Re: [Qemu-devel] [PATCH 01/16] target-m68k: add bkpt instruction

2016-10-26 Thread Richard Henderson
On 10/26/2016 09:35 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v10 16/19] vfio: Define device_api strings

2016-10-26 Thread Kirti Wankhede
Defined device API strings. Vendor driver using mediated device framework should use corresponding string for device_api attribute. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I42d29f475f02a7132ce13297fbf2b48f1da10995 ---

[Qemu-devel] [PATCH v10 12/19] vfio_pci: Update vfio_pci to use vfio_info_add_capability()

2016-10-26 Thread Kirti Wankhede
Update msix_sparse_mmap_cap() to use vfio_info_add_capability() Update region type capability to use vfio_info_add_capability() Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I52bb28c7875a6da5a79ddad1843e6088aff58a45 ---

[Qemu-devel] [Bug 1623276] Re: qemu 2.7 / iPXE crash

2016-10-26 Thread Laszlo Ersek (Red Hat)
(In other news, Launchpad continues to suck incredibly. Did you see how it broke up "unrestricted_guest" in my previous comment?) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1623276 Title: qemu

[Qemu-devel] [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-10-26 Thread Kirti Wankhede
Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers about DMA_UNMAP. Exported two APIs vfio_register_notifier() and vfio_unregister_notifier(). Vendor driver should register notifer using these APIs. Vendor driver should use VFIO_IOMMU_NOTIFY_DMA_UNMAP action to invalidate

[Qemu-devel] [PATCH v10 13/19] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-10-26 Thread Kirti Wankhede
Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id:

[Qemu-devel] [PATCH v10 17/19] docs: Add Documentation for Mediated devices

2016-10-26 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d ---

[Qemu-devel] [PATCH v10 09/19] vfio iommu type1: Add support for mediated devices

2016-10-26 Thread Kirti Wankhede
VFIO IOMMU drivers are designed for the devices which are IOMMU capable. Mediated device only uses IOMMU APIs, the underlying hardware can be managed by an IOMMU domain. Aim of this change is: - To use most of the code of TYPE1 IOMMU driver for mediated devices - To support direct assigned device

[Qemu-devel] [PATCH v10 08/19] vfio iommu type1: Add find_iommu_group() function

2016-10-26 Thread Kirti Wankhede
Add find_iommu_group() Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I9d372f1ebe9eb01a5a21374b8a2b03f7df73601f --- drivers/vfio/vfio_iommu_type1.c | 58 - 1 file changed, 34 insertions(+), 24

[Qemu-devel] [PATCH v10 15/19] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare()

2016-10-26 Thread Kirti Wankhede
Updated vfio_platform_common.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Id87cd6b78ae901610b39bf957974baa6f40cd7b0 --- drivers/vfio/platform/vfio_platform_common.c | 31

[Qemu-devel] [PATCH v10 11/19] vfio: Introduce common function to add capabilities

2016-10-26 Thread Kirti Wankhede
Vendor driver using mediated device framework should use vfio_info_add_capability() to add capabilities. Introduced this function to reduce code duplication in vendor drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id:

[Qemu-devel] [PATCH v10 06/19] vfio iommu type1: Update arguments of vfio_lock_acct

2016-10-26 Thread Kirti Wankhede
Updated arguments of vfio_lock_acct to take task as input argument Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I5d3673cc9d3786bb436b395d5f74537f1a36da80 --- drivers/vfio/vfio_iommu_type1.c | 20 ++-- 1 file changed, 10

[Qemu-devel] [PATCH v10 07/19] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-10-26 Thread Kirti Wankhede
Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input argument. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I885fd4cd4a9f66f4ee2c1caf58267464ec239f52 --- drivers/vfio/vfio_iommu_type1.c | 25

[Qemu-devel] [PATCH v10 03/19] vfio: Rearrange functions to get vfio_group from dev

2016-10-26 Thread Kirti Wankhede
This patch rearranges functions to get vfio_group from device Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I1f93262bdbab75094bc24b087b29da35ba70c4c6 --- drivers/vfio/vfio.c | 23 --- 1 file changed, 16 insertions(+),

[Qemu-devel] [PATCH v10 05/19] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-10-26 Thread Kirti Wankhede
Added two new callback functions to struct vfio_iommu_driver_ops. Backend IOMMU module that supports pining and unpinning pages for mdev devices should provide these functions. Added APIs for pining and unpining pages to VFIO module. These calls back into backend iommu module to actually pin and

[Qemu-devel] [PATCH v10 00/19] Add Mediated device support

2016-10-26 Thread Kirti Wankhede
This series adds Mediated device support to Linux host kernel. Purpose of this series is to provide a common interface for mediated device management that can be used by different devices. This series introduces Mdev core module that creates and manages mediated devices, VFIO based driver for

[Qemu-devel] [PATCH v10 01/19] vfio: Mediated device Core driver

2016-10-26 Thread Kirti Wankhede
Design for Mediated Device Driver: Main purpose of this driver is to provide a common interface for mediated device management that can be used by different drivers of different devices. This module provides a generic interface to create the device, add it to mediated bus, add device to IOMMU

[Qemu-devel] [PATCH v10 02/19] vfio: VFIO based driver for Mediated devices

2016-10-26 Thread Kirti Wankhede
vfio_mdev driver registers with mdev core driver. mdev core driver creates mediated device and calls probe routine of vfio_mdev driver for each device. Probe routine of vfio_mdev driver adds mediated device to VFIO core module This driver forms a shim layer that pass through VFIO devices

[Qemu-devel] [PATCH v10 04/19] vfio: Common function to increment container_users

2016-10-26 Thread Kirti Wankhede
This change rearrange functions to have common function to increment container_users Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I8bdeb352bc8439b107ffd519480fd4dc238677f2 --- drivers/vfio/vfio.c | 34 +-

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-26 Thread Stefano Stabellini
On Wed, 26 Oct 2016, Wei Liu wrote: > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > On Tue, 25 Oct 2016 18:28:04 +0100 > > Wei Liu wrote: > > > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > > building if running on Xen. >

Re: [Qemu-devel] [PATCH v2] char: cadence: check baud rate generator and divider values

2016-10-26 Thread P J P
+-- On Wed, 26 Oct 2016, Alistair Francis wrote --+ | >From what I can tell I would say that any writes to the divider | register that have a value lower then 3 are ignored and the register | isn't updated. | | That way we will always have a valid value as the register is reset to 0xF. Sent a

[Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values

2016-10-26 Thread P J P
From: Prasad J Pandit The Cadence UART device emulator calculates speed by dividing the baud rate by a 'baud rate generator' & 'baud rate divider' value. The device specification defines these register values to be non-zero and within certain limits. Add checks for these

[Qemu-devel] [PATCH v2 3/3] tests: Enhance qobject output to cover partial visit

2016-10-26 Thread Eric Blake
Add a test that proves (at least when run under valgrind) that we are correctly handling allocated memory even when a visit is aborted in the middle for whatever other reason. See commit f24582d "qapi: fix double free in qmp_output_visitor_cleanup()" for a fix that was lacking testsuite exposure

[Qemu-devel] [PATCH v2 2/3] qapi: Further enhance visitor virtual walk doc example

2016-10-26 Thread Eric Blake
Markus pointed out that the example given for virtual walks did not discuss how to do a virtual walk of an alternate type. It turns out that for output, we don't need to visit an alternate (just directly visit the type that we want); and for input, visit_start_alternate() is not currently wired

[Qemu-devel] [PATCH v2 1/3] tests: Simplify expected error checking for qmp output

2016-10-26 Thread Eric Blake
Minor test cleanup noticed while writing a new test. Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster --- tests/test-qobject-output-visitor.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter

2016-10-26 Thread Eric Blake
On 10/21/2016 02:42 PM, Juan Quintela wrote: > Indicates the number of threads that we would create. By default we > create 2 threads. > > Signed-off-by: Juan Quintela > --- > @@ -1386,6 +1389,9 @@ void hmp_migrate_set_parameter(Monitor *mon, const > QDict *qdict) >

[Qemu-devel] [PATCH v2 0/3] qmp output visitor test improvement

2016-10-26 Thread Eric Blake
Well, technically qobject output visitor, but keeping the cover letter subject unchanged helps for continuity Given the threads last week with Pino's claim that we had a memory leak, and Markus' counter-claim that the proposed patch was reverting an earlier double-free fix, I ended up enhancing

Re: [Qemu-devel] [Qemu-arm] [PATCH] net: smc91c111: check packet number and data register index

2016-10-26 Thread P J P
+-- On Wed, 26 Oct 2016, Peter Maydell wrote --+ | The queue_tx function checks s->tx_fifo_len (because | it's about to put something into s->tx_fifo[]), but it | does not check anything about the values it puts into | tx_fifo[]. The do_tx function then does |packetnum = s->tx_fifo[i]; |p

[Qemu-devel] [Bug 1623276] Re: qemu 2.7 / iPXE crash

2016-10-26 Thread Laszlo Ersek (Red Hat)
(--> the rebuilt binaries should go into v2.7.1, if we agree) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1623276 Title: qemu 2.7 / iPXE crash Status in QEMU: New Bug description: I am

[Qemu-devel] [Bug 1623276] Re: qemu 2.7 / iPXE crash

2016-10-26 Thread Laszlo Ersek
The ipxe bisection is extremely helpful; can you please thank Peter Pickford in the arch tracker on our behalf? So, the culprit iPXE commit is commit 71560d185475117b10994d839afe059577e7768c Author: Michael Brown Date: Wed Apr 27 11:03:18 2016 +0100 [librm] Preserve FPU,

[Qemu-devel] [Bug 1623276] Re: qemu 2.7 / iPXE crash

2016-10-26 Thread Laszlo Ersek (Red Hat)
Gerd, do you think we should rebuild the iPXE binaries bundled with QEMU with the offending iPXE commit (71560d185475) reverted, at least until KVM gets FXSAVE emulation in big real mode? I think this would be reasonable, as that iPXE commit works around a bug in the IBM Tivoli Provisioning

[Qemu-devel] [Bug 1623276] Re: qemu 2.7 / iPXE crash

2016-10-26 Thread Laszlo Ersek (Red Hat)
We could also try changing upstream iPXE so that the FXSAVE trick is not active for CONFIG=qemu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1623276 Title: qemu 2.7 / iPXE crash Status in QEMU:

[Qemu-devel] [Bug 1623276] Re: qemu 2.7 / iPXE crash

2016-10-26 Thread Laszlo Ersek
(In retrospect, the QEMU code dump "<0f> ae 06 d0 1c" is also a match.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1623276 Title: qemu 2.7 / iPXE crash Status in QEMU: New Bug description:

[Qemu-devel] [PATCH v3] net: smc91c111: check packet number and data register index

2016-10-26 Thread P J P
From: Prasad J Pandit SMSC91C111 Ethernet interface emulator has registers to store 'packet number' and a 'pointer' to Tx/Rx FIFO buffer area. These two are used to derive an address to access into 'data' registers. If they are set incorrectly, they could lead to an OOB

Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code

2016-10-26 Thread Eduardo Habkost
On Wed, Oct 26, 2016 at 06:57:12PM +0100, Peter Maydell wrote: > On 26 October 2016 at 17:57, Eduardo Habkost wrote: > > On Wed, Oct 26, 2016 at 05:48:03PM +0100, Peter Maydell wrote: > >> On 26 October 2016 at 17:30, Eduardo Habkost wrote: > >> > The

[Qemu-devel] [PATCH 4/4] e1000e: Rename "subsys_ven" property to "subsys-vendor"

2016-10-26 Thread Eduardo Habkost
Follow the usual QOM property naming style, and make the property name clearer. This breaks command-line compatibility, but I am assuming the property is not being used in production by anybody. Signed-off-by: Eduardo Habkost --- hw/net/e1000e.c | 9 - 1 file

[Qemu-devel] [PATCH 3/4] e1000e: Rename "disable_vnet_hdr" property to "vnet"

2016-10-26 Thread Eduardo Habkost
The original commit that introduced e1000e (6f3fbe4e) mentioned a property called "vnet". The actual property name added by the patch is "disable_vnet_hdr". Rename the property so that: 1) we avoid confusing double-negatives like "disable_vnet_hdr=false"; 2) we avoid underscores in property

[Qemu-devel] [PATCH 1/4] e1000e: Use regular DEFINE_PROP_ macros for properties

2016-10-26 Thread Eduardo Habkost
Instead of hacking custom PropertyInfo structs, use the regular DEFINE_PROP_ macros for the e1000e properties. This also fixes a bug in the disable_vnet_hdr property definition, that was using qdev_prop_uint8 for a bool field. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH 0/4] e1000e: QOM property & configuration cleanups

2016-10-26 Thread Eduardo Habkost
This changes some of the QOM property code in e1000e so it uses regular property type macros, and the usual QOM property naming style. This also removes unnecessary configuration validation on migration/loadvm. Some of the patches break command-line compatibility, but I am assuming those

[Qemu-devel] [PATCH 2/4] e1000e: No need to validate configuration on migration

2016-10-26 Thread Eduardo Habkost
The user (or management software) is responsible for keeping the same configuration on both sides while migrating. Remove the configuration validation code at e1000e_post_load, and the unnecessary subsys_used/subsys_ven_used fields. Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [PATCH 13/13] migration: flush receive queue

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > From: Juan Quintela > > Each time that we sync the bitmap, it is a possiblity that we receive > a page that is being processed by a different thread. We fix this > problem just making sure that we wait for all receiving threads

[Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for z900

2016-10-26 Thread Richard Henderson
The LT instruction was added in the extended immediate facility introduced with the z9-109 processor. Cc: Riku Voipio Reported-by: Michael Tokarev Fixes: c9bc3437a905b660561a26cd4ecc64579843267b Suggested-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH 12/13] migration: [HACK]Transfer pages over new channels

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We switch for sending the page number to send real pages. > > [HACK] > How we calculate the bandwidth is beyond repair, there is a hack there > that would work for x86 and archs that have 4kb pages. Is that a problem? Isn't it always

Re: [Qemu-devel] [PATCH v2] char: cadence: check baud rate generator and divider values

2016-10-26 Thread Alistair Francis
On Tue, Oct 25, 2016 at 11:50 PM, P J P wrote: > +-- On Tue, 25 Oct 2016, Alistair Francis wrote --+ > | I think your email crossed with Peter. Have a look at what he said. > | That should clarify everything. > > I saw, I'll mask values with 0x and 0xFF; But it's not

Re: [Qemu-devel] [PATCH 07/13] migration: create ram_multifd_page

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > The function still don't use multifd, but we have simplified > ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > counter and a new flag for this type of pages. > > Signed-off-by: Juan Quintela > --- > hmp.c

Re: [Qemu-devel] [PATCH] Makefile: Fix help text for target 'installer'

2016-10-26 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] qemu-ga: Remove stray 'q' in documentation

2016-10-26 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] s390: avoid always-true comparison in s390_pci_generate_fid()

2016-10-26 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 05/13] migration: create multifd migration threads

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Creation of the threads, nothing inside yet. > > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 4 ++ > migration/migration.c | 6 ++ > migration/ram.c | 148 >

Re: [Qemu-devel] [PATCH] migration: Remove unneeded NULL check from migrate_fd_error()

2016-10-26 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 04/13] migration: Create x-multifd-threads parameter

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Indicates the number of threads that we would create. By default we > create 2 threads. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > hmp.c | 7

Re: [Qemu-devel] [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-10-26 Thread Dave Hansen
On 10/26/2016 03:13 AM, Li, Liang Z wrote: > 3 times memory required is not accurate, please ignore this. sorry ... > The complexity is the point. What is making it so complex? Can you describe the problems?

Re: [Qemu-devel] [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-10-26 Thread Dave Hansen
On 10/26/2016 03:06 AM, Li, Liang Z wrote: > I am working on Dave's new bitmap schema, I have finished the part of > getting the 'hybrid scheme bitmap' and found the complexity was more > than I expected. The main issue is more memory is required to save > the 'hybrid scheme bitmap' beside that

Re: [Qemu-devel] [PATCH 01/13] migration: create Migration Incoming State at init time

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 - > migration/migration.c | 38 +- > migration/savevm.c| 4 ++-- > 3 files changed, 19

Re: [Qemu-devel] [PATCH 03/13] migration: Add multifd capability

2016-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 + > migration/migration.c | 9 + > qapi-schema.json | 5 +++-- > 3

[Qemu-devel] configure diagnostic pragma check, clang (was: Re: [PULL 00/35] cmpxchg atomic operations)

2016-10-26 Thread Peter Maydell
On 24 October 2016 at 19:02, Peter Maydell wrote: > On 24 October 2016 at 18:27, Richard Henderson wrote: >> Bah. Annoyingly, even though I didn't configure with --disable-werror, I >> only >> got the warning from clang, which of course flashed by

Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code

2016-10-26 Thread Peter Maydell
On 26 October 2016 at 17:57, Eduardo Habkost wrote: > On Wed, Oct 26, 2016 at 05:48:03PM +0100, Peter Maydell wrote: >> On 26 October 2016 at 17:30, Eduardo Habkost wrote: >> > The only remaining user of object_class_property_add() is >> >

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-26 Thread Michael Tokarev
19.10.2016 20:24, Richard Henderson wrote: > On 10/18/2016 03:17 PM, Aurelien Jarno wrote: >> Actually gcc suggests to use icm %r0,15,0(%r8). It's even shorter than >> lt %r0,0(%r8). > > Yep, that works too. So what's the final patch for this, if any? :) Or should I just use extra -march?

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 10:09 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/26/2016 09:53 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: >

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v7 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 05:29 AM, Halil Pasic wrote: > > > On 10/22/2016 12:52 AM, Jianjun Duan wrote: >> +#define RAW_FIELD(base, offset) >>\ >> +((char *) (base) + offset) >> + > > Seems you partially adopted Paolo's suggestion for improving

Re: [Qemu-devel] [PATCH v12 10/19] block: Add QMP support for streaming to an intermediate layer

2016-10-26 Thread Alberto Garcia
On Wed 26 Oct 2016 04:58:00 PM CEST, Kevin Wolf wrote: > Am 26.10.2016 um 12:29 hat Alberto Garcia geschrieben: >> This patch makes the 'device' parameter of the 'block-stream' command >> accept a node name that is not a root node. >> >> In addition to that, operation blockers

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such structures. We created

Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code

2016-10-26 Thread Eduardo Habkost
On Wed, Oct 26, 2016 at 05:48:03PM +0100, Peter Maydell wrote: > On 26 October 2016 at 17:30, Eduardo Habkost wrote: > > The only remaining user of object_class_property_add() is > > arm_cpu_post_init(), but removing it may take some work. While we > > don't change it, warn

Re: [Qemu-devel] [QEMU PATCH v8 3/3] tests/migration: Add test for QTAILQ migration

2016-10-26 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > Add a test for QTAILQ migration to tests/test-vmstate.c. > > Signed-off-by: Jianjun Duan > --- > tests/test-vmstate.c | 160 > +++ > 1 file changed, 160 insertions(+) >

[Qemu-devel] [PATCH] 9pfs: limit xattr size in xattrcreate

2016-10-26 Thread Greg Kurz
We shouldn't allow guests to create extended attribute with arbitrary sizes. On linux hosts, the limit is XATTR_SIZE_MAX. Let's use it. Also, since the 9P protocol uses signed integers, we take care of not converting a negative value into an insanely great size. Signed-off-by: Greg Kurz

[Qemu-devel] [PATCH 16/16] target-m68k: immediate ops manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 57 ++--- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c

[Qemu-devel] [PATCH 05/16] target-m68k: Inline addx, subx, negx

2016-10-26 Thread Laurent Vivier
From: Richard Henderson And add opcodes for 680x0 Signed-off-by: Laurent Vivier --- target-m68k/helper.c| 40 -- target-m68k/helper.h| 2 - target-m68k/translate.c | 196 +++- 3 files changed,

[Qemu-devel] [PATCH 12/16] target-m68k: introduce byte and word cc_ops

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/cpu.h | 6 +-- target-m68k/helper.c| 25 ++--- target-m68k/translate.c | 131 +++- 3 files changed, 93 insertions(+), 69 deletions(-) diff --git a/target-m68k/cpu.h

[Qemu-devel] [PATCH 11/16] target-m68k: some bit ops cleanup

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > > > On 10/26/2016 09:53 AM, Dr. David Alan Gilbert wrote: > > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: > >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >

[Qemu-devel] [PATCH 13/16] target-m68k: add addressing modes to neg

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 27bde2e..383709d 100644

[Qemu-devel] [PATCH 04/16] target-m68k: add scc/dbcc

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 65 ++--- 1 file changed, 45 insertions(+), 20 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index a07b6f5..05efd29 100644 ---

Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code

2016-10-26 Thread Peter Maydell
On 26 October 2016 at 17:30, Eduardo Habkost wrote: > The only remaining user of object_class_property_add() is > arm_cpu_post_init(), but removing it may take some work. While we > don't change it, warn people to not use the function in new code. This is about the third

[Qemu-devel] [PATCH 14/16] target-m68k: add/sub manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 73 +++-- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c

[Qemu-devel] [PATCH 03/16] target-m68k: add exg ops

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 41 + 1 file changed, 41 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 0d3111d..a07b6f5 100644 --- a/target-m68k/translate.c +++

[Qemu-devel] [PATCH 15/16] target-m68k: cmp manages word and bytes operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 3659b9f..1685abb 100644

[Qemu-devel] [PATCH 08/16] target-m68k: or can manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 985bc58..41994b3 100644 ---

[Qemu-devel] [PATCH 06/16] target-m68k: add addressing modes to not

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 59d7017..76432b4 100644 ---

[Qemu-devel] [PATCH 00/16] 680x0 instruction set, part 1

2016-10-26 Thread Laurent Vivier
This series is another subset of the series I sent in May: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00501.html It must be applied on top of series: "target-m68k: prepare to introduce 680x0 instruction set" This subset contains: - all the patches reviewed by Richard that needed no

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 09:53 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: Currently we cannot directly transfer a QTAILQ instance because of the

[Qemu-devel] [PATCH 01/16] target-m68k: add bkpt instruction

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 6c6173a..a128b67 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -1639,6 +1639,11

[Qemu-devel] [PATCH v3 6/8] qom: object_class_property_iter_init() function

2016-10-26 Thread Eduardo Habkost
The new function will allow us to iterate over class properties using the same logic we use for object properties. Unit test included. Signed-off-by: Eduardo Habkost --- include/qom/object.h | 14 ++ qom/object.c | 11 +--

[Qemu-devel] [PATCH 09/16] target-m68k: and can manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 41994b3..28c6d93 100644 ---

[Qemu-devel] [PATCH 10/16] target-m68k: suba/adda can manage word operand

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 28c6d93..557f671 100644 ---

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > > > On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: > > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > >> Currently we cannot directly transfer a QTAILQ instance because of the > >> limitation in the migration code. Here we introduce

[Qemu-devel] [PATCH v3 4/8] qdev: Extract property-default code to qdev_property_set_to_default()

2016-10-26 Thread Eduardo Habkost
The code that registers qdev properties will be split from the code that initializes default values on instance_init, so move it to a separate function. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- hw/core/qdev.c | 41

[Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code

2016-10-26 Thread Eduardo Habkost
The only remaining user of object_class_property_add() is arm_cpu_post_init(), but removing it may take some work. While we don't change it, warn people to not use the function in new code. Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH v3 0/8] qdev class properties + abstract class support on device-list-properties

2016-10-26 Thread Eduardo Habkost
This series allows abstract classes to be used on device-list-properties, which will return all class properties registered for the class. Changes v2 -> v3: * Small alignment fix in patch 3/6 * Included patches from "tests: A few check-qom-proplist fixes" in the series * Rebased to latest

[Qemu-devel] [PATCH 07/16] target-m68k: eor can manage word and byte operands

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 76432b4..985bc58 100644 ---

[Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property

2016-10-26 Thread Eduardo Habkost
The object_property_add_bool() call in dummy_init() is always failing because there is an existing "bv" class property. We need to remove either the "bv" class property or the "bv" instance property. Remove the class property so both object properties and class properties are covered by the test

[Qemu-devel] [PULL v2 34/37] linux-user: remove handling of aarch64's EXCP_STREX

2016-10-26 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-30-git-send-email-c...@braap.org> ---

[Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

2016-10-26 Thread Eduardo Habkost
Instead of registering qdev static properties on instance_init, register them as class properties, at qdev_class_set_props(). qdev_property_add_legacy() was replaced by an equivalent qdev_class_property_add_legacy() function. qdev_property_add_static(), on the other hand, can't be eliminated yet

[Qemu-devel] [PATCH 02/16] target-m68k: add linkl

2016-10-26 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index a128b67..0d3111d

[Qemu-devel] [PULL v2 35/37] target-arm: remove EXCP_STREX + cpu_exclusive_{test, info}

2016-10-26 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore; remove it and the associated TCG variables. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id:

[Qemu-devel] [PULL v2 33/37] linux-user: remove handling of ARM's EXCP_STREX

2016-10-26 Thread Richard Henderson
From: "Emilio G. Cota" The exception is not emitted anymore. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson Message-Id: <1467054136-10430-29-git-send-email-c...@braap.org> ---

[Qemu-devel] [PATCH v3 2/8] tests: check-qom-proplist: Use _abort to catch errors

2016-10-26 Thread Eduardo Habkost
Use _abort so we don't ignore any errors on the property registration calls. Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- tests/check-qom-proplist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [ANNOUNCE] SeaBIOS 1.10.0

2016-10-26 Thread Kevin O'Connor
The 1.10.0 version of SeaBIOS has now been released. For more information on the release, please see: http://seabios.org/Releases New in this release: * Initial support for Trusted Platform Module (TPM) version 2.0 * Several USB XHCI timing fixes on real hardware * Support for "LSI MPT

[Qemu-devel] [PULL v2 31/37] target-arm: emulate SWP with atomic_xchg helper

2016-10-26 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <1467054136-10430-25-git-send-email-c...@braap.org> Signed-off-by: Richard Henderson --- target-arm/translate.c | 26 ++ 1 file changed, 14 insertions(+),

[Qemu-devel] [PULL v2 30/37] target-arm: emulate LL/SC using cmpxchg helpers

2016-10-26 Thread Richard Henderson
From: "Emilio G. Cota" Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. Portable parallel code, however, is written assuming only cmpxchg--and not LL/SC--is available. This means that in practice emulating LL/SC with cmpxchg is a viable

[Qemu-devel] [PULL v2 37/37] target-alpha: Emulate LL/SC using cmpxchg helpers

2016-10-26 Thread Richard Henderson
Emulating LL/SC with cmpxchg is not correct, since it can suffer from the ABA problem. However, portable parallel code is written assuming only cmpxchg which means that in practice this is a viable alternative. Signed-off-by: Richard Henderson --- linux-user/main.c|

<    1   2   3   4   5   6   >