Re: [Qemu-devel] [PATCH v1] vhost-pci-net: design vhost-pci-net for the transmission of network packets between VMs

On Monday, October 24, 2016 3:09 PM, Wei Wang wrote: > To: virtio-comm...@lists.oasis-open.org; qemu-devel@nongnu.org; > m...@redhat.com; marcandre.lur...@gmail.com; stefa...@redhat.com; > pbonz...@redhat.com > Cc: Wang, Wei W > Subject: [PATCH v1] vhost-pci-net: design

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

On Tue, Nov 01, 2016 at 03:22:01PM +, Peter Maydell wrote: > On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: > > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1'

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

On 02/11/16 14:29, Kirti Wankhede wrote: > > > On 11/2/2016 6:54 AM, Alexey Kardashevskiy wrote: >> On 02/11/16 01:01, Kirti Wankhede wrote: >>> >>> >>> On 10/28/2016 7:48 AM, Alexey Kardashevskiy wrote: On 27/10/16 23:31, Kirti Wankhede wrote: > > > On 10/27/2016 12:50 PM,

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

On 11/2/2016 6:54 AM, Alexey Kardashevskiy wrote: > On 02/11/16 01:01, Kirti Wankhede wrote: >> >> >> On 10/28/2016 7:48 AM, Alexey Kardashevskiy wrote: >>> On 27/10/16 23:31, Kirti Wankhede wrote: On 10/27/2016 12:50 PM, Alexey Kardashevskiy wrote: > On 18/10/16 08:22, Kirti

Re: [Qemu-devel] How to print value of float instruction argument

On Oct 31, 2016, at 4:39 AM, Peter Maydell wrote: > On 31 October 2016 at 03:13, Programmingkid wrote: >> I'm trying to print the value of the arguments sent to >> gen_fmadds() in target-ppc/translate/fp-impl.inc.c. How >> do I do this? I have tried

Re: [Qemu-devel] [PATCH 1/1] net: skip virtio-net config of deleted nic's peers

On 2016年11月01日 06:42, Michael S. Tsirkin wrote: On Tue, Nov 01, 2016 at 12:01:17AM +0200, yuri.benditov...@daynix.com wrote: From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1373816 qemu core dump happens during repetitive unpug-plug with

Re: [Qemu-devel] [PATCH v2 3/3] hostmem-file: make option 'size' optional

On 10/31/16 16:18 -0200, Eduardo Habkost wrote: On Fri, Oct 28, 2016 at 10:06:40AM +0800, Haozhong Zhang wrote: [...] > > diff --git a/exec.c b/exec.c > > index 264a25f..89065bd 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -1234,7 +1234,7 @@ static int64_t get_file_size(int fd) > > } > > >

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

On 11/02/2016 01:52 AM, Eric Blake wrote: On 11/01/2016 12:19 PM, Stefan Weil wrote: Fix also some indefinite articles. Signed-off-by: Stefan Weil --- I still don't understand the comment in docs/colo-proxy.txt. Me neither. Which part of the docs/colo-proxy.txt?

Re: [Qemu-devel] [PULL 08/27] hostmem-file: make option 'size' optional

On 11/01/16 12:16 -0200, Eduardo Habkost wrote: On Tue, Nov 01, 2016 at 05:32:20PM +0800, Haozhong Zhang wrote: On 10/31/16 20:22 -0200, Eduardo Habkost wrote: > On Mon, Oct 31, 2016 at 03:47:53PM -0400, Paolo Bonzini wrote: > > > > > > - Original Message - > > > From: "Eduardo Habkost"

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

On 02/11/16 01:01, Kirti Wankhede wrote: > > > On 10/28/2016 7:48 AM, Alexey Kardashevskiy wrote: >> On 27/10/16 23:31, Kirti Wankhede wrote: >>> >>> >>> On 10/27/2016 12:50 PM, Alexey Kardashevskiy wrote: On 18/10/16 08:22, Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Michael S. Tsirkin > Sent: Wednesday, November 02, 2016 1:26 AM > To: Peter Maydell > Cc: QEMU Developers > Subject: Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and

[Qemu-devel] [RESEND PATCH v2 2/3] exec.c: check memory backend file size with 'size' option

If the memory backend file is not large enough to hold the required 'size', Qemu will report error and exit. Signed-off-by: Haozhong Zhang Message-Id: <20161027042300.5929-3-haozhong.zh...@intel.com> Reviewed-by: Eduardo Habkost --- Changes in

Re: [Qemu-devel] [PATCH v10 00/19] Add Mediated device support

On 11/01/2016 11:24 PM, Gerd Hoffmann wrote: >> I rebased KVMGT upon v10, with 2 minor changes: >> >> 1, get_user_pages_remote has only 7 args > > Appears to be a 4.9 merge window change. v10 as-is applies and builds > fine against 4.8, after rebasing to 4.9-rc3 it stops building due to >

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On Tue, 1 Nov 2016, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 05:44:16PM +, Wei Liu wrote: > > Introduce this field to control whether ACPI build is enabled by a > > particular machine or accelerator. > > > > It defaults to true if the machine itself supports ACPI build. Xen > >

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 05:44:16PM +, Wei Liu wrote: > Introduce this field to control whether ACPI build is enabled by a > particular machine or accelerator. > > It defaults to true if the machine itself supports ACPI build. Xen > accelerator will disable it because Xen is in charge of

Re: [Qemu-devel] [PATCH 00/15] optimize Qemu RSS usage

On 10/31/2016 05:00 PM, Michael R. Hines wrote: On 10/18/2016 05:47 AM, Peter Lieven wrote: Am 12.10.2016 um 23:18 schrieb Michael R. Hines: Peter, Greetings from DigitalOcean. We're experiencing the same symptoms without this patch. We have, collectively, many gigabytes of un-planned-for

[Qemu-devel] [PATCH 4/4] target-m68k: Use gen_ea_mode in cmpm

The writeback infrastructure takes care of ensuring that Ax == Ay both uses the updated register value from Ay for Ax, and updating the final register result twice. ??? Maybe squash into previous. Signed-off-by: Richard Henderson --- target-m68k/translate.c | 28

[Qemu-devel] [PATCH 3/4] target-m68k: add cmpm

From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <1477604609-2206-2-git-send-email-laur...@vivier.eu> Signed-off-by: Richard Henderson --- target-m68k/translate.c | 28

[Qemu-devel] [PATCH 1/4] target-m68k: Delay autoinc writeback

Signed-off-by: Richard Henderson --- target-m68k/translate.c | 83 + 1 file changed, 63 insertions(+), 20 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 9ad974f..f812c4b 100644 ---

[Qemu-devel] [PATCH 0/4] target-m68k areg writeback

Here's the patch I almost wrote in the email, followed by a cleanup that allows cmpm to be written "nicely". I can test this to some extent with the coldfire kernel, but of course coldfire can't excersise any of the tricky edge cases that m68000 can. I'm particularly interested in edge cases

[Qemu-devel] [PATCH 2/4] target-m68k: Split gen_lea and gen_ea

Provide gen_lea_mode and gen_ea_mode, where the mode can be specified manually, rather than taken from the instruction. Signed-off-by: Richard Henderson --- target-m68k/translate.c | 112 +--- 1 file changed, 59 insertions(+), 53

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

On 1 November 2016 at 19:21, Richard Henderson wrote: > On 11/01/2016 12:17 PM, Peter Maydell wrote: >> On 1 November 2016 at 17:51, Richard Henderson wrote: >>> >>> The usual pain point for me is building for 32-bit on a 64-bit >>> system, where there is no

Re: [Qemu-devel] [PATCH v4 2/2] target-m68k: add 680x0 divu/divs variants

On 11/01/2016 02:03 PM, Laurent Vivier wrote: Update helper to set the throwing location in case of div-by-0. Cleanup divX.w and add quad word variants of divX.l. Signed-off-by: Laurent Vivier --- linux-user/main.c | 7 ++ target-m68k/cpu.h | 4 --

Re: [Qemu-devel] [PATCH] atomic.h: Use __atomic_load_n() primitive

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] atomic.h: Use __atomic_load_n() primitive Message-id: 20161101203953.18065-1-bobby.pr...@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] atomic.h: Use __atomic_load_n() primitive

Use __atomic_load_n() primitive saving a load and store to a local variable. Signed-off-by: Pranith Kumar --- include/qemu/atomic.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h

[Qemu-devel] [Bug 1629618] Re: QEMU causes host hang / reset on PPC64EL

Unfortunately, the machine just crashed again. It seems related to the use of 4K pages instead of the more typical 64K pages; the machine is rock solid with 64K pages. ** Changed in: qemu Status: Fix Released => New -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [PATCH v4 1/2] target-m68k: add 64bit mull

Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 62 +++-- 1 file changed, 50 insertions(+), 12 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c

[Qemu-devel] [PATCH v4 2/2] target-m68k: add 680x0 divu/divs variants

Update helper to set the throwing location in case of div-by-0. Cleanup divX.w and add quad word variants of divX.l. Signed-off-by: Laurent Vivier --- linux-user/main.c | 7 ++ target-m68k/cpu.h | 4 -- target-m68k/helper.h| 8 ++-

[Qemu-devel] [PATCH v4 0/2] 680x0 mul and div instructions

This series is another subset of the series I sent in May: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00501.html It must be applied on top of series: "target-m68k: 680x0 instruction set, part 2" This subset contains reworked patches of mul and div instructions: - "add 64bit mull":

Re: [Qemu-devel] [PATCH v2 1/3] target-m68k: add cmpm

Le 01/11/2016 à 18:48, Richard Henderson a écrit : > On 10/27/2016 03:43 PM, Laurent Vivier wrote: >> +DISAS_INSN(cmpm) >> +{ >> +int opsize = insn_opsize(insn); >> +TCGv tmp = tcg_temp_new(); >> +TCGv src, dst, addr; >> + >> +src = gen_load(s, opsize, AREG(insn, 0), 1); >> +

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On Tue, 1 Nov 2016, Wei Liu wrote: > Introduce this field to control whether ACPI build is enabled by a > particular machine or accelerator. > > It defaults to true if the machine itself supports ACPI build. Xen > accelerator will disable it because Xen is in charge of building ACPI > tables for

Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over nucleus mode

On 11/01/2016 12:12 PM, Artyom Tarasenko wrote: While playing with your patch set, I discovered that we also need a patch to get_asi for ASI_N et al to retain MMU_HYPV_IDX, and not decrease privilege. This happens *very* early in the prom boot, with the first casx (when casx is implemented

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

On 11/01/2016 12:17 PM, Peter Maydell wrote: On 1 November 2016 at 17:51, Richard Henderson wrote: The usual pain point for me is building for 32-bit on a 64-bit system, where there is no cross-prefix that one can use, and PKG_CONFIG_PATH and --extra-cflags are the only

Re: [Qemu-devel] [PATCH] arm-smmu: Fix bug when merging two 32 bit words to form 64 bit word

> -Original Message- > From: Edgar E. Iglesias [mailto:edgar.igles...@xilinx.com] > Sent: Monday, 26 September 2016 7:56 AM > To: Paul Kennedy > Cc: qemu-devel@nongnu.org; Alistair Francis ; qemu- > triv...@nongnu.org > Subject: Re: [PATCH]

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On 2016-11-01 18:44, Wei Liu wrote: Introduce this field to control whether ACPI build is enabled by a particular machine or accelerator. It defaults to true if the machine itself supports ACPI build. Xen accelerator will disable it because Xen is in charge of building ACPI tables for the

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

On 1 November 2016 at 17:51, Richard Henderson wrote: > The usual pain point for me is building for 32-bit on a 64-bit > system, where there is no cross-prefix that one can use, and > PKG_CONFIG_PATH and --extra-cflags are the only changes. That sounds like a bug in how the

Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over nucleus mode

On Wed, Oct 12, 2016 at 3:29 PM, Richard Henderson wrote: > On 10/12/2016 06:33 AM, Artyom Tarasenko wrote: >> >> On Mon, Oct 10, 2016 at 11:41 PM, Richard Henderson >> wrote: >>> >>> On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:

Re: [Qemu-devel] [PATCH v3 4/4] pc: memhp: enable nvdimm device hotplug

On Sat, Oct 29, 2016 at 12:35:40AM +0800, Xiao Guangrong wrote: > _GPE.E04 is dedicated for nvdimm device hotplug > > Signed-off-by: Xiao Guangrong > --- > docs/specs/acpi_mem_hotplug.txt | 3 +++ > hw/acpi/memory_hotplug.c | 31

Re: [Qemu-devel] [RFC 1/2] linux-headers: update

On 1 November 2016 at 18:13, Alexander Graf wrote: > On 01/11/2016 11:19, Peter Maydell wrote: >> Is there a cover letter email for this series ? > > > I figured that the set is so small that it didn't deserve one :). The usual rule is "one patch: no cover letter; more than one

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

On Tue, Nov 01, 2016 at 04:26:57PM +, Peter Maydell wrote: > On 1 November 2016 at 16:20, Daniel P. Berrange wrote: > > On Tue, Nov 01, 2016 at 09:34:24AM -0600, Richard Henderson wrote: > >> On 11/01/2016 06:07 AM, Richard Henderson wrote: > >> > V2, now with more

Re: [Qemu-devel] [RFC 1/2] linux-headers: update

On 01/11/2016 11:19, Peter Maydell wrote: On 29 October 2016 at 22:10, Alexander Graf wrote: This patch updates the Linux headers to include the in-progress user space ARM timer patches. It is explicitly RFC, as the patches are not merged yet. --- Is there a cover letter

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

On 1 November 2016 at 17:19, Stefan Weil wrote: > Fix also some indefinite articles. > > Signed-off-by: Stefan Weil > --- > > I still don't understand the comment in docs/colo-proxy.txt. > diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt > index

[Qemu-devel] when we add EL2 to QEMU TCG ARM emulation and the virt board, should it default on or off?

I'm working on turning on EL2 support in our TCG ARM emulation, and one area I'm not sure about is whether it should default to on or off. We have a few precedents: For EL3 support: * the CPU property is enabled by default but can be disabled by the board * 'virt' defaults it to disabled, with

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > [...] > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int > > running, > > > > static int xen_init(MachineState *ms) > > { > > +

Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31

On 1 November 2016 at 16:29, Paolo Bonzini wrote: > The following changes since commit 39542105bbb19c690219d2f22844d8dfbd9bba05: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2016-11-01 12:48:07 +) > > are available in the git

Re: [Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

On 11/01/2016 07:29 AM, Prasanna Kumar Kalever wrote: > Document: > 1. The new debug and logfile options with their usages and > 2. New json format and its usage. > > Signed-off-by: Prasanna Kumar Kalever > --- > qemu-doc.texi | 46

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

On 11/01/2016 12:19 PM, Stefan Weil wrote: > Fix also some indefinite articles. > > Signed-off-by: Stefan Weil > --- > > I still don't understand the comment in docs/colo-proxy.txt. Me neither. > +++ b/docs/colo-proxy.txt > @@ -158,7 +158,7 @@ secondary. > > == Usage ==

Re: [Qemu-devel] [PATCH v2 1/3] target-m68k: add cmpm

On 10/27/2016 03:43 PM, Laurent Vivier wrote: +DISAS_INSN(cmpm) +{ +int opsize = insn_opsize(insn); +TCGv tmp = tcg_temp_new(); +TCGv src, dst, addr; + +src = gen_load(s, opsize, AREG(insn, 0), 1); +/* delay the update after the second gen_load() */ +tcg_gen_addi_i32(tmp,

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

On 11/01/2016 11:43 AM, Daniel P. Berrange wrote: It was a particular pain-point for me when doing mingw builds, where I would typically use 'PKG_CONFIG_PATH=/blah ./configure' so that I didn't permanently pollute my shell with mingw32 pkg-config env The usual pain point for me is building for

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: [...] > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int > running, > > static int xen_init(MachineState *ms) > { > +PCMachineState *pcms = PC_MACHINE(ms); > + > +/* Disable ACPI build because Xen

Re: [Qemu-devel] [PATCH v3 3/4] nvdimm acpi: introduce _FIT

On Sat, Oct 29, 2016 at 12:35:39AM +0800, Xiao Guangrong wrote: > +1) Read FIT > + As we only reserved one page for NVDIMM ACPI it is impossible to map the > + whole FIT data to guest's address space. This function is used by _FIT > + method to read a piece of FIT data from QEMU. > + > +

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > Introduce this field to control whether ACPI build is enabled by a > particular machine or accelerator. > > It defaults to true so that PC machine has ACPI build by default. Xen > accelerator will disable it because Xen is in charge of

[Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

Introduce this field to control whether ACPI build is enabled by a particular machine or accelerator. It defaults to true if the machine itself supports ACPI build. Xen accelerator will disable it because Xen is in charge of building ACPI tables for the guest. Signed-off-by: Wei Liu

Re: [Qemu-devel] [PULL v3 for-2.8 0/9] tcg queued patches

> > > The following changes since commit c46ef897dbb75590af94b6e3dca6a9c5f9a1ea1e: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2016-11-01 14:27:05 +) > > are available in the git repository at: > > git://github.com/rth76

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 05:12:37PM +, Wei Liu wrote: > On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote: > > On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > > [...] > > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, > > > int running, > > >

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

On Tue, Nov 01, 2016 at 03:22:01PM +, Peter Maydell wrote: > On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: > > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1'

[Qemu-devel] [PULL v3 for-2.8 0/9] tcg queued patches

'remotes/cody/tags/block-pull-request' into staging (2016-11-01 14:27:05 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20161101-2 for you to fetch changes up to 3ff91d7e85176f8b4b131163d7fd801757a2c949: tcg: correct 32-bit tcg_gen_ld8s_i64 sign

Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31 Message-id: 1478017783-7703-1-git-send-email-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

On 1 November 2016 at 17:25, Michael S. Tsirkin wrote: > A general question - I have a couple of tweaks to tests in > my tree. Didn't push to avoid them blocking the features. > I think test tweaks are fair game after freeze - agree? Yes, especially if they're only tweaks, not

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

On 11/01/2016 08:26 AM, Peter Maydell wrote: i686-w64-mingw32 builds fail to link :-( exec.o: In function `qemu_flockfile': /home/petmay01/linaro/qemu-for-merges/include/sysemu/os-win32.h:110: undefined reference to `_imp___lock_file' exec.o: In function `qemu_funlockfile':

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

On Tue, Nov 01, 2016 at 09:52:59AM -0700, ashish mittal wrote: > Done! > > All builds are fine, but I have no way of knowing if that fixed the > issue! Please let me know if you still see a problem. configure works for me after pulling your libqnio update Regards, Daniel -- |:

[Qemu-devel] [PULL 25/30] slirp: fix CharDriver breakage

SLIRP expects a CharBackend as the third argument to slirp_add_exec, but net/slirp.c was passing a CharDriverState. Fix this to restore guestfwd functionality. Reported-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- net/slirp.c | 3 +-- 1

[Qemu-devel] [PATCH] hw/block/m25p80: Fix typo in local macro name

Signed-off-by: Stefan Weil --- hw/block/m25p80.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index d29ff4c..09ea51f 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -121,7 +121,7 @@ typedef struct

[Qemu-devel] [PATCH] docs: Fix typos found by codespell

Fix also some indefinite articles. Signed-off-by: Stefan Weil --- I still don't understand the comment in docs/colo-proxy.txt. Stefan docs/COLO-FT.txt| 2 +- docs/colo-proxy.txt | 2 +- qemu-doc.texi | 2 +- qemu-options.hx | 2 +- 4 files changed, 4

[Qemu-devel] [PULL 20/30] nbd: Refactor conversion to errno to silence checkpatch

From: Eric Blake Checkpatch complains that 'return EINVAL' is usually wrong (since we tend to favor 'return -EINVAL'). But it is a false positive for nbd_errno_to_system_errno(). Since NBD may add future defined wire values, refactor the code to keep checkpatch happy.

[Qemu-devel] [PULL v3 for-2.8 4/9] log: Add locking to large logging blocks

Reuse the existing locking provided by stdio to keep in_asm, cpu, op, op_opt, op_ind, and out_asm as contiguous blocks. While it isn't possible to interleave e.g. in_asm or op_opt logs because of the TB lock protecting all code generation, it is possible to interleave cpu logs, or to interleave a

[Qemu-devel] [PULL 18/30] nbd: Less allocation during NBD_OPT_LIST

From: Eric Blake Since we know that the maximum name we are willing to accept is small enough to stack-allocate, rework the iteration over NBD_OPT_LIST responses to reuse a stack buffer rather than allocating every time. Furthermore, we don't even have to allocate if we know

[Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

Introduce this field to control whether ACPI build is enabled by a particular machine or accelerator. It defaults to true so that PC machine has ACPI build by default. Xen accelerator will disable it because Xen is in charge of building ACPI tables for the guest. Signed-off-by: Wei Liu

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 02:59:25PM -0200, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote: > > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: > > [...] > > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error > > > > **errp) > >

[Qemu-devel] [PULL 30/30] main-loop: Suppress I/O thread warning under qtest

From: Max Reitz We do not want to display the "I/O thread spun" warning for test cases that run under qtest. The first attempt for this (commit 01c22f2cdd4fcf02276ea10f48253850a5fd7259) tested whether qtest_enabled() was true. Commit 21a24302e85024dd7b2a151158adbc1f5dc5c4dd

[Qemu-devel] [PULL 15/30] nbd: Share common option-sending code in client

From: Eric Blake Rather than open-coding each option request, it's easier to have common helper functions do the work. That in turn requires having convenient packed types for handling option requests and replies. Signed-off-by: Eric Blake Message-Id:

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote: > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: > [...] > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > > { > > > PCMachineState *pcms = PC_MACHINE(obj); > > > @@ -2159,6 +2173,8

[Qemu-devel] [PULL 28/30] vl: exit qemu on guest panic if -no-shutdown is not set

From: Christian Borntraeger For automated testing purposes it can be helpful to exit qemu (poweroff) when the guest panics. Make this the default unless -no-shutdown is specified. For internal-errors like errors from KVM_RUN the behaviour is not changed, in other words

[Qemu-devel] [PULL 14/30] nbd: Send message along with server NBD_REP_ERR errors

From: Eric Blake The NBD Protocol allows us to send human-readable messages along with any NBD_REP_ERR error during option negotiation; make use of this fact for clients that know what to do with our message. Signed-off-by: Eric Blake Message-Id:

Re: [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization (AMD)

On 1 November 2016 at 16:22, wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: Fam, it looks like patchew's test script is assuming git arguments that don't exist on the git version it's trying to use: > ===

[Qemu-devel] [PULL 22/30] nbd: Implement NBD_CMD_WRITE_ZEROES on server

From: Eric Blake Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants to allow a hole. Note that when it comes to requiring full allocation, vs.

[Qemu-devel] [PULL 11/30] nbd: Rename NbdClientSession to NBDClientSession

From: Eric Blake It's better to use consistent capitalization of the namespace used for NBD functions; we have more instances of NBD* than Nbd*. Signed-off-by: Eric Blake Message-Id: <1476469998-28592-5-git-send-email-ebl...@redhat.com> Signed-off-by:

Re: [Qemu-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: [...] > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > { > > PCMachineState *pcms = PC_MACHINE(obj); > > @@ -2159,6 +2173,8 @@ static void pc_machine_initfn(Object *obj) > > pcms->vmport =

[Qemu-devel] [PULL 26/30] x86: add AVX512_4VNNIW and AVX512_4FMAPS features

From: Luwei Kang The spec can be found in Intel Software Developer Manual or in Instruction Set Extensions Programming Reference. Signed-off-by: Piotr Luc Signed-off-by: Luwei Kang Message-Id:

[Qemu-devel] [PULL 21/30] nbd: Improve server handling of shutdown requests

From: Eric Blake NBD commit 6d34500b clarified how clients and servers are supposed to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN (for the server to announce it is about to go away during option haggling, so the client should quit sending NBD_OPT_* other

[Qemu-devel] [PULL 05/30] exec.c: ensure all AddressSpaceDispatch updates under RCU

From: Alex Bennée The memory_dispatch field is meant to be protected by RCU so we should use the correct primitives when accessing it. This race was flagged up by the ThreadSanitizer. Signed-off-by: Alex Bennée Message-Id:

Re: [Qemu-devel] [PATCH v5 28/33] cputlb: make tlb_flush_by_mmuidx safe for MTTCG

Pranith Kumar writes: > On Tue, Nov 1, 2016 at 3:45 AM, Alex Bennée wrote: > >> >> Odd. I'll look into it. What was you configure string and host architecture? >> > > It's a plain configure string, nothing special: > > $ ../configure

[Qemu-devel] [PULL 23/30] nbd: Implement NBD_CMD_WRITE_ZEROES on client

From: Eric Blake Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. The generic block code takes care of falling back to the obvious write

[Qemu-devel] [PULL 16/30] nbd: Let server know when client gives up negotiation

From: Eric Blake The NBD spec says that a client should send NBD_OPT_ABORT rather than just dropping the connection, if the client doesn't like something the server sent during option negotiation. This is a best-effort attempt only, and can only be done in places where we

[Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31

The following changes since commit 39542105bbb19c690219d2f22844d8dfbd9bba05: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2016-11-01 12:48:07 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

Done! All builds are fine, but I have no way of knowing if that fixed the issue! Please let me know if you still see a problem. [root@rhel72ga-build-upstream qemu] 2016-11-01 09:46:06$ make CC block/vxhs.o LINKqemu-nbd LINKqemu-img LINKqemu-io LINK

[Qemu-devel] [PULL 19/30] nbd: Support shorter handshake

From: Eric Blake The NBD Protocol allows the server and client to mutually agree on a shorter handshake (omit the 124 bytes of reserved 0), via the server advertising NBD_FLAG_NO_ZEROES and the client acknowledging with NBD_FLAG_C_NO_ZEROES (only possible in newstyle, whether

[Qemu-devel] [PULL 09/30] nbd: Treat flags vs. command type as separate fields

From: Eric Blake Current upstream NBD documents that requests have a 16-bit flags, followed by a 16-bit type integer; although older versions mentioned only a 32-bit field with masking to find flags. Since the protocol is in network order (big-endian over the wire), the ABI

[Qemu-devel] [PULL 02/30] nbd: Use CoQueue for free_sema instead of CoMutex

From: Changlong Xie NBD is using the CoMutex in a way that wasn't anticipated. For example, if there are N(N=26, MAX_NBD_REQUESTS=16) nbd write requests, so we will invoke nbd_client_co_pwritev N times.

[Qemu-devel] [PULL 17/30] nbd: Let client skip portions of server reply

From: Eric Blake The server has a nice helper function nbd_negotiate_drop_sync() which lets it easily ignore fluff from the client (such as the payload to an unknown option request). We can't quite make it common, since it depends on nbd_negotiate_read() which handles

[Qemu-devel] [PULL 29/30] docs/rcu.txt: Fix minor typo

From: Pranith Kumar s/presented/prevented/ Signed-off-by: Pranith Kumar Message-Id: <20161018050418.4912-1-bobby.pr...@gmail.com> Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 01/30] checkpatch: tweak "struct should normally be const" warning

Avoid triggering on typedef struct BlockJobDriver BlockJobDriver; or struct BlockJobDriver { Cc: John Snow Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 10/30] nbd: Rename NBDRequest to NBDRequestData

From: Eric Blake We have both 'struct NBDRequest' and 'struct nbd_request'; making it confusing to see which does what. Furthermore, we want to rename nbd_request to align with our normal CamelCase naming conventions. So, rename the struct which is used to associate the data

[Qemu-devel] [PULL 27/30] checkpatch: allow spaces before parenthesis for 'coroutine_fn'

From: Jeff Cody Signed-off-by: Jeff Cody Message-Id: <83b0fae0728906e18849c971d22d077d7fc0f179.1478010883.git.jc...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 2 +-

[Qemu-devel] [PULL 12/30] nbd: Rename struct nbd_request and nbd_reply

From: Eric Blake Our coding convention prefers CamelCase names, and we already have other existing structs with NBDFoo naming. Let's be consistent, before later patches add even more structs. Signed-off-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 03/30] qemu-error: remove dependency of stubs on monitor

Leave the implementation of error_vprintf and error_vprintf_unless_qmp (the latter now trivially wrapped by error_printf_unless_qmp) to libqemustub.a and monitor.c. This has two advantages: it lets us remove the monitor_printf and monitor_vprintf stubs, and it lets tests provide a different

Re: [Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer

On Tue, 1 Nov 2016 23:57:55 +0800 Xiao Guangrong wrote: > On 11/01/2016 09:58 PM, Igor Mammedov wrote: > > >> > >> I mean, for example. if there are two devices, the first one is failed to > >> be > >> realized, the second one is init-ed successfully, then can >

[Qemu-devel] [PULL 24/30] qemu-char: do not forward events through the mux until QEMU has started

Otherwise, the CHR_EVENT_OPENED event is sent twice: first when the backend (for example "stdio") is opened, and second after processing the command line. The incorrect sending of the event prints the monitor banner when QEMU is started with "-serial mon:stdio". This includes the "(qemu)"

[Qemu-devel] [PULL 06/30] exec.c: do not truncate non-empty memory backend file

From: Haozhong Zhang For '-object memory-backend-file,mem-path=foo,size=xyz', if the size of file 'foo' does not match the given size 'xyz', the current QEMU will truncate the file to the given size, which may corrupt the existing data in that file. To avoid such data

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

On Tue, Nov 01, 2016 at 09:09:31AM -0700, ashish mittal wrote: > Hi Daniel, > > Thanks for pointing that out. I had done a fresh configure and make > before submitting the patch. I am somehow not able to reproduce that > error! > > Checked out fresh source just now and tried again, still no

  1   2   3   >