Re: [Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

2016-12-02 Thread Cédric Le Goater
On 12/03/2016 08:16 AM, Alexey Kardashevskiy wrote: > On 02/12/16 18:55, Cédric Le Goater wrote: >> On 12/02/2016 12:34 AM, Alexey Kardashevskiy wrote: >>> On 01/12/16 23:31, Cédric Le Goater wrote: On 12/01/2016 01:42 AM, Alastair D'Silva wrote: > On Wed, 2016-11-30 at 09:18 +0100,

Re: [Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

2016-12-02 Thread Alexey Kardashevskiy
On 02/12/16 18:55, Cédric Le Goater wrote: > On 12/02/2016 12:34 AM, Alexey Kardashevskiy wrote: >> On 01/12/16 23:31, Cédric Le Goater wrote: >>> On 12/01/2016 01:42 AM, Alastair D'Silva wrote: On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote: > On 11/30/2016 06:36 AM, Alastair

[Qemu-devel] [RFC] target-ppc/fpu_helper.c: Use C99 code to speed up floating point unit

2016-12-02 Thread Programmingkid
The floating point code used in fpu_helper.c can be sped up by using the IEEE 754 support added to the C99 standard. To test this code out simply set and unset the I_NEED_SPEED macro. The program to test out each version of the helper_fmadd() function is below the patch. It needs to be ran in

[Qemu-devel] [PATCH 6/7] target-ppc: Implement bcdtrunc. instruction

2016-12-02 Thread Jose Ricardo Ziviani
bcdtrunc.: Decimal integer truncate. Given a BCD number in vrb and the number of bytes to truncate in vra, the return register will have vrb with such bits truncated. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 +

[Qemu-devel] [PATCH 7/7] target-ppc: Implement bcdtrunc. instruction

2016-12-02 Thread Jose Ricardo Ziviani
bcdutrunc. Decimal unsigned truncate. Works like bcdtrunc. with unsigned BCD numbers. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 39 +

[Qemu-devel] [PATCH 2/7] target-ppc: Implement unsigned quadword left/right shift and unit tests

2016-12-02 Thread Jose Ricardo Ziviani
This commit implements functions to right and left shifts and the unittest for them. Such functions is needed due to instructions that requires them. Today, there is already a right shift implementation in int128.h but it's for signed numbers. Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PATCH 5/7] target-ppc: Implement bcdsr. instruction

2016-12-02 Thread Jose Ricardo Ziviani
bcdsr.: Decimal shift and round. This instruction works like bcds. however, when performing right shift, 1 will be added to the result if the last digit was >= 5. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 +

[Qemu-devel] [PATCH 0/7] POWER9 TCG enablements - BCD functions - final part

2016-12-02 Thread Jose Ricardo Ziviani
This serie contains 5 new instructions for POWER9 ISA3.0, left/right shifts for unsigned quadwords and a small improvement to check whether a bcd value is valid or not. bcds.: Decimal signed shift bcdus.: Decimal unsigned shift bcdsr.: Decimal shift and round bcdtrunc.: Decimal signed trucate

[Qemu-devel] [PATCH 1/7] target-ppc: Implement bcd_is_valid function

2016-12-02 Thread Jose Ricardo Ziviani
A function to check if all digits of a given BCD number is valid is here presented because more instructions will need to reuse the same code. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/int_helper.c | 27 --- 1 file changed, 20

[Qemu-devel] [PATCH 3/7] target-ppc: Implement bcds. instruction

2016-12-02 Thread Jose Ricardo Ziviani
bcds.: Decimal shift. Given two registers vra and vrb, this instruction shift the vrb value by vra bits into the result register. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 38

[Qemu-devel] [PATCH 4/7] target-ppc: Implement bcdus. instruction

2016-12-02 Thread Jose Ricardo Ziviani
bcdus.: Decimal unsigned shift. This instruction works like bcds. but considers only unsigned BCDs (no sign in least meaning 4 bits). Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 43

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-02 Thread Alexey Kardashevskiy
On 03/12/16 08:41, Benjamin Herrenschmidt wrote: > On Fri, 2016-12-02 at 16:50 +1100, David Gibson wrote: >> >> Uh.. I don't entirely follow you. From the host point of view there >> are multiple iommu groups (PEs), but from the guest point of view >> there's only one. On the guest side iommu

[Qemu-devel] New wiki page: http://wiki.qemu.org/Hosts

2016-12-02 Thread Programmingkid
I thought we could use a Hosts page to sort all the host documentation we have. It is located here: http://wiki.qemu.org/Hosts Here is what I have so far: AIX Darwin FreeBSD, NetBSD, OpenBSD Linux Mac OS X Solaris Windows

Re: [Qemu-devel] ARM documentation

2016-12-02 Thread Programmingkid
On Nov 30, 2016, at 9:55 PM, G 3 wrote: > > On Nov 30, 2016, at 6:58 PM, Alistair Francis wrote: > >> On Fri, Nov 18, 2016 at 4:53 PM, Programmingkid >> wrote: >>> >>> On Nov 18, 2016, at 7:31 PM, Programmingkid wrote: >>> On Nov 18, 2016, at 4:10 PM,

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread John Snow
On 12/02/2016 04:54 PM, Laszlo Ersek wrote: > On 12/02/16 22:16, Eduardo Habkost wrote: >> On Fri, Dec 02, 2016 at 10:01:52PM +0100, Laszlo Ersek wrote: >> [...] >>> +docs/* >>> +*.txt >>> +configure >>> +GNUmakefile >>> +makefile >>> +Makefile* >>> +*.mak >>> +qapi-schema*.json >>> +qapi/*.json

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

2016-12-02 Thread Marcelo Tosatti
On Fri, Dec 02, 2016 at 11:56:09AM -0200, Eduardo Habkost wrote: > On Thu, Dec 01, 2016 at 12:39:03PM -0200, Marcelo Tosatti wrote: > > On Wed, Nov 30, 2016 at 11:09:28AM -0200, Eduardo Habkost wrote: > > > On Tue, Nov 29, 2016 at 09:54:29PM -0200, Marcelo Tosatti wrote: > > > > On Tue, Nov 29,

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Laszlo Ersek
On 12/02/16 22:16, Eduardo Habkost wrote: > On Fri, Dec 02, 2016 at 10:01:52PM +0100, Laszlo Ersek wrote: > [...] >> +docs/* >> +*.txt >> +configure >> +GNUmakefile >> +makefile >> +Makefile* >> +*.mak >> +qapi-schema*.json >> +qapi/*.json >> +include/qapi/visitor.h >> +include/qapi/visitor-impl.h

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-02 Thread Benjamin Herrenschmidt
On Fri, 2016-12-02 at 16:50 +1100, David Gibson wrote: > > Uh.. I don't entirely follow you.  From the host point of view there > are multiple iommu groups (PEs), but from the guest point of view > there's only one.  On the guest side iommu granularity is always > per-vPHB. Ok so the H_PUT_TCE

[Qemu-devel] [PATCH for-2.9 16/17] tests: query-cpu-model-test.py test code

2016-12-02 Thread Eduardo Habkost
This python script will run query-cpu-model-expansion and related commands, and sanity-check the results. It seems to work with qemu-system-s390x, already, but I don't have a host where I can make sure the test case work for all CPU models. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH for-2.9 11/17] target-i386: Remove AMD feature flag aliases from Opteron models

2016-12-02 Thread Eduardo Habkost
When CPU vendor is set to AMD, the AMD feature alias bits on CPUID[0x8001].EDX are already automatically copied from CPUID[1].EDX on x86_cpu_realizefn(). When CPU vendor is Intel, those bits are reserved and should be zero. On either case, those bits shouldn't be set in the CPU model table.

[Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-02 Thread Eduardo Habkost
The query-cpu-model-expand QMP command needs at least one static model, to allow the "static" expansion mode to be implemented. Instead of defining static versions of every CPU model, define a "base" CPU model that has absolutely no feature flag enabled. Despite having no CPUID data set at all,

[Qemu-devel] [PATCH for-2.9 09/17] target-i386: Move "host" properties to base class

2016-12-02 Thread Eduardo Habkost
Make the "pmu" and "host-cache-info" properties configurable on all CPU model classes. This way, query-cpu-model-expansion will be able to return the value of those properties when returning expansion data using the "base" CPU model as base. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH for-2.9 17/17] target-i386: Implement query-cpu-model-expansion QMP command

2016-12-02 Thread Eduardo Habkost
Implement query-cpu-model-expansion for target-i386. The code needs to be careful to handle non-migration-safe features ("pmu" and "host-cache-info") according to the expansion type. Cc: libvir-l...@redhat.com Cc: Jiri Denemark Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH for-2.9 08/17] target-i386: Support "-cpu host" on TCG too

2016-12-02 Thread Eduardo Habkost
Change the meaning of "-cpu host" to "enable all features supported by the accelerator in the current host", so that it can be used to enable all features supported by TCG. To make sure "host" is still at the end of the list in "-cpu help", add a "ordering" field that will be used when sorting

[Qemu-devel] [PATCH for-2.9 14/17] qapi: add static/migration-safe info to query-cpu-model-expansion

2016-12-02 Thread Eduardo Habkost
On x86, "-cpu host" enables some features that can't be represented by a static CPU model definition: cache info passthrough ("host-cache-info") and PMU passthrough ("pmu"). This means a type=static expansion of "host" can't include those features. A type=full expansion of "host", on the other

[Qemu-devel] [PATCH for-2.9 07/17] target-i386: Reorganize and document CPUID initialization steps

2016-12-02 Thread Eduardo Habkost
CPU runnability checks and CPU model expansion have slightly different requirements. Document the steps involved in loading a CPU model and realizing a CPU, so their requirements and purpose are clearly defined. This patch doesn't change any implementation. It just add comments, rename the

[Qemu-devel] [PATCH for-2.9 13/17] cpu: Support comma escaping when parsing -cpu

2016-12-02 Thread Eduardo Habkost
Currently it's impossible to use commas inside any option value in -cpu due to the simple way the parser splits the options. Change both cpu_common_parse_features() and x86_cpu_parse_featurestr() to use get_opt_*() parsing options, that can handle handle ",," escaping of commas. The ideal

[Qemu-devel] [PATCH for-2.9 03/17] qtest.py: Support QTEST_LOG environment variable

2016-12-02 Thread Eduardo Habkost
qtest logs everything to stderr by default, but we don't want it to be the default behavior on test cases. Implement the same behavior of libqtest.c, and redirect the qtest log to /dev/null by default unless the QTEST_LOG environment variable is set. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH for-2.9 12/17] target-i386: Return migration-safe field on query-cpu-definitions

2016-12-02 Thread Eduardo Habkost
Return the migration-safe field on query-cpu-definitions. All CPU models in x86 are migration-safe except "host". Signed-off-by: Eduardo Habkost --- target-i386/cpu-qom.h | 2 ++ target-i386/cpu.c | 3 +++ 2 files changed, 5 insertions(+) diff --git

[Qemu-devel] [PATCH for-2.9 10/17] target-i386: Allow short strings to be used as vendor ID

2016-12-02 Thread Eduardo Habkost
If a short string is specified, it will be padded with zeroes. Without this, "query-cpu-model-expansion model=base" would return an expansion that would never work in the command-line. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 11 +++ 1 file changed, 7

[Qemu-devel] [PATCH for-2.9 06/17] tests: Add rules to non-gtester qtest test cases

2016-12-02 Thread Eduardo Habkost
Today, simple non-gtester binaries can be run easily by a single Makefile rule (e.g. check-tests/qemu-iotest-quick.sh), but we don't have anything to help us automatically run the same test binary for multiple architectures. This add check-simpleqtest-* rules that will help us run binaries

[Qemu-devel] [PATCH for-2.9 02/17] qemu.py: Make logging optional

2016-12-02 Thread Eduardo Habkost
If a test case doesn't make QEMU generate any output, there's no need to redirect stdout and stderr to a file. On those cases, logging can be disabled so any errors are included on the test case output. Signed-off-by: Eduardo Habkost --- Patch originally submitted as part of

[Qemu-devel] [PATCH for-2.9 01/17] qmp: Report QOM type name on query-cpu-definitions

2016-12-02 Thread Eduardo Habkost
The new typename attribute on query-cpu-definitions will be used to help management software use device-list-properties to check which properties can be set using -cpu or -global for the CPU model. Signed-off-by: Eduardo Habkost --- Patch originally submitted as: From:

[Qemu-devel] [PATCH for-2.9 00/17] target-i386: Implement query-cpu-model-expansion

2016-12-02 Thread Eduardo Habkost
This series implements query-cpu-model-expansion on target-i386. QAPI / interface changes When implementing this, I have noticed that the "host" CPU model in i386 includes some migration-unsafe features that can't be translated to any migration-safe representation:

[Qemu-devel] [PATCH for-2.9 05/17] qtest.py: Make 'binary' parameter optional

2016-12-02 Thread Eduardo Habkost
If the 'binary' parameter is omitted, use the $QTEST_QEMU_BINARY environment variable. Signed-off-by: Eduardo Habkost --- Patch originally submitted as part of series: * [RFC v2 00/20] qmp: Report bus information on 'query-machines' --- scripts/qtest.py | 4 +++- 1 file

[Qemu-devel] [PATCH for-2.9 04/17] qtest.py: make logging optional

2016-12-02 Thread Eduardo Habkost
Support the 'logging' parameter on QEMUQtestMachine, for test cases that don't require logging. Signed-off-by: Eduardo Habkost --- Patch originally submitted as part of series: * [RFC v2 00/20] qmp: Report bus information on 'query-machines' --- scripts/qtest.py | 5 +++--

Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Eduardo Habkost
On Fri, Dec 02, 2016 at 10:01:52PM +0100, Laszlo Ersek wrote: [...] > +docs/* > +*.txt > +configure > +GNUmakefile > +makefile > +Makefile* > +*.mak > +qapi-schema*.json > +qapi/*.json > +include/qapi/visitor.h > +include/qapi/visitor-impl.h > +scripts/qapi.py > +scripts/*.py > +*.h >

[Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Laszlo Ersek
When passed to git-diff (and to every other git command producing diffs and/or diffstats) with "-O" or "diff.orderFile", this list of patterns will place the more declarative / abstract hunks first, while changes to imperative code / details will be near the end of the patches. This saves on

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-02 Thread John Snow
On 12/02/2016 01:45 PM, Alex Bligh wrote: > John, > >>> +Some storage formats and operations over such formats express a >>> +concept of data dirtiness. Whether the operation is block device >>> +mirroring, incremental block device backup or any other operation with >>> +a concept of data

[Qemu-devel] [PATCH v3 1/2] block: Rename raw_bsd to raw-format.c

2016-12-02 Thread Eric Blake
Given that we have raw-win32.c and raw-posix.c, my initial guess at raw_bsd.c was that it was for dealing with raw files using code specific to the BSD operating system (beyond what raw-posix could do). Not so - this name was chosen back in commit e1c66c6 to distinguish that it was a BSD licensed

[Qemu-devel] [PATCH v3 2/2] block: Rename raw-{posix, win32} to file-*.c

2016-12-02 Thread Eric Blake
These files deal with the file protocol, not the raw format (the file protocol is often used with other formats, and the raw format is not forced to use the file protocol). Rename things to make it a bit easier to follow. Suggested-by: Daniel P. Berrange Signed-off-by: Eric

[Qemu-devel] [PATCH v3 0/2] less confusing block file names

2016-12-02 Thread Eric Blake
no real change from v2 other than trivial rebasing and R-by: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07220.html but it's been more than a month since the last activity, and the start of the release cycle is as good a time as any to avoid any potential churn on conflicts due to

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

2016-12-02 Thread Laszlo Ersek
On 12/02/16 13:18, Igor Mammedov wrote: > On Thu, 1 Dec 2016 21:42:58 +0100 > Laszlo Ersek wrote: > >> On 12/01/16 20:13, Eduardo Habkost wrote: >>> On Thu, Dec 01, 2016 at 06:06:24PM +0100, Laszlo Ersek wrote: For the time being, we cannot handle SMIs in OVMF if VCPUs

[Qemu-devel] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries

2016-12-02 Thread Eric Blake
Make it easier to simulate various unusual hardware setups (for example, recent commits 3482b9b and b8d0a98 affect the Dell Equallogic iSCSI with its 15M preferred and maximum unmap and write zero sizing, or b2f95fe deals with the Linux loopback block device having a max_transfer of 64k), by

[Qemu-devel] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes

2016-12-02 Thread Eric Blake
Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away portions of requests not aligned to preferred boundaries.

[Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

2016-12-02 Thread Eric Blake
In order to test the effects of artificial geometry constraints on operations like write zero or discard, we first need blkdebug to manage these actions. It also allows us to inject errors on those operations, just like we can for read/write/flush. We can also test the contract promised by the

[Qemu-devel] [PATCH v3 1/5] blkdebug: Sanity check block layer guarantees

2016-12-02 Thread Eric Blake
Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment any I/O to fit within device boundaries. Additionally, when using a minimum alignment of 4k, we want to ensure the block layer does proper read-modify-write rather than requesting I/O on a slice of a sector. Let's enforce that

[Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

2016-12-02 Thread Eric Blake
Rather than store into a local variable, the copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.

[Qemu-devel] [PATCH v3 0/5] add blkdebug tests

2016-12-02 Thread Eric Blake
Based-on: Kevin Wolf's block-next branch: http://repo.or.cz/qemu/kevin.git/shortlog/refs/heads/block-next v2 of the series was here: https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg03495.html since then, the first half was applied to 2.8; leaving just this second half to enhance

Re: [Qemu-devel] [RFC PATCH] glusterfs: allow partial reads

2016-12-02 Thread Eric Blake
On 12/01/2016 04:59 AM, Wolfgang Bumiller wrote: > Fixes #1644754. > > Signed-off-by: Wolfgang Bumiller > --- > I'm not sure what the original rationale was to treat both partial > reads as well as well as writes as I/O error. (Seems to have happened > from original

Re: [Qemu-devel] [Xen-devel] [PATCH v2 4/4] 9pfs: introduce init_out/in_iov_from_pdu

2016-12-02 Thread Stefano Stabellini
On Fri, 2 Dec 2016, Greg Kurz wrote: > On Mon, 28 Nov 2016 13:27:24 -0800 > Stefano Stabellini wrote: > > > Not all 9pfs transports share memory between request and response. For > > those who don't, it is necessary to know how much memory is required in > > the response.

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-02 Thread Alex Bligh
John, >> +Some storage formats and operations over such formats express a >> +concept of data dirtiness. Whether the operation is block device >> +mirroring, incremental block device backup or any other operation with >> +a concept of data dirtiness, they all share a need to provide a list >> +of

[Qemu-devel] 答复: [PATCH v4 5/5] object: Add 'help' option for all available backends and properties

2016-12-02 Thread Nutaro, James J.
Hi Lin, My comments are inline with the patch. ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> '-object help' prints available user creatable backends. '-object $typename,help' prints relevant properties. Signed-off-by: Lin Ma --- include/qom/object_interfaces.h

Re: [Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target

2016-12-02 Thread Dr. David Alan Gilbert
* Bharata B Rao (bharata@gmail.com) wrote: > Hi, > > - Add ram object and dimm device at the source > > (qemu) object_add memory-backend-ram,id=ram0,size=128M > (qemu) device_add pc-dimm,id=dimm0,memdev=ram0 > > - Migrate the VM and remove the dimm device and ram object at the target > >

[Qemu-devel] Postcopy+spice crash

2016-12-02 Thread Dr. David Alan Gilbert
Hi Gerd, I've got a moderately repeatable crash with spice playing a video + postcopy. Some of the time I just get a warning (that I also get in precopy) but sometimes it turns into a backtrace; This is: f24 guest playing youtube fullscreen. migration between 2.7.0<->current head (had

[Qemu-devel] [PATCH for-2.8] target-arm/translate-a64: fix gen_load_exclusive

2016-12-02 Thread Alex Bennée
While testing rth's latest TCG patches with risu I found ldaxp was broken. Investigating further I found it was broken by 1dd089d0 when the cmpxchg atomic work was merged. As part of that change the code attempted to be clever by doing a single 64 bit load and then shuffle the data around to set

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-02 Thread Alex Williamson
On Fri, 2 Dec 2016 14:08:59 +0800 Peter Xu wrote: > On Thu, Dec 01, 2016 at 04:27:52PM +0800, Lan Tianyu wrote: > > On 2016年11月30日 17:23, Peter Xu wrote: > > > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > >> * intel_iommu's replay op is not implemented yet

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-02 Thread Alex Williamson
On Fri, 2 Dec 2016 13:59:25 +0800 Peter Xu wrote: > On Thu, Dec 01, 2016 at 04:21:38AM +, Tian, Kevin wrote: > > > From: Peter Xu > > > Sent: Wednesday, November 30, 2016 5:24 PM > > > > > > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > > > *

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Eric Blake
On 12/02/2016 08:41 AM, Fam Zheng wrote: >>> +++ b/scripts/git.orderfile >>> @@ -0,0 +1,15 @@ >>> +*.txt >> >> We also have *.md. (OK, OK, we have a single docs/bitmaps.md, but maybe >> it's going to be more in the future. :-)) > > Maybe just insert 'docs/*' here? I'm not sure if it works for

Re: [Qemu-devel] [PATCH 14/14] tests: Add test-image-lock

2016-12-02 Thread Max Reitz
On 31.10.2016 16:38, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/Makefile.include | 2 + > tests/test-image-lock.c | 179 > > 2 files changed, 181 insertions(+) > create mode 100644 tests/test-image-lock.c > >

Re: [Qemu-devel] QEMU Advent Calendar 2016

2016-12-02 Thread Kashyap Chamarthy
On Fri, Dec 02, 2016 at 03:24:27PM +0100, Ingve Vormestrand wrote: > Hi! First of all, QEMU rocks! Heya! > I'm from the IncludeOS project, and QEMU is, without a doubt, one of our > favourite tools! (If you haven't heard about IncludeOS, it is an open > source unikernel operating system written

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2016-12-02 Thread Max Reitz
On 31.10.2016 16:38, Fam Zheng wrote: > This implements open flag sensible image locking for local file > and host device protocol. > > virtlockd in libvirt locks the first byte, so we start looking at the > file bytes from 1. > > Quoting what was proposed by Kevin Wolf , there

[Qemu-devel] [RISU PATCH 2/9] aarch64: add hand-coded risu skeleton for directed testing

2016-12-02 Thread Alex Bennée
Sometimes you want absolute control over your test set-up to feed explicit values into the test. This started as an experiment but might be useful for further developing tests. Signed-off-by: Alex Bennée --- Makefile | 7 ++

[Qemu-devel] [RISU PATCH 3/9] risu: add simple trace and replay support

2016-12-02 Thread Alex Bennée
This adds a very dumb and easily breakable trace and replay support to the aarch64 build of risu. In --master mode the various risu ops trigger a write of register/memory state into a binary file which can be played back to an apprentice. Currently there is no validation of the image source so

[Qemu-devel] [RISU PATCH 5/9] risu_aarch64: it's -> it is

2016-12-02 Thread Alex Bennée
Signed-off-by: Alex Bennée --- risu_aarch64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/risu_aarch64.c b/risu_aarch64.c index 9d538cb..77f9288 100644 --- a/risu_aarch64.c +++ b/risu_aarch64.c @@ -82,7 +82,7 @@ int send_register_info(int sock,

[Qemu-devel] [RISU PATCH 4/9] risu: add support compressed tracefiles

2016-12-02 Thread Alex Bennée
This uses the magic of zlib's gzread/write interface to wrap the tracefile in compression. The code changes are tiny. I spent more time messing about with the configure/linker stuff to auto-detect bits. Signed-off-by: Alex Bennée --- Makefile | 3 ++- configure | 55

[Qemu-devel] [RISU PATCH 7/9] new: generate_all.sh script

2016-12-02 Thread Alex Bennée
A simple script to cut up a full .risu file and generate binaries for the whole set. Call with risu file and instruction count and directory: ./generate_all.sh aarch64.risu 4 2 testcases.aarch64 Signed-off-by: Alex Bennée --- generate_all.sh | 55

[Qemu-devel] [RISU PATCH 9/9] new: run_risu.sh script

2016-12-02 Thread Alex Bennée
A simple script to work through running all of a bunch of files with record/playback traces. Dumps a summary and the number of failed tests at the end. Signed-off-by: Alex Bennée --- run_risu.sh | 51 +++ 1 file changed, 51

[Qemu-devel] [RISU PATCH 0/9] Record/playback patches

2016-12-02 Thread Alex Bennée
Hi Peter, I've been cleaning things up so I thought I should re-post my current state. These all apply to the current master. I had to regenerate all the risu binaries as I'd used --no-fp for a bunch of them originally which was causing failures. I'm not sure if this is due to the FP registers

[Qemu-devel] [RISU PATCH 1/9] risu: a bit more verbosity when running

2016-12-02 Thread Alex Bennée
Before this is could seem a little quite when running as you had no indication stuff was happening (or how fast). I only dump on the master side as I want to minimise the amount of qemu logs to sift through. Signed-off-by: Alex Bennée --- risu.c | 15

[Qemu-devel] [RISU PATCH 8/9] new: record_traces.sh helper script

2016-12-02 Thread Alex Bennée
A simple script to run through a bunch of binaries and generate their trace files. Signed-off-by: Alex Bennée --- record_traces.sh | 16 1 file changed, 16 insertions(+) create mode 100755 record_traces.sh diff --git a/record_traces.sh

[Qemu-devel] [RISU PATCH 6/9] risugen: remove grocer's apostrophe from REs

2016-12-02 Thread Alex Bennée
This also fixes perl-modes confusion about escaped strings. Signed-off-by: Alex Bennée --- risugen | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/risugen b/risugen index a604fe5..77a550b 100755 --- a/risugen +++ b/risugen @@ -288,7 +288,7 @@ Valid

Re: [Qemu-devel] Livelock with qemu 2.5.0

2016-12-02 Thread Brian Candler
On 02/12/2016 14:19, Brian Candler wrote: I am running a VM under qemu 2.5.0/Ubuntu 16.04. The guest VM is also Ubuntu 16.04, with ZFS and LXD Correction: it's btrfs (not zfs). I re-ran the test with qemu 2.7.0, and this time got a btrfs kernel panic in the guest [below]. The guest is

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-02 Thread Aurelien Jarno
On 2016-12-01 21:51, Jin Guojie wrote: > Changes in v5: > * Update against master(v2.8.0-rc2) > * Fix a bug: 64-bit big-endian guests hang on mips64 little-endian > hosts, and vice versa. This bug was first introduced in v2 patch, > due to obvious misuse of ret/arg registers in

[Qemu-devel] QEMU Advent Calendar 2016

2016-12-02 Thread Ingve Vormestrand
Hi! First of all, QEMU rocks! I'm from the IncludeOS project, and QEMU is, without a doubt, one of our favourite tools! (If you haven't heard about IncludeOS, it is an open source unikernel operating system written in modern C++ (you can find out more about the project at http://includeos.org/

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-02 Thread James Hogan
On Fri, Dec 02, 2016 at 11:16:41AM +, James Hogan wrote: > Hi, > > On Thu, Dec 01, 2016 at 09:51:59PM +0800, Jin Guojie wrote: > > * Tested successfully on following machines: > > > > | HOST| qemu-system | Debian ISO | > > |-| > >

Re: [Qemu-devel] [Qemu-ppc] [RFCv2 12/12] ppc: Rework CPU compatibility testing across migration

2016-12-02 Thread Greg Kurz
On Wed, 16 Nov 2016 09:17:55 +1100 David Gibson wrote: > Migrating between different CPU versions is quite complicated for ppc. > A long time ago, we ensure identical CPU versions at either end by checking > the PVR had the same value. However, this breaks under KVM

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Fam Zheng
On Fri, 12/02 15:33, Max Reitz wrote: > On 02.12.2016 11:40, Laszlo Ersek wrote: > > When passed to git-diff (and to every other git command producing diffs > > and/or diffstats) with "-O" or "diff.orderFile", this list of patterns > > will place the more declarative / abstract hunks first, while

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Max Reitz
On 02.12.2016 11:40, Laszlo Ersek wrote: > When passed to git-diff (and to every other git command producing diffs > and/or diffstats) with "-O" or "diff.orderFile", this list of patterns > will place the more declarative / abstract hunks first, while changes to > imperative code / details will be

[Qemu-devel] Livelock with qemu 2.5.0

2016-12-02 Thread Brian Candler
I am running a VM under qemu 2.5.0/Ubuntu 16.04. The guest VM is also Ubuntu 16.04, with ZFS and LXD, and I am hitting it hard with I/O, concurrently building multiple LXD containers. Previously it was serialized to build one container at a time, and it was fine. With the concurrent builds I

Re: [Qemu-devel] [PATCH 02/20] blockjob: introduce .drain callback for jobs

2016-12-02 Thread Vladimir Sementsov-Ogievskiy
27.10.2016 13:48, Paolo Bonzini wrote: This is required to decouple block jobs from running in an AioContext. With multiqueue block devices, a BlockDriverState does not really belong to a single AioContext. The solution is to first wait until all I/O operations are complete; then loop in the

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

2016-12-02 Thread Eduardo Habkost
On Thu, Dec 01, 2016 at 12:39:03PM -0200, Marcelo Tosatti wrote: > On Wed, Nov 30, 2016 at 11:09:28AM -0200, Eduardo Habkost wrote: > > On Tue, Nov 29, 2016 at 09:54:29PM -0200, Marcelo Tosatti wrote: > > > On Tue, Nov 29, 2016 at 10:34:05AM -0200, Eduardo Habkost wrote: > > > > On Tue, Nov 29,

Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-02 Thread Gerd Hoffmann
Hi, > Please check one of the links in the blurb, under which Paolo noted that > we're already above the limit in the worst (theoretical) case. Oh, ok. That changes the picture. > In practice they don't hit the limit, indeed. But creating such a case being possible (even if unlikely) is

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Gerd Hoffmann
> # Apply this diff order to your git configuration with the command > # > # git config diff.orderFile scripts/git.orderfile Looks good to me. cheers, Gerd

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

2016-12-02 Thread Igor Mammedov
On Thu, 1 Dec 2016 21:42:58 +0100 Laszlo Ersek wrote: > On 12/01/16 20:13, Eduardo Habkost wrote: > > On Thu, Dec 01, 2016 at 06:06:24PM +0100, Laszlo Ersek wrote: > >> For the time being, we cannot handle SMIs in OVMF if VCPUs can show up > >> after boot. Otherwise,

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Laszlo Ersek
On 12/02/16 11:59, Gerd Hoffmann wrote: >> git config diff.orderFile scripts/git.orderfile > >> diff --git a/scripts/git.orderfile b/scripts/git.orderfile >> new file mode 100644 >> index ..600a2e4fc540 >> --- /dev/null >> +++ b/scripts/git.orderfile >> @@ -0,0 +1,15 @@ > > Is it

Re: [Qemu-devel] [RFC v2 06/20] qdev: Add 'accepted-device-types' property to BusClass

2016-12-02 Thread Cornelia Huck
On Tue, 29 Nov 2016 12:18:19 -0200 Eduardo Habkost wrote: > On Tue, Nov 29, 2016 at 02:57:07PM +0100, Cornelia Huck wrote: > > On Fri, 25 Nov 2016 20:05:42 -0200 > > Eduardo Habkost wrote: > > > > > Each bus class will now be aware of the specific

Re: [Qemu-devel] [PATCH v4 5/7] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2016-12-02 Thread Laszlo Ersek
On 12/02/16 12:54, Igor Mammedov wrote: > On Thu, 1 Dec 2016 18:06:22 +0100 > Laszlo Ersek wrote: > >> Introduce the following fw_cfg files: >> >> - "etc/smi/host-features": a little endian uint64_t feature bitmap, >> presenting the features known by the host to the guest.

Re: [Qemu-devel] [PATCH v4 5/7] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2016-12-02 Thread Igor Mammedov
On Thu, 1 Dec 2016 18:06:22 +0100 Laszlo Ersek wrote: > Introduce the following fw_cfg files: > > - "etc/smi/host-features": a little endian uint64_t feature bitmap, > presenting the features known by the host to the guest. Read-only for > the guest. 'host' here is a

Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-02 Thread Laszlo Ersek
On 12/02/16 12:10, Gerd Hoffmann wrote: > On Do, 2016-12-01 at 18:06 +0100, Laszlo Ersek wrote: >> We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could >> lead to problems with backward migration: a more recent QEMU (running an >> older machine type) would allow the guest, in

[Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable

2016-12-02 Thread P J P
From: Prasad J Pandit Local 'netcfg' variable in 'virtio_net_get_config' routine was not initialised. It could leak uninitialised 'netcfg.mtu' field memory. Initialise 'netcfg' to avoid it. Reported-by: Azureyang Signed-off-by: Prasad J Pandit

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-02 Thread James Hogan
Hi, On Thu, Dec 01, 2016 at 09:51:59PM +0800, Jin Guojie wrote: > * Tested successfully on following machines: > > | HOST| qemu-system | Debian ISO | > |-| > | mips 32 le |i386 |i386 | > | mips 32 le |

[Qemu-devel] [PATCH] i386: amd_iommu: fix MMIO register count and access

2016-12-02 Thread P J P
From: Prasad J Pandit IOMMU MMIO registers are divided in two groups by their offsets. Low offsets(<0x2000) registers are grouped into 'amdvi_mmio_low' table and higher offsets(>=0x2000) registers are grouped into 'amdvi_mmio_high' table. No of registers in each table is

Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

2016-12-02 Thread Stefan Hajnoczi
On Thu, Dec 01, 2016 at 07:26:39PM +, Stefan Hajnoczi wrote: > v4: > * Added poll time self-tuning algorithm [Christian and Paolo] > * Try a single iteration of polling to avoid non-blocking > ppoll(2)/epoll_wait(2) [Paolo] > * Reordered patches to make performance analysis easier - see

Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-02 Thread Gerd Hoffmann
On Do, 2016-12-01 at 18:06 +0100, Laszlo Ersek wrote: > We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could > lead to problems with backward migration: a more recent QEMU (running an > older machine type) would allow the guest, in fw_cfg_select(), to select a > high key value

Re: [Qemu-devel] [PATCH v2 4/4] 9pfs: introduce init_out/in_iov_from_pdu

2016-12-02 Thread Greg Kurz
On Mon, 28 Nov 2016 13:27:24 -0800 Stefano Stabellini wrote: > Not all 9pfs transports share memory between request and response. For > those who don't, it is necessary to know how much memory is required in > the response. > > Split the existing init_iov_from_pdu

Re: [Qemu-devel] [PATCH v2 3/4] 9pfs: call v9fs_init_qiov_from_pdu before v9fs_pack

2016-12-02 Thread Greg Kurz
On Mon, 28 Nov 2016 13:27:23 -0800 Stefano Stabellini wrote: > v9fs_xattr_read should not access VirtQueueElement elems directly. > Move v9fs_init_qiov_from_pdu up in the file and call > v9fs_init_qiov_from_pdu before v9fs_pack. Use v9fs_pack on the new > iovec. > >

Re: [Qemu-devel] [PATCH v2 2/4] 9pfs: introduce transport specific callbacks

2016-12-02 Thread Greg Kurz
On Mon, 28 Nov 2016 13:27:22 -0800 Stefano Stabellini wrote: > Don't call virtio functions from 9pfs generic code, use generic function > callbacks instead. > > Signed-off-by: Stefano Stabellini > > --- Reviewed-by: Greg Kurz

Re: [Qemu-devel] [PATCH] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

2016-12-02 Thread Gerd Hoffmann
> git config diff.orderFile scripts/git.orderfile > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > new file mode 100644 > index ..600a2e4fc540 > --- /dev/null > +++ b/scripts/git.orderfile > @@ -0,0 +1,15 @@ Is it possible to have comments in here? So we can place

Re: [Qemu-devel] Support for using TCG frontend as a library

2016-12-02 Thread Liviu Ionescu
> On 2 Dec 2016, at 12:24, Peter Maydell wrote: > > Right, but if you have a bug which requires your application to > sit there processing for half an hour (or even five minutes) > before it appears, it's nice not to spend that time. fully agree. for physical targets,

  1   2   >