Re: [Qemu-devel] QEMU for RISC6000

2016-12-22 Thread Thomas Huth
On 22.12.2016 13:01, giancarlo teodori wrote: > Hi, I'm working to emulate aix SO on RISC6000 environment using qemu > emulator. > I tried to import related patch ([RFC,2/6] prep: add IBM RS/6000 7248 (43p) > machine emulation), but this operation give me an error. > I'm using a wrong release of

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread Zhang Chen
On 12/22/2016 08:52 PM, Eric Blake wrote: [resend, I don't know how I botched the From: line in my first attempt, or if that botch changed who received the mail] On 12/22/2016 12:08 AM, Zhang Chen wrote: Make sense, this command trying to collect status on whether an error has occurred, and

Re: [Qemu-devel] [kvm-unit-tests PATCH v8 00/14] VT-d unit test

2016-12-22 Thread Peter Xu
On Thu, Dec 22, 2016 at 12:52:09PM +0100, Paolo Bonzini wrote: > > > On 22/12/2016 12:06, Andrew Jones wrote: > > Alex, > > > > Are you happy with v8? If so, then, as far as I'm concerned, this > > series is ready. I'd like to try driving the edu device from ARM > > tests too. > > > > Thanks,

Re: [Qemu-devel] [PATCH v3] intel_iommu: allow dynamic switch of IOMMU region

2016-12-22 Thread Peter Xu
On Thu, Dec 22, 2016 at 07:34:10PM +0800, Jason Wang wrote: > > > On 2016年12月22日 19:04, Peter Xu wrote: > >On Thu, Dec 22, 2016 at 05:52:58PM +0800, Jason Wang wrote: > >> > >>On 2016年12月22日 17:48, Peter Xu wrote: > >>> /* Handle Translation Enable/Disable */ > >>> static void

Re: [Qemu-devel] [PATCH v3 0/4] migration: skip scanning and migrating ram pages released by virtio-balloon driver.

2016-12-22 Thread Li, Liang Z
> While measuring live migration performance for qemu/kvm guest, it was > observed that the qemu doesn’t maintain any intelligence for the guest ram > pages released by the guest balloon driver and treat such pages as any other > normal guest ram pages. This has direct impact on overall migration

[Qemu-devel] [PATCH] pcie: remove duplicate assertion

2016-12-22 Thread Cao jin
"size >= 8" connote "size > 0" Signed-off-by: Cao jin --- hw/pci/pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 39b10b852d91..f864c5cd5458 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -668,7 +668,6 @@ void

Re: [Qemu-devel] [RISU PATCH v3 00/10] Record/payback patches

2016-12-22 Thread joserz
On Fri, Dec 09, 2016 at 11:48:20AM +, Alex Bennée wrote: > Hi, > > I did a bunch of tweaking to see if I could abstract the hackage for > record/replay a bit more. With a little bit of light re-factoring of > the send and recv functions I can move all the specific send/recv > logic into the

Re: [Qemu-devel] A question about PCI device address spaces

2016-12-22 Thread David Gibson
On Thu, Dec 22, 2016 at 05:42:40PM +0800, Peter Xu wrote: > Hello, > > Since this is a general topic, I picked it out from the VT-d > discussion and put it here, just want to be more clear of it. > > The issue is, whether we have exposed too much address spaces for > emulated PCI devices? > >

Re: [Qemu-devel] [PATCH v2] ipmi: Fix macro issues

2016-12-22 Thread Eric Blake
On 12/22/2016 01:18 PM, miny...@acm.org wrote: > From: Corey Minyard > > Macro parameters should almost always have () around them when used. > llvm reported an error on this. > > Remove redundant parenthesis and put parenthesis around the entire > macros with assignments

Re: [Qemu-devel] [libvirt] Cannot add iothreads label in libvirt xml configuration file

2016-12-22 Thread John Ferlan
On 12/21/2016 12:11 PM, Weiwei Jia wrote: > Hi, > > I cannot add iothreads > (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in > the libvirt xml configuration file. Once I add > "4" and other related config for IOthreads into > the libvirt xml configuration file with virsh

Re: [Qemu-devel] [PATCH v6 17/17] build-sys: add qapi doc generation targets

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Generate and install the man, txt and html versions of QAPI > documentation (generate and install qemu-doc.txt too). Sure you don't install qemu-doc.txt in the previous patch already? > > Add it also to optional pdf/info targets. > >

Re: [Qemu-devel] [PATCH v6 16/17] build-sys: add txt documentation rules

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Build txt documentation, and install it. Suggest "Build plain text documentation". Can touch up on commit. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v6 15/17] build-sys: use a generic TEXI2MAN rule

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau This is a bit terse. Suggest to explain why, like this: The recipe for making a man page from .texi is duplicated several times over. Capture it in suitable pattern

Re: [Qemu-devel] [PATCH v6 14/17] build-sys: remove dvi doc generation

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > There is no clear reason to have rules to generate dvi format > documentation, pdf is generally better supported. Suggest "supported nowadays." Can touch up on commit. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v6 13/17] build-sys: use --no-split for info

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Splitting the info files doesn't bring much benefits these days. > This fixes also untracked generated info files from git ignore. > > Let's use MAKEINFOFLAGS for common flags, --number-sections is already > the default anyway, so adding

Re: [Qemu-devel] [PATCH v6 12/17] docs: add qemu logo to pdf

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Add a logo to texi2pdf output. Other formats (info/html) are left as > future improvements. > > The pdf (needed by texi2pdf for vectorized images) was generated thanks > to inkscape, from the pc-bios/qemu_logo.svg file, with the following

Re: [Qemu-devel] [PATCH v6 10/17] json: reorder documentation body

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Place the body of expression documentation at the top (after the > @symbol:). This prevents ambiguity with other argument or > tagged-section documentation. I suspect the ambiguity is due to sub-optimal doc language design. But

Re: [Qemu-devel] [PATCH v6 09/17] texi2pod: learn quotation, deftp and deftypefn

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Learn a few more markups used for API documentation. > > Signed-off-by: Marc-André Lureau I don't know enough about POD to review this. If nobody else steps up, and I can't find the time to learn some POD,

Re: [Qemu-devel] [libvirt] Cannot add iothreads label in libvirt xml configuration file

2016-12-22 Thread Weiwei Jia
On Thu, Dec 22, 2016 at 4:33 AM, Daniel P. Berrange wrote: > On Wed, Dec 21, 2016 at 12:11:51PM -0500, Weiwei Jia wrote: >> Hi, >> >> I cannot add iothreads >> (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in >> the libvirt xml configuration file. Once I

Re: [Qemu-devel] [libvirt] Performance about x-data-plane

2016-12-22 Thread Weiwei Jia
On Thu, Dec 22, 2016 at 4:30 AM, Daniel P. Berrange wrote: > On Thu, Dec 22, 2016 at 01:34:47AM -0500, Weiwei Jia wrote: >> Hi, >> >> With QEMU x-data-plane, I find the performance has not been improved >> very much. Please see following two settings. >> >> Setting 1: I/O

Re: [Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016-12-21

2016-12-22 Thread Peter Maydell
On 22 December 2016 at 10:47, Daniel P. Berrange wrote: > The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: > > Open 2.9 development tree (2016-12-20 16:20:16 +) > > are available in the git repository at: > > git://github.com/berrange/qemu

[Qemu-devel] [PATCH v2] ipmi: Fix macro issues

2016-12-22 Thread minyard
From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the entire macros with assignments in case they are used in an expression. Remove some unused

[Qemu-devel] [PATCH v3 3/6] exec: [tcg] Use multiple physical TB caches

2016-12-22 Thread Lluís Vilanova
The physical TB cache is split into 2^E caches, where E is the number of events with the "vcpu" and without the "disable" properties. The virtual TB cache on each vCPU uses a (potentially) different physical TB cache. This is later exploited to support different tracing event states on a

[Qemu-devel] [PATCH v3 0/6] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches

2016-12-22 Thread Lluís Vilanova
Optimizes tracing of events with the 'tcg' and 'vcpu' properties (e.g., memory accesses), making it feasible to statically enable them by default on all QEMU builds. Some quick'n'dirty numbers with 400.perlbench (SPECcpu2006) on the train input (medium size - suns.pl) and the guest_mem_before

[Qemu-devel] [PATCH v3 5/6] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events

2016-12-22 Thread Lluís Vilanova
If an event is dynamically disabled, the TCG code that calls the execution-time tracer is not generated. Removes the overheads of execution-time tracers for dynamically disabled events. As a bonus, also avoids checking the event state when the execution-time tracer is called from TCG-generated

[Qemu-devel] [PATCH v3 1/6] exec: [tcg] Refactor flush of per-CPU virtual TB cache

2016-12-22 Thread Lluís Vilanova
The function is reused in later patches. Signed-off-by: Lluís Vilanova --- cputlb.c|2 +- include/exec/exec-all.h |6 ++ translate-all.c | 14 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/cputlb.c

[Qemu-devel] [PATCH v3 4/6] exec: [tcg] Switch physical TB cache based on vCPU tracing state

2016-12-22 Thread Lluís Vilanova
Uses the per-vCPU event state in CPUState->trace_dstate (a bitmap) as an index to a physical TB cache that will contain code specific to the set of dynamically enabled events. Two vCPUs tracing different events will execute code from different physical TB caches. Two vCPUs tracing the same events

[Qemu-devel] [PATCH v3 2/6] trace: Make trace_get_vcpu_event_count() inlinable

2016-12-22 Thread Lluís Vilanova
Later patches will make use of it. Signed-off-by: Lluís Vilanova --- trace/control-internal.h |5 + trace/control.c |9 ++--- trace/control.h |2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/trace/control-internal.h

[Qemu-devel] [PATCH v3 6/6] trace: [tcg, trivial] Re-align generated code

2016-12-22 Thread Lluís Vilanova
Last patch removed a nesting level in generated code. Re-align all code generated by backends to be 4-column aligned. Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/dtrace.py |2 +- scripts/tracetool/backend/ftrace.py | 20 ++--

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Holger Schranz
Hi Paolo, thanks for the hint. In the SLES11 SP4 documentation virtio-scsi is implemented, but this described SLES11SP4 as a host system not as a VM guest. I'm totally confused. Why does the guest VM's runs until version 2.7.0 without any problems (with older and newer kernel versions)? May be

Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks

2016-12-22 Thread Peter Maydell
On 20 December 2016 at 23:07, Samuel Thibault wrote: > The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: > > Open 2.9 development tree (2016-12-20 16:20:16 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters

2016-12-22 Thread Corey Minyard
On 12/22/2016 09:01 AM, Eric Blake wrote: On 12/22/2016 08:30 AM, miny...@acm.org wrote: From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Reported in https://bugs.launchpad.net/bugs/1651167

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 18:42, Eduardo Habkost wrote: > On Thu, Dec 22, 2016 at 06:32:24PM +0100, Paolo Bonzini wrote: >> >> >> On 22/12/2016 18:30, Peter Maydell wrote: >>> On 22 December 2016 at 15:59, Paolo Bonzini wrote: This moves out of libqemustub.a those functions which

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Eduardo Habkost
On Thu, Dec 22, 2016 at 06:32:24PM +0100, Paolo Bonzini wrote: > > > On 22/12/2016 18:30, Peter Maydell wrote: > > On 22 December 2016 at 15:59, Paolo Bonzini wrote: > >> This moves out of libqemustub.a those functions which can be handled > >> simply by $(call lnot), like

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 18:30, Peter Maydell wrote: > On 22 December 2016 at 15:59, Paolo Bonzini wrote: >> This moves out of libqemustub.a those functions which can be handled >> simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c. >> libqemustub.a keep the more

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Peter Maydell
On 22 December 2016 at 15:59, Paolo Bonzini wrote: > This moves out of libqemustub.a those functions which can be handled > simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c. > libqemustub.a keep the more complex cases where a small part of the >

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 13:33, Holger Schranz wrote: > > > I have installed an RH 7.7 based on kernel 3.10 and a SuSE LEAP 42.2 which > is based on kernel 4.4. Both system see the tape devices and can work. > Than I restart in the same session the VM with SLES11 SP4 (kernel 3.0.101) > and an older RH

[Qemu-devel] [PATCH 08/11] stubs: move vhost stubs to stubs/vhost.o

2016-12-22 Thread Paolo Bonzini
No need to include them in libqemustub.a, since only system emulators need them. Signed-off-by: Paolo Bonzini --- hw/Makefile.objs| 2 +- hw/virtio/Makefile.objs | 6 +- stubs/vhost.c => hw/virtio/vhost-stub.c | 0

[Qemu-devel] [PATCH 10/11] build: remove --enable-colo/--disable-colo

2016-12-22 Thread Paolo Bonzini
No need to provide this knob, just enable COLO unconditionally. Remove the configure option as well as stubs/migration-colo.c. Signed-off-by: Paolo Bonzini --- configure | 11 --- migration/Makefile.objs | 3 +-- stubs/Makefile.objs | 1 -

[Qemu-devel] [PATCH 09/11] event_notifier: cleanups around event_notifier_set_handler

2016-12-22 Thread Paolo Bonzini
EventNotifiers are already supported by AioContext, so reuse that in iohandler.c and remove the useless is_external argument. Since the iohandler AioContext is never used for block devices, aio_disable_external is never called on it. This lets us remove stubs/iohandler.c. Signed-off-by: Paolo

[Qemu-devel] [PATCH 07/11] stubs: group all monitor_fdset_* functions in a single file

2016-12-22 Thread Paolo Bonzini
It makes little sense to implement only one of them, so avoid proliferation of stubs files. Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 5 + stubs/fdset-add-fd.c| 8 stubs/fdset-find-fd.c | 8 stubs/fdset-get-fd.c| 8

[Qemu-devel] [PATCH 11/11] stubs: remove stubs/kvm.c

2016-12-22 Thread Paolo Bonzini
This has a single function, just move it to the other target/*/kvm.c files. Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 1 - stubs/kvm.c | 8 target/mips/kvm.c | 5 + target/ppc/kvm.c| 5 + target/s390x/kvm.c | 5 + 5 files

[Qemu-devel] [PATCH 06/11] stubs: group stubs for user-mode emulation

2016-12-22 Thread Paolo Bonzini
Some stubs are used for user-mode emulation only; they are not needed by tools. Move them out of stubs/. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 1 + Makefile.target | 4 ++-- stubs/Makefile.objs | 2 -- stubs/cpus.c| 11 ---

[Qemu-devel] [PATCH 05/11] hw: move reset handlers from vl.c to hw/core

2016-12-22 Thread Paolo Bonzini
They are small, it is not worth stubbing them. Just include them in user-mode emulators and unit tests as well. Signed-off-by: Paolo Bonzini --- hw/core/Makefile.objs | 2 +- hw/core/reset.c | 72 + include/hw/hw.h

[Qemu-devel] [PATCH 03/11] stubs: move acpi stubs to hw/acpi

2016-12-22 Thread Paolo Bonzini
No need to include them in libqemustub.a, since only system emulators need them. Signed-off-by: Paolo Bonzini --- hw/acpi/Makefile.objs | 12 stubs/ipmi.c => hw/acpi/ipmi-stub.c | 0 stubs/Makefile.objs | 1 - 3 files changed, 8

[Qemu-devel] [PATCH 01/11] stubs: merge all monitor stubs in one file, remove monitor_cur_is_qmp stub

2016-12-22 Thread Paolo Bonzini
monitor_cur_is_qmp was previously used by other stubs, but it's not since 397d30e ("qemu-error: remove dependency of stubs on monitor", 2016-11-01). Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 4 +--- stubs/mon-is-qmp.c| 10 --

[Qemu-devel] [PATCH 04/11] stubs: remove unused stub for serial_hd

2016-12-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 1 - stubs/get-next-serial.c | 4 2 files changed, 5 deletions(-) delete mode 100644 stubs/get-next-serial.c diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs index c4df915..5b3e7c6 100644 ---

[Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Paolo Bonzini
This moves out of libqemustub.a those functions which can be handled simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c. libqemustub.a keep the more complex cases where a small part of the executables we build needs an implementation of a small subset of an API. Paolo Paolo

[Qemu-devel] [PATCH 02/11] stubs: move smbios stubs to hw/smbios

2016-12-22 Thread Paolo Bonzini
No need to include them in libqemustub.a, since only system emulators need them. Signed-off-by: Paolo Bonzini --- hw/smbios/Makefile.objs | 11 --- stubs/smbios_type_38.c => hw/smbios/smbios_type_38-stub.c | 0 stubs/Makefile.objs

Re: [Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9

2016-12-22 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 20161222152300.32395-1-pbonz...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PULL 25/25] x86: implement la57 paging mode

2016-12-22 Thread Paolo Bonzini
From: "Kirill A. Shutemov" The new paging more is extension of IA32e mode with more additional page table level. It brings support of 57-bit vitrual address space (128PB) and 52-bit physical address space (4PB). The structure of new page table level is

[Qemu-devel] [PULL 24/25] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

2016-12-22 Thread Paolo Bonzini
From: Doug Evans The syscall and sysret instructions behave a bit differently: TF is checked after the instruction completes. This allows the o/s to disable #DB at a syscall by adding TF to FMASK. And then when the sysret is executed the #DB is taken "as if" the syscall insn

Re: [Qemu-devel] [PATCH] smbios: filter based on CONFIG_SMBIOS rather than TARGET

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 16:18, Leif Lindholm wrote: > -smbios command line options were accepted but silently ignored on > TARGET_ARM, due to a test for TARGET_I386 in arch_init.c. > > Copy the mechanism of hw/pci/pci-stub.c to implement an smbios-stub > instead, enabled for all targets without

[Qemu-devel] [PULL 23/25] kvmclock: reduce kvmclock difference on migration

2016-12-22 Thread Paolo Bonzini
From: Marcelo Tosatti Check for KVM_CAP_ADJUST_CLOCK capability KVM_CLOCK_TSC_STABLE, which indicates that KVM_GET_CLOCK returns a value as seen by the guest at that moment. For new machine types, use this value rather than reading from guest memory. This reduces kvmclock

[Qemu-devel] [PULL 16/25] pc: make sata configurable

2016-12-22 Thread Paolo Bonzini
From: Chao Peng Signed-off-by: Chao Peng Message-Id: <1478330391-74060-3-git-send-email-chao.p.p...@linux.intel.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 29 -

[Qemu-devel] [PULL 22/25] kvm: sync linux headers

2016-12-22 Thread Paolo Bonzini
From: Marcelo Tosatti Import KVM_CLOCK_TSC_STABLE. Signed-off-by: Marcelo Tosatti Message-Id: <20161210172324.402794...@redhat.com> Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input.h| 1 +

[Qemu-devel] [PULL 15/25] pc: make smbus configurable

2016-12-22 Thread Paolo Bonzini
From: Chao Peng Signed-off-by: Chao Peng Message-Id: <1478330391-74060-2-git-send-email-chao.p.p...@linux.intel.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 18 ++ hw/i386/pc_q35.c

[Qemu-devel] [PULL 21/25] scsi-disk: fix VERIFY for scsi-block

2016-12-22 Thread Paolo Bonzini
When a scsi-disk object receives VERIFY command with BYTCHK bit being zero, scsi_block_is_passthrough returns false and finally makes req being proceeded by scsi_block_dma_command. Because scsi_block_dma_command has removed process of VERIFY, QEMU will abort in this function. Reported-by: Junlian

[Qemu-devel] [PULL 12/25] main-loop: update comment for qemu_mutex_lock/unlock_iothread

2016-12-22 Thread Paolo Bonzini
From: Yaowei Bai Commit 49cf57281b7 (vl: delay thread initialization after daemonization) makes the global mutex is taken after daemonization instead before daemonization by qemu_init_main_loop(). Signed-off-by: Yaowei Bai

[Qemu-devel] [PULL 11/25] timer: fix misleading comment in timer.h

2016-12-22 Thread Paolo Bonzini
From: Yaowei Bai It's timer to expire, not clock. Signed-off-by: Yaowei Bai Message-Id: <1480566640-27264-1-git-send-email-baiyao...@cmss.chinamobile.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo

[Qemu-devel] [PULL 09/25] virtio-scsi: introduce virtio_scsi_acquire/release

2016-12-22 Thread Paolo Bonzini
These will be used more as soon as the acquire/release is pushed down to the ioeventfd handlers. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 27

[Qemu-devel] [PULL 18/25] x86: Fix x86_64 'g' packet response to gdb from 32-bit mode.

2016-12-22 Thread Paolo Bonzini
From: Doug Evans The remote protocol can't handle flipping back and forth between 32-bit and 64-bit regs. To compensate, pretend "as if" on 64-bit cpu when in 32-bit mode. Signed-off-by: Doug Evans Reviewed-by: Richard Henderson Message-Id:

[Qemu-devel] [PULL 07/25] rules.mak: add more rules to avoid chaining

2016-12-22 Thread Paolo Bonzini
Really rule chaining is not a particularly expensive task, since GNU Make caches the directory listing. However it is easy to avoid it for most files and for phony targets (one was missing). After this patch, only "Makefile", "scripts/hxtool" and "scripts/create_config" attempt to use chained

[Qemu-devel] [PULL 20/25] hw/block/pflash_cfi*.c: fix confusing assert fail message

2016-12-22 Thread Paolo Bonzini
From: Ziyue Yang The patch is to fix the confusing assert fail message caused by un-initialized device structure (from bite sized tasks). The bug can be reproduced by ./qemu-system-x86_64 -nographic -device cfi.pflash01 The CFI hardware is dynamically loaded by QOM

[Qemu-devel] [PULL 08/25] build-sys: remove libtool left-over

2016-12-22 Thread Paolo Bonzini
From: Marc-André Lureau Libtool support was removed in commit e999ee44349, there is a few left-over. Signed-off-by: Marc-André Lureau Message-Id: <20161108070513.30274-1-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 17/25] pc: make pit configurable

2016-12-22 Thread Paolo Bonzini
From: Chao Peng Signed-off-by: Chao Peng Message-Id: <1478330391-74060-4-git-send-email-chao.p.p...@linux.intel.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 21 -

[Qemu-devel] [PULL 03/25] exec: introduce address_space_extend_translation

2016-12-22 Thread Paolo Bonzini
This extracts the common part of address_space_map and address_space_cache_init into a new function. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- exec.c | 50 +- 1 file changed, 29

[Qemu-devel] [PULL 10/25] qemu-timer: check active_timers outside lock/event

2016-12-22 Thread Paolo Bonzini
This avoids taking the active_timers_lock or resetting/setting the timers_done_ev if there are no active timers. This removes a small (2-3%) source of overhead for dataplane. The list is then checked again inside the lock, or a NULL pointer could be dereferenced. Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 19/25] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-22 Thread Paolo Bonzini
From: Vlad Lungu get_opt_value() truncates the value at the first comma Use memcpy() instead so that -append works correctly in the presence of commas. For -initrd to work right, instead, unescape the module filename and parameters with get_opt_value() before calling

[Qemu-devel] [PULL 01/25] exec: optimize remaining address_space_* cases

2016-12-22 Thread Paolo Bonzini
Do them right before the next patch generalizes them into a multi-included file. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- exec.c | 126 + 1 file changed, 103

[Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9

2016-12-22 Thread Paolo Bonzini
The following changes since commit d1e8e8ecc3d2a1a72504912d671f1cbbac1b06e5: Merge remote-tracking branch 'remotes/huth/tags/target-dirs-20161220' into staging (2016-12-21 21:11:48 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 14/25] target-i386: Add Intel SHA_NI instruction support.

2016-12-22 Thread Paolo Bonzini
From: Yi Sun Add SHA_NI feature bit. Its spec can be found at: https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf Signed-off-by: Yi Sun Message-Id:

[Qemu-devel] [PULL 05/25] watchdog: 6300esb: add exit function

2016-12-22 Thread Paolo Bonzini
From: Li Qiang When the Intel 6300ESB watchdog is hot unplug. The timer allocated in realize isn't freed thus leaking memory leak. This patch avoid this through adding the exit function. Signed-off-by: Li Qiang Message-Id:

[Qemu-devel] [PULL 02/25] exec: introduce memory_ldst.inc.c

2016-12-22 Thread Paolo Bonzini
Templatize the address_space_* and *_phys functions, so that we can add similar functions in the next patch that work with a lightweight, cache-like version of address_space_map/unmap. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 06/25] rules.mak: speedup save-vars load-vars

2016-12-22 Thread Paolo Bonzini
Unnesting variables spends a lot of time parsing and executing foreach and if functions. Because actually very few variables have to be saved and restored, a good strategy is to remember what has to be done in load-vars, and only iterate the right variables in load-vars. For save-vars, unroll the

[Qemu-devel] [PULL 13/25] block: drop remaining legacy aio functions in comment

2016-12-22 Thread Paolo Bonzini
From: Yaowei Bai Commit 87f68d318222563822b5c6b28192215fc4b4e441 (block: drop aio functions that operate on the main AioContext) drops qemu_aio_wait function references mostly while leaves these behind, clean up them. Signed-off-by: Yaowei Bai

[Qemu-devel] [PULL 04/25] exec: introduce MemoryRegionCache

2016-12-22 Thread Paolo Bonzini
Device models often have to perform multiple access to a single memory region that is known in advance, but would to use "DMA-style" functions instead of address_space_map/unmap. This can happen for example when the data has to undergo endianness conversion. Introduce a new data structure to

Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-22 Thread Leif Lindholm
On Wed, Dec 21, 2016 at 06:58:44PM +0100, Paolo Bonzini wrote: > On 21/12/2016 14:59, Igor Mammedov wrote: > >> Apparently a misunderstanding of the underlying command line handling > >> mechanics. > >> > >>> Also this patch would break build for targets that don't link smbios.c > >>> (i.e. which

[Qemu-devel] [PATCH] smbios: filter based on CONFIG_SMBIOS rather than TARGET

2016-12-22 Thread Leif Lindholm
-smbios command line options were accepted but silently ignored on TARGET_ARM, due to a test for TARGET_I386 in arch_init.c. Copy the mechanism of hw/pci/pci-stub.c to implement an smbios-stub instead, enabled for all targets without CONFIG_SMBIOS. Signed-off-by: Leif Lindholm

[Qemu-devel] [PATCH for-2.9 v2 07/10] memhp: move GPE handler_E03 into build_memory_hotplug_aml()

2016-12-22 Thread Igor Mammedov
build hotplug event handler method body in generic hw/acpi/memory_hotplug.c and make hw/i386/acpi-build.c only provide target specific full name of the event handler. That removes hardcoded MEMORY_HOTPLUG_HANDLER_PATH and allows to do target specific memory hotplug AML placement and wiring it with

Re: [Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters

2016-12-22 Thread Eric Blake
On 12/22/2016 08:30 AM, miny...@acm.org wrote: > From: Corey Minyard > > Macro parameters should almost always have () around them when used. > llvm reported an error on this. > > Reported in https://bugs.launchpad.net/bugs/1651167 > > Signed-off-by: Corey Minyard

Re: [Qemu-devel] [PATCH v4 1/2] pcie_aer: Convert pcie_aer_init to Error

2016-12-22 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman > On 21 Dec 2016, at 10:21 AM, Cao jin wrote: > > When user specify invalid value for property aer_log_max, device should > fail to create, and report appropriate message. > > Signed-off-by: Cao jin

[Qemu-devel] QEMU for RISC6000

2016-12-22 Thread giancarlo teodori
Hi, I'm working to emulate aix SO on RISC6000 environment using qemu emulator. I tried to import related patch ([RFC,2/6] prep: add IBM RS/6000 7248 (43p) machine emulation), but this operation give me an error. I'm using a wrong release of qemu code? Do you know a version of qemu already

[Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters

2016-12-22 Thread minyard
From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Reported in https://bugs.launchpad.net/bugs/1651167 Signed-off-by: Corey Minyard --- hw/ipmi/isa_ipmi_bt.c | 18

[Qemu-devel] [Bug 1651167] Re: hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?

2016-12-22 Thread cminyard
** Changed in: qemu Assignee: (unassigned) => cminyard (minyard) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1651167 Title:

Re: [Qemu-devel] [Bug 1651167] [NEW] hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?

2016-12-22 Thread Corey Minyard
On 12/19/2016 09:47 AM, dcb wrote: Public bug reported: I just had a go at compiling qemu trunk with llvm trunk. It said: hw/ipmi/isa_ipmi_bt.c:283:31: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] Source code is

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Igor Mammedov
On Thu, 22 Dec 2016 15:53:55 +0200 Marcel Apfelbaum wrote: > On 12/22/2016 03:31 PM, Igor Mammedov wrote: > > On Thu, 22 Dec 2016 14:31:19 +0200 > > Marcel Apfelbaum wrote: > > > >> On 12/06/2016 01:32 AM, Igor Mammedov wrote: > >>> Move DIMM devices

[Qemu-devel] [PATCH] vexpress fix flash device-width

2016-12-22 Thread David Engraf
The current implementation uses width = 4 and device-width = 2 for the flash configuration. When using u-boot or Linux, the flash is detected as 32 x 16 bit, thus the sector size is doubled to 512 KB. When u-boot sends a sector erase, only the first 256 KB are erased because the QEMU flash

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Marcel Apfelbaum
On 12/22/2016 03:31 PM, Igor Mammedov wrote: On Thu, 22 Dec 2016 14:31:19 +0200 Marcel Apfelbaum wrote: On 12/06/2016 01:32 AM, Igor Mammedov wrote: Move DIMM devices from global _SB scope to a new \_SB.MHPC container along with common methods used by DIMMs: MCRS, MRST,

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Igor Mammedov
On Thu, 22 Dec 2016 14:31:19 +0200 Marcel Apfelbaum wrote: > On 12/06/2016 01:32 AM, Igor Mammedov wrote: > > Move DIMM devices from global _SB scope to a new \_SB.MHPC > > container along with common methods used by DIMMs: > > MCRS, MRST, MPXM, MOST, MEJ00, MSCN, MTFY > > >

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Fam Zheng
On Thu, 12/22 13:33, Holger Schranz wrote: > Hi Fam, > > You win !!! > > I have installed an RH 7.7 based on kernel 3.10 and a SuSE LEAP 42.2 which > is based on kernel 4.4. Both system see the tape devices and can work. > Than I restart in the same session the VM with SLES11 SP4 (kernel

Re: [Qemu-devel] CPU hotplug on Windows 2016 as guest

2016-12-22 Thread Igor Mammedov
On Thu, 22 Dec 2016 10:40:29 +0100 Eduardo Otubo wrote: > Hi guys, > > I'm just trying Qemu 2.7 and 2.8 and Windows 2016 as guest and cpu > hotplug doesn't seem to be working. CPU appears on qemu device tree, but > doesn't appear inside the guest (nor control

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread Eric Blake
[resend, I don't know how I botched the From: line in my first attempt, or if that botch changed who received the mail] On 12/22/2016 12:08 AM, Zhang Chen wrote: >>> Make sense, this command trying to collect status on whether >>> an error has occurred, and the "replication_get_error_all(errp)"

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread addr_cc
On 12/22/2016 12:08 AM, Zhang Chen wrote: >>> Make sense, this command trying to collect status on whether >>> an error has occurred, and the "replication_get_error_all(errp)" >>> is always succeeds. So, Can you suggest to me the right name? >> If replication_get_error_all() always succeeds, then

Re: [Qemu-devel] [PATCH] x86: implement la57 paging mode

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 13:37, Kirill A. Shutemov wrote: > On Fri, Dec 16, 2016 at 01:59:36PM +0100, Paolo Bonzini wrote: >> >> >> On 15/12/2016 01:13, Kirill A. Shutemov wrote: >>> The new paging more is extension of IA32e mode with more additional page >>> table level. >>> >>> It brings support of

Re: [Qemu-devel] [PATCH] x86: implement la57 paging mode

2016-12-22 Thread Kirill A. Shutemov
On Fri, Dec 16, 2016 at 01:59:36PM +0100, Paolo Bonzini wrote: > > > On 15/12/2016 01:13, Kirill A. Shutemov wrote: > > The new paging more is extension of IA32e mode with more additional page > > table level. > > > > It brings support of 57-bit vitrual address space (128PB) and 52-bit > >

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Holger Schranz
Hi Fam, You win !!! I have installed an RH 7.7 based on kernel 3.10 and a SuSE LEAP 42.2 which is based on kernel 4.4. Both system see the tape devices and can work. Than I restart in the same session the VM with SLES11 SP4 (kernel 3.0.101) and an older RH based on kernel 2.6. This both system

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Marcel Apfelbaum
On 12/06/2016 01:32 AM, Igor Mammedov wrote: Move DIMM devices from global _SB scope to a new \_SB.MHPC container along with common methods used by DIMMs: MCRS, MRST, MPXM, MOST, MEJ00, MSCN, MTFY this reduces AML size on 12 * #slots bytes, i.e. up to 3072 bytes for 265 slots. Can you

Re: [Qemu-devel] [PULL 0/1] Move target-xxx folders to target/ folder

2016-12-22 Thread Peter Maydell
On 20 December 2016 at 21:16, Thomas Huth wrote: > The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: > > Open 2.9 development tree (2016-12-20 16:20:16 +) > > are available in the git repository at: > > https://github.com/huth/qemu.git

Re: [Qemu-devel] [kvm-unit-tests PATCH v8 00/14] VT-d unit test

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 12:06, Andrew Jones wrote: > Alex, > > Are you happy with v8? If so, then, as far as I'm concerned, this > series is ready. I'd like to try driving the edu device from ARM > tests too. > > Thanks, > drew There are some minor conflicts, but nothing that I cannot fix. I've pushed

  1   2   >