Re: [Qemu-devel] [PATCH 14/17] qmp: add x-debug-block-dirty-bitmap-sha256

16.02.2017 03:35, John Snow wrote: On 02/13/2017 04:54 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz This is simply the same as the version in the other two series, right? Yes.

[Qemu-devel] [PATCH v7 7/8] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID both from guest memory and from the monitor * test that the "auto" argument to the GUID generates a valid GUID, as seen by the

[Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must

[Qemu-devel] [PATCH v7 3/8] ACPI: Add vmgenid blob storage to the build tables

From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid_guid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() ->

Re: [Qemu-devel] [PATCH v6 5/7] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

> On Feb 15, 2017, at 7:36 AM, Laszlo Ersek wrote: > > Two questions: > > On 02/15/17 07:15, b...@skyportsystems.com > wrote: >> From: Igor Mammedov >> >> Add commands to query Virtual Machine Generation ID counter. >>

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

> On Feb 15, 2017, at 7:24 AM, Laszlo Ersek wrote: > > On 02/15/17 13:19, Igor Mammedov wrote: >> On Tue, 14 Feb 2017 22:15:46 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren >>> >>> This implements the VM Generation ID feature by

Re: [Qemu-devel] [PATCH v6 3/7] ACPI: Add vmgenid blob storage to the build tables

> On Feb 15, 2017, at 6:30 AM, Laszlo Ersek wrote: > > On 02/15/17 07:15, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> This allows them to be centrally initialized and destroyed >> >> The "AcpiBuildTables.vmgenid" array will be used to

[Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context. But the original logic is not correct, we didn't remove the right fd because we call g_main_context_find_source_by_id(NULL, tag) which always try to

[Qemu-devel] [PATCH v2 2/4] colo-compare: kick compare thread to exit after some cleanup in finalization

We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if (qemu_thread_is_self(>thread))' branch. Before compare thead exits,

[Qemu-devel] [PATCH v2 4/4] colo-compare: Fix removing fds been watched incorrectly in finalization

We will catch the bellow error report while try to delete compare object by qmp command: chardev/char-io.c:91: io_watch_poll_finalize: Assertion `iwp->src == ((void *)0)' failed. This is caused by failing to remove the right fd been watched while call qemu_chr_fe_set_handlers(); Fix it by pass

[Qemu-devel] [PATCH v2 0/4] colo-compare: fix some bugs

This series includes two parts: codes optimization and bug fix. patch 1 tries to move timer process into colo compare thread as a new coroutine. patch 2 ~ 4 fixe some bugs of colo compare. v2: - Squash patch 3 of last version into patch 2. (ZhangChen's suggestion) zhanghailiang (4):

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

On 2017年02月16日 13:43, Jason Wang wrote: On 2017年02月16日 13:36, Liu, Yi L wrote: -Original Message- From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] On Behalf Of Michael S. Tsirkin Sent: Tuesday, January 10, 2017 1:40 PM To: qemu-devel@nongnu.org Cc: Peter

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

On 2017年02月16日 13:36, Liu, Yi L wrote: -Original Message- From: Qemu-devel [mailto:qemu-devel-bounces+yi.l.liu=intel@nongnu.org] On Behalf Of Michael S. Tsirkin Sent: Tuesday, January 10, 2017 1:40 PM To: qemu-devel@nongnu.org Cc: Peter Maydell ; Eduardo

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017/2/16 10:27, Zhang Chen wrote: On 02/15/2017 04:34 PM, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by:

Re: [Qemu-devel] [PATCH 5/6] target-ppc: support for 32-bit carry and overflow

Richard Henderson writes: > On 02/14/2017 02:05 PM, Nikunj A Dadhania wrote: >> Yes, you are right. I had a discussion with Paul Mackerras yesterday, he >> explained to me in detail about the bits. I am working on the revised >> implementation. Will detail it in the commit

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

On 2017年02月16日 11:25, Zhang Chen wrote: Ping... No new for a long time. Who can pick up this patch? I believe you'd better cc migration maintainers (cced), have you tried scripts/get_maintainer ? Thanks Thanks Zhang Chen On 02/14/2017 04:28 AM, Stefano Stabellini wrote: On Wed,

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

On Thu, Feb 16, 2017 at 01:48:42PM +1100, David Gibson wrote: > On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: > > On 02/15/2017 03:45 AM, David Gibson wrote: > > > On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > > > > On 02/14/2017 06:15 AM, David Gibson

Re: [Qemu-devel] [PATCH V7 2/2] Add a new qmp command to do checkpoint, query xen replication status

Ping... No new for a long time. Who can pick up this patch? Thanks Zhang Chen On 02/14/2017 04:28 AM, Stefano Stabellini wrote: On Wed, 8 Feb 2017, Eric Blake wrote: On 02/07/2017 11:24 PM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Xen colo will

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

Sorry, pressed the "send" button instead of "expand text" on the previous email ... On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >>

Re: [Qemu-devel] [PATCH] pci/pcie: don't assume cap id 0 is reserved

On Wed, Feb 15, 2017 at 07:52:35PM -0700, Alex Williamson wrote: > On Thu, 16 Feb 2017 10:35:28 +0800 > Peter Xu wrote: > > > On Wed, Feb 15, 2017 at 10:49:47PM +0200, Michael S. Tsirkin wrote: > > > VFIO actually wants to create a capability with ID == 0. > > > This is done

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Check for valid page size when hot plugging memory

On Wed, Feb 15, 2017 at 10:21:44AM +0100, Thomas Huth wrote: > On POWER, the valid page sizes that the guest can use are bound > to the CPU and not to the memory region. QEMU already has some > fancy logic to find out the right maximum memory size to tell > it to the guest during boot (see

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

On Wed, Feb 15, 2017 at 04:59:33PM +0200, Marcel Apfelbaum wrote: > On 02/15/2017 03:45 AM, David Gibson wrote: > > On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > > > On 02/14/2017 06:15 AM, David Gibson wrote: > > > > On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [PATCH v7 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

On Mon, Feb 13, 2017 at 6:43 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:14PM -0800, Ashish Mittal wrote: >> diff --git a/tests/qemu-iotests/common.config >> b/tests/qemu-iotests/common.config >> index f6384fb..c7a80c0 100644 >> ---

Re: [Qemu-devel] [PATCH v7 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 13, 2017 at 6:57 AM, Stefan Hajnoczi wrote: > On Tue, Feb 07, 2017 at 08:18:13PM -0800, Ashish Mittal wrote: >> +static int vxhs_parse_uri(const char *filename, QDict *options) >> +{ >> +URI *uri = NULL; >> +char *hoststr, *portstr; >> +char *port; >> +

Re: [Qemu-devel] [PATCH] pci/pcie: don't assume cap id 0 is reserved

On Thu, 16 Feb 2017 10:35:28 +0800 Peter Xu wrote: > On Wed, Feb 15, 2017 at 10:49:47PM +0200, Michael S. Tsirkin wrote: > > VFIO actually wants to create a capability with ID == 0. > > This is done to make guest drivers skip the given capability. > > pcie_add_capability then

Re: [Qemu-devel] iommu emulation

On Thu, 16 Feb 2017 10:28:39 +0800 Peter Xu wrote: > On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote: > > [...] > > > > Alex, do you like something like below to fix above issue that Jintack > > > has encountered? > > > > > > (note: this code is not for

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017年02月16日 10:43, Hailiang Zhang wrote: On 2017/2/16 10:34, Jason Wang wrote: On 2017年02月15日 16:34, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug.

Re: [Qemu-devel] [PATCH 2/5] colo-compare: kick compare thread to exit while finalize

On 2017/2/16 10:25, Zhang Chen wrote: On 02/15/2017 04:34 PM, zhanghailiang wrote: We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017/2/16 10:34, Jason Wang wrote: On 2017年02月15日 16:34, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH] target-ppc: Add quad precision muladd instructions

On Thu, Feb 16, 2017 at 09:13:31AM +1100, Richard Henderson wrote: > On 02/15/2017 05:37 PM, Bharata B Rao wrote: > > + * > > + * TODO: When float128_muladd() becomes available, switch this > > + * implementation to use that instead of separate float128_mul() > > + * followed by float128_add(). >

Re: [Qemu-devel] [PATCH 2/5] colo-compare: kick compare thread to exit while finalize

On 2017年02月16日 10:25, Zhang Chen wrote: @@ -703,13 +704,11 @@ static void colo_compare_finalize(Object *obj) qemu_chr_fe_deinit(>chr_sec_in); qemu_chr_fe_deinit(>chr_out); -g_queue_free(>conn_list); +g_main_loop_quit(s->compare_loop); +qemu_thread_join(>thread); -

Re: [Qemu-devel] [PATCH] pci/pcie: don't assume cap id 0 is reserved

On Wed, Feb 15, 2017 at 10:49:47PM +0200, Michael S. Tsirkin wrote: > VFIO actually wants to create a capability with ID == 0. > This is done to make guest drivers skip the given capability. > pcie_add_capability then trips up on this capability > when looking for end of capability list. > > To

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 2017年02月15日 16:34, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by: zhanghailiang --- net/colo-compare.c | 20

Re: [Qemu-devel] [PATCH] pcie: simplify pcie_add_capability()

On Thu, Feb 16, 2017 at 10:18:00AM +0800, Cao jin wrote: > Hi peter > > On 02/14/2017 03:51 PM, Peter Xu wrote: > > When we add PCIe extended capabilities, we should be following the rule > > that we add the head extended cap (at offset 0x100) first, then the rest > > of them. Meanwhile, we are

Re: [Qemu-devel] iommu emulation

On Wed, Feb 15, 2017 at 11:15:52AM -0700, Alex Williamson wrote: [...] > > Alex, do you like something like below to fix above issue that Jintack > > has encountered? > > > > (note: this code is not for compile, only trying show what I mean...) > > > > --8<--- > > diff --git

Re: [Qemu-devel] [PATCH 3/5] colo-compare: release all unhandled packets in finalize function

On 02/15/2017 04:34 PM, zhanghailiang wrote: We should release all unhandled packets before finalize colo compare. Besides, we need to free connection_track_table, or there will be a memory leak bug. Signed-off-by: zhanghailiang --- net/colo-compare.c | 20

Re: [Qemu-devel] [PATCH 2/5] colo-compare: kick compare thread to exit while finalize

On 02/15/2017 04:34 PM, zhanghailiang wrote: We should call g_main_loop_quit() to notify colo compare thread to exit, Or it will run in g_main_loop_run() forever. Besides, the finalizing process can't happen in context of colo thread, it is reasonable to remove the 'if

Re: [Qemu-devel] [PATCH] pcie: simplify pcie_add_capability()

On Wed, Feb 15, 2017 at 04:25:05PM +0200, Marcel Apfelbaum wrote: > On 02/14/2017 09:51 AM, Peter Xu wrote: > >When we add PCIe extended capabilities, we should be following the rule > >that we add the head extended cap (at offset 0x100) first, then the rest > >of them. Meanwhile, we are always

Re: [Qemu-devel] [PATCH] pcie: simplify pcie_add_capability()

Hi peter On 02/14/2017 03:51 PM, Peter Xu wrote: > When we add PCIe extended capabilities, we should be following the rule > that we add the head extended cap (at offset 0x100) first, then the rest > of them. Meanwhile, we are always adding new capability bits at the end > of the list. Here the

Re: [Qemu-devel] [PATCH v3 15/16] target-m68k: add more FPU instructions

On 02/07/2017 11:59 AM, Laurent Vivier wrote: +static long double floatx80_to_ldouble(floatx80 val) +{ +if (floatx80_is_infinity(val)) { +if (floatx80_is_neg(val)) { +return -__builtin_infl(); +} +return __builtin_infl(); +} +if

Re: [Qemu-devel] [PATCH v3 14/16] target-m68k: add explicit single and double precision operations

On 02/07/2017 11:59 AM, Laurent Vivier wrote: +case 0: /* fmove */ +break; +case 0x40: /* fsmove */ +gen_helper_redf32_FP0(cpu_env); +gen_helper_extf32_FP0(cpu_env); +break; +case 0x44: /* fdmove */ +gen_helper_redf64_FP0(cpu_env); +

Re: [Qemu-devel] [PATCH v3 13/16] target-m68k: add fsglmul and fsgldiv

On 02/07/2017 11:59 AM, Laurent Vivier wrote: fsglmul and fsgldiv truncate data to single precision before computing results. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 22 ++ target/m68k/helper.h | 2 ++ target/m68k/translate.c |

Re: [Qemu-devel] [PATCH v3 12/16] target-m68k: add fscale, fgetman, fgetexp and fmod

On 02/07/2017 11:59 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 1 + target/m68k/fpu_helper.c | 56 target/m68k/helper.h | 4 target/m68k/translate.c | 14 4

Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts

Hi, > > On Sat, 2017-02-11 at 10:39 -0500, Paolo Bonzini wrote: > > > > > > > > > > > > > > On 10/02/2017 10:31, Gonglei (Arei) wrote: > > > > > > > > > > But We tested the same cases on Xen platform and VMware, and > > > > > the guest booted successfully. > > > > > > > > Were these two also

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

Hi Halil, > > On 02/09/2017 03:29 AM, Gonglei (Arei) wrote: > [..] > > Oh, so much work need to be done. > > > > Halil, Would you mind work together with me to perfect the spec? > > And feel free to add your signed-off-by tag. :) > > > > TBH as a non-native English speaker, it's more difficult

Re: [Qemu-devel] [PATCH v3 07/16] target-m68k: manage FPU exceptions

On 02/07/2017 11:59 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 28 + target/m68k/fpu_helper.c | 107 ++- target/m68k/helper.h | 1 + target/m68k/translate.c | 27

[Qemu-devel] [PATCH v5 8/8] hw/mips: MIPS Boston board support

From: Paul Burton Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs

Re: [Qemu-devel] [PATCH 14/17] qmp: add x-debug-block-dirty-bitmap-sha256

On 02/13/2017 04:54 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz This is simply the same as the version in the other two series, right? Reviewed-by: John Snow >

[Qemu-devel] [PATCH v5 5/8] dtc: Update requirement to v1.4.2

From: Paul Burton In order to obtain fdt_first_subnode & fdt_next_subnode symbols from libfdt for use by a later patch, bump the requirement for dtc to v1.4.2 & the submodule to that same version. Signed-off-by: Paul Burton Reviewed-by: Yongbok

[Qemu-devel] [PATCH v5 7/8] hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller

From: Paul Burton Add support for emulating the Xilinx AXI Root Port Bridge for PCI Express as described by Xilinx' PG055 document. This is a PCIe controller that can be used with certain series of Xilinx FPGAs, and is used on the MIPS Boston board which will make use of

[Qemu-devel] [PATCH v5 4/8] target-mips: Provide function to test if a CPU supports an ISA

From: Paul Burton Provide a new cpu_supports_isa function which allows callers to determine whether a CPU supports one of the ISA_ flags, by testing whether the associated struct mips_def_t sets the ISA flags in its insn_flags field. An example use of this is to allow

[Qemu-devel] [PATCH v5 2/8] hw/mips_gictimer: provide API for retrieving frequency

From: Paul Burton Provide a new function mips_gictimer_get_freq() which returns the frequency at which a GIC timer will count. This will be useful for boards which perform setup based upon this frequency. Signed-off-by: Paul Burton Reviewed-by:

[Qemu-devel] [PATCH v5 6/8] loader: Support Flattened Image Trees (FIT images)

From: Paul Burton Introduce support for loading Flattened Image Trees, as used by modern U-Boot. FIT images are essentially flattened device tree files which contain binary images such as kernels, FDTs or ramdisks along with one or more configuration nodes describing boot

[Qemu-devel] [PATCH v5 0/8] MIPS Boston board support

This series introduces support for the MIPS Boston development board. It begins by introducing support for moving MIPS Coherence Manager GCRs which Boston software typically does to avoid conflicting with its flash memory region. An API is then added to retrieve the emulated MIPS GIC timer

[Qemu-devel] [PATCH v5 1/8] hw/mips_cmgcr: allow GCR base to be moved

From: Paul Burton Support moving the GCR base address & updating the CPU's CP0 CMGCRBase register appropriately. This is required if a platform needs to move its GCRs away from other memory, as the MIPS Boston development board does to avoid its flash memory.

Re: [Qemu-devel] [PATCH v15 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

On 02/15/2017 05:10 AM, Vladimir Sementsov-Ogievskiy wrote: > Add detailed error messages. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow > --- > block/qcow2-bitmap.c | 48 ++-- >

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

On Wed, Feb 15, 2017 at 06=27=32PM +, Daniel P. Berrange wrote: > The current impl of seccomp in QEMU is intentionally allowing a huge range > of system calls to be executed. The goal was that running '-sandbox on' > should never break any feature of QEMU, so naturally any syscall that can >

Re: [Qemu-devel] iommu emulation

On Wed, Feb 15, 2017 at 5:50 PM, Alex Williamson wrote: > On Wed, 15 Feb 2017 17:05:35 -0500 > Jintack Lim wrote: > > > On Tue, Feb 14, 2017 at 9:52 PM, Peter Xu wrote: > > > > > On Tue, Feb 14, 2017 at 07:50:39AM -0500,

Re: [Qemu-devel] [PATCH v15 16/25] qmp: add persistent flag to block-dirty-bitmap-add

On 02/15/2017 05:10 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > Reviewed-by: Max

Re: [Qemu-devel] [PATCH v15 15/25] qcow2: add .bdrv_can_store_new_dirty_bitmap

On 02/15/2017 05:10 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize .bdrv_can_store_new_dirty_bitmap interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, Reviewed-by: John Snow > --- > block/qcow2-bitmap.c | 52 >

Re: [Qemu-devel] [PATCH v6 6/7] tests: Move reusable ACPI macros into a new header file

> On Feb 15, 2017, at 2:56 PM, Eric Blake wrote: > > On 02/15/2017 03:58 PM, Ben Warren wrote: > >>> >>> --- >>> tests/acpi-utils.h | 75 >>> >>> tests/bios-tables-test.c | 72

Re: [Qemu-devel] [RFC QEMU PATCH 1/8] nvdimm: do not initialize label_data if label_size is zero

On Mon, Oct 10, 2016 at 08:34:16AM +0800, Haozhong Zhang wrote: > When memory-backend-xen is used, the label_data pointer can not be got > via memory_region_get_ram_ptr(). We will use other functions to get Could you explain why it cannot be retrieved via that way? > label_data once we introduce

Re: [Qemu-devel] [PATCH] target-ppc: Add quad precision muladd instructions

On 02/15/2017 05:37 PM, Bharata B Rao wrote: + * + * TODO: When float128_muladd() becomes available, switch this + * implementation to use that instead of separate float128_mul() + * followed by float128_add(). Let's just do that, rather than add something that can't pass tests. You should be

Re: [Qemu-devel] [PATCH v6 6/7] tests: Move reusable ACPI macros into a new header file

> On Feb 15, 2017, at 1:35 PM, Eric Blake wrote: > > On 02/15/2017 12:15 AM, b...@skyportsystems.com > wrote: >> From: Ben Warren >> >> Also usable by upcoming VM Generation ID tests >> >> Signed-off-by: Ben Warren

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

On 02/15/2017 04:26 AM, Li Qiang wrote: > Hello, > > 2017-02-15 7:30 GMT+08:00 John Snow >: > > > > On 02/09/2017 08:22 PM, Li Qiang wrote: > > Hello John, > > > > 2017-02-10 3:42 GMT+08:00 John Snow

Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification

Ewww, it looks like I have a mingw disagreement I need to fix; > QEMU_CFLAGS -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/pixman-1 > -I$(SRC_PATH)/dtc/libfdt -Werror -mms-bitfields > -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0 >

Re: [Qemu-devel] [PATCH v4 2/3] report guest crash information in GUEST_PANICKED event

On 02/14/2017 12:25 AM, Denis V. Lunev wrote: > From: Anton Nefedov > > it's not very convenient to use the crash-information property interface, > so provide a CPU class callback to get the guest crash information, and pass > that information in the event > >

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

> On Feb 15, 2017, at 11:14 AM, Ben Warren wrote: > >> >> On Feb 15, 2017, at 10:24 AM, Igor Mammedov > > wrote: >> >> On Wed, 15 Feb 2017 20:04:40 +0200 >> "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

On Wed, 15 Feb 2017 10:14:55 -0800 Ben Warren wrote: > > On Feb 15, 2017, at 10:06 AM, Michael S. Tsirkin wrote: > > > > On Wed, Feb 15, 2017 at 09:54:08AM -0800, Ben Warren wrote: > >> > >>On Feb 15, 2017, at 9:43 AM, Igor Mammedov

Re: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification

Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 0/5] SLIRP VMStatification Message-id: 20170215181922.11624-1-dgilb...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PATCH v3 3/5] slirp: Common lhost/fhost union

From: "Dr. David Alan Gilbert" The socket structure has a pair of unions for lhost and fhost addresses; the unions are identical so split them out into a separate union declaration. Signed-off-by: Dr. David Alan Gilbert --- slirp/socket.h | 18

[Qemu-devel] [PATCH v3 1/5] slirp: VMState conversion; tcpcb

From: "Dr. David Alan Gilbert" Convert the migration of the struct tcpcb to use a VMStateDescription, the rest of it will come later. Mostly mechanical, except for conversion of some 'char' to uint8_t to ensure portability. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH v3 5/5] slirp: VMStatify remaining except for loop

From: "Dr. David Alan Gilbert" This converts the remaining components, except for the top level loop, to VMState. Signed-off-by: Dr. David Alan Gilbert --- slirp/slirp.c | 48 +++- 1 file changed, 19

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

On Wed, Feb 15, 2017 at 06:43:09PM +0100, Igor Mammedov wrote: > On Wed, 15 Feb 2017 18:39:06 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > > > On Wed, 15 Feb 2017 17:30:00 +0200 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH v2] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

Le 13/02/2017 à 23:01, Helge Deller a écrit : > Add the neccessary sockopts for ping and traceroute on IPv6. > > This fixes the following qemu warnings with IPv6: > Unsupported ancillary data: 0/2 > Unsupported ancillary data: 0/11 > Unsupported ancillary data: 41/25 > Unsupported setsockopt

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

> On Feb 15, 2017, at 9:43 AM, Igor Mammedov wrote: > > On Wed, 15 Feb 2017 18:39:06 +0200 > "Michael S. Tsirkin" > wrote: > >> On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: >>> On Wed, 15 Feb 2017 17:30:00 +0200

Re: [Qemu-devel] [RFC PATCH 11/41] vvfat: Implement .bdrv_child_perm()

Am 15.02.2017 um 18:30 hat Max Reitz geschrieben: > On 13.02.2017 18:22, Kevin Wolf wrote: > > vvfat is the last remaining driver that can have children, but doesn't > > implement .bdrv_child_perm() yet. The default handlers aren't suitable > > here, so let's implement a very simple

Re: [Qemu-devel] [RFC PATCH 10/41] block: Request child permissions in format drivers

On 13.02.2017 18:22, Kevin Wolf wrote: > This makes use of the .bdrv_child_perm() implementation for formats that > we just added. All format drivers expose the permissions they actually > need nows, so that they can be set accordingly and updated when parents > are attached or detached. > > The

Re: [Qemu-devel] [RFC PATCH 11/41] vvfat: Implement .bdrv_child_perm()

On 13.02.2017 18:22, Kevin Wolf wrote: > vvfat is the last remaining driver that can have children, but doesn't > implement .bdrv_child_perm() yet. The default handlers aren't suitable > here, so let's implement a very simple driver-specific one that protects > the internal child from being used

[Qemu-devel] [PATCH v4 3/8] hw/mips_gic: Update pin state on mask changes

From: Paul Burton If the GIC interrupt mask is changed by a write to the smask (set mask) or rmask (reset mask) registers, we need to re-evaluate the state of the pins/IRQs fed to the CPU. Without doing so we risk leaving a pin high despite the interrupt that led to that

[Qemu-devel] [PATCH v4 5/8] dtc: Update requirement to v1.4.2

From: Paul Burton In order to obtain fdt_first_subnode & fdt_next_subnode symbols from libfdt for use by a later patch, bump the requirement for dtc to v1.4.2 & the submodule to that same version. Signed-off-by: Paul Burton Reviewed-by: Yongbok

[Qemu-devel] [PATCH v4 8/8] hw/mips: MIPS Boston board support

From: Paul Burton Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs

[Qemu-devel] [PATCH v4 1/8] hw/mips_cmgcr: allow GCR base to be moved

From: Paul Burton Support moving the GCR base address & updating the CPU's CP0 CMGCRBase register appropriately. This is required if a platform needs to move its GCRs away from other memory, as the MIPS Boston development board does to avoid its flash memory.

[Qemu-devel] [PATCH v4 4/8] target-mips: Provide function to test if a CPU supports an ISA

From: Paul Burton Provide a new cpu_supports_isa function which allows callers to determine whether a CPU supports one of the ISA_ flags, by testing whether the associated struct mips_def_t sets the ISA flags in its insn_flags field. An example use of this is to allow

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

On 02/15/17 17:39, Michael S. Tsirkin wrote: > On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: >> On Wed, 15 Feb 2017 17:30:00 +0200 >> "Michael S. Tsirkin" wrote: >> >>> On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: On Wed, 15 Feb 2017

Re: [Qemu-devel] [PATCH v3] backup: allow target without .bdrv_get_info

On Wed, Feb 15, 2017 at 05:58:13PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Currently backup to nbd target is broken, as nbd doesn't have > .bdrv_get_info realization. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > v3: fix compilation (I feel like an

Re: [Qemu-devel] [RFC PATCH 09/41] block: Default .bdrv_child_perm() for format drivers

On 13.02.2017 18:22, Kevin Wolf wrote: > Almost all format drivers have the same characteristics as far as > permissions are concerned: They have one or more children for storing > their own data and, more importantly, metadata (can be written to and > grow even without external write requests,

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

> On Feb 15, 2017, at 8:40 AM, Michael S. Tsirkin wrote: > > On Wed, Feb 15, 2017 at 05:07:57PM +0100, Igor Mammedov wrote: >>> Those improvements can be added later, IMO -- but please do work out >>> with Igor whether he really wants a v7 for those. >> since it's minor fixes

Re: [Qemu-devel] [PATCH 17/18] nbd: BLOCK_STATUS for standard get_block_status function: server part

On 09/02/2017 16:38, Eric Blake wrote: >> +static int blockstatus_to_extent(BlockDriverState *bs, uint64_t offset, >> + uint64_t length, NBDExtent *extent) >> +{ >> +BlockDriverState *file; >> +uint64_t start_sector = offset >> BDRV_SECTOR_BITS; >> +

Re: [Qemu-devel] [PATCH v3] backup: allow target without .bdrv_get_info

Am 15.02.2017 um 15:58 hat Vladimir Sementsov-Ogievskiy geschrieben: > Currently backup to nbd target is broken, as nbd doesn't have > .bdrv_get_info realization. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > v3: fix compilation (I feel like an idiot) >

Re: [Qemu-devel] [PATCH 18/18] nbd: BLOCK_STATUS for standard get_block_status function: client part

On 09/02/2017 17:00, Eric Blake wrote: >> +if (!client->block_status_ok) { >> +*pnum = nb_sectors; >> +ret = BDRV_BLOCK_DATA | BDRV_BLOCK_ALLOCATED; >> +if (bs->drv->protocol_name) { This condition is always true, I think? >> +ret |=

Re: [Qemu-devel] [PATCH 17/18] nbd: BLOCK_STATUS for standard get_block_status function: server part

On 09/02/2017 16:38, Eric Blake wrote: > Umm, why are we sending only one status? If the client requests two ids > during NBD_OPT_SET_META_CONTEXT, we should be able to provide both > pieces of information at once. For a minimal implementation, it works > for proof of concept, but it is pretty

Re: [Qemu-devel] [PATCH 08/18] hbitmap: add next_zero function

On 07/02/2017 23:55, Eric Blake wrote: > On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> The function searches for next zero bit. >> Also add interface for BdrvDirtyBitmap. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block/dirty-bitmap.c

Re: [Qemu-devel] [PATCH 07/18] nbd: Minimal structured read for client

On 07/02/2017 21:14, Eric Blake wrote: > On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> Minimal implementation: always send DF flag, to not deal with fragmented >> replies. > > This works well with your minimal server implementation, but I worry > that it will cause us to fall

Re: [Qemu-devel] [PATCH 06/18] nbd/client: refactor drop_sync

On 08/02/2017 08:55, Vladimir Sementsov-Ogievskiy wrote: > 07.02.2017 02:19, Eric Blake wrote: >> On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Return 0 on success to simplify success checking. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>>

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Swap request limit definitions

On 15.02.2017 17:44, Kevin Wolf wrote: > Am 15.02.2017 um 14:42 hat Max Reitz geschrieben: >> On 14.02.2017 10:52, Alberto Garcia wrote: >>> On Mon 13 Feb 2017 06:13:38 PM CET, Max Reitz wrote: >>> >> -#define BDRV_REQUEST_MAX_SECTORS MIN(SIZE_MAX >> BDRV_SECTOR_BITS, \ >> -

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

On Wed, Feb 15, 2017 at 05:07:57PM +0100, Igor Mammedov wrote: > > Those improvements can be added later, IMO -- but please do work out > > with Igor whether he really wants a v7 for those. > since it's minor fixes not influencing other patches within series > there is not need to repost whole

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

On Wed, Feb 15, 2017 at 04:56:02PM +0100, Igor Mammedov wrote: > On Wed, 15 Feb 2017 17:30:00 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 15, 2017 at 04:22:25PM +0100, Igor Mammedov wrote: > > > On Wed, 15 Feb 2017 15:13:20 +0100 > > > Laszlo Ersek

Re: [Qemu-devel] [PATCH 1/1] qemu-iotests: redirect nbd server stdout to /dev/null

Am 14.02.2017 um 19:42 hat Eric Blake geschrieben: > On 02/14/2017 12:15 PM, Jeff Cody wrote: > > Some iotests (e.g. 174) try to filter the output of _make_test_image by > > piping the stdout. Pipe the server stdout to /dev/null, so that filter > > pipe does not need to wait until process

Re: [Qemu-devel] [Qemu-discuss] Estimation of qcow2 image size converted from raw image

On Wed, Feb 15, 2017 at 05:05:04PM +0100, Alberto Garcia wrote: > On Wed 15 Feb 2017 04:57:12 PM CET, Nir Soffer wrote: > >>> Let's try this syntax: > >>> > >>> $ qemu-img query-max-size -f raw -O qcow2 input.raw > >>> 1234678000 > >>> > >>> As John explained, it is only an estimate. But it

  1   2   >