[Qemu-devel] [Bug 1668556] Re: QEMU Guest Agent service fails to start on Windows 10 RS2 preview

2017-03-02 Thread Michael Klopf
Not a bug! I have forgotten to add the socket in the start script :( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1668556 Title: QEMU Guest Agent service fails to start on Windows 10 RS2

Re: [Qemu-devel] iommu emulation

2017-03-02 Thread Bandan Das
Peter Xu writes: > On Thu, Mar 02, 2017 at 05:20:19PM -0500, Bandan Das wrote: >> Jintack Lim writes: >> >> > [cc Bandan] >> > ... >> >> Jintack, any progress with this ? >> >> I am testing on a X540-AT2 and I see a different behavior. It appears

Re: [Qemu-devel] [Qemu-block] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json()

2017-03-02 Thread Markus Armbruster
Niels de Vos writes: > On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus Armbruster wrote: >> To reproduce, run >> >> $ valgrind qemu-system-x86_64 --nodefaults -S --drive >> driver=gluster,volume=testvol,path=/a/b/c,server.0.type=xxx >> >> Signed-off-by: Markus

Re: [Qemu-devel] [Qemu-block] [PATCH 10/15] gluster: Drop assumptions on SocketTransport names

2017-03-02 Thread Markus Armbruster
Niels de Vos writes: > On Thu, Mar 02, 2017 at 10:44:01PM +0100, Markus Armbruster wrote: >> qemu_gluster_glfs_init() passes the names of QAPI enumeration type >> SocketTransport to glfs_set_volfile_server(). Works, because they >> were chosen to match. But the coupling is

Re: [Qemu-devel] [Qemu-block] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json()

2017-03-02 Thread Niels de Vos
On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus Armbruster wrote: > To reproduce, run > > $ valgrind qemu-system-x86_64 --nodefaults -S --drive > driver=gluster,volume=testvol,path=/a/b/c,server.0.type=xxx > > Signed-off-by: Markus Armbruster > --- > block/gluster.c |

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/3] throttle: improve command-line parameter documentation

2017-03-02 Thread Greg Kurz
On Fri, 3 Mar 2017 10:11:09 +0800 Stefan Hajnoczi wrote: > On Wed, Mar 01, 2017 at 10:27:48PM +0100, Greg Kurz wrote: > > On Wed, 1 Mar 2017 11:50:23 + > > Stefan Hajnoczi wrote: > > > > > v3: > > > * Added Patch 2 to fix invalid test parameters

[Qemu-devel] [PATCH 1/3] target/ppc: fmadd check for excp independently

2017-03-02 Thread Nikunj A Dadhania
Current order of checking does not confirm with the spec (ISA 3.0: MultiplyAddDP page-469). Change the order and make them independent of each other. For example: a = infinity, b = zero, c = SNaN, this should set both VXIMZ and VXNAN Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PATCH 0/3] target/ppc: floating point multiply-add fixes

2017-03-02 Thread Nikunj A Dadhania
Exception handling in fmadd/fmsub/fnmadd/fnmsub isnt correct as the order of checking could give wrong settings in FPSCR. For example, (x * y) + z, if x = infinity, y = zero and z = snan. After the execution of instruction VXNAN and VXIMZ both should be set. For this correct the ordering in

[Qemu-devel] [PATCH 2/3] target/ppc: fmadd: add macro for updating flags

2017-03-02 Thread Nikunj A Dadhania
Adds FPU_MADDSUB_UPDATE macro, this will be used for other routines having float32/16 Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 62 - 1 file changed, 31 insertions(+), 31 deletions(-) diff --git

[Qemu-devel] [PATCH 3/3] target/ppc: use helper for excp handling

2017-03-02 Thread Nikunj A Dadhania
Use the helper routine float[32,64]_maddsub_update_excp() in VSX_MADD macro. Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/target/ppc/fpu_helper.c

Re: [Qemu-devel] [Qemu-block] [PATCH 10/15] gluster: Drop assumptions on SocketTransport names

2017-03-02 Thread Niels de Vos
On Thu, Mar 02, 2017 at 10:44:01PM +0100, Markus Armbruster wrote: > qemu_gluster_glfs_init() passes the names of QAPI enumeration type > SocketTransport to glfs_set_volfile_server(). Works, because they > were chosen to match. But the coupling is artificial. Use the > appropriate literal

Re: [Qemu-devel] [Qemu-block] [PATCH 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse()

2017-03-02 Thread Niels de Vos
On Thu, Mar 02, 2017 at 10:44:02PM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/gluster.c | 30 +- > 1 file changed, 9 insertions(+), 21 deletions(-) > > diff --git a/block/gluster.c b/block/gluster.c > index

[Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-02 Thread David Gibson
The following changes since commit ecb24d334af1a98ef0329f4b3b0e14ae8cb8770d: Merge remote-tracking branch 'remotes/rth/tags/pull-tgt-20170302' into staging (2017-03-02 22:06:41 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/submodule-update-20170303

Re: [Qemu-devel] using fdt_setprop() to set properties to empty values

2017-03-02 Thread David Gibson
On Mon, Feb 27, 2017 at 10:11:57AM +, Peter Maydell wrote: > On 27 February 2017 at 01:05, David Gibson > wrote: > > On Fri, Feb 24, 2017 at 10:35:35AM +, Peter Maydell wrote: > >> On 24 February 2017 at 00:16, David Gibson > >>

[Qemu-devel] [PULL 2/2] Update dtc submodule to v1.4.3

2017-03-02 Thread David Gibson
Since the last submodule update (which was v1.4.2) dtc and libfdt have gained some features which would be useful in qemu. There's now a v1.4.3 upstream release, so update our submodule to point to it. Signed-off-by: David Gibson --- dtc | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH v7 kernel 5/5] This patch contains two parts:

2017-03-02 Thread Wei Wang
From: Liang Li One is to add a new API to mm go get the unused page information. The virtio balloon driver will use this new API added to get the unused page info and send it to hypervisor(QEMU) to speed up live migration. During sending the bitmap, some the pages may be

[Qemu-devel] [PATCH v7 kernel 4/5] virtio-balloon: define flags and head for host request vq

2017-03-02 Thread Wei Wang
From: Liang Li Define the flags and head struct for a new host request virtual queue. Guest can get requests from host and then responds to them on this new virtual queue. Host can make use of this virtqueue to request the guest to do some operations, e.g. drop page cache,

[Qemu-devel] [PATCH v7 kernel 1/5] virtio-balloon: rework deflate to add page to a list

2017-03-02 Thread Wei Wang
From: Liang Li When doing the inflating/deflating operation, the current virtio-balloon implementation uses an array to save 256 PFNS, then send these PFNS to host through virtio and process each PFN one by one. This way is not efficient when inflating/deflating a large

[Qemu-devel] [PATCH v7 kernel 3/5] virtio-balloon: implementation of VIRTIO_BALLOON_F_CHUNK_TRANSFER

2017-03-02 Thread Wei Wang
From: Liang Li The implementation of the current virtio-balloon is not very efficient, because the pages are transferred to the host one by one. Here is the breakdown of the time in percentage spent on each step of the balloon inflating process (inflating 7GB of an 8GB idle

[Qemu-devel] [PATCH v7 kernel 2/5] virtio-balloon: VIRTIO_BALLOON_F_CHUNK_TRANSFER

2017-03-02 Thread Wei Wang
From: Liang Li Add a new feature bit, VIRTIO_BALLOON_F_CHUNK_TRANSFER. Please check the implementation patch commit for details about this feature. Signed-off-by: Liang Li Signed-off-by: Wei Wang Cc: Michael S. Tsirkin

[Qemu-devel] [PATCH v7 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2017-03-02 Thread Wei Wang
Take over this work from Liang. This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 1) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Please check patch 0003 for more details about

Re: [Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster

2017-03-02 Thread Markus Armbruster
Eric Blake writes: > On 03/02/2017 03:43 PM, Markus Armbruster wrote: >> Bad error handling, memory leaks, and lack of blockdev-add support. > > How hard are we trying to get blockdev-add working in 2.9? Or is this > series 2.10 material now? Definitely not 2.10: seven

Re: [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

2017-03-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 03/02/2017 08:32 PM, Eric Blake wrote: >> On 03/02/2017 03:43 PM, Markus Armbruster wrote: >>> sd_parse_uri() truncates long VDI names silently. Reject them >>> instead. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>>

Re: [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-02 Thread Markus Armbruster
Eric Blake writes: > On 03/02/2017 03:43 PM, Markus Armbruster wrote: >> As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an >> error and return negative errno on failure. It sometimes returns -1, >> and sometimes neglects to set an error. It also prints

Re: [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

2017-03-02 Thread Markus Armbruster
Eric Blake writes: > On 03/02/2017 03:43 PM, Markus Armbruster wrote: >> sd_parse_uri() truncates long VDI names silently. Reject them >> instead. >> >> Signed-off-by: Markus Armbruster >> --- >> block/sheepdog.c | 4 +++- >> 1 file changed, 3

Re: [Qemu-devel] [PATCH 01/15] sheepdog: Defuse time bomb in sd_open() error handling

2017-03-02 Thread Markus Armbruster
Eric Blake writes: > On 03/02/2017 03:43 PM, Markus Armbruster wrote: >> When qemu_opts_absorb_qdict() fails, sd_open() closes stdin, because >> sd->fd is still zero. Fortunately, qemu_opts_absorb_qdict() can't >> fail, because: >> >> 1. it only fails when qemu_opt_parse()

Re: [Qemu-devel] [RFC PATCH v2 08/12] spapr: Only setup HTP if necessary.

2017-03-02 Thread David Gibson
On Wed, Mar 01, 2017 at 04:17:43PM +1100, Suraj Jitindar Singh wrote: > On Tue, 2017-02-28 at 14:19 +1100, David Gibson wrote: > > On Tue, Feb 28, 2017 at 01:25:17PM +1100, Suraj Jitindar Singh wrote: > > > > > > On Tue, 2017-02-28 at 11:28 +1100, David Gibson wrote: > > > > > > > > s/HTP/HPT/

[Qemu-devel] [RFC] x86: Allow to set NUMA distance for different NUMA nodes

2017-03-02 Thread He Chen
Current, QEMU does not provide a clear command to set vNUMA distance for guest although we already have `-numa` command to set vNUMA nodes. vNUMA distance makes sense in certain scenario. But now, if we create a guest that has 4 vNUMA nodes, when we check NUMA info via `numactl -H`, we will see:

Re: [Qemu-devel] [PATCH] memory: show region offset and ROM/RAM type in "info mtree -f"

2017-03-02 Thread Peter Xu
On Thu, Mar 02, 2017 at 10:56:03PM +0100, Paolo Bonzini wrote: > "info mtree -f" output is currently hard to use for large RAM regions, because > there is no hint as to what part of the region is being mapped. Add the > offset > if it is nonzero. > > Secondly, FlatView has a readonly field,

Re: [Qemu-devel] [PATCH v2] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-02 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Fri, Mar 03, 2017 at 02:31:38PM +1100, Richard Henderson wrote: >> On 03/03/2017 01:10 AM, Nikunj A Dadhania wrote: >> > +static void float64_maddsub_update_excp(CPUPPCState *env, float64 arg1, >> > +

Re: [Qemu-devel] [PULL 00/17] ppc-for-2.9 queue 20170303

2017-03-02 Thread David Gibson
On Thu, Mar 02, 2017 at 07:40:58PM -0800, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20170303032507.16142-1-da...@gibson.dropbear.id.au > Type: series > Subject: [Qemu-devel] [PULL 00/17]

Re: [Qemu-devel] [PATCH v2] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-02 Thread David Gibson
On Fri, Mar 03, 2017 at 02:31:38PM +1100, Richard Henderson wrote: > On 03/03/2017 01:10 AM, Nikunj A Dadhania wrote: > > +static void float64_maddsub_update_excp(CPUPPCState *env, float64 arg1, > > +float64 arg2, float64 arg3, > > +

Re: [Qemu-devel] [PATCH v2] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-02 Thread Nikunj A Dadhania
Richard Henderson writes: > On 03/03/2017 01:10 AM, Nikunj A Dadhania wrote: >> +static void float64_maddsub_update_excp(CPUPPCState *env, float64 arg1, >> +float64 arg2, float64 arg3, >> +unsigned

Re: [Qemu-devel] iommu emulation

2017-03-02 Thread Peter Xu
On Thu, Mar 02, 2017 at 05:20:19PM -0500, Bandan Das wrote: > Jintack Lim writes: > > > [cc Bandan] > > > > On Tue, Feb 21, 2017 at 5:33 AM, Jintack Lim > > wrote: > > > >> > >> > >> On Wed, Feb 15, 2017 at 9:47 PM, Alex Williamson < > >>

Re: [Qemu-devel] [PULL 00/17] ppc-for-2.9 queue 20170303

2017-03-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170303032507.16142-1-da...@gibson.dropbear.id.au Type: series Subject: [Qemu-devel] [PULL 00/17] ppc-for-2.9 queue 20170303 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PULL 17/17] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-02 Thread David Gibson
From: Nikunj A Dadhania Use the softfloat api for fused multiply-add. Introduce routine to set the FPSCR flags VXNAN, VXIMZ nad VMISI. Signed-off-by: Nikunj A Dadhania Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 06/17] target/ppc: Don't gen an SDR1 on POWER9 and rework register creation

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh POWER9 doesn't have a storage description register 1 (SDR1) which is used to store the base and size of the hash table. Thus we don't need to generate this register on the POWER9 cpu model. While we're here, the register generation code for

Re: [Qemu-devel] [PATCH v2] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-02 Thread Richard Henderson
On 03/03/2017 01:10 AM, Nikunj A Dadhania wrote: +static void float64_maddsub_update_excp(CPUPPCState *env, float64 arg1, +float64 arg2, float64 arg3, +unsigned int madd_flags) { +if

[Qemu-devel] [PULL 16/17] spapr: Small cleanup of PPC MMU enums

2017-03-02 Thread David Gibson
From: Sam Bobroff The PPC MMU types are sometimes treated as if they were a bit field and sometime as if they were an enum which causes maintenance problems: flipping bits in the MMU type (which is done on both the 1TB segment and 64K segment bits) currently produces new

[Qemu-devel] [PULL 12/17] target/ppc: Add execute permission checking to access authority check

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh Basic storage protection defines various access authority permissions based on a slb storage key and pte pp value pair. This access authority defines read, write and execute permissions however currently we only use this to control read and

[Qemu-devel] [PULL 13/17] target/ppc: Move no-execute and guarded page checking into new function

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh A pte entry has bit fields which can be used to make a page no-execute or guarded, if either of these bits are set then an instruction access to this page will fail. Currently these bits are checked with the pp_prot function however the ISA

[Qemu-devel] [PULL 15/17] spapr_pci: Advertise access to PCIe extended config space

2017-03-02 Thread David Gibson
The (paravirtual) PCI host bridge on the 'pseries' machine in most regards acts like a regular PCI bus, rather than a PCIe bus. Despite this, though, it does allow access to the PCIe extended config space. We already implemented the RTAS methods to allow this access.. but forgot to put the

[Qemu-devel] [PULL 14/17] target/ppc: Rework hash mmu page fault code and add defines for clarity

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh The hash mmu page fault handling code is responsible for generating ISIs and DSIs when access permissions cause an access to fail. Part of this involves setting the srr1 or dsisr registers to indicate what causes the access to fail. Add

[Qemu-devel] [PULL 07/17] target/ppc/POWER9: Add POWER9 mmu fault handler

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh Add a new mmu fault handler for the POWER9 cpu and add it as the handler for the POWER9 cpu definition. This handler checks if the guest is radix or hash based on the value in the partition table entry and calls the correct fault handler

[Qemu-devel] [PULL 05/17] target/ppc: Add patb_entry to sPAPRMachineState

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh ISA v3.00 adds the idea of a partition table which is used to store the address translation details for all partitions on the system. The partition table consists of double word entries indexed by partition id where the second double word

[Qemu-devel] [PULL 09/17] target/ppc/POWER9: Add cpu_has_work function for POWER9

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh The cpu has work function is used to mask interrupts used to determine if there is work for the cpu based on the LPCR. Add a function to do this for POWER9 and add it to the POWER9 cpu definition. This is similar to that for POWER8 except

[Qemu-devel] [PULL 11/17] target/ppc: Add Instruction Authority Mask Register Check

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh The instruction authority mask register (IAMR) can be used to restrict permissions for instruction fetch accesses on a per key basis for each of 32 different key values. Access permissions are derived based on the specific key value stored in

[Qemu-devel] [PULL 02/17] exec, kvm, target-ppc: Move getrampagesize() to common code

2017-03-02 Thread David Gibson
From: Alexey Kardashevskiy getrampagesize() returns the largest supported page size and mainly used to know if huge pages are enabled. However is implemented in target-ppc/kvm.c and not available in TCG or other architectures. This renames and moves gethugepagesize() to

[Qemu-devel] [PULL 08/17] target/ppc/POWER9: Add POWER9 pa-features definition

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh Add a pa-features definition which includes all of the new fields which have been added, note we don't claim support for any of these new features at this stage. Signed-off-by: Suraj Jitindar Singh Reviewed-by:

[Qemu-devel] [PULL 04/17] target/ppc/POWER9: Add POWERPC_MMU_V3 bit

2017-03-02 Thread David Gibson
For easier handling of future processors using the POWER9 or something close to it, add a new bit in the MMU model. This was originally from a revised version of 86cf1e9 "target/ppc/POWER9: Add ISAv3.00 MMU definition" but the older version of the patch was already merged. This makes the change

[Qemu-devel] [PULL 03/17] powernv: Don't test POWER9 CPU yet

2017-03-02 Thread David Gibson
A couple of tests for the work-in-progress 'powernv' machine type attempt to test on POWER9 CPUs. However the POWER9 CPU support is incomplete and this doesn't really work. In particular the firmware image we have currently assumes the presence of the SDR1 register, which no longer exists on

[Qemu-devel] [PULL 01/17] target/ppc: Add POWER9/ISAv3.00 to compat_table

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh compat_table contains the list of logical pvr compat modes which a cpu can operate in. It is a list of struct CompatInfo which contains the given pvr value for a compat mode, the pcr bits which should be set to operate in that compat mode, the

[Qemu-devel] [PULL 10/17] hw/ppc/spapr: Add POWER9 to pseries cpu models

2017-03-02 Thread David Gibson
From: Suraj Jitindar Singh Add POWER9 cpu to list of spapr core models which allows it to be specified as the cpu model for a pseries guest (e.g. -machine pseries -cpu POWER9). This now allows a POWER9 cpu to boot to userspace in tcg emulation for a pseries machine

[Qemu-devel] [PULL 00/17] ppc-for-2.9 queue 20170303

2017-03-02 Thread David Gibson
The following changes since commit ecb24d334af1a98ef0329f4b3b0e14ae8cb8770d: Merge remote-tracking branch 'remotes/rth/tags/pull-tgt-20170302' into staging (2017-03-02 22:06:41 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.9-20170303

[Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2017-03-02 Thread Alexey Kardashevskiy
The following changes since commit ecb24d334af1a98ef0329f4b3b0e14ae8cb8770d: Merge remote-tracking branch 'remotes/rth/tags/pull-tgt-20170302' into staging (2017-03-02 22:06:41 +) are available in the git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20170303 for you

Re: [Qemu-devel] [GIT PULL for pseries] pseries: Update SLOF firmware image

2017-03-02 Thread Alexey Kardashevskiy
On 03/03/17 13:42, Alexey Kardashevskiy wrote: > The following changes since commit 138c1712bc9d5ea3a4de03e2d463259a11362367: > > pseries: Update SLOF firmware image (2017-03-03 13:35:43 +1100) > > are available in the git repository at: > > g...@github.com:aik/qemu.git > > for you to

[Qemu-devel] [GIT PULL for pseries] pseries: Update SLOF firmware image

2017-03-02 Thread Alexey Kardashevskiy
The following changes since commit 138c1712bc9d5ea3a4de03e2d463259a11362367: pseries: Update SLOF firmware image (2017-03-03 13:35:43 +1100) are available in the git repository at: g...@github.com:aik/qemu.git for you to fetch changes up to 138c1712bc9d5ea3a4de03e2d463259a11362367:

Re: [Qemu-devel] [PATCH 1/1] event_notifier: prevent accidental use after close

2017-03-02 Thread Stefan Hajnoczi
On Thu, Mar 02, 2017 at 07:13:08PM +0100, Halil Pasic wrote: > Let's set the handles to the underlying facilities to their extremal > value so no accidental misuse can happen, and to make it obvious that the > notifier is dysfunctional. E.g. if we just close an fd but do not touch > the int

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/3] throttle: improve command-line parameter documentation

2017-03-02 Thread Stefan Hajnoczi
On Wed, Mar 01, 2017 at 11:50:23AM +, Stefan Hajnoczi wrote: > v3: > * Added Patch 2 to fix invalid test parameters > * Switched to nicer max < avg check [Berto] > v2: > * Fixed s/bps/iops/ copy-paste error in Patch 1 [Berto] > * Rephrased warning about guest hangs and errors [Berto] > *

Re: [Qemu-devel] Regarding Gsoc17

2017-03-02 Thread Stefan Hajnoczi
On Wed, Mar 01, 2017 at 11:03:31PM +0530, Mohammad Sameer Malik wrote: > Hi i am Mohammad Sameer Malik a Btech undergraduate in Electronics and > Communication at IIIT Delhi and i want to be a part of GSOC 17 as a student > and want to chose Qemu as my organisation i have strong web development

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-02 Thread BALATON Zoltan
On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 18:46, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- v2: Split off small clean up to other patch hw/display/sm501.c | 6 +++--- hw/display/sm501_template.h | 23

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/3] throttle: improve command-line parameter documentation

2017-03-02 Thread Stefan Hajnoczi
On Wed, Mar 01, 2017 at 10:27:48PM +0100, Greg Kurz wrote: > On Wed, 1 Mar 2017 11:50:23 + > Stefan Hajnoczi wrote: > > > v3: > > * Added Patch 2 to fix invalid test parameters > > * Switched to nicer max < avg check [Berto] > > v2: > > * Fixed s/bps/iops/ copy-paste

[Qemu-devel] [PATCH v3 01/13] sm501: Fixed code style and a few typos in comments

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 1132 ++- hw/display/sm501_template.h | 52 +- 2 files changed, 594 insertions(+), 590 deletions(-) diff --git

[Qemu-devel] [PATCH v3 03/13] sm501: Add missing arbitration control register

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6b72964..6e74200 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -474,6 +474,7 @@ typedef struct

[Qemu-devel] [PATCH v3 04/13] sm501: QOMify

2017-03-02 Thread BALATON Zoltan
Adding vmstate saving is not in this patch because the state structure will be changed in further patches, then another patch will add vmstate descriptor after those changes. Signed-off-by: BALATON Zoltan --- v2: Add memory regions to device state instead of allocating them

[Qemu-devel] [PATCH v3 11/13] sm501: Add some more missing registers

2017-03-02 Thread BALATON Zoltan
This is to allow clients to initialise these without failing as long as no 2D engine function is called that would use the written value. Saved values are not used yet (may get used when more of 2D engine is added sometimes) and clients normally only write to most of these registers, nothing is

Re: [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI

2017-03-02 Thread BALATON Zoltan
On Thu, 2 Mar 2017, Peter Maydell wrote: On 2 March 2017 at 20:13, BALATON Zoltan wrote: On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 18:31, BALATON Zoltan wrote: Only the display controller part is created automatically on PCI

[Qemu-devel] [PATCH v3 08/13] sm501: Fix hardware cursor

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v3: simplify return expression in get_bpp hw/display/sm501.c | 169 +--- hw/display/sm501_template.h | 25 +++ 2 files changed, 107 insertions(+), 87 deletions(-) diff --git

[Qemu-devel] [PATCH v3 07/13] sm501: Fix device endianness

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v2: Split off small clean up to other patch hw/display/sm501.c | 6 +++--- hw/display/sm501_template.h | 23 ++- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/display/sm501.c

[Qemu-devel] [PATCH v3 02/13] sm501: Use defined constants instead of literal values where available

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v3: Fix initial value of misc_control register as Peter Maydell suggested Also use M_BYTE constant from cutils.h hw/display/sm501.c | 29 +++-- hw/display/sm501_template.h | 2 +- 2 files changed, 20

[Qemu-devel] [PATCH v3 12/13] sm501: Add vmstate descriptor

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v3: Added local_mem_size_index to vmstate, add vmstate for sysbus version too hw/display/sm501.c | 100 - 1 file changed, 99 insertions(+), 1 deletion(-) diff --git a/hw/display/sm501.c

[Qemu-devel] [PATCH v3 05/13] sm501: Get rid of base address in draw_hwc_line

2017-03-02 Thread BALATON Zoltan
Do not use the base address to access data in local memory. This is in preparation to allow chip connected via PCI where base address depends on where the BAR is mapped so it will be unknown. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v3 06/13] sm501: Add emulation of chip connected via PCI

2017-03-02 Thread BALATON Zoltan
Only the display controller part is created automatically on PCI Signed-off-by: BALATON Zoltan --- v2: Split off removing dependency on base address to separate patch v3: Added reset function and PCI ID constant definitions in pci_ids.h hw/display/sm501.c | 58

[Qemu-devel] [PATCH v3 09/13] sm501: Misc clean ups

2017-03-02 Thread BALATON Zoltan
- Rename a variable - Move variable declarations out of loop to the beginning in draw_hwc_line Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 10 +- hw/display/sm501_template.h | 10 -- 2

[Qemu-devel] [PATCH v3 10/13] sm501: Add support for panel layer

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off renaming a variable to separate clean up patch hw/display/sm501.c | 63 +++--- 1 file changed, 32 insertions(+), 31

[Qemu-devel] [PATCH v3 00/13] Improvements for SM501 display controller emulation

2017-03-02 Thread BALATON Zoltan
Third version addressing points that came up in review of v2. BALATON Zoltan (13): sm501: Fixed code style and a few typos in comments sm501: Use defined constants instead of literal values where available sm501: Add missing arbitration control register sm501: QOMify sm501: Get rid of

[Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets

2017-03-02 Thread BALATON Zoltan
This is not used by default on any emulated machine yet but it is still useful to have it compiled so it can be added from the command line for clients that can use it (e.g. MorphOS has no driver for any other emulated video cards but can output via SM501) Signed-off-by: BALATON Zoltan

Re: [Qemu-devel] [PATCH RFC] block: Tolerate existing writers on read only BdrvChild

2017-03-02 Thread Fam Zheng
On Thu, 03/02 15:23, Kevin Wolf wrote: > Am 02.03.2017 um 12:21 hat Fam Zheng geschrieben: > > On Wed, 03/01 17:22, Kevin Wolf wrote: > > > Am 01.03.2017 um 17:10 hat Fam Zheng geschrieben: > > > > On Wed, 03/01 16:16, Kevin Wolf wrote: > > > > > > I'm not sure about this because: 1) this is

Re: [Qemu-devel] [PATCH v2] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-02 Thread David Gibson
On Thu, Mar 02, 2017 at 07:40:29PM +0530, Nikunj A Dadhania wrote: > Use the softfloat api for fused multiply-add. > Introduce routine to set the FPSCR flags VXNAN, VXIMZ nad VMISI. > > Signed-off-by: Nikunj A Dadhania Merged, thanks. > > --- > > v1: > * Removed

Re: [Qemu-devel] [PATCH v14 00/24] MTTCG Base enabling patches with ARM enablement

2017-03-02 Thread Programmingkid
On Feb 25, 2017, at 10:03 PM, Pranith Kumar wrote: > On Sat, Feb 25, 2017 at 8:46 PM, Programmingkid > wrote: >> >> >> With the i386 target, I did see host CPU usage go up to 120%. That was nice >> to see. Windows XP and Windows 2000 would not boot to the desktop

Re: [Qemu-devel] git master build failure in 9pfs

2017-03-02 Thread Programmingkid
On Mar 2, 2017, at 1:26 PM, qemu-devel-requ...@nongnu.org wrote: > > Does anyone else see the following error when trying to build git master? > > cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs > -I/home/build/src/qemu/git/qemu/tcg > -I/home/build/src/qemu/git/qemu/tcg/i386 >

Re: [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

2017-03-02 Thread Philippe Mathieu-Daudé
On 03/02/2017 08:32 PM, Eric Blake wrote: On 03/02/2017 03:43 PM, Markus Armbruster wrote: sd_parse_uri() truncates long VDI names silently. Reject them instead. Signed-off-by: Markus Armbruster --- block/sheepdog.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

2017-03-02 Thread Philippe Mathieu-Daudé
On 03/02/2017 06:43 PM, Markus Armbruster wrote: sd_parse_uri() truncates long VDI names silently. Reject them instead. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- block/sheepdog.c | 4 +++- 1 file changed, 3

Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

2017-03-02 Thread Philippe Mathieu-Daudé
On 03/02/2017 06:43 PM, Markus Armbruster wrote: As a bdrv_create() method, sd_create() must set an error and return negative errno on failure. It prints the error instead of setting it when connect_to_sdog() fails. Fix that. While there, return the value of connect_to_sdog() like we do

Re: [Qemu-devel] [PATCH] memory: show region offset and ROM/RAM type in "info mtree -f"

2017-03-02 Thread Philippe Mathieu-Daudé
On 03/02/2017 06:56 PM, Paolo Bonzini wrote: "info mtree -f" output is currently hard to use for large RAM regions, because there is no hint as to what part of the region is being mapped. Add the offset if it is nonzero. Secondly, FlatView has a readonly field, that can override the

Re: [Qemu-devel] [PATCH 1/3] ide: qdev: register ide bus unrealize function

2017-03-02 Thread Philippe Mathieu-Daudé
On 03/02/2017 07:08 AM, Li Qiang wrote: we have an idebus unrealize function, but it was being registered as the unrealize function for the IDE Device, so it was not getting invoked on device teardown because nothing is "unrealizing" the IDE devices themselves. nice catch Suggested-by: John

Re: [Qemu-devel] iommu emulation

2017-03-02 Thread Jintack Lim
On Thu, Mar 2, 2017 at 5:20 PM, Bandan Das wrote: > Jintack Lim writes: > >> [cc Bandan] >> >> On Tue, Feb 21, 2017 at 5:33 AM, Jintack Lim >> wrote: >> >>> >>> >>> On Wed, Feb 15, 2017 at 9:47 PM, Alex Williamson < >>>

Re: [Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > Bad error handling, memory leaks, and lack of blockdev-add support. How hard are we trying to get blockdev-add working in 2.9? Or is this series 2.10 material now? > > Markus Armbruster (15): > sheepdog: Defuse time bomb in sd_open() error

Re: [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > sd_parse_uri() truncates long VDI names silently. Reject them > instead. > > Signed-off-by: Markus Armbruster > --- > block/sheepdog.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > sd_parse_uri() and sd_snapshot_goto() screw up error checking after > strtoul(), and truncate long tag names silently. Fix by replacing > those parts by new sd_parse_snapid_or_tag(), which checks more > carefully. At least we've fixed checkpatch

Re: [Qemu-devel] [PULL v4 00/19] KVM and cpu-exec patches for 2.9 soft freeze

2017-03-02 Thread Peter Maydell
On 2 March 2017 at 18:01, Paolo Bonzini wrote: > > > On 01/03/2017 18:58, Peter Maydell wrote: >> Fails to build, ppc64, aarch64 (and probably others): >> >> In file included from /home/pm215/qemu/include/qemu/osdep.h:36:0, >> from

Re: [Qemu-devel] [PATCH 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > sd_snapshot_delete() should delete the snapshot whose ID matches > @snapshot_id and whose name matches @name. But that's not what it > does. If @snapshot_id is a valid ID, it deletes the snapshot with > that ID, else it deletes the snapshot with

Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > As a bdrv_create() method, sd_create() must set an error and return > negative errno on failure. It prints the error instead of setting it > when connect_to_sdog() fails. Fix that. > > While there, return the value of connect_to_sdog() like we

Re: [Qemu-devel] [PULL] target/sparc queued patch

2017-03-02 Thread Peter Maydell
/pmaydell/tags/pull-target-arm-20170228-1' into staging (2017-03-01 > 17:58:54 +) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tgt-20170302 > > for you to fetch changes up to 3db010c3398d03646d74f2d36a68e62539342e6c: > &g

Re: [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an > error and return negative errno on failure. It sometimes returns -1, > and sometimes neglects to set an error. It also prints error messages > with error_report(). Fix all

Re: [Qemu-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

2017-03-02 Thread Stefano Stabellini
On Thu, 2 Mar 2017, Paul Durrant wrote: > This patch modifies the wrapper functions in xen_common.h to use the > new xendevicemodel interface if it is available along with compatibility > code to use the old libxenctrl interface if it is not. > > Signed-off-by: Paul Durrant

Re: [Qemu-devel] [PATCH 01/15] sheepdog: Defuse time bomb in sd_open() error handling

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > When qemu_opts_absorb_qdict() fails, sd_open() closes stdin, because > sd->fd is still zero. Fortunately, qemu_opts_absorb_qdict() can't > fail, because: > > 1. it only fails when qemu_opt_parse() fails, and > 2. the only member of

Re: [Qemu-devel] [PATCH] Bugfix: Handle error if VM Generation ID device not present

2017-03-02 Thread Laszlo Ersek
On 03/02/17 22:36, b...@skyportsystems.com wrote: > From: Ben Warren > > This was crashing due to NULL-pointer dereference > > QMP Test case: > == > > (QEMU) query-vm-generation-id > {"error": {"class": "GenericError", "desc": "VM Generation ID device not >

Re: [Qemu-devel] [PATCH] tests: check path to avoid a failing qga/get-vcpus test

2017-03-02 Thread Marc-André Lureau
On Thu, Mar 2, 2017 at 11:46 PM Bruce Rogers wrote: > The qga/get-vcpus test fails in a simple chroot environment, as > used in an openSUSE Build Service local build, so first check > that the sysfs based path exists in order to avoid calling this > test in an environment where

Re: [Qemu-devel] iommu emulation

2017-03-02 Thread Bandan Das
Jintack Lim writes: > [cc Bandan] > > On Tue, Feb 21, 2017 at 5:33 AM, Jintack Lim > wrote: > >> >> >> On Wed, Feb 15, 2017 at 9:47 PM, Alex Williamson < >> alex.william...@redhat.com> wrote: ... >> > > I've tried another network device on a

  1   2   3   4   >