[Qemu-devel] [PATCH v3 05/12] cpus: remove icount handling from qemu_tcg_cpu_thread_fn

2017-04-07 Thread Alex Bennée
We should never be running in multi-threaded mode with icount enabled. There is no point calling handle_icount_deadline here so remove it and assert !use_icount. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cpus.c | 4 ++-- 1 file

Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4

2017-04-07 Thread Peter Maydell
On 7 April 2017 at 14:47, Kevin Wolf wrote: > The following changes since commit 5fe2339e6b09da7d6f48b9bef0f1a7360392b489: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-updates-20170406.0' into staging (2017-04-07 > 10:29:56 +0100) > > are available in the

Re: [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine

2017-04-07 Thread Kevin Wolf
Am 07.04.2017 um 08:54 hat Fam Zheng geschrieben: > Coroutine in block layer should always be waken up in bs->aio_context > rather than the "current" context where it is entered. They differ when > the main loop is doing QMP tasks. > > Race conditions happen without this patch, because the wrong

Re: [Qemu-devel] [PATCH for 2.10] slirp/smb: Replace constant strings by glib string

2017-04-07 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/07/2017 09:56 AM, Dr. David Alan Gilbert wrote: > > > > >> The cleanup is useful, and resolves one of the build issues I pointed > >> out earlier on Rawhide (looks like it is now Fedora 26 in addition to > >> Rawhide that have new-enough gcc). In

Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

2017-04-07 Thread Marc-André Lureau
Hi On Fri, Apr 7, 2017 at 4:41 PM Daniel P. Berrange > > +.name = "data-path", > > +.type = QEMU_OPT_STRING, > > +.help = "Socket path to use for data exhange", > > +}, > > +{ > > +.name = "ctrl-path", > > +.type = QEMU_OPT_STRING, > > +

[Qemu-devel] [Bug 1678466] Re: using x-vga=on with vfio-pci leads to segfault

2017-04-07 Thread Alex Williamson
This is now fixed in QEMU 2.9-rc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1678466 Title: using x-vga=on with vfio-pci leads to segfault Status in QEMU: New Bug description: bug occures

Re: [Qemu-devel] [PATCH for 2.10] slirp/smb: Replace constant strings by glib string

2017-04-07 Thread Eric Blake
On 04/07/2017 09:56 AM, Dr. David Alan Gilbert wrote: > >> The cleanup is useful, and resolves one of the build issues I pointed >> out earlier on Rawhide (looks like it is now Fedora 26 in addition to >> Rawhide that have new-enough gcc). In that thread, we argued that it's >> not going to be

[Qemu-devel] [Bug 1680679] Re: qemu cannot run twice

2017-04-07 Thread Alex Williamson
If you get one boot where GPU assignment works with a mobile GeForce, you're doing better than most. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1680679 Title: qemu cannot run twice Status in

Re: [Qemu-devel] [PATCH for 2.10] slirp/smb: Replace constant strings by glib string

2017-04-07 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/07/2017 09:32 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > gcc 7 (on fedora 26) objects to many of the snprintf's > > in the smb path and command creation because it can't > > figure out

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Alberto Garcia
On Fri 07 Apr 2017 02:41:21 PM CEST, Kevin Wolf wrote: >> 6356 5548 4740 3932 3124 2316 15 8 7 0 >> >> **<> <---><-->*

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2017-04-07 Thread Arndt Kritzner
Sorry, but I have moved to ESXI more than 4 years ago. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014681 Title: BSOD with newer host kernels (x64) and W2k8S guest (x64) Status in QEMU:

Re: [Qemu-devel] [PATCH for 2.10] slirp/smb: Replace constant strings by glib string

2017-04-07 Thread Eric Blake
On 04/07/2017 09:32 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > gcc 7 (on fedora 26) objects to many of the snprintf's > in the smb path and command creation because it can't > figure out that the smb_dir (i.e. the /tmp dir for the

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9] throttle: Remove block from group on hot-unplug

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 02:08:47PM -0500, Eric Blake wrote: > When a block device that is part of a throttle group is hot-unplugged, > we forgot to remove it from the throttle group. This leaves stale > memory around, and causes an easily reproducible crash: > > $

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-07 Thread Peter Maydell
** Changed in: qemu Status: Fix Released => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1635339 Title: qxl_pre_save assertion failure on vm "save" Status in QEMU: Confirmed

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote: > From: Wei Qi > > It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused > after assignment, so remove it. > > Signed-off-by: Wei Qi > --- > hw/virtio/vhost.c | 1 - > 1 file

Re: [Qemu-devel] [PATCH for-2.9?] qcow2: Allow discard of final unaligned cluster

2017-04-07 Thread Max Reitz
On 07.04.2017 03:37, Eric Blake wrote: > As mentioned in commit 0c1bd46, we ignored requests to > discard the trailing cluster of an unaligned image. While > discard is an advisory operation from the guest standpoint, > (and we are therefore free to ignore any request), our > qcow2 implementation

[Qemu-devel] [PATCH v2] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Ard Biesheuvel
Our current ACPI table generation code limits the placement of ACPI tables to 32-bit addressable memory, in order to be able to emit the root pointer (RSDP) and root table (RSDT) using table types from the ACPI 1.0 days. Since ARM was not supported by ACPI before version 5.0, it makes sense to

Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

2017-04-07 Thread Daniel P. Berrange
On Fri, Apr 07, 2017 at 05:30:31PM +0300, Amarnath Valluri wrote: > This change introduces a new TPM backend driver that can communicate with > swtpm(software TPM emulator) using unix domain socket interface. > > Swtpm uses two unix sockets, one for plain TPM commands and responses, and one > for

[Qemu-devel] Hacks for building on gcc 7 / Fedora 26

2017-04-07 Thread Dr. David Alan Gilbert
Hi, Fedora 26 has gcc 7.0.1 which has the normal compliment of new fussy warnings; so far I've posted : tests/check-qdict: Fix missing brackets slirp/smb: Replace constant strings by glib string that fix one actual mistake and work around something it's being fussy over. But I've also got a

[Qemu-devel] [PATCH for 2.10] slirp/smb: Replace constant strings by glib string

2017-04-07 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" gcc 7 (on fedora 26) objects to many of the snprintf's in the smb path and command creation because it can't figure out that the smb_dir (i.e. the /tmp dir for the configuration) is known to be short. Replace all these fixed length buffers by

Re: [Qemu-devel] [RFC PATCH 4/4] nvdimm acpi: build flush hint address structure if required

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 06:53:09PM +0800, Haozhong Zhang wrote: > On 04/06/17 11:13 +0100, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:47PM +0800, Haozhong Zhang wrote: > > > > > > Add an boolean option 'flush-hint' to device 'nvdimm'. If it's on, a > > > flush hint address structure

[Qemu-devel] [Bug 1680679] [NEW] qemu cannot run twice

2017-04-07 Thread Roger Lawhorn
Public bug reported: After using qemu with gpu passthrough and then shutting down windows 7 properly I cannot boot windows 7 a second time. Only a full reboot of linux fixes this issue. Qemu appears to corrupt something in linux when exiting. I get no error messages but windows 7 never finishes

[Qemu-devel] [PATCH v2 8/9] tpm-passthrough: move reusable code to utils

2017-04-07 Thread Amarnath Valluri
Signed-off-by: Amarnath Valluri --- hw/tpm/tpm_passthrough.c | 64 hw/tpm/tpm_util.c| 25 +++ hw/tpm/tpm_util.h| 4 +++ 3 files changed, 34 insertions(+), 59 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 06:31:17PM +0800, Haozhong Zhang wrote: > On 04/06/17 10:43 +0100, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > > We should think about the optimal way of implementing Flush Hint > > Addresses in QEMU. But if there is no

[Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend TpmInfo

2017-04-07 Thread Amarnath Valluri
TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new interface method, get_tpm_options() to TPMDriverOps., which shall be implemented by the derived classes to

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 07:32:01AM -0700, Dan Williams wrote: > On Thu, Apr 6, 2017 at 2:43 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote: > * I don't think we can just skip implementing support for this flush. > Yes it's

[Qemu-devel] [Bug 1020484] Re: RFE: Support spice via unix domain socket

2017-04-07 Thread elmarco
you could pass sockets via QMP a while ago, but listening to unix socket has been added there: commit fe4831b1e7e7007ae15ae0470a06898660ab3877 Author: Marc-André Lureau Date: Tue Jan 13 17:57:51 2015 +0100 spice: add unix address support Teach qemu to

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-07 Thread elmarco
damn launchpad, wrong bug and I can't change it back. Please someone move it back to New/Confirmed ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH v2 6/9] tpm-backend: Remove unneeded destroy() method from TpmDriverOps interface

2017-04-07 Thread Amarnath Valluri
As TPMBackend is a Qemu Object, we can use object_unref() inplace of tpm_backend_destroy() to free the backend object, hence removed destroy() from TPMDriverOps interface. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 11 ---

[Qemu-devel] [PATCH v2 7/9] tpm-backend: Move realloc_buffer() implementation to base class

2017-04-07 Thread Amarnath Valluri
Provide base implementation of realloc_buffer(), so that backend implementations can resue. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 9 - hw/tpm/tpm_passthrough.c | 12 2 files changed, 8 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

2017-04-07 Thread Amarnath Valluri
This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. Swtpm uses two unix sockets, one for plain TPM commands and responses, and one for out-of-band control messages. The swtpm and associated tools can be found

[Qemu-devel] [PATCH v2 2/9] tpm-backend: Move thread handling inside TPMBackend

2017-04-07 Thread Amarnath Valluri
Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they needs to implement 'handle_request()' class method that always been called from a thread. This change made tpm_backend_int.h kind of useless, hence removed it.

[Qemu-devel] [PATCH v2 4/9] tpm-backend: Made few interface methods optional

2017-04-07 Thread Amarnath Valluri
This allows backend implementations left optional interface methods. For mandatory methods assertion checks added. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 28 +--- hw/tpm/tpm_passthrough.c | 16 2 files

[Qemu-devel] [PATCH v2 3/9] tpm-backend: Initialize and free data members in it's own methods

2017-04-07 Thread Amarnath Valluri
Initialize and free TPMBackend data members in it's own instance_init() and instance_finalize methods. Took the opportunity to fix object cleanup in tpm_backend_{create,destroy} methods Signed-off-by: Amarnath Valluri --- backends/tpm.c | 8 ++--

[Qemu-devel] [PATCH v2 1/9] tpm-backend: Remove unneeded member variable from backend class

2017-04-07 Thread Amarnath Valluri
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class member. The only possible reason for keeping in TPMBackend was, to get the backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is present. Signed-off-by: Amarnath Valluri

[Qemu-devel] [PATCH v2 0/9] Provide support for the software TPM

2017-04-07 Thread Amarnath Valluri
Briefly, Theses set of patches introduces: - new TPM backend driver to support software TPM emulators(swtpm(1)). - and few supported fixes/enhancements/cleanup to existing tpm backend code. The similar idea was initiated earliar(2) by Stefan Berger(CCed) with slightly different approach,

[Qemu-devel] [Bug 1670175] Re: qemu-system-sparc64 with tribblix-sparc-0m16.iso ends with "panic - kernel: no nucleus hblk8 to allocate"

2017-04-07 Thread Mark Cave-Ayland
Looks like tribblix is an OpenSolaris variant from the above output (I normally tend to test with Milax but it's good to have another reference around). I spent a lot of time during the 2.8 cycle fixing up the context switch code in OpenBIOS which gets OpenSolaris most of the way. AFAICT the 2

Re: [Qemu-devel] [PATCH for-2.9] throttle: Remove block from group on hot-unplug

2017-04-07 Thread Max Reitz
On 06.04.2017 21:08, Eric Blake wrote: > When a block device that is part of a throttle group is hot-unplugged, > we forgot to remove it from the throttle group. This leaves stale > memory around, and causes an easily reproducible crash: > > $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults

Re: [Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on read

2017-04-07 Thread Eric Blake
On 04/07/2017 08:47 AM, Kevin Wolf wrote: > The assertion is currently failing. We can't require callers to have > write permissions when all they are doing is a read, so comment it out. > Add a FIXME comment in the code so that the check is re-enabled when > copy on read is refactored into its

[Qemu-devel] [Bug 1067119] Re: e1000 missing statistics

2017-04-07 Thread Thomas Huth
Looks like these counters have been implemented here: http://git.qemu-project.org/?p=qemu.git;a=commitdiff;h=3b27430177498a1728b6 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 0/3] some simple cleanups

2017-04-07 Thread Michael S. Tsirkin
On Fri, Apr 07, 2017 at 02:58:25PM +0800, weiqi wrote: > From: Wei Qi > > This patchset cleanups some unused/unnecessary variables assignment. Pls remember to repost after 2.9 is out. > Wei Qi (3): > vhost: simple clean up > vnc: simple clean up > esp-pci: simple

Re: [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine

2017-04-07 Thread Eric Blake
On 04/07/2017 01:54 AM, Fam Zheng wrote: > Coroutine in block layer should always be waken up in bs->aio_context s/waken up/awakened/ > rather than the "current" context where it is entered. They differ when > the main loop is doing QMP tasks. > > Race conditions happen without this patch,

[Qemu-devel] [Bug 1089005] Re: Qemu does not shutdown with vnc enabled on OS X

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1077806] Re: Integrate Virtualbox/Qemu Guest booting as a desktop environment listing (request)

2017-04-07 Thread Thomas Huth
** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077806 Title: Integrate Virtualbox/Qemu Guest booting as a desktop environment listing (request) Status in Light

[Qemu-devel] [Bug 1077708] Re: Video capture from webcam with USB passthrough freezes

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1073952] Re: data sent to serial interface gets truncated after 64kb

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1078892] Re: qemu doesn't general protection fault if there are reserved bits set in page-directory-pointer table entries

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1031955] Re: qemu-system-arm -M lm3s811evb fails

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v2 for-2.10 1/8] chardev: Basic support for TN3270

2017-04-07 Thread Eric Blake
On 04/07/2017 06:18 AM, Cornelia Huck wrote: > From: Jing Liu > > This introduces basic support for TN3270, which needs to negotiate > three Telnet options during handshake: > - End of Record > - Binary Transmission > - Terminal-Type > > As a basic

Re: [Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Max Reitz
On 07.04.2017 15:53, Eric Blake wrote: > On 04/07/2017 05:32 AM, Kevin Wolf wrote: >> The assertion is currently failing. We can't require callers to have >> write permissions when all they are doing is a read, so comment it out. >> Add a FIXME comment in the code so that the check is re-enabled

[Qemu-devel] [Bug 1030666] Re: gdb can't proceed after a breakpoint

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on read

2017-04-07 Thread Kevin Wolf
The assertion is currently failing. We can't require callers to have write permissions when all they are doing is a read, so comment it out. Add a FIXME comment in the code so that the check is re-enabled when copy on read is refactored into its own filter driver. Reported-by: Richard W.M. Jones

[Qemu-devel] [Bug 1024275] Re: bad iteraction between -daemonize and -nographic

2017-04-07 Thread Thomas Huth
According to the Debian bug tracker, this has been fixed with this upstream commit: http://git.qemu.org/?p=qemu.git;a=commit;h=ab51b1d568e02c80b1abf9016bda3a86dc1db389 ... so let's close this now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug

Re: [Qemu-devel] New iotest repros failures on virtio external snapshot with iothread

2017-04-07 Thread Max Reitz
On 30.03.2017 04:16, Eric Blake wrote: > On 03/29/2017 09:01 PM, Ed Swierk via Qemu-devel wrote: >> Parts of qemu's block code have changed a lot in recent months but are >> not well exercised by current tests. >> >> Subtle bugs have crept in causing assertion failures, hangs and other >> crashes

[Qemu-devel] [PULL 09/10] block: Assert attached child node has right aio context

2017-04-07 Thread Kevin Wolf
From: Fam Zheng Suggested-by: Kevin Wolf Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block.c | 4 1 file changed, 4 insertions(+) diff --git a/block.c b/block.c index 927ba89..b8a3011 100644 --- a/block.c

[Qemu-devel] [PULL 03/10] commit: Set commit_top_bs->total_sectors

2017-04-07 Thread Kevin Wolf
Like in the mirror filter driver, we also need to set the image size for the commit filter driver. This is less likely to be a problem in practice than for the mirror because we're not at the active layer here, but attaching new parents to a node in the middle of the chain is possible, so the size

Re: [Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Eric Blake
On 04/07/2017 05:32 AM, Kevin Wolf wrote: > The assertion is currently failing. We can't require callers to have > write permissions when all they are doing is a read, so comment it out. > Add a FIXME comment in the code so that the check is re-enabled when > copy on read is refactored into its

[Qemu-devel] [PULL 10/10] mirror: Fix aio context of mirror_top_bs

2017-04-07 Thread Kevin Wolf
From: Fam Zheng It should be moved to the same context as source, before inserting to the graph. Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PULL 01/10] block: Ignore guest dev permissions during incoming migration

2017-04-07 Thread Kevin Wolf
Usually guest devices don't like other writers to the same image, so they use blk_set_perm() to prevent this from happening. In the migration phase before the VM is actually running, though, they don't have a problem with writes to the image. On the other hand, storage migration needs to be able

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

2017-04-07 Thread Eric Blake
On 04/07/2017 03:38 AM, Sahid Orentino Ferdjaoui wrote: > On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote: >> From: Wei Qi >> >> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused >> after assignment, so remove it. > > nit: The line should not

[Qemu-devel] [PULL 05/10] iotests: Add mirror tests for orphaned source

2017-04-07 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041| 46 +++

[Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4

2017-04-07 Thread Kevin Wolf
The following changes since commit 5fe2339e6b09da7d6f48b9bef0f1a7360392b489: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170406.0' into staging (2017-04-07 10:29:56 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[Qemu-devel] [PULL 08/10] block: Fix unpaired aio_disable_external in external snapshot

2017-04-07 Thread Kevin Wolf
From: Fam Zheng bdrv_replace_child_noperm tries to hand over the quiesce_counter state from old bs to the new one, but if they are not on the same aio context this causes unbalance. Fix this by setting the correct aio context before calling bdrv_append(). Reported-by: Ed

[Qemu-devel] [Bug 1022023] Re: vga/std lacks few wide screen modes.

2017-04-07 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1022023 Title: vga/std lacks few wide screen modes. Status in QEMU: New Bug description:

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-07 Thread elmarco
Crash reproduced immediately after setting up a win10 VM with qxl driver 10.0.0.15000. Gerd, are you looking into fixing it? Is it acceptable to crash qemu if the driver is faulty? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PULL 04/10] block/mirror: Fix use-after-free

2017-04-07 Thread Kevin Wolf
From: Max Reitz If @bs does not have any parents, the only reference to @mirror_top_bs will be held by the BlockJob object after the bdrv_unref() following block_job_create(). However, if block_job_create() fails, this reference will not exist and @mirror_top_bs will have been

[Qemu-devel] [PULL 02/10] commit: Set commit_top_bs->aio_context

2017-04-07 Thread Kevin Wolf
The filter driver that is inserted by the commit job needs to use the same AioContext as its parent and child nodes. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Fam Zheng --- block/commit.c | 2 ++ 1 file changed, 2

[Qemu-devel] [PULL 06/10] qemu-img: img_create does not support image-opts, fix docs

2017-04-07 Thread Kevin Wolf
From: Jeff Cody The documentation and help for qemu-img claims that 'qemu-img create' will take the '--image-opts' argument. This is not true, so this patch removes those claims. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH] event: Add signal information to SHUTDOWN

2017-04-07 Thread Eric Blake
On 04/07/2017 04:35 AM, Daniel P. Berrange wrote: > On Thu, Apr 06, 2017 at 04:09:17PM -0500, Eric Blake wrote: >> qemu_kill_report() is already able to tell whether a shutdown >> was triggered by guest action (no output) or by a host signal >> (a message about termination is printed via

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2017-04-07 Thread Thomas Huth
Which version of QEMU have you been using here? Can you still reproduce this with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC PATCH 1/4] pc-dimm: add 'reserved-size' to reserve address range after the ending address

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 06:46:49PM +0800, Haozhong Zhang wrote: > On 04/06/17 11:24 +0100, Stefan Hajnoczi wrote: > > On Fri, Mar 31, 2017 at 04:41:44PM +0800, Haozhong Zhang wrote: > > > If option 'reserved-size=RSVD' is present, QEMU will reserve an > > > address range of size 'RSVD' after the

[Qemu-devel] [Bug 1020484] Re: RFE: Support spice via unix domain socket

2017-04-07 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1020484 Title: RFE: Support spice via unix domain socket Status in QEMU: New Bug

[Qemu-devel] [Bug 1020309] Re: qemu-system-ppc: no keyboard after savevm/loadvm

2017-04-07 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1013888] Re: windows xp sp3 setup blank screen on boot

2017-04-07 Thread Thomas Huth
Marking this bug as fixed, according to comment #4 and #5 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013888 Title: windows xp sp3 setup

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-04-07 Thread Matwey V. Kornilov
Hi, I've attached the files with logs you requested. Could you comment them somehow? x86info says that IA32_PERF is not enabled: Performance MSRs: MSR_IA32_PERF_STATUS: 0x0 MSR_IA32_MISC_ENABLE: 0x0 [Enabled: ] -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 1013714] Re: Data corruption after block migration (LV->LV)

2017-04-07 Thread Thomas Huth
Closing according to comment #3 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013714 Title: Data corruption after block migration (LV->LV)

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-07 Thread Gerd Hoffmann
I put my money on that one: https://cgit.freedesktop.org/spice/win32/qxl-wddm- dod/commit/?id=f6e099db39e7d0787f294d5fd0dce328b5210faa commit f6e099db39e7d0787f294d5fd0dce328b5210faa Author: Sameeh Jubran Date: Sun Sep 11 16:05:24 2016 +0300 Use the second bar (VRAM)

Re: [Qemu-devel] [PATCH v2 6/6] tests/block-job-txn: Don't start block job before adding to txn

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:14PM +0800, Fam Zheng wrote: > Previously, before test_block_job_start returns, the job can already > complete, as a result, the transactional state of other jobs added to > the same txn later cannot be handled correctly. > > Move the block_job_start() calls to

Re: [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:13PM +0800, Fam Zheng wrote: > Coroutine in block layer should always be waken up in bs->aio_context > rather than the "current" context where it is entered. They differ when > the main loop is doing QMP tasks. > > Race conditions happen without this patch, because

Re: [Qemu-devel] [PATCH v2 3/6] mirror: Fix aio context of mirror_top_bs

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:11PM +0800, Fam Zheng wrote: > It should be moved to the same context as source, before inserting to the > graph. > > Reviewed-by: Eric Blake > Reviewed-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- >

Re: [Qemu-devel] [PATCH v2 2/6] block: Assert attached child node has right aio context

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:10PM +0800, Fam Zheng wrote: > Suggested-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > block.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP

Re: [Qemu-devel] [PATCH v2 1/6] block: Fix unpaired aio_disable_external in external snapshot

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:09PM +0800, Fam Zheng wrote: > bdrv_replace_child_noperm tries to hand over the quiesce_counter state > from old bs to the new one, but if they are not on the same aio context > this causes unbalance. > > Fix this by setting the correct aio context before calling >

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Alex Bennée
Paolo Bonzini writes: > - Original Message - >> From: "Alex Bennée" >> To: "Paolo Bonzini" >> Cc: dovga...@ispras.ru, r...@twiddle.net, "peter maydell" >> , qemu-devel@nongnu.org, >>

Re: [Qemu-devel] is qemu able to run multiple system emulation simultaneously

2017-04-07 Thread G 3
On Apr 7, 2017, at 3:08 AM, Jiahuan Zhang wrote: On 7 April 2017 at 08:26, Jiahuan Zhang wrote: On 6 April 2017 at 19:58, G 3 wrote: On Apr 6, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote: Dear QEMU developers, I need

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Kevin Wolf
Am 07.04.2017 um 14:20 hat Stefan Hajnoczi geschrieben: > On Thu, Apr 06, 2017 at 06:01:48PM +0300, Alberto Garcia wrote: > > Here are the results (subcluster size in brackets): > > > > |-++-+---| > > | cluster size |

Re: [Qemu-devel] [PATCH v2 4/6] block: Quiesce old aio context during bdrv_set_aio_context

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:12PM +0800, Fam Zheng wrote: > @@ -4413,6 +4416,10 @@ void bdrv_set_aio_context(BlockDriverState *bs, > AioContext *new_context) > aio_context_acquire(new_context); > bdrv_attach_aio_context(bs, new_context); > aio_context_release(new_context); > +

Re: [Qemu-devel] [PATCH v2 0/6] block: Fixes regarding dataplane and management operations

2017-04-07 Thread Kevin Wolf
Am 07.04.2017 um 08:54 hat Fam Zheng geschrieben: > v2: - Drop patch 4 in v1. A second thought made me feel neither it nor Kevin's > suggestion to move the BH process to bdrv_drain_recurse/BDRV_POLL_WHILE > is a complete fix. So leave it for a separate patch. > - Add rev-by to

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Kevin Wolf
Am 06.04.2017 um 18:40 hat Eric Blake geschrieben: > On 04/06/2017 10:01 AM, Alberto Garcia wrote: > > I thought of three alternatives for storing the subcluster bitmaps. I > > haven't made my mind completely about which one is the best one, so > > I'd like to present all three for discussion.

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Alberto Garcia
On Fri 07 Apr 2017 02:20:21 PM CEST, Stefan Hajnoczi wrote: >> Here are the results when writing to an empty 40GB qcow2 image with no >> backing file. The numbers are of course different but as you can see >> the patterns are similar: >> >>

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 06:01:48PM +0300, Alberto Garcia wrote: > Here are the results (subcluster size in brackets): > > |-++-+---| > | cluster size | subclusters=on | subclusters=off | Max L2 cache size | >

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Paolo Bonzini
- Original Message - > From: "Alex Bennée" > To: "Paolo Bonzini" > Cc: dovga...@ispras.ru, r...@twiddle.net, "peter maydell" > , qemu-devel@nongnu.org, > mt...@greensocs.com, "fred konrad"

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Alex Bennée
Paolo Bonzini writes: > On 05/04/2017 15:25, Alex Bennée wrote: >> This ensures each time the vCPU thread reads the icount we update the >> master timer_state.qemu_icount field. This way as long as updates are >> in BQL protected sections (which they should be) the

Re: [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 09:30:33AM +0800, 858585 jemmy wrote: > On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote: > > > > A proper solution is to refactor the synchronous code to make it > >

[Qemu-devel] [PATCH] qemu-img: improve convert_iteration_sectors()

2017-04-07 Thread Vladimir Sementsov-Ogievskiy
Do not do extra call to _get_block_status() Signed-off-by: Vladimir Sementsov-Ogievskiy --- Also, I'm not sure about last line: s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA; (which is equal to old code) may be, it should be s->status =

Re: [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 09:30:33AM +0800, 858585 jemmy wrote: > On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote: > >> From: Lidong Chen > >> > >> when migration with

Re: [Qemu-devel] [RFC PATCH v1 8/9] cpus: don't credit executed instructions before they have run

2017-04-07 Thread Pavel Dovgalyuk
> From: mttcg-requ...@listserver.greensocs.com > [mailto:mttcg-requ...@listserver.greensocs.com] > On 04/04/2017 07:37, Pavel Dovgalyuk wrote: > >> -icount -= (cpu->icount_decr.u16.low + cpu->icount_extra); > >> +/* Take into account what has run */ > >> +icount +=

[Qemu-devel] [PATCH v2 for-2.10 7/8] s390x/3270: Detect for continued presence of a 3270 client

2017-04-07 Thread Cornelia Huck
From: Jing Liu To ensure that we do not keep any 3270 sockets where the client is not connected anymore, we send a packet with the timing mark option after ten minutes of client inactivity. If the client does not answer it, then the socket will be closed

[Qemu-devel] [PATCH v2 for-2.10 6/8] s390x/3270: Add the TCP socket events handler for 3270

2017-04-07 Thread Cornelia Huck
From: Jing Liu This introduces a chr_event handler to handle the 3270 connection and disconnection events. Signed-off-by: Jing Liu Reviewed-by: QingFeng Hao Reviewed-by: Dong Jia Shi

[Qemu-devel] [PATCH v2 for-2.10 8/8] s390x/3270: Mark non-migratable and enable the device

2017-04-07 Thread Cornelia Huck
From: Jing Liu Mark 3270 as non-migratable for the experimental stage. Enable the 3270 device so that we can use x3270 client to operate the guest. Run qemu with the arguments: -chardev socket,id=char3270_0,host=0.0.0.0,port=23,nowait,server,tn3270 \ -device

[Qemu-devel] [PATCH v2 for-2.10 5/8] s390x/3270: 3270 data stream handling

2017-04-07 Thread Cornelia Huck
From: Jing Liu This introduces the input and output handlers for 3270 device, setting up the data tunnel among guest kernel, qemu and the 3270 client. After the client connected and TN3270 handshake done, signal the not-ready to ready status by an unsolicited

<    1   2   3   >