[Qemu-devel] [PULL 01/18] migration: Fix non-multiple of page size migration

From: "Dr. David Alan Gilbert" Unfortunately it's legal to create a VM with a RAM size that's not a multiple of the underlying host page or huge page size. Recently I'd changed things to always send host sized pages, and that breaks if we have say a 1025MB guest on 2MB

[Qemu-devel] [PULL 02/18] postcopy: Require RAMBlocks that are whole pages

From: "Dr. David Alan Gilbert" It turns out that it's legal to create a VM with RAMBlocks that aren't a multiple of the pagesize in use; e.g. a 1025M main memory using 2M host pages. That breaks postcopy's atomic placement of pages, so disallow it. Signed-off-by: Dr. David

[Qemu-devel] [PULL 00/18] Migration pull request

commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170518 for you to fetch changes up

[Qemu-devel] [PULL 03/18] hmp: Use visitor api for hmp_migrate_set_parameter()

We only use it for int64 at this point, I am not able to find a way to parse an int with MiB units. Signed-off-by: Juan Quintela Reviewed-by: Markus Armbruster --- hmp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hmp.c

Re: [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

* Juan Quintela (quint...@redhat.com) wrote: > Create an include for its exported functions. > > Signed-off-by: Juan Quintela Other than needing to fix the GPLv2 to be GPLv2 or later, Reviewed-by: Dr. David Alan Gilbert > --- > Add proper header >

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 + > include/migration/qemu-file.h | 4 > migration/channel.c | 1 + > migration/colo.c | 1 + > migration/migration.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

Quoting Daniel Henrique Barboza (2017-05-17 15:31:44) > > > On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: > > > > > > On 05/16/2017 01:25 AM, David Gibson wrote: > >> On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: > >>> From: Jianjun Duan

Re: [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

On Thu, May 18, 2017 at 05:40:54PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > Create an include for its exported functions. > > > > Signed-off-by: Juan Quintela > > > > --- > > Add proper header > > --- > >

Re: [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

* Juan Quintela (quint...@redhat.com) wrote: > Create an include for its exported functions. > > Signed-off-by: Juan Quintela > > --- > Add proper header > --- > include/migration/migration.h | 7 - > migration/Makefile.objs | 2 +- > migration/channel.c

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

HI, No worries about Yesterday. I decided to take a different approach. I'll put that stuff in that relates to GDummyPanel flypie/GDummyPanel first I sent the patch to the list a copy is here. 0001-PATCH-V-2-GDummyPanel-Fix-formatingissues.patch | | | | || | | | ||

Re: [Qemu-devel] [PATCH v2 1/2] exec: Create include for target_page_size()

* Juan Quintela (quint...@redhat.com) wrote: > That is the only function that we need from exec.c, and having to > include the whole sysemu.h for this. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > > --- > > /me leans to be

Re: [Qemu-devel] [PATCH 1/4] split the tcg accelerator from accel.c file

On 05/18/2017 02:14 PM, Yang Zhong wrote: Your system clock is way off. From the headers: > Received: from yangzhon-virtual.bj.intel.com ([10.238.145.52]) > by fmsmga002.fm.intel.com with ESMTP; 18 May 2017 04:17:51 -0700 > Date: Fri, 19 May 2017 03:14:52 +0800 Your computer claimed to

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

Quoting Daniel Henrique Barboza (2017-05-18 09:33:58) > > > On 05/18/2017 01:30 AM, David Gibson wrote: > > On Wed, May 17, 2017 at 05:31:44PM -0300, Daniel Henrique Barboza wrote: > >> > >> On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: > >>> > >>> On 05/16/2017 01:25 AM, David Gibson

[Qemu-devel] EL2\EL3 support for Aarch64

Hello, List! Could you tell me, what is the current state for EL2\EL3 (Aarch64)? Whether they are fully supported, or not? Am I need to use any command line options to enable them for Aarch64 assembler programs simulation? Thanks in advance! -- Sincerely yours, Sergey Smolov Institute for

[Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 + include/migration/qemu-file.h | 4 migration/channel.c | 1 + migration/colo.c | 1 + migration/migration.c | 1 + migration/qemu-file-channel.c | 1 +

[Qemu-devel] [PATCH 7/9] migration: Remove qemu-file.h from vmstate.h

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- minor rearangements due to the rebase --- include/hw/hw.h | 1 + include/migration/vmstate.h | 3 --- migration/block.c | 1 + migration/colo.c| 1 +

[Qemu-devel] [PATCH 9/9] migration: migration.h was not needed

This files don't use any function from migration.h, so drop it. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- block/qed.c | 1 - hw/i386/pc_q35.c| 1 -

[Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

Create an include for its exported functions. Signed-off-by: Juan Quintela --- Add proper header --- include/migration/migration.h | 7 - migration/Makefile.objs | 2 +- migration/channel.c | 69 +++

[Qemu-devel] [PATCH 6/9] migration: Split vmstate-types.c from vmstate.c

Now one just has the interperter, and the other has the basic types. Once there, add copyright boilerplate. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Use GPL v2 or later. Detected by David. --- migration/Makefile.objs | 2 +-

[Qemu-devel] [PATCH 1/9] migration: Create migration/xbzrle.h

Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 4 migration/ram.c | 1 + migration/xbzrle.c| 2 +- migration/xbzrle.h| 21 + tests/test-xbzrle.c

[Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/

It is only used for migration code. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/qjson.c| 2 +- {include/migration => migration}/qjson.h | 0 migration/vmstate.c | 2 +- 3

[Qemu-devel] [PATCH 8/9] migration: Remove vmstate.h from migration.h

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- Minor rearrangements due to rebase --- include/migration/migration.h | 1 - migration/block.c | 1 +

[Qemu-devel] [PATCH 4/9] migration: Remove migration.h from colo.h

migration.h is not included in any includes now. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/colo.h | 1 - migration/colo-comm.c| 3 ++- migration/colo.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v5 0/9] Migration mini-cleanup

Hi Changes from v3 Only copyright notices: included the diff to make it easier to see: - channel.{c,h} -> goes to Daniel Berrange - qemu-file-channel.h -> same one than qemu-file-channel.c I hope this is ok now. Thanks, Juan. diff --git a/migration/channel.c b/migration/channel.c index

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

Hi, > >> Feel free to send an additional cleanup patch ... otherwise, I'd say let > >> it bitrot for another year and we then remove it completely together > >> with all the other "-usbdevice" functions... > > > > Well, Coverity reports it so I'd rather keep it clean... It will be clean once

[Qemu-devel] [PATCH 1/1] target/arm: clear PMUVER field of AA64DFR0 when vPMU=off

The PMUv3 driver of linux kernel (in arch/arm64/kernel/perf_event.c) relies on the PMUVER field of id_aa64dfr0_el1 to decide if PMU support is present or not. This patch clears the PMUVER field under TCG mode when vPMU=off. Without it, PMUv3 will init insider guest VMs even with vPMU=off. This

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

"Daniel P. Berrange" wrote: > On Thu, May 18, 2017 at 04:44:08PM +0100, Dr. David Alan Gilbert wrote: >> OK, similar copyright - but slightly different problem. >> These two lines come from include/migration/qemu-file.h; >> they were both added by Daniel in a9cfeb33bb23a81.

[Qemu-devel] qemu-system-sh4 -M r2d serial is broken.

Serial input hangs after the first character in the 4.11 kernel: http://www.spinics.net/lists/linux-sh/msg51183.html Because they enabled support for a buffer size thing QEMU doesn't emulate right: http://www.spinics.net/lists/linux-sh/msg51189.html Rob

Re: [Qemu-devel] [PATCH 3/5] 9pfs: local: simplify file opening

On Thu, 18 May 2017 09:23:07 -0500 Eric Blake wrote: > On 05/09/2017 04:23 AM, Greg Kurz wrote: > > On Fri, 5 May 2017 12:01:55 -0500 > > Eric Blake wrote: > > > >> On 05/05/2017 09:37 AM, Greg Kurz wrote: > >>> All paths in the virtfs directory now

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

On Thu, May 18, 2017 at 04:44:08PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > Signed-off-by: Juan Quintela > > --- > > include/migration/migration.h | 1 + > > include/migration/qemu-file.h | 4 > > migration/channel.c

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 + > include/migration/qemu-file.h | 4 > migration/channel.c | 1 + > migration/colo.c | 1 + > migration/migration.c

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 05/18/2017 06:20 AM, Aurelien Jarno wrote: +DEF_HELPER_FLAGS_2(testblock, TCG_CALL_NO_WG, i32, env, i64) As the helper does not read any values from the global, you can even use TCG_CALL_NO_RWG. By throwing an exception, we imply a read of all values along the exception path. r~

Re: [Qemu-devel] [PATCH 00/17] qobject/qapi: add uint type

Marc-André Lureau writes: > Hi, > > In previously sent series "[PATCH 00/21] WIP: dump: add kaslr support > (for after 2.9)", I proposed changes to accept uint64 values from > json, by adding a QUint type. During review, it was suggested to > introduce a QNum type to

Re: [Qemu-devel] [PATCH v3] target/s390x: Add support for the TEST BLOCK instruction

On 05/18/2017 07:19 AM, Thomas Huth wrote: TEST BLOCK was likely once used to execute basic memory tests, but nowadays it is just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- v3: - Use TCG_CALL_NO_RWG instead of TCG_CALL_NO_WG - Use

Re: [Qemu-devel] KVM call for 2017-05-23

Juan Quintela wrote: > Hi Gentle remainder that call is next week Thanks, Juan. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After

[Qemu-devel] [PATCH v2 2/2] migration: Make savevm.c target independent

It only needed TARGET_PAGE_SIZE/BITS/BITS_MIN values, so just export them from exec.h Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert --- Makefile.target| 2 +- exec.c

[Qemu-devel] [PATCH v2 0/2] Make migration/savevm.c target independent

Hi Changes for v2 - Make copyright notice correct (dave) Please, review. [v1] Only reason that ram.c is compiled by target is because it use TARGET_PAGE_BITS. As we already have a function to export TARGET_PAGE_SIZE, do the same. After this, we can make it target independent. Juan Quintela

[Qemu-devel] [PATCH v2 1/2] exec: Create include for target_page_size()

That is the only function that we need from exec.c, and having to include the whole sysemu.h for this. Signed-off-by: Juan Quintela --- /me leans to be less sloppy with copyright notices thanks Dave --- exec.c | 1 + include/exec/target_page.h | 19

Re: [Qemu-devel] [PATCH 16/17] RFC: qdict: add uint

Marc-André Lureau writes: > Similar to int support, add uint support. > > Note this is RFC because this is currently unused in qemu, I haven't > found a good user for it yet (kaslr qemu-ga code did use it though). > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

On Thu, May 18, 2017 at 04:45:23PM +0200, Maxime Coquelin wrote: > Hi Michael, > > On 05/18/2017 09:35 AM, Maxime Coquelin wrote: > > > > > > On 05/17/2017 06:41 PM, Michael S. Tsirkin wrote: > > > On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote: > > > > > > > > On 05/11/2017

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

On Thu, May 18, 2017 at 09:30:53AM -0500, Eric Blake wrote: > On 05/18/2017 04:54 AM, Niels de Vos wrote: > > Add missing support for "preallocation=falloc" to the Gluster block > > driver. This change bases its logic on that of block/file-posix.c and > > removed the gluster_supports_zerofill()

Re: [Qemu-devel] [PATCH 15/17] Use uint property getter/setter where appropriate

Marc-André Lureau writes: > All those property usages are associated with unsigned integers, so use > appropriate getter/setter. "Usages"? I think this is a question of whether the property value is signed or unsigned. I guess "those properties are" would work.

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

On 05/18/2017 05:54 PM, Kevin Wolf wrote: > Am 18.05.2017 um 14:22 hat Denis V. Lunev geschrieben: >> On 05/18/2017 03:10 PM, Kevin Wolf wrote: >>> Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.05.2017 13:25, Kevin Wolf wrote: > Am 18.05.2017 um 12:09 hat

Re: [Qemu-devel] [PATCH 2/2] migration: Make savevm.c target independent

* Juan Quintela (quint...@redhat.com) wrote: > It only needed TARGET_PAGE_SIZE/BITS/BITS_MIN values, so just export > them from exec.h > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > Makefile.target| 2 +- >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] altera_timer: fix incorrect memset

On 18/05/2017 12:33, Paolo Bonzini wrote: > Use sizeof instead of ARRAY_SIZE, fixing -Wmemset-elt-size with recent > GCC versions. > > Signed-off-by: Paolo Bonzini > --- > hw/timer/altera_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH] spapr: ensure core_slot isn't NULL in spapr_core_unplug()

On Thu, 18 May 2017 15:58:31 +0200 Greg Kurz wrote: > If we go that far on the path of hot-removing a core and we find out that > the core-id is invalid, then we have a serious bug. > > Let's make it explicit with an assert() instead of dereferencing a NULL > pointer. > > This

Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h

On 18/05/2017 12:36, Juan Quintela wrote: > All the file is surounded already by #ifndef CONFIG_USER_ONLY. > > Signed-off-by: Juan Quintela > --- > include/exec/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

Am 18.05.2017 um 14:22 hat Denis V. Lunev geschrieben: > On 05/18/2017 03:10 PM, Kevin Wolf wrote: > > Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 18.05.2017 13:25, Kevin Wolf wrote: > >>> Am 18.05.2017 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben: >

Re: [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

On 05/18/2017 06:18 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

On 05/18/2017 06:18 AM, Juan Quintela wrote: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela > > --- > Reviewed-by: Eric Blake -- Eric Blake, Principal Software

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

Hi Michael, On 05/18/2017 09:35 AM, Maxime Coquelin wrote: On 05/17/2017 06:41 PM, Michael S. Tsirkin wrote: On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote: On 05/11/2017 07:33 PM, Michael S. Tsirkin wrote: On Thu, May 11, 2017 at 02:32:43PM +0200, Maxime Coquelin wrote:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

On 05/18/2017 01:30 AM, David Gibson wrote: On Wed, May 17, 2017 at 05:31:44PM -0300, Daniel Henrique Barboza wrote: On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote:

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

On 05/18/2017 04:54 AM, Niels de Vos wrote: > Add missing support for "preallocation=falloc" to the Gluster block > driver. This change bases its logic on that of block/file-posix.c and > removed the gluster_supports_zerofill() and qemu_gluster_zerofill() > functiond in favour of #ifdef checks in

Re: [Qemu-devel] [PATCH 1/2] exec: Create include for target_page_size()

* Juan Quintela (quint...@redhat.com) wrote: > That is the only function that we need from exec.c, and having to > include the whole sysemu.h for this. > > Signed-off-by: Juan Quintela > --- > exec.c | 1 + > include/exec/target_page.h | 20

Re: [Qemu-devel] [PATCH 1/4] split the tcg accelerator from accel.c file

On 05/18/2017 02:14 PM, Yang Zhong wrote: > there are two accelerators in qemu, kvm and tcg. kvm > accelerator is defined in kvm-all.c, but tcg accelerator > is defined in accel.c file. we split tcg accelerator from > accel.c file and create one new accel directory,which will space after comma

Re: [Qemu-devel] [PATCH 3/5] 9pfs: local: simplify file opening

On 05/09/2017 04:23 AM, Greg Kurz wrote: > On Fri, 5 May 2017 12:01:55 -0500 > Eric Blake wrote: > >> On 05/05/2017 09:37 AM, Greg Kurz wrote: >>> All paths in the virtfs directory now start with "./" (except the virtfs >>> root itself which is exactly "."). >>> >>> We hence

[Qemu-devel] [PATCH v3] target/s390x: Add support for the TEST BLOCK instruction

TEST BLOCK was likely once used to execute basic memory tests, but nowadays it is just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- v3: - Use TCG_CALL_NO_RWG instead of TCG_CALL_NO_WG - Use potential_page_fault() since the helper can generate an exception

Re: [Qemu-devel] [PATCH 2/5] 9pfs: local: resolve special directories in paths

On 05/18/2017 03:41 AM, Greg Kurz wrote: > [...] +} else if (!strcmp(name, "..")) { +if (!strcmp(dir_path->data, ".")) { +/* ".." relative to the root is "." */ +v9fs_path_sprintf(target, "."); +} else {

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: As a preparation for switching to a vmstate based migration let us

Re: [Qemu-devel] [PATCH V5 2/9] migration: pass ptr to MigrationIncomingState into migration ufd_version_check & postcopy_ram_supported_by_host

On 05/12/2017 08:31 AM, Alexey Perevalov wrote: Long subject line. Try to keep things in the subject around 60 characters or less, in part so that 'git shortlog --oneline -30' still fits in an 80-column screen. Maybe: migration: Refactor use of MigrationIncomingState pointer > That tiny

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

On 18.05.2017 15:35, Paolo Bonzini wrote: > > > On 18/05/2017 15:22, Thomas Huth wrote: >> On 18.05.2017 14:00, Paolo Bonzini wrote: >>> >>> >>> On 12/05/2017 14:21, Gerd Hoffmann wrote: From: Thomas Huth When starting QEMU with the legacy USB serial device like

[Qemu-devel] [PATCH] spapr: ensure core_slot isn't NULL in spapr_core_unplug()

If we go that far on the path of hot-removing a core and we find out that the core-id is invalid, then we have a serious bug. Let's make it explicit with an assert() instead of dereferencing a NULL pointer. This fixes Coverity issue CID 1375404. Signed-off-by: Greg Kurz ---

Re: [Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function.

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function. Type: series Message-id: 1495085580-10631-1-git-send-email-tianyu@intel.com === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v3 0/5] mc146818rtc: fix Windows VM clock faster

On 18/05/2017 15:38, Xiao Guangrong wrote: >>> >> >> Yes, I've already queued it, but I don't have many patches so I am >> delaying the pull request a bit (until at least I have time to test >> vhost-user-scsi...). >> > > Very glad to know it. I should check your git tree before raise this >

Re: [Qemu-devel] [PATCH v3 0/5] mc146818rtc: fix Windows VM clock faster

On 05/18/2017 03:52 PM, Paolo Bonzini wrote: Looks great. Thanks for following up quickly on the reviews. Paolo, if it is okay to you, could you please consider to merge this patchset? ;) Yes, I've already queued it, but I don't have many patches so I am delaying the pull request a bit

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 18.05.2017 15:20, Aurelien Jarno wrote: > On 2017-05-18 13:39, Thomas Huth wrote: >> TEST BLOCK was likely once used to execute basic memory >> tests, but nowadays it's just a (slow) way to clear a page. >> >> Signed-off-by: Thomas Huth >> --- >> v2: >> - Use

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

On 18/05/2017 15:22, Thomas Huth wrote: > On 18.05.2017 14:00, Paolo Bonzini wrote: >> >> >> On 12/05/2017 14:21, Gerd Hoffmann wrote: >>> From: Thomas Huth >>> >>> When starting QEMU with the legacy USB serial device like this: >>> >>> qemu-system-x86_64 -usbdevice

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

On 5/17/2017 7:09 PM, Eric Blake wrote: On 05/17/2017 11:29 AM, Greg Kurz wrote: First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling a stub for Windows will still leave BSD broken, and your #ifdef is wrong. Fixing compilation on

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 18.05.2017 15:20, Aurelien Jarno wrote: > On 2017-05-18 14:59, Thomas Huth wrote: >> On 18.05.2017 14:23, David Hildenbrand wrote: >>> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index f6e5bce..de0ecd4 100644 --- a/target/s390x/mem_helper.c +++

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

Peter Xu wrote: > On Wed, May 17, 2017 at 05:47:50PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> include/migration/migration.h | 1 + >> include/migration/qemu-file.h | 4 >> migration/channel.c | 1 + >>

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

On 18.05.2017 14:00, Paolo Bonzini wrote: > > > On 12/05/2017 14:21, Gerd Hoffmann wrote: >> From: Thomas Huth >> >> When starting QEMU with the legacy USB serial device like this: >> >> qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio >> >> it currently aborts

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

> > On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > >> Sent: Wednesday, May 17, 2017 6:18 AM > >> > >> > >> On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: > On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic

Re: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

On Mon, May 15, 2017 at 12:00:52PM +0200, Paolo Bonzini wrote: > Compared to v2, this silences checkpatch and correctly destroy the mutex on > exiting from curl_open with an error. FWIW I hit the curl bug again and tested the current patch series, and it also fixes the bug (as expected). Rich.

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 2017-05-18 14:59, Thomas Huth wrote: > On 18.05.2017 14:23, David Hildenbrand wrote: > > > >> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c > >> index f6e5bce..de0ecd4 100644 > >> --- a/target/s390x/mem_helper.c > >> +++ b/target/s390x/mem_helper.c > >> @@ -20,6 +20,7 @@ >

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 2017-05-18 13:39, Thomas Huth wrote: > TEST BLOCK was likely once used to execute basic memory > tests, but nowadays it's just a (slow) way to clear a page. > > Signed-off-by: Thomas Huth > --- > v2: > - Use DEF_HELPER_FLAGS_2 instead for DEF_HELPER_2 for returning CC

Re: [Qemu-devel] [PATCH v8 00/13] basic channel IO passthrough infrastructure based on vfio

On Wed, 17 May 2017 02:48:00 +0200 Dong Jia Shi wrote: > The patch series introduce a basic channel I/O passthrough > infrastructure based on vfio. > - Focus on supporting dasd-eckd(cu_type/dev_type = 0x3990/0x3390) as > the target device. > - Support new qemu

Re: [Qemu-devel] [PATCH 0/5] Remove old MigrationParams

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Hi >> >> Changes from v4: >> - make suggested logic change by eric >> - remove extra space in error message >> - allow migrate_set_capability block off when block migration is complied off >>

Re: [Qemu-devel] [PATCH v8 13/13] MAINTAINERS: Add vfio-ccw maintainer

On Wed, 17 May 2017 02:48:13 +0200 Dong Jia Shi wrote: > Add Cornelia Huck as the vfio-ccw maintainer. > > Acked-by: Alex Williamson > Signed-off-by: Dong Jia Shi > --- > MAINTAINERS | 7 +++ > 1 file

Re: [Qemu-devel] [PATCH v8 01/13] update-linux-headers: update for vfio-ccw

On Wed, 17 May 2017 02:48:01 +0200 Dong Jia Shi wrote: > Add vfio_ccw.h. > > Signed-off-by: Dong Jia Shi > --- > scripts/update-linux-headers.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> From: "Dr. David Alan Gilbert" >> >> Many users now prefer to use drive_mirror over NBD as an >> alternative to the older migrate -b option; drive_mirror is >> more

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 18.05.2017 14:59, Thomas Huth wrote: > On 18.05.2017 14:23, David Hildenbrand wrote: >> >>> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c >>> index f6e5bce..de0ecd4 100644 >>> --- a/target/s390x/mem_helper.c >>> +++ b/target/s390x/mem_helper.c >>> @@ -20,6 +20,7 @@ >>>

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

On 18.05.2017 14:23, David Hildenbrand wrote: > >> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c >> index f6e5bce..de0ecd4 100644 >> --- a/target/s390x/mem_helper.c >> +++ b/target/s390x/mem_helper.c >> @@ -20,6 +20,7 @@ >> >> #include "qemu/osdep.h" >> #include "cpu.h"

Re: [Qemu-devel] [PATCH 14/17] acpi: fix s3/s4 disabled type

Marc-André Lureau writes: > Use a more specific bool type. > > Signed-off-by: Marc-André Lureau Why doesn't this run afoul backward compatibility? To answer the question, we need to enumerate affected external interfaces.

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

18.05.2017 15:10, Kevin Wolf wrote: Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.05.2017 13:25, Kevin Wolf wrote: Am 18.05.2017 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben: Shows, how much data qcow2 allocates in underlying file. This should be helpful on

Re: [Qemu-devel] [PATCH] nvme: Add support for Controller Memory Buffers

> This mail seems to have made it to the list, but the patch hasn't. > Looking at the headers, you don't seem to use the same server for > your normal mail client and git send-email. Maybe it's related to this? My patches come through my gmail smtp client (via git send-email) so maybe that’s a

Re: [Qemu-devel] [Qemu-block] [PATCH 03/18] block: access io_limits_disabled with atomic ops

On Thu 11 May 2017 04:41:53 PM CEST, Paolo Bonzini wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c > index f6e5bce..de0ecd4 100644 > --- a/target/s390x/mem_helper.c > +++ b/target/s390x/mem_helper.c > @@ -20,6 +20,7 @@ > > #include "qemu/osdep.h" > #include "cpu.h" > +#include "exec/address-spaces.h" > #include

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

On 05/18/2017 03:10 PM, Kevin Wolf wrote: > Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 18.05.2017 13:25, Kevin Wolf wrote: >>> Am 18.05.2017 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben: Shows, how much data qcow2 allocates in underlying file. This should

Re: [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

* Juan Quintela (quint...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating

Re: [Qemu-devel] [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex

On Thu 18 May 2017 02:08:32 PM CEST, Paolo Bonzini wrote: >> Does io_limits_disabled need locking too? > > It uses atomic access since patch 3. Ah, I overlooked that one, sorry! Berto

Re: [Qemu-devel] [Qemu-block] [PATCH 18/18] block: make accounting thread-safe

On Thu 11 May 2017 04:42:08 PM CEST, Paolo Bonzini wrote: > I'm not trying too hard yet. Later, with multiqueue support, > this may cause mutex contention or cacheline bouncing. > > Signed-off-by: Paolo Bonzini s/spin/lock/ as Stefan said. Reviewed-by: Alberto Garcia

Re: [Qemu-devel] [PATCH 0/5] Remove old MigrationParams

* Juan Quintela (quint...@redhat.com) wrote: > Hi > > Changes from v4: > - make suggested logic change by eric > - remove extra space in error message > - allow migrate_set_capability block off when block migration is complied off > (eric request) Hang on, is this v6? I think you've missed the

Re: [Qemu-devel] [Qemu-block] [PATCH 17/18] block: introduce block_account_one_io

On Thu 11 May 2017 04:42:07 PM CEST, Paolo Bonzini wrote: > This is the common code to account operations that produced actual I/O. > > Signed-off-by: Paolo Bonzini Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 4/9] migration: Remove migration.h from colo.h

On Wed, May 17, 2017 at 05:47:51PM +0200, Juan Quintela wrote: > migration.h is not included in any includes now. > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH 9/9] migration: migration.h was not needed

On Wed, May 17, 2017 at 05:47:56PM +0200, Juan Quintela wrote: > This files don't use any function from migration.h, so drop it. > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > 18.05.2017 13:25, Kevin Wolf wrote: > >Am 18.05.2017 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>Shows, how much data qcow2 allocates in underlying file. This should > >>be helpful on non-sparse file systems,

Re: [Qemu-devel] [PATCH 6/9] migration: Split vmstate-types.c from vmstate.c

On Wed, May 17, 2017 at 05:47:53PM +0200, Juan Quintela wrote: > Now one just has the interperter, and the other has the basic types. > Once there, add copyright boilerplate. > > Signed-off-by: Juan Quintela (Actually I would still avoid moving too many things around

Re: [Qemu-devel] [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex

On 18/05/2017 14:06, Alberto Garcia wrote: > On Thu 11 May 2017 04:41:59 PM CEST, Paolo Bonzini wrote: > >> --- a/include/sysemu/block-backend.h >> +++ b/include/sysemu/block-backend.h >> @@ -72,11 +72,8 @@ typedef struct BlockDevOps { >> * fields that must be public. This is in particular

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

On Wed, May 17, 2017 at 05:47:50PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 + > include/migration/qemu-file.h | 4 > migration/channel.c | 1 + > migration/colo.c | 1 + >

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] >> Sent: Wednesday, May 17, 2017 6:18 AM >> >> >> On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: >> From: Halil Pasic

<    1   2   3   >