Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

On 05/23/2017 10:08 AM, Jason Wang wrote: On 2017年05月22日 19:46, Wang, Wei W wrote: On Monday, May 22, 2017 10:28 AM, Jason Wang wrote: On 2017年05月19日 23:33, Stefan Hajnoczi wrote: On Fri, May 19, 2017 at 11:10:33AM +0800, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On

Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking

Kamil Rytarowski writes: > On 22.05.2017 08:28, Markus Armbruster wrote: >> Kamil Rytarowski writes: >> >>> Hello, >>> >>> Excuse me for delay, I missed this mail. >> >> No problem. >> >>> Please see in-line. >>> >>> On 17.05.2017 09:28, Markus Armbruster wrote:

Re: [Qemu-devel] [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size

On 05/23/2017 10:04 AM, Jason Wang wrote: On 2017年05月22日 19:52, Wei Wang wrote: On 05/20/2017 04:42 AM, Michael S. Tsirkin wrote: On Fri, May 19, 2017 at 10:32:19AM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size)

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

On Mon, May 22, 2017 at 04:30:50PM +1000, Suraj Jitindar Singh wrote: > On Fri, 2017-05-19 at 11:10 +0530, Bharata B Rao wrote: > > Fix migration of radix guests by ensuring that we issue > > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > > > Reported-by: Nageswara R Sastry

Re: [Qemu-devel] [PATCH] migration: keep bytes_xfer_prev init'd to zero

On Fri, May 19, 2017 at 10:59:02PM +0100, Felipe Franciosi wrote: > The first time migration_bitmap_sync() is called, bytes_xfer_prev is set > to ram_state.bytes_transferred which is, at this point, zero. The next > time migration_bitmap_sync() is called, an iteration has happened and >

Re: [Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

On Mon, May 22, 2017 at 03:40:39PM -0300, Daniel Henrique Barboza wrote: > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started.

Re: [Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

Hi Hervé, On 05/22/2017 06:12 PM, Hervé Poussineau wrote: According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some

[Qemu-devel] [PATCH v5 1/4] net/rocker: Remove the dead error handling

Memory allocation functions like world_alloc, desc_ring_alloc etc, they are all wrappers around g_malloc, g_new etc. But g_malloc and similar functions doesn't return null. Because they ignore the fact that g_malloc() of 0 bytes returns null. So error checks for these allocation failure are

[Qemu-devel] [PATCH v5 4/4] net/rocker: Fix the unusual macro name

Suggested-by: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/net/rocker/rocker.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index 2764529..f8a32f7

[Qemu-devel] [PATCH v5 2/4] net/rocker: Plug memory leak in pci_rocker_init()

pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Signed-off-by: Mao Zhongyi Reviewed-by: Markus Armbruster ---

[Qemu-devel] [PATCH v5 3/4] net/rocker: Convert to realize()

The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a

[Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling

v5: * Patch 1 removed the dead error handling that was previously missing. * Patch 2 and 3 has not changed. * Patch 4 is a new patch to fix the unusual macro name. v4: * Patch 1 is following Markus's suggestion that remove the dead error handling. * Patch 2 is separate from patch 1 to plug the

[Qemu-devel] [PATCH 27/31] target/s390x: Use unwind data for helper_tprot

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 - target/s390x/translate.c | 1 - 2 files changed, 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index a874f8a..7f22bf0 100644 --- a/target/s390x/mem_helper.c +++

[Qemu-devel] [PATCH 23/31] target/s390x: Use unwind data for helper_lctlg

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 902290c..26960e4 100644 ---

[Qemu-devel] [PATCH 21/31] target/s390x: Use unwind data for helper_tre

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 15 --- target/s390x/translate.c | 1 - 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 748a6e8..4c6c6ee 100644 ---

[Qemu-devel] [PATCH 31/31] target/s390x: Use unwind data for helper_mvcs/mvcp

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 ++-- target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 4becc80..d8d29bd 100644 ---

[Qemu-devel] [PATCH 22/31] target/s390x: Use unwind data for helper_trt

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 4c6c6ee..902290c 100644 ---

[Qemu-devel] [PATCH 28/31] target/s390x: Use unwind data for helper_lra

Note that exception_index is not live during a TB, so there is no point saving it around mmu_translate. Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 4 +--- target/s390x/translate.c | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 19/31] target/s390x: Use unwind data for helper_unpk

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index da81b38..d37e691 100644 ---

[Qemu-devel] [PATCH 20/31] target/s390x: Use unwind data for helper_tr

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 +- target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d37e691..748a6e8 100644 ---

[Qemu-devel] [PATCH 29/31] target/s390x: Use atomic operations for COMPARE SWAP PURGE

Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/insn-data.def | 2 +- target/s390x/mem_helper.c | 32 target/s390x/translate.c | 42 ++ 4 files changed, 48

[Qemu-devel] [PATCH 17/31] target/s390x: Use unwind data for helper_clcle

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 7a59be0..6e85406 100644 ---

[Qemu-devel] [PATCH 26/31] target/s390x: Use unwind data for helper_testblock

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 +++ target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1e31bd3..a874f8a 100644 ---

[Qemu-devel] [PATCH 16/31] target/s390x: Use unwind data for helper_mvcle

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b764c48..7a59be0 100644 ---

[Qemu-devel] [PATCH 30/31] target/s390x: Implement CSPG

Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 4c91f30..8604847 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -838,6

[Qemu-devel] [PATCH 25/31] target/s390x: Use unwind data for helper_stctl

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b169e0e..1e31bd3 100644 ---

[Qemu-devel] [PATCH 13/31] target/s390x: Use unwind data for helper_lam

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d1a7bcd..4ecec74 100644 ---

[Qemu-devel] [PATCH 14/31] target/s390x: Use unwind data for helper_stam

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 4ecec74..d6d5047 100644 ---

[Qemu-devel] [PATCH 24/31] target/s390x: Use unwind data for helper_lctl

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 26960e4..b169e0e 100644 ---

[Qemu-devel] [PATCH 10/31] target/s390x: Use unwind data for helper_clst

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 3c28f3a..7c9e7c7 100644 ---

[Qemu-devel] [PATCH 18/31] target/s390x: Use unwind data for helper_cksm

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 6e85406..da81b38 100644 ---

[Qemu-devel] [PATCH 11/31] target/s390x: Use unwind data for helper_mvpg

Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 3 +-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index d6cc513..2b4e7be

[Qemu-devel] [PATCH 15/31] target/s390x: Use unwind data for helper_mvcl

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d6d5047..b764c48 100644 ---

[Qemu-devel] [PATCH 12/31] target/s390x: Use unwind data for helper_mvst

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 9ef9f4a..d1a7bcd 100644 ---

[Qemu-devel] [PATCH 06/31] target/s390x: Use unwind data for helper_mvc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 19 ++- target/s390x/translate.c | 1 - 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index e75c2de0..0295485 100644 ---

[Qemu-devel] [PATCH 08/31] target/s390x: Use unwind data for helper_clm

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d04850b..5f38ac3 100644 ---

[Qemu-devel] [PATCH 07/31] target/s390x: Use unwind data for helper_clc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 18 +- target/s390x/translate.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0295485..d04850b 100644 ---

[Qemu-devel] [PATCH 09/31] target/s390x: Use unwind data for helper_srst

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 5f38ac3..3c28f3a 100644 ---

[Qemu-devel] [PATCH 04/31] target/s390x: Use unwind data for helper_xc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 25 - target/s390x/translate.c | 1 - 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1018fe0..e0a6fad 100644

[Qemu-devel] [PATCH 05/31] target/s390x: Use unwind data for helper_oc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 18 +- target/s390x/translate.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index e0a6fad..e75c2de0 100644 ---

[Qemu-devel] [PATCH 03/31] target/s390x: Use unwind data for helper_nc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 18 +- target/s390x/translate.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index db80d53..1018fe0 100644 ---

[Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock

Previously, helper_ex would construct the insn and then implement the insn via direct calls other helpers. This was sufficient to boot Linux but that is all. It is easy enough to go the whole nine yards by stashing state for EXECUTE within the cpu, and then relying on a new TB to be created that

[Qemu-devel] [PATCH 01/31] target/s390: Use cpu_loop_exit_restore for tlb_fill

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0c6a0d9..e3325a4 100644 --- a/target/s390x/mem_helper.c +++

[Qemu-devel] [PATCH 00/31] target/s390x unwind patches

We can use cpu_restore_state (and via *_ra memory helpers) to avoid storing cpu state in expectation of the unlikely case of page fault or specification error. There are more that can be fixed, but this is all of mem_helper.c, and this patch set is large enough. r~ Richard Henderson (31):

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

On Mon, May 22, 2017 at 10:59:50AM +0200, Greg Kurz wrote: > On Mon, 22 May 2017 12:04:13 +1000 > David Gibson wrote: > > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > For historical reasons, we compute CPU device-tree ids with a non-trivial > >

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

On Mon, May 22, 2017 at 04:33:36PM +0200, Greg Kurz wrote: > On Mon, 22 May 2017 12:12:46 +1000 > David Gibson wrote: > > > On Mon, May 22, 2017 at 12:04:13PM +1000, David Gibson wrote: > > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > > For

[Qemu-devel] [PULL 9/9] e1000e: Fix ICR "Other" causes clear logic

From: Sameeh Jubran This commit fixes a bug which causes the guest to hang. The bug was observed upon a "receive overrun" (bit #6 of the ICR register) interrupt which could be triggered post migration in a heavy traffic environment. Even though the "receive overrun" bit (#6)

[Qemu-devel] [PULL 7/9] net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle

From: Zhang Chen Because filter_mirror_receive_iov() and filter_redirector_receive_iov() both use the filter_mirror_send() to send packet, so I change filter_mirror_send() to filter_send() that looks more common. And fix some codestyle. Signed-off-by: Zhang Chen

[Qemu-devel] [PULL 8/9] net/filter-rewriter: Remove unused option in filter-rewriter

From: Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index

[Qemu-devel] [PULL 3/9] virtio-net: fix wild pointer when remove virtio-net queues

From: Yunjian Wang The tx_bh or tx_timer will free in virtio_net_del_queue() function, when removing virtio-net queues if the guest doesn't support multiqueue. But it might be still referenced by virtio_net_set_status(), which needs to be set NULL. And also the tx_waiting

[Qemu-devel] [PULL 6/9] net/filter-mirror.c: Remove duplicate check code.

From: Zhang Chen The s->outdev have checked in filter_mirror_set_outdev(). Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/filter-mirror.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[Qemu-devel] [PULL 2/9] net/dump: Issue a warning for the deprecated "-net dump"

From: Thomas Huth Network dumping should be done with "-object filter-dump" nowadays. Using "-net dump" via the VLAN mechanism is considered as deprecated and might be removed in a future release. So warn the users now to inform them to user the filter-dump method instead.

[Qemu-devel] [PULL 5/9] hmp / net: Mark host_net_add/remove as deprecated

From: Thomas Huth The netdev_add and netdev_del commands should be used nowadays instead. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- hmp-commands.hx | 8 net/net.c | 13 + 2 files changed, 17

[Qemu-devel] [PULL 4/9] COLO-compare: Improve tcp compare trace event readability

From: Zhang Chen Because of previous patch's trace arguments over the limit of UST backend, so I rewrite the patch. Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 33

[Qemu-devel] [PULL 1/9] net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c

From: Thomas Huth The files tap-haiku.c and tap-aix.c are identical (except one line of error message). We should avoid such code duplication, so replace these by a generic tap-stub.c file instead. Signed-off-by: Thomas Huth Reviewed-by: Philippe

[Qemu-devel] [PULL 0/9] Net patches

The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

Ping... Sorry to disturb, just make this patchset not be missed. :) On 05/04/2017 03:06 PM, Paolo Bonzini wrote: On 04/05/2017 05:36, Xiao Guangrong wrote: Great. As there is no conflict between these two patchsets except dirty ring pages takes benefit from write-protect-all, i think they

Re: [Qemu-devel] A problem of IRQchip in QEMU and KVM for ARM

Any idea? Thanks. On Fri, May 19, 2017 at 1:46 PM, Li Zhang wrote: > > Hi, > > I am looking into QEMU code in ARM recently and trying to add add_hot_cpu in > QEMU for ARM, > but it doesn't work when enabling KVM. It reports error: > > "kvm_init_vcpu failed: Device or

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

On 2017年05月22日 19:46, Wang, Wei W wrote: On Monday, May 22, 2017 10:28 AM, Jason Wang wrote: On 2017年05月19日 23:33, Stefan Hajnoczi wrote: On Fri, May 19, 2017 at 11:10:33AM +0800, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On 05/17/2017 02:22 PM, Jason Wang wrote: On

Re: [Qemu-devel] [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size

On 2017年05月22日 19:52, Wei Wang wrote: On 05/20/2017 04:42 AM, Michael S. Tsirkin wrote: On Fri, May 19, 2017 at 10:32:19AM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size) and 1024 by the user. The queue size

Re: [Qemu-devel] [PATCH v2 00/11] Preparation for block job mutex

On Mon, May 08, 2017 at 04:12:59PM +0200, Paolo Bonzini wrote: > These are a bunch of cleanups and patches extracted from the AioContext > lock removal series. As a general theme, the patches reorganize > blockjob.c to follow the blockjob.h/blockjob_int.h separation more > closely. For this

[Qemu-devel] [PATCH V2] Add code to connect to external panel, for ARM

>From 5f5c186162ef5f56872095318106e9fe360ae310 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Tue, 23 May 2017 01:43:32 +0100 Subject: [PATCH] Add code to connect to external panel, for ARM Has no effect if panel not found. GDummyPanel Fix formating issues. Add inital

Re: [Qemu-devel] [PATCH v2] e1000e: Fix ICR "Other" causes clear logic

On 2017年05月22日 19:26, Sameeh Jubran wrote: This commit fixes a bug which causes the guest to hang. The bug was observed upon a "receive overrun" (bit #6 of the ICR register) interrupt which could be triggered post migration in a heavy traffic environment. Even though the "receive overrun"

Re: [Qemu-devel] [PATCH 4/4] target/mips: optimize WSBH, DSBH and DSHD

On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Use the same mask to avoid having to load two different constants, as suggested by Richard Henderson. Signed-off-by: Aurelien Jarno --- target/mips/translate.c | 18 -- 1 file changed, 12 insertions(+), 6

Re: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM Message-id: 1da30c06-46bd-47fa-b0ef-886ea9ab84e5@ONE.local === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM Message-id:

[Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

>From 9256c1450557ed67b4328761ab80b4e80be26e3e Mon Sep 17 00:00:00 2001 From: John Bradley Date: Tue, 23 May 2017 01:43:32 +0100 Subject: [PATCH] Add code to connect to external panel, for ARM Has no effect if panel not found. GDummyPanel Fix formating issues. Add inital

Re: [Qemu-devel] [PATCH 3/4] target/cris: optimize swap

On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Use the same mask to avoid having to load two different constants, as suggest by Richard Henderson. Also use one less temp. Signed-off-by: Aurelien Jarno --- target/cris/translate.c | 15 +++ 1 file changed, 7

Re: [Qemu-devel] [PATCH 2/4] target/arm: simplify and optimize aarch64 rev16

On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Instead of byteswapping individual 16-bit words one by one, work on the whole register at the same time using shifts and mask. This is the same strategy than the aarch32 version of rev16 and is much more efficient in the case sf=1. Signed-off-by:

Re: [Qemu-devel] [PATCH 1/4] target/arm: optimize aarch32 rev16

On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Use the same mask to avoid having to load two different constants, as suggested by Richard Henderson. Signed-off-by: Aurelien Jarno --- target/arm/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 56fa8a79-fa90-4adc-aa0e-0527c9d96698@ONE.local Subject: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues. Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 56fa8a79-fa90-4adc-aa0e-0527c9d96698@ONE.local Subject: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix

[Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

>From 468b7c74d36b1e9d56ca014531301f0485254866 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Fri, 19 May 2017 00:01:07 +0100 Subject: [PATCH] [PATCH V2] GDummyPanel Fix formatingissues. Add inital discussion of protocol version. Add code to connect with

Re: [Qemu-devel] [PATCH 2/2] hw/arm: Integrate ADC model into Aspeed SoC

On Fri, May 19, 2017 at 5:26 PM, Andrew Jeffery wrote: > Signed-off-by: Andrew Jeffery The connections look good to me. I'll have a look at V2 of your first patch. Reviewed-by: Alistair Francis Thanks, Alistair > --- >

Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

Ohh, sorry. I don't know how or why, but I missed all your replies (this was archived in gmail) Below is qmp-net-test.c, It's just a copy and paste of what Markus suggested. I could try doing it with a socket (virtio-net-test.c) as Jason suggested but I'm afraid I won't have time this week as

Re: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170522211205.14265-1-hpous...@reactos.org Subject: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] qapi: Fix some blockdev-add documentation regressions

In the process of getting rid of docs/qmp-commands.txt, we managed to regress on any text that changed after the point where the move was first branched and when the move actually occurred. For example, commit 3282eca for blockdev-snapshot re-added the extra "options" layer which had been cleaned

Re: [Qemu-devel] [PATCH v8 14/21] (SQUASHED) move doc to schema

On 01/13/2017 08:41 AM, Marc-André Lureau wrote: > qmp-commands: move 'add_client' doc to schema > Sadly, the squashed version introduced some documentation regressions. For example, the documentation for blockdev-snapshot (got merged as commit 3282eca4): > @@ -983,9 +1193,31 @@ > # > #

[Qemu-devel] [PATCH v2 02/13] vvfat: replace tabs by 8 spaces

This was a complete mess. On 2299 indented lines: - 1329 were with spaces only - 617 with tabulations only - 353 with spaces and tabulations Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2054 - 1 file changed,

[Qemu-devel] [PATCH v2 09/13] vvfat: correctly create base short names for non-ASCII filenames

More specifically, create short name from filename and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about mismatch between SFN and LFN. Specification: "FAT: General

[Qemu-devel] [PATCH v2 04/13] vvfat: rename useless enumeration values

MODE_FAKED and MODE_RENAMED are not and were never used. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 8b5f53ad26..6a36d4f7fa 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert

On 05/22/2017 04:11 PM, Hervé Poussineau wrote: > - bs->total_sectors is the number of sectors of the whole disk > - s->sector_count is the number of sectors of the FAT partition > > This fixes the following assert in qemu-img map: > qemu-img.c:2641: get_block_status: Assertion `nb_sectors'

[Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names

More specifically: - try without numeric-tail only if LFN didn't have invalid short chars - start at ~1 (instead of ~0) - handle case if numeric tail is more than one char (ie > 10) Windows 9x Scandisk doesn't see anymore mismatches between short file names and long file names for non-ASCII

[Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

- offset_to_bootsector is the number of sectors up to FAT bootsector - offset_to_fat is the number of sectors up to first File Allocation Table - offset_to_root_dir is the number of sectors up to root directory sector Replace first_sectors_number - 1 by offset_to_bootsector. Replace

[Qemu-devel] [PATCH v2 06/13] vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors

Specification: "FAT: General overview of on-disk format" v1.03, pages 11-13 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index

[Qemu-devel] [PATCH v2 07/13] vvfat: always create . and .. entries at first and in that order

readdir() doesn't always return . and .. entries at first and in that order. This leads to not creating them at first in the directory, which raises some errors on file system checking utilities like MS-DOS Scandisk. Specification: "FAT: General overview of on-disk format" v1.03, page 25 Fixes:

[Qemu-devel] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert

- bs->total_sectors is the number of sectors of the whole disk - s->sector_count is the number of sectors of the FAT partition This fixes the following assert in qemu-img map: qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed. This also fixes an infinite loop in qemu-img convert.

[Qemu-devel] [PATCH v2 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16

FAT12/FAT16 root directory is two sectors in size, which allows only 512 directory entries. Prevent QEMU startup if too much files exist, instead of overflowing root directory. Also introduce variable root_entries, which will be required for FAT32. Fixes:

[Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some FAT drivers might not recognize the volume." Specification:

[Qemu-devel] [PATCH v2 08/13] vvfat: correctly create long names for non-ASCII filenames

Assume that input filename is encoded as UTF-8, so correctly create UTF-16 encoding. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/block/vvfat.c

[Qemu-devel] [PATCH v2 03/13] vvfat: fix typos

Signed-off-by: Hervé Poussineau --- block/vvfat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index d3afb731b6..8b5f53ad26 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -404,9 +404,9 @@ static void

[Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

Hi, This patchset fixes some of issues I encountered when trying to use vvfat, and fixes bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 Patch 1 fixes a crash when using 'qemu-img convert'. Patches 2 to 6 are code cleanup. No functionnal changes. Patches 7 to 13 fix problems detected

[Qemu-devel] [PATCH v2 12/13] vvfat: handle KANJI lead byte 0xe5

Specification: "FAT: General overview of on-disk format" v1.03, page 23 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 5376659010..53e8faa54c 100644 ---

[Qemu-devel] [PATCH] qemu-doc: Move the qemu-ga description into a separate chapter

The qemu-ga description is currently a subsection of the Disk Images chapter - which does not make much sense since the qemu-ga is not directly related to disk images. So let's move this information into a separate chapter instead. Signed-off-by: Thomas Huth --- qemu-doc.texi

[Qemu-devel] [PATCH] qemu-doc: Add hyperlinks to further license information

Add a link to the GPLv2 and a link to the LICENSE file in the QEMU repository to fix the two TODO items in this appendix. Signed-off-by: Thomas Huth --- qemu-doc.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi

Re: [Qemu-devel] [PATCH 3/4] block: Simplify use of BDRV_BLOCK_RAW.

On 05/18/2017 09:32 PM, Eric Blake wrote: Not sure why I included a trailing dot in the subject line; a maintainer can remove that if desired. > The lone caller that cares about a return of BDRV_BLOCK_RAW > completely replaces the return value, so there is no point in > passing BDRV_BLOCK_DATA.

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

On 2017-05-22 22:06, Eric Blake wrote: > On 05/22/2017 02:52 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/126 | 105 >> + >> tests/qemu-iotests/126.out | 23 ++ >>

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

On 05/22/2017 02:52 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/126 | 105 > + > tests/qemu-iotests/126.out | 23 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 129

Re: [Qemu-devel] [PATCH v2 2/3] block/file-*: *_parse_filename() and colons

On 05/22/2017 02:52 PM, Max Reitz wrote: > The file drivers' *_parse_filename() implementations just strip the > optional protocol prefix off the filename. However, for e.g. > "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's > filename which looks like it should be managed

[Qemu-devel] [PATCH v2 1/3] block: Fix backing paths for filenames with colons

path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first slash. A protocol prefix that is not

  1   2   3   >