[Qemu-devel] [Bug 961757] Re: wrong error for blockdev-snapshot-sync

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/961757 Title: wrong error

[Qemu-devel] [Bug 899664] Re: Bad internet performance for Host to Guest or Guest to Host

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/899664 Title: Bad

[Qemu-devel] [Bug 822408] Re: Unable to access disk image on mipsel host

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/822408 Title: Unable to

Re: [Qemu-devel] [PATCH v2 8/8] error: Add a 'error: ' prefix to error_report()

On 07/07/2017 08:21 PM, Alistair Francis wrote: As we don't regard error messages as a stable API the let's add a 'error: ' prefix to the original error_report() messages. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH 3/3] linux-user/sh4: Reduce TARGET_VIRT_ADDR_SPACE_BITS to 31

The real kernel has TASK_SIZE as 0x7c00, due to quirks with a couple of SH parts. But nominally user-space is limited to 2GB. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/sh4/cpu.h

[Qemu-devel] [PATCH 2/3] linux-user: Tidy and enforce reserved_va initialization

We had a check using TARGET_VIRT_ADDR_SPACE_BITS to make sure that the allocation coming in from the command-line option was not too large, but that didn't include target-specific knowledge about other restrictions on user-space. Remove several target-specific hacks in linux-user/main.c. For

[Qemu-devel] [PATCH 0/3] linux-user fixes for va mapping

At first I was simply going to add TARGET_SH to the existing set of defines that trigger a 31-bit address space. But then I realized that one could create non-working va configurations from the command-line. r~ Richard Henderson (3): tcg: Fix off-by-one in assert in page_set_flags

[Qemu-devel] [PATCH 1/3] tcg: Fix off-by-one in assert in page_set_flags

Most of the users of page_set_flags offset (page, page + len) as the end points. One might consider this an error, since the other users do supply an endpoint as the last byte of the region. However, the first thing that page_set_flags does is round end UP to the start of the next page. Which

Re: [Qemu-devel] [PATCH v2 3/8] Convert error_report() to warn_report()

> "Alistair" == Alistair Francis writes: Alistair> Convert all uses of error_report("[Ww]arning:"... to use Alistair> warn_report() instead. This helps standardise on a single Alistair> method of printing warnings to the user. Alistair> All of the warnings were

Re: [Qemu-devel] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps

On 07/07/2017 05:13 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.07.2017 20:53, John Snow wrote: >> >> On 07/06/2017 04:05 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 06.07.2017 00:46, John Snow wrote: On 07/05/2017 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.02.2017 16:04, Fam

[Qemu-devel] [PATCH v2 8/8] error: Add a 'error: ' prefix to error_report()

As we don't regard error messages as a stable API the let's add a 'error: ' prefix to the original error_report() messages. Signed-off-by: Alistair Francis --- util/qemu-error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/qemu-error.c

[Qemu-devel] [PATCH v2 7/8] Convert error_report*_err() to warn_report*_err()

Convert all uses of error_report*_err("Warning:"... to use warn_report*_err() instead. This helps standardise on a single method of printing warnings to the user. Signed-off-by: Alistair Francis Cc: Paolo Bonzini Cc: Richard Henderson

[Qemu-devel] [PATCH v2 5/8] char-socket: Report TCP socket waiting as information

When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error it is just information so let's change the report to use info_report() instead. Signed-off-by: Alistair Francis Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v2 3/8] Convert error_report() to warn_report()

Convert all uses of error_report("[Ww]arning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i \ 's|error_report.*[Ww]arning: |warn_report("|g'

[Qemu-devel] [PATCH v2 4/8] hw/i386: Improve some of the warning messages

Signed-off-by: Alistair Francis Suggested-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 --- hw/i386/pc.c | 9 - hw/i386/pc_q35.c | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH v2 2/8] error: Functions to report warnings and informational messages

Add warn_report(), warn_vreport() for reporting warnings, and info_report(), info_vreport() for informational messages. These are implemented them with a helper function factored out of error_vreport(), suitably generalized. This patch makes no changes to the output of the original error_report()

[Qemu-devel] [PATCH v2 6/8] error: Implement the warn and free Error functions

Implement warn_report_err() and warn_reportf_err() functions which are the same as the error_report_err() and error_reportf_err() functions except report a warning instead of an error. Signed-off-by: Alistair Francis --- include/qapi/error.h | 11 +++

[Qemu-devel] [PATCH v2 0/8] Implement a warning_report function

QEMU currently has a standard method to report errors with error_repot(). This ensure a sane and standard format when printing errors. This series is attempting to extend this functionality for warnings and information as well. This patch renames error_print_loc() function to be more clear, but I

[Qemu-devel] [PATCH v2 1/8] util/qemu-error: Rename error_print_loc() to be more generic

Rename the error_print_loc() function in preparation for using it to print warnings as well. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- util/qemu-error.c | 4 ++-- 1 file

Re: [Qemu-devel] [PATCH v2 4/8] target/s390x: Implement SRSTU

On 2017-07-01 13:25, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 1 + > target/s390x/mem_helper.c | 41 + > target/s390x/translate.c | 13 + > target/s390x/insn-data.def

Re: [Qemu-devel] [PATCH v2 3/8] target/s390x: Tidy SRST

On 2017-07-01 13:25, Richard Henderson wrote: > Since we require all registers saved on input, read R0 from ENV instead > of passing it manually. Recognize the specification exception when R0 > contains incorrect data. Keep high bits of result registers unmodified > when in 31 or 24-bit mode. >

Re: [Qemu-devel] [PATCH v2 26/27] target/sh4: Implement fsrra

On 2017-07-06 16:21, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/sh4/helper.h| 1 + > target/sh4/op_helper.c | 16 > target/sh4/translate.c | 2 ++ > 3 files changed, 19 insertions(+) > > diff --git a/target/sh4/helper.h

Re: [Qemu-devel] [PATCH v5 2/2] live-block-ops.txt: Rename, rewrite, and improve it

Last time, on DRAGON BALL Q: On 07/06/2017 10:36 AM, Kashyap Chamarthy wrote: [A lot of good documentation] > + > +So, the following is the flow for `block-commit_Case-3`_ -- to convert a > +disk image chain such as this:: > + Maybe drop the "So, " "The following is the flow for 'Block Commit

Re: [Qemu-devel] [PATCH v2 25/27] target/sh4: Add missing FPSCR.PR == 0 checks

On 2017-07-06 16:21, Richard Henderson wrote: > Both frchg and fschg require PR == 0, otherwise undefined_operation. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 24/27] target/sh4: Implement fpchg

On 2017-07-06 16:21, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B

Re: [Qemu-devel] [PATCH v2 23/27] target/sh4: Introduce CHECK_SH4A

On 2017-07-06 16:21, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 64 > +++--- > 1 file changed, 29 insertions(+), 35 deletions(-) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 22/27] target/sh4: Introduce CHECK_FPSCR_PR_*

On 2017-07-06 16:21, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 57 > +++--- > 1 file changed, 31 insertions(+), 26 deletions(-) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 20/27] target/sh4: Unify code for CHECK_FPU_ENABLED

On 2017-07-06 16:21, Richard Henderson wrote: > We do not need to emit N copies of raising an exception. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH v2 21/27] target/sh4: Tidy misc illegal insn checks

On 2017-07-06 16:21, Richard Henderson wrote: > Now that we have a do_illegal label, use goto in order > to self-document the forcing of the exception. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 22 +- > 1 file changed, 13

Re: [Qemu-devel] [PATCH v2 19/27] target/sh4: Unify code for CHECK_PRIVILEGED

On 2017-07-06 16:21, Richard Henderson wrote: > We do not need to emit N copies of raising an exception. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 18/27] target/sh4: Unify code for CHECK_NOT_DELAY_SLOT

On 2017-07-06 16:21, Richard Henderson wrote: > We do not need to emit N copies of raising an exception. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 17/27] target/sh4: Simplify 64-bit fp reg-reg move

On 2017-07-06 16:21, Richard Henderson wrote: > We do not need to form full 64-bit quantities in order to perform > the move. This reduces code expansion on 64-bit hosts. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 8 > 1 file changed, 4

Re: [Qemu-devel] [PATCH v2 16/27] target/sh4: Load/store Dr as 64-bit quantities

On 2017-07-06 16:21, Richard Henderson wrote: > This enforces proper alignment and makes the register update > more natural. Note that there is a more serious bug fix for > fmov {DX}Rn,@(R0,Rn) to use a store instead of a load. > > Signed-off-by: Richard Henderson > --- >

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

Hello Jean, Thanks for the information. Is someone already working on implementing this, or is this something I can look into and implementing ? Also, as Michael mentioned and I looked in the vfio iommu (type1) driver implementation that it supports mainly static mappings of user-space

Re: [Qemu-devel] [PATCH v2 3/3] xen-disk: use an IOThread per instance

On Fri, 7 Jul 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 22 June 2017 23:15 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > > bl...@nongnu.org;

Re: [Qemu-devel] [PATCH v2 15/27] target/sh4: Merge DREG into fpr64 routines

On 2017-07-06 16:20, Richard Henderson wrote: > Also add a debugging assert that we did signal illegal opc > for odd double-precision registers. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 26 +++--- > 1 file changed, 15

Re: [Qemu-devel] [PATCH v2 14/27] target/sh4: Eliminate unused XREG macro

On 2017-07-06 16:20, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B

Re: [Qemu-devel] [PATCH v2 13/27] target/sh4: Hoist fp register bank selection

On 2017-07-06 16:20, Richard Henderson wrote: > Compute which register bank to use once at the start of translation. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 12/27] target/sh4: Pass DisasContext to fpr64 routines

On 2017-07-06 16:20, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) Reviewed-by: Aurelien Jarno -- Aurelien Jarno

Re: [Qemu-devel] [PATCH v2 11/27] target/sh4: Unify cpu_fregs into FREG

On 2017-07-06 16:20, Richard Henderson wrote: > We were treating FREG as an index and REG as a TCGv. > Making FREG return a TCGv is both less confusing and > a step toward cleaner banking of cpu_fregs. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 125

Re: [Qemu-devel] [PATCH v2 10/27] target/sh4: Hoist register bank selection

On 2017-07-06 16:20, Richard Henderson wrote: > Compute which register bank to use once at the start of translation. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-)

Re: [Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean

On 2017-07-06 16:20, Richard Henderson wrote: > If we mask off any out-of-band bits before we assign to the > variable, then we don't need to clean it up when reading. > > Signed-off-by: Richard Henderson > --- > target/sh4/cpu.h | 2 +- > target/sh4/cpu.c | 2 +- > 2 files

Re: [Qemu-devel] [PATCH v2 03/27] target/sh4: Introduce TB_FLAG_ENVFLAGS_MASK

On 2017-07-06 16:20, Richard Henderson wrote: > We'll be putting more things into this bitmask soon. > Let's have a name that covers all possible uses. > > Signed-off-by: Richard Henderson > --- > target/sh4/cpu.h | 4 +++- > target/sh4/translate.c | 4 ++-- > 2 files

Re: [Qemu-devel] [PATCH v2 05/27] target/sh4: Adjust TB_FLAG_PENDING_MOVCA

On 2017-07-06 16:20, Richard Henderson wrote: > Don't leave an unused bit after DELAY_SLOT_MASK. > > Signed-off-by: Richard Henderson > --- > target/sh4/cpu.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Aurelien Jarno --

Re: [Qemu-devel] [PATCH v2 02/27] target/sh4: Consolidate end-of-TB tests

On 2017-07-06 16:20, Richard Henderson wrote: > We can fold 3 different tests within the decode loop > into a more accurate computation of max_insns to start. > > Signed-off-by: Richard Henderson > --- > target/sh4/translate.c | 29 + > 1 file

[Qemu-devel] [PATCH 2/2] qom: Fix ambiguous path detection when ambiguous=NULL

object_resolve_path*() ambiguous path detection breaks when ambiguous==NULL and the object tree have 3 objects of the same type and only 2 of them are under the same parent. e.g.: /container/obj1 (TYPE_FOO) /container/obj2 (TYPE_FOO) /obj2 (TYPE_FOO) With the above tree,

[Qemu-devel] [PATCH 1/2] tests: Test case for object_resolve_path*()

Test for partial path lookup using object_resolve_path*(). Signed-off-by: Eduardo Habkost --- tests/check-qom-proplist.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c

[Qemu-devel] [PATCH 0/2] qom: Fix ambiguous path detection when ambiguous=NULL

object_resolve_path*() ambiguous path detection breaks when ambiguous==NULL and the object tree have 3 objects of the same type and only 2 of them are under the same parent. e.g.: /container/obj1 (TYPE_FOO) /container/obj2 (TYPE_FOO) /obj2 (TYPE_FOO) With the above tree,

Re: [Qemu-devel] [PATCH v3 3/4] qcow2: add shrink image support

On 07/07/2017 09:30 AM, Pavel Butsykin wrote: > This patch add shrinking of the image file for qcow2. As a result, this allows > us to reduce the virtual image size and free up space on the disk without > copying the image. Image can be fragmented and shrink is done by punching > holes > in the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

Anyway, this was more of an experiment than a serious fix proposal. I believe the general idea is solid but it'll get a couple of spins to get a good patch for pushing. I'll send the POC as a RFC to get things started and we'll see what happens. I've sent the POC as RFC here: "[RFC drcVI

Re: [Qemu-devel] [PATCH v5 5/5] tests: add functional test validating ipv4/ipv6 address flag handling

On 07/07/2017 10:15 AM, Daniel P. Berrange wrote: > The semantics around handling ipv4=on|off & ipv6=on|off are quite > subtle to understand in combination with the various hostname addresses > and backend types. Introduce a massive test matrix that launches QEMU > and validates the ability to

[Qemu-devel] [RFC drcVI PATCH] spapr: reset DRCs on migration pre_load

"spapr: Remove 'awaiting_allocation' DRC flag" removed the flag that was originally was being used to prevent a race condition between hot unplug and hotplug. The DRC code base got simplified and more robust over time, eliminating the conditions that led to this race. Thus the awaiting_allocation

Re: [Qemu-devel] [PATCH v3 1/4] qemu-img: add --shrink flag for resize

On 07/07/2017 09:30 AM, Pavel Butsykin wrote: > The flag as additional precaution of data loss. Perhaps in the future the s/as/is/ s/of/against/ > operation shrink without this flag will be blocked for all formats, but while s/while/for now/ > we need to maintain compatibility with raw. > >

Re: [Qemu-devel] [PATCH v5 2/2] live-block-ops.txt: Rename, rewrite, and improve it

On 07/07/2017 06:46 AM, Kashyap Chamarthy wrote: > Thanks for your patience in review. Much appreciated (including the > grammar corrections)! > > I'll wait for the rest of your comments before I spin a v6. > > [...] Thank *you* for exercising the necessary patience to make incredibly nice

Re: [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256

On 07/07/2017 09:53 AM, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 07.07.2017 12:00, Markus Armbruster wrote: >>> "Daniel P. Berrange" writes: >>> On Fri, Jul 07, 2017 at 10:05:22AM +0200, Markus Armbruster wrote:

Re: [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events

On 06/23/2017 08:02 AM, Tomáš Golembiovský wrote: > This is just a draft, or a request for comments if you will. > > This patch sets drafts the support of sending events by QEMU Guest Agent. > Events can plan important role in monitoring of the guest OS behaviour. The > range of use cases ranges

Re: [Qemu-devel] [RFC 1/3] qemu-ga: add support for events

On 06/23/2017 08:02 AM, Tomáš Golembiovský wrote: > Events can play an integral role when monitoring internal state of the > guest OS. This patch adds the core functionality for adding events to > QEMU Guest Agent. Will sending events confuse existing clients that aren't expecting them? Do we

Re: [Qemu-devel] [PATCH v5 3/9] nbd: Expose and debug more NBD constants

On 07/07/2017 03:30 PM, Eric Blake wrote: > The NBD protocol has several constants defined in various extensions > that we are about to implement. Expose them to the code, along with > an easy way to map various constants to strings during diagnostic > messages. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events

Hi, On Sun, 25 Jun 2017 23:25:17 +0200 Tomáš Golembiovský wrote: > Hi, > > On Fri, 23 Jun 2017 13:25:34 + > Marc-André Lureau wrote: > > > Hi > > > > On Fri, Jun 23, 2017 at 3:03 PM Tomáš Golembiovský > > wrote: > >

Re: [Qemu-devel] [Qemu-block] [PATCH v5 6/9] nbd: Implement NBD_OPT_GO on server

On 07/07/2017 03:30 PM, Eric Blake wrote: > NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure > requires us to close the connection rather than report an error. > Therefore, upstream NBD recently added NBD_OPT_GO as the improved > version of the option that does what we want [1],

[Qemu-devel] [PATCH v5 9/9] nbd: Implement NBD_INFO_BLOCK_SIZE on client

The upstream NBD Protocol has defined a new extension to allow the server to advertise block sizes to the client, as well as a way for the client to inform the server whether it intends to obey block sizes. When using the block layer as the client, we will obey block sizes; but when used as

[Qemu-devel] [PATCH v5 6/9] nbd: Implement NBD_OPT_GO on server

NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure requires us to close the connection rather than report an error. Therefore, upstream NBD recently added NBD_OPT_GO as the improved version of the option that does what we want [1], along with NBD_OPT_INFO that returns the same

[Qemu-devel] [PATCH v5 1/9] nbd: Create struct for tracking export info

The NBD Protocol is introducing some additional information about exports, such as minimum request size and alignment, as well as an advertised maximum request size. It will be easier to feed this information back to the block layer if we gather all the information into a struct, rather than

[Qemu-devel] [PATCH v5 8/9] nbd: Implement NBD_INFO_BLOCK_SIZE on server

The upstream NBD Protocol has defined a new extension to allow the server to advertise block sizes to the client, as well as a way for the client to inform the server that it intends to obey block sizes. Thanks to a recent fix (commit df7b97ff), our real minimum transfer size is always 1 (the

[Qemu-devel] [PATCH v5 3/9] nbd: Expose and debug more NBD constants

The NBD protocol has several constants defined in various extensions that we are about to implement. Expose them to the code, along with an easy way to map various constants to strings during diagnostic messages. Signed-off-by: Eric Blake --- v5: rebase to master, add

[Qemu-devel] [PATCH v5 7/9] nbd: Implement NBD_OPT_GO on client

NBD_OPT_EXPORT_NAME is lousy: per the NBD protocol, any failure requires the server to close the connection rather than report an error to us. Therefore, upstream NBD recently added NBD_OPT_GO as the improved version of the option that does what we want [1]: it reports sane errors on failures,

[Qemu-devel] [PATCH v5 4/9] nbd: Simplify trace of client flags in negotiation

Simplify the tracing of client flags in the server, and return -EINVAL instead of -EIO if we successfully read but don't like those flags. Signed-off-by: Eric Blake --- v5: new patch --- nbd/server.c | 6 ++ nbd/trace-events | 4 +--- 2 files changed, 3

[Qemu-devel] [PATCH v5 2/9] nbd: Don't bother tracing an NBD_OPT_ABORT response failure

We really don't care if our spec-compliant reply to NBD_OPT_ABORT was received, so shave off some lines of code by not even tracing it. Signed-off-by: Eric Blake --- v5: new patch --- nbd/server.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff

[Qemu-devel] [PATCH v5 5/9] nbd: Refactor reply to NBD_OPT_EXPORT_NAME

Reply directly in nbd_negotiate_handle_export_name(), rather than waiting until nbd_negotiate_options() completes. This will make it easier to implement NBD_OPT_GO. Pass additional parameters around, rather than stashing things inside NBDClient. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v5 0/9] Implement NBD_OPT_GO, block size advertisement

The NBD protocol has now finalized the extension that fixes several shortcomings with NBD_OPT_EXPORT_NAME (namely, no error reporting, no way for the server to advertise block sizes to the client): https://github.com/NetworkBlockDevice/nbd/blob/extension-info/doc/proto.md This sort of overlaps

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On 07/07/17 21:54, Eduardo Habkost wrote: > On Fri, Jul 07, 2017 at 04:30:29PM -0300, Eduardo Habkost wrote: >> On Fri, Jul 07, 2017 at 08:18:20PM +0200, Igor Mammedov wrote: >>> On Fri, 7 Jul 2017 12:09:56 -0300 >>> Eduardo Habkost wrote: >>> On Fri, Jul 07, 2017 at

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On Fri, Jul 07, 2017 at 04:30:29PM -0300, Eduardo Habkost wrote: > On Fri, Jul 07, 2017 at 08:18:20PM +0200, Igor Mammedov wrote: > > On Fri, 7 Jul 2017 12:09:56 -0300 > > Eduardo Habkost wrote: > > > > > On Fri, Jul 07, 2017 at 04:58:17PM +0200, Igor Mammedov wrote: > > > >

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On Fri, Jul 07, 2017 at 08:18:20PM +0200, Igor Mammedov wrote: > On Fri, 7 Jul 2017 12:09:56 -0300 > Eduardo Habkost wrote: > > > On Fri, Jul 07, 2017 at 04:58:17PM +0200, Igor Mammedov wrote: > > > On Fri, 7 Jul 2017 10:13:00 -0300 > > > "Eduardo Habkost"

[Qemu-devel] [PATCH] fixup! nbd: use generic trace subsystem instead of TRACE macro

From: Vladimir Sementsov-Ogievskiy [eblake minor tweaks to a couple of traces] Signed-off-by: Eric Blake --- If you are okay with this, I plan to squash this into your patch 10 when I send my pull request nbd/client.c | 3 +-- nbd/server.c

Re: [Qemu-devel] Fwd: [PATCH v2.5] fixup! linux-user/sh4: Notice gUSA regions during signal delivery

On 07/07/2017 07:57 AM, Richard Henderson wrote: +/* ??? The SH4 kernel checks for and address above 0xC000. + However, the page mappings in qemu linux-user aren't as restricted + and we wind up with the normal stack mapped above 0xF000. + That said, there is no

Re: [Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

On 07/07/2017 08:29 AM, Alex Bennée wrote: Naming all of these different exit conditions is certainly non-trivial. Given the variation of usage this is something that should probably be done after Lluís common run loop goes in and we can beef up the semantics of the various exit conditions.

[Qemu-devel] [PULL 3/3] xen/pt: Fixup addr validation in xen_pt_pci_config_access_check

From: Anoob Soman xen_pt_pci_config_access_check checks if addr >= 0xFF. 0xFF is a valid address and should not be ignored. Signed-off-by: Anoob Soman Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini

[Qemu-devel] [PATCH] MAINTAINERS: Promote NBD to supported, with new maintainer

We are promising more than just odd fixes, and Paolo is hoping to offload the pull requests to me. Also, enough of NBD is related to the block layer that it is worth including qemu-block on patches. Signed-off-by: Eric Blake --- If there are no objections, I'll include this

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On Fri, 7 Jul 2017 12:09:56 -0300 Eduardo Habkost wrote: > On Fri, Jul 07, 2017 at 04:58:17PM +0200, Igor Mammedov wrote: > > On Fri, 7 Jul 2017 10:13:00 -0300 > > "Eduardo Habkost" wrote: > [...] > > > I don't disagree with adding the assert(), but it

Re: [Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

On 07/07/2017 07:36 AM, Peter Maydell wrote: On 7 July 2017 at 18:32, Alex Bennée wrote: Given the wording of: /* is_jmp field values */ #define DISAS_NEXT0 /* next instruction can be analyzed */ #define DISAS_JUMP1 /* only pc was modified dynamically */

Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework

On 07/07/2017 01:56 AM, Lluís Vilanova wrote: +void translator_loop(const TranslatorOps *ops, DisasContextBase *db, + CPUState *cpu, TranslationBlock *tb) +{ +int max_insns; + +/* Initialize DisasContext */ +db->tb = tb; +db->pc_first = tb->pc; +

Re: [Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_insn

On 07/07/2017 07:33 AM, Peter Maydell wrote: On 7 July 2017 at 16:26, Richard Henderson wrote: That is the purpose of DISAS_EXC too. We've called a noreturn helper to raise an exception and all following code is unreached. If there *was* any code being emitted afterward,

[Qemu-devel] [PULL 2/3] xen-platform: Cleanup network infrastructure when emulated NICs are unplugged

From: Ross Lagerwall When the guest unplugs the emulated NICs, cleanup the peer for each NIC as it is not needed anymore. Most importantly, this allows the tap interfaces which QEMU holds open to be closed and removed. Signed-off-by: Ross Lagerwall

[Qemu-devel] [PULL 0/3] please pull xen-20170707-tag

/xen-20170707-tag for you to fetch changes up to 4daf62594d13dfca2ce3a74dd3bddee5f54d7127: xen/pt: Fixup addr validation in xen_pt_pci_config_access_check (2017-07-07 11:13:10 -0700) Xen 2017/07/07

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

On 07/07/2017 07:32 AM, Lluís Vilanova wrote: That said, even for AArch32 we know by the TB flags whether or not we're going to be generating arm or thumb code. I think that these hooks will allow arm and thumb mode to finally be split apart cleanly, instead of the tangle that they are now. I

[Qemu-devel] [PULL 1/3] xenfb: remove xen_init_display "temporary" hack

Initialize xenfb properly, as all other backends, from its own "initialise" function. Remove the dependency of vkbd on vfb: use qemu_console_lookup_by_index to find the principal console (to get the size of the screen) instead of relying on a vfb backend to be available (which adds a dependency

Re: [Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

On 7 July 2017 at 18:32, Alex Bennée wrote: > Given the wording of: > > /* is_jmp field values */ > #define DISAS_NEXT0 /* next instruction can be analyzed */ > #define DISAS_JUMP1 /* only pc was modified dynamically */ > #define DISAS_UPDATE 2 /* cpu state was

Re: [Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

Richard Henderson writes: > On 07/07/2017 07:36 AM, Peter Maydell wrote: >> On 7 July 2017 at 18:32, Alex Bennée wrote: >>> Given the wording of: >>> >>> /* is_jmp field values */ >>> #define DISAS_NEXT0 /* next instruction can be analyzed */ >>>

Re: [Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

Alex Bennée writes: > Previously DISAS_JUMP did ensure this but with the optimisation of > 8a6b28c7 (optimize indirect branches) we might not leave the loop. > This means if any pending interrupts are cleared by changing IRQ flags > we might never get around to servicing

Re: [Qemu-devel] change x86 default machine type to Q35?

On Fri, Jul 07, 2017 at 06:17:57PM +0300, Michael S. Tsirkin wrote: > On Fri, Jul 07, 2017 at 10:39:49AM -0300, Eduardo Habkost wrote: > > On Wed, Jul 05, 2017 at 12:32:10PM +0300, Marcel Apfelbaum wrote: > > > On 05/07/2017 11:14, Thomas Huth wrote: > > > > Hi, > > > > > > > > > > Hi, > > >

[Qemu-devel] Fwd: [PATCH v2.5] fixup! linux-user/sh4: Notice gUSA regions during signal delivery

Bah. Should have gone to the list as well. r~ -- Forwarded message -- From: Richard Henderson Date: Fri, Jul 7, 2017 at 6:38 AM Subject: [PATCH v2.5] fixup! linux-user/sh4: Notice gUSA regions during signal delivery To: glaub...@physik.fu-berlin.de Cc:

[Qemu-devel] [PULL 092/100] block: release persistent bitmaps on inactivate

From: Vladimir Sementsov-Ogievskiy We should release them here to reload on invalidate cache. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20170628120530.31251-31-vsement...@virtuozzo.com

[Qemu-devel] [PULL 093/100] iotests: skip 159 & 170 with luks format

From: "Daniel P. Berrange" While the qemu-img dd command does accept --image-opts this is not sufficient to make it work with the LUKS image yet. This is because bdrv_create() still always requires the non-image-opts syntax. Thus we must skip 159/170 with luks for now

Re: [Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_insn

On 07/07/2017 07:18 AM, Lluís Vilanova wrote: There was no code being generated after this specific case, but I haven't checked if DISAS_EXC is set in any other place that is not immediately followed by a "goto done_generating". Typically we haven't actually done a goto, but simply exit the

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

On Fri, Jul 7, 2017 at 5:06 AM, Eduardo Habkost wrote: > On Thu, Jul 06, 2017 at 04:49:44PM -0700, Alistair Francis wrote: >> Convert all uses of error_report("[Ww]arning:"... to use warn_report() >> instead. This helps standardise on a single method of printing warnings >>

[Qemu-devel] [PULL 089/100] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

From: Vladimir Sementsov-Ogievskiy Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow Message-id:

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

Richard Henderson writes: > On 07/07/2017 01:18 AM, Lluís Vilanova wrote: diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9c870f6d07..586a01a2de 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -11244,6 +11244,9 @@

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

Emilio G Cota writes: > On Fri, Jul 07, 2017 at 05:46:19 -1000, Richard Henderson wrote: >> I do wonder if we should provide a generic empty hook, so that a target that >> does not need a particular hook need not define an empty function. It could >> just put e.g. "translator_noop" into the

Re: [Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_insn

On 7 July 2017 at 16:26, Richard Henderson wrote: > That is the purpose of DISAS_EXC too. We've called a noreturn helper to > raise an exception and all following code is unreached. If there *was* any > code being emitted afterward, that is arguably a bug. One exception to

[Qemu-devel] [PULL 082/100] qcow2: store bitmaps on reopening image as read-only

From: Vladimir Sementsov-Ogievskiy Store bitmaps and mark them read-only on reopening image as read-only. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id:

  1   2   3   4   5   >