[Qemu-devel] [PATCH v2 1/9] block: Make blk_get_attached_dev_id() public

2017-07-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/block-backend.c | 3 +-- include/sysemu/block-backend.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index

Re: [Qemu-devel] [PATCH v5 1/4] block: pass bdrv_* methods to bs->file by default in block filters

2017-07-13 Thread Manos Pitsidianakis
On Thu, Jul 13, 2017 at 06:23:14AM -0500, Eric Blake wrote: On 07/13/2017 05:01 AM, Manos Pitsidianakis wrote: The following functions fail if bs->drv is a filter and does not implement them: bdrv_probe_blocksizes bdrv_probe_geometry bdrv_truncate bdrv_has_zero_init bdrv_get_info Instead, the

Re: [Qemu-devel] [PATCH v5 0/9] Implement NBD_OPT_GO, block size advertisement

2017-07-13 Thread Paolo Bonzini
On 07/07/2017 22:30, Eric Blake wrote: > The NBD protocol has now finalized the extension that fixes > several shortcomings with NBD_OPT_EXPORT_NAME (namely, no error > reporting, no way for the server to advertise block sizes to the > client): >

Re: [Qemu-devel] [RFC PATCH RESEND 1/2] scripts: helper to keep console alive

2017-07-13 Thread Eric Blake
On 07/13/2017 05:03 AM, Philippe Mathieu-Daudé wrote: > useful to avoid Travis CI jobs getting killed after 10min of inactivity. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > scripts/aliveness.sh | 32 > 2

Re: [Qemu-devel] [PATCH V3] chardev: fix parallel device can't be reconnect

2017-07-13 Thread Paolo Bonzini
On 12/07/2017 17:41, Peng Hao wrote: > Parallel device don't register be->chr_can_read function, but remote > disconnect event is handled in chr_read.So connected parallel device > can not detect remote disconnect event. The chardevs with chr_can_read=NULL > has the same problem. > >

Re: [Qemu-devel] [PATCH] tcg: move atomic_template.h to accel/tcg/

2017-07-13 Thread Paolo Bonzini
On 12/07/2017 07:52, Thomas Huth wrote: > On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> same as Thomas previous patch. this file had no entry in MAINTAINERS. >> >> atomic_template.h => accel/tcg/atomic_template.h | 0 >> 1

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Laszlo Ersek
On 07/13/17 12:47, Peter Maydell wrote: > On 12 July 2017 at 00:43, Ben Warren wrote: >> Yes, it’s definitely a setup time problem. With the values that are checked >> in, I can’t get it to fail on my setup, but if I wind the numbers down I see >> the same failure as

Re: [Qemu-devel] [PATCH 5/9] block: List anonymous device BBs in query-block

2017-07-13 Thread Kevin Wolf
Am 12.07.2017 um 17:47 hat Eric Blake geschrieben: > On 07/12/2017 07:57 AM, Kevin Wolf wrote: > > Instead of listing only monitor-owned BlockBackends in query-block, also > > add those anonymous BlockBackends that are owned by a qdev device and as > > such under the control of the user. > > > >

Re: [Qemu-devel] [PATCH v5 1/4] block: pass bdrv_* methods to bs->file by default in block filters

2017-07-13 Thread Eric Blake
On 07/13/2017 05:01 AM, Manos Pitsidianakis wrote: > The following functions fail if bs->drv is a filter and does not > implement them: > > bdrv_probe_blocksizes > bdrv_probe_geometry > bdrv_truncate > bdrv_has_zero_init > bdrv_get_info > > Instead, the call should be passed to bs->file if it

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Markus Armbruster
Eric Blake writes: > On 07/13/2017 02:08 AM, Alistair Francis wrote: >> On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster wrote: >>> Alistair Francis writes: >>> QEMU currently has a standard method to report errors with

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Cédric Le Goater
On 07/13/2017 12:32 PM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 07/13/2017 11:10 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> On 07/13/2017 09:55 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes:

Re: [Qemu-devel] [PATCH v5 0/4] block: Block driver callbacks fixes

2017-07-13 Thread Eric Blake
On 07/13/2017 05:01 AM, Manos Pitsidianakis wrote: > This series makes implementing some of the bdrv_* callbacks easier for block > filters by passing requests to bs->file if bs->drv doesn't implement it > instead > of failing, and adding default bdrv_co_get_block_status() implementations. > >

Re: [Qemu-devel] [PATCH 00/18] nbd: BLOCK_STATUS

2017-07-13 Thread Eric Blake
On 02/15/2017 11:05 AM, Paolo Bonzini wrote: [now several months later...] > > > On 03/02/2017 16:47, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> We really need exporting dirty bitmaps feature as well as remote >> get_block_status for nbd devices. So, here is minimalistic and

Re: [Qemu-devel] [PATCH v5 15/18] qcow2: Switch load_bitmap_data() to byte-based iteration

2017-07-13 Thread Vladimir Sementsov-Ogievskiy
13.07.2017 14:03, Vladimir Sementsov-Ogievskiy wrote: 13.07.2017 04:05, Eric Blake wrote: Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by:

Re: [Qemu-devel] [PATCH v5 16/18] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-07-13 Thread Vladimir Sementsov-Ogievskiy
13.07.2017 04:05, Eric Blake wrote: Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v1 1/1] io/channel-watch.c: Only select on what we are actually waiting for

2017-07-13 Thread Paolo Bonzini
On 13/07/2017 12:23, Daniel P. Berrange wrote: > On Thu, Jul 13, 2017 at 03:15:49AM -0700, Alistair Francis wrote: >> diff --git a/io/channel-watch.c b/io/channel-watch.c >> index 8640d1c464..d80722f496 100644 >> --- a/io/channel-watch.c >> +++ b/io/channel-watch.c >> @@ -286,9 +286,21 @@ GSource

Re: [Qemu-devel] [PATCH v5 15/18] qcow2: Switch load_bitmap_data() to byte-based iteration

2017-07-13 Thread Vladimir Sementsov-Ogievskiy
13.07.2017 04:05, Eric Blake wrote: Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow

[Qemu-devel] [PATCH v2 8/8] virtio-crypto: use virtqueue_error for errors with queue context

2017-07-13 Thread Ladi Prosek
virtqueue_error includes queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek --- hw/virtio/virtio-crypto.c | 56 --- 1 file

[Qemu-devel] [PATCH v2 4/8] virtio-9p: use virtqueue_error for errors with queue context

2017-07-13 Thread Ladi Prosek
virtqueue_error includes queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek --- hw/9pfs/virtio-9p-device.c | 37 +++-- 1 file changed, 15

[Qemu-devel] [PATCH v2 5/8] virtio-blk: use virtqueue_error for errors with queue context

2017-07-13 Thread Ladi Prosek
virtqueue_error includes queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek --- hw/block/virtio-blk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v2 6/8] virtio-net: use virtqueue_error for errors with queue context

2017-07-13 Thread Ladi Prosek
virtqueue_error includes queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek --- hw/net/virtio-net.c | 24 1 file changed, 12 insertions(+), 12

[Qemu-devel] [PATCH v2 7/8] virtio-scsi: use virtqueue_error for errors with queue context

2017-07-13 Thread Ladi Prosek
virtqueue_error includes queue index in the error output and is preferred for errors that pertain to a virtqueue rather than to the device as a whole. Signed-off-by: Ladi Prosek --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 0/8] virtio: enhance virtio_error messages

2017-07-13 Thread Ladi Prosek
Output like "Virtqueue size exceeded" is not much useful in identifying the culprit. This series beefs up virtio_error to print the virtio device name and id, and introduces virtqueue_error which additionally includes the index of the virtqueue where the error occured. Patches 1 to 3 lay the

[Qemu-devel] [PATCH v2 3/8] virtio: introduce virtqueue_error

2017-07-13 Thread Ladi Prosek
Most virtio error output pertains to a specific virtqueue so it makes sense to include the queue index in error messages. This commit makes all error output in virtio.c use the newly introduced virtqueue_error. Suggested-by: Stefan Hajnoczi Signed-off-by: Ladi Prosek

[Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-13 Thread Ladi Prosek
Callers of error_report may want to compose the error message out of multiple separate format strings. To save them from always having to combine their strings into one (a process that would likely involve memory allocation which is good to avoid on error paths), new "nolf" variants of

[Qemu-devel] [PATCH v2 2/8] virtio: enhance virtio_error messages

2017-07-13 Thread Ladi Prosek
Output like "Virtqueue size exceeded" is not much useful in identifying the culprit. This commit adds virtio device name (e.g. "virtio-input") and id if set (e.g. "mouse0") to all virtio error messages to improve debuggability. Some virtio devices (virtio-scsi, virtio-serial) insert a bus between

Re: [Qemu-devel] [PATCH v4 14/17] qcow2: Switch load_bitmap_data() to byte-based iteration

2017-07-13 Thread Eric Blake
On 07/13/2017 04:16 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.07.2017 18:10, Eric Blake wrote: >> Now that we have adjusted the majority of the calls this function >> makes to be byte-based, it is easier to read the code if it makes >> passes over the image using bytes rather than sectors. >>

Re: [Qemu-devel] [PATCH/s390-next 0/3] s390x: remaining pci related fixes

2017-07-13 Thread Christian Borntraeger
On 07/13/2017 12:40 PM, Christian Borntraeger wrote: > here are the remaining PCI patches also enabling AIS via KVM. > CPU model wise we do not put AIS in a default model for zEC12 and z13 > since almost all distribution kernels do not have ais yet. This would > break -cpu zEC12 and -cpu z13 if

Re: [Qemu-devel] [PATCH v2 08/27] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-13 Thread John Paul Adrian Glaubitz
On Thu, Jul 13, 2017 at 11:09:08AM +0200, John Paul Adrian Glaubitz wrote: > Just as a heads-up: The current set of patches as they are present in > the tgt-sh4 branch on git://github.com/rth7680/qemu.git are a HUGE > improvement for qemu-sh4 user mode. Several packages which previously > crashed

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Peter Maydell
On 12 July 2017 at 00:43, Ben Warren wrote: > Yes, it’s definitely a setup time problem. With the values that are checked > in, I can’t get it to fail on my setup, but if I wind the numbers down I see > the same failure as Peter. So now we have the ages-old problem of

[Qemu-devel] [PATCH/s390-next 0/3] s390x: remaining pci related fixes

2017-07-13 Thread Christian Borntraeger
here are the remaining PCI patches also enabling AIS via KVM. CPU model wise we do not put AIS in a default model for zEC12 and z13 since almost all distribution kernels do not have ais yet. This would break -cpu zEC12 and -cpu z13 if QEMU is updated. patches are against previous series. Yi Min

[Qemu-devel] [PATCH/s390-next 3/3] s390x/flic: migrate ais states

2017-07-13 Thread Christian Borntraeger
From: Yi Min Zhao During migration we should transfer ais states to the target guest. This patch introduces a subsection to kvm_s390_flic_vmstate and new vmsd for qemu_flic. The ais states need to be migrated only when ais is supported. Signed-off-by: Yi Min Zhao

[Qemu-devel] [PATCH/s390-next 1/3] s390x: initialize cpu firstly

2017-07-13 Thread Christian Borntraeger
From: Yi Min Zhao By initializing the CPU firstly, we are able to retrieve and use the CPU model features when initializing other subsystem or devices. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel

[Qemu-devel] [PATCH/s390-next 2/3] s390x/cpumodel: add zpci, aen and ais facilities

2017-07-13 Thread Christian Borntraeger
From: Yi Min Zhao zPCI instructions and facilities are available since IBM zEnterprise EC12. To support z/PCI in QEMU we enable zpci, aen and ais facilities starting with zEC12 GA1. And we always set zpci and aen bits in max cpu model. Later they might be switched off

Re: [Qemu-devel] [PATCH 1/7] hw/arm/mps2: Implement skeleton mps2-an385 and mps2-an511 board models

2017-07-13 Thread Peter Maydell
On 13 July 2017 at 08:27, Alistair Francis wrote: > On Tue, Jul 11, 2017 at 6:35 PM, Peter Maydell > wrote: >> On 11 July 2017 at 15:33, Alistair Francis wrote: >>> On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell

Re: [Qemu-devel] [PATCH] virtion-net: Prefer is_power_of_2()

2017-07-13 Thread Eric Blake
On 07/13/2017 02:44 AM, Michal Privoznik wrote: In the subject: s/virtion/virtio/ > We have a function that checks if given number is power of two. > We should prefer it instead of expanding the check on our own. > > Signed-off-by: Michal Privoznik > --- >

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-13 Thread Laszlo Ersek
On 07/12/17 04:08, Dongjiu Geng wrote: > (1) Add related APEI/HEST table structures and macros, these > definition refer to ACPI 6.1 and UEFI 2.6 spec. > (2) Add generic error status block and CPER memory section > definition, user space only handle memory section errors. > >

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Eric Blake
On 07/13/2017 02:08 AM, Alistair Francis wrote: > On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> QEMU currently has a standard method to report errors with >>> error_repot(). This ensure a sane and

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Nikunj A Dadhania
Cédric Le Goater writes: > On 07/13/2017 11:10 AM, Nikunj A Dadhania wrote: >> Cédric Le Goater writes: >> >>> On 07/13/2017 09:55 AM, Nikunj A Dadhania wrote: Cédric Le Goater writes: >>> How about the following, we do not report

Re: [Qemu-devel] [PATCH v1 1/1] io/channel-watch.c: Only select on what we are actually waiting for

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 03:15:49AM -0700, Alistair Francis wrote: > When calling WAEventSelect() only wait on events as specified by the > condition variable. This requires that the condition variable is set > correctly for the specific events that we need to wait for. Can you describe the actual

Re: [Qemu-devel] [PATCH 1/2] audio/fmopl: modify timer callback to give opaque and channel parameters in two arguments

2017-07-13 Thread Philippe Mathieu-Daudé
Hi Hervé, On 06/21/2017 01:34 AM, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau --- hw/audio/adlib.c | 2 +- hw/audio/fmopl.c | 18 +- hw/audio/fmopl.h | 7 --- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

2017-07-13 Thread Philippe Mathieu-Daudé
On 06/21/2017 01:33 AM, Hervé Poussineau wrote: Hi, This patchset removes a global variable in adlib emulation, and allows to have multiple adlib sound cards. Note that indentation seem off because I have replaced some tabulations by spaces. Before: qemu-system-i386 -device adlib,iobase=0x220

[Qemu-devel] [PATCH v1 1/1] io/channel-watch.c: Only select on what we are actually waiting for

2017-07-13 Thread Alistair Francis
When calling WAEventSelect() only wait on events as specified by the condition variable. This requires that the condition variable is set correctly for the specific events that we need to wait for. Signed-off-by: Alistair Francis --- io/channel-watch.c | 18

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Cédric Le Goater
On 07/13/2017 11:10 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 07/13/2017 09:55 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> >> How about the following, we do not report work until MSR_EE is disabled: > > With this

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

2017-07-13 Thread Daniel Henrique Barboza
On 07/12/2017 09:57 PM, David Gibson wrote: On Wed, Jul 12, 2017 at 10:48:38AM -0300, Daniel Henrique Barboza wrote: The dreaded Libvirt hotplug-migrate-hotunplug scenario is working nicely. Good to hear. device_add when the machine is in RUN_STATE_PRELAUNCH (-S) still doesn't work but it

[Qemu-devel] [RFC PATCH RESEND 1/2] scripts: helper to keep console alive

2017-07-13 Thread Philippe Mathieu-Daudé
useful to avoid Travis CI jobs getting killed after 10min of inactivity. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + scripts/aliveness.sh | 32 2 files changed, 33 insertions(+) create mode 100755 scripts/aliveness.sh

[Qemu-devel] [RFC PATCH RESEND 2/2] travis: use console aliveness script

2017-07-13 Thread Philippe Mathieu-Daudé
Travis CI has specific time limits for each job, and will stop the build and add an error message to the build log in the following situation[s]: - A job produces no log output for 10 minutes See: https://docs.travis-ci.com/user/customizing-the-build#build-timeouts Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH v4 13/18] crypto: cipher: add afalg-backend cipher support

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 05:55:00PM +0800, long mike wrote: > 2017-07-11 20:29 GMT+08:00 Daniel P. Berrange : > > On Tue, Jul 04, 2017 at 04:57:05PM +0800, Longpeng(Mike) wrote: > >> Adds afalg-backend cipher support: introduces some private APIs > >> firstly, and then

[Qemu-devel] [RFC PATCH RESEND 0/2] avoid Travis CI "no log output for 10 minutes" failure

2017-07-13 Thread Philippe Mathieu-Daudé
Hi, still trying to reduce Travis false negatives... Suggested yesterday on IRC: pm215: this one seems to be that we hit the "10 minutes with no output" limit stefanha: f4bug: We could literally have a SIGALRM that wakes up to print out a '.' :-) Let's try with an easy shell script. This

[Qemu-devel] [PATCH v5 3/4] block: remove bdrv_truncate callback in blkdebug

2017-07-13 Thread Manos Pitsidianakis
Now that bdrv_truncate is passed to bs->file by default, remove the callback from block/blkdebug.c and set is_filter to true. Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis ---

[Qemu-devel] [PATCH v5 2/4] block: remove unused bdrv_media_changed

2017-07-13 Thread Manos Pitsidianakis
This function is not used anywhere, so remove it. Markus Armbruster adds: The i82078 floppy device model used to call bdrv_media_changed() to implement its media change bit when backed by a host floppy. This went away in 21fcf36 "fdc: simplify media change handling". Probably broke host floppy

[Qemu-devel] [PATCH v5 1/4] block: pass bdrv_* methods to bs->file by default in block filters

2017-07-13 Thread Manos Pitsidianakis
The following functions fail if bs->drv is a filter and does not implement them: bdrv_probe_blocksizes bdrv_probe_geometry bdrv_truncate bdrv_has_zero_init bdrv_get_info Instead, the call should be passed to bs->file if it exists, to allow filter drivers to support those methods without

[Qemu-devel] [PATCH v5 4/4] block: add default implementations for bdrv_co_get_block_status()

2017-07-13 Thread Manos Pitsidianakis
bdrv_co_get_block_status_from_file() and bdrv_co_get_block_status_from_backing() set *file to bs->file and bs->backing respectively, so that bdrv_co_get_block_status() can recurse to them. Future block drivers won't have to duplicate code to implement this. Reviewed-by: Fam Zheng

[Qemu-devel] [PATCH v5 0/4] block: Block driver callbacks fixes

2017-07-13 Thread Manos Pitsidianakis
This series makes implementing some of the bdrv_* callbacks easier for block filters by passing requests to bs->file if bs->drv doesn't implement it instead of failing, and adding default bdrv_co_get_block_status() implementations. This is based against Kevin Wolf's block branch, commit

Re: [Qemu-devel] [PATCH v4 13/18] crypto: cipher: add afalg-backend cipher support

2017-07-13 Thread long mike
2017-07-11 20:29 GMT+08:00 Daniel P. Berrange : > On Tue, Jul 04, 2017 at 04:57:05PM +0800, Longpeng(Mike) wrote: >> Adds afalg-backend cipher support: introduces some private APIs >> firstly, and then intergrates them into qcrypto_cipher_afalg_driver. >> >> Signed-off-by:

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-07-13 Thread Peter Maydell
On 11 July 2017 at 09:35, Stefan Hajnoczi wrote: > The following changes since commit 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-07-10-v2' > into staging (2017-07-10 16:12:47 +0100) > > are available in the

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Cédric Le Goater writes: > >> On 07/13/2017 09:55 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> >> How about the following, we do not report work until MSR_EE is disabled: > > With

Re: [Qemu-devel] [PATCH] Don't enable networking as a side-effect of DEBUG=1

2017-07-13 Thread Daniel P. Berrange
On Wed, Jul 12, 2017 at 06:55:45PM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 07/12/2017 01:25 PM, Daniel P. Berrange wrote: > > When trying to debug problems with tests it is natural to set > > DEBUG=1 when starting the docker environment. Unfortunately > > this has a side-effect

Re: [Qemu-devel] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 10:44:53AM +0200, Peter Lieven wrote: > Am 10.07.2017 um 15:55 schrieb Daniel P. Berrange: > > On Mon, Jul 10, 2017 at 03:52:18PM +0200, Kevin Wolf wrote: > > > Am 10.07.2017 um 15:44 hat Daniel P. Berrange geschrieben: > > > > On Mon, Jul 10, 2017 at 03:34:59PM +0200,

Re: [Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 10:52:41AM +0200, Kevin Wolf wrote: > Am 13.07.2017 um 10:45 hat Peter Lieven geschrieben: > > Am 10.07.2017 um 15:30 schrieb Kevin Wolf: > > >Am 10.07.2017 um 15:24 hat Peter Lieven geschrieben: > > >>Am 10.07.2017 um 15:10 schrieb Kevin Wolf: > > >>>Am 29.06.2017 um 12:57

Re: [Qemu-devel] [PATCH v4 14/17] qcow2: Switch load_bitmap_data() to byte-based iteration

2017-07-13 Thread Vladimir Sementsov-Ogievskiy
03.07.2017 18:10, Eric Blake wrote: Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake --- v4: new patch ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Nikunj A Dadhania
Cédric Le Goater writes: > On 07/13/2017 09:55 AM, Nikunj A Dadhania wrote: >> Cédric Le Goater writes: >> > How about the following, we do not report work until MSR_EE is disabled: With this fix, I could test the XIVE<->XICS transitions at reboot

Re: [Qemu-devel] [PATCH v2 08/27] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-13 Thread John Paul Adrian Glaubitz
Just as a heads-up: The current set of patches as they are present in the tgt-sh4 branch on git://github.com/rth7680/qemu.git are a HUGE improvement for qemu-sh4 user mode. Several packages which previously crashed during build or use can now be used properly! So, I hope to see this series merged

Re: [Qemu-devel] [RFC 1/3] qemu-ga: add support for events

2017-07-13 Thread Tomáš Golembiovský
On Fri, 7 Jul 2017 15:53:37 -0500 Eric Blake wrote: > On 06/23/2017 08:02 AM, Tomáš Golembiovský wrote: > > Events can play an integral role when monitoring internal state of the > > guest OS. This patch adds the core functionality for adding events to > > QEMU Guest Agent.

Re: [Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-07-13 Thread Kevin Wolf
Am 13.07.2017 um 10:45 hat Peter Lieven geschrieben: > Am 10.07.2017 um 15:30 schrieb Kevin Wolf: > >Am 10.07.2017 um 15:24 hat Peter Lieven geschrieben: > >>Am 10.07.2017 um 15:10 schrieb Kevin Wolf: > >>>Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: > Signed-off-by: Peter Lieven

Re: [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events

2017-07-13 Thread Tomáš Golembiovský
On Fri, 7 Jul 2017 15:55:31 -0500 Eric Blake wrote: > On 06/23/2017 08:02 AM, Tomáš Golembiovský wrote: > > This is just a draft, or a request for comments if you will. > > > > This patch sets drafts the support of sending events by QEMU Guest Agent. > > Events can plan

Re: [Qemu-devel] [PATCH v3 4/4] intel_iommu: implement mru list for iotlb

2017-07-13 Thread Jason Wang
On 2017年07月12日 16:13, Peter Xu wrote: It is not wise to disgard all the IOTLB cache when cache size reaches max, but that's what we do now. A slightly better (but still simple) way to do this is, we just throw away the least recent used cache entry. This patch implemented MRU list algorithm

Re: [Qemu-devel] [PATCH] Don't enable networking as a side-effect of DEBUG=1

2017-07-13 Thread Alex Bennée
Fam Zheng writes: > On Wed, 07/12 17:25, Daniel P. Berrange wrote: >> When trying to debug problems with tests it is natural to set >> DEBUG=1 when starting the docker environment. Unfortunately >> this has a side-effect of enabling an eth0 network interface >> in the

Re: [Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-07-13 Thread Peter Lieven
Am 10.07.2017 um 15:30 schrieb Kevin Wolf: Am 10.07.2017 um 15:24 hat Peter Lieven geschrieben: Am 10.07.2017 um 15:10 schrieb Kevin Wolf: Am 29.06.2017 um 12:57 hat Peter Lieven geschrieben: Signed-off-by: Peter Lieven --- qapi/block-core.json | 44

Re: [Qemu-devel] [PATCH 11/11] s390x/css: update css_adapter_interrupt

2017-07-13 Thread Cornelia Huck
On Wed, 12 Jul 2017 14:57:45 +0200 Christian Borntraeger wrote: > From: Yi Min Zhao > > Let's use the new inject_airq callback of flic to inject adapter > interrupts. For kvm case, if the kernel flic doesn't support the new > interface, the

Re: [Qemu-devel] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-07-13 Thread Peter Lieven
Am 10.07.2017 um 15:55 schrieb Daniel P. Berrange: On Mon, Jul 10, 2017 at 03:52:18PM +0200, Kevin Wolf wrote: Am 10.07.2017 um 15:44 hat Daniel P. Berrange geschrieben: On Mon, Jul 10, 2017 at 03:34:59PM +0200, Kevin Wolf wrote: Am 10.07.2017 um 15:29 hat Peter Lieven geschrieben: Am

Re: [Qemu-devel] [PATCH v12 8/8] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

2017-07-13 Thread Wei Wang
On 07/13/2017 08:22 AM, Michael S. Tsirkin wrote: On Wed, Jul 12, 2017 at 08:40:21PM +0800, Wei Wang wrote: Add a new vq, cmdq, to handle requests between the device and driver. This patch implements two commands sent from the device and handled in the driver. 1)

Re: [Qemu-devel] [PATCH v3 1/4] intel_iommu: fix VTD_PAGE_MASK

2017-07-13 Thread Jason Wang
On 2017年07月12日 16:13, Peter Xu wrote: IOMMUTLBEntry.iova is returned incorrectly in one PT path (though mostly we cannot really trigger this path, even if we do, we are mostly disgarding this value, so it didn't break anything). Fix it by converting the VTD_PAGE_MASK into normal definition

Re: [Qemu-devel] [PATCH v5 3/4] qcow2: add shrink image support

2017-07-13 Thread Kevin Wolf
Am 12.07.2017 um 18:58 hat Max Reitz geschrieben: > On 2017-07-12 16:52, Kevin Wolf wrote: > > Am 12.07.2017 um 13:46 hat Pavel Butsykin geschrieben: > >> This patch add shrinking of the image file for qcow2. As a result, this > >> allows > >> us to reduce the virtual image size and free up space

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v12 7/8] mm: export symbol of next_zone and first_online_pgdat

2017-07-13 Thread Wei Wang
On 07/13/2017 08:16 AM, Michael S. Tsirkin wrote: On Wed, Jul 12, 2017 at 08:40:20PM +0800, Wei Wang wrote: This patch enables for_each_zone()/for_each_populated_zone() to be invoked by a kernel module. ... for use by virtio balloon. With this patch, other kernel modules can also use the

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-13 Thread Wei Wang
On 07/13/2017 08:33 AM, Michael S. Tsirkin wrote: On Wed, Jul 12, 2017 at 08:40:19PM +0800, Wei Wang wrote: This patch adds support for reporting blocks of pages on the free list specified by the caller. As pages can leave the free list during this call or immediately afterwards, they are not

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Cédric Le Goater
On 07/13/2017 09:55 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > How about the following, we do not report work until MSR_EE is disabled: >>> >>> With this fix, I could test the XIVE<->XICS transitions at reboot >>> under TCG. However, the second boot is very

Re: [Qemu-devel] [PATCH 11/11] s390x/css: update css_adapter_interrupt

2017-07-13 Thread Thomas Huth
On 13.07.2017 10:08, Christian Borntraeger wrote: > On 07/12/2017 04:26 PM, Thomas Huth wrote: >> On 12.07.2017 14:57, Christian Borntraeger wrote: >>> From: Yi Min Zhao >>> >>> Let's use the new inject_airq callback of flic to inject adapter >>> interrupts. For kvm

Re: [Qemu-devel] 答复: Re: [PATCH] target-i386:kvm_get/put_vcpu_events don't handlesipi_vector

2017-07-13 Thread Paolo Bonzini
On 13/07/2017 04:53, peng.h...@zte.com.cn wrote: > > I think what you're seeing is a race like this: > > > > VCPU 0 VCPU 1 > > [qemu] kvm_get_mp_state > > [kvm] kvm_apic_accept_events > > __apic_accept_irq > >

Re: [Qemu-devel] [PATCH 11/11] s390x/css: update css_adapter_interrupt

2017-07-13 Thread Christian Borntraeger
On 07/12/2017 04:26 PM, Thomas Huth wrote: > On 12.07.2017 14:57, Christian Borntraeger wrote: >> From: Yi Min Zhao >> >> Let's use the new inject_airq callback of flic to inject adapter >> interrupts. For kvm case, if the kernel flic doesn't support the new >>

Re: [Qemu-devel] About the trace framework

2017-07-13 Thread Wang Dong
On 07/10/2017 08:40 PM, Stefan Hajnoczi wrote: On Mon, Jul 10, 2017 at 01:24:23PM +0800, Xie Changlong wrote: 在 7/9/2017 5:57 PM, Wang Dong 写道: Hi, I am new to QEMU. But I got some problem so that I want to figure it out. So I try to debug qemu to see what happened. And I found trace

Re: [Qemu-devel] [PULL 01/21] virtio-net: enable configurable tx queue size

2017-07-13 Thread Michal Privoznik
On 07/04/2017 03:44 AM, Wei Wang wrote: > On 07/04/2017 03:44 AM, Michael S. Tsirkin wrote: >> From: Wei Wang >> >> This patch enables the virtio-net tx queue size to be configurable >> between 256 (the default queue size) and 1024 by the user when the >> vhost-user backend

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Nikunj A Dadhania
Cédric Le Goater writes: >>> How about the following, we do not report work until MSR_EE is disabled: >> >> With this fix, I could test the XIVE<->XICS transitions at reboot >> under TCG. However, the second boot is very slow for some reason. > > hmm, I am not sure this is

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Nikunj A Dadhania
Cédric Le Goater writes: > On 07/13/2017 06:38 AM, Nikunj A Dadhania wrote: >> David Gibson writes: >> >>> >>> Ok, but we definitely should be able to fix this without new >>> variables. If we can quiesce the secondary CPUs for the first boot, >>>

Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback

2017-07-13 Thread Cornelia Huck
On Thu, 13 Jul 2017 09:35:16 +0200 Christian Borntraeger wrote: > On 07/13/2017 09:27 AM, Cornelia Huck wrote: > > On Thu, 13 Jul 2017 09:12:50 +0200 > > Christian Borntraeger wrote: > > > >> On 07/12/2017 05:07 PM, Cornelia Huck wrote: >

Re: [Qemu-devel] [PATCH 03/11] s390x/migration: Storage attributes device

2017-07-13 Thread Christian Borntraeger
On 07/13/2017 09:35 AM, Thomas Huth wrote: > On 13.07.2017 09:11, Christian Borntraeger wrote: >> Thanks for the review, all valid. Claudio has provided me the following >> fixup. >> >> I plan to fold that in the base patch (retest pending). >> >> Christian >> >> >> --- >>

[Qemu-devel] [PATCH] virtion-net: Prefer is_power_of_2()

2017-07-13 Thread Michal Privoznik
We have a function that checks if given number is power of two. We should prefer it instead of expanding the check on our own. Signed-off-by: Michal Privoznik --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-13 Thread Wei Wang
On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: So the way I see it, there are several issues: - internal wait - forces multiple APIs like kick/kick_sync note how kick_sync can fail but your code never checks return code - need to re-write the last descriptor - might not work for

Re: [Qemu-devel] [PATCH 3/7] hw/arm/mps2: Add UARTs

2017-07-13 Thread Alistair Francis
On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell wrote: > Add the UARTs to the MPS2 board models. > > Unfortunately the details of the wiring of the interrupts through > various OR gates differ between AN511 and AN385 so this can't > be purely a data-driven difference. > >

Re: [Qemu-devel] [PATCH 03/11] s390x/migration: Storage attributes device

2017-07-13 Thread Thomas Huth
On 13.07.2017 09:11, Christian Borntraeger wrote: > Thanks for the review, all valid. Claudio has provided me the following fixup. > > I plan to fold that in the base patch (retest pending). > > Christian > > > --- > hw/s390x/s390-stattrib-kvm.c | 26 +++--- >

Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback

2017-07-13 Thread Christian Borntraeger
On 07/13/2017 09:27 AM, Cornelia Huck wrote: > On Thu, 13 Jul 2017 09:12:50 +0200 > Christian Borntraeger wrote: > >> On 07/12/2017 05:07 PM, Cornelia Huck wrote: + +switch (mode) { +case SIC_IRQ_MODE_ALL: +flic->simm &=

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-13 Thread Alistair Francis
On Tue, Jul 11, 2017 at 6:45 PM, Peter Maydell wrote: > On 11 July 2017 at 16:40, Alistair Francis wrote: >> On Tue, Jul 11, 2017 at 5:33 PM, Peter Maydell >> wrote: >>> On 11 July 2017 at 16:12, Alistair Francis

Re: [Qemu-devel] [PATCH 03/11] s390x/migration: Storage attributes device

2017-07-13 Thread Cornelia Huck
On Thu, 13 Jul 2017 09:11:34 +0200 Christian Borntraeger wrote: > Thanks for the review, all valid. Claudio has provided me the following fixup. > > I plan to fold that in the base patch (retest pending). Looks good to me, and I have no further comments beyond those by

Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback

2017-07-13 Thread Cornelia Huck
On Thu, 13 Jul 2017 09:12:50 +0200 Christian Borntraeger wrote: > On 07/12/2017 05:07 PM, Cornelia Huck wrote: > >> + > >> +switch (mode) { > >> +case SIC_IRQ_MODE_ALL: > >> +flic->simm &= ~AIS_MODE_MASK(isc); > >> +flic->nimm &=

Re: [Qemu-devel] [PATCH 1/7] hw/arm/mps2: Implement skeleton mps2-an385 and mps2-an511 board models

2017-07-13 Thread Alistair Francis
On Tue, Jul 11, 2017 at 6:35 PM, Peter Maydell wrote: > On 11 July 2017 at 15:33, Alistair Francis wrote: >> On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell >> wrote: >>> Model the ARM MPS2/MPS2+ FPGA based development

Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback

2017-07-13 Thread Christian Borntraeger
On 07/12/2017 05:07 PM, Cornelia Huck wrote: >> + >> +switch (mode) { >> +case SIC_IRQ_MODE_ALL: >> +flic->simm &= ~AIS_MODE_MASK(isc); >> +flic->nimm &= ~AIS_MODE_MASK(isc); >> +break; >> +case SIC_IRQ_MODE_SINGLE: >> +flic->simm |= AIS_MODE_MASK(isc);

Re: [Qemu-devel] [PATCH 03/11] s390x/migration: Storage attributes device

2017-07-13 Thread Christian Borntraeger
Thanks for the review, all valid. Claudio has provided me the following fixup. I plan to fold that in the base patch (retest pending). Christian --- hw/s390x/s390-stattrib-kvm.c | 26 +++--- hw/s390x/s390-stattrib.c | 12 +++-

Re: [Qemu-devel] [PATCH v3 4/8] hw/i386: Improve some of the warning messages

2017-07-13 Thread Alistair Francis
On Thu, Jul 13, 2017 at 8:24 AM, Markus Armbruster wrote: > Eduardo Habkost writes: > >> On Wed, Jul 12, 2017 at 11:39:59AM +0200, Markus Armbruster wrote: >>> Alistair Francis writes: >>> >>> > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function

2017-07-13 Thread Alistair Francis
On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster wrote: > Alistair Francis writes: > >> QEMU currently has a standard method to report errors with >> error_repot(). This ensure a sane and standard format when printing >> errors. This series is

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] spapr: ignore interrupts during reset state

2017-07-13 Thread Cédric Le Goater
On 07/13/2017 08:43 AM, Cédric Le Goater wrote: > On 07/13/2017 06:38 AM, Nikunj A Dadhania wrote: >> David Gibson writes: >> >>> On Fri, Jun 09, 2017 at 10:32:25AM +0530, Nikunj A Dadhania wrote: David Gibson writes: > On

<    1   2   3   4   5   6   >