This just allow spapr_dr_connector_new() to propagate errors to its
callers. It doesn't change any functionality.
Signed-off-by: Greg Kurz
---
hw/ppc/spapr.c |4 ++--
hw/ppc/spapr_drc.c |4 ++--
hw/ppc/spapr_pci.c |2 +-
include/hw/ppc/spapr_drc.h |2 +
object_property_add_child() can only fail in two cases:
- the child already has a parent, which shouldn't happen since the DRC was
allocated a few lines above
- the parent already has a child with the same name, which would mean the
caller tries to create a DRC that already exists
In both case
While working on PHB hotplug for 2.11, a bug was discovered in the PCI DR
logic in the PHB code: it relies on the PHB index property to be set but
it doesn't enforce it. It is hence possible to create two PHBs with the
same index (ie, the default value -1), even though this isn't expected
by the re
The 'check_updated_properties' function keeps track of properties
that were added/removed from fields across qemu versions. The
'check_updated_sizes' function reduces false positives generated
especially while testing backward migration by keeping a list
of common size/version changes. The 'check_n
This is an update to the script vmstate-static-checker.py. The whitelist has
been updated and newer functions have been added to reduce the false
positives generated by the script while testing migration. The code has been
cleaned and updated to follow PEP8 guidelines.
dverma (3):
Fix format an
Appended newer fields and introduced new names in the whitelist
---
scripts/vmstate-static-checker.py | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/scripts/vmstate-static-checker.py
b/scripts/vmstate-static-checker.py
index b416b66..ae41e44 100755
---
- Format fixes, cleaned up the print statement
- Style fixes, e.g. changed "if not x in y" to "if x not in y"
- Improved variable names
---
scripts/vmstate-static-checker.py | 111 +-
1 file changed, 62 insertions(+), 49 deletions(-)
diff --git a/scripts/vmstat
On 07/08/2017 19:42, Alexander Bezzubikov wrote:
2017-08-07 19:39 GMT+03:00 Marcel Apfelbaum :
On 05/08/2017 23:27, Aleksandr Bezzubikov wrote:
Introduce a new PCIExpress-to-PCI Bridge device,
which is a hot-pluggable PCI Express device and
supports devices hot-plug with SHPC.
Hi Aleksandr
This compat property sole function is to prevent the device from being
instantiated. Instead of requiring an extra compat property, check if
fw_cfg has DMA enabled.
fw_cfg is a built-in device that is initialized very early by the
machine init code. We have at least one other device that also
ass
On 08/07/17 16:40, Peter Maydell wrote:
> On 7 August 2017 at 15:31, Igor Mammedov wrote:
>> As I recall there were issues with FAT driver licensing in edk2,
>> but I've heard there were some changes in that regard.
>>
>> Is there any other reasons why we are not putting subj.
>> in QEMU tree like
Markus Armbruster wrote:
> Sizes should use QAPI type 'size' (uint64_t). MigrationStats members
> @transferred, @remaining, @total, @normal-bytes, @page-size are 'int'
> (int64_t). populate_ram_info(), populate_disk_info() and and many
> places that update them in global variable @ram_counters i
Markus Armbruster wrote:
> Byte rates should use QAPI type 'size' (uint64_t).
> migrate_set_speed's parameter @value and member @max-bandwidth of
> MigrationParameters and MigrateSetParameters are 'int' (int64_t).
>
> Change them all to 'size'.
>
> migrate_set_speed and migrate-set-parameters now
(please ignore my last email, looks like mutt wants play games lately)
Hi all,
I have found a problem on colo-compare that leads to segmentation fault
when calling qemu like this:
$ qemu-system-x86_64 -S -machine pc -object colo-compare,id=test-object
First I got an assert failed:
(qemu-sys
On 05/08/2017 23:27, Aleksandr Bezzubikov wrote:
To enable hotplugging of a newly created pcie-pci-bridge,
we need to tell firmware (SeaBIOS in this case) to reserve
additional buses or IO/MEM/PREF space for pcie-root-port.
Additional bus reservation allows us to hotplug pcie-pci-bridge into this
Markus Armbruster wrote:
> Sizes should use QAPI type 'size' (uint64_t). XBZRLECacheStats member
> @bytes is 'int' (int64_t). save_xbzrle_page() computes the byte count
> increment in size_t, implicitly converts it to int, then adds that to
> @bytes.
>
> Change the XBZRLECacheStats member to 'si
On 05/08/2017 23:27, Aleksandr Bezzubikov wrote:
On PCI init PCI bridges may need some extra info about bus number,
IO, memory and prefetchable memory to reserve. QEMU can provide this
with a special vendor-specific PCI capability.
Hi Aleksandr,
Signed-off-by: Aleksandr Bezzubikov
---
hw/
2017-08-07 19:39 GMT+03:00 Marcel Apfelbaum :
> On 05/08/2017 23:27, Aleksandr Bezzubikov wrote:
>>
>> Introduce a new PCIExpress-to-PCI Bridge device,
>> which is a hot-pluggable PCI Express device and
>> supports devices hot-plug with SHPC.
>>
>
>
> Hi Aleksandr,
>
>> This device is intended to r
Ok, could you maybe try something like this instead:
qemu-system-x86_64 ... -usb \
-device qemu-xhci,id=xhci \
-device usb-tablet,bus=usb-bus.0 \
-device usb-kbd,bus=usb-bus.0 \
-device usb-host,bus=xhci.0,vendorid=0x05ac,productid=0x12a8
i.e. use "bus=xhci.0" for the usb-host de
On 05/08/2017 23:27, Aleksandr Bezzubikov wrote:
Introduce a new PCIExpress-to-PCI Bridge device,
which is a hot-pluggable PCI Express device and
supports devices hot-plug with SHPC.
Hi Aleksandr,
This device is intended to replace the DMI-to-PCI
Bridge in an overwhelming majority of use-ca
zhangchen.f...@cn.fujitsu.com, wang.guan...@zte.com.cn,
wang.yong...@zte.com.cn
Bcc:
Subject: colo-compare: segfault and assert on colo_compare_finalize
Reply-To:
Hi all,
I have found a problem on colo-compare that leads to segmentation fault
when calling qemu like this:
$ qemu-system-x86_64
On 07/08/2017 19:02, Alexander Bezzubikov wrote:
2017-08-07 18:52 GMT+03:00 Marcel Apfelbaum :
On 05/08/2017 23:29, Aleksandr Bezzubikov wrote:
On PCI init PCI bridge devices may need some
extra info about bus number to reserve, IO, memory and
prefetchable memory limits. QEMU can provide this
On 05/08/2017 23:29, Aleksandr Bezzubikov wrote:
In case of Red Hat Generic PCIE Root Port reserve additional buses,
which number is provided in a vendor-specific capability.
Hi Aleksandr,
It seems the subject/commit description does not cover
all that the patch does, not it also deals with o
07.08.2017 18:57, Vladimir Sementsov-Ogievskiy wrote:
07.08.2017 18:46, Vladimir Sementsov-Ogievskiy wrote:
07.08.2017 17:29, Eric Blake wrote:
On 08/07/2017 09:16 AM, Vladimir Sementsov-Ogievskiy wrote:
185 iotest is broken.
How to test:
i=0; while ./check -qcow2 -nocache 185; do ((i+=1));
On 08/07/2017 11:09 AM, Vladimir Sementsov-Ogievskiy wrote:
> On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Set reply.handle to 0 on error path to prevent normal path of
>> nbd_co_receive_reply.
>>
>> The client still tried to send a flush request to the server, when
Markus Armbruster wrote:
> Sizes should use QAPI type 'size' (uint64_t). migrate-set-cache-size
> parameter @value is 'int' (int64_t). qmp_migrate_set_cache_size()
> ensures it fits into size_t. page_cache.c implicitly converts the
> signed size to unsigned types (it can't quite decide whether
Both the throttling limits set with the throttling.iops-* and
throttling.bps-* options and their QMP equivalents defined in the
BlockIOThrottle struct are integer values.
Those limits are also reported in the BlockDeviceInfo struct and they
are integers there as well.
Therefore there's no reason
Markus Armbruster wrote:
> qmp_migrate_set_cache_size() calls xbzrle_cache_resize() to do the
> actual work, which in turn calls cache_init() to resize the cache. If
> cache_init() fails, xbzrle_cache_resize() reports that error with
> error_report() and fails. qmp_migrate_set_cache_size() detec
Am 04.08.2017 um 17:10 hat Denis V. Lunev geschrieben:
> These cases were reported by Markus Armbruster
> Patches add error checking of the bdrv_getlength() call or remove
> the call of that function.
Thanks, applied to the block branch.
Kevin
On Thu, 3 Aug 2017 15:30:19 +0200
Thomas Huth wrote:
> Now that we've got a firmware that can do TFTP booting on s390x (i.e.
> the pc-bios/s390-netboot.img), we can enable the PXE tester for this
> architecture, too.
I'll take this through the s390x tree, unless someone objects.
>
> Signed-of
07.08.2017 18:33, Eric Blake wrote:
On 08/07/2017 10:13 AM, Eric Blake wrote:
On 08/07/2017 07:56 AM, Vladimir Sementsov-Ogievskiy wrote:
07.08.2017 14:52, Eric Blake wrote:
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
Set reply.handle to 0 on error path to prevent normal path
2017-08-07 18:52 GMT+03:00 Marcel Apfelbaum :
> On 05/08/2017 23:29, Aleksandr Bezzubikov wrote:
>>
>> On PCI init PCI bridge devices may need some
>> extra info about bus number to reserve, IO, memory and
>> prefetchable memory limits. QEMU can provide this
>> with special vendor-specific PCI capa
On Mon, 7 Aug 2017 21:04:16 +0800
Bob Chen wrote:
> Besides, I checked the lspci -vvv output, no capabilities of Access Control
> are seen.
Are these switches onboard an NVIDIA card or are they separate
components? The examples I have on NVIDIA cards do include ACS:
+-02.0-[42-47]00.0-[43-
On Mon, 7 Aug 2017 21:00:04 +0800
Bob Chen wrote:
> Bad news... The performance had dropped dramatically when using emulated
> switches.
>
> I was referring to the PCIe doc at
> https://github.com/qemu/qemu/blob/master/docs/pcie.txt
>
> # qemu-system-x86_64_2.6.2 -enable-kvm -cpu host,kvm=off -
07.08.2017 18:46, Vladimir Sementsov-Ogievskiy wrote:
07.08.2017 17:29, Eric Blake wrote:
On 08/07/2017 09:16 AM, Vladimir Sementsov-Ogievskiy wrote:
185 iotest is broken.
How to test:
i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo N = $i; \
done; echo N = $i
finished for me l
This allows to init the MMUCFG SPR with a non NULL value.
Signed-off-by: KONRAD Frederic
---
target/ppc/translate_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c
index 01723bd..2627cbe 100644
--- a/targ
Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 185 iotest is broken.
>
> How to test:
> > i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo N = $i; \
> done; echo N = $i
>
> finished for me like this:
>
> 185 2s ... - output mismatch (see 185.out.bad)
> --- /wor
Some OS don't populate the TSIZE field when using a fixed size TLB which result
in a 1KB TLB. When the TLB is a fixed size TLB the TSIZE field should be
ignored.
Fix this wrong behavior with MAV 2.0.
Signed-off-by: KONRAD Frederic
---
target/ppc/cpu.h| 22 ++
target/
Hi,
Those are some patches to add basic e6500 support for the moment e5500 with a
correct MMU configuration and supported instructions.
Some (maybe a lot of) things are missing (ie: the thread support) but it is
enough to boot a propietary OS on my side.
The first two patches are fixes when using
This introduces e6500 core.
Signed-off-by: KONRAD Frederic
---
target/ppc/cpu-models.c | 2 +
target/ppc/cpu-models.h | 1 +
target/ppc/translate_init.c | 91 -
3 files changed, 93 insertions(+), 1 deletion(-)
diff --git a/target/ppc/cpu-mod
On 05/08/2017 23:29, Aleksandr Bezzubikov wrote:
On PCI init PCI bridge devices may need some
extra info about bus number to reserve, IO, memory and
prefetchable memory limits. QEMU can provide this
with special vendor-specific PCI capability.
This capability is intended to be used only
for Red
This fixes booke206_tlbnps for MAV 2.0 by checking the MMUCFG register and
return directly the right tlbnps instead of computing it from non existing
field.
Signed-off-by: KONRAD Frederic
---
target/ppc/cpu.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/ppc/cpu.
- Original Message -
> Hi Dave
>
> On Wed, Jul 26, 2017 at 10:21 AM, Michael S. Tsirkin wrote:
> > On Sat, Jul 15, 2017 at 01:47:50AM +0200, Marc-André Lureau wrote:
> >> >
> >> > There's more info scattered in other places.
> >> >
> >> > Why do you get to document it? Because you are t
07.08.2017 17:29, Eric Blake wrote:
On 08/07/2017 09:16 AM, Vladimir Sementsov-Ogievskiy wrote:
185 iotest is broken.
How to test:
i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo N = $i; \
done; echo N = $i
finished for me like this:
185 2s ... - output mismatch (see 185.out.ba
On Mon, 24 Jul 2017 12:44:43 +0200
Christian Borntraeger wrote:
> On 07/19/2017 03:31 PM, Thomas Huth wrote:
> > On 19.07.2017 15:03, Cornelia Huck wrote:
> >> On Tue, 18 Jul 2017 16:24:46 +0200
> >> Cornelia Huck wrote:
> >>
> >>> Next try of the zPCI detangling, taking cpu models into acco
The QEMU tree often has dirty submodules in it but this will confuse
things as git stash is not going to save their state directly. They
are likely just dirty from build files anyway. Ignore them in the
diff-index command.
Signed-off-by: Alex Bennée
Reviewed-by: Eric Blake
---
tests/docker/Make
On Mon, Jul 31, 2017 at 01:17:03PM +0300, Michael Tokarev wrote:
> 28.07.2017 14:51, Eduardo Otubo wrote:
> > Starting Qemu with "qemu-system-unicore32 -M puv3,accel=qtest -S -nographic"
> > and entering "x 0 " at the monitor prompt leads to abort():
>
> Applied to -trivial, thanks!
>
Hi Michael
Installing the device-tree-compiler build-deps is a little extreme. We
only actually need the binary so include it with the other packages.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
---
tests/docker/dockerfiles/travis.docker | 3 +--
1 file changed, 1 insertion(+), 2 delet
While adding the current user is a useful default behaviour for
creating new images it is not appropriate for Travis which already has
a default user.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 1 +
1 fil
If you invoke with NOCACHE=1 we pass --no-cache in the argv to
docker.py but may still not force a rebuild if the dockerfile checksum
hasn't changed. By testing for its presence we can force builds
without having to manually remove the docker image.
Signed-off-by: Alex Bennée
---
tests/docker/do
I reported this a while ago but evidently forgot to push the patch
upstream. Without this I wasn't seeing the dirty tree state submitted
to the docker build which is very confusing.
Reference:
Subject: [PATCH 1/6] tests/docker/Makefile.include: fix diff-index call
Date: Fri, 28 Oct 2016 17:33:
Hello,
I am Vaibhav Shukla, sophomore student of Indian Institute of Information
Technology, Kalyani, India.
I would like to contribute in some projects in your company, please guide me
that how can I do so.
I shall be highly grateful to you.
Yours Sincerely
Hi,
I didn't get around to posting the pull-req before I went on holiday
as there were some comments to address on "docker: reduce noise when
building travis.docker". If there are no other comments I shall roll
the pull request with this.
Alex Bennée (6):
docker: ensure NOUSER for travis images
Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so
much as we build the image. See the Travis build logs where it is done
by their scripts.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Am 04.08.2017 um 16:09 hat Fam Zheng geschrieben:
> Errors from the callees must be captured and propagated to our caller,
> ensure this for both find_extent() and bdrv_getlength().
>
> Reported-by: Markus Armbruster
> Signed-off-by: Fam Zheng
Thanks, applied to the block branch.
Kevin
Pradeep Jagadeesh writes:
> On 7/6/2017 7:55 PM, Markus Armbruster wrote:
>> Pradeep Jagadeesh writes:
>>
>>> This patch enables qmp interfaces for the fsdev
>>> devices. This provides two interfaces one
>>> for querying info of all the fsdev devices. The second one
>>> to set the IO limits for
On Mon, Aug 07, 2017 at 04:46:00PM +0200, Markus Armbruster wrote:
> Byte offsets should use QAPI type 'size' (uint64_t).
> QCryptoBlockInfoLUKS member @payload-offset and
> QCryptoBlockInfoLUKSSlot member @key-offset are 'int' (int64_t).
> qcrypto_block_luks_get_info() gets the former QCryptoBlock
On 08/07/2017 10:13 AM, Eric Blake wrote:
> On 08/07/2017 07:56 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 07.08.2017 14:52, Eric Blake wrote:
>>> On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
Set reply.handle to 0 on error path to prevent normal path of
nbd_co_receive_reply
File offsets and sizes use QAPI type 'size' (uint64_t). MapEntry
members @start, @length and @offset are 'int' (int64_t).
get_block_status() sets @start and @length to unsigned long long
values, and @offset to a non-negative int64_t value.
Change these MapEntry members to 'size'.
"qemu-img map"
mirror_start_job() takes int64_t speed. The underlying BlockJob
abstraction takes uint64_t. mirror_start_job() converts from int64_t
to uint64_t, rejecting negative speed.
Lift this check and conversion out of mirror_start_job() into its
callers. I'm going to lift it further until it falls off
On 08/07/2017 07:56 AM, Vladimir Sementsov-Ogievskiy wrote:
> 07.08.2017 14:52, Eric Blake wrote:
>> On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Set reply.handle to 0 on error path to prevent normal path of
>>> nbd_co_receive_reply.
Side note: in general, our server must allow
qmp_migrate_set_cache_size() calls xbzrle_cache_resize() to do the
actual work, which in turn calls cache_init() to resize the cache. If
cache_init() fails, xbzrle_cache_resize() reports that error with
error_report() and fails. qmp_migrate_set_cache_size() detects the
failure and reports "Parame
The BlockJob abstraction takes int64_t speed. The underlying
RateLimit abstraction takes uint64_t. We convert from int64_t to
uint64_t in block_job_set_speed(). It rejects negative speed.
Lift this check and conversion up into its callers
qmp_block_job_set_speed() and block_job_create(). I'm g
Block dirty bitmaps represent granularity in bytes as uint32_t. It
must be a power of two and a multiple of BDRV_SECTOR_SIZE.
The trouble with uint32_t is computations like this one in
mirror_do_read():
uint64_t max_bytes;
max_bytes = s->granularity * s->max_iov;
The operands of * are
** Changed in: cloud-archive/mitaka
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1626972
Title:
QEMU memfd_create fallback mechanism change for securit
nfs_client_open() implicitly converts the uint64_t value of
qemu_opt_get_number() to int64_t, then clamps it to range. The
clamping is broken for negative values.
Fix by making NFSClient members @readahead and @pagecache uint64_t.
Signed-off-by: Markus Armbruster
---
block/nfs.c | 7 ---
1
stream_start() takes int64_t speed. The underlying BlockJob
abstraction takes uint64_t. stream_start() converts from int64_t to
uint64_t, rejecting negative speed.
Lift this check and conversion out of stream_start() into its caller.
I'm going to lift it further until it falls off the top.
Sign
Pradeep Jagadeesh writes:
> On 7/7/2017 8:14 AM, Markus Armbruster wrote:
>> Pradeep Jagadeesh writes:
>>
>>> These patches provide the qmp interface, to query the io throttle
>>> status of the all fsdev devices that are present in a vm.
>>> also, it provides an interface to set the io throttle
Sizes should use QAPI type 'size' (uint64_t). ImageInfo members
@virtual-size, @actual-size, @cluster-size are 'int' (int64_t).
bdrv_query_image_info() gets their values from bdrv_getlength(),
bdrv_get_allocated_file_size(), bdrv_get_info(), all signed. It
ensures the former two are non-negative,
Byte offsets should use QAPI type 'size' (uint64_t).
QCryptoBlockInfoLUKS member @payload-offset and
QCryptoBlockInfoLUKSSlot member @key-offset are 'int' (int64_t).
qcrypto_block_luks_get_info() gets the former QCryptoBlock member
@payload_offset, implicitly converting from uint64_t, and computes
Byte rates should use QAPI type 'size' (uint64_t). drive-backup,
blockdev-backup, block-commit, drive-mirror, blockdev-mirror,
block-stream and block-job-set-speed parameter @size is 'int'
(int64_t). Their QMP command handlers all ensure it's non-negative
before they pass it on to the next lower
File offsets should use QAPI type 'size' (uint64_t). BlockJobInfo
members @len, offset and parameters @len, @offset of events
BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are 'int'
(int64_t). block_job_query(), block_job_event_completed(),
block_job_event_cancelled(), block_job_event
File offsets should use QAPI type 'size' (uint64_t). ImageCheck
member @image-end-offset is 'int' (int64_t). collect_image_check()
gets it from BdrvCheckResult member @image_end_offset (also int64_t,
should never be negative).
Change the ImageCheck member to 'size', for QAPI/QMP consistency.
Si
File offsets, sizes and alignments should use QAPI type 'size'
(uint64_t). blockdev-add parameters are 'int' (int64_t):
BlockdevOptionsNull member @size; BlockdevOptionsQcow2 members
@cache-size, @l2-cache-size, @refcount-cache-size; BlockdevOptionsNfs
members @readahead-size, @page-cache-size; Bl
backup_job_create() takes int64_t speed. The underlying BlockJob
abstraction takes uint64_t. backup_job_create() converts from int64_t
to uint64_t, rejecting negative speed.
Lift this check and conversion out of backup_job_create() into its
callers. I'm going to lift it further until it falls o
File offsets should use QAPI type 'size' (uint64_t).
BLOCK_IMAGE_CORRUPTED parameters @offset and @size are 'int'
(int64_t). qcow2_signal_corruption() passes non-negative int64_t
values.
Change the event parameters to 'size', for QAPI/QMP consistency.
Signed-off-by: Markus Armbruster
---
qapi/
Signed-off-by: Markus Armbruster
---
qemu-img.c | 4
1 file changed, 4 insertions(+)
diff --git a/qemu-img.c b/qemu-img.c
index 3ae5fe3..cf3ef3e 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -2838,6 +2838,10 @@ static int img_map(int argc, char **argv)
}
length = blk_getlength(blk
Pradeep Jagadeesh writes:
> On 7/6/2017 8:47 PM, Markus Armbruster wrote:
>> Pradeep Jagadeesh writes:
>>
>>> This patch introduces qmp interfaces for the fsdev
>>> devices. This provides two interfaces one
>>> for querying info of all the fsdev devices. The second one
>>> to set the IO limits f
hbitmap_count() returns uint64_t.
Clean up test-hbitmap.c to check its value with g_assert_cmpuint()
instead of g_assert_cmpint().
bdrv_get_dirty_count() and bdrv_get_meta_dirty_count() return its
value converted to int64_t. Clean them up to return it unadulterated.
This moves the implicit conv
Sizes and addresses should use QAPI type 'size' (uint64_t).
PCDIMMDeviceInfo members @addr and @size are 'int' (int64_t).
qmp_pc_dimm_device_list() implicitly converts from uint64_t.
Change these PCDIMMDeviceInfo members to 'size'.
query-memory-devices now reports sizes and addresses above 2^63-1
File offsets should use QAPI type 'size' (uint64_t).
block-set-write-threshold parameter @write-threshold is 'int'
(int64_t). qmp_block_set_write_threshold() passes it on to
bdrv_write_threshold_set(), implicitly converting to uint64_t.
BLOCK_WRITE_THRESHOLD parameters @write-threshold, @amount-ex
Sizes, virtual and physical addresses should use QAPI type 'size'
(uint64_t). memsave, pmemsave parameters @val, @size are 'int'
(int64_t). qmp_memsave() and qmp_pmemsave() implicitly convert to
target_ulong or hwaddr.
Change the parameters to 'size'.
Both commands now accept size and address v
Sizes should use QAPI type 'size' (uint64_t). BlockMeasureInfo
members @required and @fully-allocated are 'int' (int64_t).
qcow2_measure() computes their values from qcow2_calc_prealloc_size(),
@virtual_size and @required, all uint64_t (the former only since the
previous commit).
raw_measure() c
blockdev_mirror_common() takes int64_t speed. The underlying BlockJob
abstraction takes uint64_t. blockdev_mirror_common() converts from
int64_t to uint64_t, rejecting negative speed.
Lift this check and conversion out of blockdev_mirror_common() into
its callers. I'm going to lift it further u
Byte counts and file offsets should use QAPI type 'size' (uint64_t).
BlockDeviceStats members @rd_bytes, @wr_bytes and @wr_highest_offset
are 'int' (int64_t). bdrv_query_blk_stats() gets them from
BlockAcctStats member nr_bytes[] and stat64_get(), implicitly
converting from uint64_t.
Change all t
The previous commit made it unsigned in QMP. Switch HMP's args_type
from 'M' to 'o'. Loses support for expressions (QEMU pocket
calculator), gains support for units other than mebibytes. Negative
values are no longer accepted and interpreted modulo 2^64. Instead,
values between 2^63 and 2^64-1
The nfs block driver uses QEMU_OPT_NUMBER for these sizes. All other
block drivers use QEMU_OPT_SIZE. Both are uint64_t, but QEMU_OPT_SIZE
rejects negative numbers, while QEMU_OPT_NUMBER interprets them modulo
2^64. Switch the nfs block driver to QEMU_OPT_SIZE.
Signed-off-by: Markus Armbruster
Byte counts should use QAPI type 'size' (uint64_t). BlockDirtyInfo
member @count is 'int' (int64_t). bdrv_query_dirty_bitmaps() computes
@count from bdrv_get_dirty_count() in uint64_t, then implicitly
converts to int64_t. Before the commit before previous, the
conversion was in bdrv_get_dirty_co
Byte counts should use QAPI type 'size' (uint64_t). Parameter
@buf-size of drive-mirror and blockdev-mirror is 'int' (int64_t). The
underlying MirrorBlockJob abstraction takes size_t.
mirror_start_job() converts from int64_t to size_t, rejecting negative
sizes (but not values exceeding SIZE_MAX).
Sizes, virtual and physical addresses should use QAPI type 'size'
(uint64_t). dump-guest-memory parameters @begin, @length are 'int'
(int64_t). They get implicitly converted to unsigned types somewhere
down in the bowels of the dump machinery. DumpQueryResult members
@completed and @total are al
commit_start() takes int64_t speed. The underlying BlockJob
abstraction takes uint64_t. commit_start() converts from int64_t to
uint64_t, rejecting negative speed.
Lift this check and conversion out of commit_start() and
commit_active_start() into their caller qmp_block_commit(). I'm going
to l
The previous commit made them unsigned in QMP. Switch HMP's args_type
from 'l' to 'o'. Loses support for expressions (QEMU pocket
calculator), gains support for unit suffixes. Negative values are no
longer accepted and interpreted modulo 2^64. Instead, values between
2^63 and 2^64-1 are now acc
Sizes should use QAPI type 'size' (uint64_t). block_resize parameter
@size is 'int' (int64_t). qmp_block_resize() ensures it's
non-negative before it passes it on to blk_truncate().
Change parameter @size to 'size', and update the range check
accordingly. Just cleanup; block_resize accepts the
qemu_chr_parse_ringbuf() initializes the new ChardevRingbuf's @size to
the value of qemu_opt_get_size(). Except it first truncates the value
from uint64_t to int. Fix that, so you can waste your RAM on
multi-gigabyte ring buffers.
Signed-off-by: Markus Armbruster
---
chardev/char-ringbuf.c | 8
Signed-off-by: Markus Armbruster
---
block/backup.c | 2 +-
block/commit.c | 2 +-
block/mirror.c | 2 +-
block/stream.c | 2 +-
blockjob.c | 9 +
include/block/blockjob_int.h | 2 +-
6 files changed, 6 insertions(+
Parameter @val is int64_t. It's assigned to opt->value.uint, which is
uint64_t, because that's what QemuOpts integers are. Screwed up when
the function was added in commit b83c18e. Change @val to uint64_t.
Signed-off-by: Markus Armbruster
---
include/qemu/option.h | 2 +-
util/qemu-option.c
block_job_create() takes int64_t speed. The underlying RateLimit
abstraction takes uint64_t. block_job_create() converts from int64_t
to uint64_t, rejecting negative speed.
Lift this check and conversion out of block_job_create() into its
callers. I'm going to lift it further until it falls off
Byte rates should use QAPI type 'size' (uint64_t).
migrate_set_speed's parameter @value and member @max-bandwidth of
MigrationParameters and MigrateSetParameters are 'int' (int64_t).
Change them all to 'size'.
migrate_set_speed and migrate-set-parameters now accept bandwidth
values between 2^63 a
@size is declared int64_t. It's set in two places.
The second one assigns the (signed) value of bdrv_getlength(), then
errors out if its negative.
The first one assigns qemu_opt_get_size(opts, BLOCK_OPT_SIZE, 0),
i.e. an uint64_t value. What if it exceeds INT64_MAX? Is that even
possible? Tur
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qdict.h | 5 +
qobject/qdict.c | 43 ---
2 files changed, 41 insertions(+), 7 deletions(-)
diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
index 363e431..3b52481 100644
--
mirror_start() takes int64_t speed. The underlying BlockJob
abstraction takes uint64_t. mirror_start() converts from int64_t to
uint64_t, rejecting negative speed.
Lift this check and conversion out of mirror_start() into its caller.
I'm going to lift it further until it falls off the top.
Sign
101 - 200 of 336 matches
Mail list logo
