Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

Alistair Francis writes: > On Mon, Aug 14, 2017 at 6:30 AM, Markus Armbruster wrote: [...] >> Drop the periods from the warning messages, and you may add >> Reviewed-by: Markus Armbruster >> >> I encourage you to also use the

[Qemu-devel] [PATCH] bios-tables-test: use strlen instead of sizeof

From: Wei Yang sizeof(BLOCK_NAME_END) is actually 2. it can work because there's a space after ,. but It is better to replace it with strlen so it will work without a space too. Signed-off-by: Wei Yang CC: Michael S. Tsirkin CC:

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

On 14.08.2017 22:44, Eric Farman wrote: > How often does one really do a "make clean" ? Rather infrequently, > as I only stumbled on this today. > > Perhaps I have missed the RM variable somewhere, as I see similar syntax > in some of the tests/tcg/ Makefiles, but I don't see it being set here.

Re: [Qemu-devel] [RFC PATCH 02/12] ppc4xx: Make MAL emulation more generic

On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > Allow MAL with more RX and TX channels as found in newer versions. > > Signed-off-by: BALATON Zoltan Looks reasonable. Reviewed-by: David Gibson > --- > hw/ppc/ppc405_uc.c

Re: [Qemu-devel] [RFC PATCH 03/12] ohci: Allow sysbus version to be used as a companion

On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: Wants a commit message - why do you need this functionality. Patch itself looks fine to me, but you should probably CC Gerd for review. > Signed-off-by: BALATON Zoltan > --- >

Re: [Qemu-devel] [PATCH] ppc: fix ppc_set_compat() with KVM PR

On Mon, Aug 14, 2017 at 07:49:16PM +0200, Greg Kurz wrote: > When running in KVM PR mode, kvmppc_set_compat() always fail because the > current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now that > the machine code inconditionally calls ppc_set_compat_all() at reset time > to

Re: [Qemu-devel] [RFC PATCH 06/12] ppc4xx_i2c: QOMify

On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan Mostly good, one niggle below. > --- > hw/ppc/ppc405.h | 2 - > hw/ppc/ppc405_uc.c | 5 +- > hw/ppc/ppc4xx_i2c.c | 153 >

[Qemu-devel] [PATCH v3 0/1] Exploit settable KVM_CAP_PPC_SMT

Hello QEMU PPC people, This is v3, it is only a single patch now. My core objective with this patch is to provide a way for QEMU to configure the newly writeable KVM capability 'KVM_CAP_PPC_SMT', because without it Power 9 hosts can only run VMs with a single thread per core. (With this

[Qemu-devel] [PATCH v3 1/1] PPC: KVM: Support machine option to set VSMT mode

KVM now allows writing to KVM_CAP_PPC_SMT which has previously been read only. Doing so causes KVM to act, for that VM, as if the host's SMT mode was the given value. This is particularly important on Power 9 systems because their default value is 1, but they are able to support values up to 8.

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On Tue, Aug 15, 2017 at 11:53:29AM +0800, wyang wrote: > Seems the only place, which needs to be fixed, is to replace sizeof with > strlen. Just like what you said, it is not fault but just refinement. > If you need it, I am glad to send patch to fix it. > > Wei Sure. > -- > Wei Yang(杨伟) >

[Qemu-devel] [PATCH for-2.10 3/4] block-backend: Defer shared_perm tightening migration completion

As in the case of nbd_export_new(), bdrv_invalidate_cache() can be called when migration is still in progress. In this case we are not ready to tighten the shared permissions fenced by blk->disable_perm. Defer to a VM state change handler. Signed-off-by: Fam Zheng ---

[Qemu-devel] [PATCH for-2.10 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache

From: Kevin Wolf The "inactive" state of BDS affects whether the permissions can be granted, we must call bdrv_invalidate_cache before bdrv_set_perm to support "-incoming defer" case. Reported-by: Christian Ehrhardt Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH for-2.10 4/4] iotests: Add non-shared storage migration case 192

Signed-off-by: Fam Zheng --- tests/qemu-iotests/192 | 63 ++ tests/qemu-iotests/192.out | 7 ++ tests/qemu-iotests/group | 1 + 3 files changed, 71 insertions(+) create mode 100755 tests/qemu-iotests/192 create mode

[Qemu-devel] [PATCH for-2.10 1/4] stubs: Add vm state change handler stubs

Signed-off-by: Fam Zheng --- stubs/Makefile.objs | 1 + stubs/change-state-handler.c | 14 ++ 2 files changed, 15 insertions(+) create mode 100644 stubs/change-state-handler.c diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs index

[Qemu-devel] [PATCH for-2.10 0/4] block: Fix non-shared storage migration

"nbd-server-add -w" doesn't work when we are in "-incoming defer" state: (qemu) nbd_server_add -w drive-virtio-disk0 Block node is read-only Two problems are faced: - nbd_export_new() calls bdrv_invalidate_cache() too late. - bdrv_invalidate_cache() restores qdev permission (which

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On 2017年08月15日 10:49, Michael S. Tsirkin wrote: BTW sizeof(BLOCK_NAME_END) is actually 2. I think it works because there's a space after ,. It is better to replace it with strlen so it will work without a space too. MST, I double check the failure of assert, it has already been fixed by the

Re: [Qemu-devel] [PATCH V2 2/3] xen-pt: bind/unbind interrupt remapping format MSI

Hi Anthony: On 2017年08月12日 02:04, Anthony PERARD wrote: > On Wed, Aug 09, 2017 at 04:51:21PM -0400, Lan Tianyu wrote: >> From: Chao Gao >> >> If a vIOMMU is exposed to guest, guest will configure the msi to remapping >> format. The original code isn't suitable to the new

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On 2017年08月14日 23:58, Michael S. Tsirkin wrote: On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: From: Wei Yang The assert would be touched when the version of acpica is greater than or equal to 20160318. its reason is that "Disasembler: Update a couple

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On Tue, Aug 15, 2017 at 10:46:27AM +0800, wyang wrote: > > > On 2017年08月15日 10:39, Michael S. Tsirkin wrote: > > On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: > > > On 2017年08月14日 23:58, Michael S. Tsirkin wrote: > > > > On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn

Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

On Mon, Aug 14, 2017 at 05:45:02PM +0100, Anthony PERARD wrote: > On Mon, Aug 14, 2017 at 06:53:14PM +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 14, 2017 at 03:55:50PM +0100, Anthony PERARD wrote: > > > On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > > > > On Fri, Aug

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On 2017年08月15日 10:39, Michael S. Tsirkin wrote: On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: On 2017年08月14日 23:58, Michael S. Tsirkin wrote: On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: From: Wei Yang The assert would be touched when

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: > On 2017年08月14日 23:58, Michael S. Tsirkin wrote: > > On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: > > > From: Wei Yang > > > > > > The assert would be touched when the version of acpica is greater

Re: [Qemu-devel] [PATCH] ppc: fix ppc_set_compat() with KVM PR

On Mon, 2017-08-14 at 19:49 +0200, Greg Kurz wrote: > When running in KVM PR mode, kvmppc_set_compat() always fail because > the > current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now > that > the machine code inconditionally calls ppc_set_compat_all() at reset > time > to restore

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

Hi Eduardo, At 08/14/2017 08:44 PM, Eduardo Habkost wrote: On Mon, Aug 14, 2017 at 06:11:11PM +0800, Dou Liyang wrote: Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0

Re: [Qemu-devel] [PATCH for 2.10?] qxl: call qemu_spice_display_init_common for secondary devices

On 15/08/2017 01:15, Paolo Bonzini wrote: > Fixes this 2.10 regression: > > $ qemu-system-x86_64 -cpu host -m 6144 -vga qxl -device qxl > qemu-system-x86_64: util/qemu-thread-posix.c:64: qemu_mutex_lock: Assertion > `mutex->initialized' failed. > > Reported-by: adema...@redhat.com > Cc:

Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

On 14/08/2017 21:03, Matt Parker wrote: >>> static const MemoryRegionOps rtl8139_mmio_ops = { >> I think you don't even need to declare a separate MemoryRegionOps, and >> can just recycle rtl8139_io_ops? > Looking at the memory region, it's only 0x100 bytes in size, > so addr & 0xFF would not be

[Qemu-devel] [PATCH for 2.10?] qxl: call qemu_spice_display_init_common for secondary devices

Fixes this 2.10 regression: $ qemu-system-x86_64 -cpu host -m 6144 -vga qxl -device qxl qemu-system-x86_64: util/qemu-thread-posix.c:64: qemu_mutex_lock: Assertion `mutex->initialized' failed. Reported-by: adema...@redhat.com Cc: kra...@redhat.com Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [libvirt] [RFC v4 00/13] qmp: query-device-slots command

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170814215748.5158-1-ehabk...@redhat.com Subject: [libvirt] [RFC v4 00/13] qmp: query-device-slots command Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

Example output when using "-machine q35": { "available": true, "count": 1, "device-types": [ "ide-device" ], "hotpluggable": false, "opts": [ { "option": "unit", "values": 0 }, { "option": "bus", "values": "ide.2" } ], "opts-complete": true }

[Qemu-devel] [RFC v4 06/13] qdev core: generic enumerate_slots implementation

Implement a generic enumerate_slots method on TYPE_BUS The generic implementation will just report a opts-complete=false entry, listing the "bus" option. This will let clients know that the bus is available, but that detailed slot information is not available by the running QEMU version. We

[Qemu-devel] [RFC v4 05/13] query-device-slots: Collapse similar entries

Use slot_list_collapse() on the final list returned by query-device-slots. This way we combine similar entries from different buses. For example, a machine with multiple IDE buses with no devices would return a single entry like this: { "available":true, "count":10,

[Qemu-devel] [RFC v4 04/13] qdev: Slot info helpers

Helper functions to deal with slot info data structures, and automatically merge similar device slots There's room for improvement on the slot merging algorithm, but this version should be enough to demonstrate how bus implementations can benefit from it. TODO: write API documentation, make

[Qemu-devel] [RFC v4 12/13] usb: enumerate_slots implementation

Example output for QEMU command-line: $ qemu-system-x86_64 -machine q35,usb=on -S \ -device usb-hub,port=2 -device usb-tablet,port=2.4 Output: {"available":true,"count":12, "device-types":["usb-device"],"hotpluggable":true, "opts":[

[Qemu-devel] [RFC v4 09/13] pci: pci_bus_has_pcie_upstream_port() function

The new helper will be useful when enumerating free slots on PCI buses. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- hw/pci/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [RFC v4 01/13] qmp: Define query-device-slots command

This adds a new command to QMP: query-device-slots. It will allow management software to query possible slots where devices can be plugged. Slot sets are represented by a list of option names and sets of possible values for each of those options. We use a compact format for set of valid values,

[Qemu-devel] [RFC v4 13/13] tests: Experimental query-device-slots test code

The test script is crude and full of hacks. Included in the RFC just in case somebody wants to try it. The script uses environment variables as arguments to make it easier to be invoked from the tests/ Makefile later. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [RFC v4 11/13] pci: enumerate_slots implementation

Enumerate each PCI function as a separate slots, because that's how QEMU treats multi-function PCI devices. Example output using "-machine q35" is below. { "available": true, "count": 224, "device-types": [ "pci-device" ], "hotpluggable": false, "opts": [ { "option":

[Qemu-devel] [RFC v4 03/13] qdev: Add BusClass::device_type field

The field will be useful when building device slot information for buses. TODO: Confirm if all bus types were handled by the patch. Signed-off-by: Eduardo Habkost --- include/hw/qdev-core.h| 3 +++ hw/audio/intel-hda.c | 7 +++ hw/block/fdc.c

[Qemu-devel] [RFC v4 00/13] qmp: query-device-slots command

Changelog - Changes v3 -> v4: * New compact representation of slot sets. * New generic code to automatically merge similar slots into a single entry in the command output while keeping implementations of the method simpler. * Example implementation of IDE and USB bus enumeration

[Qemu-devel] [RFC v4 07/13] qdev: Enumerate CPU slots on query-device-slots

Use machine_query_hotpluggable_cpus() to build the slot list for CPU devices. Example output: the following command line: $ qemu-system-x86_64 -machine q35,accel=kvm \ -cpu Haswell -smp 2,maxcpus=4 will generate the following entries: { "available": false, "count": 1,

[Qemu-devel] [RFC v4 10/13] pci: device-number & function properties

The "addr" property on PCI devices has some magic for parsing it as a single PCI device number (called "slot" internally), or a "." string. Add simple integer properties that can represent the device address with no special parsing. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum

[Qemu-devel] [RFC v4 02/13] qapi: qobject_compare() helper

The helper function will be useful when writing support code to deal with device slot information. TODO: documentation is incomplete and unclear, needs to be improved. Signed-off-by: Eduardo Habkost --- include/qapi/util.h| 39 +

[Qemu-devel] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting in the client hanging when it never

[Qemu-devel] [PATCH 1/1] pc-bios/s390-ccw: Use rm command during make clean

This reverts what I think was an accidental change that replaced the "rm -f" command with an undefined variable RM, and causes the "make clean" command to fail for a s390 target: make[1]: Entering directory '/usr/src/qemu/build/pc-bios/s390-ccw' rm -f *.timestamp *.o *.d *.img *.elf *~ *.a

[Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

How often does one really do a "make clean" ? Rather infrequently, as I only stumbled on this today. Perhaps I have missed the RM variable somewhere, as I see similar syntax in some of the tests/tcg/ Makefiles, but I don't see it being set here. My configure statement isn't terribly interesting,

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

Hi John, On 08/14/2017 10:39 AM, Programmingkid wrote: On Aug 14, 2017, at 8:50 AM, qemu-devel-requ...@nongnu.org wrote: An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html The

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

Hi Alistair, On 07/28/2017 07:16 PM, Alistair Francis wrote: Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using these commands:

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

On 08/14/2017 01:49 PM, Programmingkid wrote: > >> On Aug 14, 2017, at 2:20 PM, Eric Blake wrote: >> >> On 08/14/2017 12:20 PM, Programmingkid wrote: These are based against git master, just save the series and then 'git am' the lot in one go. >>> > > Thank you for

Re: [Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

On Mon, Aug 14, 2017 at 10:40:27AM +0200, Paolo Bonzini wrote: > On 12/08/2017 23:33, Matt Parker wrote: > > This updates the current MemoryRegionOps for the bar 1 memory region > > from using the old_mmio accessors to the .read and .write accessors. > > > > Signed-off-by: Matt Parker

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

On Mon, Aug 14, 2017 at 6:34 AM, Markus Armbruster wrote: > PATCH 3/5 has the exact same subject. Why are the two separate? You are right, that is a mess. This one doesn't check for newlines at the end while the earlier one checked for and removed new lines. > > Alistair

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

> On Aug 14, 2017, at 2:20 PM, Eric Blake wrote: > > On 08/14/2017 12:20 PM, Programmingkid wrote: >>> These are based against git master, just save the series and then 'git am' >>> the lot in one go. >> >> Is there a tool that can be used to download a series of patches

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

On Mon, Aug 14, 2017 at 6:30 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... >> to use warn_report() instead. This helps standardise on a single >> method of

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

Sorry but there appears to be an issue with your patchset. I ran this command: ./configure --target-list=ppc-softmmu,i386-softmmu Then saw this error message: error: pathspec 'ui/keycodemapdb' did not match any file(s) known to git. Running 'make' I saw this error message: make: *** No rule

Re: [Qemu-devel] RFH: difference in read-only mapped bios.bin - memory corruption?

* Philipp Hahn (h...@univention.de) wrote: > Hello, > > I'm currently investigating a problem, were a Linux VM does not reboot > and gets stuck in the SeaBIOS reboot code: > > I'm using SeaBIOS-1.7 from Debian with a more modern qemu-2.8 > > > virsh # qemu-monitor-command --hmp ucs41-414 info

Re: [Qemu-devel] [PATCH v1 2/5] Convert remaining error_report() to warn_report()

On Mon, Aug 14, 2017 at 4:45 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we >> converted uses of error_report("warning:"... to use warn_report() >> instead. This was to

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

On 08/14/2017 05:47 PM, Thomas Huth wrote: > On 14.08.2017 17:33, Cornelia Huck wrote: >> On Mon, 14 Aug 2017 17:34:15 +0300 >> "Michael S. Tsirkin" wrote: >> >>> Speed up tests on host systems with kvm support. >>> In particular, this fixes tests with --disable-tcg. > [...] >>>

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

The share=on attribute can also be used in the case of a pre-allocated file, created outside qemu, to be used as a memory backing, using the MAP_SHARED flag to allow data to be written out to the file in the case of host memory pressure. In this case, as the file was created outside qemu, it

Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init()

Le 14/08/2017 à 10:00, Igor Mammedov a écrit : > On Mon, 17 Jul 2017 17:23:22 +0200 > Igor Mammedov wrote: > >> On Mon, 17 Jul 2017 17:05:15 +0200 >> Andreas Färber wrote: >> >>> Am 17.07.2017 um 12:41 schrieb Igor Mammedov: On Sat, 15 Jul 2017

Re: [Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

On Sat, Aug 12, 2017 at 8:41 AM, Richard Henderson wrote: > SetExclusiveMonitors in the pseudocode is on the address + width, > and says nothing about the manner of the load. Therefore > > ldxpw0, w1, [x2] > vs > ldxrx0, [x2] > > must record the same

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

On 08/14/2017 12:20 PM, Programmingkid wrote: >> These are based against git master, just save the series and then 'git am' >> the lot in one go. > > Is there a tool that can be used to download a series of patches from a > mailing list? Copying and pasting patches sometimes introduces problems.

[Qemu-devel] [PATCH] ppc: fix ppc_set_compat() with KVM PR

When running in KVM PR mode, kvmppc_set_compat() always fail because the current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now that the machine code inconditionally calls ppc_set_compat_all() at reset time to restore the compat mode default value (commit 66d5c492dd3a9), it is

Re: [Qemu-devel] [RFC 03/29] qemu_ram_block_host_offset

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Jun 28, 2017 at 08:00:21PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Utility to give the offset of a host pointer within a RAMBlock > > (assuming we already know it's in that

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

> On Aug 14, 2017, at 10:00 AM, Daniel P. Berrange wrote: > > On Mon, Aug 14, 2017 at 09:39:56AM -0400, Programmingkid wrote: >> >>> On Aug 14, 2017, at 8:50 AM, qemu-devel-requ...@nongnu.org wrote: >>> >>> An update of: >>> >>> v1:

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170814162142.29666-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

On Mon, Aug 14, 2017 at 06:53:14PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 14, 2017 at 03:55:50PM +0100, Anthony PERARD wrote: > > On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > > > > To do PCI

[Qemu-devel] [PATCH v2] target-i386/cpu: Add new EPYC CPU model

Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Tom Lendacky

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

On Mon, Aug 14, 2017 at 05:21:40PM +0100, Stefan Hajnoczi wrote: > The SystemTap flight recorder mode no longer works with simpletrace.stp > because > the event ID mapping records are emitted the first time an event fires. > Chances are, the event ID mapping record will not be in ring buffer when

[Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

The SystemTap flight recorder mode no longer works with simpletrace.stp because the event ID mapping records are emitted the first time an event fires. Chances are, the event ID mapping record will not be in ring buffer when the users wants to print the trace. This series solves the issue by

[Qemu-devel] [PATCH for-2.10 1/2] trace: use static event ID mapping in simpletrace.stp

Commit 7f1b588f20d027730676e627713ae3bbf6baab04 ("trace: emit name <-> ID mapping in simpletrace header") broke the SystemTap flight recorder because event mapping records may no longer be present in the ring buffer when the trace is analyzed. This means simpletrace.py --no-header does not know

[Qemu-devel] [PATCH for-2.10 2/2] simpletrace: fix flight recorder --no-header option

The simpletrace.py script can pretty-print flight recorder ring buffers. These are not full simpletrace binary trace files but just the end of a trace file. There is no header and the event ID mapping information is often unavailable since the ring buffer may have filled up and discarded event ID

Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu subclasses

Hi Igor, On Mon, Aug 14, 2017 at 9:56 AM, Igor Mammedov wrote: > On Fri, 14 Jul 2017 15:51:55 +0200 > Igor Mammedov wrote: > >> QOMfy cpu models handling introducing propper cpu types >> for each cpu model. >> >> Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v2 for 2.10] block/nbd-client: always return EIO on and after the first io channel error

On 08/14/2017 02:39 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2017 01:28, Eric Blake wrote: >> On 08/08/2017 10:26 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> Initial review, I'm still playing with this one, and will reply again on >> Monday. >> >>> Do not communicate after the first error

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

On 08/12/2017 10:38 AM, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 08/12/2017 08:41 AM, Eric Blake wrote: >> Here's an idea: Instead of using struct ip6 { ... } QEMU_PACKED, use >> >> struct ip6 { >> ... >> }; >> QEMU_BUG_ON(sizeof(struct ip6) != 32); >> >> so that the compiler explicitly

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: > From: Wei Yang > > The assert would be touched when the version of acpica is greater than or > equal to 20160318. its reason is that "Disasembler: Update a couple > output items(commit id: 1ecbb3d)" is

[Qemu-devel] [PATCH] target-i386/cpu: Add new EYPC CPU model

Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx,73xx and 72xx). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Tom Lendacky

Re: [Qemu-devel] [PATCH v6 14/19] migration: Send the fd number which we are going to use for this page

* Juan Quintela (quint...@redhat.com) wrote: > We are still sending the page through the main channel, that would > change later in the series > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

On Mon, Aug 14, 2017 at 03:55:50PM +0100, Anthony PERARD wrote: > On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > > set, but

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

On 14.08.2017 17:33, Cornelia Huck wrote: > On Mon, 14 Aug 2017 17:34:15 +0300 > "Michael S. Tsirkin" wrote: > >> Speed up tests on host systems with kvm support. >> In particular, this fixes tests with --disable-tcg. [...] >> diff --git a/tests/pnv-xscom-test.c

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

On Mon, 14 Aug 2017 17:34:15 +0300 "Michael S. Tsirkin" wrote: > Speed up tests on host systems with kvm support. > In particular, this fixes tests with --disable-tcg. > > Cc: Paolo Bonzini > Cc: Thomas Huth > Cc: Laurent Vivier

Re: [Qemu-devel] [PATCH 1/1] QAPI schema: turn example commands/returns into proper JSON

Cleber Rosa writes: > On 08/08/2017 05:13 PM, Eric Blake wrote: >> On 08/08/2017 03:53 PM, Cleber Rosa wrote: >>> Most QMP commands and returns in the QAPI schema documentation >>> are valid "JSON-based wire format". A few examples are either >>> malformed, or contain

Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > set, but this was done only when ACPI tables are built which is not > > needed for

Re: [Qemu-devel] [PATCH v4 3/3] qemu-img check: add format allocation info

Vladimir Sementsov-Ogievskiy writes: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 6 +- > qemu-img.c | 42 ++ > 2 files changed, 47 insertions(+), 1

Re: [Qemu-devel] [PATCH v4 1/3] block: add bdrv_get_format_alloc_stat format interface

Cc: Eric Blake for additional schema review expertise. Vladimir Sementsov-Ogievskiy writes: > The function should collect statistics, about used/unused by top-level > format driver space (in its .file) and allocation status > (data/zero/discarded/after-eof) of

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

On Fri, Aug 11, 2017 at 01:43:55PM +0200, Cornelia Huck wrote: > On Fri, 11 Aug 2017 12:52:54 +0200 > Thomas Huth wrote: > > > On 11.08.2017 12:19, Cornelia Huck wrote: > > > > A quick test on x86_64 with --disable-tcg showed no further problems > > > than boot-serial-test, so

[Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

Speed up tests on host systems with kvm support. In particular, this fixes tests with --disable-tcg. Cc: Paolo Bonzini Cc: Thomas Huth Cc: Laurent Vivier Suggested-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary commands

Vadim Galitsyn writes: > Hi Guys, > > This thread is a continuation of discussion from: > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg01565.html > > I will post changes list here in cover letter. Looks good from a QMP point of view. Just clean

[Qemu-devel] RFH: difference in read-only mapped bios.bin - memory corruption?

Hello, I'm currently investigating a problem, were a Linux VM does not reboot and gets stuck in the SeaBIOS reboot code: I'm using SeaBIOS-1.7 from Debian with a more modern qemu-2.8 > virsh # qemu-monitor-command --hmp ucs41-414 info roms > fw=genroms/kvmvapic.bin size=0x002400

Re: [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

On Fri, Aug 11, 2017 at 09:59:00AM +0100, Peter Maydell wrote: > On 11 August 2017 at 09:51, David Gibson wrote: > > On Thu, Aug 10, 2017 at 01:47:03PM +0100, Peter Maydell wrote: > >> On 9 August 2017 at 08:03, David Gibson > >> wrote:

Re: [Qemu-devel] [PATCH v5 3/3] hmp: introduce 'info memory-size-summary' command

Vadim Galitsyn writes: > This command is an equivalent of QMP command query-memory-size-summary. > It provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > *

Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

On 14 August 2017 at 12:18, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> Can you move it to hw/i2c while you're at it? > I could if that's the preferred way but I've left it in hw/ppc because this > is not a generic device but specific to PPC SoCs and

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

Vadim Galitsyn writes: > Command above provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * hotunpluggable-memory - amount of memory that was hot-plugged. > If target

Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

On 14/08/2017 13:18, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, Paolo Bonzini wrote: >> On 13/08/2017 19:04, BALATON Zoltan wrote: >>> Signed-off-by: BALATON Zoltan >>> --- >>> hw/ppc/Makefile.objs | 2 +- >>> hw/ppc/ppc405.h | 2 + >>> hw/ppc/ppc405_uc.c | 241

Re: [Qemu-devel] [PATCH V2 for-2.10] xlnx-qspi: add a property for mmio-execution

On 11 August 2017 at 15:29, Edgar E. Iglesias wrote: > On Fri, Aug 11, 2017 at 09:54:12AM +0200, KONRAD Frederic wrote: >> This adds mmio-exec property to workaround the migration bug. >> When enabled the migration is blocked and will return an error. >> >>

Re: [Qemu-devel] migration issue with qemu 2.10-rc2: QEMU command 'nbd-server-add': Block node is read-only

On Fri, 08/11 18:48, Kevin Wolf wrote: > The patch below implements what I was thinking of, and it seems to fix > this problem. However, you'll immediately run into the next one, which > is a message like 'Conflicts with use by ide0-hd0 as 'root', which does > not allow 'write' on #block172'. > >

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

On Mon, Aug 14, 2017 at 09:39:56AM -0400, Programmingkid wrote: > > > On Aug 14, 2017, at 8:50 AM, qemu-devel-requ...@nongnu.org wrote: > > > > An update of: > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html > > v2:

Re: [Qemu-devel] [PATCH v6 11/19] migration: Start of multiple fd work

"Daniel P. Berrange" wrote: > On Tue, Aug 08, 2017 at 06:26:21PM +0200, Juan Quintela wrote: >> We create new channels for each new thread created. We send through >> them a string containing multifd so we are >> sure that we connect the right channels in both sides. >> >>

Re: [Qemu-devel] [PATCH v6 11/19] migration: Start of multiple fd work

On Mon, Aug 14, 2017 at 03:43:58PM +0200, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Tue, Aug 08, 2017 at 06:26:21PM +0200, Juan Quintela wrote: > >> We create new channels for each new thread created. We send through > >> them a string containing multifd so

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

> On Aug 14, 2017, at 8:50 AM, qemu-devel-requ...@nongnu.org wrote: > > An update of: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html > > The keycodemap project[1] provides a database

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

PATCH 3/5 has the exact same subject. Why are the two separate? Alistair Francis writes: > Convert any remaining uses of fprintf(stderr, "warning:"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > >

Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

Alistair Francis writes: > Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were changed using these commands:

  1   2   >