Re: [Qemu-devel] [PATCH] io: fix typo in docs comment for qio_channel_read

On 08/31/2017 04:50 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > include/io/channel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/include/io/channel.h

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

On Wed, 30 Aug 2017 19:05:58 +0200 David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 are

[Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

We can use the drive_del test on s390x, too, to check that adding and deleting also works fine with the virtio-ccw bus. But we have to make sure that we use the devices with the "-ccw" suffix instead of the "-pci" suffix for the virtio-ccw transport on s390x. Introduce a helper function called

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

On 31.08.2017 16:38, Cornelia Huck wrote: > On Thu, 31 Aug 2017 16:30:59 +0200 > David Hildenbrand wrote: > >> On 31.08.2017 16:29, Cornelia Huck wrote: >>> On Thu, 31 Aug 2017 15:11:28 +0200 >>> David Hildenbrand wrote: >>> >> +S390CPU

Re: [Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

Hi - Original Message - > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. > >> > >> Check that the QLit list has the same size as the qlist, this should

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

On Thu, 31 Aug 2017 16:30:59 +0200 David Hildenbrand wrote: > On 31.08.2017 16:29, Cornelia Huck wrote: > > On Thu, 31 Aug 2017 15:11:28 +0200 > > David Hildenbrand wrote: > > > +S390CPU *s390_cpu_addr2state(uint16_t cpu_addr) > +{ > +

Re: [Qemu-devel] [PATCH v2] io: add new qio_channel_{readv, writev, read, write}_all functions

On 08/31/2017 04:46 AM, Daniel P. Berrange wrote: > These functions wait until they are able to read / write the full > requested data buffer(s). > > Signed-off-by: Daniel P. Berrange > --- > Reviewed-by: Eric Blake -- Eric Blake, Principal Software

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

On 31.08.2017 16:31, Thomas Huth wrote: > On 31.08.2017 16:23, David Hildenbrand wrote: >> +struct S390CPU; >>> >>> You define a "struct S390CPU" here ... >>> typedef struct S390CcwMachineState { /*< private >*/ MachineState parent_obj; /*< public

Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling

On Wed, 30 Aug 2017 19:05:56 +0200 David Hildenbrand wrote: > Some time ago we discussed that using "id" as property name is not the > right thing to do, as it is a reserved property for other devices. > > Switch to the term "addr" instead, which matches the definition in the

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

On 31.08.2017 16:23, David Hildenbrand wrote: > >>> +struct S390CPU; >> >> You define a "struct S390CPU" here ... >> >>> typedef struct S390CcwMachineState { >>> /*< private >*/ >>> MachineState parent_obj; >>> >>> /*< public >*/ >>> +S390CPU **cpus; >> >> ... but use the

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

On 31.08.2017 16:29, Cornelia Huck wrote: > On Thu, 31 Aug 2017 15:11:28 +0200 > David Hildenbrand wrote: > +S390CPU *s390_cpu_addr2state(uint16_t cpu_addr) +{ +S390CcwMachineState *ms = S390_CCW_MACHINE(qdev_get_machine()); + +if (cpu_addr >=

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

On Thu, 31 Aug 2017 15:11:28 +0200 David Hildenbrand wrote: > >> +S390CPU *s390_cpu_addr2state(uint16_t cpu_addr) > >> +{ > >> +S390CcwMachineState *ms = S390_CCW_MACHINE(qdev_get_machine()); > >> + > >> +if (cpu_addr >= max_cpus) { > >> +return NULL; > >> +

Re: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

On 31 August 2017 at 15:04, Kamil Rytarowski wrote: > Could we please add SmartOS image. It's an Illumos distribution, > previously known as OpenSolaris. > > qemu is actively maintained for SmartOS in pkgsrc. > > The latest build fixes were introduced less than a week ago. >

[Qemu-devel] [PATCH v2 2/5] qapi: use items()/values() intead of iteritems()/itervalues()

The iteritems()/itervalues() methods are gone in py3, but the items()/values() methods are still around. The latter are less efficient than the former in py2, but this has unmeasurably small impact on QEMU build time, so taking portability over efficiency is a net win Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v2 4/5] qapi: adapt to moved location of StringIO module in py3

Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 05cb1ee38c..3c06711e2c 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -22,6 +22,10 @@ try:

[Qemu-devel] [PATCH v2 0/5] qapi: support py2 & py3 in parallel

Since I claimed that supporting py2 & py3 in parallel would be easy for QEMU, I figured I ought to actually give it a try to backup that assertion. This small patch series is the result of that effort. I tested this series on Fedora 26 using 2.7.13 and Python 3.6.2. To test with py3, I hacked

[Qemu-devel] [PATCH v2 5/5] qapi: Adapt to moved location of 'maketrans' function in py3

Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 3c06711e2c..853622badd 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1743,7 +1743,10 @@ def

[Qemu-devel] [PATCH v2 1/5] qapi: convert to use python print function instead of statement

Get Py2 + 3 compatibility by using the print function instead of print statement. This works for 2.6 onwards. Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 12 ++-- scripts/qapi2texi.py | 9 + 2 files changed, 11 insertions(+), 10

[Qemu-devel] [PATCH v2 3/5] qapi: Use OrderedDict from standard library if available

The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

>> +struct S390CPU; > > You define a "struct S390CPU" here ... > >> typedef struct S390CcwMachineState { >> /*< private >*/ >> MachineState parent_obj; >> >> /*< public >*/ >> +S390CPU **cpus; > > ... but use the typedef'ed S390CPU here ... looks somewhat suspicious, I >

Re: [Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing members

On Wed, 30 Aug 2017 19:05:52 +0200 David Hildenbrand wrote: > These comments are obviously stale. > > Signed-off-by: David Hildenbrand > --- > include/qom/cpu.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v1 01/11] exec, dump: don't include exec/exec-all.h explicitly

On Wed, 30 Aug 2017 19:05:51 +0200 David Hildenbrand wrote: > All but two, namely exec.c and dump.c, include exec/exec-all.h via > cpu.h only. as these files already include cpu.h, let's just drop the > additional include. > > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

Markus Armbruster writes: > Marc-André Lureau writes: > >> Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. >> >> Check that the QLit list has the same size as the qlist, this should >> ensure that we have an exact match when

Re: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

Could we please add SmartOS image. It's an Illumos distribution, previously known as OpenSolaris. qemu is actively maintained for SmartOS in pkgsrc. The latest build fixes were introduced less than a week ago. https://github.com/NetBSD/pkgsrc/commit/f2608af5433f1491a92567bf570e9349dffbda7a I'm

Re: [Qemu-devel] [PATCH for-2.11 v4 08/25] s390x: replace cpu_s390x_init() with cpu_generic_init()

On Thu, 31 Aug 2017 15:44:38 +0200 David Hildenbrand wrote: > On 31.08.2017 15:19, Igor Mammedov wrote: > > cpu_s390x_init() is used only *-user targets indirectly > > via cpu_init() macro and has a hack to assign ids to created > > cpus (I'm not sure if 'id' really matters to

Re: [Qemu-devel] [PATCH v2 01/14] qdict: add qdict_put_null() helper

Markus Armbruster writes: > Eric Blake writes: > >> On 08/25/2017 05:59 AM, Marc-André Lureau wrote: >>> A step towards completeness. >>> >>> Signed-off-by: Marc-André Lureau >>> Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

On Thu, Aug 31, 2017 at 2:26 PM, Paolo Bonzini wrote: > > > Il 31 ago 2017 9:43 AM, "Stefan Hajnoczi" ha scritto: > > On Wed, Aug 30, 2017 at 03:07:38PM +0100, Daniel P. Berrange wrote: > > On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez

Re: [Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

Marc-André Lureau writes: > Hi > > On Thu, Aug 31, 2017 at 10:43 AM Markus Armbruster > wrote: > >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> >> Marc-André Lureau

Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches

On 08/31/2017 03:21 AM, Stefan Hajnoczi wrote: > The following changes since commit 248b23735645f7cbb503d9be6f5bf825f2a603ab: Subject line should probably say 2.11, not 2.10 :) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org |

Re: [Qemu-devel] [PATCH for-2.11 v4 08/25] s390x: replace cpu_s390x_init() with cpu_generic_init()

On 31.08.2017 15:19, Igor Mammedov wrote: > cpu_s390x_init() is used only *-user targets indirectly > via cpu_init() macro and has a hack to assign ids to created > cpus (I'm not sure if 'id' really matters to *-user emulation). It only has one cpu, right? With the below mentioned patch, the

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

On 8/31/2017 3:34 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote: On 8/30/2017 5:10 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: Thanks for the steps, I did reproduce the issue easily. Looking into the code,

Re: [Qemu-devel] [PATCH for-2.11] tests/bios-tables: Silence some messages with V=1, print them with V=2 only

On 30.08.2017 15:48, Igor Mammedov wrote: > On Mon, 28 Aug 2017 19:39:45 +0200 > Thomas Huth wrote: > >> When running "make check-qtest-x86_64 V=1", the output is currently flooded >> with "Looking for expected file ..." and "Using expected file ..." messages. >> None of the

Re: [Qemu-devel] [PATCH v1 10/11] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault()

On 30.08.2017 21:11, Thomas Huth wrote: > On 30.08.2017 19:06, David Hildenbrand wrote: >> This looks cleaner. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/excp_helper.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote: > On 8/30/2017 5:10 PM, Alberto Garcia wrote: >> On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: >> >>> Thanks for the steps, I did reproduce the issue easily. Looking into >>> the code, may be we also need to try the same

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 14:25, Daniel P. Berrange wrote: > On Thu, Aug 31, 2017 at 02:19:05PM +0100, Peter Maydell wrote: >> On 31 August 2017 at 14:14, Daniel P. Berrange wrote: >> > NB, some distros have already changed /usr/bin/python to point to py3 >>

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 13:58, Markus Armbruster wrote: > Peter Maydell writes: > >> On 31 August 2017 at 07:35, Markus Armbruster wrote: >>> So, first we'll invest in work-arounds to make both 2 and 3 work. Once >>> 2 is gone, we

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 02:19:05PM +0100, Peter Maydell wrote: > On 31 August 2017 at 14:14, Daniel P. Berrange wrote: > > NB, some distros have already changed /usr/bin/python to point to py3 > > so all the files with #!/usr/bin/python in QEMU are already broken on > > those

Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH

On Thu, 31 Aug 2017 14:18:28 +0200 Halil Pasic wrote: > The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > present cc 1 and the other way around, because css_do_xsch has the error > codes mixed up. Because cc 1 has precedence over cc 2 we also

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

On 30.08.2017 21:06, Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x under TCG. >> >> Let's bail out if more

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 02:44:58PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: > >> On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > >> > If we can update to

Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h

On 31.08.2017 15:18, David Hildenbrand wrote: > On 31.08.2017 11:29, Thomas Huth wrote: >> On 30.08.2017 19:05, David Hildenbrand wrote: >>> The only interface left, so let's properly rename it. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> hw/s390x/s390-virtio-ccw.c

[Qemu-devel] [PATCH for-2.11 v4 08/25] s390x: replace cpu_s390x_init() with cpu_generic_init()

cpu_s390x_init() is used only *-user targets indirectly via cpu_init() macro and has a hack to assign ids to created cpus (I'm not sure if 'id' really matters to *-user emulation). So to on safe side, instead of having custom wrapper to do numbering replace it with cpu_generic_init() and use

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 14:14, Daniel P. Berrange wrote: > NB, some distros have already changed /usr/bin/python to point to py3 > so all the files with #!/usr/bin/python in QEMU are already broken on > those distros. This is a bug in those distros and they should fix it.

Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h

On 31.08.2017 11:29, Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: >> The only interface left, so let's properly rename it. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-virtio-ccw.c | 2 +- >>

[Qemu-devel] [PATCH 2/2] .dir-locals.el: add json schema to auto-mode

The json schema is more friendly to python-mode since it doesn't follow strictly json (comments to start with). All schema files add file variables to set the python mode, but most tests didn't. This will cover all json files now. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH 1/2] .dir-locals.el: add makefiles to auto-mode

QEMU uses non-conventional makefile filenames. Ease the life of emacs developpers a bit by appending to the auto-mode-alist. Signed-off-by: Marc-André Lureau --- .dir-locals.el | 7 ++- Makefile.target | 2 -- trace/Makefile.objs | 2 -- 3 files

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 02:58:24PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On 31 August 2017 at 07:35, Markus Armbruster wrote: > >> So, first we'll invest in work-arounds to make both 2 and 3 work. Once > >> 2 is gone, we can

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

>> +return 0; >> +} >> + >> + > > Nit: One empty line should be enough here. > > Reviewed-by: Thomas Huth > Indeed, thanks! -- Thanks, David

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

On 30.08.2017 19:05, David Hildenbrand wrote: > It is a leftover from the days where we had still the !ccw virtio > machine. As this one is long gone, let's move everything to > s390-virtio-ccw.c. > > Cornelia Huck I will add the missing Suggested-by: :) > Signed-off-by:

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

>> +S390CPU *s390_cpu_addr2state(uint16_t cpu_addr) >> +{ >> +S390CcwMachineState *ms = S390_CCW_MACHINE(qdev_get_machine()); >> + >> +if (cpu_addr >= max_cpus) { >> +return NULL; >> +} >> + >> +/* Fast lookup via CPU ID */ >> +return ms->cpus[cpu_addr]; >> +} > > I

Re: [Qemu-devel] [PATCH v1 01/11] exec, dump: don't include exec/exec-all.h explicitly

On 30.08.2017 20:55, Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: >> All but two, namely exec.c and dump.c, include exec/exec-all.h via >> cpu.h only. as these files already include cpu.h, let's just drop the >> additional include. >> >> Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

Peter Maydell writes: > On 31 August 2017 at 07:35, Markus Armbruster wrote: >> So, first we'll invest in work-arounds to make both 2 and 3 work. Once >> 2 is gone, we can invest some more to clean them up. Which probably >> won't happen, so we'll

Re: [Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH

On 31.08.2017 14:18, Halil Pasic wrote: > The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > present cc 1 and the other way around, because css_do_xsch has the error > codes mixed up. Because cc 1 has precedence over cc 2 we also have to > swap the two checks. > > Let us

Re: [Qemu-devel] [PULL 00/44] first batch of s390x patches for 2.11

On 30 August 2017 at 17:52, Cornelia Huck wrote: > The following changes since commit 1ab5eb4efb91a3d4569b0df6e824cc08ab4bd8ec: > > Update version for v2.10.0 release (2017-08-30 17:02:54 +0100) > > are available in the git repository at: > > git://github.com/cohuck/qemu

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 12:02, Daniel P. Berrange wrote: > On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: >> On 31 August 2017 at 11:47, Daniel P. Berrange wrote: >> > If we can update to python 2.7 as our minimum, then supporting py2 >> >

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

On 31 August 2017 at 13:29, Daniel P. Berrange wrote: > A while back now I posted an RFC patch that changes qemu-X.Y.Z.tar.bz2 > archive to *not* have any ROMs or 3rd party libs bundled, and create a > new dist qemu-bundled-X.Y.Z.tar.bz2 for the fully bundled dist: > >

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

"Daniel P. Berrange" writes: > On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: >> On 31 August 2017 at 11:47, Daniel P. Berrange wrote: >> > If we can update to python 2.7 as our minimum, then supporting py2 >> > and py3 gets simpler,

[Qemu-devel] RFC: changing ROM bundling in tar dists for releases

A while back now I posted an RFC patch that changes qemu-X.Y.Z.tar.bz2 archive to *not* have any ROMs or 3rd party libs bundled, and create a new dist qemu-bundled-X.Y.Z.tar.bz2 for the fully bundled dist: http://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03335.html With 2.10 out of the

[Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH

The function ioinst_handle_xsch is presenting cc 2 when it's supposed to present cc 1 and the other way around, because css_do_xsch has the error codes mixed up. Because cc 1 has precedence over cc 2 we also have to swap the two checks. Let us fix this. Signed-off-by: Halil Pasic

Re: [Qemu-devel] [PATCH v1 09/11] target/s390x: tcg_s390_program_interrupt() will never return

On 30.08.2017 22:45, Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: >> The assert should hold in both scenarios. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/interrupt.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi Eduardo, At 08/31/2017 06:38 PM, Dou Liyang wrote: Hi Eduardo, [...] +continue; } Now the nodes will be out of order, if node 0 has no RAM. Why? Because the code parsed the other node with RAM first, then parsed the node 0. Why not implement this in the same

[Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

From: Eduardo Habkost Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa

[Qemu-devel] [PATCH v5 2/3] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be called as node0). eg: ... \ -m 128,slots=3,maxmem=1G \ -numa node -numa node,mem=128M \ But, this makes it hard for QEMU to build a known-to-work ACPI SRAT table. Only fixing it is not

[Qemu-devel] [PATCH v5 0/3] hw/acpi-build: Fix ACPI SRAT Memory Affinity building

v4 --> v5: - Replace the original way with Eduardo's method. - rewrite the testcase. - Drop the SLIT date - 2.11 develop tree is opened, So, Add the third patch for re-posting it. v3 --> v4: -add a new testcase. This patchset fixs an ACPI building bug which caused by no RAM in the

[Qemu-devel] [PATCH v5 3/3] NUMA: Replace MAX_NODES with nb_numa_nodes in for loop

In QEMU, the number of the NUMA nodes is determined by parse_numa_opts(). Then, QEMU uses it for iteration, for example: for (i = 0; i < nb_numa_nodes; i++) However, in memory_region_allocate_system_memory(), it uses MAX_NODES not nb_numa_nodes. So, replace MAX_NODES with nb_numa_nodes to keep

Re: [Qemu-devel] [PATCH v8 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

On Fri, Aug 25, 2017 at 08:34:54PM -0400, Emilio G. Cota wrote: > On Sun, Jul 30, 2017 at 17:08:18 +0300, Lluís Vilanova wrote: > > The hypertrace channel allows guest code to emit events in QEMU (the host) > > using > > its tracing infrastructure (see "docs/trace.txt"). This works in both > >

Re: [Qemu-devel] [PULL 00/29] Code cleanup patches

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170831103432.6007-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PULL 00/29] Code cleanup patches Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports the GMainContext event loop

On Tue, Aug 29, 2017 at 03:22:37PM +0800, Wang yong wrote: > From: Wang Yong > > IOThread uses AioContext event loop and does not run a GMainContext. > Therefore,chardev cannot work in IOThread,such as the chardev is > used for colo-compare packets reception. > > This

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

On Thu, Aug 24, 2017 at 08:21:59AM +0100, Stefan Hajnoczi wrote: > This series introduces context managers for the two most commonly used > resources: files and VMs. Context managers eliminate the need to call a > cleanup function explicitly. > > Tests should declare resources upfront in a with

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

On 08/31/2017 09:50 AM, Thomas Huth wrote: > On 30.08.2017 18:36, Halil Pasic wrote: >> According to the POP a start subchannel instruction (SSCH) returning with >> cc 1 implies that the subchannel was status pending when SSCH executed. >> >> Due to a somewhat confusing error handling, where

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

On 08/31/2017 11:19 AM, Cornelia Huck wrote: > On Wed, 30 Aug 2017 18:36:02 +0200 > Halil Pasic wrote: > >> According to the POP a start subchannel instruction (SSCH) returning with >> cc 1 implies that the subchannel was status pending when SSCH executed. >> >> Due

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

I have not reviewed this, but the whole idea is Acked-by: Christian Borntraeger On 08/30/2017 07:05 PM, David Hildenbrand wrote: > It is a leftover from the days where we had still the !ccw virtio > machine. As this one is long gone, let's move everything to >

[Qemu-devel] [PATCH v4] block: document semantics of bdrv_co_preadv|pwritev

Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- Changed in v4: - Fix typo in commit message include/block/block_int.h | 31 +++ 1 file changed, 31

[Qemu-devel] [PULL 24/29] kvm: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- linux-headers/asm-x86/kvm.h | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 23/29] i386/dump: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Acked-by: Eduardo Habkost Reviewed-by: Richard Henderson --- target/i386/arch_dump.c |

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi Eduardo, [...] +continue; } Now the nodes will be out of order, if node 0 has no RAM. Why? Because the code parsed the other node with RAM first, then parsed the node 0. Why not implement this in the same way the PCI 4GB hole is already implemented. e.g.:

[Qemu-devel] [PULL 20/29] usb-hub: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- hw/usb/dev-hub.c | 8 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PULL 16/29] console: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- include/ui/console.h

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

Il 31 ago 2017 9:43 AM, "Stefan Hajnoczi" ha scritto: On Wed, Aug 30, 2017 at 03:07:38PM +0100, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > > diff --git a/target/i386/hvf-utils/x86.c b/target/i386/hvf-utils/x86.c

[Qemu-devel] [PATCH v2 3/3] docker: Add test-block

Signed-off-by: Fam Zheng --- tests/docker/test-block | 21 + 1 file changed, 21 insertions(+) create mode 100755 tests/docker/test-block diff --git a/tests/docker/test-block b/tests/docker/test-block new file mode 100755 index 00..20ef70538f ---

[Qemu-devel] [PATCH v2 0/3] docker: Add test-block

A few tweaks to the docker images and running commands allow us to run qemu-iotests in the fedora container. This will be added to the patchew test cases later. v2: Add nettle-devel because a few iotest cases blindly assumes the support is there. Fam Zheng (3): docker: Use unconfined security

[Qemu-devel] [PATCH v2 2/3] docker: Add nettle-devel to fedora image

The LUKS cases in qemu-iotests requires this. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 4eaa8ed2a5..27e8201c54

[Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile

Some by default blocked syscalls are required to run tests for example userfaultfd. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

[Qemu-devel] [PATCH v2 3/4] block: convert crypto driver to bdrv_co_preadv|pwritev

Make the crypto driver implement the bdrv_co_preadv|pwritev callbacks, and also use bdrv_co_preadv|pwritev for I/O with the protocol driver beneath. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 103 + 1 file

[Qemu-devel] [PATCH v2 0/4] block: improve luks driver perf & switch to byte APIs

This series includes a previously posted patch that improves performance of the luks crypto driver: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html And then adds three patches that switch over to use byte based APIs for I/O, rather than the legacy sector based APIs. Daniel

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > If we can update to python 2.7 as our minimum, then supporting py2 > and py3 gets simpler, avoiding some of the nastier hacks, even > without that though it isn't too hard. Unfortunately RHEL6 is what's holding us to

[Qemu-devel] [PATCH v2 4/4] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

Instead of sector offset, take the bytes offset when encrypting or decrypting data. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 8 block/qcow.c | 7 +-- block/qcow2-cluster.c | 8 +++- block/qcow2.c | 4 ++--

[Qemu-devel] [PATCH v2 1/4] block: use 1 MB bounce buffers for crypto instead of 16KB

Using 16KB bounce buffers creates a significant performance penalty for I/O to encrypted volumes on storage which high I/O latency (rotating rust & network drives), because it triggers lots of fairly small I/O operations. On tests with rotating rust, and cache=none|directsync, write speed

[Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

Signed-off-by: Daniel P. Berrange --- block/crypto.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/block/crypto.c b/block/crypto.c index cc8afe0e0d..e63f094379 100644 --- a/block/crypto.c +++ b/block/crypto.c @@

[Qemu-devel] [PULL 27/29] i386: replace g_malloc()+memcpy() with g_memdup()

I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Reviewed-by: Richard Henderson --- hw/i386/multiboot.c | 3 +-- 1 file

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: > On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > > If we can update to python 2.7 as our minimum, then supporting py2 > > and py3 gets simpler, avoiding some of the nastier hacks, even > > without that

Re: [Qemu-devel] [Qemu-discuss] Accessing a shared folder

On 31 August 2017 at 11:34, Mahmood via Qemu-devel wrote: > Hello again, > For the command > > mount -t 9p -o trans=virtio Downloads /media/Downloads > > inside the Centos-7 guest, I get this error > > mount: unknown filesystem type '9p' > > Any thought? That's an

[Qemu-devel] [PULL 29/29] eepro100: replace g_malloc()+memcpy() with g_memdup()

I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Weil Reviewed-by: Jason Wang Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 28/29] test-iov: replace g_malloc()+memcpy() with g_memdup()

I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- tests/test-iov.c | 3 +-- 1 file

Re: [Qemu-devel] [PATCH 0/9]

On 08/31/2017 12:04 PM, Cornelia Huck wrote: > On Wed, 30 Aug 2017 18:36:00 +0200 > Halil Pasic wrote: > >> This series has a character of a refactoring, as the initial motivation >> was improving readability and reducing complexity. > > But you reduced the cover

[Qemu-devel] [PULL 26/29] i386: introduce ELF_NOTE_SIZE macro

Factour out a common pattern to compute the ELF note size. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Reviewed-by: Richard Henderson --- target/i386/arch_dump.c | 20 ++-- 1 file changed, 10

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 11:27:15AM +0100, Peter Maydell wrote: > On 31 August 2017 at 07:35, Markus Armbruster wrote: > > So, first we'll invest in work-arounds to make both 2 and 3 work. Once > > 2 is gone, we can invest some more to clean them up. Which probably > > won't

[Qemu-devel] [PULL 22/29] ppc: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Acked-by: David Gibson Reviewed-by: Richard Henderson ---

[Qemu-devel] [PULL 21/29] msix: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/pci/msix.c | 4

[Qemu-devel] [PULL 18/29] piix: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/pci-host/piix.c |

<    1   2   3   4   >