Re: [Qemu-devel] [PATCH] iotests: test clearing unknown autoclear_features by qcow2

2017-11-16 Thread Vladimir Sementsov-Ogievskiy
10.11.2017 23:02, Kevin Wolf wrote: Am 10.11.2017 um 18:54 hat Vladimir Sementsov-Ogievskiy geschrieben: Test clearing unknown autoclear_features by qcow2 on incoming migration. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! This patch shows degradation,

Re: [Qemu-devel] [Qemu-block] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type

2017-11-16 Thread Paolo Bonzini
On 16/11/2017 18:38, Cleber Rosa wrote: > check makes a distinction on how it runs Python based tests. The > current approach is inconsistent because: > > 1) a large number of Python tests are already set as executable files > (eg: 030, 040, 041, 044, 045, 055, 056, 057, 065, 093, 118, 147, 149,

Re: [Qemu-devel] [PATCH for-2.12 v3 08/11] spapr: introduce a XICSFabric irq_is_lsi() operation

2017-11-16 Thread Cédric Le Goater
On 11/17/2017 05:54 AM, David Gibson wrote: > On Fri, Nov 10, 2017 at 03:20:14PM +, Cédric Le Goater wrote: >> It will be used later on to distinguish the allocation of an LSI >> interrupt from an MSI and also to reduce the use of the ICSIRQState >> array of the ICSState object, which is on

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-16 Thread Paolo Bonzini
On 16/11/2017 18:38, Cleber Rosa wrote: > This variables has no real use. To avoid pretending it does, while > still keeping the information, let's turn it into a comment. > > The format chosen is the one already being used on tests 149 and 194. I would just delete it... Paolo >

Re: [Qemu-devel] [PATCH for-2.11] hw/net/eepro100: Fix endianness problem on big endian hosts

2017-11-16 Thread Thomas Huth
On 17.11.2017 06:35, Stefan Weil wrote: > Am 17.11.2017 um 05:14 schrieb Michael S. Tsirkin: >> On Thu, Nov 16, 2017 at 10:16:54PM +0100, Thomas Huth wrote: >>> Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission >>> mode"), the test/pxe-test is broken for the eepro100 device

Re: [Qemu-devel] [PATCH for-2.12 v3 05/11] spapr: introduce an IRQ allocator using a bitmap

2017-11-16 Thread Cédric Le Goater
On 11/17/2017 05:50 AM, David Gibson wrote: > On Tue, Nov 14, 2017 at 10:42:24AM +0100, Greg Kurz wrote: >> On Fri, 10 Nov 2017 15:20:11 + >> Cédric Le Goater wrote: >> >>> Let's define a new set of XICSFabric IRQ operations for the latest >>> pseries machine. These simply use

Re: [Qemu-devel] [PATCH for-2.12 v3 03/11] spapr: introduce new XICSFabric operations for an IRQ allocator

2017-11-16 Thread Cédric Le Goater
On 11/17/2017 05:48 AM, David Gibson wrote: > On Fri, Nov 10, 2017 at 03:20:09PM +, Cédric Le Goater wrote: >> Currently, the ICSState 'ics' object of the sPAPR machine acts as the >> global interrupt source handler and also as the IRQ number allocator >> for the machine. Some IRQ numbers are

Re: [Qemu-devel] [PATCH v3 0/3] Qemu: add Xen vIOMMU interrupt remapping function support

2017-11-16 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3 0/3] Qemu: add Xen vIOMMU interrupt remapping function support Type: series Message-id:

Re: [Qemu-devel] [Question] why need to start all queues in vhost_net_start

2017-11-16 Thread Jason Wang
On 2017年11月17日 12:32, Michael S. Tsirkin wrote: On Thu, Nov 16, 2017 at 08:04:34PM +0800, Jason Wang wrote: On 2017年11月16日 17:32, Longpeng (Mike) wrote: Hi Jason, On 2017/11/16 17:13, Jason Wang wrote: On 2017年11月16日 17:01, Gonglei (Arei) wrote: No, Windows guest + vhost-user/DPDK. BTW

Re: [Qemu-devel] [QEMU-PPC] [PATCH V3] target/ppc: Update setting of cpu features to account for compat modes

2017-11-16 Thread David Gibson
On Fri, Nov 17, 2017 at 04:39:00PM +1100, Suraj Jitindar Singh wrote: > The device tree nodes ibm,arch-vec-5-platform-support and ibm,pa-features > are used to communicate features of the cpu to the guest operating > system. The properties of each of these are determined based on the > selected

[Qemu-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request

2017-11-16 Thread Chao Gao
According to VT-d spec Interrupt Remapping and Interrupt Posting -> Interrupt Remapping -> Interrupt Request Formats On Intel 64 Platforms, fields of MSI data register have changed. This patch avoids wrongly regarding a remappable format interrupt request as an interrupt binded with a pirq.

[Qemu-devel] [PATCH v3 0/3] Qemu: add Xen vIOMMU interrupt remapping function support

2017-11-16 Thread Chao Gao
This patchset is to deal with MSI interrupt remapping request when guest updates MSI registers. In case of conflicts, this series also can be found in my personal github: Xen: https://github.com/gc1008/viommu_xen.git vIOMMU4 Qemu: https://github.com/gc1008/viommu_qemu.git vIOMMU3 Any comments

[Qemu-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen

2017-11-16 Thread Chao Gao
Previously, some fields (reserved or unalterable) are filtered by Qemu. This fields are useless for the legacy interrupt format. However, these fields are may meaningful (for intel platform) for the interrupt of remapping format. It is better to pass the whole msi addr/data to Xen without any

[Qemu-devel] [PATCH v3 1/3] i386/msi: Correct mask of destination ID in MSI address

2017-11-16 Thread Chao Gao
According to SDM 10.11.1, only [19:12] bits of MSI address are Destination ID, change the mask to avoid ambiguity for VT-d spec has used the bit 4 to indicate a remappable interrupt request. Signed-off-by: Chao Gao Signed-off-by: Lan Tianyu Reviewed-by:

[Qemu-devel] [PATCH] rcu: reduce half heap memory size by malloc_trim()

2017-11-16 Thread Yang Zhong
Since there are some issues in memory alloc/free machenism in glibc for little chunk memory, if Qemu frequently alloc/free little chunk memory, the glibc doesn't alloc little chunk memory from free list of glibc and still allocate from OS, which make the heap size bigger and bigger. This patch

Re: [Qemu-devel] [PATCH for-2.12 v3 08/11] spapr: introduce a XICSFabric irq_is_lsi() operation

2017-11-16 Thread David Gibson
On Fri, Nov 10, 2017 at 03:20:14PM +, Cédric Le Goater wrote: > It will be used later on to distinguish the allocation of an LSI > interrupt from an MSI and also to reduce the use of the ICSIRQState > array of the ICSState object, which is on our way to introduce XIVE. > > The 'irq' parameter

[Qemu-devel] [QEMU-PPC] [PATCH V3] target/ppc: Update setting of cpu features to account for compat modes

2017-11-16 Thread Suraj Jitindar Singh
The device tree nodes ibm,arch-vec-5-platform-support and ibm,pa-features are used to communicate features of the cpu to the guest operating system. The properties of each of these are determined based on the selected cpu model and the availability of hypervisor features. Currently the

Re: [Qemu-devel] [PATCH for-2.12 v3 05/11] spapr: introduce an IRQ allocator using a bitmap

2017-11-16 Thread David Gibson
On Tue, Nov 14, 2017 at 10:42:24AM +0100, Greg Kurz wrote: > On Fri, 10 Nov 2017 15:20:11 + > Cédric Le Goater wrote: > > > Let's define a new set of XICSFabric IRQ operations for the latest > > pseries machine. These simply use a a bitmap 'irq_map' as a IRQ number > >

Re: [Qemu-devel] [PATCH for-2.11] hw/net/eepro100: Fix endianness problem on big endian hosts

2017-11-16 Thread Stefan Weil
Am 17.11.2017 um 05:14 schrieb Michael S. Tsirkin: > On Thu, Nov 16, 2017 at 10:16:54PM +0100, Thomas Huth wrote: >> Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission >> mode"), the test/pxe-test is broken for the eepro100 device on big >> endian hosts. However, it seems like

Re: [Qemu-devel] [Question] why need to start all queues in vhost_net_start

2017-11-16 Thread Longpeng (Mike)
On 2017/11/17 12:32, Michael S. Tsirkin wrote: > On Thu, Nov 16, 2017 at 08:04:34PM +0800, Jason Wang wrote: >> >> >> On 2017年11月16日 17:32, Longpeng (Mike) wrote: >>> Hi Jason, >>> >>> On 2017/11/16 17:13, Jason Wang wrote: >>> On 2017年11月16日 17:01, Gonglei (Arei) wrote: > No,

Re: [Qemu-devel] [PATCH for-2.12 v3 03/11] spapr: introduce new XICSFabric operations for an IRQ allocator

2017-11-16 Thread David Gibson
On Fri, Nov 10, 2017 at 03:20:09PM +, Cédric Le Goater wrote: > Currently, the ICSState 'ics' object of the sPAPR machine acts as the > global interrupt source handler and also as the IRQ number allocator > for the machine. Some IRQ numbers are allocated very early in the > machine

Re: [Qemu-devel] [Question] why need to start all queues in vhost_net_start

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 08:04:34PM +0800, Jason Wang wrote: > > > On 2017年11月16日 17:32, Longpeng (Mike) wrote: > > Hi Jason, > > > > On 2017/11/16 17:13, Jason Wang wrote: > > > > > > > > On 2017年11月16日 17:01, Gonglei (Arei) wrote: > > > > No, Windows guest + vhost-user/DPDK. > > > > > > > >

Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 05:43:52PM +0100, Thomas Huth wrote: > On 16.11.2017 17:15, Peter Maydell wrote: > > On 16 November 2017 at 16:13, Daniel P. Berrange > > wrote: > >> On Thu, Nov 16, 2017 at 04:10:22PM +, Peter Maydell wrote: > >>> If there are known-buggy iasl

Re: [Qemu-devel] [PATCH for-2.11] hw/net/eepro100: Fix endianness problem on big endian hosts

2017-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 10:16:54PM +0100, Thomas Huth wrote: > Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission > mode"), the test/pxe-test is broken for the eepro100 device on big > endian hosts. However, it seems like that commit did not introduce the > problem, but just

Re: [Qemu-devel] [PATCH 0/2] virtio-net: Fix TX data discard on backend disconnection

2017-11-16 Thread Jason Wang
On 2017年11月17日 02:48, Maxime Coquelin wrote: This series fixes TX data discard when backend disconnects. On backend disconnection, QEMU cannot retrieve its internal avail index, which makes the virtio queue internal state inconsistent (last_avail_idx will always be 0, whereas used_idx is

Re: [Qemu-devel] [Question] why need to start all queues in vhost_net_start

2017-11-16 Thread Jason Wang
On 2017年11月17日 10:01, Longpeng (Mike) wrote: On 2017/11/16 20:04, Jason Wang wrote: On 2017年11月16日 17:32, Longpeng (Mike) wrote: Hi Jason, On 2017/11/16 17:13, Jason Wang wrote: On 2017年11月16日 17:01, Gonglei (Arei) wrote: No, Windows guest + vhost-user/DPDK. BTW pls see virtio spec in

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-16 Thread John Snow
On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.11.2017 00:20, John Snow wrote: >> >> On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all. >>> >>> There are three qmp commands, needed to implement external backup API. >>> >>> Using these three commands, client

Re: [Qemu-devel] [PATCH 0/2] e1000: Correct TX offload context handling

2017-11-16 Thread Jason Wang
On 2017年11月15日 07:23, Ed Swierk via Qemu-devel wrote: The transmit offload implementation in QEMU's e1000 device is deficient and causes packet data corruption in some situations. According to the Intel 8254x software developer's manual[1], the device maintains two separate contexts: the TCP

Re: [Qemu-devel] [PATCH v3 REPOST] net: Transmit zero UDP checksum as 0xFFFF

2017-11-16 Thread Jason Wang
On 2017年11月16日 22:06, Ed Swierk wrote: The checksum algorithm used by IPv4, TCP and UDP allows a zero value to be represented by either 0x and 0x. But per RFC 768, a zero UDP checksum must be transmitted as 0x because 0x is a special value meaning no checksum. Substitute

Re: [Qemu-devel] [PATCH for-2.11] MAINTAINERS: Add missing entry for eepro100 emulation

2017-11-16 Thread Jason Wang
On 2017年11月17日 03:49, Stefan Weil wrote: Signed-off-by: Stefan Weil --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ffd77b461c..83434e09af 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1183,6 +1183,11 @@ M: Dmitry

Re: [Qemu-devel] [PATCH for-2.11] hw/net/eepro100: Fix endianness problem on big endian hosts

2017-11-16 Thread Jason Wang
On 2017年11月17日 05:16, Thomas Huth wrote: Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission mode"), the test/pxe-test is broken for the eepro100 device on big endian hosts. However, it seems like that commit did not introduce the problem, but just uncovered it: The

Re: [Qemu-devel] [PATCH] Revert "Add new PCI ID for i82559a"

2017-11-16 Thread Jason Wang
On 2017年11月16日 20:20, Jason Wang wrote: This reverts commit 5e89dc01133f8f5e621f6b66b356c6f37d31dafb since: - we should use ID in the spec instead the one used by OEM - in the future, we should allow changing id through either property or EEPROM file. Cc: Stefan Weil

Re: [Qemu-devel] [PATCH] colo-compare: fix the dangerous assignment

2017-11-16 Thread Jason Wang
On 2017年11月16日 10:28, Mao Zhongyi wrote: Cc: Peter Maydell Cc: Jason Wang Cc: Zhang Chen Cc: Li Zhijian Cc: Paolo Bonzini Fixes: 8ec14402029d783720f4312ed8a925548e1dad61

Re: [Qemu-devel] [PATCH v2] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v2] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command Message-id: 20171117020447.9776-1-caoxin...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash #

Re: [Qemu-devel] [PATCH v2] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command Type: series

[Qemu-devel] [PATCH v2] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread xinhua.Cao
When we always kill vm's ipmi_sim program. qemu will do handling chr_event to reconnect ipmi_sim. handling chain is chr_event -> continue_send -> qemu_chr_fe_write. if ipmi_sim program was killed again. then qemu_chr_fe_write will failed. then ibe's outlen and outbuf will not cleared. so if vcpu

Re: [Qemu-devel] [Question] why need to start all queues in vhost_net_start

2017-11-16 Thread Longpeng (Mike)
On 2017/11/16 20:04, Jason Wang wrote: > > > On 2017年11月16日 17:32, Longpeng (Mike) wrote: >> Hi Jason, >> >> On 2017/11/16 17:13, Jason Wang wrote: >> >>> >>> On 2017年11月16日 17:01, Gonglei (Arei) wrote: No, Windows guest + vhost-user/DPDK. BTW pls see virtio spec in :

Re: [Qemu-devel] [PATCH v8 10/14] migration: add postcopy migration of dirty bitmaps

2017-11-16 Thread John Snow
On 11/16/2017 11:50 AM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >> >> >> On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Postcopy migration of dirty bitmaps. Only named dirty bitmaps, >>> associated with root nodes and non-root named nodes are

Re: [Qemu-devel] [PATCH] colo-compare: fix the dangerous assignment

2017-11-16 Thread Mao Zhongyi
On 11/17/2017 04:07 AM, Stefan Weil wrote: Am 16.11.2017 um 03:28 schrieb Mao Zhongyi: Cc: Peter Maydell Cc: Jason Wang Cc: Zhang Chen Cc: Li Zhijian Cc: Paolo Bonzini

Re: [Qemu-devel] [PATCH v8 10/14] migration: add postcopy migration of dirty bitmaps

2017-11-16 Thread John Snow
On 11/16/2017 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.11.2017 04:58, John Snow wrote: >> >> On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Postcopy migration of dirty bitmaps. Only named dirty bitmaps, >>> associated with root nodes and non-root named nodes are

[Qemu-devel] [QEMU-PPC] [PATCH V2] target/ppc: Update setting of cpu features to account for compat modes

2017-11-16 Thread Suraj Jitindar Singh
The device tree nodes ibm,arch-vec-5-platform-support and ibm,pa-features are used to communicate features of the cpu to the guest operating system. The properties of each of these are determined based on the selected cpu model and the availability of hypervisor features. Currently the

Re: [Qemu-devel] [PATCH v8 10/14] migration: add postcopy migration of dirty bitmaps

2017-11-16 Thread John Snow
On 11/16/2017 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +    /* if a block is zero we need to flush here since the network >>> + * bandwidth is now a lot higher than the storage device bandwidth. >>> + * thus if we queue zero blocks we slow down the migration. */ >> Can you

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH] target/ppc: Update setting of cpu features to account for compat modes

2017-11-16 Thread Suraj Jitindar Singh
On Thu, 2017-11-16 at 19:24 +0100, Greg Kurz wrote: > On Thu, 16 Nov 2017 15:16:07 +1100 > Suraj Jitindar Singh wrote: > > > The device tree nodes ibm,arch-vec-5-platform-support and ibm,pa- > > features > > are used to communicate features of the cpu to the guest

Re: [Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command

2017-11-16 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20171116052511.16236-1-caoxin...@huawei.com Subject: [Qemu-devel] [PATCH] ipmi: check ibe status before ibe outlen at ipmi_bmc_extern_handle_command === TEST SCRIPT BEGIN === #!/bin/bash #

[Qemu-devel] [PATCH v3 2/2] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

2017-11-16 Thread Daniel Henrique Barboza
This patch implements a test case for the scenario that was failing prior to the patch "migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END". This new test file 198 was derived from the test file 181 authored by Kevin Wolf. CC: Kevin Wolf CC: Max Reitz

[Qemu-devel] [PATCH v3 1/2] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-16 Thread Daniel Henrique Barboza
When migrating a VM with 'migrate_set_capability postcopy-ram on' a postcopy_state is set during the process, ending up with the state POSTCOPY_INCOMING_END when the migration is over. This postcopy_state is taken into account inside ram_load to check how it will load the memory pages. This same

[Qemu-devel] [PATCH v3 0/2] Fix savevm/loadvm after postcopy migration

2017-11-16 Thread Daniel Henrique Barboza
v3: - patch 1: added 'Reported-by' info in the commit msg. No code changes were made. - patch 2 *new*: a new qemu-iotest that verifies the behavior fixed in patch1. v2: - added helper functions to simplify the code Daniel Henrique Barboza (2): migration/ram.c: do not set 'postcopy_running' in

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-16 Thread John Snow
On 11/16/2017 10:54 AM, Alberto Garcia wrote: > On Wed 15 Nov 2017 05:31:20 PM CET, Anton Nefedov wrote: >>> I have the impression that one major source of headaches is the fact >>> that the reopen queue contains nodes that don't need to be reopened at >>> all. Ideally this should be detected

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread David Hildenbrand
On 16.11.2017 21:57, Christian Borntraeger wrote: > Please change the subject. In busy times I tend to ignore tcg patches. > This code is clearly kvm and tcg. > So what about "s390x/diag:" as prefix? Right, it was a fix for TCG, that's why I added TCG only. But it should have been purely s390x or

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qapi: block-core: Clarify events emitted by 'block-job-cancel'

2017-11-16 Thread John Snow
On 11/16/2017 04:14 AM, Kashyap Chamarthy wrote: > On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote: >> >> >> On 11/15/2017 04:54 PM, Kashyap Chamarthy wrote: >>> On Wed, Nov 15, 2017 at 02:15:57PM -0500, John Snow wrote: > > [...] > is it covered sufficiently in

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: test clearing unknown autoclear_features by qcow2

2017-11-16 Thread John Snow
On 11/10/2017 03:02 PM, Kevin Wolf wrote: > Am 10.11.2017 um 18:54 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Test clearing unknown autoclear_features by qcow2 on incoming >> migration. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> Hi all! >> >>

[Qemu-devel] [PATCH for-2.11] hw/net/eepro100: Fix endianness problem on big endian hosts

2017-11-16 Thread Thomas Huth
Since commit 1865e288a823c764cd4344d ("Fix eepro100 simple transmission mode"), the test/pxe-test is broken for the eepro100 device on big endian hosts. However, it seems like that commit did not introduce the problem, but just uncovered it: The EEPRO100State->tx.tbd_array_addr and

Re: [Qemu-devel] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again)

2017-11-16 Thread Christian Borntraeger
On 11/16/2017 06:05 PM, David Hildenbrand wrote: > Looks like the last fix + cleanup introduced another bug. (for now Linux > guests don't seem to care) - we store the crs into ars. > > Fixes: 947a38bd6f13 ("s390x/kvm: fix and cleanup storing CPU status") > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread Christian Borntraeger
Please change the subject. In busy times I tend to ignore tcg patches. This code is clearly kvm and tcg. So what about "s390x/diag:" as prefix? On 11/16/2017 06:05 PM, David Hildenbrand wrote: > Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when > the bios tries to switch to

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-16 Thread Christian Borntraeger
On 11/16/2017 06:23 PM, Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:05:23 +0100 > David Hildenbrand wrote: > >> First one also applies to KVM SIGP handling. The other two only >> apply to TCG (allowing to IPL from disk with more than 1 VCPU- I >> never tested that before).

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.11 3/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (MTTCG)

2017-11-16 Thread Thomas Huth
On 16.11.2017 18:05, David Hildenbrand wrote: > Currently, multi threaded TCG with > 1 VCPU gets stuck during IPL, when > the bios tries to switch to the loaded kernel via DIAG 308. > > As run_on_cpu() is used, we run into a deadlock after handling the reset. > We need the iolock (just like KVM).

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2.11 1/3] s390x: fix storing CPU status (again)

2017-11-16 Thread Thomas Huth
On 16.11.2017 18:05, David Hildenbrand wrote: > Looks like the last fix + cleanup introduced another bug. (for now Linux > guests don't seem to care) - we store the crs into ars. > > Fixes: 947a38bd6f13 ("s390x/kvm: fix and cleanup storing CPU status") > Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v5 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-11-16 Thread Changpeng Liu
This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with Qemu. The vhost-user-blk sample application should be used with Qemu vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s

[Qemu-devel] [PATCH v5 3/4] contrib/libvhost-user: enable virtio config space messages

2017-11-16 Thread Changpeng Liu
Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG/VHOST_USER_SET_CONFIG_FD messages in libvhost-user library, users can implement their own I/O target based on the library. This enable the virtio config space delivered between Qemu host device and the I/O target, also event notifier is added in

[Qemu-devel] [PATCH v5 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-11-16 Thread Changpeng Liu
This commit introduces a new vhost-user device for block, it uses a chardev to connect with the backend, same with Qemu virito-blk device, Guest OS still uses the virtio-blk frontend driver. To use it, start Qemu with command line like this: qemu-system-x86_64 \ -chardev

[Qemu-devel] [PATCH v5 0/4] *** Introduce a new vhost-user-blk host device to Qemu ***

2017-11-16 Thread Changpeng Liu
Although virtio scsi specification was designed as a replacement for virtio_blk, there are still many users using virtio_blk. Qemu 2.9 introduced a new device vhost user scsi which can process I/O in user space for virtio_scsi, this commit introduces a new vhost user block host device, which can

[Qemu-devel] [PATCH v5 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-11-16 Thread Changpeng Liu
Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration of vhost user devices, also vhost user devices can benefit from the messages to get/set virtio config space from/to the I/O target. For the purpose to support virtio config space change,

Re: [Qemu-devel] [PATCH] colo-compare: fix the dangerous assignment

2017-11-16 Thread Stefan Weil
Am 16.11.2017 um 03:28 schrieb Mao Zhongyi: > Cc: Peter Maydell > Cc: Jason Wang > Cc: Zhang Chen > Cc: Li Zhijian > Cc: Paolo Bonzini > Fixes:

Re: [Qemu-devel] [PATCH 0/4] Some trivial fixes, mostly comment typos

2017-11-16 Thread Emilio G. Cota
On Wed, Oct 18, 2017 at 18:01:39 -0400, Emilio G. Cota wrote: > A few trivial fixes that I embedded in a previous (unrelated) patchset. > Better to submit them separately as a standalone "trivial" patchset. *ping* Can someone please pick up patches 1, 3 and 4? Thanks, Emilio

[Qemu-devel] [Bug 1719984] Re: wrgsbase misemulated in x86_64-softmmu

2017-11-16 Thread Todd Eisenberger
Fix is in master: https://github.com/qemu/qemu/commit/e0dd5fd41a1a38766009f442967fab700d2d0550 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH for-2.11] MAINTAINERS: Add missing entry for eepro100 emulation

2017-11-16 Thread Stefan Weil
Signed-off-by: Stefan Weil --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ffd77b461c..83434e09af 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1183,6 +1183,11 @@ M: Dmitry Fleytman S: Maintained F:

Re: [Qemu-devel] [PULL for-2.11 0/1] Block patches

2017-11-16 Thread Peter Maydell
On 16 November 2017 at 16:36, Stefan Hajnoczi wrote: > The following changes since commit 8048082f7a11040a366942a2de8abb4c3d0020c9: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2017-11-15-1' into staging (2017-11-16 > 11:34:24 +) > > are

[Qemu-devel] [PATCH 2/2] vhost: restore avail index from vring used index on disconnection

2017-11-16 Thread Maxime Coquelin
vhost_virtqueue_stop() gets avail index value from the backend, except if the backend is not responding. It happens when the backend crashes, and in this case, internal state of the virtio queue is inconsistent, making packets to corrupt the vring state. With a Linux guest, it results in

[Qemu-devel] [PATCH 1/2] virtio: Add queue interface to restore avail index from vring used index

2017-11-16 Thread Maxime Coquelin
In case of backend crash, it is not possible to restore internal avail index from the backend value as vhost_get_vring_base callback fails. This patch provides a new interface to restore internal avail index from the vring used index, as done by some vhost-user backend on reconnection.

[Qemu-devel] [PATCH 0/2] virtio-net: Fix TX data discard on backend disconnection

2017-11-16 Thread Maxime Coquelin
This series fixes TX data discard when backend disconnects. On backend disconnection, QEMU cannot retrieve its internal avail index, which makes the virtio queue internal state inconsistent (last_avail_idx will always be 0, whereas used_idx is correct). It results in discarding TX data to

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH] target/ppc: Update setting of cpu features to account for compat modes

2017-11-16 Thread Greg Kurz
On Thu, 16 Nov 2017 15:16:07 +1100 Suraj Jitindar Singh wrote: > The device tree nodes ibm,arch-vec-5-platform-support and ibm,pa-features > are used to communicate features of the cpu to the guest operating > system. The properties of each of these are determined based

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread David Hildenbrand
On 16.11.2017 19:12, Alex Bennée wrote: > > David Hildenbrand writes: > >> On 16.11.2017 18:37, Alex Bennée wrote: >>> >>> David Hildenbrand writes: >>> Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when the bios tries to

Re: [Qemu-devel] [PATCH v8 02/14] block/dirty-bitmap: add locked version of bdrv_release_dirty_bitmap

2017-11-16 Thread John Snow
On 11/16/2017 03:56 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.11.2017 01:52, John Snow wrote: >> >> On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >>> It is needed to realize bdrv_dirty_bitmap_release_successor in >>> the following patch. >>> >> OK, but... >> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread Alex Bennée
David Hildenbrand writes: > On 16.11.2017 18:37, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when >>> the bios tries to switch to the loaded kernel via DIAG 308. >>> >>>

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread Alex Bennée
David Hildenbrand writes: > On 16.11.2017 18:37, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when >>> the bios tries to switch to the loaded kernel via DIAG 308. >>> >>>

Re: [Qemu-devel] [PATCH v2 1/2] Fix eepro100 simple transmission mode

2017-11-16 Thread Michael Nawrocki
On 11/16/2017 12:43 PM, Thomas Huth wrote: On 16.11.2017 17:59, Thomas Huth wrote: On 06.11.2017 21:35, Mike Nawrocki wrote: The simple transmission mode was treating the area immediately after the transmit command block (TCB) as if it were a transmit buffer descriptor, when in reality it is

Re: [Qemu-devel] Effect of qemu-img convert -m and -W options

2017-11-16 Thread Richard W.M. Jones
On Thu, Nov 16, 2017 at 05:30:48PM +, Stefan Hajnoczi wrote: > On Thu, Nov 16, 2017 at 3:10 PM, Richard W.M. Jones wrote: > > Both local filesystems, but on different SATA devices. > > Okay. I'm curious what the strace -f output looks like (only the > preadv(2)/pwritev(2)

Re: [Qemu-devel] [PATCH] hax-interface: Add BSD license

2017-11-16 Thread Eduardo Habkost
On Thu, Nov 16, 2017 at 07:47:44AM +0100, Stefan Weil wrote: > Am 16.11.2017 um 07:50 schrieb yu.n...@linux.intel.com: > > From: Yu Ning > > > > hax-interface.h defines the interface between the HAXM kernel > > module and the HAXM QEMU accelerator. The same code can be found

[Qemu-devel] [PATCH v2 6/7] s390x/pci: move the memory region write from pcistg

2017-11-16 Thread Pierre Morel
Let's move the memory region write from pcistg into a dedicated function. This allows us to prepare a later patch searching for subregions inside of the memory region. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao ---

[Qemu-devel] [PATCH v2 5/7] s390x/pci: move the memory region read from pcilg

2017-11-16 Thread Pierre Morel
Let's move the memory region read from pcilg into a dedicated function. This allows us to prepare a later patch. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 15 +++ 1 file changed, 11

[Qemu-devel] [PATCH v2 3/7] s390x/pci: rework PCI LOAD

2017-11-16 Thread Pierre Morel
Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-inst.c | 25 ++--- 1 file

[Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-16 Thread Pierre Morel
Enhance the fault detection. Fixup the precedence to check the destination path existance before checking for the source accessibility. Add the maxstbl entry to both the Query PCI Function Group response and the PCIBusDevice structure. Initialize the maxstbl to 128 per default until we get the

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread David Hildenbrand
On 16.11.2017 18:37, Alex Bennée wrote: > > David Hildenbrand writes: > >> Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when >> the bios tries to switch to the loaded kernel via DIAG 308. >> >> pause_all_vcpus()/resume_all_vcpus() should not be called

[Qemu-devel] [PATCH v2 1/7] s390x/pci: factor out endianess conversion

2017-11-16 Thread Pierre Morel
There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel ---

[Qemu-devel] [PATCH v2 7/7] s390x/pci: search for subregion inside the BARs

2017-11-16 Thread Pierre Morel
When dispatching memory access to PCI BAR region, we must look for possible subregions, used by the PCI device to map different memory areas inside the same PCI BAR. Since the data offset we received is calculated starting at the region start address we need to adjust the offset for the

[Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-16 Thread Pierre Morel
Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-inst.c | 39

[Qemu-devel] [PATCH v2 0/7] s390x/pci: Improve zPCI to cover more cases

2017-11-16 Thread Pierre Morel
This patch fixes the following BUG: Even a guest is able to detect virtio_pci device, the init function the Linux virtio_pci driver will hang because zPCI does not support the subregions used by virtio_pci. It follows that right now the PCI support is very limited (e.g. pass through of a host

Re: [Qemu-devel] [PATCH v2 1/2] Fix eepro100 simple transmission mode

2017-11-16 Thread Thomas Huth
On 16.11.2017 17:59, Thomas Huth wrote: > On 06.11.2017 21:35, Mike Nawrocki wrote: >> The simple transmission mode was treating the area immediately after the >> transmit command block (TCB) as if it were a transmit buffer descriptor, >> when in reality it is simply the packet data. This change

Re: [Qemu-devel] [PATCH v1 for-2.11 2/3] s390x/tcg: fix DIAG 308 with > 1 VCPU (single threaded TCG)

2017-11-16 Thread David Hildenbrand
On 16.11.2017 18:05, David Hildenbrand wrote: > Currently, single threaded TCG with > 1 VCPU gets stuck during IPL, when > the bios tries to switch to the loaded kernel via DIAG 308. > > pause_all_vcpus()/resume_all_vcpus() should not be called from a VCPU. > > And there is also no need for it.

[Qemu-devel] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-16 Thread Cleber Rosa
This variables has no real use. To avoid pretending it does, while still keeping the information, let's turn it into a comment. The format chosen is the one already being used on tests 149 and 194. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/001 | 5 ++---

[Qemu-devel] [PATCH 05/10] qemu-iotests: define functions used in _cleanup() before its use

2017-11-16 Thread Cleber Rosa
The functions used in _cleanup() come from common.rc, which currently gets sourced after _cleanup() is defined and registered as a signal handler. When _cleanup() is executed, it has no valid references to those functions, as BASH won't resolve the reference at that time. While at it, also fix

[Qemu-devel] [PATCH 09/10] qemu-iotests: remove unused "here" variable

2017-11-16 Thread Cleber Rosa
Another legacy variable that did not convince me it has any purpose whatsoever. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/001 | 1 - tests/qemu-iotests/002 | 1 - tests/qemu-iotests/003 | 1 - tests/qemu-iotests/004 | 1 - tests/qemu-iotests/005 | 1 -

[Qemu-devel] [PATCH 10/10] qemu-iotests: add section on how to write a new I/O test

2017-11-16 Thread Cleber Rosa
This adds some basic information on how to write a new test. I'm aware that some of the information in the wiki (Testing/QemuIoTests) could also belong here. Since copying content over won't generate much interesting feedback, the goal here is to get feedback on the sample_test_templates,

[Qemu-devel] [PATCH 04/10] qemu-iotests: include (source) filters from common.rc

2017-11-16 Thread Cleber Rosa
There's an explicit dependency from common.rc on common.filters, that is, it consumes functions defined there. Just like common.config is included in common.rc, it makes sense to also sense common.filter. This drops the requirement on individual tests to include common.filter, reducing the

[Qemu-devel] [PATCH 07/10] qemu-iotests: remove the concept of $seq.full (and boiler plate code)

2017-11-16 Thread Cleber Rosa
The $seq.full file, in theory, should contain the full output of a test error. In practice, it's only used on a single test, and the boiler plate code to clean it up plagues all other tests. Let's remove the concept altogether, and record the failure in the output itself for the one test using

[Qemu-devel] [PATCH 03/10] qemu-iotests: be strict with expected output

2017-11-16 Thread Cleber Rosa
The contract between runner (check) and test is one that accepts some minor differences in the expcted output, as the comparison method employed is a "diff -w". This is an exception to a clearer and more straightforward rule of just requiring the generated output to be *equal* (and not similar)

[Qemu-devel] [PATCH 01/10] qemu-iotests: make execution of tests agnostic to test type

2017-11-16 Thread Cleber Rosa
check makes a distinction on how it runs Python based tests. The current approach is inconsistent because: 1) a large number of Python tests are already set as executable files (eg: 030, 040, 041, 044, 045, 055, 056, 057, 065, 093, 118, 147, 149, 155, 165 and 194) 2) a smaller number of Python

[Qemu-devel] [PATCH 08/10] qemu-iotests: clean up double comment characters

2017-11-16 Thread Cleber Rosa
This is a syntactic only change, just to make it consistent with the style used on all other tests. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/048 | 37 ++--- tests/qemu-iotests/074 | 40 2 files

[Qemu-devel] [PATCH 00/10] I/O tests cleanups

2017-11-16 Thread Cleber Rosa
Hi all, This is a collection of cleanups, simplifications, and hopefully improvements to the I/O tests. Please don't mind the "change noise": this almost qualifies as a collection of trivial patches. It skips that category (of trivial patches) because it proposes a few conceptual changes to how

[Qemu-devel] [PATCH 02/10] qemu-iotests: fix filename containing checks

2017-11-16 Thread Cleber Rosa
Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/common.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

  1   2   3   >