[Qemu-devel] [PATCH v2 5/8] docker: warn users to use ubuntu16.04 for the LTS Xenial image

2018-01-15 Thread Philippe Mathieu-Daudé
deprecate the generic 'ubuntu' image, but stay backward incompatible Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 3 ++- tests/docker/dockerfiles/ubuntu.docker | 26 ++ tests/docker/dockerfiles/ubuntu16.04.docker | 16 +

[Qemu-devel] [PATCH v2 0/8] docker: update Ubuntu and Fedora images, deprecate old ones

2018-01-15 Thread Philippe Mathieu-Daudé
Hi, This series is to be clearer about which upstream version we are using. All "FROM distrib:latest" entries have now been removed and replaced by explicit "FROM distrib:version" ones. To keep backward compatibility, a warning is displayed to the user, suggesting which correct base image to use

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Eduardo Habkost
On Mon, Jan 15, 2018 at 03:25:18PM +0100, Jiri Denemark wrote: > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > CCing libvirt developers. > ... > > This case is slightly more problematic, however: the new feature > > is actually migratable (under very controlled circumstances) >

Re: [Qemu-devel] [RFC PATCH 2/3] acpi: implement aml_lless_equal

2018-01-15 Thread Igor Mammedov
On Fri, 12 Jan 2018 14:42:14 -0500 Stefan Berger wrote: > On 01/12/2018 10:17 AM, Marc-André Lureau wrote: > > 2018-01-10 19:35 GMT+01:00 Stefan Berger : > >> LLessEqualOp = LNotOp LGreaterOp > >> > >> Signed-off-by: Stefan Berger > > Reviewed-by: Marc-André Lureau > > Thanks. I added a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread Thomas Huth
On 15.01.2018 12:05, Greg Kurz wrote: > On Mon, 15 Jan 2018 10:30:53 +0100 > Thomas Huth wrote: > >> ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset > > Hi Thomas, > > Per curiosity. I understand that a 64-bit ppc CPU is expected to support > 32-bit ppc code, but does QEM

Re: [Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

2018-01-15 Thread Peter Maydell
On 10 January 2018 at 05:39, Richard Henderson wrote: > The code sequence we were generating was only good for unsigned > comparisons. For signed comparisions, use the sequence from gcc. > > Fixes booting of ppc64 firmware, with a patch changing the code > sequence for ppc comparisons. > > Signed

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Jiri Denemark
On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > CCing libvirt developers. ... > This case is slightly more problematic, however: the new feature > is actually migratable (under very controlled circumstances) > because of patch 2/2, but it is not migration-safe[1]. This > means lib

[Qemu-devel] [PATCH] ui: deprecate use of SDL 1.2 in favour of 2.0 series

2018-01-15 Thread Daniel P. Berrange
The SDL 2.0 release was made in Aug, 2013: https://www.libsdl.org/release/ That will soon be 4 + 1/2 years ago, which is enough time to consider the 2.0 series widely supported. Thus we deprecate the SDL 1.2 support, which will allow us to delete it in the last release of 2018. By this time, S

Re: [Qemu-devel] [PATCH v5 1/1] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

2018-01-15 Thread Kevin Wolf
Am 05.12.2017 um 14:35 hat Daniel Henrique Barboza geschrieben: > This patch implements a test case for the scenario that was failing > prior to the patch "migration/ram.c: do not set 'postcopy_running' in > POSTCOPY_INCOMING_END", commit acab30b85d. > > This new test file 201 was derived from the

[Qemu-devel] [PATCH v2 2/2] sdl: reorganize -no-frame support

2018-01-15 Thread Gerd Hoffmann
Drop no_frame flag from sdl_display_init argument list, use a global variable instead. This is temporary until -no-frame support is dropped altogether when we remove sdl1 support. Remove any traces of noframe from sdl2 code. It is just dead code as sdl2 doesn't support the SDL_NOFRAME window fla

[Qemu-devel] [PATCH v2 0/2] sdl: hotkey updates and cleanups

2018-01-15 Thread Gerd Hoffmann
Gerd Hoffmann (2): sdl: use ctrl-alt-g as grab hotkey sdl: reorganize -no-frame support include/sysemu/sysemu.h | 1 + include/ui/console.h| 5 ++--- ui/sdl.c| 38 +++--- ui/sdl2.c | 34 -- v

[Qemu-devel] [PATCH v2 1/2] sdl: use ctrl-alt-g as grab hotkey

2018-01-15 Thread Gerd Hoffmann
Be consistent with gtk and cocoa. Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 30 +- ui/sdl2.c | 27 +++ 2 files changed, 24 insertions(+), 33 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 7b71a9ac58..9c664c86a0 100644 --- a/ui/sdl.c ++

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-15 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 03:07:15PM +0100, Kevin Wolf wrote: > Am 15.01.2018 um 14:51 hat Daniel P. Berrange geschrieben: > > On Mon, Jan 15, 2018 at 02:38:48PM +0100, Kevin Wolf wrote: > > > Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > > > > On Thu, Jan 11, 2018 at 08:52:17PM +0100,

Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages

2018-01-15 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 08:25:50PM +, Stefan Hajnoczi wrote: > This series improves the tracetool error messages to make them more > user-friendly. > > Stefan Hajnoczi (3): > tracetool: prefix parse errors with line numbers > tracetool: clarify that "formats" means "format strings" > tra

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-15 Thread Kevin Wolf
Am 15.01.2018 um 14:51 hat Daniel P. Berrange geschrieben: > On Mon, Jan 15, 2018 at 02:38:48PM +0100, Kevin Wolf wrote: > > Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > > > On Thu, Jan 11, 2018 at 08:52:17PM +0100, Kevin Wolf wrote: > > > > Signed-off-by: Kevin Wolf > > > > --- >

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Eduardo Habkost
CCing libvirt developers. On Mon, Jan 15, 2018 at 10:33:35AM +0100, Paolo Bonzini wrote: > On 15/01/2018 08:19, Kang, Luwei wrote: > >> If you are forwarding host info directly to the guest, the feature > >> is not migration-safe. The new feature needs to be added to > >> feature_word_info[FEAT_

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 10:51 AM, Peter Maydell wrote: > On 13 January 2018 at 05:07, Philippe Mathieu-Daudé wrote: >> Since v6: >> - addressed Peter reviews >> - do not use an unique Property[] for both sysbus/pci >> Peter didn't recommend me to use the qdev_property_add_static() API since >> it

Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages

2018-01-15 Thread Stefan Hajnoczi
On Wed, Jan 10, 2018 at 02:48:16PM -0600, Eric Blake wrote: > On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote: > > This series improves the tracetool error messages to make them more > > user-friendly. > > > > Stefan Hajnoczi (3): > > tracetool: prefix parse errors with line numbers > > tracetoo

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-15 Thread Stefan Hajnoczi
On Sun, Jan 14, 2018 at 03:36:19AM +, Wang, Wei W wrote: > On Friday, January 12, 2018 6:38 PM, Stefan Hajnoczi wrote: > > On Fri, Jan 12, 2018 at 02:44:00PM +0800, Wei Wang wrote: > > > On 01/11/2018 05:56 PM, Stefan Hajnoczi wrote: > > > > On Thu, Jan 11, 2018 at 6:31 AM, Wei Wang > > wrote:

Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/12/2018 10:10 AM, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Type: series > Message-id: 20180112125000.27256-1-f4...@a

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-15 Thread Stefan Hajnoczi
On Mon, Jan 15, 2018 at 02:56:31PM +0800, Jason Wang wrote: > On 2018年01月12日 18:18, Stefan Hajnoczi wrote: > > > And what's more important, according to the kvm 2016 slides of vhost-pci, > > > the motivation of vhost-pci is not building SDN but a chain of VNFs. So > > > bypassing the central vswitc

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-15 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 02:38:48PM +0100, Kevin Wolf wrote: > Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > > On Thu, Jan 11, 2018 at 08:52:17PM +0100, Kevin Wolf wrote: > > > Signed-off-by: Kevin Wolf > > > --- > > > qapi/block-core.json | 33 - > >

Re: [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1)

2018-01-15 Thread Peter Maydell
On 13 January 2018 at 05:07, Philippe Mathieu-Daudé wrote: > Since v6: > - addressed Peter reviews > - do not use an unique Property[] for both sysbus/pci > Peter didn't recommend me to use the qdev_property_add_static() API since > it is only used by the ARM cpus and may be due for remo

Re: [Qemu-devel] [PATCH v7 13/14] sdhci: fix the PCI device, using the PCI address space for DMA

2018-01-15 Thread Peter Maydell
On 13 January 2018 at 05:07, Philippe Mathieu-Daudé wrote: > While SysBus devices can use the get_system_memory() address space, > PCI devices should use the bus master address space for DMA. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > Should we check for the

Re: [Qemu-devel] [PATCH v2 1/3] xlnx-zynqmp-rtc: Initial commit

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 10:25 AM, Peter Maydell wrote: > On 12 January 2018 at 22:36, Alistair Francis > wrote: >> Initial commit of the ZynqMP RTC device. >> >> Signed-off-by: Alistair Francis >> --- >> V2: >> - Delete unused realise function >> - Remove DB_PRINT() >> >> hw/timer/Makefile.objs

Re: [Qemu-devel] [PATCH] LEON3 IRQMP: Fix IRQ software ack

2018-01-15 Thread Jean-Christophe Dubois
Le 2018-01-15 12:09, Fabien Chouteau a écrit : On 12/01/2018 15:10, Jean-Christophe Dubois wrote: Le 2018-01-12 11:55, Fabien Chouteau a écrit : On 11/01/2018 13:35, Jean-Christophe Dubois wrote: Thanks Fabien, Now, as a side question, could you tell me which reference LEON3 platform is impl

Re: [Qemu-devel] [PATCH v2 03/21] RISC-V CPU Core Definition

2018-01-15 Thread Igor Mammedov
On Wed, 10 Jan 2018 15:46:22 -0800 Michael Clark wrote: > Add CPU state header, CPU definitions and initialization routines > > Signed-off-by: Michael Clark > --- > target/riscv/cpu.c | 391 + > target/riscv/cpu.h | 271

Re: [Qemu-devel] [PATCH v4] ucontext: annotate coroutine stack for ASAN

2018-01-15 Thread Stefan Hajnoczi
On Fri, Jan 12, 2018 at 03:17:45PM +0100, Marc-André Lureau wrote: > It helps ASAN to detect more leaks on coroutine stacks, as found in > the following patch. > > A similar work would need to be done for sigaltstack & windows fibers > to have similar coverage. Since ucontext is preferred, I didn'

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-15 Thread Kevin Wolf
Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > On Thu, Jan 11, 2018 at 08:52:17PM +0100, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 33 - > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff --git a

Re: [Qemu-devel] [PATCH v2 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 22:37, Alistair Francis wrote: > Allow the guest to determine the time set from the QEMU command line. > > This includes adding a trace event to debug the new time. > > Signed-off-by: Alistair Francis > --- > - Convert DB_PRINT() macro to trace > > hw/timer/trace-events

Re: [Qemu-devel] [PATCH v2 3/3] xlnx-zynqmp: Connect the RTC device

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 22:37, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > hw/arm/xlnx-zynqmp.c | 14 ++ > include/hw/arm/xlnx-zynqmp.h | 2 ++ > 2 files changed, 16 insertions(+) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index 3256

Re: [Qemu-devel] [PATCH v2 15/21] RISC-V Spike Machines

2018-01-15 Thread Igor Mammedov
On Wed, 10 Jan 2018 15:46:34 -0800 Michael Clark wrote: > RISC-V machines compatble with Spike aka riscv-isa-sim, the RISC-V > Instruction Set Simulator. The following machines are implemented: > > - 'spike_v1.9'; HTIF console, config-string, Privileged ISA Version 1.9.1 > - 'spike_v1.10'; HTIF

Re: [Qemu-devel] [PATCH v2 1/3] xlnx-zynqmp-rtc: Initial commit

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 22:36, Alistair Francis wrote: > Initial commit of the ZynqMP RTC device. > > Signed-off-by: Alistair Francis > --- > V2: > - Delete unused realise function > - Remove DB_PRINT() > > hw/timer/Makefile.objs | 1 + > hw/timer/xlnx-zynqmp-rtc.c | 218 >

Re: [Qemu-devel] [PATCH] file-posix: refuse to open directories

2018-01-15 Thread Kevin Wolf
Am 13.01.2018 um 00:30 hat John Snow geschrieben: > On 12/22/2017 08:00 AM, Kevin Wolf wrote: > > Am 21.12.2017 um 23:44 hat John Snow geschrieben: > >> I don't think there's a legitimate reason to open directories as if > >> they were files. This prevents QEMU from opening and attempting to probe

Re: [Qemu-devel] [PATCH v2 12/21] RISC-V HART Array

2018-01-15 Thread Igor Mammedov
On Wed, 10 Jan 2018 15:46:31 -0800 Michael Clark wrote: > Holds the state of a heterogenous array of RISC-V hardware threads. > > Signed-off-by: Michael Clark > --- > hw/riscv/riscv_hart.c | 95 > +++ > include/hw/riscv/riscv_hart.h | 45 +++

Re: [Qemu-devel] [PATCH 0/2] target/arm: split out vfp_expand_imm

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 19:07, Richard Henderson wrote: > On 01/12/2018 09:22 AM, Peter Maydell wrote: >>> Richard Henderson (2): >>> target/arm: Split out vfp_expand_imm >>> target/arm: Add fp16 support to vfp_expand_imm >>> >>> target/arm/translate-a64.c | 49 >>>

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:53 AM, Daniel P. Berrange wrote: > On Mon, Jan 15, 2018 at 07:47:29AM -0300, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: >>> Fedora has switched to Python 3 by default, so it makes sense to use that >>> for testing QEMU builds

Re: [Qemu-devel] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread Peter Maydell
On 15 January 2018 at 09:30, Thomas Huth wrote: > (off-topic question: Do we still need a separate ppcemb-softmmu nowadays? > It seemed to be useful 10 years ago when everybody was doing KVM on > embedded PPC, but these days seem to be pretty much over now, so IMHO > just using ppc-softmmu for emb

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-01-15 Thread Stefan Hajnoczi
On Thu, Jan 11, 2018 at 03:25:56PM -0800, Alistair Francis wrote: > On Wed, Jan 10, 2018 at 4:52 AM, Stefan Hajnoczi wrote: > > On Tue, Jan 9, 2018 at 9:45 PM, Alistair Francis > > wrote: > >> Can anyone who has done this before chime in. > >> > >> What do you think about getting someone to clea

Re: [Qemu-devel] question: I found a qemu crash about migration

2018-01-15 Thread Dr. David Alan Gilbert
* Matthew Schumacher (mat...@aptalaska.net) wrote: > Am 28.09.2017 um 19:01 hat Dr. David Alan Gilbert geschrieben: > > Hi, > > This is a 'fun' bug; I had a good chat to kwolf about it earlier. > > A proper fix really needs to be done together with libvirt so that we > > can sequence: > >a)

Re: [Qemu-devel] [PATCH] tap: close fd conditionally when error occured

2018-01-15 Thread Zhoujian (jay)
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, January 15, 2018 3:21 PM > To: Zhoujian (jay) ; qemu-devel@nongnu.org > Cc: m...@redhat.com; imamm...@redhat.com; Huangweidong (C) > ; wangxin (U) ; Gonglei > (Arei) > Subject: Re: [PATCH] tap: close fd co

Re: [Qemu-devel] [PATCH 0/2] linux-user: Fix race between threads in page_unprotect()

2018-01-15 Thread Laurent Vivier
Le 15/01/2018 à 13:48, Peter Maydell a écrit : > On 28 November 2017 at 14:35, Peter Maydell wrote: >> If multiple guest threads in user-mode emulation write to a >> page which QEMU has marked read-only because of cached TCG >> translations, the threads can race in page_unprotect: > >> Peter Mayd

Re: [Qemu-devel] [PATCH 0/2] linux-user: Fix race between threads in page_unprotect()

2018-01-15 Thread Peter Maydell
On 28 November 2017 at 14:35, Peter Maydell wrote: > If multiple guest threads in user-mode emulation write to a > page which QEMU has marked read-only because of cached TCG > translations, the threads can race in page_unprotect: > Peter Maydell (2): > linux-user: Propagate siginfo_t through to

Re: [Qemu-devel] [PATCH 0/7] CPU model updates for CVE-2017-5715 (Spectre variant #2)

2018-01-15 Thread Eduardo Habkost
On Tue, Jan 09, 2018 at 01:45:12PM -0200, Eduardo Habkost wrote: > This series adds support for the new IA32_SPEC_CTRL MSR on Intel > CPU models. The new MSR and the spec-ctrl CPUID bit > (CPUID[EAX=7,ECX=0].EDX[bit 26]) were introduced by a recent > Intel microcode updated and can be used by OSes

Re: [Qemu-devel] RFE for patchew docker result reporting

2018-01-15 Thread Cornelia Huck
On Mon, 15 Jan 2018 11:48:41 + "Daniel P. Berrange" wrote: > Currently if I look at the patchew website for build logs, the 'docker' > job results are listed as a single expandable item. > > Patchew runs 3 separate docker builds, however, and there's a tonne of > output to scroll through to

Re: [Qemu-devel] [RFC PATCH 1/3] vfio: ccw: introduce schib region

2018-01-15 Thread Cornelia Huck
On Mon, 15 Jan 2018 10:50:00 +0100 Pierre Morel wrote: > On 11/01/2018 04:04, Dong Jia Shi wrote: > > This introduces a new region for vfio-ccw to provide subchannel > > information for user space. > > > > Signed-off-by: Dong Jia Shi > > --- > > drivers/s390/cio/vfio_ccw_fsm.c | 21 +++

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/4] Reset SD cards attached to legacy-API controllers

2018-01-15 Thread Peter Maydell
On 9 January 2018 at 16:13, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 01/09/2018 11:01 AM, Peter Maydell wrote: >> It turns out that we don't reset the SD card model if it's >> attached to a legacy-API controller. For new-style controllers >> where the SD card object is attached to an SD_BU

[Qemu-devel] [PATCH] tests/boot-serial-test: fix powernv support

2018-01-15 Thread Cédric Le Goater
Recent commit introduced the firmware image skiboot 5.9 which has a different first line ouput. Signed-off-by: Cédric Le Goater --- tests/boot-serial-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index dd3828c49b38.

Re: [Qemu-devel] [PATCH 1/3] hw/arm/virt: Add virt-2.12 machine type

2018-01-15 Thread Peter Maydell
On 12 December 2017 at 14:39, Andrew Jones wrote: > On Fri, Dec 08, 2017 at 03:02:06PM +, Peter Maydell wrote: >> Add virt-2.12 machine type. >> >> Signed-off-by: Peter Maydell >> --- >> include/hw/compat.h | 3 +++ >> hw/arm/virt.c | 19 +-- >> 2 files changed, 20 ins

Re: [Qemu-devel] [PATCH 3/7] i386: Add spec-ctrl CPUID bit

2018-01-15 Thread Eduardo Habkost
On Sat, Jan 13, 2018 at 03:04:44AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Qemu-devel > > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > > Behalf Of Eduardo Habkost > > Sent: Tuesday, January 09, 2018 11:45 PM > > To: qemu-devel@nongnu.org > > C

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread BALATON Zoltan
On Mon, 15 Jan 2018, Thomas Huth wrote: ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset of ppcemb-softmmu. But since the config files are currently independent from each other, we missed to define some CONFIG switches in the super- sets: CONFIG_SUNGEM is missing from the pp

[Qemu-devel] [PULL 26/27] migration: remove some block_cleanup_parameters()

2018-01-15 Thread Juan Quintela
From: Peter Xu Keep the one in migrate_fd_cleanup() would be enough. Removing the other two. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/migration/migration.c b/migration/migra

Re: [Qemu-devel] [PATCH] ppc/pnv: Update skiboot firmware image

2018-01-15 Thread Cédric Le Goater
On 01/15/2018 01:07 PM, Cédric Le Goater wrote: > This is skiboot 5.9 (commit e0ee24c2). It brings improved POWER9 > support among many other things. Built from submodule. I just noticed that unit test ppc64/boot-serial/powernv needs a change to take into account the first output line. I will sen

[Qemu-devel] [PULL 22/27] migration: use switch at the end of migration

2018-01-15 Thread Juan Quintela
From: Peter Xu It converts the old if clauses into switch, explicitly mentions the possible migration states. The old nested "if"s are not clear on what we do on different states. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 44

[Qemu-devel] [PULL 27/27] migration: remove notify in fd_error

2018-01-15 Thread Juan Quintela
From: Peter Xu It is already called in migrate_fd_cleanup. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 47367cffae..d3a1c494c0 1

[Qemu-devel] [PULL 25/27] migration: put the finish part into a new function

2018-01-15 Thread Juan Quintela
From: Peter Xu This patch only moved the last part of migration_thread() into a new function migration_iteration_finish() to make it much shorter. With previous works to remove some local variables, now it's fairly easy to do that. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off

[Qemu-devel] [PULL 23/27] migration: cleanup stats update into function

2018-01-15 Thread Juan Quintela
From: Peter Xu We have quite a few lines in migration_thread() that calculates some statistics for the migration interations. Isolate it into a single function to improve readability. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c |

[Qemu-devel] [PULL 24/27] migration: major cleanup for migrate iterations

2018-01-15 Thread Juan Quintela
From: Peter Xu The major work for migration iterations are to move RAM/block/... data via qemu_savevm_state_iterate(). Generalize those part into a single function. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 90 +++

[Qemu-devel] [PULL 20/27] migration: introduce downtime_start

2018-01-15 Thread Juan Quintela
From: Peter Xu Introduce MigrationState.downtime_start to replace the local variable "start_time" in migration_thread to avoid passing things around. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 12 migration/migrati

[Qemu-devel] [PULL 16/27] migration: qemu_savevm_state_cleanup() in cleanup

2018-01-15 Thread Juan Quintela
From: Peter Xu Moving existing callers all into migrate_fd_cleanup(). It simplifies migration_thread() a bit. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --gi

[Qemu-devel] [PULL 21/27] migration: introduce migrate_calculate_complete

2018-01-15 Thread Juan Quintela
From: Peter Xu Generalize the calculation part when migration complete into a function to simplify migration_thread(). Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 31 --- 1 file changed, 20 insertions

[Qemu-devel] [PULL 18/27] migration: split use of MigrationState.total_time

2018-01-15 Thread Juan Quintela
From: Peter Xu It was used either to: 1. store initial timestamp of migration start, and 2. store total time used by last migration Let's provide two parameters for each of them. Mix use of the two is slightly misleading. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Jua

[Qemu-devel] [PULL 15/27] migration: assert colo instead of check

2018-01-15 Thread Juan Quintela
From: Peter Xu When reaching here if we are still "active" it means we must be in colo state. After a quick discussion offlist, we decided to use the safer error_report(). Finally I want to use "switch" here rather than lots of complicated if clauses. Signed-off-by: Peter Xu Reviewed-by: Juan

Re: [Qemu-devel] [PATCH qemu v2] kvm: Add kvm_set_user_memory tracepoint

2018-01-15 Thread Paolo Bonzini
On 15/12/2017 06:23, Alexey Kardashevskiy wrote: > This adds a tracepoint to trace the KVM_SET_USER_MEMORY_REGION ioctl > parameters which is quite useful for debugging VFIO memory regions > being actually registered with KVM. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * add

[Qemu-devel] [PULL 14/27] migration: finalize current_migration object

2018-01-15 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy current_migration has .instance_finalize callback, but it is not called, because nobody unrefs current_migration. Fix that. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- includ

[Qemu-devel] [PULL 13/27] migration: Guard ram_bytes_remaining against early call

2018-01-15 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Calling ram_bytes_remaining during the early part of setup is unsafe because the ram_state isn't yet initialised. This can happen in the sequence: migrate migrate_cancel info migrate if the migrate sticks trying to connect (e.g. to an unresponsive destina

[Qemu-devel] [PULL 19/27] migration: move vm_old_running into global state

2018-01-15 Thread Juan Quintela
From: Peter Xu Firstly, it was passed around. Let's just move it into MigrationState just like many other variables as state of migration, renaming it to vm_was_running. One thing to mention is that for postcopy, we actually don't need this knowledge at all since postcopy can't resume a VM even

[Qemu-devel] [PULL 06/27] migration: fix analyze-migration.py script with radix table

2018-01-15 Thread Juan Quintela
From: Laurent Vivier Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") the HTAB migration stream contains a header set to "-1", meaning there is no HPT. Teach analyze-migration.py to ignore the section in this case. Without this fix, the script fails with a dump from a

[Qemu-devel] [PULL 12/27] migration: add postcopy total blocktime into query-migrate

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migr

[Qemu-devel] [PULL 11/27] migration: add blocktime calculation into migration-test

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov This patch just requests blocktime calculation, and check it in case when UFFD_FEATURE_THREAD_ID feature is set on the host. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- tests/migration

[Qemu-devel] [PULL 04/27] docs: Convert migration.txt to rst

2018-01-15 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Mostly just manual conversion with very minor fixes. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrange Reviewed-by: Kashyap Chamarthy Reviewed-by: Peter Xu Signed-off-by: Juan Quintela --- docs/devel/{migration.txt => migration.rst} | 470

[Qemu-devel] [PULL 09/27] migration: calculate vCPU blocktime on dst side

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keep

[Qemu-devel] [PULL 17/27] migration: remove "enable_colo" var

2018-01-15 Thread Juan Quintela
From: Peter Xu It's only used once, clean it up a bit. Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 02d8bc07b1..0b513c2020 100644 --- a/m

[Qemu-devel] [PULL 10/27] migration: postcopy_blocktime documentation

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- docs/devel/migration.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.

[Qemu-devel] [PULL 03/27] migration: free addr in the same function that we created it

2018-01-15 Thread Juan Quintela
Otherwise, we can't use it after calling socket_start_incoming_migration Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/socket.c b/migration/socket.c index dee869044a..3a8232dd2d 100644

[Qemu-devel] [PULL 08/27] migration: add postcopy blocktime ctx into MigrationIncomingState

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case this feature is provided by kernel. PostcopyBlocktimeContext is encapsulated inside postcopy-ram.c, due to it being a postcopy-only feature. Also it defines PostcopyBlocktimeContext's instance live

[Qemu-devel] [PULL 07/27] migration: introduce postcopy-blocktime capability

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 05/27] migration: free result string

2018-01-15 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reported-by: Peter Xu --- tests/migration-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index be598d3257..799e24ebc6 100644 --- a/tests/migration-test.

[Qemu-devel] [PULL 00/27] Migration pull

2018-01-15 Thread Juan Quintela
9:29 +) are available in the Git repository at: git://github.com/juanquintela/qemu.git tags/migration/20180115 for you to fetch changes up to 816306826a45f4d15352e32d157172af3a35899f: migration: remove notify in fd_error (2018-01-15 12:4

[Qemu-devel] [PULL 02/27] migration: print features as on off

2018-01-15 Thread Juan Quintela
Once there, do one thing for line Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 8d2372394c..1

[Qemu-devel] [PULL 01/27] migration: Use proper types in json

2018-01-15 Thread Juan Quintela
We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. This change only happens for HMP. QMP always use bytes and similar. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- hmp.c | 22 +++---

[Qemu-devel] [Bug 1708462] Re: Support Python 3 to build

2018-01-15 Thread Daniel Berrange
Two patches series posted in Aug last year: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg03642.html https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06528.html An updated series covering both of those, and also turning on tests https://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] RFE for patchew docker result reporting

2018-01-15 Thread Daniel P. Berrange
Currently if I look at the patchew website for build logs, the 'docker' job results are listed as a single expandable item. Patchew runs 3 separate docker builds, however, and there's a tonne of output to scroll through to find which one actually failed. Thus, my RFE is to split the build log up

Re: [Qemu-devel] [PULL 0/5] slirp updates

2018-01-15 Thread Peter Maydell
On 14 January 2018 at 17:20, Samuel Thibault wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 7398166ddf7c6dbbc9cae6ac69bb2feda14b40ac: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vnc-20180112-pull-request' into s

Re: [Qemu-devel] [PATCH] fw_cfg: don't use DMA mapping for fw_cfg device

2018-01-15 Thread Marc-Andre Lureau
Hi On Mon, Jan 15, 2018 at 9:55 AM, Peter Xu wrote: > fw_cfg device does not need IOMMU protection, so use physical addresses > always. That's how QEMU implements fw_cfg. Otherwise we'll see call > traces during boot when vIOMMU is enabled in guest: > > [1.018306] [ cut here ]--

Re: [Qemu-devel] [PATCH] LEON3 IRQMP: Fix IRQ software ack

2018-01-15 Thread Fabien Chouteau
On 12/01/2018 15:10, Jean-Christophe Dubois wrote: > Le 2018-01-12 11:55, Fabien Chouteau a écrit : >> On 11/01/2018 13:35, Jean-Christophe Dubois wrote: >>> Thanks Fabien, >>> >>> Now, as a side question, could you tell me which reference LEON3 platform >>> is implemented by Qemu in leon3_generic

Re: [Qemu-devel] [RFC PATCH 0/3] add helpers to be more explicit when using QOM abstract parent hooks

2018-01-15 Thread Paolo Bonzini
On 14/01/2018 03:04, Philippe Mathieu-Daudé wrote: > Hi, > > Learning how to implement QOM devices I found the pattern changing parent > hooks > when the parent is abstract not trivial to understand. > > This series add few helpers to have this pattern more explicit. > > Those functions deserve

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread Greg Kurz
On Mon, 15 Jan 2018 10:30:53 +0100 Thomas Huth wrote: > ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset Hi Thomas, Per curiosity. I understand that a 64-bit ppc CPU is expected to support 32-bit ppc code, but does QEMU really need to emulate setups that likely never exist

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

2018-01-15 Thread Mihail Abakumov
Paolo Bonzini писал 2018-01-12 11:27: On 11/12/2017 14:21, Mihail Abakumov wrote: How it works: The WinDbg debugger has the possibility of connecting to a remote debug service (Kdsrv.exe) in the Windows kernel. Therefore, it is possible to connect to the guest system running in the QEMU emulat

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

2018-01-15 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 07:47:29AM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > > Fedora has switched to Python 3 by default, so it makes sense to use that > > for testing QEMU builds, so we get testing of Python 3 compatibility. > > I'

Re: [Qemu-devel] [PULL v2 00/52] Misc patches for 2017-01-12

2018-01-15 Thread Philippe Mathieu-Daudé
Hi Paolo, On 01/15/2018 07:37 AM, Peter Maydell wrote: > On 12 January 2018 at 13:42, Paolo Bonzini wrote: >> I'll drop that patch. > > I'm assuming you'll send a new pull req cover letter email > when you've done that (so this one is leaving my queue of > things to do). If you send an new PR c

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

2018-01-15 Thread Philippe Mathieu-Daudé
Hi Daniel, On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Fedora has switched to Python 3 by default, so it makes sense to use that > for testing QEMU builds, so we get testing of Python 3 compatibility. I'd rather keep Fedora 25 with Python 2, and use Python 3 in Fedora 27. If you agree, I

Re: [Qemu-devel] [PATCH v3 08/13] scripts: ensure signrom treats data as bytes

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/signrom.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/signrom.py b/scripts/signrom.py > index d1dabe0240..0497a1c

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-15 Thread Wei Wang
On 01/15/2018 04:34 PM, Jason Wang wrote: On 2018年01月15日 15:59, Wei Wang wrote: On 01/15/2018 02:56 PM, Jason Wang wrote: On 2018年01月12日 18:18, Stefan Hajnoczi wrote: I just fail understand why we can't do software defined network or storage with exist virtio device/drivers (or are the

Re: [Qemu-devel] [PATCH 1/2] target/ppc: Clarify compat mode max_threads value

2018-01-15 Thread joserz
On Mon, Jan 15, 2018 at 06:27:14PM +1100, David Gibson wrote: > We recently had some discussions that were sidetracked for a while, because > nearly everyone misapprehended the purpose of the 'max_threads' field in > the compatiblity modes table. It's all about guest expectations, not host > expec

Re: [Qemu-devel] [PATCH v3 04/13] qapi: adapt to moved location of StringIO module in py3

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/qapi.py | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 7ec2e00b2c..eaa63a58be 10

Re: [Qemu-devel] [PATCH v3 07/13] qapi: ensure stable sort ordering when checking QAPI entities

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Some early python 3.x versions will have different default > ordering when calling the 'values()' method on a dict, compared > to python 2.x and later 3.x versions. Explicitly sort the items > to get a stable ordering. > > Signed-off-by: Daniel P

Re: [Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

2018-01-15 Thread Daniel P. Berrange
On Fri, Dec 22, 2017 at 05:25:29PM +0200, Miika S wrote: > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > Signed-off-by: Miika S > --- > hw/input/virtio-input-hid.c | 7 +++ > qapi/ui.json| 5 - > ui/keycodemapdb | 2 +- > 3 files

Re: [Qemu-devel] [PULL v2 00/52] Misc patches for 2017-01-12

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 13:42, Paolo Bonzini wrote: > I'll drop that patch. I'm assuming you'll send a new pull req cover letter email when you've done that (so this one is leaving my queue of things to do). thanks -- PMM

Re: [Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > The OrderedDict class appeared in the 'collections' module > from python 2.7 onwards, so use that in preference to our > local backport if available. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/q

<    1   2   3   4   5   >