On 16.02.2018 23:07, Collin L. Walling wrote:
[...]
> +/**
> + * uitoa:
> + * @num: an integer (base 10) to be converted.
> + * @str: a pointer to a string to store the conversion.
> + * @len: the length of the passed string.
> + *
> + * Given an integer @num, convert it to a string. The string
What kind of exeception are you seeing here exactly? Can you still
reproduce it with the latest version of QEMU?
** Information type changed from Private Security to Public
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of
On 16.02.2018 23:07, Collin L. Walling wrote:
> Some ECKD bootmap code was using structs designed for SCSI.
> Even though this works, it confuses readability. Add a new
> BootMapTable struct to assist with readability in bootmap
> entry code. Also:
>
> - replace ScsiMbr in ECKD code with
ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity
domain of a NVDIMM SPA range must match with corresponding entry in
SRAT table.
The address ranges of vNVDIMM in QEMU are allocated from the
hot-pluggable address space, which is entirely covered by one SRAT
memory affinity
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1587970
Title:
QEMU
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1490853
Title:
qemu
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1731588
Title:
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1721187
Title:
install
Not all arches implement this, and the kernel doesn't require them to.
Add ifdef logic to disable it when not available.
Signed-off-by: Mike Frysinger
---
linux-user/syscall.c | 4
1 file changed, 4 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
Not all arches implement this, and the kernel doesn't require them to.
Add ifdef logic to disable it when not available.
Signed-off-by: Mike Frysinger
---
linux-user/syscall.c| 4
target/bfin/op_helper.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
On 2/16/18 9:47 AM, Dr. David Alan Gilbert wrote:
> * Brijesh Singh (brijesh.si...@amd.com) wrote:
>> The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory
>> region using the VM Encryption Key created using LAUNCH_START.
>>
>> Cc: Paolo Bonzini
>> Cc:
On Tue, Jan 9, 2018 at 1:10 PM, Wei Wang wrote:
> From: Matthew Wilcox
>
> The eXtensible Bitmap is a sparse bitmap representation which is
> efficient for set bits which tend to cluster. It supports up to
> 'unsigned long' worth of bits.
>
On Fri, Feb 16, 2018 at 8:30 PM, Matthew Wilcox wrote:
> On Fri, Feb 16, 2018 at 07:44:50PM +0200, Andy Shevchenko wrote:
>> On Tue, Jan 9, 2018 at 1:10 PM, Wei Wang wrote:
>> > From: Matthew Wilcox
>> >
>> > The eXtensible
Signed-off-by: Emilio G. Cota
---
target/s390x/translate.c | 170 ---
1 file changed, 86 insertions(+), 84 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index dd504a1..2b27a69 100644
---
The only non-trivial modification is the use of DISAS_TOO_MANY
in the same way is used by the generic translation loop.
Signed-off-by: Emilio G. Cota
---
target/s390x/translate.c | 1267 +++---
1 file changed, 632 insertions(+), 635
Notes:
- Kept ctx.pc and ctx.next_pc; it would be very confusing
to have ctx.base.pc_next and ctx.next_pc !
Instead, just updated ctx.base.pc_next where relevant.
- Did not convert num_insns and is_jmp, since the corresponding
code will go away in the next patch.
- Avoided a checkpatch
Tested with the "Moon Buggy" image:
http://www.qemu-advent-calendar.org/2014/#day-22
Thanks,
Emilio
** Changed in: qemu
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/589315
Title:
qemu: Improve error reporting when migration can't connect
Status in
On 16.02.2018 11:55, BALATON Zoltan wrote:
> On Fri, 16 Feb 2018, Thomas Huth wrote:
>> On 15.02.2018 22:27, BALATON Zoltan wrote:
>>> Remaining patches for Sam460ex emulation. The original cover letter
>>> with more details is here:
>>>
>>>
Read the stage2 boot loader data block-by-block. We scan the
current block for the string "zIPL" to detect the start of the
boot menu banner. We then load the adjacent blocks (previous
block and next block) to account for the possibility of menu
data spanning multiple blocks.
Signed-off-by:
When the boot menu options are present and the guest's
disk has been configured by the zipl tool, then the user
will be presented with an interactive boot menu with
labeled entries. An example of what the menu might look
like:
zIPL v1.37.1-build-20170714 interactive boot menu.
0. default
Implements an sclp_read function to capture input from the
console and a wrapper function that handles parsing certain
characters and adding input to a buffer. The input is checked
for any erroneous values and is handled appropriately.
A prompt will persist until input is entered or the timeout
It is possible while waiting for multiple types of external
interrupts that we might have pending irqs remaining between
irq consumption and irq-type disabling. Those interrupts
could potentially propagate to the guest after IPL completes
and cause unwanted behavior.
As it is today, the SCLP will
Moved:
memcmp from bootmap.h to libc.h (renamed from _memcmp)
strlen from sclp.c to libc.h (renamed from _strlen)
Added C standard functions:
isdigit
Added non C-standard function:
uitoa
atoui
Signed-off-by: Collin L. Walling
Acked-by: Christian
Reads boot menu flag and timeout values from the iplb and
sets the respective fields for the menu.
Signed-off-by: Collin L. Walling
Reviewed-by: Thomas Huth
---
pc-bios/s390-ccw/Makefile | 2 +-
pc-bios/s390-ccw/main.c | 24
Interactive boot menu for scsi. This follows a similar procedure
as the interactive menu for eckd dasd. An example follows:
s390x Enumerated Boot Menu.
3 entries detected. Select from index 0 to 2.
Signed-off-by: Collin L. Walling
Reviewed-by: Thomas Huth
The s390-ccw firmware needs some information in support of the
boot process which is not available on the native machine.
Examples are the netboot firmware load address and now the
boot menu parameters.
While storing that data in unused fields of the IPL parameter block
works, that approach could
Some ECKD bootmap code was using structs designed for SCSI.
Even though this works, it confuses readability. Add a new
BootMapTable struct to assist with readability in bootmap
entry code. Also:
- replace ScsiMbr in ECKD code with appropriate structs
- fix read_block messages to reflect
Set boot menu options for an s390 guest and store them in
the iplb. These options are set via the QEMU command line
option:
-boot menu=on|off[,splash-time=X]
or via the libvirt domain xml:
Where X represents some positive integer representing
milliseconds.
Any value set
ECKD DASDs have different IPL structures for CDL and LDL
formats. The current Ipl1 and Ipl2 structs follow the CDL
format, so we prepend "EckdCdl" to them. Boot info for LDL
has been moved to a new struct: EckdLdlIpl1.
Signed-off-by: Collin L. Walling
Acked-by:
Add new cylinder/head/sector struct. Use it to calculate
eckd block numbers instead of a BootMapPointer (which used
eckd chs anyway).
Signed-off-by: Collin L. Walling
Reviewed-by: Thomas Huth
---
pc-bios/s390-ccw/bootmap.c | 28
Sorry for posting this version so close to the previous posting. The requested
changes are getting smaller and smaller and I'm hoping to get these patches
satisfactory soon.
--- [v7] ---
- fixed alignment mistake in QemuIplParameters
- also added comment explaining this
- fixed
On Fri, Feb 16, 2018 at 11:45:51PM +0200, Andy Shevchenko wrote:
> Now, the question about test case. Why do you heavily use BUG_ON?
> Isn't resulting statistics enough?
No. If any of those tests fail, we want to stop dead. They'll lead to
horrendous bugs throughout the kernel if they're wrong.
The EXTRA record allows for additional space to be allocated
beyon what is currently reserved. Add code to emit and read
this record type.
Nothing uses extra space yet.
Signed-off-by: Richard Henderson
---
linux-user/signal.c | 55
Split out helpers from target_setup_frame and target_restore_sigframe
for dealing with general registers, fpsimd registers, and the end record.
When we add support for sve registers, the relative positions of
these will change.
Signed-off-by: Richard Henderson
---
Depending on the currently selected size of the SVE vector registers,
we can either store the data within the "standard" allocation, or we
may beedn to allocate additional space with an EXTRA record.
Signed-off-by: Richard Henderson
---
linux-user/signal.c | 141
Changes since v2:
* 5 patches merged,
* The PR_SVE_SET/GET_VL patch is more specifically user-only.
* Split the signal frame patch into 4 parts.
r~
Richard Henderson (5):
linux-user: Implement aarch64 PR_SVE_SET/GET_VL
aarch64-linux-user: Split out helpers for guest signal handling
This changes the qemu signal frame layout to be more like the kernel's,
in that the various records are dynamically allocated rather than fixed
in place by a structure.
For now, all of the allocation is out of uc.tuc_mcontext.__reserved,
so the allocation is actually trivial. That will change
As an implementation choice, widening VL has zeroed the
previously inaccessible portion of the sve registers.
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_syscall.h | 3 +++
target/arm/cpu.h| 1 +
linux-user/syscall.c
On Wed, Jan 24, 2018 at 03:18:48PM +0100, Marek Marczykowski-Górecki wrote:
> Allow updating those two adjacent 32bit fields with one 64bit write.
> This fixes qemu crash when booting Xen inside.
>
> See discussion on Xen side of the thing here:
> http://xen.markmail.org/message/6mrmemrnmhxvaxba
On Thu, Feb 15, 2018 at 6:29 PM, Philippe Mathieu-Daudé wrote:
> omap_mmc.c is the last user left.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> include/hw/sd/sd.h| 16
On Thu, Feb 15, 2018 at 6:29 PM, Philippe Mathieu-Daudé wrote:
> It belongs to the legacy API (the last user has been converted).
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
>
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/206 | 34 ++
tests/qemu-iotests/206.out | 2 ++
tests/qemu-iotests/group | 1 +
3 files changed,
On Thu, Feb 15, 2018 at 2:05 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/sd/sd.c | 32 ++--
> hw/sd/trace-events
On 02/15/2018 04:25 PM, Marc-André Lureau wrote:
> Fixes the following ASAN report:
>
> Direct leak of 128 byte(s) in 8 object(s) allocated from:
> #0 0x7fefce311850 in malloc (/lib64/libasan.so.4+0xde850)
> #1 0x7fefcdd5ef0c in g_malloc ../glib/gmem.c:94
> #2 0x559b976faff0 in
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Simple way to have auto generated filenames with auto clenup. Like
s/clenup/cleanup/
FilePath but without using 'with' statement and without additional
indentation of the whole test.
Signed-off-by: Vladimir Sementsov-Ogievskiy
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
What breaks if they aren't moved? But stylistically, this looks
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Minimal realization: only one extent in server answer is supported.
Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior.
Tests 140, 147 and 205 are fixed due to now server failed on searching
export in context of
Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g.
This combination may not be very fun for the user to have to enter, so we
now enable the user to specify their own key(s) as the ungrab key(s). The
list of keys that can be used is found in the file qapi/ui.json under
* Peter Lieven (p...@kamp.de) wrote:
>
> > Am 07.02.2018 um 19:29 schrieb Dr. David Alan Gilbert :
> >
> > * Peter Lieven (p...@kamp.de) wrote:
> >> Am 12.12.2017 um 18:05 schrieb Dr. David Alan Gilbert:
> >>> * Peter Lieven (p...@kamp.de) wrote:
> Am 21.09.2017 um
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
> Initially int64_t was used, but on PowerPC architecture,
> clang doesn't have atomic_*_8 function, so it produces
> link time error.
>
> QEMU is working with time as with 64bit value, but by
> fact 32 bit is enough with CLOCK_REALTIME. In this
Hi Philippe,
Am Freitag, den 16.02.2018, 16:23 -0300 schrieb Philippe Mathieu-Daudé:
> Hi Benjamin,
>
> On 02/16/2018 02:55 PM, Benjamin Drung wrote:
> > This patch will allow the user to include the domainname option in
> > replies from the built-in DHCP server.
> >
> > Signed-off-by: Benjamin
Hi Benjamin,
On 02/16/2018 02:55 PM, Benjamin Drung wrote:
> This patch will allow the user to include the domainname option in
> replies from the built-in DHCP server.
>
> Signed-off-by: Benjamin Drung
> ---
> net/slirp.c | 7 ---
> qapi/net.json|
Commit 5d0fb1508e2d "spapr: consolidate the VCPU id numbering logic
in a single place" introduced a helper to detect thread0 of a virtual
core based on its VCPU id. This is used to create CPU core nodes in
the DT, but it is broken in TCG.
$ qemu-system-ppc64 -nographic -accel tcg -machine
On 16 February 2018 at 17:31, Dr. David Alan Gilbert (git)
wrote:
> From: "Dr. David Alan Gilbert"
>
> RHEL6's compilers don't like the repeated typedef.
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
>
On Fri, Feb 16, 2018 at 07:44:50PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 9, 2018 at 1:10 PM, Wei Wang wrote:
> > From: Matthew Wilcox
> >
> > The eXtensible Bitmap is a sparse bitmap representation which is
> > efficient for set bits which tend
These two functions are essentially called by code that is only
compiled when CONFIG_KVM=y, with the notable exception of the
two users in the sPAPR code:
$ git grep -E -l 'kvm_arch_vcpu_id|kvm_vcpu_id_is_valid'
accel/kvm/kvm-all.c
hw/intc/openpic_kvm.c
hw/intc/xics_kvm.c
hw/ppc/spapr.c
This patch will allow the user to include the domainname option in
replies from the built-in DHCP server.
Signed-off-by: Benjamin Drung
---
net/slirp.c | 7 ---
qapi/net.json| 4
qemu-options.hx | 7 +--
slirp/bootp.c| 8
On 02/15/2018 07:14 PM, Michael Roth wrote:
Quoting Daniel Henrique Barboza (2018-01-05 07:03:13)
When issuing the qmp/hmp 'system_wakeup' command, what happens in a
nutshell is:
- qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason
and notify the event
- in the
From: Thomas Huth
The "default" parameter of the "-mon" option is useless since
QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That
should have been long enough to let people update their scripts,
so time to remove it now.
Signed-off-by: Thomas Huth
From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
The following changes since commit 5e8d6a12d643a38b82a0a713a77d1192117dbdca:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180216-pull-request'
into staging (2018-02-16 15:55:45 +)
are available in th
From: "Dr. David Alan Gilbert"
The QEMU monitor enters an infinite loop when trying to auto-complete commands
that accept only optional parameters. The commands currently affected by this
issue are 'info registers' and 'info mtree'.
Reported-by: Dimitris Karagkasidis
On 02/16/2018 02:31 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> RHEL6's compilers don't like the repeated typedef.
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Philippe Mathieu-Daudé
On 02/16/2018 02:41 PM, Kamil Rytarowski wrote:
> On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote:
>> But before announcing the host OS being supported again, I'd rather see
>> reproducible build/tests logs, in a (public - if possible) continuous
>> integration system. Else it is hard to notice
On Fri, Feb 16, 2018 at 05:37:32PM +, Peter Maydell wrote:
> On 16 February 2018 at 17:30, Philippe Mathieu-Daudé wrote:
> > But before announcing the host OS being supported again, I'd rather see
> > reproducible build/tests logs, in a (public - if possible) continuous
> >
On 02/16/2018 01:28 PM, Igor Mammedov wrote:
> On Fri, 16 Feb 2018 13:45:15 +
> Peter Maydell wrote:
...
>> static void sysbus_dev_print(Monitor *mon, DeviceState *dev, int indent);
>> static char *sysbus_get_fw_dev_path(DeviceState *dev);
>> @@ -372,6 +373,19 @@
On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote:
> But before announcing the host OS being supported again, I'd rather see
> reproducible build/tests logs, in a (public - if possible) continuous
> integration system. Else it is hard to notice when it get broken.
>
This is already done for
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
1. NBD_REP_ERR_INVALID is not only about length, so, make message more
general
2. hex format is not very good: it's hard to read something like
"option a (set meta context)", so switch to dec.
It would be okay as option 0xa;
On 16 February 2018 at 17:30, Philippe Mathieu-Daudé wrote:
> But before announcing the host OS being supported again, I'd rather see
> reproducible build/tests logs, in a (public - if possible) continuous
> integration system. Else it is hard to notice when it get broken.
I do
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
It is ok, that fatal error hides previous not fatal, but hiding
first fatal error is a bad feature.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.c | 4 +++-
1 file changed, 3
From: "Dr. David Alan Gilbert"
RHEL6's compilers don't like the repeated typedef.
Signed-off-by: Dr. David Alan Gilbert
---
include/hw/misc/macio/cuda.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch adds ans uses a new function to send virtio device
status updates to the backend.
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxime Coquelin
---
hw/net/vhost_net.c | 10 ++
hw/net/virtio-net.c | 7 ++-
Hi Brad,
On 02/16/2018 01:46 PM, Brad Smith wrote:
> Add myself as an OpenBSD maintainer and add OpenBSD as maintained.
>
> Signed-off-by: Brad Smith
>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 57358a08e2..86329e274f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
>
This patch implements the .vhost_set_virtio_status() backend
callback for user backend by intooducing a new vhost-user
VHOST_USER_SET_VIRTIO_STATUS request.
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxime Coquelin
---
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxime Coquelin
---
hw/scsi/vhost-user-scsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c
index 9389ed48e0..da36a3b7f5 100644
---
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxime Coquelin
---
hw/block/vhost-user-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index b53b4c9c57..a88b6f13a4 100644
---
This series introduces a new vhost-user request to notify the
backend with virtio device status updates.
This is done to address the case when the guest driver only
intializes a subset of the virtqueues. For example, it happens
with Windows virtio-net driver, when the virtio-net device has
more
This patch adds a function to notify the vhost backend with
virtio device status updates.
Suggested-by: Stefan Hajnoczi
Signed-off-by: Maxime Coquelin
---
hw/virtio/vhost.c | 11 +++
include/hw/virtio/vhost-backend.h | 3
On 02/16/2018 10:50 AM, Stefan Hajnoczi wrote:
BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop
activity while a condition evaluates to true. This is used to implement
synchronous operations where it acts as a condvar between the IOThread
running the operation and the main
On 02/16/2018 10:50 AM, Stefan Hajnoczi wrote:
The name aio_context_in_iothread() is misleading because it also return
s/return/returns/
true when called on the main AioContext from the main loop thread, which
is not an IOThread.
This patch renames it to in_aio_context_home_thread() and
* Brijesh Singh (brijesh.si...@amd.com) wrote:
> The command can be used to show the SEV information when memory
> encryption is enabled on AMD platform.
>
> Cc: Eric Blake
> Cc: "Daniel P. Berrangé"
> Cc: "Dr. David Alan Gilbert"
>
On 16.02.2018 17:46, Brad Smith wrote:
> Add myself as an OpenBSD maintainer and add OpenBSD as maintained.
>
> Signed-off-by: Brad Smith
>
Reviewed-by: Kamil Rytarowski
Would you like to co-maintain with myself a merge-branch for BSD? Right
now I send
On 02/16/2018 08:43 AM, Vladimir Sementsov-Ogievskiy wrote:
16.02.2018 16:21, Eric Blake wrote:
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Minimal realization: only one extent in server answer is supported.
Signed-off-by: Vladimir Sementsov-Ogievskiy
On 16.02.2018 17:44, Collin L. Walling wrote:
> On 02/16/2018 11:36 AM, Viktor Mihajlovski wrote:
>> On 16.02.2018 17:20, Thomas Huth wrote:
>> [...]
diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h
index cab8a97..7c3cab8 100644
--- a/hw/s390x/ipl.h
+++ b/hw/s390x/ipl.h
@@
From: Kevin Wolf
This patch adds test cases for the scenario where blk_aio_flush() is
called on a BlockBackend with no root. Calling drain afterwards should
complete the requests with -ENOMEDIUM.
Signed-off-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
BlockDriverState has the BDRV_POLL_WHILE() macro to wait on event loop
activity while a condition evaluates to true. This is used to implement
synchronous operations where it acts as a condvar between the IOThread
running the operation and the main loop waiting for the operation. It
can also be
The name aio_context_in_iothread() is misleading because it also return
true when called on the main AioContext from the main loop thread, which
is not an IOThread.
This patch renames it to in_aio_context_home_thread() and expands the
doc comment to make the semantics clearer.
Signed-off-by:
BlockBackend currently relies on BlockDriverState->in_flight to track
requests for blk_drain(). There is a corner case where
BlockDriverState->in_flight cannot be used though: blk->root can be NULL
when there is no medium. This results in a segfault when the NULL
pointer is dereferenced.
This reverts commit 4da97120d51a4383aa96d741a2b837f8c4bbcd0b.
blk_aio_flush() now handles the blk->root == NULL case, so we no longer
need this workaround.
Cc: John Snow
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
v3:
* Add Patch 1 to rename aio_context_in_iothread() to
in_aio_context_home_thread() [Eric]
v2:
* Introduce AIO_WAIT_WHILE() since aio_poll(ctx, true) is not allowed [Paolo]
Using bdrv_inc_in_flight(blk_bs(blk)) doesn't work since BlockBackend->root may
be NULL.
This patch series solves
Add myself as an OpenBSD maintainer and add OpenBSD as maintained.
Signed-off-by: Brad Smith
diff --git a/MAINTAINERS b/MAINTAINERS
index 57358a08e2..86329e274f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -386,6 +386,12 @@ M: Kamil Rytarowski
S:
he git repository at:
>
> git://git.kraxel.org/qemu tags/ui-20180216-pull-request
>
> for you to fetch changes up to d50f09ff23f5509c05e3883440849b27af051f08:
>
> ui: extend VNC trottling tracing to SASL codepaths (2018-02-16 12:33:02
> +0100)
>
> --
On 02/16/2018 11:36 AM, Viktor Mihajlovski wrote:
On 16.02.2018 17:20, Thomas Huth wrote:
[...]
diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h
index cab8a97..7c3cab8 100644
--- a/hw/s390x/ipl.h
+++ b/hw/s390x/ipl.h
@@ -60,10 +60,15 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi;
#define
On 16.02.2018 17:20, Thomas Huth wrote:
[...]
>> diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h
>> index cab8a97..7c3cab8 100644
>> --- a/hw/s390x/ipl.h
>> +++ b/hw/s390x/ipl.h
>> @@ -60,10 +60,15 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi;
>>
>> #define QIPL_ADDRESS 0xcc
>>
>>
On Fri, 16 Feb 2018 13:45:15 +
Peter Maydell wrote:
> If you're using the increasingly-common QOM style of
> having container devices create their child objects
> in-place, you end up with a lot of boilerplate in the
> container's init function:
>
>
On 02/16/2018 11:20 AM, Thomas Huth wrote:
On 15.02.2018 23:54, Collin L. Walling wrote:
Set boot menu options for an s390 guest and store them in
the iplb. These options are set via the QEMU command line
option:
-boot menu=on|off[,splash-time=X]
or via the libvirt domain xml:
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Tue, Feb 13, 2018 at 12:51:43PM +, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
>
> Please include the details of how to trigger this bug. This helps
> justify the patch as well as aiding
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David Alan Gilbert"
>
> Reported-by: Dimitris Karagkasidis
> Fixes: 48fe86f6400574165979e0db6f5937ad487b6888
> Signed-off-by: Dr. David Alan Gilbert
Queued.
On 15.02.2018 23:54, Collin L. Walling wrote:
> Set boot menu options for an s390 guest and store them in
> the iplb. These options are set via the QEMU command line
> option:
>
> -boot menu=on|off[,splash-time=X]
>
> or via the libvirt domain xml:
>
>
>
>
>
> Where X
On 02/16/2018 07:53 AM, Vladimir Sementsov-Ogievskiy wrote:
Good idea. But it would be tricky thing to maintain backward
compatibility with published versions of virtuozzo product. And finally
our implementation would be more complex because of this simplification.
Hm. Finally, you
1 - 100 of 277 matches
Mail list logo