[Qemu-devel] [PATCH v10 22/24] migration: Create ram_multifd_page

The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the same than normal

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > Properly account for the possibility of multiboot kernels with a zero > bss_end_addr. The Multiboot Specification, section 3.1.3 allows for > kernels without a bss section, by allowing a zeroed bss_end_addr multiboot > header field. > > Do

[Qemu-devel] [PATCH v10 15/24] migration: Synchronize send threads

We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 38

[Qemu-devel] [PATCH v10 21/24] migration: Transmit initial package through the multifd channels

Signed-off-by: Juan Quintela --- migration/ram.c | 50 +- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1aab96bd5e..4efac0c20c 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH v10 02/24] tests: Add migration xbzrle test

Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/migration-test.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread

Signed-off-by: Juan Quintela --- migration/ram.c| 6 ++ migration/trace-events | 4 2 files changed, 10 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 0266bd200c..b57d9fd667 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -492,6

[Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

In both sides. We still don't transmit anything through them. Signed-off-by: Juan Quintela --- migration/ram.c | 52 ++-- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH v10 01/24] tests: Add migration precopy test

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v10 13/24] migration: Introduce multifd_recv_new_channel()

Signed-off-by: Juan Quintela --- migration/migration.c | 3 ++- migration/ram.c | 6 ++ migration/ram.h | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index c398665de7..919343232e 100644

[Qemu-devel] [PATCH v10 11/24] migration: terminate_* can be called for other threads

Once there, make count field to always be accessed with atomic operations. To make blocking operations, we need to know that the thread is running, so create a bool to indicate that. Signed-off-by: Juan Quintela --- migration/ram.c | 30 -- 1

[Qemu-devel] [PATCH v10 23/24] migration: Create pages structure for reception

Signed-off-by: Juan Quintela --- migration/ram.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index df9646ed2e..264d2e462a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -698,6 +698,7 @@ static void

[Qemu-devel] [PATCH v10 10/24] migration: In case of error just end the migration

Signed-off-by: Juan Quintela --- migration/socket.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/socket.c b/migration/socket.c index 08606c665d..b12b0a462e 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -139,9 +139,8 @@

[Qemu-devel] [PATCH v10 16/24] migration: Synchronize recv threads

We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 37

[Qemu-devel] [PATCH v10 08/24] migration: Add multifd test

We set the x-multifd-page-count and x-multifd-channels. Signed-off-by: Juan Quintela --- tests/migration-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PATCH v10 20/24] migration: Delay start of migration main routines

We need to make sure that we have started all the multifd threads. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/migration.h | 1 + migration/ram.c | 3 +++ migration/socket.c| 3 +++ 4 files changed, 9 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v10 07/24] [RFH] tests: Add migration compress threads tests

Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 52

[Qemu-devel] [PATCH v10 14/24] migration: Be sure all recv channels are created

We need them before we start migration. Signed-off-by: Juan Quintela --- migration/migration.c | 6 +- migration/ram.c | 11 +++ migration/ram.h | 1 + 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.c

[Qemu-devel] [PATCH v10 03/24] migration: Create tcp_port parameter

It will be used to store the uri tcp_port parameter. This is the only parameter than can change and we can need to be able to connect to it. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make

[Qemu-devel] [RFC v10 00/24] Multifd

Hi this is the v10 version of the multifd patches, Lots of changes from previous versions: a - everything is sent now through the multifd channels, nothing is sent through main channel b - locking is band new, I was getting into a hole with the previous approach, right now, there is a single

[Qemu-devel] [PATCH v10 05/24] tests: Migration ppc now inlines its program

No need to write it to a file. Just need a proper firmware O:-) Signed-off-by: Juan Quintela CC: Laurent Vivier --- tests/migration-test.c | 41 + 1 file changed, 5 insertions(+), 36 deletions(-) diff --git

[Qemu-devel] [PATCH v10 06/24] tests: Add basic migration precopy tcp test

Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 58

[Qemu-devel] [PATCH v10 09/24] migration: Set error state in case of error

Signed-off-by: Juan Quintela --- migration/ram.c | 20 1 file changed, 20 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 3b6c077964..4a56a85d53 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -414,6 +414,16 @@ static void

[Qemu-devel] [PATCH v10 12/24] migration: Reference counting recv channels correctly

Signed-off-by: Juan Quintela --- migration/socket.c | 11 +++ migration/socket.h | 7 +++ 2 files changed, 18 insertions(+) diff --git a/migration/socket.c b/migration/socket.c index b12b0a462e..26110739cf 100644 --- a/migration/socket.c +++

[Qemu-devel] [PATCH v10 04/24] migration: Set the migration tcp port

We can set the port parameter as zero. This patch lets us know what port the system was choosen for us. Now we can migrate to this place. Signed-off-by: Juan Quintela -- This was migrate_set_uri(), but as we only need the tcp_port, change to that one. ---

Re: [Qemu-devel] [PATCH v1 1/1] iotests: bypass s390x for case 200

在 2018/3/6 15:56, Christian Borntraeger 写道: Nack. This will be fixed by s390/ipl: only print boot menu error if -boot menu=on was specified You are right. After I applied that patch, the case is passed. Please ignore this patch. Thanks On 03/06/2018 08:54 AM, QingFeng Hao wrote: In s390x,

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella wrote: > I have applied this patch and when I run the following qmp commands I I do > not see the crash anymore but there is still something wrong because only > /root/a is opened from qemu. It looks like nbd-server-stop is also

[Qemu-devel] BUG? Using memory after freeing

Hello! Explanation of what I saw is follows. In hw/pci/pci_bridge.c function pci_bridge_update_mappings does follows: ``` void pci_bridge_update_mappings(PCIBridge *br) { PCIBridgeWindows *w = br->windows; /* Make updates atomic to: handle the case of one VCPU updating the bridge *

Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

On Tue, 6 Mar 2018 07:18:01 +0100 Thomas Huth wrote: > bootmap.h can currently only be included once - otherwise the linker > complains about multiple definitions of the "magic" strings. It's a > bad style to define string arrays in header files, so let's better > move these

Re: [Qemu-devel] [PATCH v3 4/5] tests/bios-tables-test: allow setting extra machine options

On Mon, 5 Mar 2018 14:57:09 +0800 Haozhong Zhang wrote: > Some test cases may require extra machine options than those used in > the current test_acpi_ones(), e.g., nvdimm test cases require the > machine option 'nvdimm=on'. > > Signed-off-by: Haozhong Zhang

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi-build: build SRAT memory affinity structures for DIMM devices

On Mon, 5 Mar 2018 14:57:08 +0800 Haozhong Zhang wrote: > ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity > domain of a NVDIMM SPA range must match with corresponding entry in > SRAT table. > > The address ranges of vNVDIMM in QEMU are allocated

Re: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306

On Tue, Mar 06, 2018 at 05:56:03PM +, Mark Cave-Ayland wrote: > On 06/03/18 17:47, Thomas Huth wrote: > > > > It seems that the error is being raised when setting the property rather > > > than during realize so I'm not sure what I can do to handle this. Any > > > thoughts? > > > > Does the

Re: [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

On 06/03/2018 18:10, David Hildenbrand wrote: If L2 forward devices to L3 through SIE ECA.28 but no bit is set is in the CRYCB of L2, L3 will not see any device. Exactly and this is the problem: How should L2 know that these devices are special and cannot be forwarded. This is what we call

Re: [Qemu-devel] [PATCH v3 2/5] qmp: distinguish PC-DIMM and NVDIMM in MemoryDeviceInfoList

On Mon, 5 Mar 2018 14:57:07 +0800 Haozhong Zhang wrote: > It may need to treat PC-DIMM and NVDIMM differently, e.g., when > deciding the necessity of non-volatile flag bit in SRAT memory > affinity structures. > > NVDIMMDeviceInfo, which inherits from

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

On Wed, Mar 07, 2018 at 09:24:30AM +0800, Fam Zheng wrote: > On Tue, 03/06 16:22, Daniel P. Berrangé wrote: > > RFE for patchew... > > > > Now we're sending separate email alerts for each build job, can we > > make patchew include the job name in the subject line, so it is > > immediately obvious

Re: [Qemu-devel] [PATCH v3 20/29] postcopy: postcopy_notify_shared_wake

On Tue, Mar 06, 2018 at 10:54:18AM +, Dr. David Alan Gilbert wrote: [...] > > Basically above was what I thought - to record the faulted addresses > > with specific PostcopyFD when page fault happened, then we may know > > which page(s) will a PostcopyFD need. But when with that, we'll > >

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

On Wed, Mar 07, 2018 at 01:09:29PM +1300, Michael Clark wrote: > Hopefully, this PR gets merged... I hope so too. We've been testing v8 (substantially the same as v8.2) extensively, including SMP. It's building hundreds of packages a day in the autobuilder, and being used for manual builds by

Re: [Qemu-devel] [PATCH v3 1/5] pc-dimm: refactor qmp_pc_dimm_device_list

On Mon, 5 Mar 2018 14:57:06 +0800 Haozhong Zhang wrote: I'd suggest following commit subj/msg: - pc-dimm: make qmp_pc_dimm_device_list() sort devices by address Make qmp_pc_dimm_device_list() return sorted by start address list of devices so that it could be

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 06/03/2018 18:15, David Hildenbrand wrote: 1) ap=on is a guest ABI feature saying to the guest you can use AP instructions Indeed, that's what belongs into the CPU model. 2) How we provide AP instructions to the guest can be done in three different ways: - SIE Interpretation AP

Re: [Qemu-devel] [PATCH v5 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

Le 07/03/2018 à 07:36, Max Filippov a écrit : > In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger > than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when > mmap, munmap, mprotect, mremap or shmat is called for an address outside > the guest address space. mmap

Re: [Qemu-devel] [PATCH v3 11/29] vhost+postcopy: Transmit 'listen' to client

On Tue, Mar 06, 2018 at 11:20:56AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Mar 05, 2018 at 05:42:42PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Fri, Feb 16, 2018 at 01:16:07PM +, Dr. David Alan

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

Am 06.03.2018 um 22:51 hat John Snow geschrieben: > On 02/05/2018 03:22 PM, Max Reitz wrote: > > This series implements .bdrv_refresh_filename() for the ssh block > > driver, along with an appropriate .bdrv_dirname() so we don't chop off > > query strings for backing files with relative filenames.

[Qemu-devel] Using new TCG Vector infrastructure in PowerPC

Hi Richard, I was working to get TCG vector support for PowerPC[1]. Started with converting logical operations like vector AND/OR/XOR and compare instructions. Found some inconsistency during my testing on x86 laptop emulating PowerPC: zero = max =

Re: [Qemu-devel] [PATCH] hw: Do not include "sysemu/block-backend.h" if it is not necessary

On 15.02.2018 09:55, Thomas Huth wrote: > After reviewing a patch from Philippe that removes block-backend.h > from hw/lm32/milkymist.c, I noticed that this header is included > unnecessarily in a lot of other files, too. Remove those unneeded > includes to speed up the compilation process a

Re: [Qemu-devel] [PATCH] HMP: Initialize err before using

* Zhangjixiang (jixiang_zh...@h3c.com) wrote: > When bdrv_snapshot_delete return fail, the errp will not be > assigned a valid value in error_propagate as errp didn't be > initialized in hmp_delvm, then error_reportf_err will use an > uninitialized value(call by hmp_delvm), and qemu crash. > >

Re: [Qemu-devel] [Bug 1658120] Re: building with gcc-aarch64-linux-gnu

Cao Van Dong <1658...@bugs.launchpad.net> writes: > Hello everyone!! > > I am having a issue when build qemu using gcc aarch64-linux-gnu-* on > ubuntu 16.04: > > dong02@dong:~/qemu$ ./configure >\ >> --prefix=/usr

[Qemu-devel] [Bug 1658120] Re: building with gcc-aarch64-linux-gnu

Hi Cao Van Dong, you need to install zlib1g-dev:arm64, see: https://github.com/qemu/qemu/blob/master/tests/docker/dockerfiles /debian-arm64-cross.docker Regards, Phil. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [Qemu-block] block migration and MAX_IN_FLIGHT_IO

On Wed, Mar 7, 2018 at 7:55 AM, Peter Lieven wrote: > Am 06.03.2018 um 17:35 schrieb Peter Lieven: >> Am 06.03.2018 um 17:07 schrieb Stefan Hajnoczi: >>> On Mon, Mar 05, 2018 at 02:52:16PM +, Dr. David Alan Gilbert wrote: * Peter Lieven (p...@kamp.de) wrote: > Am

Re: [Qemu-devel] [PATCH v4 0/3] s390x/sclp: 64 bit event masks

On Fri, 23 Feb 2018 18:42:55 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported 32bit sclp event masks, even though the archiecture > allows the guests to set up sclp event masks up to

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

On 07.03.2018 10:38, Philippe Mathieu-Daudé wrote: > On 03/07/2018 06:13 AM, Kamil Rytarowski wrote: >> This patch is correct. LLDB expects 1sec for reply, GDB by default 2. >> >> Debuggers use this option to disable Nagle algorithm in order to quickly >> transfer messages between gdb-server and

[Qemu-devel] [PATCH] hw/sparc/sun4m: Fix implicit creation of "-drive if=scsi" devices

The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the sun4m machines you now get: $ sparc-softmmu/qemu-system-sparc -boot d -cdrom x.iso qemu-system-sparc: -cdrom x.iso: machine

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

On 03/07/2018 06:13 AM, Kamil Rytarowski wrote: > This patch is correct. LLDB expects 1sec for reply, GDB by default 2. > > Debuggers use this option to disable Nagle algorithm in order to quickly > transfer messages between gdb-server and gdb-client. It's also fairy > portable across systems. >

[Qemu-devel] [PATCH] hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices

The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the pica61 machine you now get: $ mips64-softmmu/qemu-system-mips64 -M pica61 -cdrom x.iso qemu-system-mips64: -cdrom x.iso:

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

This patch is correct. LLDB expects 1sec for reply, GDB by default 2. Debuggers use this option to disable Nagle algorithm in order to quickly transfer messages between gdb-server and gdb-client. It's also fairy portable across systems. On 04.01.2018 18:56, Andreas Gustafsson wrote: > slirp:

[Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the 40p machine you now get: $ ppc64-softmmu/qemu-system-ppc64 -M 40p -cdrom x.iso qemu-system-ppc64: -cdrom x.iso: machine type

[Qemu-devel] [Bug 1658120] Re: building with gcc-aarch64-linux-gnu

Hello everyone!! I am having a issue when build qemu using gcc aarch64-linux-gnu-* on ubuntu 16.04: dong02@dong:~/qemu$ ./configure \ > --prefix=/usr --cross-prefix=/usr/bin/aarch64-linux-gnu- \ > --target-list=aarch64-softmmu

[Qemu-devel] [PATCH v2] iotests: Update 051 and 186 after commit 1454509726719e0933c

SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/051.pc.out | 20 tests/qemu-iotests/186| 4

[Qemu-devel] block migration and dirty bitmap reset

Hi, while looking at the code I wonder if the blk_aio_preadv and the bdrv_reset_dirty_bitmap order must be swapped in mig_save_device_bulk: qemu_mutex_lock_iothread(); aio_context_acquire(blk_get_aio_context(bmds->blk)); blk->aiocb = blk_aio_preadv(bb, cur_sector * BDRV_SECTOR_SIZE,

<    1   2   3   4