Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-09 Thread Auger Eric
Hi Peter, On 09/03/18 15:18, Peter Maydell wrote: > On 9 March 2018 at 14:03, Auger Eric wrote: >> On 08/03/18 18:49, Peter Maydell wrote: +#define smmuv3_eventq_irq_enabled(s) \ +(FIELD_EX32(s->irq_ctrl, IRQ_CTRL, EVENTQ_IRQEN))

Re: [Qemu-devel] [PATCH] hmp: Allow using a qdev id in block_set_io_throttle

2018-03-09 Thread Eric Blake
On 03/09/2018 08:11 AM, Alberto Garcia wrote: The QMP version of this command can take a qdev ID since 7a9877a02635, but the HMP version is still using the deprecated block device name so there's no way to refer to a block device added like this: -blockdev

[Qemu-devel] [PATCH v3 2/2] qapi: add block latency histogram interface

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
Set (and clear) histogram through new command block-latency-histogram-set and show new statistics in query-blockstats results. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 111 ++- block/qapi.c

[Qemu-devel] [PATCH v3 0/2] block latency histogram

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
v3: - semantics, naming and wording changed a lot - x prefixes added to new qapi names - bug fixed about calculation of new_size (new_nbins now) - drop g_renew - in _clear() set nbinst to zero too v2: 01: add block_latency_histogram_clear() 02: fix spelling (sorry =() some rewordings

[Qemu-devel] [PATCH v3 1/2] block/accounting: introduce latency histogram

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
Introduce latency histogram statics for block devices. For each accounted operation type latency region [0, +inf) is divided into subregions by several points. Then, calculate hits for each subregion. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH] migration: fix minor finalize leak

2018-03-09 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Spotted thanks to ASAN: > QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/migration-test -p > /x86_64/migration/bad_dest > > ==30302==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 48 byte(s) in 1 object(s)

Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches

2018-03-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180309142630.2170-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-09 Thread Paolo Bonzini
On 09/03/2018 07:13, Thomas Huth wrote: > + > +@item --nic none > +Indicate that no network devices should be configured. It is used to override > +the default configuration (default NIC with @option{--net user} backend) > which the default @option{--nic user} configuration (default model and

[Qemu-devel] [PATCH v2] vga: fix region calculation

2018-03-09 Thread Gerd Hoffmann
Typically the scanline length and the line offset are identical. But in case they are not our calculation for region_end is incorrect. Using line_offset is fine for all scanlines, except the last one where we have to use the actual scanline length. Fixes: CVE-2018-7550 Reported-by: Ross

Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-09 Thread Eric Blake
On 03/09/2018 12:13 AM, Thomas Huth wrote: "-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many other spots in the network chapter. We should make it less prominent that users are not lured into using it so often anymore. So instead of

Re: [Qemu-devel] Proposal: deprecate and remove QEMU's unicore32 target code

2018-03-09 Thread Xuetao Guan
> I propose that we deprecate and plan to remove the unicore32 code: > > * It has had no changes since 2012 that were not tree-wide >maintenance/API changes/other global updates > * We dropped the linux-user unicore32 support in 2016 because of >a clash between the 'old ABI' that it was

[Qemu-devel] [PULL 6/8] target/m68k: implement fetox

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_etox() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-7-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 +

[Qemu-devel] [PULL 8/8] target/m68k: implement ftentox

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_tentox() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-9-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 ++ target/m68k/helper.h |

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-09 Thread Peter Maydell
On 8 March 2018 at 19:53, Michael Clark wrote: > I re-iterate Palmer's apology. > > I shouldn't be polling git.qemu.org/qemu.git and answering emails near to > 3am in the morning after 4 months of working on trying to get the RISC-V > port in shape to go upstream. > > It appears

[Qemu-devel] [PULL 2/8] target/m68k: implement flognp1

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_lognp1() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-3-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 +

[Qemu-devel] [PULL 0/8] M68k for 2.12 patches

2018-03-09 Thread Laurent Vivier
The following changes since commit e1ee9ee139ed7091c2c592d5b784fbb7227bfc0d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180306' into staging (2018-03-06 10:21:35 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-03-09 Thread Gerd Hoffmann
Hi, > For OVMF (x86), I guess the initial set of properties should come from > the "-D FOO[=BAR]" build flags that OVMF currently supports. (The list > might grow or change incompatibly over time, so this is just a raw > starter idea.) > (0) ARCH (one of IA32, IA32X64, X64) -- the bitnesses of

[Qemu-devel] [PULL 4/8] target/m68k: implement flog10

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_log10() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-5-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 + target/m68k/helper.h

[Qemu-devel] [PULL 3/8] target/m68k: implement flogn

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_logn() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-4-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 ++ target/m68k/helper.h |

[Qemu-devel] [PULL 7/8] target/m68k: implement ftwotox

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_twotox() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-8-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 ++

[Qemu-devel] [PULL 5/8] target/m68k: implement flog2

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_log2() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-6-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h |

[Qemu-devel] [PULL 1/8] target/m68k: define floatx80_move()

2018-03-09 Thread Laurent Vivier
This functions is needed by upcoming m68k softfloat functions. Source code copied for WinUAE (tag 3500) (The WinUAE file has been copied from QEMU and has the QEMU licensing notice) Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-2-laur...@vivier.eu> ---

Re: [Qemu-devel] [PATCH v2 2/2] tests: Use query-usernet instead of 'info usernet'

2018-03-09 Thread Eric Blake
On 02/26/2018 01:58 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake I think this series can go through either my QAPI tree, or through

Re: [Qemu-devel] [PATCH v2 1/2] slirp: Add "query-usernet" QMP command

2018-03-09 Thread Eric Blake
On 02/26/2018 01:58 AM, Fam Zheng wrote: HMP "info usernet" has been available but it isn't ideal for programed s/programed/programmed/ use cases. This closes the gap in QMP by adding a counterpart "query-usernet" command. It is basically translated from the HMP slirp_connection_info() loop,

Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 14:03, Auger Eric wrote: > On 08/03/18 18:49, Peter Maydell wrote: >>> +#define smmuv3_eventq_irq_enabled(s) \ >>> +(FIELD_EX32(s->irq_ctrl, IRQ_CTRL, EVENTQ_IRQEN)) >>> +#define smmuv3_gerror_irq_enabled(s) \ >>> +

[Qemu-devel] [PATCH] hmp: Allow using a qdev id in block_set_io_throttle

2018-03-09 Thread Alberto Garcia
The QMP version of this command can take a qdev ID since 7a9877a02635, but the HMP version is still using the deprecated block device name so there's no way to refer to a block device added like this: -blockdev node-name=disk0,driver=qcow2,file.driver=file,file.filename=hd.qcow2 -device

Re: [Qemu-devel] [PATCH v2] build: try improve handling of clang warnings

2018-03-09 Thread Thomas Huth
On 09.03.2018 14:59, Gerd Hoffmann wrote: > This patch disables the pragma diagnostic -Wunused-but-set-variable for > clang in util/coroutine-ucontext.c. > > This in turn allows us to remove it from the configure check, so the > CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang. > > With

Re: [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD

2018-03-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 02/22/2018 01:01 PM, Peter Maydell wrote: > On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> Acked-by: Alistair Francis >> --- >> hw/sd/sd.c | 8 +--- >> 1

Re: [Qemu-devel] [PATCH v9 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-03-09 Thread Auger Eric
Hi Peter, On 08/03/18 18:49, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> We introduce some helpers to handle wired IRQs and especially >> GERROR interrupt. SMMU writes GERROR register on GERROR event >> and SW acks GERROR interrupts by setting

[Qemu-devel] [PATCH v2] build: try improve handling of clang warnings

2018-03-09 Thread Gerd Hoffmann
This patch disables the pragma diagnostic -Wunused-but-set-variable for clang in util/coroutine-ucontext.c. This in turn allows us to remove it from the configure check, so the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang. With that in place clang builds (linux) will use -Werror by

Re: [Qemu-devel] [edk2] [PATCH v3 0/7] ovmf: preliminary TPM2 support

2018-03-09 Thread Marc-André Lureau
Hi On Fri, Mar 9, 2018 at 2:09 PM, wrote: > From: Marc-André Lureau > > Hi, > > The following series adds basic TPM2 support for OVMF-on-QEMU (I > haven't tested TPM1, for lack of interest). It links with the modules > to initializes

Re: [Qemu-devel] [PATCH] build: try improve handling of clang warnings

2018-03-09 Thread Gerd Hoffmann
On Fri, Mar 09, 2018 at 11:32:30AM +, Peter Maydell wrote: > On 9 March 2018 at 11:01, Gerd Hoffmann wrote: > > This patch disables the pragma diagnostic -Wunused-but-set-variable for > > clang in util/coroutine-ucontext.c. > > > > This in turn allows us to remove it from

Re: [Qemu-devel] [PATCH v3 0/6] arm: support -cpu max (and gic-version=max)

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 13:52, Alex Bennée wrote: > > Peter Maydell writes: > >> This patchset adds support for '-cpu max' to Arm, along the lines >> of the existing support we have for x86 targets: >> >> * under KVM, -cpu max is the same as -cpu

Re: [Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support -machine gic-version=max

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 13:50, Alex Bennée wrote: > > Peter Maydell writes: >> @@ -1480,9 +1487,11 @@ static void virt_set_gic_version(Object *obj, const >> char *value, Error **errp) >> vms->gic_version = 2; >> } else if

Re: [Qemu-devel] [edk2] [PATCH v2 0/8] RFC: ovmf: preliminary TPM2 support

2018-03-09 Thread Stefan Berger
On 03/08/2018 10:03 PM, Shi, Steven wrote: Hi Marcandre, Thanks for your command steps and I tried them, but my qemu failed to connect the socket tpmemu.sock. When I added the control channel to the TPM, the swtpm socket command stuck there and never exit. Not sure whether it was successful.

Re: [Qemu-devel] [PATCH v3 0/6] arm: support -cpu max (and gic-version=max)

2018-03-09 Thread Alex Bennée
Peter Maydell writes: > This patchset adds support for '-cpu max' to Arm, along the lines > of the existing support we have for x86 targets: > > * under KVM, -cpu max is the same as -cpu host > * under TCG, -cpu max means "emulate with as many features as >

Re: [Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support -machine gic-version=max

2018-03-09 Thread Alex Bennée
Peter Maydell writes: > Add support for passing 'max' to -machine gic-version. By analogy > with the -cpu max option, this picks the "best available" GIC version > whether you're using KVM or TCG, so it behaves like 'host' when > using KVM, and gives you GICv3 when

Re: [Qemu-devel] [PATCH v9 04/14] hw/arm/smmuv3: Skeleton

2018-03-09 Thread Auger Eric
Hi Peter, On 09/03/18 14:37, Peter Maydell wrote: > On 9 March 2018 at 13:19, Auger Eric wrote: >> On 08/03/18 15:27, Peter Maydell wrote: >>> Consider specifically catching 8-byte accesses to non-64-bit registers? >>> This is CONSTRAINED UNPREDICTABLE (see spec section

Re: [Qemu-devel] [PATCH v8 13/23] RISC-V HART Array

2018-03-09 Thread Michael Clark
Got it. I can add to the post merge cleanup patch series. BTW the code currently creates a homogeneous array or cores but the intent is that it supports a heterogeneous array, in the future. It might evolve into an SOC base class. We need a method to give it an array or cpu_models. For example the

Re: [Qemu-devel] [PATCH v3 5/6] hw/arm/virt: Add "max" to the list of CPU types "virt" supports

2018-03-09 Thread Alex Bennée
Peter Maydell writes: > Allow the virt board to support '-cpu max' in the same way > it already handles '-cpu host'. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > hw/arm/virt.c | 1 + > 1 file

Re: [Qemu-devel] [PATCH v3 4/6] target/arm: Make 'any' CPU just an alias for 'max'

2018-03-09 Thread Alex Bennée
Peter Maydell writes: > Now we have a working '-cpu max', the linux-user-only > 'any' CPU is pretty much the same thing, so implement it > that way. > > For the moment we don't add any of the extra feature bits > to the system-emulation "max", because we don't set the

Re: [Qemu-devel] [PATCH v9 04/14] hw/arm/smmuv3: Skeleton

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 13:19, Auger Eric wrote: > On 08/03/18 15:27, Peter Maydell wrote: >> Consider specifically catching 8-byte accesses to non-64-bit registers? >> This is CONSTRAINED UNPREDICTABLE (see spec section 6.2), and "one >> of the registers is read/written and

Re: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU

2018-03-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180309132922.24211-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH] vnc: deal with surface NULL pointers

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/08/2018 05:18 PM, Gerd Hoffmann wrote: > Secondary displays in multihead setups are allowed to have a NULL > DisplaySurface. Typically user interfaces handle this by hiding the > window which shows the display in question. > > This isn't an option for vnc though because it simply hasn't a

[Qemu-devel] [PATCH 4/4] membarrier: add --enable-membarrier

2018-03-09 Thread Paolo Bonzini
Actually enable the global memory barriers if supported by the OS. Because only recent versions of Linux include the support, they are disabled by default. Note that it also has to be disabled for QEMU to run under Wine. Before this patch, rcutorture reports 85 ns/read for my machine, after the

[Qemu-devel] [PATCH 1/4] rcutorture: remove synchronize_rcu from readers

2018-03-09 Thread Paolo Bonzini
This gives much worse numbers for readers, especially if synchronize_rcu is made more expensive as is the case with --enable-membarrier. Before: $ tests/rcutorture 10 stress 10 n_reads: 98304 n_updates: 529 n_mberror: 0 rcu_stress_count: 98302 2 0 0 0 0 0 0 0 0 0 After: $

[Qemu-devel] [PATCH 3/4] membarrier: introduce qemu/sys_membarrier.h

2018-03-09 Thread Paolo Bonzini
This new header file provides heavy-weight "global" memory barriers that enforce memory ordering on each running thread belonging to the current process. For now, use a dummy implementation that issues memory barriers on both sides (matching what QEMU has been doing so far). Signed-off-by: Paolo

Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable

2018-03-09 Thread Michael Clark
BTW I was looking at the IEEE-754 2008 minNum/maxNum code today (the reason I was running riscv-tests) so that I could forward port the patch to add IEEE-754 201x minimumNumber/maximumNumber (as there are two pairs of distinct IEEE-754 functions which have distinct behaviour with respect to sNaN)

[Qemu-devel] [PATCH 2/4] rcu: make memory barriers more explicit

2018-03-09 Thread Paolo Bonzini
Prepare for introducing smp_mb_placeholder() and smp_mb_global(). The new smp_mb() in synchronize_rcu() is not strictly necessary, since the first atomic_mb_set for rcu_gp_ctr provides the required ordering. However, synchronize_rcu is not performance critical, and it *will* be necessary to

[Qemu-devel] [PATCH 0/4] Optionally use membarrier system call for RCU

2018-03-09 Thread Paolo Bonzini
I didn't have time to check whether it improves performance (not too likely, since QEMU tends to have pretty long RCU critical sections), but it cannot hurt either. :) For microbenchmark results, see patch 4. Paolo Paolo Bonzini (4): rcutorture: remove synchronize_rcu from readers rcu:

[Qemu-devel] [Bug 1754656] [NEW] Please solve graceful (ACPI) poweroff issue, using signals, most importantly SIGTERM

2018-03-09 Thread eto
Public bug reported: Version: QEMU emulator version 2.11.1 Introduction: This is call for action to get attention of somebody in QEMU project/organization, who is capable of actually doing something about this pressing issue. This might be TLDR for some, but that's only because of the

[Qemu-devel] [PULL 7/7] vl: introduce vm_shutdown()

2018-03-09 Thread Stefan Hajnoczi
Commit 00d09fdbbae5f7864ce754913efc84c12fdf9f1a ("vl: pause vcpus before stopping iothreads") and commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") tried to work around the fact that emulation was still active during termination by stopping iothreads.

[Qemu-devel] [PULL 3/7] virtio-blk: dataplane: Don't batch notifications if EVENT_IDX is present

2018-03-09 Thread Stefan Hajnoczi
From: Sergio Lopez Commit 5b2ffbe4d99843fd8305c573a100047a8c962327 ("virtio-blk: dataplane: notify guest as a batch") deferred guest notification to a BH in order batch notifications, with purpose of avoiding flooding the guest with interruptions. This optimization came with a

[Qemu-devel] [PULL 4/7] block: add aio_wait_bh_oneshot()

2018-03-09 Thread Stefan Hajnoczi
Sometimes it's necessary for the main loop thread to run a BH in an IOThread and wait for its completion. This primitive is useful during startup/shutdown to synchronize and avoid race conditions. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v9 04/14] hw/arm/smmuv3: Skeleton

2018-03-09 Thread Auger Eric
Hi Peter, On 08/03/18 15:27, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> From: Prem Mallappa >> >> This patch implements a skeleton for the smmuv3 device. >> Datatypes and register definitions are introduced. The

[Qemu-devel] [PULL 6/7] virtio-scsi: fix race between .ioeventfd_stop() and vq handler

2018-03-09 Thread Stefan Hajnoczi
If the main loop thread invokes .ioeventfd_stop() just as the vq handler function begins in the IOThread then the handler may lose the race for the AioContext lock. By the time the vq handler is able to acquire the AioContext lock the ioeventfd has already been removed and the handler isn't

[Qemu-devel] [PULL 5/7] virtio-blk: fix race between .ioeventfd_stop() and vq handler

2018-03-09 Thread Stefan Hajnoczi
If the main loop thread invokes .ioeventfd_stop() just as the vq handler function begins in the IOThread then the handler may lose the race for the AioContext lock. By the time the vq handler is able to acquire the AioContext lock the ioeventfd has already been removed and the handler isn't

[Qemu-devel] [PULL 2/7] README: Fix typo 'git-publish'

2018-03-09 Thread Stefan Hajnoczi
From: Fam Zheng Reported-by: Alberto Garcia Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180306024328.19195-1-f...@redhat.com Signed-off-by: Stefan Hajnoczi --- README | 2

[Qemu-devel] [PULL 0/7] Block patches

2018-03-09 Thread Stefan Hajnoczi
The following changes since commit 0ab4537f08e09b13788db67efd760592fb7db769: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2018-03-07-1' into staging (2018-03-08 12:56:39 +) are available in the Git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL 1/7] block: Fix qemu crash when using scsi-block

2018-03-09 Thread Stefan Hajnoczi
From: Deepa Srinivasan Starting qemu with the following arguments causes qemu to segfault: ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name= iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1 This patch fixes blk_aio_ioctl() so it

[Qemu-devel] [PATCH v3 4/7] OvmfPkg: add customized Tcg2ConfigPei clone

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau The Tcg2ConfigPei module informs the firmware globally about the TPM device type, by setting the PcdTpmInstanceGuid PCD to the appropriate GUID value. The original module under SecurityPkg can perform device detection, or read a cached value

[Qemu-devel] [PATCH v3 5/7] OvmfPkg: include Tcg2Pei module

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau This module will initialize TPM device, measure reported FVs and BIOS version. We keep both SHA-1 and SHA-256 for the TCG 1.2 log format compatibility, but the SHA-256 measurements and TCG 2 log format are now recommended. Cc: Laszlo Ersek

Re: [Qemu-devel] [PATCH v4] iotests: Tweak 030 in order to trigger a race condition with parallel jobs

2018-03-09 Thread Alberto Garcia
On Fri 09 Mar 2018 01:54:31 PM CET, Max Reitz wrote: > On 2018-03-08 08:44, Alberto Garcia wrote: >> On Wed 07 Mar 2018 06:54:51 PM CET, Max Reitz wrote: v4: Mention that commit 1a63a907507fbbcfaee3f622907ec24 also contributes to solve the original bug (both commits need to

[Qemu-devel] [PATCH v3 7/7] OvmfPkg: plug DxeTpm2MeasureBootLib into SecurityStubDxe

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau The library registers a security management handler, to measure images that are not measure in PEI phase. For example with the qemu PXE rom: Loading driver at 0x0003E6C2000 EntryPoint=0x0003E6C9076 8086100e.efi And the following

[Qemu-devel] [PATCH v3 2/7] MdeModulePkg/Core/Pei: fix REGISITER -> REGISTER typo

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau No functional changes. Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marc-André Lureau Reviewed-by: Laszlo Ersek Reviewed-by: Star

[Qemu-devel] [PATCH v3 3/7] OvmfPkg: simplify SecurityStubDxe.inf inclusion

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau SecurityStubDxe.inf should be included unconditionally. Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH v3 0/7] ovmf: preliminary TPM2 support

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series adds basic TPM2 support for OVMF-on-QEMU (I haven't tested TPM1, for lack of interest). It links with the modules to initializes the device in PEI phase, and do measurements (both PEI and DXE). The Tcg2Dxe module

[Qemu-devel] [PATCH v3 1/7] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau The module doesn't use read-only variable. Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH v3 6/7] OvmfPkg: include Tcg2Dxe module

2018-03-09 Thread marcandre . lureau
From: Marc-André Lureau This module measures and log the boot environment. It also produces the Tcg2 protocol, which allows for example to read the log from OS. The linux kernel doesn't yet read the EFI_TCG2_EVENT_LOG_FORMAT_TCG_2, which is required for crypto-agile

Re: [Qemu-devel] [edk2] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

2018-03-09 Thread Marc-André Lureau
Hi On Thu, Mar 8, 2018 at 1:36 AM, Zhang, Chao B wrote: > Hi Lureau: >I think we can remove same dependency in TcgPei. > Thanks, feel free to explore that as a separate patch. This is out of scope to me. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v8 02/23] RISC-V ELF Machine Definition

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > Define RISC-V ELF machine EM_RISCV 243 > > Reviewed-by: Richard Henderson > Reviewed-by: Alistair Francis > Signed-off-by: Sagar Karandikar > Signed-off-by:

Re: [Qemu-devel] [PATCH v8 23/23] RISC-V Build Infrastructure

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > This adds RISC-V into the build system enabling the following targets: > > - riscv32-softmmu > - riscv64-softmmu > - riscv32-linux-user > - riscv64-linux-user > > This adds defaults configs for RISC-V, enables the build for the RISC-V > CPU core,

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-09 Thread Eduardo Habkost
On Fri, Mar 09, 2018 at 12:07:21PM +, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until > just before os_setup_post"): > > Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict > > until just before os_setup_post"): > > > I

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-09 Thread Eduardo Habkost
On Fri, Mar 09, 2018 at 11:33:35AM +, Ian Jackson wrote: > Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict > until just before os_setup_post"): > > On Thu, Mar 08, 2018 at 05:39:09PM +, Ian Jackson wrote: > > [...] > > > diff --git a/vl.c b/vl.c > > > +

Re: [Qemu-devel] [PATCH v4] iotests: Tweak 030 in order to trigger a race condition with parallel jobs

2018-03-09 Thread Max Reitz
On 2018-03-08 08:44, Alberto Garcia wrote: > On Wed 07 Mar 2018 06:54:51 PM CET, Max Reitz wrote: >>> v4: Mention that commit 1a63a907507fbbcfaee3f622907ec24 also >>> contributes to solve the original bug (both commits need to >>> reverted in order to reproduce this bug reliably). >>> >>>

Re: [Qemu-devel] [PATCH v8 13/23] RISC-V HART Array

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > Holds the state of a heterogenous array of RISC-V hardware threads. heterogeneous > > Reviewed-by: Richard Henderson > Signed-off-by: Sagar Karandikar > Signed-off-by: Michael Clark

Re: [Qemu-devel] [PATCH v8 07/23] RISC-V GDB Stub

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > GDB Register read and write routines. > > Reviewed-by: Richard Henderson > Signed-off-by: Sagar Karandikar > Signed-off-by: Michael Clark Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v8 19/23] SiFive RISC-V UART Device

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > QEMU model of the UART on the SiFive E300 and U500 series SOCs. > BBL supports the SiFive UART for early console access via the SBI > (Supervisor Binary Interface) and the linux kernel SBI console. > > The SiFive UART implements the pre qom legacy

Re: [Qemu-devel] [PATCH v12 10/28] include: add psp-sev.h header file

2018-03-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Mar 08, 2018 at 06:48:43AM -0600, Brijesh Singh wrote: > > The header file provide the ioctl command and structure to communicate > > with /dev/sev device. > > > > Cc: Paolo Bonzini > > Cc: Richard Henderson

Re: [Qemu-devel] [PATCH 02/25] hw/dma/i8257: Rename DMA_init() to i8257_dma_init()

2018-03-09 Thread Mark Cave-Ayland
On 09/03/18 10:43, Philippe Mathieu-Daudé wrote: Hi Mark, On 03/09/2018 11:32 AM, Mark Cave-Ayland wrote: On 08/03/18 22:39, Philippe Mathieu-Daudé wrote: - Move the header from hw/isa/ to hw/dma/ - Remove the old i386/pc dependency - use a bool type for the high_page_enable argument

Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable (-> binary images)

2018-03-09 Thread Liviu Ionescu
On 9 March 2018 at 13:58:06, Michael Clark (m...@sifive.com) wrote: > ... Hopefully we’ll have binary images for the various artefacts > on the Releases section on all of the riscv repos, > ... > It will be great when binaries are included with the GitHub Releases/tags > assuming we use GitHub

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-09 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post"): > Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until > just before os_setup_post"): > > How about this ? > > And here's the corresponding change to the

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-09 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post"): > How about this ? And here's the corresponding change to the Xen-specific patch. >From d6140681a877c4d468c4fcf5cac075cdffbea22c Mon Sep 17 00:00:00 2001 From: Ian Jackson

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-09 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post"): > Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict > until just before os_setup_post"): > > I don't think we should have accelerator-specific code in main(), > > if

Re: [Qemu-devel] [PATCH V3 3/4] vfio: Add struct vfio_vmstate_info to introduce put/get callback funtion for vfio device status save/restore

2018-03-09 Thread Dr. David Alan Gilbert
* Yulei Zhang (yulei.zh...@intel.com) wrote: > Introduce vfio_device_put/vfio_device_get funtion for vfio device state > save/restore usage. > > For VFIO pci device status migrate, on the source side with > funtion vfio_device_put to save the following states > 1. pci configuration space

Re: [Qemu-devel] [PATCH v8 17/23] SiFive RISC-V Test Finisher

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > Test finisher memory mapped device used to exit simulation. > > Acked-by: Richard Henderson > Signed-off-by: Palmer Dabbelt > Signed-off-by: Michael Clark > --- >

Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable

2018-03-09 Thread Michael Clark
On Sat, 10 Mar 2018 at 12:30 AM, Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 03/09/2018 12:17 PM, Michael Clark wrote: > > On Fri, 9 Mar 2018 at 11:45 PM, Peter Maydell > > wrote: > > > >> On 9 March 2018 at 04:22, Michael Clark

Re: [Qemu-devel] [PATCH v8 12/23] RISC-V HTIF Console

2018-03-09 Thread Philippe Mathieu-Daudé
Hi Michael, On 03/02/2018 02:51 PM, Michael Clark wrote: > HTIF (Host Target Interface) provides console emulation for QEMU. HTIF > allows identical copies of BBL (Berkeley Boot Loader) and linux to run > on both Spike and QEMU. BBL provides HTIF console access via the > SBI (Supervisor Binary

Re: [Qemu-devel] [PATCH V3 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

2018-03-09 Thread Dr. David Alan Gilbert
* Yulei Zhang (yulei.zh...@intel.com) wrote: > New VFIO sub region VFIO_REGION_SUBTYPE_DEVICE_STATE is added > to fetch and restore the status of mdev device vGPU during the > live migration. > > Signed-off-by: Yulei Zhang > --- > hw/vfio/pci.c | 14

[Qemu-devel] [Bug 1754038] Re: ARM M: Systick first wrap delayed (qemu-timers/icount prb?)

2018-03-09 Thread Antoine
The workaround I described above is actually not the good one, because of this check occurring just before: if (!all_cpu_threads_idle()) { return; } The exit request setting must be done before, so my code looks like this: CPUState *cpu; CPU_FOREACH(cpu) {

Re: [Qemu-devel] [PATCH] scsi: support NDOB (no data-out buffer) for WRITE SAME commands

2018-03-09 Thread Paolo Bonzini
On 09/03/2018 10:24, Fam Zheng wrote: > The standard says this bit is only allowed when UNMAP is set. Do we want to > check it here? I.e. > >if (!flags && (req->cmd.buf[1] & 0x1)) { >scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); >return; >

Re: [Qemu-devel] [edk2] [PATCH v2 8/8] ovmf: add DxeTpm2MeasureBootLib

2018-03-09 Thread Yao, Jiewen
Good idea. The additional message looks great!!! thank you! Yao, Jiewen > 在 2018年3月9日,下午6:26,Laszlo Ersek 写道: > > in

Re: [Qemu-devel] [PATCH v8 11/23] Add symbol table callback interface to load_elf

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/02/2018 02:51 PM, Michael Clark wrote: > The RISC-V HTIF (Host Target Interface) console device requires access > to the symbol table to locate the 'tohost' and 'fromhost' symbols. > > Reviewed-by: Richard Henderson > Signed-off-by: Michael Clark

Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable

2018-03-09 Thread Michael Clark
On Sat, 10 Mar 2018 at 12:17 AM, Michael Clark wrote: > On Fri, 9 Mar 2018 at 11:45 PM, Peter Maydell > wrote: > >> On 9 March 2018 at 04:22, Michael Clark wrote: >> > I need to dig into this. I'll need to take the assertions out, or

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-09 Thread Ian Jackson
Eduardo Habkost writes ("Re: [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post"): > On Thu, Mar 08, 2018 at 05:39:09PM +, Ian Jackson wrote: > [...] > > diff --git a/vl.c b/vl.c > > +xen_setup_post(); > > I don't think we should have accelerator-specific code

Re: [Qemu-devel] [PATCH] build: try improve handling of clang warnings

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 11:01, Gerd Hoffmann wrote: > This patch disables the pragma diagnostic -Wunused-but-set-variable for > clang in util/coroutine-ucontext.c. > > This in turn allows us to remove it from the configure check, so the > CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will

Re: [Qemu-devel] [PATCH] build: try improve handling of clang warnings

2018-03-09 Thread Thomas Huth
On 09.03.2018 12:01, Gerd Hoffmann wrote: > This patch disables the pragma diagnostic -Wunused-but-set-variable for > clang in util/coroutine-ucontext.c. > > This in turn allows us to remove it from the configure check, so the > CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang. > > With

Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable

2018-03-09 Thread Philippe Mathieu-Daudé
Hi Michael, On 03/09/2018 12:17 PM, Michael Clark wrote: > On Fri, 9 Mar 2018 at 11:45 PM, Peter Maydell > wrote: > >> On 9 March 2018 at 04:22, Michael Clark wrote: >>> I need to dig into this. I'll need to take the assertions out, or run >> with >>>

Re: [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize

2018-03-09 Thread Pierre Morel
On 09/03/2018 11:27, Cornelia Huck wrote: On Fri, 9 Mar 2018 10:23:31 +0100 Pierre Morel wrote: On 07/03/2018 17:29, Nia Alarie wrote: Signed-off-by: Nia Alarie What you do seems right to me, naming seems more logical, but  can you please

Re: [Qemu-devel] [PATCH] build: try improve handling of clang warnings

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/09/2018 12:01 PM, Gerd Hoffmann wrote: > This patch disables the pragma diagnostic -Wunused-but-set-variable for > clang in util/coroutine-ucontext.c. > > This in turn allows us to remove it from the configure check, so the > CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang. > >

<    1   2   3   4   5   >