On Tue 13 Mar 2018 07:23:36 PM CET, Eric Blake wrote:
>> +*refcount_cache_size =
>> +MIN(combined_cache_size, min_refcount_cache);
>
> but here, if combined_cache_size is smaller than min_refcount_cache,
>
>> +*l2_cache_size = combined_cache_size
From: "Daniel P. Berrange"
There are qemu_strtoNN functions for various sized integers. This adds two
more for plain int & unsigned int types, with suitable range checking.
Reviewed-by: Eric Blake
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrange
---
include/qemu/cutils.h |
On 12 March 2018 at 22:34, Eduardo Habkost wrote:
> The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12
> 16:14:37 +)
>
> are available in the Git reposito
The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
into staging (2018-03-13 14:02:47 +)
are available in the Git repository at:
https://github.com/berrange/qemu tags/socket-next-pull-req
I just tested the patch and it resolves this problem. Thanks!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1755479
Title:
Cortex M:qemu abort with optimized code and icount
Status in QEMU:
New
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> Allow migrate-start-postcopy for any postcopy type
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Mon, Mar 12, 2018 at 08:12:58PM +, Daniel P. Berrangé wrote:
> From: "Daniel P. Berrange"
>
> There are qemu_strtoNN functions for various sized integers. This adds two
> more for plain int & unsigned int types, with suitable range checking.
>
> Reviewed-by: Eric Blake
> Reviewed-by: Mar
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Juan Quintela
Reviewed-by: Fam Zheng
---
qapi/migration.json | 6 +-
migration/migration.h | 1 +
migration/migration.c | 9 +
3 files changed, 15 insertions(+), 1 deletion(-)
On Tue, Mar 13, 2018 at 04:27:08PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 04:20:19PM +, Peter Maydell wrote:
> > On 12 March 2018 at 20:12, Daniel P. Berrangé wrote:
> > > The following changes since commit
> > > 819fd4699c7b36d574292bcbd8bc25e9d716c84b:
> > >
> > > Merg
On Tue, Mar 13, 2018 at 09:42:51AM +0100, Paolo Bonzini wrote:
> On 08/03/2018 23:44, Eduardo Habkost wrote:
> >> I think doing so will be an issue for the migration. Consider your above
> >> use case, a SEV guest is running on EPYC with cbitpos=47 and if we
> >> migrate to some $NEXT AMD CPU which
Add special state, when qmp operations on the bitmap are disabled.
It is needed during bitmap migration. "Frozen" state is not
appropriate here, because it looks like bitmap is unchanged.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20180207155837.92351-5-vsemen
13.03.2018 21:22, Dr. David Alan Gilbert wrote:
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated.
If destination qemu is already containing a dirty bitmap with the same name
as a migrated bitmap (for the
On 03/13/2018 10:02 AM, Alberto Garcia wrote:
The L2 and refcount caches have default sizes that can be overriden
using the l2-cache-size and refcount-cache-size (an additional
parameter named cache-size sets the combined size of both caches).
Unless forced by one of the aforementioned parameter
On 03/13/2018 11:17 AM, Kevin Wolf wrote:
From: John Snow
Instead of automatically transitioning from PENDING to CONCLUDED, gate
the .prepare() and .commit() phases behind an explicit acknowledgement
provided by the QMP monitor if auto_finalize = false has been requested.
##
+# @block-job
Allow migrate-start-postcopy for any postcopy type
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 094196c236..59b4fe6090 100644
--- a/migration/migration
On 13 March 2018 at 18:23, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 04:27:08PM +, Daniel P. Berrangé wrote:
>> This feels unrelated to the series, so possibly a non-deterministic
>> failure
>
> Looking at the test source code, it has a 60 second wait for the
> emulator to print expe
From: "Daniel P. Berrange"
To prepare for handling more address types, refactor the parsing of
socket address information to make it more robust and extensible.
Reviewed-by: Eric Blake
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrange
---
chardev/char-socket.c | 22 +++
Add function opposite to qemu_get_counted_string.
qemu_put_counted_string puts one-byte length of the string (string
should not be longer than 255 characters), and then it puts the string,
without last zero byte.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Jua
From: "Daniel P. Berrange"
The SocketAddress struct has an "fd" type, which references the name of a
file descriptor passed over the monitor using the "getfd" command. We
currently blindly assume the FD is a socket, which can lead to hard to
diagnose errors later. This adds an explicit check that
Yes, it looks like we accidentally broke icount. This patch from the mailing
list fixes it:
https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg06595.html
though it hasn't been code-reviewed yet.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is sub
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20180207155837.92351-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 3 +++
block/dirty-bitmap.c | 28 ++--
2 files changed, 21 insertions(+), 1
On Tue, Mar 13, 2018 at 06:29:10PM +, Peter Maydell wrote:
> On 12 March 2018 at 22:34, Eduardo Habkost wrote:
> > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e:
> >
> > Merge remote-tracking branch
> > 'remotes/kraxel/tags/audio-20180312-pull-request' into sta
From: "Daniel P. Berrange"
Instead of just checking whether it is possible to bind() on a socket, also
check that we can successfully connect() to the socket we bound to. This
more closely replicates the level of functionality that tests will actually
use.
Reviewed-by: Eric Blake
Reviewed-by: M
From: Luke Shumaker
init_guest_commpage needs to check if the mapped space, which ends at
real_start+real_size overlaps with where it needs to put the commpage,
which is (assuming sane qemu_host_page_size) guest_base + 0x000, where
guest_base is real_start - guest_start.
[guest_base][
On 03/13/2018 10:02 AM, Alberto Garcia wrote:
We have just reduced the refcount cache size to the minimum unless
the user explicitly requests a larger one, so we have to update the
documentation to reflect this change.
Signed-off-by: Alberto Garcia
---
docs/qcow2-cache.txt | 31 ++
From: "Daniel P. Berrange"
The test-io-channel-socket.c file has some useful helper functions for
checking if a specific IP protocol is available. Other tests need to
perform similar kinds of checks to avoid running tests that will fail
due to missing IP protocols.
Reviewed-by: Eric Blake
Revie
From: Luke Shumaker
Signed-off-by: Luke Shumaker
Message-Id: <20171228180814.9749-10-luke...@lukeshu.com>
Reviewed-by: Peter Maydell
Signed-off-by: Laurent Vivier
---
linux-user/elfload.c | 4
1 file changed, 4 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated.
>
> If destination qemu is already containing a dirty bitmap with the same name
> as a migrated bitmap (for the same node), then, if their granularities ar
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> There would be savevm states (dirty-bitmap) which can migrate only in
> postcopy stage. The corresponding pending is introduced here.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Dr. David Alan Gilbert
> ---
>
From: Luke Shumaker
Instead of doing
if (check1) {
if (check2) {
success;
}
}
retry;
Do a clearer
if (!check1) {
goto try_again;
}
if (!check2) {
goto try_again;
}
su
On 12 March 2018 at 22:11, Eduardo Habkost wrote:
> The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12
> 16:14:37 +)
>
> are available in the Git reposito
From: Luke Shumaker
If the ensure-alignment code gets triggered, then the
"if (host_start && real_start != current_start)" check will always trigger,
so save 2 syscalls and put that check first.
Note that we can't just switch to using MAP_FIXED for that check, because
then we couldn't differenti
From: Max Filippov
target_mprotect/target_munmap return value goes through get_errno at the
call site, thus the functions must either set errno to host error code
and return -1 or return negative guest error code. Do the latter.
Cc: qemu-sta...@nongnu.org
Cc: Riku Voipio
Cc: Laurent Vivier
Sig
From: "Daniel P. Berrange"
Even if common tn3270 implementations do not support TLS, it is trivial to
have them proxied over a proxy like stunnel which adds TLS at the sockets
layer. We should thus not silently skip tn3270 protocol initialization
when TLS is enabled.
Reviewed-by: Eric Blake
Ack
Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated.
If destination qemu is already containing a dirty bitmap with the same name
as a migrated bitmap (for the same node), then, if their granularities are
the same the migration will be done, otherwise the error will be genera
From: Luke Shumaker
There are 3 parts to this change:
- Add a comment showing the relative sizes and positions of the blocks of
memory
- introduce and use new aligned_{start,size} instead of adjusting
real_{start_size}
- When we clean up (on failure), munmap(real_start, real_size) instea
qemu-binfmt-conf.sh when it is used with systemd
needs to know for which CPU the systemd-binfmt.service
file must be created (i.e. "--systemd ppc").
But sometime, for instance for test purpose, we need to
create an entry for all known architectures.
This patch entroduce the "ALL" parameter for thi
The test starts two vms (vm_a, vm_b), create dirty bitmap in
the first one, do several writes to corresponding device and
then migrate vm_a to vm_b.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/169 | 156 +
tests/qemu-iotests/
The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44:
memory: fix flatview_access_valid RCU read lock/unlock imbalance (2018-03-09
15:55:20 +)
are available in the Git repository at:
git://github.com/vivier/qemu.git tags/linux-user-for-2.12-pull-request
for you t
Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so
to disable them and stop transporting empty sections there is a new
savevm handler.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
Reviewed-by: John Snow
Reviewed-by: Fam Zheng
---
include/migrati
From: Luke Shumaker
init_guest_commpage is a much more honest description of what the function
does. validate_guest_space not only suggests that the function has no
side-effects, but also introduces confusion as to why it is only needed on
32-bit ARM targets.
Signed-off-by: Luke Shumaker
Messa
Enable postcopy if dirty bitmap migration is enabled.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Juan Quintela
Reviewed-by: John Snow
Reviewed-by: Fam Zheng
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migr
There would be savevm states (dirty-bitmap) which can migrate only in
postcopy stage. The corresponding pending is introduced here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/migration/register.h | 17 +++--
migration/savevm.h | 5 +++--
hw/s390x/s390-stattrib
From: Peter Maydell
Now we've dropped unicore32, all of the architectures we support
for linux-user implement the signal handling routines. The
dummy "just print a message" versions are unimplemented, so we
can drop them entirely.
Signed-off-by: Peter Maydell
Reviewed-by: Laurent Vivier
Messag
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180313161803.1814-1-kw...@redhat.com
Subject: [Qemu-devel] [PULL 00/41] Block layer patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $
Hi all!
There is a new version of dirty bitmap postcopy migration series.
Patches 01-04 are directly from John's branch
https://github.com/jnsnow/qemu/tree/bitmaps
, they are included only for patchew.
v11
clone: tag postcopy-v11 from https://src.openvz.org/scm/~vsementsov/qemu.git
online:
ht
Enabling bitmap successor is necessary to enable successors of bitmaps
being migrated before target vm start.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Reviewed-by: Fam Zheng
Message-id: 20180207155837.92351-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
incl
On 03/13/2018 08:18 PM, John Snow wrote:
>
> On 11/28/2017 07:10 AM, Denis V. Lunev wrote:
>> There are 2 cases I have spotted so far:
>> 1) IDE ATAPI read processing. Actually this was reported from field
>> 2) QEMU IO hmp command (found during evaluation of (1))
>>
>> SCSI code checks during acce
Test
- start two vms (vm_a, vm_b)
- in a
- do writes from set A
- do writes from set B
- fix bitmap sha256
- clear bitmap
- do writes from set A
- start migration
- than, in b
- wait vm start (postcopy should start)
- do writes from set B
- check bitmap sha256
From: Vladimir Sementsov-Ogievskiy
Minimal realization: only one extent in server answer is supported.
Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180312152126.286890-6-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
[e
Like other setters here these functions should take a lock.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fam Zheng
Reviewed-by: John Snow
Message-id: 20180207155837.92351-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 85
From: Vladimir Sementsov-Ogievskiy
It is ok, that fatal error hides previous not fatal, but hiding
first fatal error is a bad feature.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20180312152126.286890-5-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
-
On 13 March 2018 at 17:18, Bastian Koppelmann
wrote:
> On 03/09/2018 04:13 PM, Alex Bennée wrote:
>>
>> Bastian Koppelmann writes:
>
> [...]
>>>
>>> I always saw it as a big plus that QEMU supports nearly any
>>> architecture, no matter how obscure it is. So I'm a bit more hesitant on
>>> droppin
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> 12.03.2018 19:09, Dr. David Alan Gilbert wrote:
> > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> > > Postcopy migration of dirty bitmaps. Only named dirty bitmaps are
> > > migrated.
> > >
> > > +
> > > +
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20180312152126.286890-7-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --
From: Vladimir Sementsov-Ogievskiy
NBD_REP_ERR_INVALID is often parameter to nbd_opt_drop and it would
be used more in following patches. So, let's add a helper.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20180312152126.286890-2-vsement...@virtuozzo.com>
S
From: Luke Shumaker
Signed-off-by: Luke Shumaker
Message-Id: <20171228180814.9749-7-luke...@lukeshu.com>
Reviewed-by: Peter Maydell
Signed-off-by: Laurent Vivier
---
linux-user/elfload.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index
From: Vladimir Sementsov-Ogievskiy
Simple way to have auto generated filenames with auto cleanup. Like
FilePath but without using 'with' statement and without additional
indentation of the whole test.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180312152126.286890-8-vsement...@vi
From: Vladimir Sementsov-Ogievskiy
Split out request handling logic.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180308184636.178534-6-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
[eblake: touch up blank line placement]
Signed-off-by: Eric Blake
---
nbd/server.c | 128 +++
From: Luke Shumaker
We'll just exit with an error anyway, so it doesn't really matter, but it
is cleaned up in all of the other places were we error out.
Signed-off-by: Luke Shumaker
Message-Id: <20171228180814.9749-4-luke...@lukeshu.com>
Reviewed-by: Peter Maydell
Signed-off-by: Laurent Vivie
From: Luke Shumaker
Instead of defining a bogus validate_guest_space that always returns 1 on
targets other than 32-bit ARM, use #if blocks to only call it on 32-bit ARM
targets. This makes the "normal" flow control clearer.
Signed-off-by: Luke Shumaker
Message-Id: <20171228180814.9749-2-luke.
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180312152126.286890-9-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/209 | 34 ++
tests/qemu-iotests/209.out | 2 ++
tests/qemu-iotests
From: Max Filippov
target_msync is not used, remove its declaration and implementation.
Cc: Riku Voipio
Cc: Laurent Vivier
Signed-off-by: Max Filippov
Reviewed-by: Laurent Vivier
Message-Id: <20180228221609.11265-9-jcmvb...@gmail.com>
Signed-off-by: Laurent Vivier
---
linux-user/mmap.c | 1
From: Stefan Hajnoczi
Commit 2019ba0a0197 ("block: Add AioContextNotifier functions to BB")
added blk_add/remove_aio_context_notifier() and implemented them by
passing through the bdrv_*() equivalent.
This doesn't work across bdrv_append(), which detaches child->bs and
re-attaches it to a new Bl
From: Stefan Hajnoczi
This test case adds an NBD server export and then invokes
blockdev-snapshot-sync, which changes the BlockDriverState node that the
NBD server's BlockBackend points to. This is an interesting scenario to
test and exercises the code path fixed by the previous commit.
Signed-
From: Peter Maydell
We dropped the unicore32-linux-user target in commit 5e2b40f7271cf9
in 2016. Nobody has made any attempt to fix the issues that
caused us to drop it, so remove the associated code.
(The system emulation parts of unicore32 remain.)
Signed-off-by: Peter Maydell
Reviewed-by: La
From: Vladimir Sementsov-Ogievskiy
To be reused in nbd_co_send_sparse_read() in the following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180308184636.178534-2-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
Signed-off-by: Eric Blake
---
nbd/server.c | 48
From: Max Filippov
Register qemu-xtensa and qemu-xtensaeb for transparent linux userspace
emulation.
Cc: Riku Voipio
Cc: Laurent Vivier
Signed-off-by: Max Filippov
Reviewed-by: Laurent Vivier
Message-Id: <20180228221609.11265-11-jcmvb...@gmail.com>
Signed-off-by: Laurent Vivier
---
scripts
Commit afe35cde6 added additional actions to test 33, but forgot
to reset the image between tests. As a result, './check -nbd 33'
fails because the qemu-nbd process from the first half is still
occupying the port, preventing the second half from starting a
new qemu-nbd process. Worse, the failure
From: Max Filippov
In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger
than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when
mmap, munmap, mprotect, mremap or shmat is called for an address outside
the guest address space. mmap and mprotect should return ENOMEM i
From: Shea Levy
Signed-off-by: Shea Levy
Reviewed-by: Laurent Vivier
Message-Id: <2018030500.15717-1-s...@shealevy.com>
Signed-off-by: Laurent Vivier
---
linux-user/syscall.c | 5 +
linux-user/syscall_defs.h | 41 +++--
2 files changed, 24 ins
From: Vladimir Sementsov-Ogievskiy
In case of io error in nbd_co_send_sparse_read we should not
"goto reply:", as it was a fatal error and the common behavior
is to disconnect in this case. We should not try to send the
client an additional error reply, since we already hit a
channel-io error on
The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
into staging (2018-03-13 14:02:47 +)
are available in the Git repository at:
git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-03-13
From: Max Filippov
shmdt fails to call mmap_lock/mmap_unlock around page_set_flags,
resulting in the following assertion:
page_set_flags: Assertion `have_mmap_lock()' failed.
Wrap shmdt internals into mmap_lock/mmap_unlock.
Cc: qemu-sta...@nongnu.org
Cc: Riku Voipio
Cc: Laurent Vivier
Signe
Hi Alex,
On 13/03/18 17:56, Alex Williamson wrote:
> [Cc +Eric]
>
> On Tue, 13 Mar 2018 15:53:19 +1100
> Alexey Kardashevskiy wrote:
>
>> On 7/3/18 1:17 pm, Alexey Kardashevskiy wrote:
>>> On 26/02/18 19:36, Alexey Kardashevskiy wrote:
On 19/02/18 13:46, Alexey Kardashevskiy wrote:
>>>
On 03/13/2018 12:33 PM, Vladimir Sementsov-Ogievskiy wrote:
> 13.03.2018 19:16, John Snow wrote:
>>
>> On 03/13/2018 12:14 PM, Vladimir Sementsov-Ogievskiy wrote:
>>> Hmm, I agree, it is the simplest thing we can do for now, and I'll
>>> rethink later,
>>> how (and is it worth doing) to go to pos
On 01/19/2018 06:03 PM, Eric Blake wrote:
> On 01/19/2018 04:47 PM, John Snow wrote:
>> Adjust each caller of raw_open_common to specify if they are expecting
>> host and character devices or not. Tighten expectations of file types upon
>> open in the common code and refuse types that are not exp
On 03/09/2018 04:13 PM, Alex Bennée wrote:
Bastian Koppelmann writes:
[...]
I always saw it as a big plus that QEMU supports nearly any
architecture, no matter how obscure it is. So I'm a bit more hesitant on
dropping architectures quickly.
All things being equal I agree, however there is a m
On 13 March 2018 at 16:55, Andrew Baumann wrote:
>> From: Qemu-devel > bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter
>> Maydell
>> Sent: Tuesday, 13 March 2018 08:35
>>
>> Now we have separate types for BCM2386 and BCM2387, we might as well
>> just hard-code the CPU type they
On 11/28/2017 07:10 AM, Denis V. Lunev wrote:
> There are 2 cases I have spotted so far:
> 1) IDE ATAPI read processing. Actually this was reported from field
> 2) QEMU IO hmp command (found during evaluation of (1))
>
> SCSI code checks during access that blk_is_available(). These patches add
>
The NBD spec states that since trim requests can affect disk contents,
then they should allow for FUA semantics just like writes for ensuring
the disk has settled before returning. As bdrv_[co_]pdiscard() does
not support a flags argument, we can't pass FUA down the block layer
stack, and must the
On 12 March 2018 at 10:31, Abdallah Bouassida
wrote:
> This is a callback to set the cp-regs registered by the dynamic XML.
>
> Signed-off-by: Abdallah Bouassida
> ---
>>> Adding to that our customers may need this write access, our tool TRACE32®
>>> needs this also in some particular cases. For
From: Vladimir Sementsov-Ogievskiy
Since the unchanged code has just set client->recv_coroutine to
NULL before calling nbd_client_receive_next_request(), we are
spawning a new coroutine unconditionally, but the first thing
that coroutine will do is check for client->closing, making it
a no-op if
From: Vladimir Sementsov-Ogievskiy
Minimal realization: only one extent in server answer is supported.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180312152126.286890-4-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
[eblake: tweak whitespace, move constant from .h to .c, impr
[Cc +Eric]
On Tue, 13 Mar 2018 15:53:19 +1100
Alexey Kardashevskiy wrote:
> On 7/3/18 1:17 pm, Alexey Kardashevskiy wrote:
> > On 26/02/18 19:36, Alexey Kardashevskiy wrote:
> >> On 19/02/18 13:46, Alexey Kardashevskiy wrote:
> >>> On 16/02/18 16:28, David Gibson wrote:
> On Wed, Feb
From: Vladimir Sementsov-Ogievskiy
Add helper to read name in format:
uint32 len (<= NBD_MAX_NAME_SIZE)
len bytes string (not 0-terminated)
The helper will be reused in following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20180312152126.286890-3-vsement...@virtu
> From: Qemu-devel bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter
> Maydell
> Sent: Tuesday, 13 March 2018 08:35
>
> Now we have separate types for BCM2386 and BCM2387, we might as well
> just hard-code the CPU type they use rather than having it passed
> through as an object
From: Vladimir Sementsov-Ogievskiy
nbd_trip has difficult logic when sending replies: it tries to use one
code path for all replies. It is ok for simple replies, but is not
comfortable for structured replies. Also, two types of error (and
corresponding messages in local_err) - fatal (leading to d
The log backend is the default one, we don't need to explicitly set it.
Signed-off-by: Alex Bennée
Reviewed-by: Daniel P. Berrangé
diff --git a/.travis.yml b/.travis.yml
index 79377c8de0..92c343a1ef 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -50,7 +50,7 @@ env:
- MAKEFLAGS="-j3"
matr
On 12 March 2018 at 10:31, Abdallah Bouassida
wrote:
> Generate an XML description for the cp-regs.
> Register these regs with the gdb_register_coprocessor().
> Add arm_gdb_get_sysreg() to use it as a callback to read those regs.
> Add a dummy arm_gdb_set_sysreg().
>
> Signed-off-by: Abdallah Boua
* Juan Quintela (quint...@redhat.com) wrote:
> We set the x-multifd-page-count and x-multifd-channels.
>
> Signed-off-by: Juan Quintela
This should probably go nearer the end of the series;
we've also got the problem that things are a bit delicate with TCG so
adding more migration tests probabl
On 13 March 2018 at 16:48, Andrew Baumann wrote:
>> From: Peter Maydell
>> Sent: Tuesday, 13 March 2018 08:35
>>
>> The BCM2837 sets the Aff1 field of the MPIDR affinity values for the
>> CPUs to 0, whereas the BCM2836 uses 0xf. Set this correctly, as it
>> is required for Linux to boot.
>>
>> Si
> From: Qemu-devel bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter
> Maydell
> Sent: Tuesday, 13 March 2018 08:35
>
> Our BCM2836 type is really a generic one that can be any of
> the bcm283x family. Rename it accordingly. We change only
> the names which are visible via the h
As the build times have risen we keep timing out. Split the default
config into system and user builds.
Signed-off-by: Alex Bennée
Reviewed-by: Daniel P. Berrangé
diff --git a/.travis.yml b/.travis.yml
index 92c343a1ef..75e5b408d0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -49,7 +49,8 @@ env
Daniel P. Berrangé writes:
> On Tue, Mar 13, 2018 at 03:32:10PM +, Alex Bennée wrote:
>> The tools are already built elsewhere so we might as well not build it
>> here as we just need to test the modules build of QEMU itself.
>>
>> Signed-off-by: Alex Bennée
>> ---
>> .travis.yml | 2 +-
>>
> From: Peter Maydell
> Sent: Tuesday, 13 March 2018 08:35
>
> The bcm2837 is pretty similar to the bcm2836, but it does have
> some differences. Notably, the MPIDR affinity aff1 values it
> sets for the CPUs are 0x0, rather than the 0xf that the bcm2836
> uses, and if this is wrong Linux will no
> From: Qemu-devel bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter
> Maydell
> Sent: Tuesday, 13 March 2018 08:35
>
> The TypeInfo and state struct for bcm2386 disagree about what the
> parent class is -- the TypeInfo says it's TYPE_SYS_BUS_DEVICE,
> but the BCM2386State struc
As all the disabled features only affect system emulation we might as
well disable user mode to save compile time.
Signed-off-by: Alex Bennée
Reviewed-by: Daniel P. Berrangé
diff --git a/.travis.yml b/.travis.yml
index 75e5b408d0..c1e99237b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -52,7 +
12.03.2018 19:09, Dr. David Alan Gilbert wrote:
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated.
If destination qemu is already containing a dirty bitmap with the same name
as a migrated bitmap (for the
13.03.2018 19:16, John Snow wrote:
On 03/13/2018 12:14 PM, Vladimir Sementsov-Ogievskiy wrote:
Hmm, I agree, it is the simplest thing we can do for now, and I'll
rethink later,
how (and is it worth doing) to go to postcopy automatically in case of
only-dirty-bitmaps.
Should I respin?
Please do
201 - 300 of 563 matches
Mail list logo