[Qemu-devel] [PATCH] vfio/pci-quirks.c: Make stolen memory size adjustable for igd VFIO

2018-04-10 Thread Xiong Zhang
Currenly linux guest with kernel above 3.19 couldn't boot up on igd passthrough env. The root case is i915 driver use stolen memory, but qemu vfio doesn't support it. This patch set stolen memory size to zero default, so guest i915 won't use it. But this breaks old windows igd driver which will

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread David Gibson
On Wed, Apr 11, 2018 at 10:31:28AM +0530, Bharata B Rao wrote: > On Wed, Apr 11, 2018 at 02:45:58PM +1000, David Gibson wrote: > > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: [snip] > > > @@ -2927,6 +3082,15 @@ static void spapr_instance_init(Object *obj) > > >

Re: [Qemu-devel] [qemu-s390x] [PATCH 09/10] target/s390x: avoid integer overflow in next_page PC check

2018-04-10 Thread Thomas Huth
On 10.04.2018 18:19, Emilio G. Cota wrote: > If the PC is in the last page of the address space, next_page_start > overflows to 0. Fix it. > > Cc: Cornelia Huck > Cc: Alexander Graf > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org >

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread Bharata B Rao
On Wed, Apr 11, 2018 at 02:45:58PM +1000, David Gibson wrote: > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: > > The new property ibm,dynamic-memory-v2 allows memory to be represented > > in a more compact manner in device tree. > > > > Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread David Gibson
On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: > The new property ibm,dynamic-memory-v2 allows memory to be represented > in a more compact manner in device tree. > > Signed-off-by: Bharata B Rao > --- > v1:

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread David Gibson
On Tue, Apr 10, 2018 at 09:45:21AM +0530, Bharata B Rao wrote: > On Tue, Apr 10, 2018 at 01:02:45PM +1000, David Gibson wrote: > > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: > > > The new property ibm,dynamic-memory-v2 allows memory to be represented > > > in a more compact

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread David Gibson
On Wed, Apr 11, 2018 at 01:56:14PM +1000, Alexey Kardashevskiy wrote: 1;5002;0c> On 10/4/18 1:02 pm, David Gibson wrote: > > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: > >> The new property ibm,dynamic-memory-v2 allows memory to be represented > >> in a more compact manner in

Re: [Qemu-devel] [RFC PATCH v2] spapr: Support ibm, dynamic-memory-v2 property

2018-04-10 Thread Alexey Kardashevskiy
On 10/4/18 1:02 pm, David Gibson wrote: > On Mon, Apr 09, 2018 at 11:55:38AM +0530, Bharata B Rao wrote: >> The new property ibm,dynamic-memory-v2 allows memory to be represented >> in a more compact manner in device tree. > > I still need to look at this in more detail, but to start with: >

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-10 Thread Peter Xu
On Wed, Apr 11, 2018 at 09:45:32AM +0800, Stefan Hajnoczi wrote: > On Tue, Apr 10, 2018 at 08:49:13PM +0800, Peter Xu wrote: > > cur_mon was only used in main loop so we don't really need that to be > > per-thread variable. Now it's possible that we have more than one > > thread to operate on it.

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-10 Thread Peter Xu
On Tue, Apr 10, 2018 at 08:54:31AM -0500, Eric Blake wrote: > On 04/10/2018 07:49 AM, Peter Xu wrote: > > cur_mon was only used in main loop so we don't really need that to be > > per-thread variable. Now it's possible that we have more than one > > thread to operate on it. Let's start to let it

Re: [Qemu-devel] [PATCH 1/2] qemu-thread: always keep the posix wrapper layer

2018-04-10 Thread Peter Xu
On Tue, Apr 10, 2018 at 08:35:40AM -0500, Eric Blake wrote: > On 04/10/2018 07:49 AM, Peter Xu wrote: > > We will conditionally have a wrapper layer depending on whether the host > > has the PTHREAD_SETNAME capability. It complicates stuff. Let's just > > keep the wrapper there, meanwhile we opt

Re: [Qemu-devel] [PATCH 7/8] virtio: get avail bytes check for packed ring

2018-04-10 Thread Jason Wang
On 2018年04月04日 20:54, w...@redhat.com wrote: From: Wei Xu mostly as same as 1.0, copy it separately for prototype, need a refactoring. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 142 +++-- 1 file

Re: [Qemu-devel] [PATCH 6/8] virtio: flush/push support for packed ring

2018-04-10 Thread Jason Wang
On 2018年04月04日 20:54, w...@redhat.com wrote: From: Wei Xu Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 104 + 1 file changed, 90 insertions(+), 14 deletions(-) diff --git a/hw/virtio/virtio.c

Re: [Qemu-devel] [PATCH 8/8] virtio: queue pop support for packed ring

2018-04-10 Thread Jason Wang
On 2018年04月04日 20:54, w...@redhat.com wrote: From: Wei Xu cloned from split ring pop, a global static length array and the inside-element length array are introduced to easy prototype, this consumes more memory and it is valuable to move to dynamic allocation as the out/in

Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support

2018-04-10 Thread Wei Xu
On Tue, Apr 10, 2018 at 11:46:47AM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:53, w...@redhat.com wrote: > >From: Wei Xu > > > >This is a prototype for virtio-net 1.1 support in userspace backend, > >only minimum part are included in this RFC(roughly synced to v8 as >

Re: [Qemu-devel] [PATCH for-2.12] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-10 Thread Wanpeng Li
2018-04-11 5:15 GMT+08:00 Eduardo Habkost : > The assumption in the cpu->max_features code is that anything > enabled on GET_SUPPORTED_CPUID should be enabled on "-cpu host". > This shouldn't be the case for FEAT_KVM_HINTS. > > This adds a new

Re: [Qemu-devel] [PATCH for-2.12] commit/stream: Reset delay_ns

2018-04-10 Thread Stefan Hajnoczi
On Tue, Apr 10, 2018 at 10:58:09AM +0200, Kevin Wolf wrote: > Streaming and the commit block job only want to apply throttling when > they actually copied data instead of skipping it, so they made the > calculation of delay_ns conditional. However, delay_ns isn't reset when > skipping some

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-10 Thread Stefan Hajnoczi
On Tue, Apr 10, 2018 at 08:49:13PM +0800, Peter Xu wrote: > cur_mon was only used in main loop so we don't really need that to be > per-thread variable. Now it's possible that we have more than one > thread to operate on it. Let's start to let it be per-thread variable. Trying to understand the

Re: [Qemu-devel] [PATCH v3 01/15] tests: add fp-test, a floating point test suite

2018-04-10 Thread Alex Bennée
Alex Bennée writes: > Emilio G. Cota writes: > >> This will allow us to run correctness tests against our >> FP implementation. The test can be run in two modes (called >> "testers"): host and soft. With the former we check the results >> and FP flags on

Re: [Qemu-devel] [PATCH] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-10 Thread David Gibson
On Tue, 10 Apr 2018 11:02:36 +0100 "Dr. David Alan Gilbert" wrote: > * David Gibson (dgib...@redhat.com) wrote: > > On Mon, 9 Apr 2018 19:57:47 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: >

Re: [Qemu-devel] [PATCH v3 01/15] tests: add fp-test, a floating point test suite

2018-04-10 Thread Alex Bennée
Emilio G. Cota writes: > This will allow us to run correctness tests against our > FP implementation. The test can be run in two modes (called > "testers"): host and soft. With the former we check the results > and FP flags on the host machine against the model. > With the

[Qemu-devel] [Bug 1762707] Re: VFIO device gets DMA failures when virtio-balloon leak from highmem to lowmem

2018-04-10 Thread Pixel, Ding
I think we can raise this issue to libvirt. When using virsh or virt- manager, the memory balloon is still enabled by default even if there's a device assignment. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1762707] Re: VFIO device gets DMA failures when virtio-balloon leak from highmem to lowmem

2018-04-10 Thread Pixel, Ding
Hi Alex, Thanks for your confirming. change the status to invalid. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1762707 Title: VFIO device gets

Re: [Qemu-devel] [PATCH 00/10] Avoid integer overflow in next_page_start

2018-04-10 Thread Richard Henderson
On 04/11/2018 02:19 AM, Emilio G. Cota wrote: > Richard pointed out in another thread that when computing > next_page_start we can break checks for the last page in the > address space due to integer overflow. This affects several targets; > the appended fixes them. > > You can fetch the patches

Re: [Qemu-devel] [PATCH for 2.13 v2 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-10 Thread David Gibson
On Tue, Apr 10, 2018 at 02:12:25PM -0400, Serhii Popovych wrote: > Now recent kernels (i.e. since linux-stable commit a346137e9142 > ("powerpc/numa: Use ibm,max-associativity-domains to discover possible nodes") > support this property to mark initially memory-less NUMA nodes as "possible" > to

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-10 Thread Richard Henderson
On 04/10/2018 11:45 PM, Bastian Koppelmann wrote: > On 04/10/2018 03:40 PM, Emilio G. Cota wrote: >> On Tue, Apr 10, 2018 at 15:16:19 +0200, Bastian Koppelmann wrote: >>> On 04/10/2018 03:03 PM, Emilio G. Cota wrote: On Tue, Apr 10, 2018 at 14:24:23 +1000, Richard Henderson wrote: > On

[Qemu-devel] [PULL for-2.12 1/1] icount: fix cpu_restore_state_from_tb for non-tb-exit cases

2018-04-10 Thread Richard Henderson
From: Pavel Dovgalyuk In icount mode, instructions that access io memory spaces in the middle of the translation block invoke TB recompilation. After recompilation, such instructions become last in the TB and are allowed to access io memory spaces. When the code

[Qemu-devel] [PULL for-2.12 0/1] tcg patch queue

2018-04-10 Thread Richard Henderson
The following changes since commit 26d6a7c87b05017ffabffb5e16837a0fccf67e90: Merge remote-tracking branch 'remotes/ericb/tags/pull-qapi-2018-04-10' into staging (2018-04-10 22:16:19 +0100) are available in the Git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20180411 for

Re: [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-10 Thread Richard Henderson
On 04/11/2018 12:23 AM, Emilio G. Cota wrote: > case DISAS_STOP: > -gen_goto_tb(, 0, ctx.pc); > +tcg_gen_lookup_and_goto_ptr(); You need to write ctx.pc back to the pc first, e.g. gen_save_pc(ctx.pc); tcg_gen_lookup_and_goto_ptr(); r~

Re: [Qemu-devel] [Bug 1760262] Re: cmsdk-apb-uart doesn't appear to clear interrupt flags

2018-04-10 Thread Patrick Oppenlander
On Tue, Apr 10, 2018 at 11:45 PM, Peter Maydell wrote: > > Thanks for the bug report; I've submitted this patch (which is similar to but > not quite the same as your fix): > https://patchwork.ozlabs.org/patch/896715/ > > Hopefully this will get into 2.12, but we're

[Qemu-devel] [PATCH v6 9/9] i386: Remove generic SMT thread check

2018-04-10 Thread Babu Moger
Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae ---

[Qemu-devel] [PATCH v6 7/9] i386: Add support for CPUID_8000_001E for AMD

2018-04-10 Thread Babu Moger
Populate threads/core_id/apic_ids/socket_id when CPUID_EXT3_TOPOEXT feature is supported. This is required to support hyperthreading feature on AMD CPUs. This is supported via CPUID_8000_001E extended functions. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae

[Qemu-devel] [PATCH v6 5/9] i386: Use the statically loaded cache definitions

2018-04-10 Thread Babu Moger
Use the statically loaded cache definitions if available and legacy-cache parameter is not set. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae --- target/i386/cpu.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v6 3/9] i386: Initialize cache information for EPYC family processors

2018-04-10 Thread Babu Moger
Initialize pre-determined cache information for EPYC processors. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae --- target/i386/cpu.c | 96 +++ 1 file changed, 96 insertions(+) diff --git

[Qemu-devel] [PATCH v6 6/9] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D

2018-04-10 Thread Babu Moger
Add information for cpuid 0x801D leaf. Populate cache topology information for different cache types(Data Cache, Instruction Cache, L2 and L3) supported by 0x801D leaf. Please refer Processor Programming Reference (PPR) for AMD Family 17h Model for more details. Signed-off-by: Babu Moger

[Qemu-devel] [PATCH v6 4/9] i386: Add new property to control cache info

2018-04-10 Thread Babu Moger
This will be used to control the cache information. By default new information will be displayed. If user passes "-cpu legacy-cache" then older information will be displayed even if the hardware supports new information. It will be "on" for machine type "pc-q35-2.10" for compatibility.

[Qemu-devel] [PATCH v6 8/9] i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-04-10 Thread Babu Moger
Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x801E. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae --- target/i386/cpu.c | 11 +-- 1 file changed, 9 insertions(+),

[Qemu-devel] [PATCH v6 2/9] i386: Add cache information in X86CPUDefinition

2018-04-10 Thread Babu Moger
Add cache information in X86CPUDefinition and CPUX86State. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae --- target/i386/cpu.c | 4 target/i386/cpu.h | 8 2 files changed, 12 insertions(+) diff --git a/target/i386/cpu.c

[Qemu-devel] [PATCH v6 0/9] i386: Enable TOPOEXT to support hyperthreading on AMD CPU

2018-04-10 Thread Babu Moger
This series enables the TOPOEXT feature for AMD CPUs. This is required to support hyperthreading on kvm guests. This addresses the issues reported in these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481253 https://bugs.launchpad.net/qemu/+bug/1703506 v6: 1.Fixed problem with patch#4(Add

[Qemu-devel] [PATCH v6 1/9] i386: Helpers to encode cache information consistently

2018-04-10 Thread Babu Moger
From: Eduardo Habkost Instead of having a collection of macros that need to be used in complex expressions to build CPUID data, define a CPUCacheInfo struct that can hold information about a given cache. Helper functions will take a CPUCacheInfo struct as input to encode

Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2018-04-10, 2.12-rc3

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 14:21, Eric Blake wrote: > The following changes since commit fb4fe32d5b6290deabe752b51cc1cc2a9e8573db: > > Merge remote-tracking branch 'remotes/xtensa/tags/20180409-xtensa' into > staging (2018-04-10 10:22:45 +0100) > > are available in the Git

[Qemu-devel] [Bug 1036363] Re: Major network performance problems on AMD hardware

2018-04-10 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [Bug 1192065] Re: qemu release memory to system

2018-04-10 Thread Thomas Huth
Looking through old bug tickets... I think you should rather use hotpluggable memory here for the guests instead - or use a big swap partition on the host. Anyway, this is not a bug, so closing this ticket now. ** Changed in: qemu Status: New => Invalid -- You received this bug

Re: [Qemu-devel] [PATCH] qmp: add pmemload command

2018-04-10 Thread Eric Blake
On 04/10/2018 04:24 PM, Simon Ruderich wrote: > Adapted patch from Baojun Wang [1] with the following commit message: > > I found this could be useful to have qemu-softmmu as a cross > debugger (launch with -s -S command line option), then if we can > have a command to load guest

Re: [Qemu-devel] [PATCH] qmp: add pmemload command

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 0e59c79ddc01e195ddc59d77d9df2b95bf89b600.1523395243.git.si...@ruderich.org Subject: [Qemu-devel] [PATCH] qmp: add pmemload command === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] qmp: add pmemload command

2018-04-10 Thread Simon Ruderich
Adapted patch from Baojun Wang [1] with the following commit message: I found this could be useful to have qemu-softmmu as a cross debugger (launch with -s -S command line option), then if we can have a command to load guest physical memory, we can use cross gdb to do some target

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.12 queue 20180410

2018-04-10 Thread Peter Maydell
> > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180410 > > for you to fetch changes up to 6b3913e0858488ef3358c1683605d6894a6cadb0: > > roms/u-boot-sam460ex: Change to qemu git mirro

[Qemu-devel] [PATCH for-2.12] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-10 Thread Eduardo Habkost
The assumption in the cpu->max_features code is that anything enabled on GET_SUPPORTED_CPUID should be enabled on "-cpu host". This shouldn't be the case for FEAT_KVM_HINTS. This adds a new FeatureWordInfo::no_autoenable_flags field, that can be used to prevent FEAT_KVM_HINTS bits to be enabled

[Qemu-devel] [PATCH] i386: Don't automatically enable FEAT_KVM_HINTS bits

2018-04-10 Thread Eduardo Habkost
The assumption in the cpu->max_features code is that anything enabled on GET_SUPPORTED_CPUID should be enabled on "-cpu host". This shouldn't be the case for FEAT_KVM_HINTS. This adds a new FeatureWordInfo::no_autoenable_flags field, that can be used to prevent FEAT_KVM_HINTS bits to be enabled

Re: [Qemu-devel] [PATCH v1 00/24] fix building of tests/tcg

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180410193919.28026-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v1 00/24] fix building of tests/tcg === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [Bug 1759264] Re: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns

2018-04-10 Thread Alex Bennée
Yeah it looks like it was missed, the round_to_uint code does it. Do you have a test case I can verify? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759264 Title: fpu/softfloat:

[Qemu-devel] [PATCH v1 12/24] tests/tcg/i386: Build fix for hello-i386

2018-04-10 Thread Alex Bennée
From: Fam Zheng We have -Werror=missing-prototype, add a dummy prototype to avoid that warning. Signed-off-by: Fam Zheng --- tests/tcg/i386/hello-i386.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/i386/hello-i386.c

[Qemu-devel] [PATCH v1 21/24] tests/tcg: enable building for ppc64

2018-04-10 Thread Alex Bennée
Currently this just enables building the multiarch tests. Signed-off-by: Alex Bennée --- tests/tcg/ppc64/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tests/tcg/ppc64/Makefile.include diff --git a/tests/tcg/ppc64/Makefile.include

[Qemu-devel] [PATCH v1 11/24] tests/tcg: move i386 specific tests into subdir

2018-04-10 Thread Alex Bennée
These only need to be built for i386 guests. This includes a stub tests/tcg/i386/Makfile.target which absorbs some of what was in tests/tcg/Makefile. Signed-off-by: Alex Bennée --- tests/tcg/README| 39

[Qemu-devel] [PATCH v1 20/24] tests/tcg: enable building for s390x

2018-04-10 Thread Alex Bennée
This doesn't add any additional tests but enables building the multiarch tests for s390x. Signed-off-by: Alex Bennée --- tests/tcg/s390x/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tests/tcg/s390x/Makefile.include diff --git

[Qemu-devel] [PATCH v1 19/24] tests/tcg: move MIPS specific tests into subdir

2018-04-10 Thread Alex Bennée
These only need to be built for MIPS guests. Signed-off-by: Alex Bennée --- tests/tcg/README | 11 --- tests/tcg/mips/README | 7 +++ tests/tcg/{ => mips}/hello-mips.c | 0 3 files changed, 7 insertions(+), 11 deletions(-)

[Qemu-devel] [PATCH v1 16/24] tests/tcg/i386: fix test-i386-fprem

2018-04-10 Thread Alex Bennée
Remove dependencies on QEMU's source tree and build directly. Signed-off-by: Alex Bennée --- tests/tcg/i386/test-i386-fprem.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/tcg/i386/test-i386-fprem.c b/tests/tcg/i386/test-i386-fprem.c

[Qemu-devel] [PATCH v1 14/24] tests/tcg/i386: fix test-i386

2018-04-10 Thread Alex Bennée
The test-i386 test case is a little special as it includes assembler files. Add the additional compile magic to assemble these bits and link them to the final binary. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target | 19 +++

[Qemu-devel] [PATCH v1 17/24] tests/tcg: move ARM specific tests into subdir

2018-04-10 Thread Alex Bennée
These only need to be built for ARM guests. Signed-off-by: Alex Bennée --- tests/tcg/README | 9 - tests/tcg/arm/README | 11 +++ tests/tcg/{ => arm}/hello-arm.c | 0 tests/tcg/{ => arm}/test-arm-iwmmxt.s | 0

[Qemu-devel] [PATCH v1 09/24] tests/tcg: move architecture independent tests into subdir

2018-04-10 Thread Alex Bennée
We will want to build these for all supported guest architectures so lets move them all into one place. We also drop test_path at this point because it needs qemu utils and glib bits which is hard to support for cross compiling. Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH v1 22/24] tests/tcg/Makefile: update to be called from Makefile.target

2018-04-10 Thread Alex Bennée
This make is now invoked from each individual target make with the appropriate CC and ARCH set for each guest. It includes all the multiarch tests by default as well as any tests from tests/tcg/$(ARCH). As there may be subtle additional requirements for building some of the tests it also includes

[Qemu-devel] [PATCH v1 15/24] tests/tcg/i368: fix hello-i386

2018-04-10 Thread Alex Bennée
This is a direct syscall test so needs additional CFLAGS and LDFLAGS. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target index

[Qemu-devel] [PATCH v1 18/24] tests/tcg/arm: fix hello-arm

2018-04-10 Thread Alex Bennée
As hello-arm is a bare bones syscall test it needs specific compiler flags so it doesn't try and link against glibc. Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.target | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 tests/tcg/arm/Makefile.target

[Qemu-devel] [PATCH v1 10/24] tests/tcg/multiarch: Build fix for linux-test

2018-04-10 Thread Alex Bennée
From: Fam Zheng To keep the compiler happy, and to fit in our buildsys flags: - Make local functions "static" - #ifdef out unused functions - drop cutils/osdep dependencies Signed-off-by: Fam Zheng [AJB: drop cutils/osdep dependencies] Signed-off-by: Alex

[Qemu-devel] [PATCH v1 23/24] Makefile.target: add (clean-)guest-tests targets

2018-04-10 Thread Alex Bennée
Now all the build infrastructure is in place we can build tests for each guest that we support. That support mainly depends on having cross compilers installed or docker setup. To keep all the logic for that together we put the rules in tests/tcg/Makefile.include and include it from the main

[Qemu-devel] [PATCH v1 13/24] tests/tcg/i386: move test-i386-sse.c to tests/tcg/x86_64/test-sse.c

2018-04-10 Thread Alex Bennée
The test mixes up 32bit and 64 bit code. It should probably be split into two distinct test cases. However for now just move it out of the way of the i386 build. Signed-off-by: Alex Bennée --- tests/tcg/{i386/test-i386-ssse3.c => x86_64/test-sse.c} | 6 ++ 1 file

[Qemu-devel] [PATCH v1 08/24] docker: Makefile.include introduce DOCKER_SCRIPT

2018-04-10 Thread Alex Bennée
Define this in one place to make it easy to re-use. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

[Qemu-devel] [PATCH v1 07/24] docker: allow "cc" command to run in user context

2018-04-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- tests/docker/docker.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 9444f4bea4..f79213044d 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -399,6 +399,8 @@

[Qemu-devel] [PATCH v1 05/24] docker: Add "cc" subcommand

2018-04-10 Thread Alex Bennée
From: Fam Zheng Signed-off-by: Fam Zheng --- tests/docker/docker.py | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 1246ba9578..8733266153 100755 --- a/tests/docker/docker.py

[Qemu-devel] [PATCH v1 06/24] docker: extend "cc" command to accept compiler

2018-04-10 Thread Alex Bennée
When calling our cross-compilation images we want to call something other than the default cc. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/tests/docker/docker.py

[Qemu-devel] [PATCH v1 24/24] tests/Makefile.include: add (clean-)check-tcg targets

2018-04-10 Thread Alex Bennée
This will ensure all linux-user targets build their guest test programs. Signed-off-by: Alex Bennée --- tests/Makefile.include | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index

[Qemu-devel] [PATCH v1 03/24] configure: move i386_cc to cross_cc_i386

2018-04-10 Thread Alex Bennée
We should still be able to use the system cross compiler with the appropriate flags on x86_64 hosts. Signed-off-by: Alex Bennée --- configure | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH v1 04/24] Makefile: Rename TARGET_DIRS to TARGET_LIST

2018-04-10 Thread Alex Bennée
From: Fam Zheng To be more accurate on its purpose and make code that looks for a certain target out of this variable more readable. Signed-off-by: Fam Zheng --- Makefile | 20 ++-- configure | 2 +-

[Qemu-devel] [PATCH v1 00/24] fix building of tests/tcg

2018-04-10 Thread Alex Bennée
Hi, We've talked about fixing this up for a long time and there have been several RFC patches sent attempting to do that. This is yet another RFC but hopefully shows a way forward which can build on our docker support but also allow users to specify their own guest cross compilers. So far I've

[Qemu-devel] [PATCH v1 01/24] configure: add test for docker availability

2018-04-10 Thread Alex Bennée
This tests for a working docker installation without sudo and sets up config-host.mak accordingly. This will be useful from cross compiling things in the future. Signed-off-by: Alex Bennée --- configure | 23 +++ 1 file changed, 23 insertions(+) diff

[Qemu-devel] [PATCH v1 02/24] configure: add support for --cross-cc-FOO

2018-04-10 Thread Alex Bennée
This allows us to specify cross compilers for our guests. This is useful for building test images/programs. Currently we re-run the compile test for each target. I couldn't think of a way to cache the value for a given arch without getting messier configure code. The cross compiler for the guest

[Qemu-devel] [PATCH for 2.13 v2 2/2] Revert "spapr: Don't allow memory hotplug to memory less nodes"

2018-04-10 Thread Serhii Popovych
This reverts commit b556854bd8524c26b8be98ab1bfdf0826831e793. Leave change @node type from uint32_t to to int from reverted commit because node < 0 is always false. Note that implementing capability or some trick to detect if guest kernel does not support hot-add to memory: this returns previous

[Qemu-devel] [PATCH for 2.13 v2 0/2] target/ppc: Support adding memory to initially memory-less NUMA nodes

2018-04-10 Thread Serhii Popovych
Now PowerPC Linux kernel supports hot-add to NUMA nodes not populated initially with memory we can enable such support in qemu. This requires two changes: o Add device tree property "ibm,max-associativity-domains" to let guest kernel chance to find max possible NUMA node o Revert commit

[Qemu-devel] [PATCH for 2.13 v2 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-10 Thread Serhii Popovych
Now recent kernels (i.e. since linux-stable commit a346137e9142 ("powerpc/numa: Use ibm,max-associativity-domains to discover possible nodes") support this property to mark initially memory-less NUMA nodes as "possible" to allow further memory hot-add to them. Advertise this property for pSeries

[Qemu-devel] [Bug 1762558] Re: Many crashes with "memslot_get_virt: slot_id 170 too big"-type errors in 2.12.0 rc2

2018-04-10 Thread Adam Williamson
...on the other hand, I was clearly not thinking straight in associating this with the qemu version bump in Rawhide, because we don't *run* that qemu. We use the qemu from the worker host, not from the image under test, and the worker hosts are not running Rawhide, and their qemu hasn't changed

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-10 Thread Dongwon Kim
On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: > On 04/06/2018 09:57 PM, Dongwon Kim wrote: > >On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote: > >>On 04/06/2018 02:57 PM, Gerd Hoffmann wrote: > >>> Hi, > >>> > >I fail to see any common

Re: [Qemu-devel] [PATCH 1/2] Fix error message about compressed clusters with OFLAG_COPIED

2018-04-10 Thread Alberto Garcia
On Tue 10 Apr 2018 06:18:28 PM CEST, Eric Blake wrote: > On 04/10/2018 11:05 AM, Alberto Garcia wrote: >> Compressed clusters are not supposed to have the COPIED bit set. >> "qemu-img check" detects that and prints an error message reporting >> the number of the affected host cluster. This doesn't

Re: [Qemu-devel] [PATCH 04/10] target/xtensa: avoid integer overflow in next_page PC check

2018-04-10 Thread Max Filippov
On Tue, Apr 10, 2018 at 9:19 AM, Emilio G. Cota wrote: > If the PC is in the last page of the address space, next_page_start > overflows to 0. Fix it. > > Cc: Max Filippov > Signed-off-by: Emilio G. Cota > --- > target/xtensa/translate.c | 9

Re: [Qemu-devel] [PATCH 2/2] specs/qcow2: Clarify that compressed clusters have the COPIED bit reset

2018-04-10 Thread Eric Blake
On 04/10/2018 11:05 AM, Alberto Garcia wrote: > Compressed clusters are not supposed to have the COPIED bit set, but > this is not made explicit in the specs, so let's document it. > > Signed-off-by: Alberto Garcia > --- > docs/interop/qcow2.txt | 8 > 1 file changed,

[Qemu-devel] [Bug 1761535] Re: qemu-aarch64-static docker arm64v8/openjdk coredump

2018-04-10 Thread Richard Henwood
Many thanks! I've just compiled master, and docker/aarch64/openjdk image now works as expected on my x86 machine. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1761535 Title: qemu-aarch64-static

[Qemu-devel] [PATCH 10/10] target/mips: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [Bug 1762558] Re: Many crashes with "memslot_get_virt: slot_id 170 too big"-type errors in 2.12.0 rc2

2018-04-10 Thread Adam Williamson
Nothing about SPICE changed in the affected time frame. This started happening between 2018-04-02 and 2018-04-07. The last time SPICE was changed in Rawhide was on 2018-02-09. However, qemu was bumped from rc1 to rc2 on 2018-04-05. It's possible that

[Qemu-devel] [PATCH 08/10] target/arm: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Peter Maydell Signed-off-by: Emilio G. Cota --- target/arm/translate.h | 2 +- target/arm/translate.c | 11 +-- 2 files changed, 6 insertions(+), 7

[Qemu-devel] [PATCH 05/10] target/unicore32: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Guan Xuetao Signed-off-by: Emilio G. Cota --- target/unicore32/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 07/10] target/microblaze: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/microblaze/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 09/10] target/s390x: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Cornelia Huck Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Signed-off-by: Emilio G. Cota ---

[Qemu-devel] [PATCH 01/10] target/riscv: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Reported-by: Richard Henderson Suggested-by: Richard Henderson Cc: Michael Clark Cc: Palmer Dabbelt Cc:

[Qemu-devel] [PATCH 02/10] target/cris: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/cris/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 00/10] Avoid integer overflow in next_page_start

2018-04-10 Thread Emilio G. Cota
Richard pointed out in another thread that when computing next_page_start we can break checks for the last page in the address space due to integer overflow. This affects several targets; the appended fixes them. You can fetch the patches from:

[Qemu-devel] [PATCH 03/10] target/lm32: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Michael Walle Signed-off-by: Emilio G. Cota --- target/lm32/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 04/10] target/xtensa: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Max Filippov Signed-off-by: Emilio G. Cota --- target/xtensa/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 06/10] target/tilegx: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Signed-off-by: Emilio G. Cota --- target/tilegx/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/tilegx/translate.c b/target/tilegx/translate.c

Re: [Qemu-devel] [PATCH 1/2] Fix error message about compressed clusters with OFLAG_COPIED

2018-04-10 Thread Eric Blake
On 04/10/2018 11:05 AM, Alberto Garcia wrote: > Compressed clusters are not supposed to have the COPIED bit set. > "qemu-img check" detects that and prints an error message reporting > the number of the affected host cluster. This doesn't make much sense > because compressed clusters are not

Re: [Qemu-devel] [PULL v2 0/3] linux-user fixes for -rc3

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180410160142.21096-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL v2 0/3] linux-user fixes for -rc3 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PATCH 2/2] specs/qcow2: Clarify that compressed clusters have the COPIED bit reset

2018-04-10 Thread Alberto Garcia
Compressed clusters are not supposed to have the COPIED bit set, but this is not made explicit in the specs, so let's document it. Signed-off-by: Alberto Garcia --- docs/interop/qcow2.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

  1   2   3   >