Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 10:20:11PM -0700, Richard Henderson wrote: > On 07/26/2018 08:13 PM, David Gibson wrote: > > On Thu, Jul 26, 2018 at 01:56:19PM +0530, Shivaprasad G Bhat wrote: > >> r11 is a volatile register on PPC as per calling conventions. > >> The safe_syscall code uses it to check if

Re: [Qemu-devel] [RFC PATCH v2 1/6] avocado: Add a Test.arch property

2018-07-26 Thread Philippe Mathieu-Daudé
Hi Cleber, On 06/28/2018 07:03 PM, Philippe Mathieu-Daudé wrote: > On 06/28/2018 06:54 PM, Alex Bennée wrote: >> Alex Bennée writes: >>> Philippe Mathieu-Daudé writes: >>> Tests can change this property to run tests in other architectures than the host one. Signed-off-by:

Re: [Qemu-devel] [PATCH v5 08/10] migration: create a dedicated thread to release rdma resource

2018-07-26 Thread 858585 jemmy
On Mon, Jul 23, 2018 at 10:54 PM, Gal Shachaf wrote: > On Thu, Jul 5, 2018 at 10:26 PM, 858585 jemmy wrote: >> On Thu, Jun 28, 2018 at 2:59 AM, Dr. David Alan Gilbert >> wrote: >>> * Lidong Chen (jemmy858...@gmail.com) wrote: ibv_dereg_mr wait for a long time for big memory size virtual

Re: [Qemu-devel] [PATCH v2 0/6] Avocado: start multi-arch tests, add a Travis job

2018-07-26 Thread Philippe Mathieu-Daudé
Hi Alex, On 06/28/2018 01:01 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> >> Another neanderthal approach to add multi-arch acceptance tests using >> Avocado. >> >> Since Cleber Rosa work got merged [0], I can restart my previous attempt [1] >> at using Avocado in QEMU. >> Cleber

Re: [Qemu-devel] [PATCH v2 1/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2018-07-26 Thread David Gibson
On Tue, Jul 24, 2018 at 02:18:30PM +0200, Cédric Le Goater wrote: > Hello, > > >From the discussion on the XICS MSI object, I gather that exporting > icp_irq is fine. > > Some more comments below, I have tried to answer the parts that were > not addressed yet. [snip] > > Could you use

Re: [Qemu-devel] [PATCH for-3.1] tests/cpu-plug-test: check CPU hotplug on ppc64 with KVM

2018-07-26 Thread David Gibson
On Wed, Jul 25, 2018 at 04:45:26PM +0200, Greg Kurz wrote: > Commit b585395b655 fixed a regression introduced by some recent changes > in the XICS code, that was causing QEMU to crash instantly during CPU > hotplug with KVM. This is typically the kind of bug we'd like our > test suite to detect

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 4/7] target/arm: add "cortex-m0" CPU model

2018-07-26 Thread Philippe Mathieu-Daudé
Hi Stefan, On 07/25/2018 05:59 AM, Stefan Hajnoczi wrote: > Define a "cortex-m0" ARMv6-M CPU model. > > Most of the register reset values set by other CPU models are not > relevant for the cut-down ARMv6-M architecture. > > Signed-off-by: Stefan Hajnoczi > --- > target/arm/cpu.c | 11

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Richard Henderson
On 07/26/2018 08:13 PM, David Gibson wrote: > On Thu, Jul 26, 2018 at 01:56:19PM +0530, Shivaprasad G Bhat wrote: >> r11 is a volatile register on PPC as per calling conventions. >> The safe_syscall code uses it to check if the signal_pending >> is set during the safe_syscall. When a syscall is

Re: [Qemu-devel] [PATCH v5 2/3] spapr: introduce a IRQ controller backend to the machine

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 03:37:22PM +0200, Cédric Le Goater wrote: > This proposal moves all the related IRQ routines of the sPAPR machine > behind a sPAPR IRQ backend interface 'spapr_irq' to prepare for future > changes. First of which will be to increase the size of the IRQ number > space, then,

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 1/7] hw/arm: rename armv7m_load_kernel()

2018-07-26 Thread Philippe Mathieu-Daudé
On 07/25/2018 05:59 AM, Stefan Hajnoczi wrote: > ARMv6-M and ARMv8-M need the same kernel loading functionality as > ARMv7-M. Rename armv7m_load_kernel() to arm_m_profile_load_kernel() so > it's clear that this function isn't specific to ARMv7-M. > > Signed-off-by: Stefan Hajnoczi Reviewed-by:

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 3/7] hw/arm: make bitbanded IO optional on ARM M Profile

2018-07-26 Thread Philippe Mathieu-Daudé
On 07/25/2018 05:59 AM, Stefan Hajnoczi wrote: > Some ARM CPUs have bitbanded IO, a memory region that allows convenient > bit access via 32-bit memory loads/stores. This eliminates the need for > read-modify-update instruction sequences. > > This patch makes this optional feature a ARMMProfile

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 2/7] hw/arm: rename TYPE_ARMV7M to TYPE_ARM_M_PROFILE

2018-07-26 Thread Philippe Mathieu-Daudé
On 07/25/2018 05:59 AM, Stefan Hajnoczi wrote: > The TYPE_ARMV7M class is really a container for an ARM M Profile CPU, > NVIC, and related pieces. It can also be used for ARMv6-M and ARMv8-M. > Rename the class since it is not exclusive to ARMv7-M. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-26 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > > Replay is capable of recording normal BH events, but sometimes > > there are single use callbacks scheduled with aio_bh_schedule_oneshot > > function. This patch enables recording and replaying such callbacks. > > Block layer uses these

Re: [Qemu-devel] [Qemu-arm] [PATCH v3 7/7] Add QTest testcase for the Intel Hexadecimal

2018-07-26 Thread Philippe Mathieu-Daudé
Hi Su, On 07/25/2018 05:59 AM, Stefan Hajnoczi wrote: > From: Su Hang > > 'test.hex' file is a bare metal ARM software stored in Hexadecimal > Object Format. When it's loaded by QEMU, it will print "Hello world!\n" > on console. > > `pre_store` array in 'hexloader-test.c' file, stores the

Re: [Qemu-devel] [PATCH] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Richard Henderson
On 07/26/2018 10:39 AM, Laurent Vivier wrote: > Le 26/07/2018 à 19:15, Richard Henderson a écrit : >> On 07/25/2018 11:48 PM, Shivaprasad G Bhat wrote: >>> r11 is a volatile register on PPC as per calling conventions. >>> The safe_syscall code uses it to check if the signal_pending >>> is set

Re: [Qemu-devel] [PATCH v5 1/3] spapr: introduce a fixed IRQ number space

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 03:37:21PM +0200, Cédric Le Goater wrote: > This proposal introduces a new IRQ number space layout using static > numbers for all devices, depending on a device index, and a bitmap > allocator for the MSI IRQ numbers which are negotiated by the guest at > runtime. > > As

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 01:56:19PM +0530, Shivaprasad G Bhat wrote: > r11 is a volatile register on PPC as per calling conventions. > The safe_syscall code uses it to check if the signal_pending > is set during the safe_syscall. When a syscall is interrupted > on return from signal handling, the

[Qemu-devel] [PATCH RFC for-3.0-rc3 3/3] iotests: Add test for 'qemu-img convert -C' compatibility

2018-07-26 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/082 | 8 tests/qemu-iotests/082.out | 11 +++ 2 files changed, 19 insertions(+) diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082 index a872f771a6..3e605d52d1 100755 --- a/tests/qemu-iotests/082 +++

[Qemu-devel] [PATCH RFC for-3.0-rc3 2/3] qemu-img: Add -C option for convert with copy offloading

2018-07-26 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-img-cmds.hx | 2 +- qemu-img.c | 21 + qemu-img.texi| 8 +++- 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 69758fb6e8..1526f327a5 100644 --- a/qemu-img-cmds.hx +++

[Qemu-devel] [PATCH RFC for-3.0-rc3 1/3] Revert "qemu-img: Document copy offloading implications with -S and -c"

2018-07-26 Thread Fam Zheng
This reverts commit eb461485f4558e362fab905735b50987505bca44. Now that we introduce an explicit option, these implicit rules are not used. Signed-off-by: Fam Zheng --- qemu-img.texi | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qemu-img.texi b/qemu-img.texi index

[Qemu-devel] [PATCH RFC for-3.0-rc3 0/3] qemu-img: Disable copy offloading by default

2018-07-26 Thread Fam Zheng
Kevin pointed out that both glibc and kernel provides a slow fallback of copy_file_range which hurts thin provisioning. This is particularly true for thin LVs, because host_device driver cannot get allocation info from the volume, and copy_file_range is called on every sectors, making the dst

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-26 Thread Tiwei Bie
On Thu, Jul 26, 2018 at 02:45:39PM -0600, Alex Williamson wrote: > On Mon, 23 Jul 2018 12:59:56 +0800 > Tiwei Bie wrote: > [...] > > > > +static int vhost_user_slave_handle_vfio_group(struct vhost_dev *dev, > > + int *fd) > > +{ > > +struct

Re: [Qemu-devel] [PATCH] target/ppc: only save guest timebase once after stopping

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 09:44:11AM +0200, Laurent Vivier wrote: > On 26/07/2018 07:07, David Gibson wrote: > > On Thu, May 03, 2018 at 11:20:44PM -0500, Michael Roth wrote: > >> In some cases (e.g. spapr) we record guest timebase after qmp_stop() > >> via a runstate hook so we can restore it on

Re: [Qemu-devel] [PATCH] target/ppc: only save guest timebase once after stopping

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 07:30:34AM -0500, Michael Roth wrote: > Quoting David Gibson (2018-07-26 00:07:46) > > On Thu, May 03, 2018 at 11:20:44PM -0500, Michael Roth wrote: > > > In some cases (e.g. spapr) we record guest timebase after qmp_stop() > > > via a runstate hook so we can restore it on

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-07-26 Thread Longpeng (Mike)
On 2018/7/27 0:55, Halil Pasic wrote: > Sorry I did not have any time for this last days. And this > to make it worse this is a follow up to something that was > half a year ago. That means I have to re-familiarize myself > with the topic. > > If I don't get around to answer in couple of

Re: [Qemu-devel] [PATCH] target/ppc: simplify bcdadd/sub functions

2018-07-26 Thread David Gibson
On Thu, Jul 26, 2018 at 04:44:43PM -0300, Yasmin Beatriz wrote: > On Thu, Jul 26, 2018 at 11:40:20AM +1000, David Gibson wrote: > > On Tue, Jul 24, 2018 at 12:13:04PM +, Yasmin Beatriz wrote: > > > After solving a corner case in bcdsub, this patch simplifies the logic > > > of both bcdadd/sub

[Qemu-devel] [PATCH] sdl2: redraw correctly when scanout_mode enabled.

2018-07-26 Thread Tao Wu via Qemu-devel
When scanout_mode enabled, surface is out of sync with actual screen. In such case, we just call sdl2_gl_scanout_flush to do redraw. This fixes bug reported in https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html Signed-off-by: Tao Wu --- ui/sdl2-gl.c | 5 + 1

Re: [Qemu-devel] [PATCH v2 1/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2018-07-26 Thread Benjamin Herrenschmidt
On Thu, 2018-07-26 at 11:03 +0200, Cédric Le Goater wrote: > Ben, > > I have found out recently that the QEMU PowerNV could hang while accessing > the disk. > > The issue seems to be the phb3_msi_try_send() routine when called from > the resend() handler. The 'P' is ignored in that case but

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Leonid Bloch
On 07/27/2018 12:28 AM, Kevin Wolf wrote> That makes sense. You probably need to clone the QDict before passing it to qcow2_update_options(), with qdict_clone_shallow(). Sounds like a solution! Great, thanks! Can QAPI be the solution? I've seen some examples, and it looks like the qcow2

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 23:08 hat Leonid Bloch geschrieben: > On July 26, 2018 11:19:03 PM EEST, Kevin Wolf wrote: > >Am 26.07.2018 um 21:43 hat Leonid Bloch geschrieben: > >> On 07/26/2018 05:50 PM, Leonid Bloch wrote: > >> > On 07/26/2018 05:42 PM, Kevin Wolf wrote: > >> > > Am 26.07.2018 um 14:24 hat

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Leonid Bloch
On July 26, 2018 11:19:03 PM EEST, Kevin Wolf wrote: >Am 26.07.2018 um 21:43 hat Leonid Bloch geschrieben: >> On 07/26/2018 05:50 PM, Leonid Bloch wrote: >> > On 07/26/2018 05:42 PM, Kevin Wolf wrote: >> > > Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: >> > > > > > You mean with QDict?

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-26 Thread Alex Williamson
On Mon, 23 Jul 2018 12:59:56 +0800 Tiwei Bie wrote: > Introduce a slave message to allow slave to share its > VFIO group fd to master and do the IOMMU programming > based on virtio device's DMA address space for this > group in QEMU. > > For the vhost backends which support vDPA, they could >

[Qemu-devel] [Bug 1777672] Re: QEMU aarch64 virtual/physical frame buffer

2018-07-26 Thread David Hoelzer
Whoops.. Forgot to include the QEMU command line: qemu-system-aarch64 -M raspi3 --kernel kernel8.img -serial stdio -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777672 Title: QEMU aarch64

[Qemu-devel] [Bug 1777672] Re: QEMU aarch64 virtual/physical frame buffer

2018-07-26 Thread David Hoelzer
Certainly! Attached. If you start the attached on a piece of hardware, it will start and display fine.. If you start it in QEMU, it will start but display a double-height screen rather than limiting the physical screen to the specified dimensions. (The virtual display is double-height in

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 21:43 hat Leonid Bloch geschrieben: > On 07/26/2018 05:50 PM, Leonid Bloch wrote: > > On 07/26/2018 05:42 PM, Kevin Wolf wrote: > > > Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: > > > > > > You mean with QDict? I'll look into that now. But > > > > > > already sent v5

Re: [Qemu-devel] [PATCH] target/ppc: simplify bcdadd/sub functions

2018-07-26 Thread Yasmin Beatriz
On Thu, Jul 26, 2018 at 11:40:20AM +1000, David Gibson wrote: > On Tue, Jul 24, 2018 at 12:13:04PM +, Yasmin Beatriz wrote: > > After solving a corner case in bcdsub, this patch simplifies the logic > > of both bcdadd/sub instructions by removing some unnecessary local flags. > > > >

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Leonid Bloch
On 07/26/2018 05:50 PM, Leonid Bloch wrote: On 07/26/2018 05:42 PM, Kevin Wolf wrote: Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: You mean with QDict? I'll look into that now. But already sent v5 before reading this email. Yes, with reading it from the QDict. (Or whatever the

Re: [Qemu-devel] [PATCH v1 for 3.0 1/2] linux-user/mmap.c: handle len = 0 maps correctly

2018-07-26 Thread Alex Bennée
Will do, thanks! On Thu, 26 Jul 2018 at 19:12, Laurent Vivier wrote: > Le 26/07/2018 à 19:58, Alex Bennée a écrit : > > > > Laurent Vivier writes: > > > >> Le 26/07/2018 à 15:29, Alex Bennée a écrit: > >>> I've slightly re-organised the check to more closely match the > >>> sequence that the

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 10:23 AM, Eric Blake wrote: Hmm - that thread also mentions FALLOC_FL_NO_HIDE_STALE, which is a new flag not present/documented on Fedora 28. I wonder if it helps, too. Even more odd - that flag has been proposed to the kernel since 2012 but still not mentioned in the F28 man

Re: [Qemu-devel] [PATCH v1 for 3.0 1/2] linux-user/mmap.c: handle len = 0 maps correctly

2018-07-26 Thread Laurent Vivier
Le 26/07/2018 à 19:58, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 26/07/2018 à 15:29, Alex Bennée a écrit: >>> I've slightly re-organised the check to more closely match the >>> sequence that the kernel uses in do_mmap(). >>> >>> Signed-off-by: Alex Bennée >>> Cc: umarcor

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 19:34 hat Nir Soffer geschrieben: > On Thu, Jul 26, 2018 at 7:58 PM Kevin Wolf wrote: > > Am 26.07.2018 um 18:46 hat Nir Soffer geschrieben: > > > I don't think we should depend on undocumented kernel code. > > > > Yes, the man page says "filesystem blocks" instead of just

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 12:34 PM, Nir Soffer wrote: Anyway this looks the same level of documentation as FALLOC_FL_ZERO_RANGE, so if we are ok with using it, FALLOC_FL_PUNCH_HOLE is fine. Does this change mean that oVirt can start to enable discard for VM when disks are using wipe-after-delete?

Re: [Qemu-devel] [PATCH v1 for 3.0 1/2] linux-user/mmap.c: handle len = 0 maps correctly

2018-07-26 Thread Alex Bennée
Laurent Vivier writes: > Le 26/07/2018 à 15:29, Alex Bennée a écrit: >> I've slightly re-organised the check to more closely match the >> sequence that the kernel uses in do_mmap(). >> >> Signed-off-by: Alex Bennée >> Cc: umarcor <1783...@bugs.launchpad.net> >> --- >> linux-user/mmap.c | 14

Re: [Qemu-devel] [PATCH hack dontapply v2 6/7] acpi: aml generation for _CST

2018-07-26 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 04:39:28PM +0200, Igor Mammedov wrote: > > > > +void cst_register(FWCfgState *s, uint16_t ioport) > > > > +{ > > > > +cst_ssdt_setup(); > > > > + > > > > +/* Allocate guest scratch memory for the table */ > > > > +cst_scratch = g_array_new(false, true, 1); > > >

Re: [Qemu-devel] [PATCH] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Laurent Vivier
Le 26/07/2018 à 19:15, Richard Henderson a écrit : > On 07/25/2018 11:48 PM, Shivaprasad G Bhat wrote: >> r11 is a volatile register on PPC as per calling conventions. >> The safe_syscall code uses it to check if the signal_pending >> is set during the safe_syscall. When a syscall is interrupted

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 7:58 PM Kevin Wolf wrote: > Am 26.07.2018 um 18:46 hat Nir Soffer geschrieben: > > On Thu, Jul 26, 2018 at 7:10 PM Eric Blake wrote: > > > > > On 07/26/2018 10:33 AM, Kevin Wolf wrote: > > > > > > > > > > > As far as I know, the comment you quoted is accurate for

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 06:42:51PM +0200, Knut Omang wrote: > On Thu, 2018-07-26 at 19:41 +0300, Michael S. Tsirkin wrote: > > On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: > > > On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: > > > > Hi > > > > > > > > On 07/26/2018

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Knut Omang
On Thu, 2018-07-26 at 20:05 +0300, Marcel Apfelbaum wrote: > > On 07/26/2018 07:42 PM, Knut Omang wrote: > > On Thu, 2018-07-26 at 19:41 +0300, Michael S. Tsirkin wrote: > > > On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: > > > > On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Knut Omang
On Thu, 2018-07-26 at 20:05 +0300, Marcel Apfelbaum wrote: > > On 07/26/2018 07:42 PM, Knut Omang wrote: > > On Thu, 2018-07-26 at 19:41 +0300, Michael S. Tsirkin wrote: > > > On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: > > > > On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum

Re: [Qemu-devel] [PATCH 1/2] qstring: Assert size calculations don't overflow

2018-07-26 Thread Markus Armbruster
Eric Blake writes: > On 07/26/2018 01:18 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> qobject/qstring.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/qobject/qstring.c b/qobject/qstring.c >> index 18b8eb82f8..7990569c5a 100644

Re: [Qemu-devel] [PATCH] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Richard Henderson
On 07/25/2018 11:48 PM, Shivaprasad G Bhat wrote: > Reference: > https://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi-1.9.html#REG This document is for _CALL_ELF < 2. For ppc64le, the document is at

Re: [Qemu-devel] [PATCH hack dontapply v2 6/7] acpi: aml generation for _CST

2018-07-26 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 04:39:28PM +0200, Igor Mammedov wrote: > Fixed dynamic tables are usually more or less self sufficient > so it's safer to reload so I'm ok with their reloading. Well it's just a matter of excercising self-control and building sane APIs to make sure we do. E.g. let's say we

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Alex Williamson
On Thu, 26 Jul 2018 20:11:44 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jul 26, 2018 at 10:42:52AM -0600, Alex Williamson wrote: > > On Thu, 26 Jul 2018 19:14:45 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > > > > Hi >

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Knut Omang
On Thu, 2018-07-26 at 20:11 +0300, Michael S. Tsirkin wrote: > On Thu, Jul 26, 2018 at 10:42:52AM -0600, Alex Williamson wrote: > > On Thu, 26 Jul 2018 19:14:45 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > > > > Hi > > > > >

Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-26 Thread Alex Bennée
Alex Bennée writes: > Pavel Dovgalyuk writes: > >> Replay is capable of recording normal BH events, but sometimes >> there are single use callbacks scheduled with aio_bh_schedule_oneshot >> function. This patch enables recording and replaying such callbacks. >> Block layer uses these events

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2018-07-26 Thread Stefan Berger
On 07/26/2018 01:26 AM, David Gibson wrote: On Tue, Dec 12, 2017 at 03:44:02PM -0500, Stefan Berger wrote: Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for

Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-26 Thread Alex Bennée
Pavel Dovgalyuk writes: > Replay is capable of recording normal BH events, but sometimes > there are single use callbacks scheduled with aio_bh_schedule_oneshot > function. This patch enables recording and replaying such callbacks. > Block layer uses these events for calling the completion

Re: [Qemu-devel] [PATCH] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-26 Thread Richard Henderson
On 07/25/2018 11:48 PM, Shivaprasad G Bhat wrote: > r11 is a volatile register on PPC as per calling conventions. > The safe_syscall code uses it to check if the signal_pending > is set during the safe_syscall. When a syscall is interrupted > on return from signal handling, the r11 might be

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 10:42:52AM -0600, Alex Williamson wrote: > On Thu, 26 Jul 2018 19:14:45 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > > > Hi > > > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > > On Thu, Jul

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Marcel Apfelbaum
On 07/26/2018 07:42 PM, Knut Omang wrote: On Thu, 2018-07-26 at 19:41 +0300, Michael S. Tsirkin wrote: On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: Hi On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: On Thu, Jul 12,

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 18:46 hat Nir Soffer geschrieben: > On Thu, Jul 26, 2018 at 7:10 PM Eric Blake wrote: > > > On 07/26/2018 10:33 AM, Kevin Wolf wrote: > > > > > > > > As far as I know, the comment you quoted is accurate for BLKDISCARD and > > > BLKZEROOUT, but not for the fallocate() flags. > >

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-07-26 Thread Halil Pasic
Sorry I did not have any time for this last days. And this to make it worse this is a follow up to something that was half a year ago. That means I have to re-familiarize myself with the topic. If I don't get around to answer in couple of weeks, feel free to ping me. Since from what I've seen

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 7:41 PM Kevin Wolf wrote: ... > > > +#ifdef CONFIG_FALLOCATE_PUNCH_HOLE > > > +ret = do_fallocate(s->fd, FALLOC_FL_PUNCH_HOLE | > FALLOC_FL_KEEP_SIZE, > > > + aiocb->aio_offset, aiocb->aio_nbytes); > > > +if (ret != -ENOTSUP) { > > > > > > >

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 7:10 PM Eric Blake wrote: > On 07/26/2018 10:33 AM, Kevin Wolf wrote: > > > > > As far as I know, the comment you quoted is accurate for BLKDISCARD and > > BLKZEROOUT, but not for the fallocate() flags. > > > > I sure wish the man pages were more explicit on what

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Knut Omang
On Thu, 2018-07-26 at 19:41 +0300, Michael S. Tsirkin wrote: > On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: > > On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: > > > Hi > > > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > > On Thu, Jul 12, 2018 at 07:33:14AM

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Alex Williamson
On Thu, 26 Jul 2018 19:14:45 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > > Hi > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > > Hey, > > > > > > >

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 18:22 hat Nir Soffer geschrieben: > On Thu, Jul 26, 2018 at 2:33 PM Kevin Wolf wrote: > > > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > > all-zero afterwards, so don't try to abuse it for zero writing. We try > > to only use this if

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 06:38:32PM +0200, Knut Omang wrote: > On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: > > Hi > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > > Hey, > > > > > > > > Our team is

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Knut Omang
On Thu, 2018-07-26 at 18:51 +0300, Marcel Apfelbaum wrote: > Hi > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > Hey, > > > > > > Our team is adding a NIC functional emulation to QEMU. > > > One of the features we are

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 07:34:41PM +0300, Marcel Apfelbaum wrote: > > > On 07/26/2018 07:14 PM, Michael S. Tsirkin wrote: > > On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > > > Hi > > > > > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > > > On Thu, Jul 12, 2018 at

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Marcel Apfelbaum
On 07/26/2018 07:14 PM, Michael S. Tsirkin wrote: On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: Hi On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: Hey, Our team is adding a NIC functional emulation to

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 2:33 PM Kevin Wolf wrote: > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > all-zero afterwards, so don't try to abuse it for zero writing. We try > to only use this if BLKDISCARDZEROES tells us that it is safe, but this > is unreliable on older

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Michael S. Tsirkin
On Thu, Jul 26, 2018 at 06:51:13PM +0300, Marcel Apfelbaum wrote: > Hi > > On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: > > On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > > > Hey, > > > > > > Our team is adding a NIC functional emulation to QEMU. > > > One of the features

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-26 Thread Marcel Apfelbaum
On 07/25/2018 01:59 PM, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: Hi, On 07/25/2018 10:32 AM, Thomas Huth wrote: On 25.07.2018 06:47, Rebecca Cran wrote: In commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc, ./configure on FreeBSD incorrectly

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 10:33 AM, Kevin Wolf wrote: As far as I know, the comment you quoted is accurate for BLKDISCARD and BLKZEROOUT, but not for the fallocate() flags. I sure wish the man pages were more explicit on what guarantees each flag offers. Hmm - that thread also mentions

Re: [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation

2018-07-26 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 05:53:35PM +0200, Igor Mammedov wrote: > On Wed, 25 Jul 2018 15:44:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 25, 2018 at 02:32:11PM +0200, Igor Mammedov wrote: > > > On Tue, 10 Jul 2018 03:01:30 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Now

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Marcel Apfelbaum
Hi On 07/26/2018 05:52 PM, Stefan Hajnoczi wrote: On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: Hey, Our team is adding a NIC functional emulation to QEMU. One of the features we are adding to this NIC is SRIOV. Here is the error message I get when checking SRIOV support

Re: [Qemu-devel] [PATCH hack dontapply v2 7/7] pc: HACK: acpi: tie in _CST object to Processor

2018-07-26 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 04:49:08PM +0200, Igor Mammedov wrote: > On Wed, 25 Jul 2018 15:50:09 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 25, 2018 at 02:37:24PM +0200, Igor Mammedov wrote: > > > On Tue, 10 Jul 2018 03:01:34 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > >

Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-26 Thread Alex Bennée
Pavel Dovgalyuk writes: > Replay is capable of recording normal BH events, but sometimes > there are single use callbacks scheduled with aio_bh_schedule_oneshot > function. This patch enables recording and replaying such callbacks. > Block layer uses these events for calling the completion

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 17:23 hat Eric Blake geschrieben: > On 07/26/2018 10:06 AM, Kevin Wolf wrote: > > > > > +#ifdef CONFIG_FALLOCATE_PUNCH_HOLE > > > > +ret = do_fallocate(s->fd, FALLOC_FL_PUNCH_HOLE | > > > > FALLOC_FL_KEEP_SIZE, > > > > + aiocb->aio_offset,

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 10:06 AM, Kevin Wolf wrote: +#ifdef CONFIG_FALLOCATE_PUNCH_HOLE +ret = do_fallocate(s->fd, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE, + aiocb->aio_offset, aiocb->aio_nbytes); Umm, doesn't this have to use FALLOC_FL_ZERO_RANGE? FALLOC_FL_PUNCH_HOLE

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-26 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 25/07/2018 22:04, Andrea Arcangeli wrote: > > > > It may look like the uffd-wp model is wish-feature similar to an > > optimization, but without the uffd-wp model when the WP fault is > > triggered by kernel code, the sigsegv model falls apart and

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2018 at 09:29:44AM +0200, David Hildenbrand wrote: > On 25.07.2018 22:14, Eduardo Habkost wrote: > > On Wed, Jul 25, 2018 at 07:50:21PM +0200, David Hildenbrand wrote: > >> On 25.07.2018 19:09, Eduardo Habkost wrote: > > [...] > +if (local_err) { > +

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 16:28 hat Eric Blake geschrieben: > On 07/26/2018 06:33 AM, Kevin Wolf wrote: > > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > > all-zero afterwards, so don't try to abuse it for zero writing. We try > > to only use this if BLKDISCARDZEROES tells us

Re: [Qemu-devel] [Qemu-block] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Nir Soffer
On Thu, Jul 26, 2018 at 5:28 PM Eric Blake wrote: > On 07/26/2018 06:33 AM, Kevin Wolf wrote: > > The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as > > all-zero afterwards, so don't try to abuse it for zero writing. We try > > to only use this if BLKDISCARDZEROES tells us

Re: [Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in

2018-07-26 Thread Juan Quintela
Thomas Huth wrote: > On 17.07.2018 13:33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index b3e707e8c3..ccf71bddcc

Re: [Qemu-devel] Question: SRIOV support over Win Hyper-V VM running in QEMU process on Linux host

2018-07-26 Thread Stefan Hajnoczi
On Thu, Jul 12, 2018 at 07:33:14AM +, Elijah Shakkour wrote: > Hey, > > Our team is adding a NIC functional emulation to QEMU. > One of the features we are adding to this NIC is SRIOV. > > Here is the error message I get when checking SRIOV support of our emulated > NIC on Win2016 server

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Leonid Bloch
How about: "default: 4 times the cluster size; or if cache-size is specified, the part of it which is not used for the L2 cache" Even simpler, easier to understand and more accurate. I like it. Thanks! Kevin

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Leonid Bloch
On 07/26/2018 05:42 PM, Kevin Wolf wrote: Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: You mean with QDict? I'll look into that now. But already sent v5 before reading this email. Yes, with reading it from the QDict. (Or whatever the simplest way is that results in the right external

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 16:27 hat Leonid Bloch geschrieben: > On 07/26/2018 01:02 PM, Kevin Wolf wrote: > > Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: > > > Signed-off-by: Leonid Bloch > > > --- > > > docs/qcow2-cache.txt | 3 +++ > > > qemu-options.hx | 10 ++ > > > 2 files

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-26 Thread Kevin Wolf
Am 26.07.2018 um 14:24 hat Leonid Bloch geschrieben: > > > You mean with QDict? I'll look into that now. But already sent v5 before > > > reading this email. > > > > Yes, with reading it from the QDict. (Or whatever the simplest way is > > that results in the right external interface, but I

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Leonid Bloch
On 07/26/2018 05:20 PM, Eric Blake wrote: On 07/26/2018 05:02 AM, Kevin Wolf wrote: Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch ---   docs/qcow2-cache.txt |  3 +++   qemu-options.hx  | 10 ++   2 files changed, 9 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH for-3.0] file-posix: Fix write_zeroes with unmap on block devices

2018-07-26 Thread Eric Blake
On 07/26/2018 06:33 AM, Kevin Wolf wrote: The BLKDISCARD ioctl doesn't guarantee that the discarded blocks read as all-zero afterwards, so don't try to abuse it for zero writing. We try to only use this if BLKDISCARDZEROES tells us that it is safe, but this is unreliable on older kernels and a

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Leonid Bloch
On 07/26/2018 01:02 PM, Kevin Wolf wrote: Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/docs/qcow2-cache.txt

Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes

2018-07-26 Thread Eric Blake
On 07/26/2018 05:02 AM, Kevin Wolf wrote: Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben: Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++ 2 files changed, 9 insertions(+), 4 deletions(-) +++ b/qemu-options.hx @@ -752,15 +752,17

Re: [Qemu-devel] [PULL for-3.0 1/1] trace/simple: fix hang in child after fork(2)

2018-07-26 Thread Stefan Hajnoczi
On Tue, Jul 24, 2018 at 03:41:01PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 24, 2018 at 03:35:51PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 24, 2018 at 03:25:04PM +0100, Stefan Hajnoczi wrote: > > > The simple trace backend spawns a write-out thread which is used to > > >

Re: [Qemu-devel] [PATCH v2] block/gluster: defend on legacy ftruncate api use

2018-07-26 Thread Eric Blake
On 07/26/2018 04:19 AM, Niels de Vos wrote: From: Prasanna Kumar Kalever When sending a v2, it's best to start a new thread instead of in-reply-to v1, so that the automated tooling spots it easier. Subject line is awkward, may I suggest: block/gluster: Handle changed glfs_ftruncate

Re: [Qemu-devel] [PATCH 2/2] qstring: Move qstring_from_substr()'s @end one to the right

2018-07-26 Thread Eric Blake
On 07/26/2018 01:18 AM, Markus Armbruster wrote: qstring_from_substr() takes the index of the substring's first and last character. qstring_from_substr(s, 0, SIZE_MAX) denotes an empty substring. Awkward. Shift the end index one to the right. This simplifies both qstring_from_substr() and

Re: [Qemu-devel] [PATCH 1/2] qstring: Assert size calculations don't overflow

2018-07-26 Thread Eric Blake
On 07/26/2018 01:18 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qobject/qstring.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qobject/qstring.c b/qobject/qstring.c index 18b8eb82f8..7990569c5a 100644 --- a/qobject/qstring.c +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] tpm_spapr: Support suspend and resume

2018-07-26 Thread Eric Blake
On 07/26/2018 12:31 AM, David Gibson wrote: On Tue, Dec 12, 2017 at 03:44:03PM -0500, Stefan Berger wrote: Signed-off-by: Stefan Berger --- hw/tpm/tpm_spapr.c | 61 ++ 1 file changed, 57 insertions(+), 4 deletions(-) diff --git

  1   2   >