Re: [Qemu-devel] [RFC v3 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-08-06 Thread Zihan Yang
Marcel Apfelbaum 于2018年8月6日周一 下午7:46写道: > > > > On 08/02/2018 05:45 AM, Zihan Yang wrote: > > The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, > > change it to a new type TYPE_PXB_PCIE_HOST to better utilize ECAM of PCIe > > After an offline conversation we decided to

[Qemu-devel] [PATCH 11/21] jobs: remove job_defer_to_main_loop

2018-08-06 Thread John Snow
The job infrastructure handles this now, so remove this call. Signed-off-by: John Snow --- include/qemu/job.h | 17 - job.c | 40 ++-- 2 files changed, 2 insertions(+), 55 deletions(-) diff --git a/include/qemu/job.h

[Qemu-devel] [PATCH 15/21] block/stream: add block job creation flags

2018-08-06 Thread John Snow
Add support for taking and passing forward job creaton flags. Signed-off-by: John Snow --- block/stream.c| 5 +++-- blockdev.c| 3 ++- include/block/block_int.h | 5 - 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/block/stream.c b/block/stream.c

[Qemu-devel] [PATCH 18/21] block/commit: refactor stream to use job callbacks

2018-08-06 Thread John Snow
Signed-off-by: John Snow --- block/stream.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/block/stream.c b/block/stream.c index af0a1d5d0c..20192fac77 100644 --- a/block/stream.c +++ b/block/stream.c @@ -54,16 +54,16 @@ static int coroutine_fn

[Qemu-devel] [PATCH 13/21] block/commit: add block job creation flags

2018-08-06 Thread John Snow
Add support for taking and passing forward job creation flags. Signed-off-by: John Snow --- block/commit.c| 5 +++-- blockdev.c| 7 --- include/block/block_int.h | 5 - 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/block/commit.c

[Qemu-devel] [PATCH 21/21] qapi/block-stream: expose new job properties

2018-08-06 Thread John Snow
Signed-off-by: John Snow --- blockdev.c | 9 + hmp.c| 5 +++-- qapi/block-core.json | 3 ++- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index bbb3279020..806531dc20 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3226,6

[Qemu-devel] [PATCH 01/21] jobs: canonize Error object

2018-08-06 Thread John Snow
Jobs presently use both an Error object in the case of the create job, and char strings in the case of generic errors elsewhere. Unify the two paths as just j->err, and remove the extra argument from job_completed. Signed-off-by: John Snow --- block/backup.c| 2 +- block/commit.c

[Qemu-devel] [PATCH 08/21] tests/test-blockjob-txn: utilize job_exit shim

2018-08-06 Thread John Snow
This is safe to do because job_complete which will get called implicitly already handles resetting the job error code if the job gets cancelled, so this stanza was wasted effort. Signed-off-by: John Snow --- tests/test-blockjob-txn.c | 12 +++- 1 file changed, 3 insertions(+), 9

[Qemu-devel] [PATCH 06/21] block/stream: utilize job_exit shim

2018-08-06 Thread John Snow
Change the manual deferment to stream_complete into the implicit callback to job_exit. Signed-off-by: John Snow --- block/stream.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/block/stream.c b/block/stream.c index a5d6e0cf8a..163cd6431c 100644 ---

[Qemu-devel] [PATCH 16/21] block/commit: refactor commit to use job callbacks

2018-08-06 Thread John Snow
Use the component callbacks; prepare, commit, abort, and clean. NB: prepare is only called when the job has not yet failed; and abort can be called after prepare. complete -> prepare -> abort -> clean complete -> abort -> clean Signed-off-by: John Snow --- block/commit.c | 94

[Qemu-devel] [PATCH 09/21] tests/test-blockjob: utilize job_exit shim

2018-08-06 Thread John Snow
Change the manual deferment to test_block_job_complete into the implicit callback to job_exit. Signed-off-by: John Snow --- tests/test-blockjob.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c index

[Qemu-devel] [PATCH 17/21] block/mirror: conservative mirror_exit refactor

2018-08-06 Thread John Snow
For purposes of minimum code movement, refactor the mirror_exit callback to use the post-finalization callbacks in a trivial way. Signed-off-by: John Snow --- block/mirror.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/block/mirror.c

[Qemu-devel] [PATCH 20/21] qapi/block-mirror: expose new job properties

2018-08-06 Thread John Snow
Signed-off-by: John Snow --- blockdev.c | 14 ++ qapi/block-core.json | 6 -- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8efc47e178..bbb3279020 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3707,6 +3707,8 @@ static void

[Qemu-devel] [PATCH 14/21] block/mirror: add block job creation flags

2018-08-06 Thread John Snow
Add support for taking and passing forward job creaton flags. Signed-off-by: John Snow --- block/mirror.c| 5 +++-- blockdev.c| 3 ++- include/block/block_int.h | 5 - 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/block/mirror.c b/block/mirror.c

[Qemu-devel] [PATCH 12/21] jobs: allow entrypoints to return status code

2018-08-06 Thread John Snow
Instead of awkwardly setting the return code in the job object, we can just return this on the stack and catch it in the caller. This also has the side-effect of changing the "opaque" type in the entrypoint to the more specific "Job" type, so change function signatures accordingly. Signed-off-by:

[Qemu-devel] [PATCH 07/21] block/create: utilize job_exit shim

2018-08-06 Thread John Snow
Utilize the job_exit shim by simply not calling job_defer_to_main_loop. While we're here, we don't need to duplicate the core job object's `ret`. Signed-off-by: John Snow --- block/create.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/block/create.c

[Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties

2018-08-06 Thread John Snow
Signed-off-by: John Snow --- blockdev.c | 8 qapi/block-core.json | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index c2e6402a66..8efc47e178 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3314,6 +3314,8 @@ void

[Qemu-devel] [PATCH 02/21] jobs: add exit shim

2018-08-06 Thread John Snow
Most jobs do the same thing when they leave their running loop: - Store the return code in a structure - wait to receive this structure in the main thread - signal job completion via job_completed More seriously, when we utilize job_defer_to_main_loop_bh to call a function that calls

[Qemu-devel] [PATCH 10/21] tests/test-bdrv-drain: utilize job_exit shim

2018-08-06 Thread John Snow
Utilize the job_exit shim by simply not calling job_defer_to_main_loop. Signed-off-by: John Snow --- tests/test-bdrv-drain.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index 7b05082cae..f30310596c 100644 ---

[Qemu-devel] [PATCH 05/21] block/mirror: utilize job_exit shim

2018-08-06 Thread John Snow
Change the manual deferment to mirror_exit into the implicit callback to job_exit and the mirror_exit callback. Signed-off-by: John Snow --- block/mirror.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index

[Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-06 Thread John Snow
Change the manual deferment to commit_complete into the implicit callback to job_exit. Signed-off-by: John Snow --- block/commit.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/block/commit.c b/block/commit.c index 620666161b..5bed098d5f 100644 ---

[Qemu-devel] [PATCH 03/21] block/backup: utilize job_exit shim

2018-08-06 Thread John Snow
Utilize the job_exit shim by simply not calling job_defer_to_main_loop. Signed-off-by: John Snow --- block/backup.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/block/backup.c b/block/backup.c index f3bf842423..af6ee5ab54 100644 --- a/block/backup.c +++

[Qemu-devel] [PATCH 00/21] jobs: defer graph changes until finalize

2018-08-06 Thread John Snow
This series forces all jobs to use the "finalize" semantics that were introduced previously, but only exposed via the backup jobs. This series looks huge, but it's mostly mechanical changes broken out into a series of much smaller commits so that the changes are easier to follow at each step.

Re: [Qemu-devel] [PATCH] qapi/block: Document restrictions for node names

2018-08-06 Thread Cong Li
- Original Message - > From: "Kevin Wolf" > To: qemu-bl...@nongnu.org > Cc: kw...@redhat.com, c...@redhat.com, qemu-devel@nongnu.org > Sent: Monday, August 6, 2018 8:37:28 PM > Subject: [PATCH] qapi/block: Document restrictions for node names > > blockdev-add fails if an invalid node

[Qemu-devel] [Bug 1785734] [NEW] movdqu partial write at page boundary

2018-08-06 Thread Fabian Hemmer
Public bug reported: In TCG mode, when a 16-byte write instruction (such as movdqu) is executed at a page boundary and causes a page fault, a partial write is executed in the first page. See the attached code for an example. Tested on the qemu-3.0.0-rc1 release. % gcc -m32 qemu-bug2.c &&

[Qemu-devel] [Bug 1785670] Re: Guest(ubuntu 18.04) crashes when trying uploading file

2018-08-06 Thread Zihan Yang
It's indeed e1000e specific, when I change e1000e to e1000, I can upload file freely. Looks like there is an overflow somewhere in e1000e that corrupted the heap chunk header. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC PATCH] async: Fix aio_notify_accept

2018-08-06 Thread Fam Zheng
On Fri, 08/03 19:08, Paolo Bonzini wrote: > On 03/08/2018 17:49, Fam Zheng wrote: > > void aio_notify_accept(AioContext *ctx) > > { > > -if (atomic_xchg(>notified, false)) { > > +/* If ctx->notify_me >= 2, another aio_poll() is waiting which may > > need the > > + * ctx->notifier

[Qemu-devel] [Bug 1785698] Re: Solaris build error: unknown type name ‘gcry_error_t’

2018-08-06 Thread Michele Denber
It turns out I needed #include in crypto/cipher-grypt.c However, now I'm stuck on # gmake mkdir -p dtc/libfdt mkdir -p dtc/tests Bad string LINKqemu-nbd ld: fatal: library -lutil: not found ld: fatal: file processing errors. No output written to qemu-nbd collect2: error: ld returned 1

Re: [Qemu-devel] [PATCH v2] target-i386: coalesced PIO support for RTC

2018-08-06 Thread Eduardo Habkost
Hi, On Thu, Jul 12, 2018 at 10:00:57AM +0800, Wanpeng Li wrote: > From: Peng Hao > > Windows I/O, such as the real-time clock. The address register (port > 0x70 in the RTC case) can use coalesced I/O, cutting the number of > userspace exits by half when reading or writing the RTC. > > Guest

Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode

2018-08-06 Thread Marc-André Lureau
Hi On Mon, Aug 6, 2018 at 11:16 PM, Michael S. Tsirkin wrote: > On Fri, Aug 03, 2018 at 05:32:35PM +0200, Marc-André Lureau wrote: >> With vga=775 on the Linux command line a first boot of the VM running >> Linux works fine. After a warm reboot it crashes during Linux boot. >> >> Before that,

Re: [Qemu-devel] [PULL 21/35] block: fix QEMU crash with scsi-hd and drive_del

2018-08-06 Thread Eric Blake
On 06/18/2018 11:44 AM, Kevin Wolf wrote: From: Greg Kurz Removing a drive with drive_del while it is being used to run an I/O intensive workload can cause QEMU to crash. ... The problem is that we should avoid making block driver graph changes while we have in-flight requests. Let's drain

Re: [Qemu-devel] [PATCH 1/3] x86/cpu: Enable UMONITOR/UMWAIT/TPAUSE cpu features

2018-08-06 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 04:57:32PM +0800, Jingqi Liu wrote: > UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions. > > UMONITOR arms address monitoring hardware using an address. A store > to an address within the specified address range triggers the > monitoring hardware to wake up

Re: [Qemu-devel] [PATCH 0/2] target/ppc: Fixes for my fpu cleanups

2018-08-06 Thread Mark Cave-Ayland
On 06/08/18 02:27, Richard Henderson wrote: David, please squash these with the patches you already have on your ppc-for-3.1 branch. The first fixes fp division within the vector insns. The second fixes some typos within the load/store converters as reported by Mark Cave-Ayland. I've just

[Qemu-devel] [PATCH] linux-user: fix recvmsg()/recvfrom() with netlink and MSG_TRUNC

2018-08-06 Thread Laurent Vivier
If recvmsg()/recvfrom() are used with the MSG_TRUNC flag, they return the real length even if it was longer than the passed buffer. So when we translate the buffer we must check we don't go beyond the end of the buffer. Bug: https://github.com/vivier/qemu-m68k/issues/33 Reported-by: John Paul

Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode

2018-08-06 Thread Michael S. Tsirkin
On Fri, Aug 03, 2018 at 05:32:35PM +0200, Marc-André Lureau wrote: > With vga=775 on the Linux command line a first boot of the VM running > Linux works fine. After a warm reboot it crashes during Linux boot. > > Before that, valgrind points out bad memory write to console > surface. The VGA code

[Qemu-devel] [Bug 1785698] Re: Solaris build error: unknown type name ‘gcry_error_t’

2018-08-06 Thread Michele Denber
** Description changed: Building qemu 2.12.0 on a Sun Oracle Enterprise M3000 SPARC64 VII, - opencsw toolchain and gcc 7.3.0, gmake fails with a bunch of related - errors all in cypher-gcrypt.c: + Solaris 10 Update 11, opencsw toolchain and gcc 7.3.0, gmake fails with + a bunch of related

[Qemu-devel] [RFC v7 13/16] qdev: export qbus_find_recursive

2018-08-06 Thread Eric Auger
We intend to create the virtio-iommu from the virt machine realize() code and not by passing the -device virtio-iommu-device option. That way the instantiation of the virtio-iommu can depend on a virt machine option, as it is currently done for the smmuv3 iommu. Its parent bus, the virtio-bus

[Qemu-devel] [RFC v7 16/16] hw/arm/virt: Allow virtio-iommu instantiation

2018-08-06 Thread Eric Auger
The virtio-iommu now can be instantiated by adding the virt machine option "-M virt,iommu=virtio" Signed-off-by: Eric Auger --- hw/arm/virt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index dd3cc71..25f7c21 100644 ---

[Qemu-devel] [RFC v7 15/16] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table

2018-08-06 Thread Eric Auger
This patch builds the virtio-iommu node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in smmuv3, which in turn maps to deviceid space 0x0-0x1 in the ITS group. Signed-off-by: Eric Auger --- hw/arm/virt-acpi-build.c

[Qemu-devel] [RFC v7 14/16] hw/arm/virt: Add virtio-iommu to the virt board

2018-08-06 Thread Eric Auger
Both the virtio-iommu device and its dedicated mmio transport get instantiated when requested. Signed-off-by: Eric Auger --- v6 -> v7: - align to the smmu instantiation code v4 -> v5: - VirtMachineClass no_iommu added in this patch - Use object_resolve_path_type --- hw/arm/virt.c |

[Qemu-devel] [RFC v7 12/16] virtio_iommu: Handle reserved regions in translation process

2018-08-06 Thread Eric Auger
When translating an address we need to check if it belongs to a reserved virtual address range. If it does, there are 2 cases: - it belongs to a RESERVED region: the guest should neither use this address in a MAP not instruct the end-point to DMA on them. We report an error - It belongs to

[Qemu-devel] [RFC v7 09/16] virtio-iommu: Implement probe request

2018-08-06 Thread Eric Auger
This patch implements the PROBE request. At the moment, no reserved regions are returned as none are registered per device. Only a NONE property is returned. Signed-off-by: Eric Auger --- v6 -> v7: - adapt to the change in virtio_iommu_probe_resv_mem fields - use get_endpoint() instead of

[Qemu-devel] [RFC v7 04/16] virtio-iommu: Add the iommu regions

2018-08-06 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented though. Signed-off-by: Eric Auger --- v6 -> v7: - use primary_bus - rebase on new translate proto featuring iommu_idx v5 -> v6: - include

[Qemu-devel] [RFC v7 10/16] virtio-iommu: Add an msi_bypass property

2018-08-06 Thread Eric Auger
In case the msi_bypass property is set, it means we need to register the IOAPIC MSI window as a reserved region: 0xFEE0 - 0xFEEF. Signed-off-by: Eric Auger --- --- hw/virtio/virtio-iommu.c | 52 include/hw/virtio/virtio-iommu.h | 1 + 2

[Qemu-devel] [RFC v7 08/16] virtio-iommu: Implement translate

2018-08-06 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger --- v5 -> v6: - replace error_report by qemu_log_mask v4 -> v5: - check the device domain is not NULL - s/printf/error_report - set flags to IOMMU_NONE in case of all translation faults --- hw/virtio/trace-events | 1 +

[Qemu-devel] [RFC v7 11/16] virtio-iommu: Implement fault reporting

2018-08-06 Thread Eric Auger
The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 67 +--- 2 files changed, 65 insertions(+), 3

[Qemu-devel] [RFC v7 02/16] virtio-iommu: Add skeleton

2018-08-06 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- v6 -> v7: - removed qapi-event.h include - add primary_bus and associated property v4 -> v5: - use the new v0.5 terminology (domain, endpoint) - add the event virtqueue v3 -> v4: - use page_size_mask

[Qemu-devel] [RFC v7 07/16] virtio-iommu: Implement map/unmap

2018-08-06 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger --- v5 -> v6: - use new v0.6 fields - replace error_report by qemu_log_mask v3 -> v4: - implement unmap semantics as specified in v0.4 --- hw/virtio/trace-events | 3 ++ hw/virtio/virtio-iommu.c | 94

[Qemu-devel] [RFC v7 05/16] virtio-iommu: Endpoint and domains structs and helpers

2018-08-06 Thread Eric Auger
This patch introduce domain and endpoint internal datatypes. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Helpers to get/put end points and domains are introduced. get() helpers will become static in subsequent patches. Signed-off-by: Eric Auger --- v6 ->

[Qemu-devel] [RFC v7 06/16] virtio-iommu: Implement attach/detach command

2018-08-06 Thread Eric Auger
This patch implements the endpoint attach/detach to/from a domain. Signed-off-by: Eric Auger --- hw/virtio/virtio-iommu.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index

[Qemu-devel] [RFC v7 03/16] virtio-iommu: Decode the command payload

2018-08-06 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger --- v5 -> v6: - change map/unmap semantics (remove size) v4 -> v5: - adopt new v0.5 terminology v3 -> v4: - no

[Qemu-devel] [RFC v7 00/16] VIRTIO-IOMMU device

2018-08-06 Thread Eric Auger
This series rebases the virtio-iommu device on qemu 3.0.0-rc3 and implements the v0.7 virtio-iommu spec [1]. This is a basic upgrade as the fate of the virtio mmio based solution is unclear. It also fixes a bug when the end-points are not attached to the root bus. Important notice: the way the

[Qemu-devel] [RFC v7 01/16] linux-headers: Partial update for virtio-iommu v0.7

2018-08-06 Thread Eric Auger
Partial sync against Jean-Philippe's branch: git://linux-arm.org/linux-jpb.git virtio-iommu/v0.7 Signed-off-by: Eric Auger --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_iommu.h | 172 ++

Re: [Qemu-devel] [PATCH 2/2] fw_cfg: set the get_boot_devices_list() ignore_suffixes parameter from machine property

2018-08-06 Thread Eduardo Habkost
On Sun, Aug 05, 2018 at 12:28:50PM +0100, Mark Cave-Ayland wrote: > For the older machines (such as Mac and SPARC) the DT nodes representing > bootdevices for disk nodes are irregular for mainly historical reasons, and > should be handled on an individual basis via a custom FWPathProvider. > >

Re: [Qemu-devel] [PATCH 1/2] sysbus: always allow explicit_ofw_unit_address() to override address generation

2018-08-06 Thread Eduardo Habkost
On Sun, Aug 05, 2018 at 12:28:49PM +0100, Mark Cave-Ayland wrote: > Some SysBusDevices either use sysbus_init_mmio() without > sysbus_mmio_map() or the first MMIO memory region doesn't represent the > bus address, causing a firmware device path with an invalid address to > be generated. > >

Re: [Qemu-devel] [PATCH v7 48/80] target/mips: Implement CP0 Config1.WR bit functionality

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > > Subject: [PATCH v7 48/80] target/mips: Implement CP0 Config1.WR bit > functionality > > From: Stefan Markovic > > Add testing Config1.WR bit into watch exception handling logic. > > Signed-off-by: Aleksandar Markovic >

[Qemu-devel] [Bug 1785698] [NEW] Solaris build error: unknown type name ‘gcry_error_t’

2018-08-06 Thread Michele Denber
Public bug reported: Building qemu 2.12.0 on a Sun Oracle Enterprise M3000 SPARC64 VII, opencsw toolchain and gcc 7.3.0, gmake fails with a bunch of related errors all in cypher-gcrypt.c: /export/home/denber/qemu-2.12.0/crypto/cipher-gcrypt.c:262:32: error: ‘gcry_cipher_hd_t’ undeclared (first

Re: [Qemu-devel] [PATCH v7 47/80] target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > > Subject: [PATCH v7 47/80] target/mips: Add updating BadInstr, BadInstrP, > BadInstrX for nanoMIPS > > From: Stefan Markovic > > Update BadInstr, BadInstrP,and BadInstrX registers for nanoMIPS. > The same support for

Re: [Qemu-devel] [PATCH v7 56/80] mips_malta: Add basic nanoMIPS boot code for MIPS' Malta

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > Subject: [PATCH v7 56/80] mips_malta: Add basic nanoMIPS boot code for MIPS' > Malta > > From: Matthew Fortune > > Added very very basic nanoMIPS boot code but this is hacked in > unconditionally currently. > >

[Qemu-devel] [Bug 1785670] Re: Guest(ubuntu 18.04) crashes when trying uploading file

2018-08-06 Thread Dr. David Alan Gilbert
Looks like it might be e1000e specific? I can recreate it with either q35 with no extra options (it has e1000e by default), pc or q35 specifying e1000e, but plain pc works fine. Simple test; scp bigfile from guest to user@10.0.2.2: (i.e. host) Dave -- You received this bug notification

Re: [Qemu-devel] [Bug 1785670] [NEW] Guest(ubuntu 18.04) crashes when trying uploading file

2018-08-06 Thread Dr. David Alan Gilbert
Hi Sam, Jan, Dmitry, Any idea where this is coming from; my backtrace shows it's a free in slirp, but only happening with e1000e; see the lp for my backtrace. Dave * Zihan Yang (1785...@bugs.launchpad.net) wrote: > Public bug reported: > > I speficy slirp network, and I can open websites,

[Qemu-devel] [Bug 1785670] Re: Guest(ubuntu 18.04) crashes when trying uploading file

2018-08-06 Thread Dr. David Alan Gilbert
#0 0x7fffec275feb in raise () at /lib64/libc.so.6 #1 0x7fffec2605c1 in abort () at /lib64/libc.so.6 #2 0x7fffec2b89d7 in __libc_message () at /lib64/libc.so.6 #3 0x7fffec2beeac in () at /lib64/libc.so.6 #4 0x7fffec2c091c in _int_free () at /lib64/libc.so.6 #5

[Qemu-devel] [Bug 1785670] Re: Guest(ubuntu 18.04) crashes when trying uploading file

2018-08-06 Thread Dr. David Alan Gilbert
I can recreate this here. ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1785670 Title: Guest(ubuntu 18.04) crashes when trying uploading file

Re: [Qemu-devel] [PATCH v7 45/80] disas: Add support for microMIPS and nanoMIPS

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > > From: Matthew Fortune > > Modify disassembler engine to execute a separate disassembler > for microMIPS and nanoMIPS platforms. > > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- >

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-08-06 Thread Dr. David Alan Gilbert
as per the last two comments, this fix is already in 2.12 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/177 Title: guest migration 100%

Re: [Qemu-devel] [PATCH v7 39/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1

2018-08-06 Thread Aleksandar Markovic
> +case NM_APPEND: > +gen_load_gpr(t0, rs); > + > +if (rd != 0) { > +tcg_gen_deposit_tl(cpu_gpr[rt], t0, cpu_gpr[rt], rd, 32 - rd); > +} > +tcg_gen_ext32s_tl(cpu_gpr[rt], cpu_gpr[rt]); > +break; Missing check_dspr2(). Please fix in next

Re: [Qemu-devel] [PATCH v7 42/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 4

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > From: Stefan Markovic > > Add emulation of DSP ASE instructions for nanoMIPS - part 4. > > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > target/mips/translate.c | 378 >

[Qemu-devel] [Bug 1785308] Re: 0x8 exception encountered but not handled

2018-08-06 Thread Dr. David Alan Gilbert
OK, that's just a cruel test :-) It'll be interesting to see the difference between TCG and KVM, but with such a weird test case as that you'll probably need to narrow the problem down more. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v7 41/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 3

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > > Subject: [PATCH v7 41/80] target/mips: Add emulation of DSP ASE for nanoMIPS > - part 3 > > From: Stefan Markovic > > Add emulation of DSP ASE instructions for nanoMIPS - part 3. > > Signed-off-by: Aleksandar Markovic >

Re: [Qemu-devel] [PATCH v7 40/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 2

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > > Subject: [PATCH v7 40/80] target/mips: Add emulation of DSP ASE for nanoMIPS > - part 2 > > From: Stefan Markovic > > Add emulation of DSP ASE instructions for nanoMIPS - part 2. > > Signed-off-by: Aleksandar Markovic >

Re: [Qemu-devel] [PATCH v7 39/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > > From: Stefan Markovic > > Add emulation of DSP ASE instructions for nanoMIPS - part 1. > > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > target/mips/translate.c | 619

Re: [Qemu-devel] [PATCH v7 36/80] target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > To: qemu-devel@nongnu.org > > From: Aleksandar Rikalo > > Implement support for nanoMIPS LLWP/SCWP instruction pair. > > Signed-off-by: Dimitrije Nikolic > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v7 23/80] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 6:59 PM > > From: Yongbok Kim > > Add emulation of LWXS16, LB16, SB16, LBU16, LH16, SH16, LHU16, LW16, LWSP16, > LW4X4, SW4X4, LWGP16, SWSP16, SW16, and SWGP16 instructions. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar

Re: [Qemu-devel] [PATCH 3/3] crypto: require nettle >= 1.5.0 for building QEMU

2018-08-06 Thread Eric Blake
On 07/18/2018 07:03 AM, Daniel P. Berrangé wrote: nettle 2.7.1 was released in 2013 and all the distros that are build target platforms for QEMU [1] include it: RHEL-7: 2.7.1 Debian (Stretch): 3.3 Debian (Jessie): 2.7.1 OpenBSD (ports): 3.4 FreeBSD (ports): 3.4 OpenSUSE Leap

Re: [Qemu-devel] [PATCH 2/3] crypto: require libgcrypt >= 1.5.0 for building QEMU

2018-08-06 Thread Eric Blake
On 07/18/2018 07:03 AM, Daniel P. Berrangé wrote: libgcrypt 1.5.0 was released in 2011 and all the distros that are build target platforms for QEMU [1] include it: RHEL-7: 1.5.3 Debian (Stretch): 1.7.6 Debian (Jessie): 1.6.3 OpenBSD (ports): 1.8.2 FreeBSD (ports): 1.8.3

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-08-06 Thread Frank Schreuder
Hi David, I can confirm that the specific patch solves our migration freezes. We have not seen any freezes after applying this patch to 2.11.2. We can close this issue as 'fix released'. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [PATCH v7 77/80] linux-user: Add nanoMIPS linux user mode configuration support

2018-08-06 Thread Aleksandar Markovic
From: Stefan Markovic Add new linux user mode configuration for nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- configure | 13 - default-configs/nanomips-linux-user.mak | 1 + 2

[Qemu-devel] [PATCH v7 72/80] linux-user: Add signal.c for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Dimitrije Nikolic Add signal.c as a redirection to regular mips' signal.c, but at the same time amend regular mips' signal.c with bits and pieces specific for nanoMIPS. This was done this way to avoid duplication of large pieces of code. Signed-off-by: Aleksandar Rikalo Signed-off-by:

[Qemu-devel] [PATCH v7 65/80] linux-user: Update syscall_defs.h header for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Update constants and structures related to linux user syscall support in nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/syscall_defs.h | 57 ++-

[Qemu-devel] [PATCH v7 75/80] linux-user: Amend support for sigaction() syscall for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Amend sigaction syscall support for nanoMIPS. This must be done since nanoMIPS' signal handling is different than MIPS' signal handling. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/syscall.c | 2 +-

[Qemu-devel] [PATCH v7 67/80] linux-user: Add sockbits.h header for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add sockbits.h header for nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/nanomips/sockbits.h | 1 + 1 file changed, 1 insertion(+) create mode 100644 linux-user/nanomips/sockbits.h diff

[Qemu-devel] [PATCH v7 62/80] linux-user: Add syscall numbers for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add syscall numbers for nanoMIPS. nanoMIPS redefines its ABI compared to preceding MIPS architectures, and its set of supported system calls is significantly different. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic

Re: [Qemu-devel] [PATCH v7 53/80] elf: Add nanoMIPS specific variations in ELF header fields

2018-08-06 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 6, 2018 7:00 PM > Subject: [PATCH v7 53/80] elf: Add nanoMIPS specific variations in ELF header > fields > > From: Aleksandar Rikalo > > Add nanoMIPS-related values in ELF header fields as specified in > nanoMIPS' "ELF ABI Supplement". > >

[Qemu-devel] [PATCH v7 48/80] target/mips: Implement CP0 Config1.WR bit functionality

2018-08-06 Thread Aleksandar Markovic
From: Stefan Markovic Add testing Config1.WR bit into watch exception handling logic. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c

[Qemu-devel] [PATCH v7 46/80] target/mips: Add handling of branch delay slots for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Matthew Fortune ISA mode bit (LSB of address) is no longer required but is also masked to allow for tools transition. The flag has_isa_mode has the key role in the implementation. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic ---

Re: [Qemu-devel] [PATCH v6 00/12] Enable postcopy RDMA live migration

2018-08-06 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1533287630-4221-1-git-send-email-lidongc...@tencent.com Subject: [Qemu-devel] [PATCH v6

[Qemu-devel] [PATCH v7 43/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 5

2018-08-06 Thread Aleksandar Markovic
From: Stefan Markovic Add emulation of DSP ASE instructions for nanoMIPS - part 5. Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 159 1 file changed, 159

[Qemu-devel] [PATCH v7 80/80] qemu-doc: Add nanoMIPS-related items

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Add nanoMIPS-related items in qemu-doc.texi Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- qemu-doc.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi index 8ea6bfa..ab2471d 100644 --- a/qemu-doc.texi +++

[Qemu-devel] [PATCH v7 76/80] linux-user: Add support for statx() syscall for all platforms

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for syscall statx(). The implementation is based on invoking other (more mature) syscalls (from the same 'stat' family) on the host side. This way, problems of availability of statx() on the host are avoided. Signed-off-by: Aleksandar Markovic

[Qemu-devel] [PATCH v7 41/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 3

2018-08-06 Thread Aleksandar Markovic
From: Stefan Markovic Add emulation of DSP ASE instructions for nanoMIPS - part 3. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 202 1 file changed, 202 insertions(+) diff --git

[Qemu-devel] [PATCH v7 79/80] qemu-doc: Amend MIPS-related items

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend MIPS-related items in qemu-doc.texi Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- qemu-doc.texi | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index abfd2db..8ea6bfa

[Qemu-devel] [PATCH v7 68/80] linux-user: Add target_syscall.h header for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add target_syscall.h header for nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/nanomips/target_syscall.h | 30 ++ 1 file changed, 30 insertions(+) create mode

[Qemu-devel] [PATCH v7 40/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 2

2018-08-06 Thread Aleksandar Markovic
From: Stefan Markovic Add emulation of DSP ASE instructions for nanoMIPS - part 2. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c

[Qemu-devel] [PATCH v7 74/80] linux-user: Add cpu_loop.c for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Dimitrije Nikolic Amend regular MIPS' cpu_loop.c to include nanoMIPS support. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/mips/cpu_loop.c | 8 +++- linux-user/nanomips/cpu_loop.c | 1 + 2 files changed, 8

[Qemu-devel] [PATCH v7 73/80] linux-user: Add support for nanoMIPS signal trampoline

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add signal trampoline support for nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/mips/signal.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v7 70/80] linux-user: Add target_structs.h header for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Dimitrije Nikolic Add target_structs.h header for nanoMIPS, that in fact only redirects to the corresponding MIPS header. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/nanomips/target_structs.h | 1 + 1 file changed,

[Qemu-devel] [PATCH v7 39/80] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1

2018-08-06 Thread Aleksandar Markovic
From: Stefan Markovic Add emulation of DSP ASE instructions for nanoMIPS - part 1. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 619 1 file changed, 619 insertions(+) diff --git

[Qemu-devel] [PATCH v7 71/80] linux-user: Add target_elf.h header for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Dimitrije Nikolic This header includes common elf header, and adds cpu_get_model() function. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/nanomips/target_elf.h | 14 ++ 1 file changed, 14 insertions(+)

[Qemu-devel] [PATCH v7 69/80] linux-user: Add target_cpu.h header for nanoMIPS

2018-08-06 Thread Aleksandar Markovic
From: Dimitrije Nikolic Add target_cpu.h header for nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/nanomips/target_cpu.h | 21 + 1 file changed, 21 insertions(+) create mode 100644

[Qemu-devel] [PATCH v7 78/80] linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh

2018-08-06 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add support for nanomips[eb] variant in scripts/qemu-binfmt-conf.sh. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- scripts/qemu-binfmt-conf.sh | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

  1   2   3   4   >