Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine

2018-11-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 November 2018 at 19:39, Thomas Huth wrote: >> On 2018-11-07 17:08, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On 6 November 2018 at 18:52, Thomas Huth wrote: > On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote: >> On 6/11/18 19:17, Thomas

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-07 Thread Gerd Hoffmann
Hi, > + * The device_display_id_{start,count} denotes the sequence of device display > + * IDs that map to the zero-based sequence of monitor IDs provided by > monitors > + * config on this interface. For example with device_display_id_start = 2 and > + * device_display_id_count = 3 you get

Re: [Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking

2018-11-07 Thread Fam Zheng
On Thu, 10/11 15:21, Fam Zheng wrote: > v5: Address Max's comments (Thanks for reviewing): > - Clean up after test done. > - Add rev-by to patch 1 and 2. Ping? Fam

[Qemu-devel] [ANNOUNCE] QEMU 3.1.0-rc0 is now available

2018-11-07 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 3.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-3.1.0-rc0.tar.xz

[Qemu-devel] QEMU bootup hang in tcg model using mainline QEMU code

2018-11-07 Thread gengdongjiu
Hi All using mainline QEMU code and below boot up commands, the QEMU will be hang when do bootup, if I add the "-enable-kvm" parameter, it can boot up successfully, do you know the reason about it? I also try the "remotes/origin/stable-2.12" branch code using below same boot up commands, it

Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30

2018-11-07 Thread Peter Xu
On Wed, Nov 07, 2018 at 11:21:32AM +, Peter Maydell wrote: > On 7 November 2018 at 02:56, Peter Xu wrote: > > Strange, "make check -j8" failed on my hosts (I tried two) with either > > Markus's pull tree or qemu master: > > > > hw/core/ptimer.o: In function `timer_new_tl': > >

Re: [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name

2018-11-07 Thread Palmer Dabbelt
On Wed, 07 Nov 2018 13:51:45 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 4a137a503c..2b38f89070 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -240,6

Re: [Qemu-devel] [RFC 0/2] vhost-vfio: introduce mdev based HW vhost backend

2018-11-07 Thread Jason Wang
On 2018/11/7 下午11:08, Liang, Cunming wrote: believe. [LC] Agreed, so it reuses CMD defined by vhost-kernel ioctl. But VFIO provides device specific things (e.g. DMAR, INTR and etc.) which is the extra APIs being introduced by this transport. I'm not quite sure I understand here. I think

[Qemu-devel] [PATCH qemu] ppc/spapr: Receive and store device tree blob from SLOF

2018-11-07 Thread Alexey Kardashevskiy
SLOF receives a device tree and updates it with various properties before switching to the guest kernel and QEMU is not aware of any changes made by SLOF. Since there is no real RTAS (QEMU implements it), it makes sense to pass the SLOF final device tree to QEMU to let it implement RTAS related

Re: [Qemu-devel] [PATCH] MAINTAINERS: PPC: Remove myself

2018-11-07 Thread David Gibson
On Wed, Nov 07, 2018 at 05:46:18PM +, Mark Cave-Ayland wrote: > On 07/11/2018 04:25, David Gibson wrote: > > > On Tue, Oct 30, 2018 at 02:34:46PM +, Mark Cave-Ayland wrote: > >> On 30/10/2018 09:35, Alexander Graf wrote: > >> > >>> I haven't really been maintaining any PowerPC code for

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Cleber Rosa
On 11/7/18 1:05 AM, Markus Armbruster wrote: > Eduardo Habkost writes: > >> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis >> seems to provide an older version. Change the existing rules to >> use command output instead of exit code, to make it compatible >> with older GNU

Re: [Qemu-devel] [PATCH] This patch fixes processing of rfi instructions in icount mode.

2018-11-07 Thread David Gibson
On Wed, Nov 07, 2018 at 06:25:19PM +, Mark Cave-Ayland wrote: > On 30/10/2018 12:21, Pavel Dovgalyuk wrote: > > > From: Maria Klimushenkova > > > > In this mode writing to interrupt/peripheral state is controlled > > by can_do_io flag. This flag must be set explicitly before helper > >

[Qemu-devel] [PATCH qemu] hmp: Print if memory section is registered in KVM

2018-11-07 Thread Alexey Kardashevskiy
This adds a "KVM" marker to the "into mtree -f" to tell the user if a particular memory section is registered as a KVM memory slot; useful for debugging purposes. Since it is memory sections which get registered in KVM (rather than memory regions), this only prints "KVM" for flatviews. For

Re: [Qemu-devel] [PATCH V4 3/5] hw/misc/pvpanic: Add the MMIO interface

2018-11-07 Thread peng.hao2
Hi philmd, Are there any problems with this series of patches "pvpanic: add mmio interface"? The kernel part of this series of patches has been upstream. git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-07 Thread Jim Mattson via Qemu-devel
On Wed, Nov 7, 2018 at 4:13 PM, Liran Alon wrote: > Ping on my last reply. > I would like to reach to an agreement on how v3 should look like before just > implementing what I think is right. > > Thanks, > -Liran I have no attachments to the current design. I had used a data[] blob, because I

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-07 Thread Liran Alon
Ping on my last reply. I would like to reach to an agreement on how v3 should look like before just implementing what I think is right. Thanks, -Liran > On 3 Nov 2018, at 4:02, Liran Alon wrote: > > > >> On 2 Nov 2018, at 18:39, Jim Mattson wrote: >> >> On Thu, Nov 1, 2018 at 8:46 PM,

Re: [Qemu-devel] [PATCH v1 5/5] s390x/vfio: ap: Implementing AP Queue Interrupt Control

2018-11-07 Thread Pierre Morel
On 07/11/2018 14:39, Cornelia Huck wrote: On Fri, 2 Nov 2018 11:30:21 +0100 Pierre Morel wrote: We intercept the PQAP(AQIC) instruction and transform the guest's AQIC command parameters for the host AQIC parameters. Doing this we use the standard adapter interface to provide the adapter

Re: [Qemu-devel] [PATCH v1 4/5] s390x/vfio: ap: Intercepting AP Queue Interrupt Control

2018-11-07 Thread Pierre Morel
On 07/11/2018 13:40, Cornelia Huck wrote: On Fri, 2 Nov 2018 11:30:20 +0100 Pierre Morel wrote: From: Pierre Morel Meta: you may want to rewrite your authorship to the shorter address. right thanks (this patch is in my queue since too long) We intercept the PQAP(AQIC) instruction.

Re: [Qemu-devel] [PATCH v6 08/11] authz: add QAuthZList object type for an access control list

2018-11-07 Thread Eric Blake
On 11/7/18 4:23 PM, Marc-André Lureau wrote: +## +# @QAuthZListRuleListHack: +# +# Not exposed via QMP; hack to generate QAuthZListRuleList +# for use internally by the code. Well, this will probably end in the documentation (it's already in the .json, which is one source of documentation ;).

Re: [Qemu-devel] [PATCH v6 06/11] authz: add QAuthZ object as an authorization base class

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:46 PM Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > The current qemu_acl module provides a simple access control list > facility inside QEMU, which is used via a set of monitor commands > acl_show, acl_policy, acl_add, acl_remove & acl_reset. > > Note

Re: [Qemu-devel] [PATCH v6 09/11] authz: add QAuthZListFile object type for a file access control list

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:42 PM Daniel P. Berrangé wrote: > > Add a QAuthZListFile object type that implements the QAuthZ interface. This > built-in implementation is a proxy around the QAtuhZList object type, > initializing it from an external file, and optionally, automatically > reloading it

Re: [Qemu-devel] [PATCH v6 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:49 PM Daniel P. Berrangé wrote: > > In many cases a single VM will just need to whilelist a single identity > as the allowed user of network services. This is especially the case for > TLS live migration (optionally with NBD storage) where we just need to > whitelist the

Re: [Qemu-devel] [PATCH v6 08/11] authz: add QAuthZList object type for an access control list

2018-11-07 Thread Marc-André Lureau
Hi On Fri, Oct 19, 2018 at 5:45 PM Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > Add a QAuthZList object type that implements the QAuthZ interface. This > built-in implementation maintains a trivial access control list with a > sequence of match rules and a final default policy.

Re: [Qemu-devel] [PATCH v6 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2018-11-07 Thread Marc-André Lureau
Hi On Fri, Oct 19, 2018 at 5:47 PM Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > Add an authorization backend that talks to PAM to check whether the user > identity is allowed. This only uses the PAM account validation facility, > which is essentially just a check to see if the

[Qemu-devel] [PATCH v6] lsi: Reselection needed to remove pending commands from queue

2018-11-07 Thread George Kennedy
Under heavy IO (e.g. fio) the queue is not checked frequently enough for pending commands. As a result some pending commands are timed out by the linux sym53c8xx driver, which sends SCSI Abort messages for the timed out commands. The SCSI Abort messages result in linux errors, which show up on the

[Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name

2018-11-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 4a137a503c..2b38f89070 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -240,6 +240,7 @@ static void *create_fdt(RISCVVirtState *s, const struct

Re: [Qemu-devel] [PATCH v6 0/5] Connect a PCIe host and graphics support to RISC-V

2018-11-07 Thread Alistair Francis
On Thu, Nov 1, 2018 at 1:20 AM Andrea Bolognani wrote: > > On Wed, 2018-10-31 at 13:10 -0700, Alistair Francis wrote: > > On Wed, Oct 31, 2018 at 7:51 AM Andrea Bolognani > > wrote: > > > With the pcie.0 <- pcie-root-port <- virtio-net-pci setup I get > > > > > > qemu-system-riscv64: -device

Re: [Qemu-devel] [PATCH v6 2/5] hw/riscv/virt: Connect the gpex PCIe

2018-11-07 Thread Alistair Francis
On Mon, Nov 5, 2018 at 10:45 PM Bin Meng wrote: > > Hi Alistair, > > On Tue, Nov 6, 2018 at 3:47 AM Alistair Francis wrote: > > > > On Mon, Nov 5, 2018 at 5:24 AM Bin Meng wrote: > > > > > > Hi, > > > > > > On Wed, Oct 31, 2018 at 6:22 AM Alistair Francis > > > wrote: > > > > > > > > Connect

Re: [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge

2018-11-07 Thread Collin Walling
On 11/5/18 6:50 AM, David Hildenbrand wrote: > On 05.11.18 12:40, Christian Borntraeger wrote: >> >> >> On 11/05/2018 12:37 PM, David Hildenbrand wrote: >>> On 05.11.18 12:21, Cornelia Huck wrote: On Mon, 5 Nov 2018 12:03:11 +0100 David Hildenbrand wrote: > We directly have it

Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created

2018-11-07 Thread Collin Walling
On 11/5/18 6:03 AM, David Hildenbrand wrote: > Right now, errors during realize()/pre_plug/plug of the zPCI device > would result in QEMU crashing instead of failing nicely when creating > a zPCI device for a PCI device. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-pci-bus.c | 25

Re: [Qemu-devel] [PULL 03/48] qemu-timer: introduce timer attributes

2018-11-07 Thread Eric Blake
On 11/6/18 3:45 AM, Paolo Bonzini wrote: On 06/11/2018 00:16, Eric Blake wrote: On 10/18/18 3:31 PM, Paolo Bonzini wrote: From: Artem Pisarenko Attributes are simple flags, associated with individual timers for their whole lifetime.  They intended to be used to mark individual timers for

Re: [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

2018-11-07 Thread David Hildenbrand
On 07.11.18 16:29, Markus Armbruster wrote: > David Hildenbrand writes: > >> On 05.11.18 21:43, Markus Armbruster wrote: >>> David Hildenbrand writes: >>> On 05.11.18 16:37, Markus Armbruster wrote: > David Hildenbrand writes: > >> On 31.10.18 18:55, Markus Armbruster wrote:

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler

2018-11-07 Thread Collin Walling
On 11/7/18 2:36 PM, David Hildenbrand wrote: >> >> When did these function names drop the *_hot_plug postfix? Latest master >> does not reflect this change for me. >> Just figured I'd mention it now in case merging becomes a pain later ;) >> > > Mentioned it in the cover letter, part of another

[Qemu-devel] [Bug 1802150] Re: Guest undefined when destroyed on host after migration

2018-11-07 Thread Thomas Huth
This is the QEMU bug tracker here ... Can you also reproduce such an issue with plain QEMU? If not, could you please report this to the virt- manager project first? See https://virt-manager.org/bugs/#report for details. ** Changed in: qemu Status: New => Incomplete -- You received this

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine

2018-11-07 Thread Peter Maydell
On 7 November 2018 at 19:39, Thomas Huth wrote: > On 2018-11-07 17:08, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 6 November 2018 at 18:52, Thomas Huth wrote: On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote: > On 6/11/18 19:17, Thomas Huth wrote: >> There is no

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine

2018-11-07 Thread Thomas Huth
On 2018-11-07 17:08, Markus Armbruster wrote: > Peter Maydell writes: > >> On 6 November 2018 at 18:52, Thomas Huth wrote: >>> On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote: On 6/11/18 19:17, Thomas Huth wrote: > There is no active maintainer, but since Peter is picking up >

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler

2018-11-07 Thread David Hildenbrand
> > When did these function names drop the *_hot_plug postfix? Latest master does > not reflect this change for me. > Just figured I'd mention it now in case merging becomes a pain later ;) > Mentioned it in the cover letter, part of another series (also CC'ed to qemu-s3...@nongnu.org, so

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler

2018-11-07 Thread Collin Walling
On 11/5/18 6:50 AM, David Hildenbrand wrote: > On 05.11.18 12:03, David Hildenbrand wrote: >> Let's move most of the checks to the new pre_plug handler. As a PCI >> bridge is just a PCI device, we can simplify the code. >> >> Notes: We cannot yet move the MSIX check or device ID creation + >> zPCI

Re: [Qemu-devel] QEMU and Kconfig

2018-11-07 Thread Thomas Huth
On 2018-11-07 20:24, Eduardo Habkost wrote: > On Wed, Nov 07, 2018 at 06:39:54PM +0100, Paolo Bonzini wrote: >> On 07/11/2018 16:41, Samuel Ortiz wrote: >>> - The Kconfig parser would be used to generate the equivalent of what we >>> currently have under default-configs/ I think we would still

Re: [Qemu-devel] QEMU and Kconfig

2018-11-07 Thread Eduardo Habkost
On Wed, Nov 07, 2018 at 06:39:54PM +0100, Paolo Bonzini wrote: > On 07/11/2018 16:41, Samuel Ortiz wrote: > > - The Kconfig parser would be used to generate the equivalent of what we > > currently have under default-configs/ > > It would be used to generate config-devices.mak, instead of >

[Qemu-devel] [PATCH v2 6/6] target/mips: Guard check_insn with INSN_R5900 check

2018-11-07 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index c3ed4c21ce..007dfd2975 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28329,8

[Qemu-devel] [PATCH v2 5/6] target/mips: Guard check_insn_opc_user_only with INSN_R5900 check

2018-11-07 Thread Fredrik Noring
Signed-off-by: Fredrik Noring --- target/mips/translate.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 45ad70c097..c3ed4c21ce 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@

[Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes

2018-11-07 Thread Fredrik Noring
MOVN, MOVZ, MFHI, MFLO, MTHI, MTLO, MULT, MULTU, DIV, DIVU, DMULT, DMULTU, DDIV, DDIVU and JR are decoded in decode_opc_special_tx79 instead of the generic decode_opc_special_legacy. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 54 ++--- 1 file

[Qemu-devel] [PATCH v2 2/6] target/mips: Fix decoding mechanism of R5900 DIV1 and DIVU1

2018-11-07 Thread Fredrik Noring
DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv. Signed-off-by: Fredrik Noring Reviewed-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 65 + 1 file changed, 59 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/6] Fix decoding mechanisms of the R5900

2018-11-07 Thread Fredrik Noring
This series amends the R5900 support with the following changes: - MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO. - DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv. - MOVN, MOVZ, MFHI, MFLO, MTHI, MTLO, MULT,

[Qemu-devel] [PATCH v2 3/6] target/mips: Fix HI[ac] and LO[ac] 32-bit truncation with MIPS64 DSP ASE

2018-11-07 Thread Fredrik Noring
This change removes the 32-bit truncation of the HI[ac] and LO[ac] special purpose registers when ac range from 1 to 3 for the instructions MFHI, MFLO, MTHI and MTLO. The "MIPS Architecture for Programmers Volume IV-e: MIPS DSP Module for MIPS64 Architecture" manual specifies that all 64 bits are

[Qemu-devel] [PATCH v2 1/6] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1

2018-11-07 Thread Fredrik Noring
MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 51 - 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/target/mips/translate.c

Re: [Qemu-devel] [PATCH 0/2] target/mips: Fix decoding mechanisms of R5900 M{F, T}{HI, LO}1 and DIV[U]1

2018-11-07 Thread Fredrik Noring
Hi Aleksandar, > I think the following code would be even better: > > case OPC_SC: > check_insn(ctx, ISA_MIPS2); > check_insn_opc_removed(ctx, ISA_MIPS32R6); > if (ctx->insn_flags & INSN_R5900) { > check_insn_opc_user_only(ctx, INSN_R5900); > } >

Re: [Qemu-devel] [PATCH v2 12/12] disas/mips: Disassemble R5900 DIV[U]1, M{F, T}{LO, HI}1 and MULT[U]1

2018-11-07 Thread Fredrik Noring
Hi Aleksandar, > I am glad that you want to include QEMU disas support for R5900 - this > area usually gets forgotten. > > But, as you can see, this MIPS feature is partially broken - it doesn't > handle well overlapping opcodes, and the field "membership" is not taken > into account at all. I

Re: [Qemu-devel] [PATCH] i386: Rename bools in PCMachineState to end in _enabled

2018-11-07 Thread Eduardo Habkost
On Wed, Nov 07, 2018 at 09:24:34AM -0600, miny...@acm.org wrote: > From: Corey Minyard > > This makes their function more clear and prevents conflicts when adding > the actual devices to the machine state, if necessary. > > Signed-off-by: Corey Minyard > Cc: Paolo Bonzini > Cc: Richard

Re: [Qemu-devel] [PATCH for-3.2 v3 13/14] hw/i386: add pc-i440fx-3.2 & pc-q35-3.2

2018-11-07 Thread Eduardo Habkost
On Wed, Nov 07, 2018 at 07:49:54PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Nov 7, 2018 at 4:49 PM Marc-André Lureau > wrote: > > > > The following patch is going to add compatiblity parameters for > > qemu <= 3.1. > > > > I realize this may be good enough for x86 i440/q35 machines, but

[Qemu-devel] [RFC QEMU 0/2] arm/virt: Account for guest pause time

2018-11-07 Thread Bijan Mottahedeh
This patch series address two Qemu issues: - improper system clock frequency initialization - lack of pause (virtsh suspend) time accounting A simple test to reproduce the problem executes one or more instances of the following command in the guest: dd if=/dev/zero of=/dev/null & and then

[Qemu-devel] [RFC QEMU 1/2] arm/virt: Initialize generic timer scale factor dynamically

2018-11-07 Thread Bijan Mottahedeh
Initialize the generic timer scale factor based on the counter frequency register cntfrq_el0, and default to the current static value if necessary. Signed-off-by: Bijan Mottahedeh --- hw/arm/virt.c | 15 +++ target/arm/helper.c| 19 ---

[Qemu-devel] [RFC QEMU 2/2] arm/virt: Account for guest pause time

2018-11-07 Thread Bijan Mottahedeh
Accumulate the total guest pause time and update the virtual counter offset register accordingly in order to account for that time before resuming the guest. Signed-off-by: Bijan Mottahedeh --- hw/intc/arm_gicv3_kvm.c | 39 +++ target/arm/cpu.h| 3

[Qemu-devel] [Bug 1802150] [NEW] Guest undefined when destroyed on host after migration

2018-11-07 Thread Dan Midthun
Public bug reported: After a live migration, guest VMs are being undefined from the host they were migrated to after shutdown. I have experienced this at two (2) separate locations on more than one hardware configuration. This happens when utilizing virt-manager to view current allocations on

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-07 Thread Palmer Dabbelt
On Tue, 06 Nov 2018 10:43:17 PST (-0800), Peter Maydell wrote: I had an idea for how to get a rough list of source files containing devices that haven't been QOMified. The theory is that a pre-QOM device generally has an "init" function which allocates memory for the device struct. So looking in

Re: [Qemu-devel] [PATCH 3/3] arm: allwinner: Enable USB EHCI

2018-11-07 Thread Guenter Roeck
On Mon, Nov 05, 2018 at 09:16:56AM +0100, Gerd Hoffmann wrote: > > > > @@ -116,6 +116,8 @@ static void aw_a10_realize(DeviceState *dev, Error > > > > **errp) > > > > if (machine_usb(current_machine)) { > > > > sysbus_create_simple("sysbus-ohci", 0x01c14400, s->irq[64]); > > > >

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Remove known crashes

2018-11-07 Thread Eduardo Habkost
On Tue, Nov 06, 2018 at 02:27:06PM +0100, Thomas Huth wrote: > Looks like we've fixed them all already in the past months, e.g. with: > > f7d6bfcdc0fe49040aac3ac131a319cb5427957e > spapr_pci: fail gracefully with non-pseries machine types > > 2363d5ee231bf047479422d56d3b85b7d37a7c23 >

Re: [Qemu-devel] [PATCH v2 0/2] x86/cpu: Enable direct stores cpu features

2018-11-07 Thread Eduardo Habkost
On Tue, Nov 06, 2018 at 03:13:25PM +0800, Liu Jingqi wrote: > Enable direct stores cpu features including MOVDIRI and MOVDIR64B. > > MOVDIRI moves doubleword or quadword from register to memory through > direct store. > MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity.

Re: [Qemu-devel] [PATCH] target/ppc: fix mtmsr instruction for icount

2018-11-07 Thread Mark Cave-Ayland
On 06/11/2018 12:20, 'David Gibson' wrote: > On Tue, Nov 06, 2018 at 09:10:45AM +0300, Pavel Dovgalyuk wrote: >>> From: David Gibson [mailto:da...@gibson.dropbear.id.au] >>> On Tue, Oct 30, 2018 at 12:30:31PM +0300, Pavel Dovgalyuk wrote: This patch fixes processing of mtmsr instructions in

Re: [Qemu-devel] [PATCH v6 05/11] hw/usb: switch MTP to use new inotify APIs

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:42 PM Daniel P. Berrangé wrote: > > The internal inotify APIs allow alot of conditional statements to be a lot > cleared out, and provide a simpler callback for handling events. > > Signed-off-by: Daniel P. Berrangé > --- > hw/usb/dev-mtp.c| 250

Re: [Qemu-devel] [PATCH] This patch fixes processing of rfi instructions in icount mode.

2018-11-07 Thread Mark Cave-Ayland
On 30/10/2018 12:21, Pavel Dovgalyuk wrote: > From: Maria Klimushenkova > > In this mode writing to interrupt/peripheral state is controlled > by can_do_io flag. This flag must be set explicitly before helper > function invocation. > > Signed-off-by: Maria Klimushenkova > Signed-off-by: Pavel

Re: [Qemu-devel] [PATCH v6 02/11] qom: don't require user creatable objects to be registered

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:39 PM Daniel P. Berrangé wrote: > > When an object is in turn owned by another user object, it is not > desirable to expose this in the QOM object hierarchy, as it is > just an internal implementation detail, we should be free to change > without exposure. > >

Re: [Qemu-devel] [PATCH v6 04/11] hw/usb: fix const-ness for string params in MTP driver

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:43 PM Daniel P. Berrangé wrote: > > Various functions accepting 'char *' string parameters were missing > 'const' qualifiers. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau > --- > hw/usb/dev-mtp.c | 8

Re: [Qemu-devel] [PATCH v6 01/11] util: add helper APIs for dealing with inotify in portable manner

2018-11-07 Thread Marc-André Lureau
Hi On Fri, Oct 19, 2018 at 5:41 PM Daniel P. Berrangé wrote: > > The inotify userspace API for reading events is quite horrible, so it is > useful to wrap it in a more friendly API to avoid duplicating code > across many users in QEMU. Wrapping it also allows introduction of a > platform

Re: [Qemu-devel] [PATCH v6 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver

2018-11-07 Thread Marc-André Lureau
On Fri, Oct 19, 2018 at 5:40 PM Daniel P. Berrangé wrote: > > IN_ISDIR is not a bit that one can request when registering a > watch with inotify_add_watch. Rather it is a bit that is set > automatically when reading events from the kernel. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by:

Re: [Qemu-devel] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv

2018-11-07 Thread Kevin Wolf
(Broken quoting in text/plain again) Am 01.11.2018 um 13:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > 27.09.2018 20:35, Max Reitz wrote: > > On 07.08.18 19:43, Vladimir Sementsov-Ogievskiy wrote: > > Memory allocation may become less efficient for encrypted case. It's a >

Re: [Qemu-devel] [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Nir Soffer
On Wed, Nov 7, 2018 at 7:27 PM Kevin Wolf wrote: > Am 07.11.2018 um 15:56 hat Nir Soffer geschrieben: > > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones > wrote: > > > > > Another thing I tried was to change the NBD server (nbdkit) so that it > > > doesn't advertise zero support to the client:

Re: [Qemu-devel] [Bug 1758819] Re: HVF Illegal instruction: 4, High Sierra, v2.12-rc0

2018-11-07 Thread Peter Maydell
On 7 November 2018 at 17:15, Nathan Wallace <1758...@bugs.launchpad.net> wrote: > I am also able to reproduce this bug. The problem is that when hvf is > enabled, qemu will attempt to execute the xgetbv instruction, which > isn't supported on my processor (Intel Xeon X5670). > > Here is a stack

Re: [Qemu-devel] [PATCH] MAINTAINERS: PPC: Remove myself

2018-11-07 Thread Mark Cave-Ayland
On 07/11/2018 04:25, David Gibson wrote: > On Tue, Oct 30, 2018 at 02:34:46PM +, Mark Cave-Ayland wrote: >> On 30/10/2018 09:35, Alexander Graf wrote: >> >>> I haven't really been maintaining any PowerPC code for quite a while now, >>> so let's reflect reality: David does all the work and

Re: [Qemu-devel] QEMU and Kconfig

2018-11-07 Thread Paolo Bonzini
On 07/11/2018 16:41, Samuel Ortiz wrote: > - The Kconfig parser would be used to generate the equivalent of what we > currently have under default-configs/ It would be used to generate config-devices.mak, instead of scripts/make_device_config.sh. My branch already had some Makefile

Re: [Qemu-devel] [PATCH v5] lsi: Reselection needed to remove pending commands from queue

2018-11-07 Thread Paolo Bonzini
On 07/11/2018 17:19, George Kennedy wrote: > +if (s->want_resel && s->resel_dsp) { > +save_dsp = s->dsp; > +s->dsp = s->resel_dsp; > +s->want_resel = false; > +} > break; Almost... this

Re: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension

2018-11-07 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181106110548.4209-1-luc.mic...@greensocs.com Subject: [Qemu-devel] [PATCH v4 00/16] gdbstub: support for the multiprocess extension === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [Bug 1758819] Re: HVF Illegal instruction: 4, High Sierra, v2.12-rc0

2018-11-07 Thread Nathan Wallace
I am also able to reproduce this bug. The problem is that when hvf is enabled, qemu will attempt to execute the xgetbv instruction, which isn't supported on my processor (Intel Xeon X5670). Here is a stack trace from lldb; the behavior is 100% reproducible for me.

Re: [Qemu-devel] [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Kevin Wolf
Am 07.11.2018 um 15:56 hat Nir Soffer geschrieben: > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones wrote: > > > Another thing I tried was to change the NBD server (nbdkit) so that it > > doesn't advertise zero support to the client: > > > > $ nbdkit --filter=log --filter=nozero memory size=6G

[Qemu-devel] getting link errors when building for qga-vss.dll

2018-11-07 Thread Kirk Allan
When I try to build qga-vss.dll I get the following link error: LINKqga/vss-win32/qga-vss.dll /usr/lib64/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld: qga/vss-win32/requester.o: in function `requester_freeze': /src/qemu/qga/vss-win32/requester.cpp:284: undefined reference

Re: [Qemu-devel] vhost-user devices work with chardev from different threads

2018-11-07 Thread Yury Kotov
Hi, I was wrong... Described problem with vhost-user is not possible. It cannot enter tcp_chr_disconnect twice because of qemu global mutex (BQL). Thus chardev event handler (main loop) and vhost_user_blk_set_status (VCPU) are working under BQL. 30.10.2018, 20:12, "Marc-André Lureau" : > Hi > >

Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30

2018-11-07 Thread Eric Blake
On 11/7/18 5:21 AM, Peter Maydell wrote: On 7 November 2018 at 02:56, Peter Xu wrote: Strange, "make check -j8" failed on my hosts (I tried two) with either Markus's pull tree or qemu master: hw/core/ptimer.o: In function `timer_new_tl': /home/xz/git/qemu/include/qemu/timer.h:536: undefined

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Eric Blake
On 11/7/18 6:13 AM, Richard W.M. Jones wrote: (I'm not going to claim this is a bug, but it causes a large, easily measurable performance regression in virt-v2v). I haven't closely looked at at this email thread yet, but a quick first impression: In qemu 2.12 this behaviour changed: $

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Nov 07, 2018 at 01:45:35PM +, Peter Maydell wrote: >> On 7 November 2018 at 12:49, Eduardo Habkost wrote: >> > Now, why do we need --with-python, and why do we need to use >> > $(PYTHON) when running tests? If somebody wants to use a >> > different Python

Re: [Qemu-devel] [PATCH v2 for-3.1] hw/arm/sysbus-fdt: Only call match_fn callback if the type matches

2018-11-07 Thread Alex Williamson
On Tue, 6 Nov 2018 19:42:12 +0100 Eric Auger wrote: > Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT > compatible value) introduced a match_fn callback which gets called > for each registered combo to check whether a sysbus device can be > dynamically instantiated.

[Qemu-devel] [PATCH v5] lsi: Reselection needed to remove pending commands from queue

2018-11-07 Thread George Kennedy
Under heavy IO (e.g. fio) the queue is not checked frequently enough for pending commands. As a result some pending commands are timed out by the linux sym53c8xx driver, which sends SCSI Abort messages for the timed out commands. The SCSI Abort messages result in linux errors, which show up on the

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/4] s390x/zpci: drop msix.available

2018-11-07 Thread Collin Walling
On 11/5/18 6:19 AM, Cornelia Huck wrote: > On Mon, 5 Nov 2018 12:03:10 +0100 > David Hildenbrand wrote: > >> I fail to see why this is useful as we require MSIX always and >> completely fail adding a device. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-pci-bus.c | 2 -- >>

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine

2018-11-07 Thread Markus Armbruster
Peter Maydell writes: > On 6 November 2018 at 18:52, Thomas Huth wrote: >> On 2018-11-06 19:49, Philippe Mathieu-Daudé wrote: >>> On 6/11/18 19:17, Thomas Huth wrote: There is no active maintainer, but since Peter is picking up patches via qemu-...@nongnu.org, I think we could at

[Qemu-devel] [PATCH 2/3] i2c: Add an SMBus vmstate structure

2018-11-07 Thread minyard
From: Corey Minyard There is no vmstate handling for SMBus, so no device sitting on SMBus can have a state transfer that works reliable. So add it. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert --- hw/i2c/smbus.c | 14

[Qemu-devel] [PATCH 1/3] i2c:pm_smbus: Fix state transfer

2018-11-07 Thread minyard
From: Corey Minyard Transfer the state information for the SMBus registers and internal data so it will work on a VM transfer. Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Dr. David Alan Gilbert --- hw/acpi/piix4.c | 3 ++- hw/i2c/pm_smbus.c

[Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-07 Thread minyard
From: Corey Minyard This was if the eeprom is accessed during a state transfer, the transfer will be reliable. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert --- hw/i2c/smbus_eeprom.c | 16 +++- 1 file changed, 15 insertions(+),

[Qemu-devel] [PATCH 0/3] Fix/add vmstate handling in some I2C code

2018-11-07 Thread minyard
These changes allow SMBus access while doing a state transfer. Seems like a good idea to me in general. I have these queued for the SMBus IPMI driver work, of course.

Re: [Qemu-devel] [PATCH] i386: Rename bools in PCMachineState to end in _enabled

2018-11-07 Thread Philippe Mathieu-Daudé
On 7/11/18 16:24, miny...@acm.org wrote: From: Corey Minyard This makes their function more clear and prevents conflicts when adding the actual devices to the machine state, if necessary. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

Re: [Qemu-devel] [PATCH for-3.2 v3 13/14] hw/i386: add pc-i440fx-3.2 & pc-q35-3.2

2018-11-07 Thread Marc-André Lureau
Hi On Wed, Nov 7, 2018 at 4:49 PM Marc-André Lureau wrote: > > The following patch is going to add compatiblity parameters for > qemu <= 3.1. > I realize this may be good enough for x86 i440/q35 machines, but what about other machines & architectures? What do we officially support, for

Re: [Qemu-devel] QEMU and Kconfig

2018-11-07 Thread Samuel Ortiz
Hi Paolo, On Thu, Sep 27, 2018 at 10:55:59AM +0200, Paolo Bonzini wrote: > > What is the syntactic thing in this example which distinguishes > > "user can toggle this" (ESP_PCI, ARM_VIRT, SUN4M) from "user > > can't toggle this, it's just an internal thing selected by > > other nodes" (the rest)

Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-07 Thread Eduardo Habkost
On Wed, Nov 07, 2018 at 01:45:35PM +, Peter Maydell wrote: > On 7 November 2018 at 12:49, Eduardo Habkost wrote: > > Now, why do we need --with-python, and why do we need to use > > $(PYTHON) when running tests? If somebody wants to use a > > different Python binary when running tests, they

Re: [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

2018-11-07 Thread Markus Armbruster
David Hildenbrand writes: > On 05.11.18 21:43, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 05.11.18 16:37, Markus Armbruster wrote: David Hildenbrand writes: > On 31.10.18 18:55, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On

[Qemu-devel] [PATCH] i386: Rename bools in PCMachineState to end in _enabled

2018-11-07 Thread minyard
From: Corey Minyard This makes their function more clear and prevents conflicts when adding the actual devices to the machine state, if necessary. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost --- hw/i386/pc.c | 18 +-

Re: [Qemu-devel] List of files containing devices which have not been QOMified

2018-11-07 Thread Philippe Mathieu-Daudé
On 7/11/18 0:06, Peter Maydell wrote: On 6 November 2018 at 19:16, Philippe Mathieu-Daudé wrote: On 6/11/18 19:43, Peter Maydell wrote: I had an idea for how to get a rough list of source files containing devices that haven't been QOMified. The theory is that a pre-QOM device generally has

[Qemu-devel] [PATCH for-3.2 v2] vhost-user: define conventions for vhost-user backends

2018-11-07 Thread Marc-André Lureau
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU" review, let's define a common set of backend conventions to help with management layer implementation, and interoperability. v2: - use a vhost-user.json schema to discover backends and describe capability format - drop

Re: [Qemu-devel] [RFC 0/2] vhost-vfio: introduce mdev based HW vhost backend

2018-11-07 Thread Liang, Cunming
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, November 7, 2018 2:38 PM > To: Liang, Cunming ; Wang, Xiao W > ; m...@redhat.com; alex.william...@redhat.com > Cc: qemu-devel@nongnu.org; Bie, Tiwei ; Ye, Xiaolong > ; Wang, Zhihong ; Daly, Dan > >

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Richard W.M. Jones
On Wed, Nov 07, 2018 at 04:56:48PM +0200, Nir Soffer wrote: > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones wrote: > > > Another thing I tried was to change the NBD server (nbdkit) so that it > > doesn't advertise zero support to the client: > > > > $ nbdkit --filter=log --filter=nozero

Re: [Qemu-devel] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

2018-11-07 Thread Nir Soffer
Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones wrote: > Another thing I tried was to change the NBD server (nbdkit) so that it > doesn't advertise zero support to the client: > > $ nbdkit --filter=log --filter=nozero memory size=6G logfile=/tmp/log \ > --run './qemu-img convert

Re: [Qemu-devel] [RFC 0/2] vhost-vfio: introduce mdev based HW vhost backend

2018-11-07 Thread Jason Wang
On 2018/11/7 下午8:26, Liang, Cunming wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Tuesday, November 6, 2018 4:18 AM To: Wang, Xiao W ; m...@redhat.com; alex.william...@redhat.com Cc: qemu-devel@nongnu.org; Bie, Tiwei ; Liang, Cunming ; Ye, Xiaolong ;

  1   2   >