On 12/7/18 2:57 AM, David Gibson wrote:
> On Thu, Dec 06, 2018 at 07:22:54AM +0100, Cédric Le Goater wrote:
>> On 12/6/18 4:41 AM, David Gibson wrote:
>>> On Thu, Dec 06, 2018 at 12:22:18AM +0100, Cédric Le Goater wrote:
The XiveRouter models the second sub-engine of the XIVE architecture :
On 12/7/18 3:05 AM, David Gibson wrote:
> On Thu, Dec 06, 2018 at 07:30:34AM +0100, Cédric Le Goater wrote:
>> On 12/6/18 5:09 AM, David Gibson wrote:
>>> On Thu, Dec 06, 2018 at 12:22:20AM +0100, Cédric Le Goater wrote:
> [snip]
+/*
+ * END ESB MMIO loads
+ */
+static uint64_t
Paolo Bonzini writes:
> This will be needed when we change the QTAILQ head and elem structs
> to unions. However, it is also consistent with the usage elsewhere
> in QEMU for other list head structs (see for example FsMountList).
>
> Note that most QTAILQs only need their name in order to do
Paolo Bonzini writes:
> Most list head structs need not be given a name. In most cases the
> name is given just in case one is going to use QTAILQ_LAST, QTAILQ_PREV
> or reverse iteration, but this does not apply to lists of other kinds,
> and even for QTAILQ in practice this is only rarely
Paolo Bonzini writes:
> Use the QTAILQ_IN_USE macro instead, it does the same thing but the next
> patch will change it to a different definition.
>
> Signed-off-by: Paolo Bonzini
> ---
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockdev.c
This is a reasonably careful review of the QAPI-related parts, but more
of an eye-over for the remainder.
Kevin Wolf writes:
> From: Fam Zheng
>
> This makes VMDK support blockdev-create. The implementation reuses the
> image creation code in vmdk_co_create_opts which now acceptes a callback
>
Kevin Wolf writes:
> From: Fam Zheng
>
> The extracted vmdk_init_extent takes a BlockBackend object and
> initializes the format metadata. It is the common part between "qemu-img
> create" and "blockdev-create".
>
> Add a "BlockBackend *pbb" parameter to vmdk_create_extent, to return the
>
On 2018-12-06 22:50, Paolo Bonzini wrote:
> Sometimes a test's main() function recognizes that the environment
> does not support the test, and therefore exits. In this case, we
> still should run g_test_run() so that a TAP harness will print the
> test plan ("1..0") and the test will be marked
On 2018-12-06 22:50, Paolo Bonzini wrote:
> gtester is deprecated by upstream glib (see for example the announcement
> at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does
> not support tests that call g_test_skip in some glib stable releases.
>
> glib suggests instead using
On 2018-12-06 21:06, Paolo Bonzini wrote:
> On 06/12/18 17:15, Thomas Huth wrote:
>>>
>>> -for (j = 0; j < 256; j++) {
>>> -uint32_t a = readl(s->memory.regions[i].guest_phys_addr + j*4);
>>> +for (j = 0; j < 1024; j++) {
>>> +uint32_t a =
On Tue, Nov 20, 2018 at 11:08 AM Peter Maydell wrote:
> It's still stuck, because unconditionally adding a second serial
> port to the virt board breaks some commonly used existing guest
> code (UEFI + Linux), and it's not clear to me what the best
> command line UI is for allowing the user to
On Thu, Dec 06, 2018 at 12:22:27AM +0100, Cédric Le Goater wrote:
> Initialize the MSI bitmap from it as this will be necessary for the
> sPAPR IRQ backend for XIVE.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: David Gibson
This also stands on its own, so I've applied it.
> ---
>
On Thu, Dec 06, 2018 at 12:22:29AM +0100, Cédric Le Goater wrote:
> The XIVE sPAPR IRQ backend will use it to define the number of ENDs of
> the IC controller.
>
> Signed-off-by: Cédric Le Goater
Again, this makes sense on its own, so I've applied.
> ---
> include/hw/ppc/spapr.h | 1 +
>
On Thu, Dec 06, 2018 at 12:22:26AM +0100, Cédric Le Goater wrote:
> We will need to use xics_max_server_number() to create the sPAPRXive
> object modeling the interrupt controller of the machine which is
> created before the CPUs.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Greg Kurz
On Thu, Dec 06, 2018 at 12:22:22AM +0100, Cédric Le Goater wrote:
> The last sub-engine of the XIVE architecture is the Interrupt
> Virtualization Presentation Engine (IVPE). On HW, the IVRE and the
> IVPE share elements, the Power Bus interface (CQ), the routing table
> descriptors, and they can
On Thu, Dec 06, 2018 at 12:22:24AM +0100, Cédric Le Goater wrote:
65;5402;1c> sPAPRXive models the XIVE interrupt controller of the sPAPR machine.
> It inherits from the XiveRouter and provisions storage for the routing
> tables :
>
> - Event Assignment Structure (EAS)
> - Event Notification
On Thu, Dec 06, 2018 at 12:22:23AM +0100, Cédric Le Goater wrote:
> After the event data was enqueued in the O/S Event Queue, the IVPE
> raises the bit corresponding to the priority of the pending interrupt
> in the register IBP (Interrupt Pending Buffer) to indicate there is an
> event pending in
On Thu, Dec 06, 2018 at 12:22:25AM +0100, Cédric Le Goater wrote:
> The IVPE scans the O/S CAM line of the XIVE thread interrupt contexts
> to find a matching Notification Virtual Target (NVT) among the NVTs
> dispatched on the HW processor threads.
>
> On a real system, the thread interrupt
On Fri, Dec 07, 2018 at 09:53:06AM +0800, wangjian wrote:
> Memset vhost_dev to zero in the vhost_dev_cleanup function.
> This causes dev.vqs to be NULL, so that
> vqs does not free up space when calling the g_free function.
> This will result in a memory leak. But you can't release vqs
> directly
On 2018/12/6 23:14, Peter Maydell wrote:
> ---
> I think this patch:
> * should be necessary for the current KVM debug code to be able
>to actually set the ESR_EL1 for the guest when it wants to
>deliver a breakpoint exception to it
> * will also be necessary for Dongjiu's patchset to
On Thu, Dec 06, 2018 at 07:22:54AM +0100, Cédric Le Goater wrote:
> On 12/6/18 4:41 AM, David Gibson wrote:
> > On Thu, Dec 06, 2018 at 12:22:18AM +0100, Cédric Le Goater wrote:
> >> The XiveRouter models the second sub-engine of the XIVE architecture :
> >> the Interrupt Virtualization Routing
On Thu, Dec 06, 2018 at 07:17:47AM +0100, Cédric Le Goater wrote:
> On 12/6/18 4:25 AM, David Gibson wrote:
> > On Thu, Dec 06, 2018 at 12:22:17AM +0100, Cédric Le Goater wrote:
> >> The XiveNotifier offers a simple interface, between the XiveSource
> >> object and the main interrupt controller of
On Thu, Dec 06, 2018 at 07:30:34AM +0100, Cédric Le Goater wrote:
> On 12/6/18 5:09 AM, David Gibson wrote:
> > On Thu, Dec 06, 2018 at 12:22:20AM +0100, Cédric Le Goater wrote:
[snip]
> >> +/*
> >> + * END ESB MMIO loads
> >> + */
> >> +static uint64_t xive_end_source_read(void *opaque, hwaddr
Memset vhost_dev to zero in the vhost_dev_cleanup function.
This causes dev.vqs to be NULL, so that
vqs does not free up space when calling the g_free function.
This will result in a memory leak. But you can't release vqs
directly in the vhost_dev_cleanup function, because vhost_net
will also
Patchew URL:
https://patchew.org/QEMU/1544135058-21380-1-git-send-email-wall...@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v2 0/3] Guest Support for Diagnose 318
Message-id:
On Thu, Dec 06, 2018 at 10:48:51AM -0200, Eduardo Habkost wrote:
> On Thu, Dec 06, 2018 at 09:30:35AM +1100, David Gibson wrote:
> > On Wed, Dec 05, 2018 at 06:58:26PM -0200, Eduardo Habkost wrote:
> > > Now that all instance_options functions for spapr are empty,
> > > delete them.
> > >
> > >
Patchew URL: https://patchew.org/QEMU/20181206192544.3987-1-js...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH 0/3] bitmaps: remove x- prefix from QMP api
Message-id:
The new definition of QTAILQ does not require passing the headname,
remove it.
Signed-off-by: Paolo Bonzini
---
cpus-common.c | 2 +-
dump.c | 2 +-
hw/core/qdev.c | 4 ++--
hw/scsi/scsi-bus.c | 2 +-
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8d6e44107..b4b3495044 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2263,6 +2263,11 @@ sub process {
Most list head structs need not be given a name. In most cases the
name is given just in case one is going to use QTAILQ_LAST, QTAILQ_PREV
or reverse iteration, but this does not apply to lists of other kinds,
and even for QTAILQ in practice this is only rarely needed. In addition,
we will soon
QTAILQ is a doubly linked list, with a pointer-to-pointer to the last
element from the head, and the previous element from each node.
But if you squint enough, QTAILQ becomes a combination of a singly-linked
forwards list, and another singly-linked list which goes backwards and
is circular. This
This series includes two changes that are a bit intertwined.
The main one is to reimplement QTAILQ in a way that simplifies
backwards walking of the list. The in-memory layout actually
stays the same, but the C description of it changes so that
(also thanks to typeof) you don't have to specify a
Use the QTAILQ_IN_USE macro instead, it does the same thing but the next
patch will change it to a different definition.
Signed-off-by: Paolo Bonzini
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 81f95d920b..7604b2183b 100644
This will be needed when we change the QTAILQ head and elem structs
to unions. However, it is also consistent with the usage elsewhere
in QEMU for other list head structs (see for example FsMountList).
Note that most QTAILQs only need their name in order to do backwards
walks. Those do not
On 12/5/18 9:51 AM, Cornelia Huck wrote:
vfio-ap devices do not pin any pages in the host. Therefore, they
are belived to be compatible with memory ballooning.
Flag them as compatible, so both vfio-ap and a balloon can be
used simultaneously.
Signed-off-by: Cornelia Huck
---
As briefly
Diagnose 318 is a new z14.2 CPU feature. Since we are able to emulate
it entirely via KVM, we can add guest support for earlier models. A
new CPU feature for diagnose 318 (shortened to diag318) will be made
available to guests starting with the zEC12-full CPU model.
The z14.2 adds a new read SCP
Changelog:
RFC -> v1
- introduced kvm stubs for set/get cpc
- s/fac134/byte_134
- moved diag318 vmstate description to diag.c
- reduced S390_VCPU_MAX to 247
v1 -> v2
- split patches into header sync, cpu model feat, and diag migration /
reset
Diagnose 318 contains data regarding the guest's name code
and version code (collectively called the cpc) and must be
captured for migration. Since this instruction is executed
in the kernel during IPL, we register the migration handlers
during IPL as well.
Also add a reset method for the
Introduce VM group, attribute, and CPU feat defines for
diagnose 318.
Signed-off-by: Collin Walling
---
linux-headers/asm-s390/kvm.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h
index 0265482..4b655e3 100644
---
gtester is deprecated by upstream glib (see for example the announcement
at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does
not support tests that call g_test_skip in some glib stable releases.
glib suggests instead using Automake's TAP support, which gtest itself
supports since
gtester is deprecated by upstream glib[1] and it does not support tests
that call g_test_skip in some glib stable releases.
glib suggests instead using Automake's TAP support. We do not support
Automake, but we can copy the code that beautifies the TAP output and
use it. I chose to use the Perl
Sometimes a test's main() function recognizes that the environment
does not support the test, and therefore exits. In this case, we
still should run g_test_run() so that a TAP harness will print the
test plan ("1..0") and the test will be marked as skipped.
Signed-off-by: Paolo Bonzini
On 06/12/18 22:27, Corey Minyard wrote:
> On 12/6/18 3:10 PM, Paolo Bonzini wrote:
>> On 09/11/18 14:33, Corey Minyard wrote:
>>> On 11/8/18 5:22 PM, David Gibson wrote:
>>> I'm not sure about migration. I suppose it could be migrated, but I
>>> would consider the BMC part of the hardware that
On 12/6/18 3:10 PM, Paolo Bonzini wrote:
On 09/11/18 14:33, Corey Minyard wrote:
On 11/8/18 5:22 PM, David Gibson wrote:
I'm not sure about migration. I suppose it could be migrated, but I
would consider the BMC part of the hardware that needs to be the
same on both sides. It's a fuzzy line,
On 09/11/18 14:33, Corey Minyard wrote:
> On 11/8/18 5:22 PM, David Gibson wrote:
> I'm not sure about migration. I suppose it could be migrated, but I
> would consider the BMC part of the hardware that needs to be the
> same on both sides. It's a fuzzy line, I suppose. The qemu UUID
> is
On 12/6/18 7:48 AM, Cornelia Huck wrote:
On Thu, 6 Dec 2018 13:32:39 +0100
Halil Pasic wrote:
On Thu, 6 Dec 2018 09:28:34 +0100
David Hildenbrand wrote:
On 05.12.18 18:25, Christian Borntraeger wrote:
On 05.12.2018 17:45, Cornelia Huck wrote:
On Wed, 5 Dec 2018 17:38:22 +0100
David
On 12/6/18 3:37 PM, Eric Blake wrote:
> On 12/6/18 1:25 PM, John Snow wrote:
>> Presently, we abort transactions in the same order they were processed
>> in.
>> Bitmap commands, though, attempt to restore backup data structures on
>> abort.
>> To that end, though, they need to be aborted in
On 12/6/18 1:25 PM, John Snow wrote:
Presently, we abort transactions in the same order they were processed in.
Bitmap commands, though, attempt to restore backup data structures on abort.
To that end, though, they need to be aborted in reverse chronological order.
Replace the QSIMPLEQ data
On 12/6/18 2:25 PM, John Snow wrote:
> Touch up a few last things and remove the x- prefix.
>
> Test on the way, thoughts?
>
> John Snow (3):
> blockdev: abort transactions in reverse order
> blockdev: n-ary bitmap merge
> block: remove 'x' prefix from experimental bitmap APIs
>
>
On 06.12.18 09:48, P J P wrote:
> While performing block transfer write in smb_ioport_writeb(),
> 'smb_index' is incremented and used to index smb_data[] array.
> Check 'smb_index' value to avoid OOB access.
>
> Reported-by: Michael Hanselmann
Considering that Li Qiang had already published his
On 05/12/18 23:31, Liam Merwick wrote:
> For certain applications it is desirable to rapidly boot a KVM virtual
> machine. In cases where legacy hardware and software support within the
> guest is not needed, QEMU should be able to boot directly into the
> uncompressed Linux kernel binary with
On 05/12/18 23:31, Liam Merwick wrote:
> -static inline uint32_t ldl_p(void *p)
> +inline uint32_t ldl_p(void *p)
> {
> uint32_t val;
> memcpy(, p, 4);
> diff --git a/main.c b/main.c
Can you make instead a header (memaccess.h?) with all of lduw_p, ldl_p,
stw_p, stl_p?
>
> +
>
Patchew URL: https://patchew.org/QEMU/20181206151304.8388-1-kw...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v3 0/4] vmdk: Implement blockdev-create
Message-id:
On 06/12/18 17:36, Thomas Huth wrote:
> Looks like it should work. Maybe you could use this patch here first:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg02199.html
>
> ... then you could likely get rid of global_qtest here completely, I think.
Note that most of the
On 06/12/18 17:15, Thomas Huth wrote:
>>
>> -for (j = 0; j < 256; j++) {
>> -uint32_t a = readl(s->memory.regions[i].guest_phys_addr + j*4);
>> +for (j = 0; j < 1024; j++) {
>> +uint32_t a = readb(s->memory.regions[i].guest_phys_addr + j);
> Can't you
On 06/12/18 17:26, Thomas Huth wrote:
> g_test_skip does not work with older versions of the gtester ... so this
> patch series depends on your gtester replacement patches first?
Yes, that's how I got into that other mess. :)
Paolo
On 04/12/18 11:56, Thomas Huth wrote:
> I think it would be best if we find a way to automate this process, e.g.
> when a new release is tagged, a script generates the docs and puts them
> somewhere on the web server, into the right new folder based on the name
> of the tag. However, I don't know
On 12/6/18 1:34 PM, Thomas Huth wrote:
On 2018-12-06 19:42, Eric Blake wrote:
On 12/6/18 10:49 AM, Thomas Huth wrote:
The test does not use any of the functions that require global_qtest,
so we can simply get rid of this global variable here.
Signed-off-by: Thomas Huth
---
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
sixth release candidate for the QEMU 3.1 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-3.1.0-rc5.tar.xz
On 2018-12-06 19:42, Eric Blake wrote:
> On 12/6/18 10:49 AM, Thomas Huth wrote:
>> The test does not use any of the functions that require global_qtest,
>> so we can simply get rid of this global variable here.
>>
>> Signed-off-by: Thomas Huth
>> ---
>> tests/boot-serial-test.c | 13
The 'x' prefix was added because we were uncertain of the direction we'd
take for the libvirt API. With the general approach solidified, I feel
comfortable committing to this API for 4.0.
Signed-off-by: John Snow
---
blockdev.c | 22 +++---
qapi/block-core.json |
Especially outside of transactions, it is helpful to provide
all-or-nothing semantics for bitmap merges. This facilitates
the coalescing of multiple bitmaps into a single target for
the "checkpoint" interpretation when assembling bitmaps that
represent arbitrary points in time from component
Presently, we abort transactions in the same order they were processed in.
Bitmap commands, though, attempt to restore backup data structures on abort.
To that end, though, they need to be aborted in reverse chronological order.
Replace the QSIMPLEQ data structure with a QTAILQ one, so we can
On Thu, 6 Dec 2018 17:12:40 -0200
Eduardo Habkost wrote:
> On Tue, Dec 04, 2018 at 09:27:16AM -0700, Alex Williamson wrote:
> > Including all machine types that might have a pcie-root-port.
> >
> > Cc: Peter Maydell
> > Cc: Michael S. Tsirkin
> > Cc: Marcel Apfelbaum
> > Cc: Paolo Bonzini
>
On Tue, Dec 04, 2018 at 09:27:16AM -0700, Alex Williamson wrote:
> Including all machine types that might have a pcie-root-port.
>
> Cc: Peter Maydell
> Cc: Michael S. Tsirkin
> Cc: Marcel Apfelbaum
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Acked-by: David Gibson
Touch up a few last things and remove the x- prefix.
Test on the way, thoughts?
John Snow (3):
blockdev: abort transactions in reverse order
blockdev: n-ary bitmap merge
block: remove 'x' prefix from experimental bitmap APIs
blockdev.c | 96
The patches are neat. Most of my review comments are minor. Looking
forward to v7. Thanks!
Marc-André Lureau writes:
> Add #if defined(CONFIG_REPLICATION) in generated code, and adjust the
> code accordingly.
>
> Made conditional:
>
> * xen-set-replication, query-xen-replication-status,
> xen-colo-do-checkpoint
>
> Before the patch, we first register the commands unconditionally
Marc-André Lureau writes:
> Now that member can be made conditional, let's make SPICE chardev
> conditional:
>
> * spiceport, spicevmc
>
> Before and after the patch for !CONFIG_SPICE, the error is the
> same ('spiceport' is not a valid char driver name).
>
> Signed-off-by: Marc-André Lureau
On 12/6/18 10:49 AM, Thomas Huth wrote:
global_qtest is not really required here, since boot_sector_test()
is already independent from that global variable.
Inconsistency in the use of 'independent of' and 'independent from'
across the series. I think both work grammatically (English is
Marc-André Lureau writes:
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi/doc.py | 5 -
> tests/qapi-schema/doc-good.json | 4 +++-
> tests/qapi-schema/doc-good.out | 1 +
> tests/qapi-schema/doc-good.texi | 2 ++
> 4 files changed, 10 insertions(+), 2 deletions(-)
>
>
On 12/6/18 10:49 AM, Thomas Huth wrote:
global_qtest is only needed here for one readl(). Let's replace it
with qtest_readl() and we can remove the global_qtest variable here.
Signed-off-by: Thomas Huth
---
tests/prom-env-test.c | 17 -
1 file changed, 8 insertions(+), 9
Marc-André Lureau writes:
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi/doc.py | 4 +++-
> tests/qapi-schema/doc-good.json | 3 ++-
> tests/qapi-schema/doc-good.out | 1 +
> tests/qapi-schema/doc-good.texi | 2 ++
> 4 files changed, 8 insertions(+), 2 deletions(-)
>
>
On Wed, 5 Dec 2018 13:54:02 +0100
Cornelia Huck wrote:
> On Tue, 4 Dec 2018 16:02:36 +0100
> Halil Pasic wrote:
>
> > On Tue, 4 Dec 2018 14:11:30 +0100
> > Cornelia Huck wrote:
> >
> > > On Tue, 4 Dec 2018 13:38:10 +0100
> > > Halil Pasic wrote:
> > >
> > > > On Thu, 22 Nov 2018 17:54:29
On 12/6/18 10:49 AM, Thomas Huth wrote:
Apart from using qmp() in one spot, this test does not have any
dependencies to the global_qtest variable, so we can simply get
rid of it here by replacing the qmp() with qtest_qmp().
Signed-off-by: Thomas Huth
---
tests/machine-none-test.c | 7 ---
On 12/6/18 10:49 AM, Thomas Huth wrote:
Apart from using qmp() in the qmp_discard_response() macro, these
tests do not have any dependencies to the global_qtest variable,
so we can simply get rid of it here by replacing the qmp() with
qtest_qmp() in the macro.
Signed-off-by: Thomas Huth
---
On 12/6/18 10:49 AM, Thomas Huth wrote:
The test does not use any of the functions that require global_qtest,
so we can simply get rid of this global variable here.
Signed-off-by: Thomas Huth
---
tests/boot-serial-test.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
On Thu, 6 Dec 2018 at 05:23, Daniel P. Berrangé wrote:
>
> I'd encourage you to loook at installing as many deps as possible to
> maximise the coverage. eg gnutls, nettle, spice, and anything else that
> is relevant
I've now added: bison curl cyrus-sasl fontconfig freetype2 gnutls
nettle png
Marc-André Lureau writes:
> Signed-off-by: Marc-André Lureau
> ---
> docs/devel/qapi-code-gen.txt | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
> index c2e11465f0..799aef7728 100644
> ---
On 12/06/2018 11:21 AM, Cornelia Huck wrote:
On Thu, 6 Dec 2018 10:26:12 -0500
Farhan Ali wrote:
On 12/06/2018 09:39 AM, Cornelia Huck wrote:
On Wed, 5 Dec 2018 13:34:11 -0500
Farhan Ali wrote:
On 12/05/2018 07:54 AM, Cornelia Huck wrote:
Yeah, that is perfectly clear, but it ain't
Since arm_hcr_el2_eff includes a check against
arm_is_secure_below_el3, we can often remove a
nearby check against secure state.
In some cases, sort the call to arm_hcr_el2_eff
to the end of a short-circuit logical sequence.
Signed-off-by: Richard Henderson
---
v3: Do not change
Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine
that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into
account, as documented for the plethora of bits in HCR_EL2.
Signed-off-by: Richard Henderson
v3: Fix set of bits affected by just TGE.
Reorder the bits to
Changes since v2:
* Rebased on target-arm.next, which now includes 7 of the 10 patches.
* Fixes based on patch review.
r~
Richard Henderson (3):
target/arm: Introduce arm_hcr_el2_eff
target/arm: Use arm_hcr_el2_eff more places
target/arm: Implement the ARMv8.1-LOR extension
Provide a trivial implementation with zero limited ordering regions,
which causes the LDLAR and STLLR instructions to devolve into the
LDAR and STLR instructions from the base ARMv8.0 instruction set.
Signed-off-by: Richard Henderson
---
v2: Mark LORID_EL1 read-only.
Add TLOR access checks.
On 12/6/18 6:07 PM, Eric Blake wrote:
> On 12/6/18 9:58 AM, Philippe Mathieu-Daudé wrote:
>
> "refresh": "yes"
I had to use "refresh": yes (value unquoted) to avoid:
>>>
>>> Do you mean "refresh":true? (bare yes is not valid JSON, but bare true
>>> is the correct way for a
Marc-André Lureau writes:
> Wrap generated enum/struct members and code with #if/#endif, using the
enum and struct members
> .ifcond members added in the previous patches.
>
> Some types generate both enum and struct members for example, so a
> step-by-step is unnecessarily complicated to deal
06.12.2018 13:54, Daniel P. Berrangé wrote:
> On Wed, Dec 05, 2018 at 05:47:00PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> The two thing that should be handled are cipher and ivgen. For ivgen
>> the solution is just mutex, as iv calculations should not be long in
>> comparison with
06.12.2018 13:36, Daniel P. Berrangé wrote:
> On Wed, Dec 05, 2018 at 05:46:57PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are
>> almost identical, let's reduce code duplication and simplify further
>> improvements.
>>
>>
On 12/6/18 6:09 AM, Peter Maydell wrote:
> On Mon, 3 Dec 2018 at 20:38, Richard Henderson
> wrote:
>>
>> Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine
>> that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into
>> account, as documented for the plethora of bits in HCR_EL2.
>>
Quoting Daniel P. Berrangé (2018-12-06 10:50:47)
> Copying Michael Roth as the only remaining non-Red Hat contributor
> we still need approval from
No objections from my end.
>
> On Wed, Nov 28, 2018 at 05:44:09PM +0100, Paolo Bonzini wrote:
> > On 28/11/18 16:35, Daniel P. Berrangé wrote:
> >
Let's report IO-coherent access is supported for translation
table walks, descriptor fetches and queues by setting the COHACC
override flag. Without that, we observe wrong command opcodes.
The DT description also advertises the dma coherency.
Fixes a703b4f6c1ee ("hw/arm/virt-acpi-build: Add
On 12/6/18 9:58 AM, Philippe Mathieu-Daudé wrote:
"refresh": "yes"
I had to use "refresh": yes (value unquoted) to avoid:
Do you mean "refresh":true? (bare yes is not valid JSON, but bare true
is the correct way for a JSON bool).
I first tried 'true' then was curious and tried
06.12.2018 18:16, Vladimir Sementsov-Ogievskiy wrote:
> 01.12.2018 1:03, Eric Blake wrote:
>> + * Returns: negative errno: failure talking to server
>> + * 0: server is oldstyle, client must still parse export size
>> + * 1: server is newstyle, but can only accept EXPORT_NAME
>>
Let's update the structs according to revision D of the IORT
specification and set the IORT node revision fields.
In IORT smmuv3 node: the new proximity field is not used as
the proximity domain valid flag is not set. The new DeviceId
mapping index is not used either as all the SMMU control
Changes:
- Save CPU cycles by computing the return value while scanning the
input iovec, rather than calling iov_size() at the end.
- Remove check for s->tx != NULL, because it cannot happen.
- Cache ring->tail in a local variable and use it to check for
space in the TX ring. The use
The first patch sets the COHACC override flag in the IORT SMMUv3 node.
This fixes a bug reported while decoding the command queue entries.
The second patch updates the RC and SMMUv3 node structures according to
revision D of the IORT spec and updates the revision fields.
Best Regards
Eric
Improvements to the netmap backend, mostly to fix the handling of
incomplete multi-slot packets.
This has been tested with and without jumbo frames, using pkt-gen
to send 60, 1500, 5000 or 9000 bytes packets between two VMs connected
through a VALE switch.
Vincenzo Maffione (3):
net: netmap:
This change improves the handling of incomplete multi-slot packets
(e.g. with the NS_MOREFRAG set), by advancing ring->head only on
complete packets. The ring->cur pointer is advanced in any case in
order to acknowledge the kernel and move the wake-up point (thus
avoiding repeated wake-ups).
Also
06.12.2018 19:31, Eric Blake wrote:
> On 12/6/18 8:18 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 01.12.2018 1:03, Eric Blake wrote:
>>> Add some parameters to make this function reusable in upcoming
>>> export listing, where we will want to capture the name and
>>> description rather than compare
Improve code reuse by implementing netmap_receive() with a call
to netmap_receive_iov().
Signed-off-by: Vincenzo Maffione
---
net/netmap.c | 50 +++---
1 file changed, 11 insertions(+), 39 deletions(-)
diff --git a/net/netmap.c b/net/netmap.c
index
1 - 100 of 323 matches
Mail list logo
