There is no reason for CONFIG_VHOST_NET to be specific to a single target;
it is a host feature that can be add to all targets, as long as they support
the virtio-net device. Currently CONFIG_VHOST_NET depends on CONFIG_KVM,
but ioeventfd support is present in the core memory API and works with
On Tue, Dec 11, 2018 at 7:35 PM Maran Wilson wrote:
>
> On 12/11/2018 9:11 AM, Stefano Garzarella wrote:
> > Hi Liam,
> > in order to support PVH also with SeaBIOS, I'm going to work on a new
> > option rom (like linuxboot/multiboot) that can be used in this case.
>
> That is awesome. Yes, please
vhost-user already has a way to communicate the endianness of the guest
via the vring endianness messages. The vring endianness always matches
the vnet header endianness so there is no need to do anything else in
the backend.
Reviewed-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
vhost-user does not depend on Linux; it can run on any POSIX system. Restrict
vhost-kernel to Linux in hw/virtio/vhost-backend.c, everything else can be
compiled on all POSIX systems.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id:
The new definition of QTAILQ does not require passing the headname,
remove it.
Signed-off-by: Paolo Bonzini
---
cpus-common.c | 2 +-
dump.c | 2 +-
hw/core/qdev.c | 4 ++--
hw/scsi/scsi-bus.c | 2 +-
This makes the tests more independent, and also the source and destination
TestServers in the migration test.
Reviewed-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
Message-Id: <1543851204-41186-15-git-send-email-pbonz...@redhat.com>
---
tests/vhost-user-test.c | 75
This speeds up wait_for_rings_started, which currently is just waiting for
the timeout before checking s->rings.
Reviewed-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
Message-Id: <1543851204-41186-8-git-send-email-pbonz...@redhat.com>
---
tests/vhost-user-test.c | 2 ++
1 file changed, 2
From: Thomas Huth
Since we have got a check for Clang >= 3.4 now, we do not need to
check for older Clang versions in the configure test for 128-bit ints
anymore.
Signed-off-by: Thomas Huth
Reviewed-by: Richard Henderson
Message-Id: <1543937577-28256-3-git-send-email-th...@redhat.com>
---
g_cond_signal is rarely the right thing to do, it works now because
vhost-user-test only has two threads but it is not correct in general.
Fix it before adding more calls.
Reviewed-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
Message-Id:
From: Peng Hao
The registered memory region of i6300esb is not suitable for coalesced
mmio, because a write for the region may trigger an immediate action
and can't be delayed.
Signed-off-by: Peng Hao
Message-Id: <1544253511-82742-1-git-send-email-peng.h...@zte.com.cn>
Signed-off-by: Paolo
The virt machine cannot run the vhost-user qtests because they hardcode
the presence of memory at address 0. Report the tests as a skip so that
they can be converted to use qgraph.
Reviewed-by: Marc-André Lureau
Signed-off-by: Paolo Bonzini
Message-Id:
From: Thomas Huth
Both GCC v4.8 and Clang v3.4 support the -Waddress option, so we do
not need the compiler version check here anymore.
Signed-off-by: Thomas Huth
Reviewed-by: Richard Henderson
Message-Id: <1543937577-28256-6-git-send-email-th...@redhat.com>
---
audio/alsaaudio.c | 2 --
1
From: Thomas Huth
Both GCC v4.8 and Clang v3.4 support (our minimum versions) support
__builtin_unreachable(), so we can remove the version check here now.
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
Message-Id: <1543937577-28256-5-git-send-email-th...@redhat.com>
---
tcg/tcg.h
From: Thomas Huth
The code that used it has already been removed a while ago with commit
dc41aa7d34989b552ef ("tcg: Remove GET_TCGV_* and MAKE_TCGV_*").
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
Message-Id: <1543937577-28256-8-git-send-email-th...@redhat.com>
---
Most list head structs need not be given a name. In most cases the
name is given just in case one is going to use QTAILQ_LAST, QTAILQ_PREV
or reverse iteration, but this does not apply to lists of other kinds,
and even for QTAILQ in practice this is only rarely needed. In addition,
we will soon
gtester is deprecated by upstream glib (see for example the announcement
at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does
not support tests that call g_test_skip in some glib stable releases.
glib suggests instead using Automake's TAP support, which gtest itself
supports since
From: Marc-André Lureau
osdep.h will also define the available Windows API version for QEMU.
Signed-off-by: Marc-André Lureau
Message-Id: <20181122110039.15972-2-marcandre.lur...@redhat.com>
Signed-off-by: Paolo Bonzini
---
accel/tcg/translate-all.c | 4
1 file changed, 4 deletions(-)
From: Thomas Huth
Since we require GCC version 4.8 or newer now, we can be sure that
the builtin functions are always available on GCC. And for Clang,
we can check the availablility with __has_builtin instead.
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
Message-Id:
From: Thomas Huth
So far we only had implicit requirements for the minimum compiler version,
e.g. we require at least GCC 4.1 for the support of atomics. However,
such old compiler versions are not tested anymore by the developers, so
they are not really supported anymore. Since we recently
QTAILQ is a doubly linked list, with a pointer-to-pointer to the last
element from the head, and the previous element from each node.
But if you squint enough, QTAILQ becomes a combination of a singly-linked
forwards list, and another singly-linked list which goes backwards and
is circular. This
Sometimes a test's main() function recognizes that the environment
does not support the test, and therefore exits. In this case, we
still should run g_test_run() so that a TAP harness will print the
test plan ("1..0") and the test will be marked as skipped.
Signed-off-by: Paolo Bonzini
These are just like any other struct or union, so they should have
CamelCase typedefs.
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8d6e44..b4b3495 100755
---
From: Thomas Huth
Now that we require at least GCC 4.8, we don't need this als workaround
for 4.6 and 4.7 anymore.
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
Message-Id: <1543937577-28256-4-git-send-email-th...@redhat.com>
---
Makefile.target | 3 ---
configure | 16
These are not present for other kinds of queue, and unused.
Zap them before more changes are made to the QTAILQ
implementation.
Signed-off-by: Paolo Bonzini
---
include/qemu/queue.h | 14 ++
scripts/cocci-macro-file.h | 10 --
2 files changed, 6 insertions(+), 18
From: Marc-André Lureau
This removes some clutter in compilation logging, and allows some
easier tweaking per compilation unit/CFLAGS overriding.
Note that we can't move those define in os-win32.h, since they must be
set before the first system headers are included.
Signed-off-by: Marc-André
This will be needed when we change the QTAILQ head and elem structs
to unions. However, it is also consistent with the usage elsewhere
in QEMU for other list head structs (see for example FsMountList).
Note that most QTAILQs only need their name in order to do backwards
walks. Those do not
From: Stefan Hajnoczi
The IscsiAIOCB->buf field has not been used since commit
e49ab19fcaa617ad6cdfe1ac401327326b6a2552 ("block/iscsi: bump libiscsi
requirement to 1.9.0"). It used to be a linear buffer for old libiscsi
versions that didn't support scatter-gather. The minimum libiscsi
version
It is not used outside hw/vfio/common.c, so it does not need to
be extern.
Acked-by: Alex Williamson
Signed-off-by: Paolo Bonzini
---
hw/vfio/common.c | 2 +-
include/hw/vfio/vfio-common.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/vfio/common.c
From: Guenter Roeck
Per AM53C974 datasheet, definition of "SCSI Bus and Control (SBAC)"
register:
Bit 24 'STATUS' Write Erase Control
This bit controls the Write Erase feature on bits 3:1 and bit 6 of the DMA
Status Register ((B)+54h). When this bit is programmed to '1', the state
of bits 3:1
The e1000 driver calls memory_region_add_coalescing but
kvm_coalesce_mmio_region is never called for those regions. The bug
dates back to the introduction of the memory region API; to fix it,
delete and re-add coalesced MMIO ranges when building the FlatViews.
Because coalesced MMIO regions
Use the QTAILQ_IN_USE macro instead, it does the same thing but the next
patch will change it to a different definition.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Signed-off-by: Paolo Bonzini
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Thomas Huth
The questions about our minimum compiler requirement pops up every
couple of months, and we then have to recall the details each time.
So let's document this in a proper way, by adding a comment and
check for the right compiler version to our compiler.h header.
Signed-off-by:
From: Guenter Roeck
The guest OS reads RSTAT, RSEQ, and RINTR, and expects those registers
to reflect a consistent state. However, it is possible that the registers
can change after RSTAT was read, but before RINTR is read, when
esp_command_complete() is called.
Guest OSqemu
From: Marc-André Lureau
Building QGA for XP seems possible so far: the dependency on
libqemuutil.a implies building qemu-thread-win32.c, which requires
Vista API since commit 12f8def0 (v2.9). But qemu-thread isn't being
used in QGA, the resulting binary may still work on XP. XP is no
longer
In some cases, checkpatch's process subroutine is exiting the
whole process. This is wrong, just return from the subroutine
instead.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Add optional colors to make seeing message types a bit easier.
The default is to show them on a tty.
Inspired by Linux commits 57230297116fa ("checkpatch: colorize output
to terminal") and 737c0767758b ("checkpatch: change format of --color
argument to --color[=WHEN]").
Signed-off-by: Paolo
From: Marc-André Lureau
osdep.h should be included first:
CC tests/vhost-user-bridge.o
In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
/home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name
‘int64_t’
int64_t atomic_read_i64(const
From: Stefan Hajnoczi
Commit d045c466d9e62b4321fadf586d024d54ddfd8bd4 ("iscsi: do not use
aio_context_acquire/release") introduced iscsilun->mutex but appears to
have overlooked iscsi_timed_check_events() when introducing the mutex.
iscsi_service() and iscsi_set_events() must be called with
Extract two new functions from memory_region_update_coalesced_range_as.
To avoid duplication in the creation of the MemoryRegionSection, use
MEMORY_LISTENER_UPDATE_REGION instead of MEMORY_LISTENER_CALL
to invoke the listener callback.
Signed-off-by: Paolo Bonzini
---
memory.c | 53
From: Stefan Hajnoczi
The libiscsi iscsi_task_mgmt_async() API documentation says:
abort_task will also cancel the scsi task. The callback for the scsi
task will be invoked with SCSI_STATUS_CANCELLED
The libiscsi implementation does not fulfil this promise. The task's
callback is not
From: Marc-André Lureau
Both qemu & qga build with Vista API by default already, by defining
_WIN32_WINNT 0x0600. Set it globally in osdep.h instead.
This replaces WINVER by _WIN32_WINNT in osdep.h. WINVER doesn't seem
to be really useful these days.
(see also
Similar to how patchew output looks like for multiple patches,
say what file or patch is being tested _before_ emitting errors.
This is clearer to a human that scans the output from top to
bottom.
In addition, provide a truncated commit hash and subject instead of
the full hash, and process the
From: Alexandro Sanchez Bach
Intel HAXM supports now 32-bit and 64-bit Linux hosts. This patch includes
the corresponding userland changes.
Since the Darwin userland backend is POSIX-compliant, the hax-darwin.{c,h}
files have been renamed to hax-posix.{c,h}. This prefix is consistent with
the
From: Stefan Hajnoczi
iscsi_aio_cancel() does not increment the request's reference count,
causing a use-after-free when ABORT TASK finishes after the request has
already completed.
There are some additional issues with iscsi_aio_cancel():
1. Several ABORT TASKs may be sent for the same task if
This avoids a few re-rendering of the memory AddressSpace.
Signed-off-by: Paolo Bonzini
---
hw/pci-host/pam.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci-host/pam.c b/hw/pci-host/pam.c
index e361ecb..aa5ecfd 100644
--- a/hw/pci-host/pam.c
+++ b/hw/pci-host/pam.c
@@ -52,11
From: Thomas Huth
When compiling with "--disable-tcg", we currently still use "tcg"
as default accelerator. "kvm" should be used in this case instead.
Also, some downstream distros provide QEMU binaries which have "kvm"
in their names (e.g. "qemu-kvm" on RHEL or "kvm" on Ubuntu) that use
KVM by
Store whether the FlatRange has had any coalesced I/O ranges applied,
and if not avoid calling coalesced_io_del. This is useful in preparation
for the next patch, which will call coalesced_io_del when rendering
memory regions.
Signed-off-by: Paolo Bonzini
---
memory.c | 11 +++
1 file
Pull the test before the anticipated exits from the process sub.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index
The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
Merge remote-tracking branch
'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11
19:18:58 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
On 12/12/18 9:11 AM, Jason J. Herne wrote:
...
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index 9246729..6f480c6 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -20,23 +20,12 @@
#include "hw/sysbus.h"
#include "hw/vfio/vfio.h"
#include "hw/vfio/vfio-common.h"
+#include "hw/vfio/ccw.h"
Hi Paolo,
On 12/3/18 4:32 PM, Paolo Bonzini wrote:
> Patches 1-14 are actually a refactoring of vhost and vhost-user-test so
> that it can be "qtested" on all targets that support virtio-net.
>
> Patches 15-18 are other small refactorings to the libqos library and fixes
> to the Makefile.
>
>
On Wed, Dec 12, 2018 at 04:11:44PM +0800, Zhang Yi wrote:
> Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to
> guarantee the write persistence to mmap'ed files supporting DAX (e.g.,
> files on ext4/xfs file system mounted with '-o dax').
>
> A description of MAP_SYNC and
On 12/12/18 8:41 AM, Cornelia Huck wrote:
> On Wed, 12 Dec 2018 12:20:08 +0100
> David Hildenbrand wrote:
>
>> On 11.12.18 22:12, Collin Walling wrote:
>>> On 12/11/18 11:47 AM, Collin Walling wrote:
On 12/7/18 7:08 AM, Cornelia Huck wrote:
> On Thu, 6 Dec 2018 17:24:17 -0500
>
On Wed, Dec 12, 2018 at 01:58:25PM +, Daniel P. Berrangé wrote:
> On Wed, Dec 12, 2018 at 01:52:03PM +, Dr. David Alan Gilbert wrote:
> IMHO we need something whose support status is on a par with what you'd
> get if we had the impl in-process for the main QEMU system emulator.
I agree.
On 12/12/18 9:34 AM, Cornelia Huck wrote:
On Wed, 12 Dec 2018 09:11:03 -0500
"Jason J. Herne" wrote:
Hm, I think you need to adjust your cc: list. I added some more folks
(and removed Dong Jia, whose address is no longer valid AFAIK).
Correct. I forgot to update my list before I sent.
On 12/3/18 4:32 PM, Paolo Bonzini wrote:
> From: Emanuele Giuseppe Esposito
>
> Add qgraph nodes for sdhci-pci and generic-sdhci (memory mapped) drivers.
> Both drivers implement (produce) the same interface sdhci, that provides the
> readw - readq - writeq functions.
>
> Signed-off-by:
On Wed, 12 Dec 2018 09:11:03 -0500
"Jason J. Herne" wrote:
Hm, I think you need to adjust your cc: list. I added some more folks
(and removed Dong Jia, whose address is no longer valid AFAIK).
> This is to support booting from vfio-ccw dasd devices. We basically implement
> the real hardware
On Wed, Dec 12, 2018 at 12:08:08PM -0200, Wainer dos Santos Moschetta wrote:
>
> On 12/11/2018 05:25 PM, Eduardo Habkost wrote:
> > Some downstream distributions of QEMU set host-phys-bits=on by
> > default. This worked very well for most use cases, because
> > phys-bits really didn't have huge
On 12/3/18 4:32 PM, Paolo Bonzini wrote:
> From: Emanuele Giuseppe Esposito
>
> Convert tests/sdhci-test in first qgraph test node, sdhci-test. This test
> consumes an sdhci interface and checks that its function return the
> expected values.
>
> Note that this test does not allocate any sdhci
On 12/3/18 4:32 PM, Paolo Bonzini wrote:
> This test was merged into drive_del-test in 2014.
in e2f3f221885.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Philippe Mathieu-Daudé
> ---
> tests/Makefile.include | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/Makefile.include
Allows guest to boot from a vfio configured real dasd device.
Signed-off-by: Jason J. Herne
---
docs/devel/s390-dasd-ipl.txt | 132 +++
pc-bios/s390-ccw/Makefile| 2 +-
pc-bios/s390-ccw/dasd-ipl.c | 249 +++
The dasd IPL procedure needs to execute a few previously unused
channel commands. Let's define them and their associated data
structures.
Signed-off-by: Jason J. Herne
---
pc-bios/s390-ccw/cio.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/pc-bios/s390-ccw/cio.h
Introduce inline functions to convert between pointers and unsigned 32-bit
ints. These are used to hide the ugliness required to avoid compiler
warnings.
Signed-off-by: Jason J. Herne
---
pc-bios/s390-ccw/libc.h | 12
1 file changed, 12 insertions(+)
diff --git
Add verbose error output for when unexpected i/o errors happen. This eases the
burden of debugging and reporting i/o errors. No error information is printed
in the success case, here is an example of what is output on error:
vfio-ccw device I/O error - Interrupt Response Block Data:
Function
The boot method is different depending on which device type we are
booting from. Let's examine the control unit type to determine if we're
a virtio device. We'll eventually add a case to check for a real dasd device
here as well.
Signed-off-by: Jason J. Herne
---
pc-bios/s390-ccw/main.c | 15
On Wed, Dec 12, 2018 at 05:08:39PM +0800, Yu Zhang wrote:
> On Tue, Dec 11, 2018 at 05:25:27PM -0200, Eduardo Habkost wrote:
> > Some downstream distributions of QEMU set host-phys-bits=on by
> > default. This worked very well for most use cases, because
> > phys-bits really didn't have huge
Add proper typedefs to all structs and modify all bit fields to use consistent
formatting.
Signed-off-by: Jason J. Herne
Reviewed-by: Collin Walling
---
pc-bios/s390-ccw/cio.h | 86 ++---
pc-bios/s390-ccw/s390-ccw.h | 8 -
2 files changed, 43
We need a method for finding the subchannel of a dasd device. Let's
modify find_dev to handle this since it mostly does what we need. Up to
this point find_dev has been specific to only virtio devices.
Signed-off-by: Jason J. Herne
Acked-by: Halil Pasic
---
pc-bios/s390-ccw/main.c | 16
Add struct for format-0 ccws. Support executing format-0 channel
programs and waiting for their completion before continuing execution.
This will be used for real dasd ipl.
Add cu_type() to channel io library. This will be used to query control
unit type which is used to determine if we are
This is to support booting from vfio-ccw dasd devices. We basically implement
the real hardware ipl procedure. This allows for booting Linux guests on
vfio-ccw devices.
vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl
channel programs dynamically modify themselves.
Create a separate library for channel i/o related code. This decouples
channel i/o operations from virtio and allows us to make use of them for
the real dasd boot path.
Signed-off-by: Jason J. Herne
---
pc-bios/s390-ccw/Makefile| 2 +-
pc-bios/s390-ccw/cio.c | 41
Now that we have a Channel I/O library let's modify virtio boot code to
make use of it for running channel programs.
Signed-off-by: Jason J. Herne
---
pc-bios/s390-ccw/virtio.c | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/pc-bios/s390-ccw/virtio.c
Create a new header for basic architecture specific definitions and add a
mapping of low core memory. This mapping will be used by the real dasd boot
process.
Signed-off-by: Jason J. Herne
---
pc-bios/s390-ccw/main.c | 2 +
pc-bios/s390-ccw/s390-arch.h | 100
Add bootindex property and iplb data for vfio-ccw devices. This allows us to
forward boot information into the bios for vfio-ccw devices.
Signed-off-by: Jason J. Herne
Acked-by: Halil Pasic
---
hw/s390x/ipl.c | 15 +++
hw/s390x/s390-ccw.c | 9 +
Make a new routine find_boot_device to locate the boot device for all
cases. not just virtio.
In one case no boot device is specified and a suitable boot device can not
be auto detected. The error message for this case was specific to virtio
devices. We update this message to remove virtio
Move channel i/o setup code out to a separate function. This decouples cio
setup from the virtio code path and allows us to make use of it for booting
dasd devices.
Signed-off-by: Jason J. Herne
Acked-by: Halil Pasic
Reviewed-by: Collin Walling
---
pc-bios/s390-ccw/main.c | 20
Create a boot_setup function to handle getting boot information from
the machine/hypervisor. This decouples common boot logic from the
virtio code path and allows us to make use of it for the real dasd boot
scenario.
Signed-off-by: Jason J. Herne
Acked-by: Halil Pasic
Reviewed-by: Collin
On Wed, Dec 12, 2018 at 01:52:03PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > On Mon, Dec 10, 2018 at 05:31:44PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Hi,
> > > This is the first RFC
From: Alberto Garcia
The 'block-commit' QMP command is implemented internally using two
different drivers. If the source image is the active layer then the
mirror driver is used (commit_active_start()), otherwise the commit
driver is used (commit_start()).
In both cases the destination image
On 12/11/2018 05:25 PM, Eduardo Habkost wrote:
Some downstream distributions of QEMU set host-phys-bits=on by
default. This worked very well for most use cases, because
phys-bits really didn't have huge consequences. The only
difference was on the CPUID data seen by guests, and on the
From: Alberto Garcia
This patch replaces the bdrv_reopen() call that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
blockdev.c | 3 +--
1 file changed, 1 insertion(+),
From: Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/stream.c | 20 ++--
1 file
From: Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/commit.c | 7 +++
1 file changed, 3
From: Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
blockdev.c | 8 ++--
1 file changed, 2
On Wed, Dec 12, 2018 at 08:54:37AM +, Mark Cave-Ayland wrote:
> On 12/12/2018 08:32, Gerd Hoffmann wrote:
>
> > On Fri, Dec 07, 2018 at 04:08:05PM +, Mark Cave-Ayland wrote:
> >> This is in preparation for some upcoming QEMU NDRV driver changes that pass
> >> display information from the
From: Alberto Garcia
Most callers of bdrv_reopen() only use it to switch a BlockDriverState
between read-only and read-write, so this patch adds a new function
that does just that.
We also want to get rid of the flags parameter in the bdrv_reopen()
API, so this function sets the "read-only"
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Dec 10, 2018 at 05:31:44PM +, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Hi,
> > This is the first RFC for the QEMU side of 'virtio-fs';
> > a new mechanism for mounting host directories into
aio_worker() doesn't add anything interesting, it's only a useless
indirection. Call the handler function directly instead.
As we know that this handler function is only called from coroutine
context and the coroutine stays around until the worker thread finishes,
we can keep RawPosixAIOData on
On Wed, 12 Dec 2018 12:20:08 +0100
David Hildenbrand wrote:
> On 11.12.18 22:12, Collin Walling wrote:
> > On 12/11/18 11:47 AM, Collin Walling wrote:
> >> On 12/7/18 7:08 AM, Cornelia Huck wrote:
> >>> On Thu, 6 Dec 2018 17:24:17 -0500
> >>> Collin Walling wrote:
> >>>
> Diagnose
From: Alberto Garcia
Towards the end of bdrv_reopen_queue_child(), before starting to
process the children, the update_flags_from_options() function is
called in order to have BDRVReopenState.flags in sync with the options
from the QDict.
This is necessary because during the reopen process
The function is not used any more, remove it.
Signed-off-by: Kevin Wolf
---
block/file-posix.c | 34 --
1 file changed, 34 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 0f64c83639..c8a085a911 100644
--- a/block/file-posix.c
+++
From: Alberto Garcia
Now that all callers are passing all flag changes as QDict options,
the flags parameter is no longer necessary, so we can get rid of it.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
include/block/block.h | 3 +--
block.c
From: Christian Borntraeger
"-machine pc" will not work all architectures. Lets fall back to the
default machine by not specifying it.
In addition we also need to specify -no-shutdown on s390 as qemu will
exit otherwise.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Christian Borntraeger
aio_worker() doesn't add anything interesting, it's only a useless
indirection. Call the handler function directly instead.
As we know that this handler function is only called from coroutine
context and the coroutine stays around until the worker thread finishes,
we can keep RawPosixAIOData on
From: Alberto Garcia
This function takes four options (cache.direct, cache.no-flush,
read-only and auto-read-only) from a QemuOpts object and updates the
flags accordingly.
If any of those options is not set (because it was missing from the
original QDict or because it had an invalid value)
From: Alberto Garcia
This function is used to put the hidden and secondary disks in
read-write mode before launching the backup job, and back in read-only
mode afterwards.
This patch does the following changes:
- Use an options QDict with the "read-only" option instead of
passing the
aio_worker() doesn't add anything interesting, it's only a useless
indirection. Call the handler function directly instead.
As we know that this handler function is only called from coroutine
context and the coroutine stays around until the worker thread finishes,
we can keep RawPosixAIOData on
No real reason to keep using the callback based mechanism here when the
rest of the file-posix driver is coroutine based. Changing it brings
ioctls more in line with how other request types work.
Signed-off-by: Kevin Wolf
---
include/scsi/pr-manager.h | 8 +++-
block/file-posix.c|
From: Alberto Garcia
This patch replaces the bdrv_reopen() calls that set and remove the
BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block.c | 10 +-
1 file changed, 5
From: Alberto Garcia
When reopen_f() puts a block device in the reopen queue, some of the
new options are passed using a QDict, but others ("read-only" and the
cache options) are passed as flags.
This patch puts those flags in the QDict. This way the flags parameter
becomes redundant and we'll
301 - 400 of 564 matches
Mail list logo
