> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Friday, December 14, 2018 8:53 PM
> To: Gonglei (Arei)
> Cc: Juan Quintela ; qemu-devel@nongnu.org; Thomas
> Huth ; Gerd Hoffmann
> Subject: Re: [PATCH v3 00/16] Virtio devices split from virtio-pci
>
> On
On Thu, Dec 13, 2018 at 00:03:47 -0500, Emilio G. Cota wrote:
(snip)
> diff --git a/qom/cpu.c b/qom/cpu.c
> index aa15ea4af5..2ea5b1da08 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -371,7 +371,6 @@ static void cpu_common_initfn(Object *obj)
> cpu->nr_cores = 1;
> cpu->nr_threads = 1;
Currently, the vhost-user-test is not correct.
When in qtest mode, the accel is qtest, not kvm.
So when the client side of vhost-user-test send
'VHOST_USER_SET_VRING_CALL' msg, the 'fd' will
no be added in 'fds' in 'vhost_set_vring_file'.
In 'chr_read' of the server side in the
vhost-user-test,
Currentyly when processing VHOST_USER_SET_VRING_CALL
if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will
be a stack uninitialized value.
Signed-off-by: Li Qiang
---
tests/vhost-user-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vhost-user-test.c
Assert that the return value is not an error. This is like commit
7e6478e7d4f for qemu_set_cloexec.
Signed-off-by: Li Qiang
---
util/oslib-posix.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index c1bee2a581..4ce1ba9ca4
Currently, the vhost-user-test assumes the eventfd is available.
However it's not true because the accel is qtest. So the
'vhost_set_vring_file' will not add fds to the msg and the server
side of vhost-user-test will be broken. This patch avoid this.
Signed-off-by: Li Qiang
---
To mimic the common filter of the same name, but for the python tests.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py
New interface, new smoke test.
---
tests/qemu-iotests/236 | 124 +++
tests/qemu-iotests/236.out | 200 +
tests/qemu-iotests/group | 1 +
3 files changed, 325 insertions(+)
create mode 100755 tests/qemu-iotests/236
create mode
If iotests have lines exceeding >998 characters long, git doesn't
want to send it plaintext to the list. We can solve this by allowing
the iotests to use pretty printed QMP output that we can match against
instead.
As a bonus, it's much nicer for human eyes, too.
Note that this changes the sort
Instead of using os.environ[], use .get with a default of empty string
to match the setup in check to allow us to import the iotests module
(for debugging, say) without needing a crafted environment just to
import the module.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by:
The 'x' prefix was added because I was uncertain of the direction we'd
take for the libvirt API. With the general approach solidified, I feel
comfortable committing to this API for 4.0.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c
Presently, we abort transactions in the same order they were processed in.
Bitmap commands, though, attempt to restore backup data structures on abort.
To that end, though, they need to be aborted in reverse chronological order.
Replace the QSIMPLEQ data structure with a QTAILQ one, so we can
Especially outside of transactions, it is helpful to provide
all-or-nothing semantics for bitmap merges. This facilitates
the coalescing of multiple bitmaps into a single target for
the "checkpoint" interpretation when assembling bitmaps that
represent arbitrary points in time from component
Touch up a few last things and remove the x- prefix.
V3:
- Reworked qmp_log to pretty-print the outgoing command, too [Vladimir]
- Modified test to log only bitmap information [Vladimir]
- Test disable/enable transaction toggle [Eric]
Note that the filter I added is now unused, but I think we
On Fri, Dec 14, 2018 at 10:33:54AM +0800, Yongji Xie wrote:
> On Fri, 14 Dec 2018 at 10:20, Michael S. Tsirkin wrote:
> >
> > On Fri, Dec 14, 2018 at 09:56:41AM +0800, Yongji Xie wrote:
> > > On Thu, 13 Dec 2018 at 22:45, Michael S. Tsirkin wrote:
> > > >
> > > > On Thu, Dec 06, 2018 at
On Wed, Dec 05, 2018 at 05:41:26PM +0800, Huan Xiong wrote:
> Since root and downstream port have only one slot, device should be
> connected to them using slot 0. QEMU doesn't have a check for that
> and starts up when a non-zero slot is specified, though the device
> is not seen in guest OS.
>
On Tue, Dec 11, 2018 at 04:24:46PM +0800, Wei Wang wrote:
> This is the deivce part implementation to add a new feature,
> VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device
> receives the guest free page hints from the driver and clears the
> corresponding bits in the dirty
Alex Bennée writes:
> This is a QEMU specific version of a gitdm config for generating
> reports on the contributor base of the project. I've added enough
> group maps and domain aliases to ensure the current top ten is as
> reflective as it can be. As of this commit running:
> +# Also group
This is a QEMU specific version of a gitdm config for generating
reports on the contributor base of the project. I've added enough
group maps and domain aliases to ensure the current top ten is as
reflective as it can be. As of this commit running:
git log --numstat --since "Last Year" | gitdm
On 12/13/18 8:09 AM, Vladimir Sementsov-Ogievskiy wrote:
> 13.12.2018 4:50, John Snow wrote:
>> If iotests have lines exceeding >998 characters long, git doesn't
>> want to send it plaintext to the list. We can solve this by allowing
>> the iotests to use pretty printed QMP output that we can
On 12/14/18 10:03 AM, Michael Spradling wrote:
Can you combine -s (create a writable temp file) with -l to get what you
want?
/me tries:
I can confirm that 'qemu-nbd -s a' lets me write data that is discarded on
disconnect (lsof says a temp file in /var/tmp/vl.XX was created); and
that
On Fri, Dec 07, 2018 at 09:53:06AM +0800, wangjian wrote:
> Memset vhost_dev to zero in the vhost_dev_cleanup function.
> This causes dev.vqs to be NULL, so that
> vqs does not free up space when calling the g_free function.
> This will result in a memory leak. But you can't release vqs
> directly
Use "register" TBFLAG_ANY to indicate shared state between
A32 and A64, and "registers" TBFLAG_A32 & TBFLAG_A64 for
fields that are specific to the given cpu state.
Move ARM_TBFLAG_BE to shared state, instead of its current
placement within "Bit usage when in AArch32 state".
Signed-off-by:
On 12/13/18 4:37 PM, Paolo Bonzini wrote:
Most files that have TABs only contain a handful of them. Change
them to spaces so that we don't confuse people.
disas, standard-headers, linux-headers and libdecnumber are imported
from other projects and probably should be exempted from the check.
On Fri, Dec 14, 2018 at 18:47:42 +, Aaron Lindsay wrote:
> On Dec 14 12:50, Emilio G. Cota wrote:
> > On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote:
> > > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote:
> > (snip)
> > > > I added a function to the user-facing plugin
From: Anup Patel
Currently, start and end address of a PMP region are not decoded
correctly by pmp_decode_napot().
Let's say we have a 128KB PMP region with base address as 0x8000.
Now, the PMPADDRx CSR value for this region will be 0x20003fff.
The current pmp_decode_napot() implementation
On Thu, 13 Dec 2018 at 09:03, Greg Kurz wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
> Merge remote-tracking branch
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11
> 19:18:58 +)
>
> are available in the Git
On Dec 14 12:50, Emilio G. Cota wrote:
> On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote:
> > On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote:
> (snip)
> > > I added a function to the user-facing plugin API in my own version of
> > > Pavel's plugin patchset to clear all
On Fri, Dec 14, 2018 at 17:59:20 +, Aaron Lindsay wrote:
> On Dec 14 12:08, Emilio G. Cota wrote:
(snip)
> > The idea is that a plugin can "reset" itself, so that (1) all
> > its CBs are cleared and (2) the plugin can register new callbacks.
> > This would all happen in an atomic context (no
On 12/14/2018 04:15 PM, Paolo Bonzini wrote:
On 14/12/18 19:06, Wainer dos Santos Moschetta wrote:
IIUC above block handles the lines between lead and trail. So it would
fix (but it doesn't) this:
# cat foo
/*
comment 1
comment 2
*/
# scripts/fix-multiline-comments.sh foo
/*
comment
On 14/12/18 19:06, Wainer dos Santos Moschetta wrote:
>
> IIUC above block handles the lines between lead and trail. So it would
> fix (but it doesn't) this:
>
> # cat foo
> /*
> comment 1
> comment 2
> */
>
> # scripts/fix-multiline-comments.sh foo
> /*
> comment 1
> comment 2
> */
Not
Le ven. 14 déc. 2018 16:17, Alex Bennée a écrit :
> The pkg.mxe.cc package repositories have been down for the last two
> weeks causing the builds to fail when shippable re-builds the
> containers.
>
> This is really just a sticking plaster until we can get our own docker
> hub images properly
On 12/14/2018 07:48 AM, Paolo Bonzini wrote:
Since we're adding checkpatch rules to enforce 4-line multiline comment
format, i.e. with lone /* and */, this script can be run on existing
code so that the comment style does not become inconsistent within a
file.
The alternative to
Public bug reported:
Seeing this in qemu-user 3.1.0
The code in is_proc_myself which supports remapping of /proc/self/maps
and /proc//maps does not support remapping of
/proc/self/task//maps or /proc//task//maps. Extending
is_proc_myself to cover these cases causes the maps to be rewritten
On Dec 14 12:08, Emilio G. Cota wrote:
> On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote:
> > Emilio,
> >
> > First, thanks for putting this together - I think everyone doing this
> > sort of thing will benefit if we're able to agree on one upstream plugin
> > interface.
> >
> > One
On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote:
> On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote:
(snip)
> > I added a function to the user-facing plugin API in my own version of
> > Pavel's plugin patchset to clear all existing plugin instrumentation,
(snip)
> I think
On 12/14/18 5:03 PM, Peter Maydell wrote:
> On Thu, 13 Dec 2018 at 04:01, David Gibson
> wrote:
>>
>> The following changes since commit 4b3aab204204ca742836219b97b538d90584f4f2:
>>
>> Merge remote-tracking branch
>> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-11
As the following experiments show, this series is a net perf gain,
particularly for memory-heavy workloads. Experiments are run on an
Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz.
1. System boot + shudown, debian aarch64:
- Before (v3.1.0):
Performance counter stats for './die.sh v3.1.0' (10 runs):
Public bug reported:
Seeing this in qemu-user version 3.1.0
Demo:
$ QEMU_LD_PREFIX=$(pwd)/usr/armv7a-cros-linux-gnueabi ../run/qemu-arm
/tmp/coreutils --coreutils-prog=ls /
etc lib usr
$ ls /
boot etc lib lib64 lost+found mntroot sbin sys usr
bin dev export home
Disabled in all TCG backends for now.
Signed-off-by: Emilio G. Cota
---
include/exec/cpu-defs.h | 48 +-
include/exec/cpu_ldst.h | 21 +
tcg/aarch64/tcg-target.h | 1 +
tcg/arm/tcg-target.h | 1 +
tcg/i386/tcg-target.h| 1 +
tcg/mips/tcg-target.h| 1 +
Currently we evict an entry to the victim TLB when it doesn't match
the current address. But it could be that there's no match because
the current entry is empty (i.e. all -1's, for instance via tlb_flush).
Do not evict the entry to the vtlb in that case.
This change will help us keep track of
v4: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02679.html
Changes since v4:
- Rebase on v3.1.0. Quite a few conflicts, but the resulting diffs
are simpler than in v4.
- Re-run benchmarks on a different Skylake machine (this one is
a server with a lower clock frequency).
- Add
This patch adds new property "order_platform" which is required to
allow VIRTIO_F_ORDER_PLATFORM feature negotiation. Disabled by
default because needed only for HW assited vhost backends.
Enabling of this feature will request guest drivers to use heavier
(platform dependent) techniques for
On Thu, 13 Dec 2018 at 18:15, Paolo Bonzini wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
> Merge remote-tracking branch
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11
> 19:18:58 +)
>
> are available in the Git
On Dec 13, 2018 11:40 PM, "Paolo Bonzini" wrote:
>
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted
On Fri, 14 Dec 2018, Peter Maydell wrote:
> On Mon, 26 Nov 2018 at 15:03, Anthony PERARD
> wrote:
> >
> > On Mon, Nov 19, 2018 at 04:26:58PM +, Peter Maydell wrote:
> > > Coverity (CID 796599) points out that xen_pt_setup_vga() trusts
> > > the rom->size field in the BIOS ROM from a PCI
On Fri, Dec 14, 2018 at 15:57:32 +, Aaron Lindsay wrote:
> Emilio,
>
> First, thanks for putting this together - I think everyone doing this
> sort of thing will benefit if we're able to agree on one upstream plugin
> interface.
>
> One thing I'd like to see is support for unregistering
Add a version 64bit bitfield property with no setter, useful for
introspecting the device state without being able to modify it.
Signed-off-by: Roman Kagan
---
include/hw/qdev-properties.h | 9 +
hw/core/qdev-properties.c| 9 -
2 files changed, 17 insertions(+), 1
Take the approach of commit 35f63767dc77d85bebff6c6565aceaf74023776a
"qmp: Merge ObjectPropertyInfo and DevicePropertyInfo" one step further:
drop device property-specific code from qmp_device_list_properties and
consolidate the resulting common part with qmp_qom_list_properties.
Signed-off-by:
This macro is only used in one place so seems to be unnecessary.
Signed-off-by: Roman Kagan
---
include/hw/virtio/virtio.h | 12
hw/virtio/virtio.c | 11 ++-
2 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/include/hw/virtio/virtio.h
Usually in order to tell if a property is read-only, write-only, or
read-write, one has to look at whether it has .get or .set methods.
However, property aliases are always defined with both, and it's not
until the call to the getter or setter when the support for the
corresponding operation can
This series is an attempt to make virtio features acknowledged by the
guest visible as read-only QOM properties. One potential usecase of
this is debugging; another is when the upper layer needs to do something
only when/if the guest has acknowledged the support for a feature (e.g.
hot-plug a
Make virtio features acknowledged by the guest visible through QOM as
read-only properties. One potential usecase of this is debugging;
another is when the upper layer needs to do something only when/if the
guest has acknowledged the support for a feature (e.g. hot-plug a VFIO
device once the
From: Yi Min Zhao
Common function measurement block is used to report zPCI internal
counters of successful pcilg/stg/stb and rpcit instructions to
a memory location provided by the program.
This patch introduces a new ZpciFmb structure and schedules a timer
callback to copy the zPCI measures to
After the last review round I worked on endianness.
Doing this I found some errors in the code and in the interpretation
of the documentation.
The new patch changed the following from previous version:
In s390-pci-bus:
- Initialize the FMB Format.
In s390-pci-bus.h
- re-organization of the
On Thu, 13 Dec 2018 at 14:56, Peter Maydell wrote:
>
> First target-arm pullreq of the 4.0 series; most of this
> is Mao's cleanups that finally let us drop sysbus::init;
> the most interesting user-visible feature is RTH's patches
> adding some v8.1 and v8.2 architecture features.
>
> thanks
>
On Fri, 14 Dec 2018 at 17:26, Alex Bennée wrote:
>
>
> Richard Henderson writes:
>
> > On 12/13/18 8:55 AM, Alex Bennée wrote:
> >>
> >> Ard Biesheuvel writes:
> >>
> >>> Hi Alex,
> >>>
> >>> Thanks again for looking into this.
> >>>
> >>> On Thu, 13 Dec 2018 at 12:55, Alex Bennée wrote:
> >>
Richard Henderson writes:
> On 12/13/18 8:55 AM, Alex Bennée wrote:
>>
>> Ard Biesheuvel writes:
>>
>>> Hi Alex,
>>>
>>> Thanks again for looking into this.
>>>
>>> On Thu, 13 Dec 2018 at 12:55, Alex Bennée wrote:
>>
>>>
int kvm_arch_insert_sw_breakpoint(CPUState *cs, struct
03.12.2018 13:14, Anton Nefedov wrote:
> If COW areas of the newly allocated clusters are zeroes on the backing image,
> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole
> cluster instead of writing explicit zero buffers later in perform_cow().
>
> iotest 060:
> write
On 14/12/2018 15:20, Cornelia Huck wrote:
On Fri, 14 Dec 2018 15:11:18 +0100
Pierre Morel wrote:
From: Yi Min Zhao
Common function measurement block is used to report zPCI internal
counters of successful pcilg/stg/stb and rpcit instructions to
a memory location provided by the program.
Peter Maydell writes:
> On Fri, 14 Dec 2018 at 12:31, Markus Armbruster wrote:
>> Peter Maydell writes:
>> > On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote:
>> > I have to admit I never really understood what tweak
>> > you wanted making to the commit message. I'm happy
>> > to make it
On Dec 13 15:43, Eric Blake wrote:
> On 12/13/18 12:33 PM, Michael Spradling wrote:
>
> > > > My question is has anyone looked into loading snapshots from a backing
> > > > file? I have attempted to look through the code and this looks to be
> > > > difficult. If I attempt to add support for
On Dec 14 10:57, Aaron Lindsay wrote:
> One thing I'd like to see is support for unregistering callbacks once
> they are registered.
By the way, I'm willing to work on this if we agree it sounds reasonable
and fits in with the rest of your implementation.
-Aaron
On Thu, 13 Dec 2018 at 04:01, David Gibson wrote:
>
> The following changes since commit 4b3aab204204ca742836219b97b538d90584f4f2:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-11
> 22:26:44 +)
>
> are available in the Git
Emilio,
First, thanks for putting this together - I think everyone doing this
sort of thing will benefit if we're able to agree on one upstream plugin
interface.
One thing I'd like to see is support for unregistering callbacks once
they are registered. For instance, you can imagine that a plugin
From: Tom Deseyn
Thank you for reviewing Laurant.
Sorry for missing history, I'm not used to sending patches via mail.
I got an email about code style. For now, I'm sticking to the style
that is used in the function.
v2: default to unimplemented
v3: match kernel behavior
Signed-off-by: Tom
> -Original Message-
> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf
> Of Paul Durrant
> Sent: 14 December 2018 14:50
> To: 'Kevin Wolf'
> Cc: xen-de...@lists.xenproject.org; Stefano Stabellini
> ; qemu-devel@nongnu.org; qemu-bl...@nongnu.org;
> Max Reitz
>
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should
The pkg.mxe.cc package repositories have been down for the last two
weeks causing the builds to fail when shippable re-builds the
containers.
This is really just a sticking plaster until we can get our own docker
hub images properly setup so we can avoid having dependencies on
external repos.
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should
> On Dec 14, 2018, at 9:14 AM, Thomas Huth wrote:
>
> On 2018-12-13 22:00, Juan Quintela wrote:
>> Reviewed-by: Laurent Vivier
>> Signed-off-by: Juan Quintela
>> ---
>> hw/virtio/Makefile.objs | 1 +
>> hw/virtio/vhost-user-scsi-pci.c | 101
>>
Peter Maydell writes:
> On Fri, 14 Dec 2018 at 13:56, Alex Bennée wrote:
>>
>>
>> Peter Maydell writes:
>>
>> > Thanks for the bug report and the test program. The fix seems
>> > straightforward -- just adjust what we return for the register value. I've
>> > sent a patch:
>> >
On Fri, 7 Dec 2018 at 04:54, Daniel P. Berrangé wrote:
>
> Looking at this more generally I see they support Linux containers,
> native Windows containers, macOS and FreeBSD. IOW, they offer more
> platforms than our current Travis setup does and aren't stuck on an
> amcient Ubuntu version.
> -Original Message-
[snip]
> > +
> > +blockdev->auto_iothread = iothread;
> > +
> > +object_property_set_bool(OBJECT(dev), true, "realized",
> _err);
> > +if (local_err) {
> > +error_propagate_prepend(errp, local_err,
> > +
In sdhci_sysbus_realize() we override the initialization of
s->iomem that sdhci_common_realize() performs. However we
don't destroy the old memory region before reinitializing
it, which means that the memory allocated for mr->name in
memory_region_do_init() is leaked.
Since sdhci_initfn() already
The load_image() function is now no longer used anywhere, so
we can remove it completely. (Use load_image_size() or
g_file_get_contents() instead.)
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Eric Blake
From: Eduardo Habkost
I introduced indentation using tabs instead of spaces in another
commit. Peter reported the problem, and I failed to fix that
before sending my pull request.
Reported-by: Peter Maydell
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Message-id:
The clang leak sanitizer spots a (one-off, trivial) memory
leak in make_dma() due to a missing free.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20181204132952.2601-3-peter.mayd...@linaro.org
---
hw/arm/mps2-tz.c | 1 +
1 file
Add a documentation comment for load_image_size().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Eric Blake
Message-id: 20181130151712.2312-11-peter.mayd...@linaro.org
---
include/hw/loader.h | 16
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Use the glib g_file_get_contents() function instead, which does
the whole "allocate memory for the file and read it in" operation.
Signed-off-by: Peter Maydell
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
While we are converting the code, add the missing error check.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by:
When we add a new entry to the ARMCPRegInfo hash table in
add_cpreg_to_hashtable(), we allocate memory for tehe
ARMCPRegInfo struct itself, and we also g_strdup() the
name string. So the hashtable's value destructor function
must free the name string as well as the struct.
Spotted by clang's leak
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Use the glib g_file_get_contents() function instead, which does
the whole "allocate memory for the file and read it in" operation.
Signed-off-by: Peter Maydell
ARMv7M machine types support -kernel for ELF and raw image files.
Microbit programs are typically in Intel HEX (.hex) format. The generic
loader supports .hex files but it doesn't work as expected:
$ qemu-system-arm -M microbit -device loader,file=microbit.hex
Guest image must be specified
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by:
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by:
Currently monitor.c reads physical memory using
cpu_physical_memory_read(). This effectively hard-codes
assuming that all CPUs have the same view of physical
memory. Switch to address_space_read() instead, which
lets us use the AddressSpace for the CPU we're
reading memory for (falling back to
The test-arm-mptimer setup creates a lot of test names using
g_strdup_printf() and never frees them. This is entirely
harmless since it's one-shot test code, but it clutters
up the output from clang's LeakSanitizer. Refactor to
use a helper function so we can free the memory.
Signed-off-by: Peter
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by:
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by:
Currently disas.c reads physical memory using
cpu_physical_memory_read(). This effectively hard-codes
assuming that all CPUs have the same view of physical
memory. Switch to address_space_read() instead, which
lets us use the AddressSpace for the CPU we're
disassembling for.
Signed-off-by: Peter
The API of cpu_physical_memory_write_rom() is odd, because it
takes an AddressSpace, unlike all the other cpu_physical_memory_*
access functions. Rename it to address_space_write_rom(), and
bring its API into line with address_space_write().
Signed-off-by: Peter Maydell
Reviewed-by: Philippe
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
While we are converting this code, add an error-check
for read failure.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
The timer_new() function allocates memory; this means that
if we call it in the CPU's init method we would need
to provide an instance_finalize method to free it. Defer
the timer creation to the realize function instead.
This fixes a memory leak spotted by clang LeakSanitizer
when a CPU object is
We now require Linux-kernel-style multiline comments:
/*
* line one
* line two
*/
Enforce this in checkpatch.pl, by backporting the relevant
parts of the Linux kernel's checkpatch.pl. (The only changes
needed are that Linux's checkpatch.pl WARN() function takes
an extra
Currently the load_elf function in elf_ops.h uses
cpu_physical_memory_write() to write the ELF file to
memory if it is not handling it as a ROM blob. This
means we ignore the AddressSpace that the function
is passed to define where it should be loaded.
Use address_space_write() instead.
Rename cpu_physical_memory_write_rom_internal() to
address_space_write_rom_internal(), and make it take
MemTxAttrs and return a MemTxResult. This brings its
API into line with address_space_write().
This is an internal function to exec.c; fixing its API
will allow us to change the global function
/pull-request-2018-12-12' into staging (2018-12-14
10:19:47 +)
are available in the Git repository at:
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-misc-20181214
for you to fetch changes up to bbac02f1e8edfd0663543f6fdad1e7094d860b29:
virt: Fix broken indentation (2018
On 12/14/18 7:09 AM, Halil Pasic wrote:
On Thu, 13 Dec 2018 11:26:42 -0500
Tony Krowiak wrote:
If the maximum number of devices allowed on a bus is 1 and a device
which is plugged into the bus is subsequently unplugged, attempting to replug
the device fails with error "Bus 'xxx' does not
On 12/14/18 4:16 AM, Pierre Morel wrote:
On 13/12/2018 17:26, Tony Krowiak wrote:
If the maximum number of devices allowed on a bus is 1 and a device
which is plugged into the bus is subsequently unplugged, attempting to
replug
the device fails with error "Bus 'xxx' does not support
1 - 100 of 235 matches
Mail list logo
