Re: [Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci)

2019-01-28 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 1/29/19 2:20 AM, BALATON Zoltan wrote: > Hello, > > I'm getting error building on macOS after commit ddac19f534: > >   CC  aarch64-softmmu/hw/virtio/virtio-blk-pci.o > In file included from qemu/hw/virtio/virtio-9p-pci.c:19: > In file included from qemu/hw/9pfs/virtio-9p.h:6:

Re: [Qemu-devel] [PATCH 08/13] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2019-01-28 Thread Cédric Le Goater
On 1/29/19 6:09 AM, Alexey Kardashevskiy wrote: > > > On 08/01/2019 05:39, Cédric Le Goater wrote: >> Removing RTAS handlers will become necessary when the new pseries >> machine supporting multiple interrupt mode is introduced. >> >> Signed-off-by: Cédric Le Goater >> --- >>

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.01.2019 um 17:55 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: >> [...] >> >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than >> >> 'scsi-disk'? >> > >> > Yes, scsi-disk is a

Re: [Qemu-devel] [RFC PATCH] ahci-test: Add dependency to qemu-img tool

2019-01-28 Thread Philippe Mathieu-Daudé
On 1/28/19 8:14 PM, John Snow wrote: > On 1/28/19 11:08 AM, Kevin Wolf wrote: >> Am 25.01.2019 um 22:57 hat John Snow geschrieben: >>> On 1/25/19 3:34 PM, Philippe Mathieu-Daudé wrote: Since the ahci-test uses qemu-img, add a dependency to build it before using it. This fixes:

Re: [Qemu-devel] [PATCH v11 1/3] util/mmap-alloc: Add a 'is_pmem' parameter to qemu_ram_mmap

2019-01-28 Thread Pankaj Gupta
> > From: Zhang Yi > > besides the existing 'shared' flags, we are going to add > 'is_pmem' to qemu_ram_mmap(), which indicated the memory backend > file is a persist memory. > > Signed-off-by: Haozhong Zhang > Signed-off-by: Zhang Yi > --- > exec.c| 2 +- >

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-28 Thread Philippe Mathieu-Daudé
Hi Wei, On 1/29/19 1:08 AM, Wei Yang wrote: > There are several functions/variable which are not used anymore. > > This serials just remove those without functional change. > > Wei Yang (3): > hw/i386/pc.c: remove unused function pc_acpi_init() > hw/acpi: remove unused function

Re: [Qemu-devel] [PATCH v11 2/3] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-28 Thread Pankaj Gupta
> > From: Zhang Yi > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > MAP_SYNC flag in addition which can ensure file system metadata > synced in each guest writes to the backend file, without other QEMU > actions (e.g., periodic fsync() by QEMU). > > Current, We have

Re: [Qemu-devel] [PATCH] trace: rerun tracetool after ./configure changes

2019-01-28 Thread Philippe Mathieu-Daudé
On 1/29/19 3:53 AM, Stefan Hajnoczi wrote: > Autogenerated code in trace.h/trace.c and friends is specific to the > config-host.mak TRACE_BACKENDS setting and must be regenerated when > ./configure --enable-trace-backend= changes settings. > > This patch ensures that changes to TRACE_BACKENDS are

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-28 Thread Mark Cave-Ayland
On 29/01/2019 02:28, David Gibson wrote: > On Sun, Jan 27, 2019 at 10:07:12AM -0800, Richard Henderson wrote: >> On 1/27/19 9:45 AM, Mark Cave-Ayland wrote: I would expect the i < n/2 loop to be faster, because the assignments are unconditional. FWIW. >>> >>> Do you have any idea as to

[Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-01-28 Thread Pankaj Gupta
Hotplugging existing char chardev with qmp, dereferences(removes) existing chardev. This patch avoids adding a chardev if a chardev with same id exists. RH BZ 1660831: # (host) ls -lt /tmp/helloworld* srwxr-xr-x. /tmp/helloworld1 srwxr-xr-x. /tmp/helloworld2 Before this patch: hotplug

Re: [Qemu-devel] [PATCH v4 02/14] audio: use qapi AudioFormat instead of audfmt_e

2019-01-28 Thread Thomas Huth
On 2019-01-28 23:43, Kővágó, Zoltán wrote: > I had to include an enum for audio sampling formats into qapi, but that > meant duplicating the audfmt_e enum. This patch replaces audfmt_e and > associated values with the qapi generated AudioFormat enum. > > This patch is mostly a

[Qemu-devel] [PATCH v11 2/3] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-28 Thread Zhang, Yi
From: Zhang Yi When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Current, We have below different

[Qemu-devel] [PATCH v11 1/3] util/mmap-alloc: Add a 'is_pmem' parameter to qemu_ram_mmap

2019-01-28 Thread Zhang, Yi
From: Zhang Yi besides the existing 'shared' flags, we are going to add 'is_pmem' to qemu_ram_mmap(), which indicated the memory backend file is a persist memory. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- exec.c| 2 +- include/qemu/mmap-alloc.h | 21

[Qemu-devel] [PATCH v11 3/3] docs: Added MAP_SYNC documentation

2019-01-28 Thread Zhang, Yi
From: Zhang Yi Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 29 - qemu-options.hx | 4 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a6..9da96aa 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt

[Qemu-devel] [PATCH v11 0/3] support MAP_SYNC for memory-backend-file

2019-01-28 Thread Zhang, Yi
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at

Re: [Qemu-devel] [PATCH v5 1/6] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-28 Thread Yongji Xie
On Tue, 29 Jan 2019 at 12:26, Michael S. Tsirkin wrote: > > On Tue, Jan 29, 2019 at 12:11:55PM +0800, Stefan Hajnoczi wrote: > > On Tue, Jan 22, 2019 at 04:31:47PM +0800, elohi...@gmail.com wrote: > > > +typedef struct DescState { > > > +uint8_t inuse; > > > +uint8_t version; > > > +

Re: [Qemu-devel] [PATCH v4 03/14] audio: -audiodev command line option: documentation

2019-01-28 Thread Thomas Huth
On 2019-01-28 23:43, Kővágó, Zoltán wrote: > This patch adds documentation of an -audiodev command line option, that > deprecates the old QEMU_* environment variables for audio backend > configuration. It's syntax is similar to existing options (-netdev, > -device, etc): > > -audiodev

Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source

2019-01-28 Thread Thomas Huth
On 2019-01-28 18:47, Philippe Mathieu-Daudé wrote: > Cc'ing Thomas/Paolo for Makefile rules... > > On 1/24/19 12:43 PM, Gerd Hoffmann wrote: >> On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote: >>> Move the complexity of milkymist_tmu2_create() into the >>> source file.

[Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-28 Thread Peter Xu
Lukas reported an hard to reproduce QMP iothread hang on s390 that QEMU might hang at pthread_join() of the QMP monitor iothread before quitting: Thread 1 #0 0x03ffad10932c in pthread_join #1 0x000109e95750 in qemu_thread_join at

[Qemu-devel] Last call for GSoC/Outreachy project ideas

2019-01-28 Thread Stefan Hajnoczi
Dear QEMU, KVM, Jailhouse, and Rust-VMM communities, Please post your internship project ideas by February 1st so we can include them in the Google Summer of Code and Outreachy ideas list: https://wiki.qemu.org/Google_Summer_of_Code_2019 If you'd like to mentor but don't have your own project

Re: [Qemu-devel] [PATCH 08/13] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2019-01-28 Thread Alexey Kardashevskiy
On 08/01/2019 05:39, Cédric Le Goater wrote: > Removing RTAS handlers will become necessary when the new pseries > machine supporting multiple interrupt mode is introduced. > > Signed-off-by: Cédric Le Goater > --- > include/hw/ppc/spapr.h | 4 > hw/ppc/spapr_rtas.c| 2 +- > 2 files

Re: [Qemu-devel] [PATCH v8 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo

2019-01-28 Thread Max Filippov
Hello, On Fri, Dec 7, 2018 at 1:04 AM Luc Michel wrote: > > Change the thread info related packets handling to support multiprocess > extension. > > Add the CPUs class name in the extra info to help differentiate > them in multiprocess mode. > > Signed-off-by: Luc Michel > Reviewed-by: Philippe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-28 Thread David Gibson
On Sun, Jan 27, 2019 at 10:07:12AM -0800, Richard Henderson wrote: > On 1/27/19 9:45 AM, Mark Cave-Ayland wrote: > >> I would expect the i < n/2 loop to be faster, because the assignments are > >> unconditional. FWIW. > > > > Do you have any idea as to how much faster? Is it something that would

Re: [Qemu-devel] [PATCH v5 1/6] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-28 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 12:11:55PM +0800, Stefan Hajnoczi wrote: > On Tue, Jan 22, 2019 at 04:31:47PM +0800, elohi...@gmail.com wrote: > > +typedef struct DescState { > > +uint8_t inuse; > > +uint8_t version; > > +uint16_t used_idx; > > +uint16_t avail_idx; > > +uint16_t

Re: [Qemu-devel] [PATCH v5 1/6] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-28 Thread Stefan Hajnoczi
On Tue, Jan 22, 2019 at 04:31:47PM +0800, elohi...@gmail.com wrote: > +typedef struct DescState { > +uint8_t inuse; > +uint8_t version; > +uint16_t used_idx; > +uint16_t avail_idx; > +uint16_t reserved; > +} DescState; > + > +typedef struct QueueRegion { > +uint8_t valid; >

Re: [Qemu-devel] [PATCH v6 1/2] qemu-io: Use error_[gs]et_progname()

2019-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 06:22:28PM +0100, Christophe Fergeau wrote: > qemu-io reimplements itself what > error_get_progname()/error_set_progname() already does. > This commit switches it to use this API from qemu-error.h > > Signed-off-by: Christophe Fergeau > --- > qemu-io.c | 14

Re: [Qemu-devel] [PATCH v6 2/2] log: Make glib logging go through QEMU

2019-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 06:22:29PM +0100, Christophe Fergeau wrote: > This commit adds a qemu_init_logging() helper which calls > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > are handled similarly to other QEMU logs. This means they will get a > timestamp if timestamps

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] block: local qiov helper

2019-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 07:46:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > What about such a simple helper for a very often patter around > qemu_iovec_init_external ? Sounds good, qemu_iovec_init() has 55 references vs qemu_iovec_init_external() with 51. It's worth making

Re: [Qemu-devel] [PATCH 3/5 v2] RISC-V: Map gdb CSR reg numbers to hw reg numbers.

2019-01-28 Thread Jim Wilson
On Tue, Jan 22, 2019 at 1:45 PM Alistair Francis wrote: > I think it makes more sense to just define the variable in the > gdbstubs.c file then. Can you move it to patch 5? Yes, that is no problem. That makes patch 3 a lot smaller and patch 5 a lot bigger, but it is the same code as before,

Re: [Qemu-devel] [PATCH 5/5 v2] RISC-V: Add hooks to use the gdb xml files.

2019-01-28 Thread Jim Wilson
On Tue, Jan 22, 2019 at 1:52 PM Alistair Francis wrote: > You can get env and then check for floating point support: > > CPURISCVState *env = >env; > if (env->misa_mask & RVF) { > ... I needed this which wasn't hard to figure out. RISCVCPU *cpu = RISCV_CPU(cs); CPURISCVState *env = >env;

Re: [Qemu-devel] [Bug 1813305] [NEW] trace-root.h is not regerenerated after re-configure

2019-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 02:03:39PM -, Christophe Lyon wrote: > I've just realized that after I reconfigured my qemu with > ../configure > --target-list=arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user > --enable-trace-backends=simple > > $ make > did rebuild some stuff for the

Re: [Qemu-devel] [PATCH] hw/arm/nrf51_soc: set object owner in memory_region_init_ram

2019-01-28 Thread Stefan Hajnoczi
On Fri, Jan 25, 2019 at 09:26:30PM +0530, kumar sourav wrote: > set object owner in memory_region_init_ram() instead > of NULL. > > Signed-off-by: kumar sourav > --- > hw/arm/nrf51_soc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc

[Qemu-devel] [PATCH] trace: rerun tracetool after ./configure changes

2019-01-28 Thread Stefan Hajnoczi
Autogenerated code in trace.h/trace.c and friends is specific to the config-host.mak TRACE_BACKENDS setting and must be regenerated when ./configure --enable-trace-backend= changes settings. This patch ensures that changes to TRACE_BACKENDS are detected. For example, the trace-root.h file is now

Re: [Qemu-devel] [PATCH] test-filter-mirror: pass UNIX domain socket through fd

2019-01-28 Thread Jason Wang
On 2019/1/28 下午6:30, Daniel P. Berrangé wrote: On Mon, Jan 28, 2019 at 12:11:59PM +0800, Jason Wang wrote: The tests tries to let qemu server mode to process the connection which turns out to be racy after commit 8258292e18c3 ("monitor: Remove "x-oob", offer capability "oob"

Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator

2019-01-28 Thread Alexey Kardashevskiy
On 14/01/2019 12:43, Alexey Kardashevskiy wrote: > > > On 04/01/2019 04:37, Dr. David Alan Gilbert wrote: >> * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: >>> >>> >>> On 17/12/2018 23:47, Philippe Mathieu-Daudé wrote: On 12/17/18 2:27 AM, Alexey Kardashevskiy wrote: > On 14/12/2018

Re: [Qemu-devel] building rst docs with sphinx

2019-01-28 Thread Stefan Hajnoczi
On Thu, Jan 24, 2019 at 06:56:09PM +, Peter Maydell wrote: > (1) configure: My thought is that we should just make > sphinx-build a requirement for the existing --enable-docs > switch (as texinfo and pod2man are currently). The > disadvantage is that we won't support a "build the half > of the

[Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci)

2019-01-28 Thread BALATON Zoltan
Hello, I'm getting error building on macOS after commit ddac19f534: CC aarch64-softmmu/hw/virtio/virtio-blk-pci.o In file included from qemu/hw/virtio/virtio-9p-pci.c:19: In file included from qemu/hw/9pfs/virtio-9p.h:6: In file included from qemu/hw/9pfs/9p.h:7:

Re: [Qemu-devel] [PATCH] i386: extended the cpuid level when Intel PT is enabled

2019-01-28 Thread Kang, Luwei
> > > > > > Intel Processor Trace required CPUID[0x14] but the cpuid level > > > > > > is 0xd when create a kvm guest with e.g. "-cpu qemu64,+intel-pt". > > > > > > > > > > > > Signed-off-by: Luwei Kang > > > > > > --- > > > > > > target/i386/cpu.c | 7 +++ > > > > > > 1 file changed, 7

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-28 Thread Alexey Kardashevskiy
On 29/01/2019 07:00, Fabiano Rosas wrote: > David Gibson writes: > >> On Thu, Jan 24, 2019 at 06:20:02PM +1100, Alexey Kardashevskiy wrote: >>> >>> >>> On 23/01/2019 04:01, Fabiano Rosas wrote: These will be used to let GDB know about PPC's Special Purpose Registers (SPR).

[Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-28 Thread Wei Yang
Function pc_acpi_init() is not used anymore. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/i386/pc.c | 27 --- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-28 Thread Wei Yang
There are several functions/variable which are not used anymore. This serials just remove those without functional change. Wei Yang (3): hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-28 Thread Collin Walling
On 1/28/19 6:28 AM, Cornelia Huck wrote: On Wed, 23 Jan 2019 12:05:39 +0100 Cornelia Huck wrote: On Mon, 21 Jan 2019 14:42:49 +0100 David Hildenbrand wrote: When resetting the guest we should unplug and remove all devices that are still pending. Otherwise the fresh guest will see devices

[Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin

2019-01-28 Thread Wei Yang
acpi_table_builtin is now always false, it is not necessary to check it again. This patch just removes it. Signed-off-by: Wei Yang --- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index e9b1a85e54..f9c96535d1 100644 ---

[Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin()

2019-01-28 Thread Wei Yang
Function acpi_table_add_builtin() is not used anymore. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/acpi/core.c | 6 -- include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index d6f0709691..e9b1a85e54

Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-28 Thread Wei Yang
On Mon, Jan 28, 2019 at 02:32:30PM +0100, Igor Mammedov wrote: >On Fri, 25 Jan 2019 14:01:55 +0800 >Wei Yang wrote: > >> Function pc_acpi_init() is now used in no place. >s/is now used in no place./in not used anymore,/ > >fixup the same phrase in other patches. > >otherwise series looks good, so

[Qemu-devel] [PATCH v4 04/14] audio: -audiodev command line option basic implementation

2019-01-28 Thread Kővágó, Zoltán
Audio drivers now get an Audiodev * as config paramters, instead of the global audio_option structs. There is some code in audio/audio_legacy.c that converts the old environment variables to audiodev options (this way backends do not have to worry about legacy options). It also contains a

[Qemu-devel] [PATCH v4 10/14] paaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 39 +++ audio/paaudio.c | 91 +++- 2 files changed, 79 insertions(+), 51 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 3d336259bb..d8cd5e27f6

[Qemu-devel] [PATCH v4 03/14] audio: -audiodev command line option: documentation

2019-01-28 Thread Kővágó, Zoltán
This patch adds documentation of an -audiodev command line option, that deprecates the old QEMU_* environment variables for audio backend configuration. It's syntax is similar to existing options (-netdev, -device, etc): -audiodev driver_name,property=value,... Although now it's possible to

[Qemu-devel] [PATCH v4 02/14] audio: use qapi AudioFormat instead of audfmt_e

2019-01-28 Thread Kővágó, Zoltán
I had to include an enum for audio sampling formats into qapi, but that meant duplicating the audfmt_e enum. This patch replaces audfmt_e and associated values with the qapi generated AudioFormat enum. This patch is mostly a search-and-replace, except for switches where the qapi generated

[Qemu-devel] [PATCH v4 13/14] wavaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 15 audio/wavaudio.c | 58 +++- 2 files changed, 24 insertions(+), 49 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 214774b947..2c2447176c 100644 ---

[Qemu-devel] [PATCH v4 00/14] Audio patches (was: Audio 5.1 patches)

2019-01-28 Thread Kővágó, Zoltán
Hi, Here's an updated version of my audio patches. Due to the size of the patch series, I broke it down to smaller parts, this is the first part. This series adds an -audiodev command line parameter instead of the old environment variable based config. Changes from v3: * fixed formatting

[Qemu-devel] [PATCH v4 05/14] alsaaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c| 344 ++- audio/audio_legacy.c | 94 +++- 2 files changed, 205 insertions(+), 233 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 8302f3e882..68fcfdd038 100644 ---

[Qemu-devel] [PATCH v4 11/14] sdlaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 12 audio/sdlaudio.c | 22 -- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index d8cd5e27f6..214774b947 100644 --- a/audio/audio_legacy.c

[Qemu-devel] [PATCH v2 02/12] target/arm: Add PSTATE.BTYPE

2019-01-28 Thread Richard Henderson
Place this in its own field within ENV, as that will make it easier to reset from within TCG generated code. With the change to pstate_read/write, exception entry and return are automatically handled. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h |

[Qemu-devel] [PATCH v4 14/14] audio: -audiodev command line option: cleanup

2019-01-28 Thread Kővágó, Zoltán
Remove no longer needed code. Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 17 audio/audio.c | 201 +- 2 files changed, 4 insertions(+), 214 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index

[Qemu-devel] [PATCH v4 09/14] ossaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 33 + audio/ossaudio.c | 167 +++ 2 files changed, 90 insertions(+), 110 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 0002fce627..3d336259bb 100644 ---

[Qemu-devel] [PATCH v4 01/14] qapi: qapi for audio backends

2019-01-28 Thread Kővágó, Zoltán
This patch adds structures into qapi to replace the existing configuration structures used by audio backends currently. This qapi will be the base of the -audiodev command line parameter (that replaces the old environment variables based config). This is not a 1:1 translation of the old options,

[Qemu-devel] [PATCH v2 11/12] linux-user/aarch64: Reset btype for syscalls and signals

2019-01-28 Thread Richard Henderson
The value of btype for syscalls is CONSTRAINED UNPREDICTABLE, so we need to make sure that the value is 0 before clone, fork, or syscall return. The value of btype for signals is defined, but it does not make sense for a SIGILL handler to enter with the btype set as for the indirect branch that

[Qemu-devel] [PATCH v4 07/14] dsoundaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/dsound_template.h | 6 ++--- audio/audio_legacy.c| 39 +++ audio/dsoundaudio.c | 59 - 3 files changed, 59 insertions(+), 45 deletions(-) diff --git a/audio/dsound_template.h

[Qemu-devel] [PATCH v4 06/14] coreaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 24 ++ audio/coreaudio.c| 48 +--- 2 files changed, 34 insertions(+), 38 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 8319dc5240..301934bf0c

[Qemu-devel] [PATCH v3] QGA: Fix guest-get-fsinfo PCI address collection in Windows

2019-01-28 Thread mhines
From: Matt Hines The Windows QEMU guest agent erroneously tries to collect PCI information directly from the physical drive. However, windows stores SCSI/IDE information with the drive and PCI information with the underlying storage controller This changes get_pci_info to use the physical

[Qemu-devel] [PATCH v2 01/12] target/arm: Introduce isar_feature_aa64_bti

2019-01-28 Thread Richard Henderson
Also create field definitions for id_aa64pfr1 from ARMv8.5. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Include MTE and RAS_FRAC fields of AA64PFR1. --- target/arm/cpu.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h

[Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI

2019-01-28 Thread Richard Henderson
The branch target identification extension does not yet have kernel or gcc support. It should be in shape for developing those though. In system mode I do honor the GP bit from the page tables. In user-only mode, there is a way to pretend that the GP bit is always set. Further linux-user

[Qemu-devel] [PATCH v4 12/14] spiceaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/spiceaudio.c | 5 - 1 file changed, 5 deletions(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index affc3df17f..4f7873af5a 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@ -373,10 +373,6 @@ static int line_in_ctl (HWVoiceIn *hw,

[Qemu-devel] [PATCH v2 03/12] target/arm: Add BT and BTYPE to tb->flags

2019-01-28 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 ++ target/arm/translate.h | 4 target/arm/helper.c| 22 +++--- target/arm/translate-a64.c | 2 ++ 4 files changed, 23 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v2 10/12] target/arm: Enable BTI for -cpu max

2019-01-28 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu64.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index a563f7e74d..9d2276fe53 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -368,6 +368,10 @@ static

[Qemu-devel] [PATCH v4 08/14] noaudio: port to -audiodev config

2019-01-28 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/noaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 79690af1ea..ccc611fc84 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -163,7 +163,6 @@ static struct audio_pcm_ops no_pcm_ops = { static struct

[Qemu-devel] [PATCH v2 07/12] target/arm: Reset btype for direct branches

2019-01-28 Thread Richard Henderson
This is all of the non-exception cases of DISAS_NORETURN. Signed-off-by: Richard Henderson --- v2: Do not reset byte for syscalls --- target/arm/translate-a64.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index

[Qemu-devel] [PATCH v2 06/12] target/arm: Default handling of BTYPE during translation

2019-01-28 Thread Richard Henderson
The branch target exception for guarded pages has high priority, and only 8 instructions are valid for that case. Perform this check before doing any other decode. Clear BTYPE after all insns that neither set BTYPE nor exit via exception (DISAS_NORETURN). Not yet handled are insns that exit via

[Qemu-devel] [PATCH v2 08/12] target/arm: Set btype for indirect branches

2019-01-28 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index dbac09743c..89cc54dbed 100644 ---

[Qemu-devel] [PATCH v2 04/12] exec: Add target-specific tlb bits to MemTxAttrs

2019-01-28 Thread Richard Henderson
These bits can be used to cache target-specific data in cputlb read from the page tables. Signed-off-by: Richard Henderson --- include/exec/memattrs.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/exec/memattrs.h b/include/exec/memattrs.h index d4a1642098..d4a3477d71

[Qemu-devel] [PATCH v2 05/12] target/arm: Cache the GP bit for a page in MemTxAttrs

2019-01-28 Thread Richard Henderson
Caching the bit means that we will not have to re-walk the page tables to look up the bit during translation. Signed-off-by: Richard Henderson --- target/arm/helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 6efe88a157..70277222da

[Qemu-devel] [PATCH v2 09/12] target/arm: Add x-guarded-pages cpu property for user-only

2019-01-28 Thread Richard Henderson
While waiting for a proper userland ABI, allow static test cases to be written assuming that GP is set for all pages. Signed-off-by: Richard Henderson --- v2: Renamed the property with x- prefix --- target/arm/cpu.h | 4 target/arm/cpu64.c | 18 ++

[Qemu-devel] [PATCH v2 12/12] tests/tcg/aarch64: Add bti smoke test

2019-01-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/aarch64/bti-1.c | 61 +++ tests/tcg/aarch64/bti-crt.inc.c | 51 ++ tests/tcg/aarch64/Makefile.target | 7 +++- 3 files changed, 118 insertions(+), 1 deletion(-) create mode 100644

Re: [Qemu-devel] [PATCH v1 4/4] tests/tcg/aarch64: userspace system register test

2019-01-28 Thread Alex Bennée
Alex Bennée writes: > This tests a bunch of registers that the kernel allows userspace to > read including the CPUID registers. > > Signed-off-by: Alex Bennée I'll also merge the following fix: modified tests/tcg/aarch64/sysregs.c @@ -11,6 +11,10 @@ #include #include +#ifndef

Re: [Qemu-devel] [PATCH 08/11] target/arm: Add guarded_pages cpu property for user-only

2019-01-28 Thread Richard Henderson
On 1/22/19 8:57 AM, Peter Maydell wrote: >>> This is OK code-wise but I'm a bit wary of committing it >>> because then we're stuck with the property forever even >>> if it turns out to be irrelevant to whatever the userland >>> ABI eventually is. >> >> That's surely simply a matter of

Re: [Qemu-devel] [PATCH] acpi: Make TPM 2.0 with TIS available as MSFT0101

2019-01-28 Thread Stefan Berger
On 1/28/19 12:49 PM, Michael S. Tsirkin wrote: On Mon, Jan 28, 2019 at 12:19:37PM -0500, Stefan Berger wrote: On 1/28/19 11:14 AM, Stefan Berger wrote: On 1/28/19 9:45 AM, Igor Mammedov wrote: On Fri, 25 Jan 2019 16:00:58 -0500 Stefan Berger wrote: This patch makes the a TPM 2.0 with TIS

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-28 Thread Eric Farman
On 01/28/2019 12:24 PM, Cornelia Huck wrote: On Fri, 25 Jan 2019 10:57:38 -0500 Eric Farman wrote: On 01/25/2019 07:58 AM, Cornelia Huck wrote: On Fri, 25 Jan 2019 11:24:37 +0100 Cornelia Huck wrote: On Thu, 24 Jan 2019 21:37:44 -0500 Eric Farman wrote: On 01/24/2019 09:25 PM,

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-28 Thread Eric Farman
On 01/28/2019 02:15 PM, Halil Pasic wrote: On Mon, 28 Jan 2019 18:09:48 +0100 Cornelia Huck wrote: On Fri, 25 Jan 2019 15:01:01 +0100 Halil Pasic wrote: On Fri, 25 Jan 2019 13:58:35 +0100 Cornelia Huck wrote: - The code should not be interrupted while we process the channel

Re: [Qemu-devel] [PATCH 06/11] target/arm: Reset btype for direct branches and syscalls

2019-01-28 Thread Richard Henderson
On 1/22/19 6:12 AM, Peter Maydell wrote: > On Thu, 10 Jan 2019 at 12:17, Richard Henderson > wrote: >> >> This is all of the non-exception cases of DISAS_NORETURN. > > What about the gen_helper_exit_atomic() exit cases ? In that case we are going to re-execute the same insn with a different

[Qemu-devel] [PATCH 0/2] qemu-macppc patches

2019-01-28 Thread Mark Cave-Ayland
Here's the contents of my qemu-macppc branch: just two minor patches consisting of an update to MAINTAINERS, plus bringing in updated binaries containing bugfixes for Ben's MacOS NDRV VGA driver. Signed-off-by: Mark Cave-Ayland Mark Cave-Ayland (2): MAINTAINERS: add myself as maintainer for

[Qemu-devel] [PATCH 2/2] QemuMacDrivers: update qemu_vga.ndrv to 90c488d built from submodule

2019-01-28 Thread Mark Cave-Ayland
This update to qemu_vga.ndrv includes the following changes: - Build guest resolution list from QEMU EDID data if enabled - Fixes to re-enable 256 color mode Signed-off-by: Mark Cave-Ayland --- pc-bios/qemu_vga.ndrv | Bin 14752 -> 18752 bytes roms/QemuMacDrivers | 2 +- 2 files changed, 1

[Qemu-devel] [PATCH 1/2] MAINTAINERS: add myself as maintainer for Mac Old World and New World machines

2019-01-28 Thread Mark Cave-Ayland
I've unofficially been doing most of the work on the Mac machines for a while now, so update MAINTAINERS to reflect this. David is still happy to be listed as a reviewer as per our discussion at KVM forum. Signed-off-by: Mark Cave-Ayland Acked-by: David Gibson --- MAINTAINERS | 6 -- 1

[Qemu-devel] [PATCH 1/2] usb: XHCI shall not halt isochronous endpoints

2019-01-28 Thread Yuri Benditovich
According to the XHCI spec (4.10.2) the controller never halts isochronous endpoints. This commit prevent stop of isochronous streaming when sporadic errors status received from backends. Signed-off-by: Yuri Benditovich --- hw/usb/hcd-xhci.c | 5 + 1 file changed, 5 insertions(+) diff

[Qemu-devel] [PATCH 0/2] Fix XHCI errors with isochronous transfer

2019-01-28 Thread Yuri Benditovich
These patches fix errors causing isochronous transfer to stop when XHCI works with redirected devices: * avoid halt of isochronous endpoints * implement underrun/overrun events Note that checkpatch emits errors for patch 2 on usage by 'slotid-1' statement. I still leave it for readability as this

[Qemu-devel] [PATCH 2/2] usb: implement XHCI underrun/overrun events

2019-01-28 Thread Yuri Benditovich
Implement underrun/overrun events of isochronous endpoints according to XHCI spec (4.10.3.1) Guest software restarts data streaming when receives these events. The XHCI reports these events using interrupter assigned to the slot (as these events do not have TRB), so current commit adds the field

Re: [Qemu-devel] [PATCH 04/11] target/arm: Record the GP bit for a page in MemTxAttrs

2019-01-28 Thread Richard Henderson
On 1/22/19 5:26 AM, Peter Maydell wrote: > On Thu, 10 Jan 2019 at 12:17, Richard Henderson > wrote: >> >> This isn't really a transaction attribute, but that's the most >> convenient place to hold a random bit of information within the >> softmmu tlb. >> >> Signed-off-by: Richard Henderson >>

Re: [Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-28 Thread Eric Blake
On 1/28/19 2:01 PM, Andrey Shinkevich wrote: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > > As the print of the qcow2 specific

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-28 Thread Tony Krowiak
On 12/17/18 10:57 AM, Tony Krowiak wrote: The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the max_index value of the BusState structure with the max_dev value of the BusClass structure to determine whether the maximum number of children has been reached for the bus. The

[Qemu-devel] [PATCH v2] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-28 Thread Tony Krowiak
Introduces hot plug/unplug support for the vfio-ap device. Note that only one vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only be hot plugged if the '-device vfio-ap,sysfsdev=$path_to_mdev' option is not specified on the QEMU command line. Please note that a hot plug

Re: [Qemu-devel] [Qemu-block] [PATCH v3 13/19] block: Remove aio_poll() in bdrv_drain_poll variants

2019-01-28 Thread Max Reitz
On 20.09.18 18:19, Kevin Wolf wrote: > bdrv_drain_poll_top_level() was buggy because it didn't release the > AioContext lock of the node to be drained before calling aio_poll(). > This way, callbacks called by aio_poll() would possibly take the lock a > second time and run into a deadlock with a

[Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-28 Thread Andrey Shinkevich
In the 'Format specific information' section of the 'qemu-img info' command output, the supplemental information about existing QCOW2 bitmaps will be shown, such as a bitmap name, flags and granularity: image: /vz/vmprivate/VM1/harddisk.hdd file format: qcow2 virtual size: 64G (68719476736 bytes)

[Qemu-devel] [PATCH v9 0/2] qemu-img info lists bitmap directory entries

2019-01-28 Thread Andrey Shinkevich
Currently, I am tackling the implementation of the Eric Blake's ideas, who proposed the following: "Should the test also create a disabled bitmap ("enabled":false), to show the change in flags, and/or a non-persistent bitmap (to show that it does not affect the qcow2 information, but only the

[Qemu-devel] [PATCH v9 2/2] qemu-img info: bitmaps extension new test 239

2019-01-28 Thread Andrey Shinkevich
A new test file 239 added to the qemu-iotests set. It checks the output format of 'qemu-img info' for bitmaps extension of qcow2 specific information. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/239 | 60 +++ tests/qemu-iotests/239.out | 88

Re: [Qemu-devel] [PATCH v2 1/2] tests.acceptance: adds multi vm capability for acceptance tests

2019-01-28 Thread Wainer dos Santos Moschetta
On 01/28/2019 03:47 PM, Caio Carrara wrote: This change adds the possibility to write acceptance tests with multi virtual machine support. It's done keeping the virtual machines objects stored in a test attribute (dictionary). This dictionary shouldn't be accessed directly but through the new

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 2/3] target/ppc: Add GDB callbacks for SPRs

2019-01-28 Thread Fabiano Rosas
David Gibson writes: > On Thu, Jan 24, 2019 at 06:20:02PM +1100, Alexey Kardashevskiy wrote: >> >> >> On 23/01/2019 04:01, Fabiano Rosas wrote: >> > These will be used to let GDB know about PPC's Special Purpose >> > Registers (SPR). >> > >> > They take an index based on the order the

Re: [Qemu-devel] Crash when booting KDE Neon using qxl-vga

2019-01-28 Thread Leonardo Soares Müller
libspice-server1 on host: 0.14.0-1ubuntu2.2 spice-vdagent (the only package) on guest: 0.17.0-1ubuntu2 Guest kernel version: 4.15.0-44-generic > > OK, great; can can you confirm the version of the spice packages > on both the guest and host, and the kernel on the guest. > > Dave > > -- > Dr.

[Qemu-devel] [PULL 2/2] hostmem: add more information in error messages

2019-01-28 Thread Eduardo Habkost
From: Zhang Yi When there are multiple memory backends in use, including the object type and property name in the error message can help users to locate the error. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi Message-Id:

[Qemu-devel] [PULL 0/2] Machine queue, 2019-01-28

2019-01-28 Thread Eduardo Habkost
The following changes since commit 5f39a91dbd9a186edb999afd4d17524f4b1da14f: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2019-01-28 12:54:06 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git

[Qemu-devel] [PULL 1/2] numa: Fixed the memory leak of numa error message

2019-01-28 Thread Eduardo Habkost
From: Zhang Yi object_get_canonical_path_component() returns a string which must be freed using g_free(). Signed-off-by: Zhang Yi Reviewed-by: Pankaj gupta Reviewed-by: Igor Mammedov Message-Id: <51ba6d7d0333a5517d824a870dd20887156dd15a.1546399191.git.yi.z.zh...@linux.intel.com>

  1   2   3   4   5   >