Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

On Thu, 14 Mar 2019 21:57:37 PDT (-0700), alistai...@gmail.com wrote: On Thu, Mar 14, 2019 at 8:59 PM Palmer Dabbelt wrote: On Thu, 14 Mar 2019 13:28:37 PDT (-0700), alistai...@gmail.com wrote: > On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: >> >> From: Bastian Koppelmann >> >>

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

On Thu, Mar 14, 2019 at 8:59 PM Palmer Dabbelt wrote: > > On Thu, 14 Mar 2019 13:28:37 PDT (-0700), alistai...@gmail.com wrote: > > On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: > >> > >> From: Bastian Koppelmann > >> > >> Reviewed-by: Richard Henderson > >> Signed-off-by: Bastian

Re: [Qemu-devel] [PATCH v2 04/13] spapr/xive: add state synchronization with KVM

On Thu, Mar 14, 2019 at 08:56:25AM +0100, Cédric Le Goater wrote: > On 3/14/19 3:10 AM, David Gibson wrote: > > On Mon, Mar 11, 2019 at 09:41:12PM +0100, Cédric Le Goater wrote: > >> On 2/26/19 1:01 AM, David Gibson wrote: > >>> On Fri, Feb 22, 2019 at 02:13:13PM +0100, Cédric Le Goater wrote: >

Re: [Qemu-devel] [PATCH v2 02/13] spapr/xive: add hcall support when under KVM

On Thu, Mar 14, 2019 at 10:24:49PM +0100, Cédric Le Goater wrote: > On 3/14/19 3:11 AM, David Gibson wrote: > > On Wed, Mar 13, 2019 at 11:43:54AM +0100, Cédric Le Goater wrote: > >> On 3/12/19 11:26 AM, David Gibson wrote: > >>> On Mon, Mar 11, 2019 at 06:32:05PM +0100, Cédric Le Goater wrote: >

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

On Thu, 14 Mar 2019 13:28:37 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: From: Bastian Koppelmann Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt This commit is the first bad commit in

[Qemu-devel] [PATCH v3 05/23] crypto: Use getrandom for qcrypto_random_bytes

Prefer it to direct use of /dev/urandom. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- v3: If getrandom is not present, fall back on /dev/(u)random. --- crypto/random-platform.c | 37 - configure| 18 +- 2 files

Re: [Qemu-devel] [PATCH v3 17/23] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail

On Fri, 15 Mar 2019 at 03:26, Richard Henderson wrote: > > The random number is intended for use by the guest. As such, we should > honor the -seed argument for reproducibility. Use the *_nofail routine > instead of error_abort directly. > > Cc: qemu-...@nongnu.org > Cc: Joel Stanley >

[Qemu-devel] [PATCH v3 04/23] crypto: Use O_CLOEXEC in qcrypto_random_init

Avoids leaking the /dev/urandom fd into any child processes. Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/random-platform.c b/crypto/random-platform.c index

[Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure

There were 3 copies of this code, one of which used the wrong data size for the failure indicator. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- ui/vnc.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

On Thu, 14 Mar 2019 at 19:43, Daniel P. Berrangé wrote: > > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > > > On Thu, Feb 28,

Re: [Qemu-devel] [PATCH v3 16/23] aspeed/scu: Use qemu_guest_getrandom_nofail

On Fri, 15 Mar 2019 at 03:26, Richard Henderson wrote: > > The random number is intended for use by the guest. As such, we should > honor the -seed argument for reproducibility. Use the *_nofail routine > instead of rolling our own error handling locally. Nice! Reviewed-by: Joel Stanley > >

[Qemu-devel] [PATCH v3 00/23] Add qemu_getrandom and ARMv8.5-RNG etc

Changes since v2: * Changes from review. - getrandom is not exclusive of /dev/urandom fallback. - vnc fails gracefully on crypto failure. - a great renaming. * Drop the "nonblock" argument, as it's not deliverable from the backend. * Propagate Error back through

[Qemu-devel] [PATCH v3 01/23] crypto: Merge crypto-obj-y into libqemuutil.a

We will shortly need this in the user-only binaries, so drop the split into system and tools binaries. This also means that crypto-aes-obj-y can be merged back into crypto-obj-y. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- Makefile | 12 +--- Makefile.objs

[Qemu-devel] [PATCH v3 06/23] crypto: Change the qcrypto_random_bytes buffer type to void*

Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c | 2 +- crypto/random-gnutls.c

[Qemu-devel] [PATCH v3 10/23] cpus: Initialize pseudo-random seeds for all guest cpus

When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created; which is a no-op unless the subsystem is in deterministic mode. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v3 03/23] crypto: Do not fail for EINTR during qcrypto_random_bytes

We can always get EINTR for read; /dev/urandom is no exception. Rearrange the order of tests for likelihood; allow degenerate buflen==0 case to perform a no-op zero-length read. This means that the normal success path is a straight line with a single test for success. Reviewed-by: Daniel P.

[Qemu-devel] [PATCH v3 11/23] linux-user: Initialize pseudo-random seeds for all guest cpus

When the -seed option is given, call qemu_guest_random_seed_main, putting the subsystem into deterministic mode. Pass derived seeds to each cpu created during clone; which is a no-op unless the subsystem is in deterministic mode. Cc: Laurent Vivier Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

Use a better interface for random numbers than rand(). Fail gracefully if for some reason we cannot use the crypto system. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is no need for deterministic results for this

[Qemu-devel] [PATCH v3 02/23] crypto: Reverse code blocks in random-platform.c

Use #ifdef _WIN32 instead of #ifndef _WIN32. This will make other tests easier to sequence. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 35 +-- 1 file changed, 17

[Qemu-devel] [PATCH v3 13/23] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM

Use a better interface for random numbers than rand * 16. Cc: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/elfload.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c

[Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed

Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/main.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index cf7095bdaf..8478306eef 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -38,6 +38,7

[Qemu-devel] [PATCH v3 16/23] aspeed/scu: Use qemu_guest_getrandom_nofail

The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Cc: qemu-...@nongnu.org Cc: Cédric Le Goater Cc: Andrew Jeffery Cc: Joel Stanley Signed-off-by:

[Qemu-devel] [PATCH v3 09/23] util: Add qemu_guest_getrandom and associated routines

This routine is intended to produce high-quality random numbers to the guest. Normally, such numbers are crypto quality from the host, but a command-line option can force the use of a fully deterministic sequence for use while debugging. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v3 15/23] linux-user: Remove srand call

We no longer use rand() within linux-user. Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 8478306eef..80cb9fdfbe 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@

[Qemu-devel] [PATCH v3 17/23] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail

The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of error_abort directly. Cc: qemu-...@nongnu.org Cc: Joel Stanley Signed-off-by: Richard Henderson --- hw/misc/nrf51_rng.c | 4 ++-- 1 file

[Qemu-devel] [PATCH v3 20/23] target/arm: Put all PAC keys into a structure

This allows us to use a single syscall to initialize them all. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 12 +++- linux-user/aarch64/cpu_loop.c | 6 +- linux-user/syscall.c | 10 +- target/arm/helper.c | 20 ++--

[Qemu-devel] [PATCH v3 14/23] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys

Use a better interface for random numbers than rand() * 3. Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/aarch64/target_syscall.h | 2 -- linux-user/aarch64/cpu_loop.c | 29 ++- linux-user/syscall.c| 31

[Qemu-devel] [PATCH v3 19/23] hw/misc/exynos4210_rng: Use qemu_guest_getrandom

The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Cc: qemu-...@nongnu.org Cc: Igor Mitsyanko Signed-off-by: Richard Henderson --- hw/misc/exynos4210_rng.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH v3 21/23] target/arm: Implement ARMv8.5-RNG

Cc: qemu-...@nongnu.org Cc: Peter Maydell Signed-off-by: Richard Henderson --- v3: Log errors with -d unimp, for lack of a better flag. --- target/arm/cpu.h| 5 + target/arm/cpu64.c | 1 + target/arm/helper.c | 44 3 files changed, 50

[Qemu-devel] [PATCH v3 18/23] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail

The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of rolling our own error handling locally. Cc: qemu-...@nongnu.org Cc: Andrew Baumann Cc: Philippe Mathieu-Daudé Signed-off-by: Richard

[Qemu-devel] [PATCH v3 23/23] target/i386: Implement CPUID_EXT_RDRAND

We now have an interface for guest visible random numbers. Cc: Paolo Bonzini Cc: Eduardo Habkost Signed-off-by: Richard Henderson --- target/i386/helper.h | 2 ++ target/i386/cpu.c| 5 ++-- target/i386/int_helper.c | 21 +++ target/i386/translate.c | 55

[Qemu-devel] [PATCH v3 22/23] target/ppc: Use qemu_guest_getrandom for DARN

We now have an interface for guest visible random numbers. Cc: qemu-...@nongnu.org Cc: David Gibson Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/target/ppc/int_helper.c

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

On Thu, 14 Mar 2019 at 20:31, Yury Kotov wrote: > > Hi, > > 14.03.2019, 14:44, "Daniel P. Berrangé" : > > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > >> On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > >> > On Tue, Mar 12, 2019 at 12:49:35PM -0400,

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

On Fri, Mar 15, 2019 at 10:46:34AM +0800, Yongji Xie wrote: > On Thu, 14 Mar 2019 at 19:18, Michael S. Tsirkin wrote: > > > > On Wed, Mar 13, 2019 at 10:47:08AM +0800, Yongji Xie wrote: > > > On Wed, 13 Mar 2019 at 09:16, Michael S. Tsirkin wrote: > > > > > > > > On Thu, Feb 28, 2019 at

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

> On Mar 15, 2019, at 02:22, Peter Maydell wrote: > > On Thu, 14 Mar 2019 at 15:57, Alex Bennée wrote: >> Testing in the Cloud >> >> >> After BuildBot went out-of-service we have been relying heavily on Travis >> as our primary CI platform. This has been creaking

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

On Thu, 14 Mar 2019 at 19:18, Michael S. Tsirkin wrote: > > On Wed, Mar 13, 2019 at 10:47:08AM +0800, Yongji Xie wrote: > > On Wed, 13 Mar 2019 at 09:16, Michael S. Tsirkin wrote: > > > > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > > From: Xie Yongji > > > > >

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

On Thu, 14 Mar 2019 19:05:06 -0400 Zhao Yan wrote: > On Fri, Mar 15, 2019 at 06:44:58AM +0800, Alex Williamson wrote: > > On Wed, 13 Mar 2019 21:12:22 -0400 > > Zhao Yan wrote: > > > > > On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > > > > On Tue, 12 Mar 2019 21:13:01

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

Hi Zoltan, On 3/14/19 11:08 PM, BALATON Zoltan wrote: > On Thu, 14 Mar 2019, Aleksandar Markovic wrote: >>> From: BALATON Zoltan >>> Subject: Data bus error with redeonfb on mips_fulong2e >>> >>> Hello, >>> >>> Trying to debug the Linux kernel oops with radeonfb I've added some more >>> debug

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

Hi Lukas, On Fri, Mar 15, 2019 at 5:01 AM Auer, Lukas wrote: > > Hi Bin, > > On Wed, 2019-03-13 at 09:51 +0800, Bin Meng wrote: > > Hi Lukas, > > > > On Tue, Mar 12, 2019 at 10:39 PM Auer, Lukas > > wrote: > > > Hi Bin, > > > > > > On Mon, 2019-03-11 at 23:28 +0800, Bin Meng wrote: > > > > Hi

Re: [Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update

Is this patch set picked up by someone? On Mon, Mar 04, 2019 at 03:16:29PM +0800, Wei Yang wrote: >The first one is suggested by Igor Mammedov to provide rule for multiline >code. > >The second is a trivial fix to make example code all indented with 4 spaces. > >v6: > * add ) for last example of

Re: [Qemu-devel] [PATCH v2 08/14] util: Add qemu_getrandom and support functions

On 3/13/19 11:55 PM, Richard Henderson wrote: > Initialize the system from system and linux-user arguments. > Propagate deterministic seeds when creating new cpu threads. > > Signed-off-by: Richard Henderson > --- > +/** > + * qemu_seedrandom_thread_part1(void) > + * > + * If qemu_getrandom is

Re: [Qemu-devel] [PULL 04/14] audio: -audiodev command line option basic implementation

On 2019-03-14 10:46, Peter Maydell wrote: > On Tue, 12 Mar 2019 at 07:13, Gerd Hoffmann wrote: >> >> From: Kővágó, Zoltán >> >> Audio drivers now get an Audiodev * as config paramters, instead of the >> global audio_option structs. There is some code in audio/audio_legacy.c >> that converts the

[Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch extract acpi_add_rom_blob() to utils.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang --- v3: * put acpi_add_rom_blob() to hw/acpi/utils.c v2: * remove unused

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

On Fri, Mar 15, 2019 at 06:44:58AM +0800, Alex Williamson wrote: > On Wed, 13 Mar 2019 21:12:22 -0400 > Zhao Yan wrote: > > > On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > > > On Tue, 12 Mar 2019 21:13:01 -0400 > > > Zhao Yan wrote: > > > > > > > hi Alex > > > > Any

Re: [Qemu-devel] [Xen-devel] Commit 331b51 breaks live migration on FreeBSD/Xen dom0

On Thu, Mar 14, 2019 at 04:07:55PM +, Igor Druzhinin wrote: > The change was supposed to be platform independent - it relies on the > fact addr argument to mmap() works as expected - mmaps at the specified > address. You have this guarantee only with MAP_FIXED flag, otherwise the addr

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

On Wed, 13 Mar 2019 21:12:22 -0400 Zhao Yan wrote: > On Thu, Mar 14, 2019 at 03:14:54AM +0800, Alex Williamson wrote: > > On Tue, 12 Mar 2019 21:13:01 -0400 > > Zhao Yan wrote: > > > > > hi Alex > > > Any comments to the sequence below? > > > > > > Actaully we have some concerns and

Re: [Qemu-devel] [PATCH 1/1] Update seabios-hppa to latest upstream

On 3/14/19 12:41 PM, Helge Deller wrote: > Hi Richard, > > On 14.03.19 16:26, Richard Henderson wrote: >> On 3/13/19 1:00 PM, Sven Schnelle wrote: >>> Signed-off-by: Sven Schnelle >>> --- >>> pc-bios/hppa-firmware.img | Bin 760040 -> 763944 bytes >>> roms/seabios-hppa | 2 +- >>> 2

Re: [Qemu-devel] [multiprocess RFC PATCH 35/37] multi-process: QMP/HMP commands to resize block device on remote process

On Thu, Mar 07, 2019 at 10:15:36AM -0600, Eric Blake wrote: > On 3/7/19 1:22 AM, elena.ufimts...@oracle.com wrote: > > From: Jagannathan Raman > > > > Adds rblock_resize QMP/HMP commands to resize block devices on the remote > > process. > > > > Signed-off-by: John G Johnson > > Signed-off-by:

Re: [Qemu-devel] [PATCH 1/2] kconfig: add CONFIG_MSI

On 3/14/19 3:30 PM, Paolo Bonzini wrote: > Not all interrupt controllers support message-signalled interrupts, > and some devices *only* support message-signalled interrupts. > > In QEMU this is represented by the "msi_nonbroken" variable. This > patch adds a new configuration symbol enabled

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

On 3/14/19 2:43 PM, Philippe Mathieu-Daudé wrote: > On 3/14/19 4:39 PM, Daniel P. Berrangé wrote: >> On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: >>> static void make_challenge(VncState *vs) >>> { >>> -int i; >>> - >>> -

Re: [Qemu-devel] [PATCH 2/2] kconfig: add dependencies on CONFIG_MSI

On 3/14/19 3:30 PM, Paolo Bonzini wrote: > For devices that require msi_init/msix_init to succeed, add a > dependency on CONFIG_MSI. This will prevent those devices from > appearing in a binary that cannot instantiate them. > > Signed-off-by: Paolo Bonzini > --- > Kconfig.host | 3 +++

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

On Thu, 14 Mar 2019, Aleksandar Markovic wrote: From: BALATON Zoltan Subject: Data bus error with redeonfb on mips_fulong2e Hello, Trying to debug the Linux kernel oops with radeonfb I've added some more debug logs and got this: radeonfb_pci_register BEGIN pci_host_data: pci_data_read:

Re: [Qemu-devel] [PATCH 2/5] trace-events: Shorten file names in comments

On 3/14/19 7:09 PM, Markus Armbruster wrote: > We spell out sub/dir/ in sub/dir/trace-events' comments pointing to > source files. That's because when trace-events got split up, the > comments were moved verbatim. > > Delete the sub/dir/ part from these comments. Gets rid of several >

Re: [Qemu-devel] [PATCH 1/5] trace-events: Consistently point to docs/devel/tracing.txt

On 3/14/19 7:09 PM, Markus Armbruster wrote: > Almost all trace-events do so in a comment right at the beginning. It was not obvious at first that "do so" means "consistently point to docs/devel/tracing.txt". > Touch up the ones that don't. > > Signed-off-by: Markus Armbruster > --- >

Re: [Qemu-devel] [PATCH v2 12/14] linux-user/aarch64: Use qemu_getrandom for arm_init_pauth_key

On 3/14/19 5:55 AM, Richard Henderson wrote: > Use a better interface for random numbers than rand * 3. > > Cc: Laurent Vivier > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/cpu_loop.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-)

Re: [Qemu-devel] Data bus error with redeonfb on mips_fulong2e

Hello, Paul, Zoltan > From: BALATON Zoltan > Subject: Data bus error with redeonfb on mips_fulong2e > > Hello, > > Trying to debug the Linux kernel oops with radeonfb I've added some more > debug logs and got this: > > radeonfb_pci_register BEGIN > pci_host_data: pci_data_read: ati-vga:

Re: [Qemu-devel] [PATCH v2 02/14] crypto: Reverse code blocks in random-platform.c

On 3/14/19 5:55 AM, Richard Henderson wrote: > Use #ifdef _WIN32 instead of #ifndef _WIN32. > This will make other tests easier to sequence. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > crypto/random-platform.c | 35

Re: [Qemu-devel] [PATCH v2 11/14] linux-user: Use qemu_getrandom for AT_RANDOM

On 3/14/19 5:55 AM, Richard Henderson wrote: > Use a better interface for random numbers than rand * 16. > > Cc: Laurent Vivier > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/linux-user/elfload.c

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

On 3/14/19 4:39 PM, Daniel P. Berrangé wrote: > On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: >> Use a better interface for random numbers than rand, >> plus some useless floating point arithmetic. >> >> Cc: Gerd Hoffmann >> Signed-off-by: Richard Henderson >> --- >> v2: Use

Re: [Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void*

On 3/14/19 5:55 AM, Richard Henderson wrote: > Using uint8_t* merely requires useless casts for use with > other types to be filled with randomness. > > Cc: Daniel P. Berrangé > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > include/crypto/random.h | 2 +- >

Re: [Qemu-devel] [PATCH V2 1/3] audio/paaudio: fix ignored buffer_length setting

Hi Martin, On 3/14/19 3:26 PM, Martin Schrodt wrote: > Audiodev configuration allows to set the length of the buffered data. The > setting was ignored and a constant value used instead. This patch makes the > code apply the setting properly. > > Signed-off-by: Martin Schrodt > --- >

Re: [Qemu-devel] [PATCH] scripts/make-release: Stop shipping u-boot source as a tarball

Hi Peter, On 3/14/19 4:56 PM, Peter Maydell wrote: > In commit d0dead3b6df7f6cd970e we changed to shipping the u-boot > sources as a tarball, to work around a problem where they > contained a file and directory that had the same name except > for case, which was preventing QEMU's source tarball

Re: [Qemu-devel] [PATCH v2 02/13] spapr/xive: add hcall support when under KVM

On 3/14/19 3:11 AM, David Gibson wrote: > On Wed, Mar 13, 2019 at 11:43:54AM +0100, Cédric Le Goater wrote: >> On 3/12/19 11:26 AM, David Gibson wrote: >>> On Mon, Mar 11, 2019 at 06:32:05PM +0100, Cédric Le Goater wrote: On 2/26/19 12:22 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at

Re: [Qemu-devel] [PATCH for-4.0] maint: Ignore built elf2dmp

On 3/13/19 3:45 PM, Eric Blake wrote: > Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it > during an in-tree build. I'd use ".gitignore" or "elf2dmp" prefix in subject rather than "maint". > > Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé > --- > > Yes, I know

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

Hi Bin, On Wed, 2019-03-13 at 09:51 +0800, Bin Meng wrote: > Hi Lukas, > > On Tue, Mar 12, 2019 at 10:39 PM Auer, Lukas > wrote: > > Hi Bin, > > > > On Mon, 2019-03-11 at 23:28 +0800, Bin Meng wrote: > > > Hi Lukas, > > > > > > On Mon, Mar 11, 2019 at 2:03 AM Auer, Lukas > > > wrote: > > > >

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

Jason Andryuk: > On Wed, Mar 13, 2019 at 11:09 AM Paul Durrant wrote: >> >>> -Original Message- >>> From: Jason Andryuk [mailto:jandr...@gmail.com] >>> Sent: 11 March 2019 18:02 >>> To: qemu-devel@nongnu.org >>> Cc: xen-de...@lists.xenproject.org; marma...@invisiblethingslab.com; Simon

Re: [Qemu-devel] [PULL 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

On Wed, Mar 13, 2019 at 7:53 AM Palmer Dabbelt wrote: > > From: Bastian Koppelmann > > Reviewed-by: Richard Henderson > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt This commit is the first bad commit in breaking 32-bit boot. It looks like the jal doesn't jump to the

[Qemu-devel] [PATCH 0/5] trace-events: Clean up

Markus Armbruster (5): trace-events: Consistently point to docs/devel/tracing.txt trace-events: Shorten file names in comments scripts/cleanup-trace-events: Update for current practice trace-events: Delete unused trace points trace-events: Fix attribution of trace points to source

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

On Thu, 14 Mar 2019 at 15:57, Alex Bennée wrote: > Testing in the Cloud > > > After BuildBot went out-of-service we have been relying heavily on Travis > as our primary CI platform. This has been creaking somewhat under the > strain and while we have a large test matrix its

Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU

On Wed, Mar 13, 2019 at 10:00:45PM +0100, Laszlo Ersek wrote: > Repo: https://github.com/lersek/qemu.git > Branch: edk2_build_v2 > > Version 1, that is: > [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU > > was posted at: >

Re: [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash

Michal Privoznik writes: > On 3/8/19 2:14 PM, Markus Armbruster wrote: >> The previous commit added a way to configure firmware with -blockdev >> rather than -drive if=pflash. Document it as the preferred way. >> >> Signed-off-by: Markus Armbruster >> --- >> docs/interop/firmware.json | 20

Re: [Qemu-devel] [PATCH v2 07/12] roms: build edk2 firmware binaries and variable store templates

On 3/14/19 7:38 PM, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 3/13/19 10:00 PM, Laszlo Ersek wrote: >> Add the "efi" target to "Makefile". >> >> Introduce "Makefile.edk2" for building and cleaning the firmware images >> and varstore templates. >> >> Collect the common bits from the

Re: [Qemu-devel] [PATCH v5 10/15] s390-bios: Support for running format-0/1 channel programs

On 03/13/2019 12:31 PM, Jason J. Herne wrote: Introduce a library function for executing format-0 and format-1 channel programs and waiting for their completion before continuing execution. Add cu_type() to channel io library. This will be used to query control unit type which is used to

Re: [Qemu-devel] [PATCH 0/2] kconfig: add fine-grained dependencies for MSI

On Thu, 14 Mar 2019 10:30:20 PDT (-0700), alistai...@gmail.com wrote: On Thu, Mar 14, 2019 at 10:09 AM Michael S. Tsirkin wrote: On Thu, Mar 14, 2019 at 03:30:30PM +0100, Paolo Bonzini wrote: > RISC-V targets did not include PCIe ports before the Kconfig transition, > and grew them

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

Jason Andryuk: > On Wed, Mar 13, 2019 at 11:09 AM Paul Durrant wrote: >> >>> -Original Message- >>> From: Jason Andryuk [mailto:jandr...@gmail.com] >>> Sent: 11 March 2019 18:02 >>> To: qemu-devel@nongnu.org >>> Cc: xen-de...@lists.xenproject.org; marma...@invisiblethingslab.com; Simon

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

Paolo Bonzini writes: > On 14/03/19 14:03, David Abdurachmanov wrote: >> Would it be enough to modify ./default-configs/riscv32-softmmu.mak by >> adding: >> >> CONFIG_PCIE_PORT=n > > The missing dependency is for any board that doesn't support MSI, not > just RISC-V. > > Note that technically

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

On Thu, 14 Mar 2019, Gerd Hoffmann wrote: I could not yet boot Linux on it but I'm interested in this machine because I want to use it to cross-check my patches so don't drop it just yet. Currently it seems to panic because of my newly added radeon emulation that I need to fix: Doesn't look

[Qemu-devel] [PATCH] test-thread-pool: be more reliable

There is a rare race between the atomic_cmpxchg and bdrv_aio_cancel/bdrv_aio_cancel_async invocations. Detect it, the only sensible we can do about it is to exit long_cb immediately. Signed-off-by: Paolo Bonzini --- tests/test-thread-pool.c | 32 +--- 1 file

Re: [Qemu-devel] [PATCH v2 11/12] Makefile: install the edk2 firmware images and their descriptors

On 3/13/19 10:00 PM, Laszlo Ersek wrote: > Decompress and install the edk2 firmware blobs as part of "make install", > unless blob installation was disabled with configure's "--disable-blobs" > option. > > Additionally, decompress the blobs as a pre-requisite for building softmmu > binaries --

Re: [Qemu-devel] [Qemu-block] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

Kevin Wolf writes: > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben: >> Patch created mechanically by rerunning: >> >> $ spatch --sp-file scripts/coccinelle/qobject.cocci \ >> --macro-file scripts/cocci-macro-file.h \ >> --dir hw/block --in-place >> >>

Re: [Qemu-devel] [PATCH 1/1] Update seabios-hppa to latest upstream

Hi Richard, On 14.03.19 16:26, Richard Henderson wrote: > On 3/13/19 1:00 PM, Sven Schnelle wrote: >> Signed-off-by: Sven Schnelle >> --- >> pc-bios/hppa-firmware.img | Bin 760040 -> 763944 bytes >> roms/seabios-hppa | 2 +- >> 2 files changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH v2 08/12] pc-bios: add edk2 firmware binaries and variable store templates

On 3/13/19 10:00 PM, Laszlo Ersek wrote: > Add the files built by the last patch: (compressed) binaries, and the > cumulative license text that covers them. > > Signed-off-by: Laszlo Ersek > --- > > Notes: > v2: > > - capture the compressed build outputs of the last patch; slightly

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

On 14/03/2019 19:22, Simon Gaiser wrote: > Jason Andryuk: >> On Wed, Mar 13, 2019 at 11:09 AM Paul Durrant >> wrote: -Original Message- From: Jason Andryuk [mailto:jandr...@gmail.com] Sent: 11 March 2019 18:02 To: qemu-devel@nongnu.org Cc:

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

On Thu, 14 Mar 2019, Gerd Hoffmann wrote: gets radeonfb going for me, on top of your i2c patches. --- hw/display/ati_int.h | 1 + hw/display/ati_regs.h | 1 + hw/display/ati.c | 35 +++ 3 files changed, 29 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 04/12] roms/edk2: advance to tag edk2-stable201903

On 3/14/19 1:02 PM, Philippe Mathieu-Daudé wrote: > On 3/13/19 10:00 PM, Laszlo Ersek wrote: >> Update the roms/edk2 submodule hash from edk2-stable201811 to >> edk2-stable201903. The release notes are available at >> . >> >> $ git

Re: [Qemu-devel] [PATCH v2 07/12] roms: build edk2 firmware binaries and variable store templates

Hi Laszlo, On 3/13/19 10:00 PM, Laszlo Ersek wrote: > Add the "efi" target to "Makefile". > > Introduce "Makefile.edk2" for building and cleaning the firmware images > and varstore templates. > > Collect the common bits from the recipes in the helper script > "edk2-build.sh". > >

Re: [Qemu-devel] [PATCH v2 12/12] MAINTAINERS: add the "EDK2 Firmware" subsystem

On 3/13/19 10:00 PM, Laszlo Ersek wrote: > We now have the edk2 submodule, somewhat elaborate build helpers for it, > and even a UEFI application written against edk2 whose genuine home is the > QEMU repository. Add the "EDK2 Firmware" subsystem such that all relevant > pathnames be covered. > >

Re: [Qemu-devel] [build-error] possible build error at the tip of the trunk? (dtc-related?)

> From: Peter Maydell > Subject: Re: [Qemu-devel] [build-error] possible build error at the tip of > > the trunk? (dtc-related?) > > On Mon, 11 Mar 2019 at 16:59, Aleksandar Markovic > wrote: > > > > Hello, all > > > > All of the sudden, the latest code doesn't build on my host: (the code > >

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

Paolo Bonzini writes: > On 14/03/19 13:16, Peter Maydell wrote: >> Mmm, that makes sense. So in this particular case, do we >> want to try to avoid doing an unbounded allocation based >> on whatever rubbish the user passed us in the environment, >> or do we say "this particular case is OK" and

[Qemu-devel] [PATCH 2/5] trace-events: Shorten file names in comments

We spell out sub/dir/ in sub/dir/trace-events' comments pointing to source files. That's because when trace-events got split up, the comments were moved verbatim. Delete the sub/dir/ part from these comments. Gets rid of several misspellings. Signed-off-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

On Wed, Mar 13, 2019 at 11:09 AM Paul Durrant wrote: > > > -Original Message- > > From: Jason Andryuk [mailto:jandr...@gmail.com] > > Sent: 11 March 2019 18:02 > > To: qemu-devel@nongnu.org > > Cc: xen-de...@lists.xenproject.org; marma...@invisiblethingslab.com; Simon > > Gaiser > > ;

[Qemu-devel] [PATCH 1/5] trace-events: Consistently point to docs/devel/tracing.txt

Almost all trace-events do so in a comment right at the beginning. Touch up the ones that don't. Signed-off-by: Markus Armbruster --- accel/kvm/trace-events | 2 +- accel/tcg/trace-events | 2 +- hw/i386/xen/trace-events | 2 ++ hw/rdma/trace-events | 2 +- hw/rdma/vmw/trace-events | 2

[Qemu-devel] [PATCH 4/5] trace-events: Delete unused trace points

Tracked down with cleanup-trace-events.pl. Funnies requiring manual post-processing: * block.c and blockdev.c trace points are in block/trace-events. * hw/block/nvme.c uses the preprocessor to hide its trace point use from cleanup-trace-events.pl. * include/hw/xen/xen_common.h trace points

[Qemu-devel] [PATCH 5/5] trace-events: Fix attribution of trace points to source

Some trace points are attributed to the wrong source file. Happens when we neglect to update trace-events for code motion, or add events in the wrong place, or misspell the file name. Clean up with help of cleanup-trace-events.pl. Same funnies as in the previous commit, of course. Manually

[Qemu-devel] [PATCH 3/5] scripts/cleanup-trace-events: Update for current practice

Emit comments with shortened file names (previous commit). Limit search to the input file's directory. Cope with properties tcg (commit b2b36c22bd8) and vcpu (commit 3d211d9f4db). Cope with capital letters in function names. Signed-off-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH v2 01/14] crypto: Merge crypto-obj-y into libqemuutil.a

On Thu, Mar 14, 2019 at 10:54:49AM -0700, Richard Henderson wrote: > On 3/14/19 8:43 AM, Daniel P. Berrangé wrote: > > I think this needs to replace test-crypto-obj-y with test-util-obj-y > > in tests/Makefile.include too > > test-crypto-obj-y = $(authz-obj-y) $(crypto-obj-y) $(test-qom-obj-y)

Re: [Qemu-devel] [PATCH v2 04/12] roms/edk2: advance to tag edk2-stable201903

On 3/13/19 10:00 PM, Laszlo Ersek wrote: > Update the roms/edk2 submodule hash from edk2-stable201811 to > edk2-stable201903. The release notes are available at > . > > $ git shortlog edk2-stable201811..edk2-stable201903 BTW this

Re: [Qemu-devel] [PATCH v2 01/14] crypto: Merge crypto-obj-y into libqemuutil.a

On 3/14/19 8:43 AM, Daniel P. Berrangé wrote: > I think this needs to replace test-crypto-obj-y with test-util-obj-y > in tests/Makefile.include too test-crypto-obj-y = $(authz-obj-y) $(crypto-obj-y) $(test-qom-obj-y) While I could replace crypto-obj-y with test-util-obj-y: test-util-obj-y =

Re: [Qemu-devel] [Qemu-arm] [PATCH] Check access permission to ADDVL/ADDPL/RDVL

On Thu, 14 Mar 2019 at 17:44, Eric Blake wrote: > > On 3/14/19 12:34 PM, Richard Henderson wrote: > > On 3/14/19 10:21 AM, Peter Maydell wrote: > >> Richard, Amir -- it looks like you both sent exactly the > >> same patch at pretty much exactly the same time. Any > >> preferences for whose

Re: [Qemu-devel] [Qemu-arm] [PATCH] Check access permission to ADDVL/ADDPL/RDVL

On 3/14/19 12:34 PM, Richard Henderson wrote: > On 3/14/19 10:21 AM, Peter Maydell wrote: >> Richard, Amir -- it looks like you both sent exactly the >> same patch at pretty much exactly the same time. Any >> preferences for whose version I apply ? :-) >> >> thanks >> -- PMM > > Hah. Bit of

  1   2   3   4   >