[Qemu-devel] [PATCH RFC V1] Header cleanups for functions declared in utils/ files

2019-03-31 Thread Aruna Jayasena
>From 7de901601673a212a84c895998daed89a2f85601 Mon Sep 17 00:00:00 2001 From: Aruna Jayasena Date: Mon, 1 Apr 2019 10:27:42 +0530 Subject: [PATCH 1/2] Header cleanups Declarations were moved out of qemu-common.h for functions declared in utils/ files --- include/qemu-common.h| 6 --

[Qemu-devel] [PATCH RFC] Header cleanups for functions declared in utils/ files

2019-03-31 Thread Aruna Jayasena
>From d34c4a45de91eadf2a6e98fd54aa86df11997fa2 Mon Sep 17 00:00:00 2001 From: Archfx Date: Mon, 1 Apr 2019 11:01:22 +0530 Subject: [PATCH 2/2] Header cleanups Declarations were moved out of qemu-common.h for functions declared in utils/ files Signed-off-by: Aruna Jayasena ---

[Qemu-devel] [PATCH] hw/char: Move multi-serial devices into separate file

2019-03-31 Thread Thomas Huth
In our downstream distribution of QEMU, we'd like to ship the binary without the multi-serial PCI devices. To make this disablement easier, let's move the devices into a separate file and add a proper Kconfig- switch for these devices. Signed-off-by: Thomas Huth --- I've forgot to Cc:

Re: [Qemu-devel] Pentium Pro Feature Bugs

2019-03-31 Thread Thomas Huth
On 01/04/2019 05.36, tedheadster wrote: > I just noticed this in the code regarding MMX and I wonder if it is correct: > > target/i386/cpu.c: > > #define PPRO_FEATURES (CPUID_FP87 | CPUID_DE | CPUID_PSE | CPUID_TSC | \ > CPUID_MSR | CPUID_MCE | CPUID_CX8 | CPUID_PGE | CPUID_CMOV | \ >

Re: [Qemu-devel] [PATCH v2 2/2] util: readline: replace tab indent by four spaces to fix checkpatch errors

2019-03-31 Thread Thomas Huth
On 01/04/2019 04.44, Jules Irenge wrote: > Replace tab indent by four spaces to fix errors issued by checkpatch.pl tool > "ERROR: code indent should never use tabs" within "util/readline.c" file. > > Signed-off-by: Jules Irenge > --- > util/readline.c | 98

Re: [Qemu-devel] [PATCH v2 1/2] util/readline: add a space to fix errors by checkpatch tool

2019-03-31 Thread Thomas Huth
On 01/04/2019 04.44, Jules Irenge wrote: > util/readline: add a space to fix errors reported by checkpatch.pl tool > "ERROR: space required before the open parenthesis" > "ERROR: space required after that ..." > within "util/redline.c" file > > Signed-off-by: Jules Irenge > --- >

[Qemu-devel] Pentium Pro Feature Bugs

2019-03-31 Thread tedheadster
I just noticed this in the code regarding MMX and I wonder if it is correct: target/i386/cpu.c: #define PPRO_FEATURES (CPUID_FP87 | CPUID_DE | CPUID_PSE | CPUID_TSC | \ CPUID_MSR | CPUID_MCE | CPUID_CX8 | CPUID_PGE | CPUID_CMOV | \ CPUID_PAT | CPUID_FXSR | CPUID_MMX |

[Qemu-devel] [PATCH for-4.1 8/8] target/riscv: Remove spaces from register names

2019-03-31 Thread Richard Henderson
These extra spaces make the "-d op" dump look weird. Signed-off-by: Richard Henderson --- target/riscv/cpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d61bce6d55..624528efb5 100644 --- a/target/riscv/cpu.c

[Qemu-devel] [PATCH for-4.1 6/8] target/riscv: Split RVC32 and RVC64 insns into separate files

2019-03-31 Thread Richard Henderson
This eliminates all functions in insn_trans/trans_rvc.inc.c, so the entire file can be removed. Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvc.inc.c | 115 target/riscv/translate.c| 2 - target/riscv/Makefile.objs |

[Qemu-devel] [PATCH for-4.1 7/8] target/riscv: Split gen_arith_imm into functional and temp

2019-03-31 Thread Richard Henderson
The tcg_gen_fooi_tl functions have some immediate constant folding built in, which match up with some of the riscv asm builtin macros, like mv and not. Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvi.inc.c | 14 +++--- target/riscv/translate.c| 19

[Qemu-devel] [PATCH for-4.1 2/8] target/riscv: Use --static-decode for decodetree

2019-03-31 Thread Richard Henderson
The generated functions are only used within translate.c and do not need to be global, or declared. Signed-off-by: Richard Henderson --- target/riscv/translate.c | 2 -- target/riscv/Makefile.objs | 8 2 files changed, 4 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH for-4.1 4/8] target/riscv: Merge argument decode for RVC shifti

2019-03-31 Thread Richard Henderson
Special handling for IMM==0 is the only difference between RVC shifti and RVI shifti. This can be handled with !function. Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_rvc.inc.c | 47 - target/riscv/translate.c| 6

[Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of insn32 formats

2019-03-31 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/riscv/insn32.decode | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 6f3ab7aa52..77f794ed70 100644 --- a/target/riscv/insn32.decode +++

[Qemu-devel] [PATCH for-4.1 0/8] target/riscv: decodetree improvments

2019-03-31 Thread Richard Henderson
There's new support in decodetree for pattern groups. I believe that patch 5, or something close to it, was posted as an RFC as part of the original pattern group patch set, but this cleans that up further. r~ Richard Henderson (8): target/riscv: Name the argument sets for all of insn32

Re: [Qemu-devel] [PATCH] migration: remove not used field xfer_limit

2019-03-31 Thread Wei Yang
On Wed, Mar 27, 2019 at 08:24:21PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> Remove this unnecessary field. >> >> Signed-off-by: Wei Yang > >Nice; I think that field has been

Re: [Qemu-devel] [PATCH v2 0/2] util/readline: errors clean-ups

2019-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190401024406.10819-1-jbi.oct...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190401024406.10819-1-jbi.oct...@gmail.com Subject: [Qemu-devel] [PATCH v2 0/2] util/readline:

Re: [Qemu-devel] [PATCH 4/9] cpu/topology: add ARM support for smp machine properties

2019-03-31 Thread Like Xu
On 2019/3/29 17:27, Alex Bennée wrote: Like Xu writes: Signed-off-by: Like Xu --- hw/arm/fsl-imx6.c | 5 + hw/arm/fsl-imx6ul.c| 5 + hw/arm/fsl-imx7.c | 5 + hw/arm/highbank.c | 1 + hw/arm/mcimx6ul-evk.c | 1 + hw/arm/mcimx7d-sabre.c | 3 +++

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-03-31 Thread Peter Xu
On Sun, Mar 31, 2019 at 11:15:00AM +, Elijah Shakkour wrote: [...] > I didn't have DMA nor MMIO read/write working with my old command line. > But, when I removed all CPU flags and only provided "-cpu host", I see that > MMIO works. > Still, DMA read/write from emulated device doesn't work

[Qemu-devel] [PATCH v2 2/2] util: readline: replace tab indent by four spaces to fix checkpatch errors

2019-03-31 Thread Jules Irenge
Replace tab indent by four spaces to fix errors issued by checkpatch.pl tool "ERROR: code indent should never use tabs" within "util/readline.c" file. Signed-off-by: Jules Irenge --- util/readline.c | 98 - 1 file changed, 49 insertions(+), 49

[Qemu-devel] [PATCH v2 1/2] util/readline: add a space to fix errors by checkpatch tool

2019-03-31 Thread Jules Irenge
util/readline: add a space to fix errors reported by checkpatch.pl tool "ERROR: space required before the open parenthesis" "ERROR: space required after that ..." within "util/redline.c" file Signed-off-by: Jules Irenge --- util/readline.c | 34 +- 1 file

[Qemu-devel] [PATCH v2 0/2] util/readline: errors clean-ups

2019-03-31 Thread Jules Irenge
This v2 version combines two fix of errors into one and replace tab indent by four spaces Jules Irenge (2): util/readline: add a space to fix errors by checkpatch tool util: readline: replace tab indent by four spaces to fix checkpatch errors util/readline.c | 132

Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/9] cpu/topology: add ARM support for smp machine properties

2019-03-31 Thread Like Xu
On 2019/3/29 19:20, Philippe Mathieu-Daudé wrote: Le ven. 29 mars 2019 10:27, Alex Bennée a écrit : Like Xu writes: Signed-off-by: Like Xu --- hw/arm/fsl-imx6.c | 5 + hw/arm/fsl-imx6ul.c| 5 + hw/arm/fsl-imx7.c | 5 + hw/arm/highbank.c | 1 +

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-03-31 Thread Zhao Yan
On Sat, Mar 30, 2019 at 10:14:07PM +0800, Alex Williamson wrote: > On Fri, 29 Mar 2019 19:10:50 -0400 > Zhao Yan wrote: > > > On Fri, Mar 29, 2019 at 10:26:39PM +0800, Alex Williamson wrote: > > > On Thu, 28 Mar 2019 22:47:04 -0400 > > > Zhao Yan wrote: > > > > > > > On Fri, Mar 29, 2019 at

Re: [Qemu-devel] [PATCH 7/9] cpu/topology: add riscv support for smp machine properties

2019-03-31 Thread Like Xu
On 2019/3/30 7:01, Alistair Francis wrote: On Fri, Mar 29, 2019 at 1:59 AM Like Xu wrote: Signed-off-by: Like Xu --- hw/openrisc/openrisc_sim.c | 1 + hw/riscv/sifive_e.c| 4 hw/riscv/sifive_plic.c | 3 +++ hw/riscv/sifive_u.c| 4 hw/riscv/spike.c

Re: [Qemu-devel] [PATCH 1/9] cpu/topology: add struct CpuTopology to MachineState

2019-03-31 Thread Like Xu
On 2019/3/29 17:22, Alex Bennée wrote: Like Xu writes: Signed-off-by: Like Xu --- include/hw/arm/virt.h | 2 +- include/hw/boards.h | 8 include/sysemu/sysemu.h | 2 +- vl.c| 7 ++- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Replace calls to object_child_foreach() with object_child_foreach_recursive()

2019-03-31 Thread Ernest Esene
On Fri, Mar 29, 2019 at 10:47:22AM +, Stefan Hajnoczi wrote: > On Tue, Mar 26, 2019 at 10:12:56AM +0100, Paolo Bonzini wrote: > > On 26/03/19 08:43, Stefan Hajnoczi wrote: > > > On Sun, Mar 10, 2019 at 02:39:13AM +0100, Ernest Esene wrote: > > >> Replace calls to object_child_foreach() with >

[Qemu-devel] Want to contribute in this project.

2019-03-31 Thread amit kumar rathore
Hey I’m 2nd year (I.T) student from NIT SRINAGAR .I want to work on QEMU .So please guide me and where I can start to contributing. I am good in c language .I’m serious to this project . Sent from Mail for Windows 10

Re: [Qemu-devel] Options for 4.0 (was: [PATCH 1/2] qmp: Add query-qemu-features)

2019-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/87y34v42z0.fsf...@dusky.pond.sub.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 87y34v42z0.fsf...@dusky.pond.sub.org Subject: [Qemu-devel] Options for 4.0 (was: [PATCH 1/2] qmp: Add

[Qemu-devel] Options for 4.0 (was: [PATCH 1/2] qmp: Add query-qemu-features)

2019-03-31 Thread Markus Armbruster
Let's review our options for 4.0. Please note my analysis is handicapped by incomplete information, in particular on libvirt's needs. Terminology: * "Hard read-write" semantics: open read/write. * "Hard read-only" semantics: open read-only. * "Dynamic read-only" semantics: open read-only,

Re: [Qemu-devel] [PATCH for-4.1] block: Use bdrv_unref_child() for all children in bdrv_close()

2019-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019033747.14685-1-be...@igalia.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time

[Qemu-devel] [PATCH for-4.1] block: Use bdrv_unref_child() for all children in bdrv_close()

2019-03-31 Thread Alberto Garcia
bdrv_unref_child() does the following things: - Updates the child->bs->inherits_from pointer. - Calls bdrv_detach_child() to remove the BdrvChild from bs->children. - Calls bdrv_unref() to unref the child BlockDriverState. When bdrv_unref_child() was introduced in commit 33a604075c it was

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-03-31 Thread Elijah Shakkour
> -Original Message- > From: Peter Xu > Sent: Wednesday, March 27, 2019 10:43 AM > To: Knut Omang > Cc: Elijah Shakkour ; Michael S. Tsirkin > ; Alex Williamson ; > Marcel Apfelbaum ; Stefan Hajnoczi > ; qemu-devel@nongnu.org > Subject: Re: QEMU and vIOMMU support for emulated VF

Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition

2019-03-31 Thread Alberto Garcia
On Tue 05 Mar 2019 04:55:56 PM CET, Marc-André Lureau wrote: > Hi > > On Tue, Mar 5, 2019 at 4:52 PM Alberto Garcia wrote: >> >> ping > > I can queue this in the next chardev PR. This can probably wait until > the softfreeze though. I think Paolo had some plans to look at chardev > issues. I

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Saner printing of large file sizes

2019-03-31 Thread Alberto Garcia
On Sat 30 Mar 2019 04:07:02 PM CET, Eric Blake wrote: > Disk sizes close to INT64_MAX cause overflow, for some pretty > ridiculous output: > > $ ./nbdkit -U - memory size=$((2**63 - 512)) --run 'qemu-img info $nbd' > image: nbd+unix://?socket=/tmp/nbdkitHSAzNz/socket > file format: raw >

[Qemu-devel] [PATCH] Add coroutine_fn to bdrv_check_co_entry

2019-03-31 Thread n . alekseev2104
From: nickaleks bdrv_check_co_entry calls bdrv_co_check, which is a coroutine function. Thus, it also needs to be marked as a coroutine. Signed-off-by: Nikita Alekseev --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index