On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Fairly easy as only 128-bit handling is required. Simply perform the
> subtraction and then subtract the borrow.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 27
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Let's keep it simple for now and handle 8/16/128 bit elements via helpers.
> Especially for 8/16, we could come up with some bit tricks.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 3 +++
>
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> We can use tcg_gen_sub2_i64() to do 128-bit subtraction and otherwise
> existing gvec helpers.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 17 +
> 2
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Similar to VECTOR SHIFT RIGHT ARITHMETICAL.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 1 +
> target/s390x/insn-data.def | 4
> target/s390x/translate_vx.inc.c | 17 +
>
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Similar to VECTOR SHIFT LEFT ARITHMETIC. Add s390_vec_sar() similar to
> s390_vec_shr().
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 1 +
> target/s390x/insn-data.def | 4
>
Laszlo Ersek writes:
> On 04/12/19 19:49, Markus Armbruster wrote:
>> Laszlo Ersek writes:
>>
>>> On 04/11/19 15:56, Markus Armbruster wrote:
The ARM virt machines put firmware in flash memory. To configure it,
you use -drive if=pflash,unit=0,... and optionally -drive
Thomas Huth writes:
> On 12/04/2019 18.02, Peter Maydell wrote:
>> On Fri, 12 Apr 2019 at 16:26, Thomas Huth wrote:
>>>
>>> These machines depend on the deprecated bluetooth subsystem. In case we
>>> finally decide to remove the bluetooth subsystem, we likely need to
>>> remove the n800 and
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> The previous commits have eliminated fprintf_function outside
>> disassemblers, simplifying code and cleaning up the ugly type-punning
>> fprintf_function seems to attract. Move fprintf_function to
>>
Add a new base CPU model called 'Dhyana' to model processors from Hygon
Dhyana(family 18h), which derived from AMD EPYC(family 17h).
The following features bits have been removed compare to AMD EPYC:
aes, pclmulqdq, sha_ni
The Hygon Dhyana support to KVM in Linux is already accepted upstream[1].
Anyone else has a similar problem?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1824053
Title:
Qemu-img convert appears to be stuck on aarch64 host with low
probability
Status in QEMU:
New
Patchew URL:
https://patchew.org/QEMU/20190413011302.6610-1-jbi.oct...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190413011302.6610-1-jbi.oct...@gmail.com
Subject: [Qemu-devel] [PATCH v4 0/3] target/mips: Errors
Wrap lines to fix errors issued by checkpatch.pl tool
"ERROR: line over 90 characters"
within "target/mips/cpu.h" file.
Signed-off-by: Jules Irenge
---
target/mips/cpu.h | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/target/mips/cpu.h
Add or remove space to fix errors issued by checkpatch.pl tool
"ERROR: spaces required around that..."
"ERROR: space required after that..."
"ERROR: space required before the open parenthesis"
"ERROR: space required after that..."
"ERROR: space prohibited between function name and open
Realign comments to fix warnings issued by checkpatc.pl tool
"WARNING: Block comments use a leading /* on a separate line"
within "target/mips/cpu.h" file.
Signed-off-by: Jules Irenge
---
target/mips/cpu.h | 34 ++
1 file changed, 22 insertions(+), 12
This v4 series combines two previously distinct patches into one patch
replace tab code indent patch and the add or rmove space into
one patch add or remove space patch.
Jules Irenge (3):
target/mips: add or remove space to fix checkpatch errors
target/mips: realign comments to fix
On 11.04.19 16:33, Vladimir Sementsov-Ogievskiy wrote:
> 10.04.2019 23:57, Max Reitz wrote:
>> This adds a salvaging mode (--salvage) to qemu-img convert which ignores
>> read errors and treats the respective areas as containing only zeroes.
>> This can be used for instance to at least partially
On 11.04.19 16:23, Alberto Garcia wrote:
> Hi,
>
> Patch 1 is the fix for the bug reported by Max here:
>
>https://lists.gnu.org/archive/html/qemu-block/2019-04/msg00293.html
>
> Patch 2 fixes a different (but slightly related) issue that I found
> while preparing the first patch.
I think
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +static DisasJumpType op_vsldb(DisasContext *s, DisasOps *o)
> +{
> +int src_idx = get_field(s->fields, i4) & 0xf;
> +
> +if (src_idx == 0) {
> +gen_gvec_mov(get_field(s->fields, v1), get_field(s->fields, v2));
> +} else {
> +
On 11.04.19 15:41, Alberto Garcia wrote:
> On Wed 10 Apr 2019 07:03:50 PM CEST, Max Reitz wrote:
>>> +# hd0 has no backing file: we can omit the 'backing' option
>>> +self.reopen(opts)
>>
>> [...]
>>
>>> +# Detach hd2 from hd0.
>>> +self.reopen(opts, {'backing':
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> We can reuse the existing 128-bit shift utility function.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 1 +
> target/s390x/insn-data.def | 4
> target/s390x/translate_vx.inc.c | 20
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Only for one special case we can reuse real gvec helpers. Mostly
> rely on oom helpers.
>
> One important thing to take care of is always to properly mask of
> unused bits from the shift count.
>
> Signed-off-by: David Hildenbrand
> ---
>
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +static void gen_rim_i32(TCGv_i32 d, TCGv_i32 a, TCGv_i32 b, int32_t c)
> +{
> +TCGv_i32 t0 = tcg_temp_new_i32();
> +TCGv_i32 t1 = tcg_temp_new_i32();
> +
> +tcg_gen_andc_i32(t0, a, b);
> +tcg_gen_rotli_i32(t1, a, c & 31);
> +
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +#define DEF_ROTL(BITS)
> \
> +static uint##BITS##_t rotl##BITS(uint##BITS##_t a, uint8_t count)
> \
> +{
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Again, vector enhancements facility 1 material.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 7 +++
> 2 files changed, 9 insertions(+)
Reviewed-by: Richard Henderson
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Similar to VECTOR COUNT TRAILING ZEROES.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 2 ++
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 19 +++
>
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Reuse a gvec helper.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 7 +++
> 2 files changed, 9 insertions(+)
Reviewed-by: Richard Henderson
r~
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 7 +++
> 2 files changed, 9 insertions(+)
Reviewed-by: Richard Henderson
r~
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Again, part of vector enhancement facility 1. The operation corresponds
> to an bitwise equality check.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 7 +++
> 2 files
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Part of vector enhancements facility 1, but easy to implement.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate.c| 1 +
> target/s390x/translate_vx.inc.c | 7 +++
> 3 files
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +static void gen_mh_i32(TCGv_i32 d, TCGv_i32 a, TCGv_i32 b)
> +{
> +TCGv_i64 t0 = tcg_temp_new_i64();
> +TCGv_i64 t1 = tcg_temp_new_i64();
> +
> +tcg_gen_ext_i32_i64(t0, a);
> +tcg_gen_ext_i32_i64(t1, b);
> +tcg_gen_mul_i64(t0,
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Quite some variants to handle. At least handle some 32-bit element
> variants via gvec expansion (we could also handle 16/32-bit variants
> for ODD and EVEN easily via gvec expansion, but let's keep it simple
> for now).
>
> Signed-off-by: David
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Luckily, we already have gvec helpers for all four cases.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 8
> target/s390x/translate_vx.inc.c | 31 +++
> 2 files changed, 39
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Similar to VECTOR LOAD COMPLEMENT but unfortunately we don't have a
> gvec helper.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 2 ++
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c |
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> We can reuse an existing gvec helper for negating the values.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 17 +
> 2 files changed, 19 insertions(+)
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> A galois field multiplication in field 2 is like binary multiplication,
> however instead of doing ordinary binary additions, xor's are performed.
> So no carries are considered.
>
> Implement all variants via helpers. s390_vec_sar() and
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Easy, we can reuse an existing gvec helper.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 7 +++
> 2 files changed, 9 insertions(+)
Reviewed-by: Richard Henderson
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +s390_vec_write_element##BITS(v1, i, ctz32(a));
>
Wrong result for a == 0. You need a ? ctz32(a) : BITS.
r~
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> For 8/16, use the 32 bit variant and properly subtract the added
> leading zero bits.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 2 ++
> target/s390x/insn-data.def | 2 ++
>
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> To carry out the comparison, we can reuse the existing gvec comparison
> function. In case the CC is to be computed, save the result vector
> and compute the CC lazily. The result is a vector consisting of all 1's
> for elements that matched and 0's
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> + es | logical ? 0 : MO_SIGN);
Incorrect operator precedence. You need:
es | (logical ? 0 : MO_SIGN)
or
logical ? es : es | MO_SIGN
And perhaps cse this expression into a temporary
and not replicate it between the
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +read_vec_element_i32(sum, get_field(s->fields, v3), 1, ES_32);
> +for (i = 0; i < 4; i++) {
> +read_vec_element_i32(tmp, get_field(s->fields, v2), i, ES_32);
> +tcg_gen_add_i32(sum, sum, tmp);
> +
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Similar to VECTOR AVERAGE but without sign extension.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/helper.h | 2 ++
> target/s390x/insn-data.def | 2 ++
> target/s390x/translate_vx.inc.c | 48
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +}
> +static DisasJumpType op_vavg(DisasContext *s, DisasOps *o)
> +{
Watch your spacing.
> +static const GVecGen3 g[4] = {
> +{ .fno = gen_helper_gvec_vavg8, },
> +{ .fno = gen_helper_gvec_vavg16, },
> +{ .fni4 =
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> Easy, as we can reuse existing gvec helpers.
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 4
> target/s390x/translate_vx.inc.c | 14 ++
> 2 files changed, 18 insertions(+)
Reviewed-by: Richard
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +static DisasJumpType op_vaccc(DisasContext *s, DisasOps *o)
> +{
> +if (get_field(s->fields, m5) != ES_128) {
> +gen_program_exception(s, PGM_SPECIFICATION);
> +return DISAS_NORETURN;
> +}
> +
> +
I actually missed this. I just added it to for-next on
github.com/palmer-dabbelt.
Thanks for the ping!
On Fri, 12 Apr 2019 14:23:42 PDT (-0700), alistai...@gmail.com wrote:
On Fri, Apr 12, 2019 at 2:15 PM Jonathan Behrens wrote:
Just to double check, nothing further on this is need from
On 4/11/19 12:07 AM, David Hildenbrand wrote:
> Only slightly ugly, perform two additions. At least it is only supported
> for 128 bit elements.
>
> Introduce gen_gvec128_4_i64() similar to gen_gvec128_3_i64().
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/insn-data.def | 2
On 04/12/19 19:49, Markus Armbruster wrote:
> Laszlo Ersek writes:
>
>> On 04/11/19 15:56, Markus Armbruster wrote:
>>> The ARM virt machines put firmware in flash memory. To configure it,
>>> you use -drive if=pflash,unit=0,... and optionally -drive
>>> if=pflash,unit=1,...
>>>
>>> Why two
On Fri, Apr 12, 2019 at 2:15 PM Jonathan Behrens wrote:
>
> Just to double check, nothing further on this is need from me, right? It is
> set to be merged onto the master branch once the 4.0 release is out?
Thanks for checking!
Yep you don't need to do anything, Palmer will merge it in the
On Fri, Apr 12, 2019 at 1:36 AM Igor Mammedov wrote:
>
> On Thu, 11 Apr 2019 13:42:20 -0700
> Alistair Francis wrote:
>
> > On Thu, Apr 11, 2019 at 5:18 AM Igor Mammedov wrote:
> > >
> > > On Wed, 10 Apr 2019 23:10:25 +
> > > Alistair Francis wrote:
> > >
> > > > If a user specifies a CPU
Dr. David Alan Gilbert, le ven. 12 avril 2019 16:49:42 +0100, a ecrit:
> * Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> > Hello,
> >
> > Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit:
> > > 'soread' has the comment:
> > >
> > > /*
> > > * No need to
Just to double check, nothing further on this is need from me, right? It is
set to be merged onto the master branch once the 4.0 release is out?
Jonathan
On Wed, Apr 3, 2019 at 7:11 PM Alistair Francis
wrote:
> On Mon, Apr 1, 2019 at 1:39 PM Jonathan Behrens
> wrote:
> >
> > The 'sfence.vma'
AIX 5.1 expects the base year to be 1900. Adjust accordingly.
Signed-off-by: Artyom Tarasenko
---
hw/isa/i82378.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index a5d67bc..546c928 100644
--- a/hw/isa/i82378.c
+++ b/hw/isa/i82378.c
@@
Performing a complete flush is ~ 100 times faster than flushing
256MiB of 4KiB pages. Set a limit of 1024 pages and perform a complete
flush afterwards.
This patch significantly speeds up AIX 5.1 and NetBSD-ofppc.
Signed-off-by: Artyom Tarasenko
---
target/ppc/mmu_helper.c | 7 +++
1 file
On 4/11/19 12:07 AM, David Hildenbrand wrote:
> +static const GVecGen3 g[5] = {
> +{ .fni8 = gen_acc8_i64, },
> +{ .fni8 = gen_acc16_i64, },
> +{ .fni8 = gen_acc32_i64, },
> +{ .fni8 = gen_acc_i64, },
> +{ .fno = gen_helper_gvec_vacc128, },
> +};
Signed-off-by: Artyom Tarasenko
---
hw/pci-host/prep.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 8b9e1fd..94b7465 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -62,6 +62,7 @@ typedef struct
AIX/PReP does access to the aliased IO registers of 53810.
Implement aliasing to make the AIX driver work.
Signed-off-by: Artyom Tarasenko
---
hw/scsi/lsi53c895a.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/hw/scsi/lsi53c895a.c
This series makes various fixes for the -M 40p target.
Particularly now it's possible to boot AIX 5.1 (both from a cdrom
and a hard disk).
The OFW image:
https://github.com/artyom-tarasenko/openfirmware/releases/download/20190406-AIX-boots/q40pofw-serial.rom
The command line:
qemu-system-ppc -M
On Fri, Apr 05, 2019 at 02:41:17PM +0800, Wei Yang wrote:
> Here is two simple change related to select_machine()
>
> [1]: make find_default_machine() local since no one outside file use it
> [2]: allocate TYPE_MACHINE list only once to select machine type
> [3]: cleanup after previous commit
>
On Mon, Apr 08, 2019 at 07:26:16AM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Fri, Apr 05, 2019 at 07:22:35PM -0400, Michael S. Tsirkin wrote:
> >> On Fri, Apr 05, 2019 at 09:56:29AM +0100, Dr. David Alan Gilbert wrote:
> >> > * Jens Freimann (jfreim...@redhat.com) wrote:
Currently mcounteren.TM acts as though it is hardwired to zero, even though
QEMU
allows it to be set. This change resolves the issue by allowing reads to the
time and timeh control registers when running in a privileged mode where
such
accesses are allowed.
Signed-off-by: Jonathan Behrens
---
On 12/04/2019 18.02, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 16:26, Thomas Huth wrote:
>>
>> These machines depend on the deprecated bluetooth subsystem. In case we
>> finally decide to remove the bluetooth subsystem, we likely need to
>> remove the n800 and n810 machines, too, so mark them
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Fri, Apr 12, 2019 at 12:13:51PM -0500, Eric Blake wrote:
> > On 4/12/19 7:20 AM, Yury Kotov wrote:
> > > Hi,
> > >
> > > I've added 'inline-fd:' proto to simplify migration to/from fd.
> > > I thought about modifying the existing 'fd:' proto
On Thu, Apr 11, 2019 at 12:56:55PM +0200, Cornelia Huck wrote:
> On Thu, 11 Apr 2019 03:28:46 -0700 (PDT)
> no-re...@patchew.org wrote:
>
> > === OUTPUT BEGIN ===
> > ERROR: spaces required around that '=' (ctx:WxV)
> > #58: FILE: hw/i386/pc.c:118:
> > +GlobalProperty pc_compat_4_0[] ={};
> >
On Thu, Apr 11, 2019 at 12:20:25PM +0200, Cornelia Huck wrote:
> Add 4.1 machine types for arm/i440fx/q35/s390x/spapr.
>
> Signed-off-by: Cornelia Huck
Thanks!
Reviewed-by: Eduardo Habkost
I'm queueing it on machine-next.
--
Eduardo
* Markus Armbruster (arm...@redhat.com) wrote:
> The previous commits have eliminated fprintf_function outside
> disassemblers, simplifying code and cleaning up the ugly type-punning
> fprintf_function seems to attract. Move fprintf_function to
> include/disas/dis-asm.h to reduce the temptation
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
> The old -realtime mlock=on|off parameter does exactly the same as the
> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
> does not activate any additional "realtime" capabilities as the name
> might indicate. We
On 4/12/19 3:47 AM, Paolo Bonzini wrote:
> On 10/04/19 20:26, Cole Robinson wrote:
>> On 11/20/18 6:44 AM, Dr. David Alan Gilbert wrote:
>>> * Paolo Bonzini (pbonz...@redhat.com) wrote:
Nested VMX does not support live migration yet. Add a blocker
until that is worked out.
On 4/11/19 12:07 AM, David Hildenbrand wrote:
> Introduce two types of fancy new helpers that will be reused a couple of
> times
>
> 1. gen_gvec_fn_3: Call an existing tcg_gen_gvec_X function with 3
>parameters, simplifying parameter passing
> 2. gen_gvec128_3_i64: Call a function that
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> dump_drift_info() takes an fprintf()-like callback and a FILE * to
>
> ^^^ looks like the wrong function for this patch?
Pasto, will fix.
>> pass to it, and so do its helper functions. Passing
On 12/04/2019 18.21, Philippe Mathieu-Daudé wrote:
> On 4/12/19 5:26 PM, Thomas Huth wrote:
>> These machines depend on the deprecated bluetooth subsystem. In case we
>> finally decide to remove the bluetooth subsystem, we likely need to
>> remove the n800 and n810 machines, too, so mark them now
Cole Robinson writes:
> This gives us the consistent 'Error:' prefix added in 66363e9a43f,
> which helps users like libvirt who still need to scrape hmp error
> messages to detect failure.
>
> Signed-off-by: Cole Robinson
> ---
> hmp.c | 7 ---
> 1 file changed, 4 insertions(+), 3
On 4/12/19 10:55 AM, Eric Blake wrote:
> On 4/12/19 7:21 AM, Kevin Wolf wrote:
>> Am 10.04.2019 um 20:27 hat Eric Blake geschrieben:
>>> On 4/10/19 1:03 PM, Cole Robinson wrote:
This gives us the consistent 'Error:' prefix added in 66363e9a43f,
which helps users like libvirt who still
* Markus Armbruster (arm...@redhat.com) wrote:
> INIT_DISASSEMBLE_INFO() takes an fprintf()-like callback and a FILE *
> to pass to it. monitor_disas() passes monitor_fprintf() and the
> current monitor cast to FILE *. monitor_fprintf() casts it right
> back, and is otherwise identical to
* Markus Armbruster (arm...@redhat.com) wrote:
> bdrv_snapshot_dump(), bdrv_image_info_specific_dump(),
> bdrv_image_info_dump() and their helpers take an fprintf()-like
> callback and a FILE * to pass to it.
>
> hmp.c passes monitor_printf() cast to fprintf_function and the current
> monitor
* Markus Armbruster (arm...@redhat.com) wrote:
> Code that doesn't want to know about current monitor vs. stdout
> vs. stderr takes an fprintf_function callback and a FILE * argument to
> pass to it. Actual arguments are either fprintf() and stdout or
> stderr, or monitor_fprintf() and the
* Markus Armbruster (arm...@redhat.com) wrote:
> CPUClass method dump_statistics() takes an fprintf()-like callback and
> a FILE * to pass to it.
>
> Its only caller hmp_info_cpustats() (via cpu_dump_statistics()) passes
> monitor_fprintf() and the current monitor cast to FILE *.
>
* Markus Armbruster (arm...@redhat.com) wrote:
> x86_cpu_dump_local_apic_state() takes an fprintf()-like callback and a
> FILE * to pass to it, and so do its helper functions.
>
> Its only caller hmp_info_local_apic() passes monitor_fprintf() and the
> current monitor cast to FILE *.
Laszlo Ersek writes:
> On 04/11/19 15:56, Markus Armbruster wrote:
>> The ARM virt machines put firmware in flash memory. To configure it,
>> you use -drive if=pflash,unit=0,... and optionally -drive
>> if=pflash,unit=1,...
>>
>> Why two -drive? This permits setting up one part of the flash
* Markus Armbruster (arm...@redhat.com) wrote:
> dump_drift_info() takes an fprintf()-like callback and a FILE * to
^^^ looks like the wrong function for this patch?
> pass to it, and so do its helper functions. Passing around callback
> and argument is rather tiresome.
>
> Its
* Markus Armbruster (arm...@redhat.com) wrote:
> qsp_report() takes an fprintf()-like callback and a FILE * to pass to
> it.
>
> Its only caller hmp_sync_profile() passes monitor_fprintf() and the
> current monitor cast to FILE *. monitor_fprintf() casts it right
> back, and is otherwise
On Fri, Apr 12, 2019 at 12:13:51PM -0500, Eric Blake wrote:
> On 4/12/19 7:20 AM, Yury Kotov wrote:
> > Hi,
> >
> > I've added 'inline-fd:' proto to simplify migration to/from fd.
> > I thought about modifying the existing 'fd:' proto but I'm not sure it's a
> > good idea to change it's contract.
* Markus Armbruster (arm...@redhat.com) wrote:
> dump_drift_info() takes an fprintf()-like callback and a FILE * to pass
> to it.
Me thinks there's a pattern here
> Its only caller hmp_info_jit() passes monitor_fprintf() and a Monitor
> * cast to FILE *. monitor_fprintf() casts it right
On 4/12/19 7:20 AM, Yury Kotov wrote:
> Hi,
>
> I've added 'inline-fd:' proto to simplify migration to/from fd.
> I thought about modifying the existing 'fd:' proto but I'm not sure it's a
> good idea to change it's contract.
>
> Existing 'fd:' proto works with previously added fd by getfd or
* Markus Armbruster (arm...@redhat.com) wrote:
> dump_opcount_info() takes an fprintf()-like callback and a FILE * to
> pass to it.
>
> Its only caller hmp_info_opcount() passes monitor_fprintf() and the
> current monitor cast to FILE *. monitor_fprintf() casts it right
> back, and is otherwise
* Markus Armbruster (arm...@redhat.com) wrote:
> dump_exec_info() takes an fprintf()-like callback and a FILE * to pass
> to it.
>
> Its only caller hmp_info_jit() passes monitor_fprintf() and the
> current monitor cast to FILE *. monitor_fprintf() casts it right
> back, and is otherwise
This commit finally deletes "hw/devices.h".
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/gumstix.c | 2 +-
hw/arm/integratorcp.c | 2 +-
hw/arm/mainstone.c | 2 +-
hw/arm/realview.c | 2 +-
hw/arm/versatilepb.c | 2
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4_boards.c | 3 ++-
hw/arm/mps2-tz.c | 3 ++-
hw/net/lan9118.c | 1 -
include/hw/net/lan9118.h | 2 ++
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/arm/exynos4_boards.c
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 1 +
hw/arm/nseries.c | 1 +
hw/misc/cbus.c | 2 +-
include/hw/devices.h | 14 --
include/hw/misc/cbus.h | 32
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
v3:
Drop "Gamepad devices that have nowhere better to go" comment (Markus)
---
MAINTAINERS| 1 +
hw/arm/stellaris.c | 2 +-
hw/input/stellaris_input.c | 2 +-
include/hw/devices.h | 3 ---
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/kzm.c | 2 +-
hw/arm/mps2.c| 2 +-
hw/arm/realview.c| 1 +
hw/arm/vexpress.c| 2 +-
hw/net/lan9118.c | 2 +-
include/hw/devices.h | 3 ---
* Markus Armbruster (arm...@redhat.com) wrote:
> st_print_trace_file_status() takes an fprintf()-like callback and a
> FILE * to pass to it.
>
> Its only caller hmp_trace_file() passes monitor_fprintf() and the
> current monitor cast to FILE *. monitor_fprintf() casts it right
> back, and is
No code used the tc6393xb_gpio_in_get() and tc6393xb_gpio_out_set()
functions since their introduction in commit 88d2c950b002. Time to
remove them.
Suggested-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/tc6393xb.c | 16
include/hw/devices.h | 3
Add an entries the Blizzard device in MAINTAINERS.
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 ++
hw/arm/nseries.c | 1 +
hw/display/blizzard.c | 2 +-
include/hw/devices.h
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/net/ne2000-isa.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/hw/net/ne2000-isa.h b/include/hw/net/ne2000-isa.h
index ff2bed9c95d..527337c4548 100644
---
Since uWireSlave is only used in this new header, there is no
need to expose it via "qemu/typedefs.h".
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
v3:
Drop "TI 4/8-wire resistive touch screen converters" comment (Markus)
---
MAINTAINERS| 2 ++
Reviewed-by: Thomas Huth
Reviewed-by: Cédric Le Goater
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 996812498dc..1c23ebd9925
Hi,
As his first comment describes itself, the "hw/devices.h" contains
declarations for "Devices that have nowhere better to go."
This series remove it, creating new headers for devices covered there.
MAINTAINERS is updated.
I also included 2 cleanups while working on this, in "qemu/typedefs.h"
Suggested-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/nseries.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 906b7ca22d4..2b710c3d49f 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -31,6 +31,7
Reviewed-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
hw/arm/tosa.c | 2 +-
hw/display/tc6393xb.c | 2 +-
include/hw/devices.h | 6 --
include/hw/display/tc6393xb.h | 24
5
1 - 100 of 277 matches
Mail list logo
