Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-04-25 Thread Thomas Huth
On 26/04/2019 00.55, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 4/19/19 9:56 AM, Thomas Huth wrote: >> First patch fixes a problem with ohci_die(), second patch moves PCI code into >> a separate file, so that the sysbus OHCI device can also be used without >> the dependency on the PCI

Re: [Qemu-devel] [PATCH v2 2/5] linux-user: Add support for the SIOCSPGRP ioctl

2019-04-25 Thread Max Filippov
On Wed, Apr 24, 2019 at 5:58 AM Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > Add support for setting the process (or process group) to receive SIGIO > or SIGURG signals when I/O becomes possible or urgent data is available, > using SIOCSPGRP ioctl. > > The ioctl numeric values

Re: [Qemu-devel] [PATCH v2 1/5] linux-user: Fix support for the SIOCATMARK and SIOCGPGRP ioctls for eXtensa

2019-04-25 Thread Max Filippov
On Wed, Apr 24, 2019 at 5:57 AM Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fix support for the SIOCATMARK and SIOCGPGRP ioctls for eXtensa by xtensa is the official name of this architecture, please fix the spelling here... > correcting corresponding macro definition. > >

[Qemu-devel] [PATCH v7 6/6] xfs: disable map_sync for async flush

2019-04-25 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta --- fs/xfs/xfs_file.c | 9 ++--- 1 file changed, 6

[Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported

2019-04-25 Thread Pankaj Gupta
This patch introduces 'daxdev_mapping_supported' helper which checks if 'MAP_SYNC' is supported with filesystem mapping. It also checks if corresponding dax_device is synchronous. Virtio pmem device is asynchronous and does not not support VM_SYNC. Suggested-by: Jan Kara Signed-off-by: Pankaj

[Qemu-devel] [PATCH v7 2/6] virtio-pmem: Add virtio pmem driver

2019-04-25 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into

[Qemu-devel] [PATCH v7 0/6] virtio pmem driver

2019-04-25 Thread Pankaj Gupta
This patch series has implementation for "virtio pmem". "virtio pmem" is fake persistent memory(nvdimm) in guest which allows to bypass the guest page cache. This also implements a VIRTIO based asynchronous flush mechanism. Sharing guest kernel driver in this patchset with the changes

[Qemu-devel] [PATCH v7 04/21] gdbstub: Implement continue (c pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c47ef7dd9c..89f1ab6524 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1522,6 +1522,16 @@ static void handle_thread_alive(GdbCmdContext

[Qemu-devel] [PATCH v7 5/6] ext4: disable map_sync for async flush

2019-04-25 Thread Pankaj Gupta
Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta Reviewed-by: Jan Kara --- fs/ext4/file.c | 10 ++

[Qemu-devel] [PATCH v7 08/21] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 36c7353a22..b42425b24c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1611,6 +1611,29 @@ static void

[Qemu-devel] [PATCH v7 3/6] libnvdimm: add dax_dev sync flag

2019-04-25 Thread Pankaj Gupta
This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +-

[Qemu-devel] [PATCH v7 10/21] gdbstub: Implement get register (p pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 10e3f12a68..e9a3d0c2bc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1655,6 +1655,36 @@ static void

[Qemu-devel] [PATCH v7 1/6] libnvdimm: nd_region flush callback support

2019-04-25 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to host over VIRTIO. We are registering a callback based on 'nd_region' type. virtio_pmem driver requires this special flush function. For rest of the region types we are registering existing flush function. Report error returned by host

[Qemu-devel] [PATCH v7 15/21] gdbstub: Implement file io (F pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3478ac778d..9fe130f30d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1772,6 +1772,39 @@ static void

[Qemu-devel] [PATCH v7 01/21] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..d5e0f3878a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res; }

[Qemu-devel] [PATCH v7 00/21] gdbstub: Refactor command packets handler

2019-04-25 Thread Jon Doron
This patch series refactors the old gdbstub command packets handler with a new infrastructure which should ease extending and adding new and missing gdb command packets. version 7 changes: - Fixed few checkpatch complaints - Feedback from Alex Bennee version 4-6 changes: - mostly feedback from

[Qemu-devel] [PATCH v7 02/21] gdbstub: Implement deatch (D pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 90 ++- 1 file changed, 50 insertions(+), 40 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d5e0f3878a..621d689868 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1418,11 +1418,6 @@ static inline int

[Qemu-devel] [PATCH v7 18/21] gdbstub: Implement generic query (q pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 327 ++ 1 file changed, 327 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d56d0fd235..83ae8738cc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1915,6 +1915,323 @@ static void

[Qemu-devel] [PATCH v7 03/21] gdbstub: Implement thread_alive (T pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 621d689868..c47ef7dd9c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1498,6 +1498,30 @@ static void

[Qemu-devel] [PATCH v7 07/21] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 21cdaf4678..36c7353a22 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1588,6 +1588,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx,

[Qemu-devel] [PATCH v7 09/21] gdbstub: Implement set register (P pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b42425b24c..10e3f12a68 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1634,6 +1634,27 @@ static void

[Qemu-devel] [PATCH v7 05/21] gdbstub: Implement continue with signal (C pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 89f1ab6524..469aaeb875 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1532,6 +1532,21 @@ static void handle_continue(GdbCmdContext

[Qemu-devel] [PATCH v7 11/21] gdbstub: Implement write memory (M pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e9a3d0c2bc..8dc2e1d507 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1685,6 +1685,31 @@ static void

[Qemu-devel] [PATCH v7 19/21] gdbstub: Implement generic set (Q pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 213 +++--- 1 file changed, 25 insertions(+), 188 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 83ae8738cc..2fd0d66f4d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1130,14 +1130,6 @@ static

[Qemu-devel] [PATCH v7 21/21] gdbstub: Clear unused variables in gdb_handle_packet

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index d678191705..8bdfae4b29 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2259,17 +2259,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void

[Qemu-devel] [PATCH v7 13/21] gdbstub: Implement write all registers (G pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index daa602edc3..adfe39b3a3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1734,6 +1734,29 @@ static void

[Qemu-devel] [PATCH v7 12/21] gdbstub: Implement read memory (m pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8dc2e1d507..daa602edc3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1710,6 +1710,30 @@ static void

[Qemu-devel] [PATCH v7 06/21] gdbstub: Implement set_thread (H pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 469aaeb875..21cdaf4678 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1547,6 +1547,47 @@ static void

[Qemu-devel] [PATCH v7 20/21] gdbstub: Implement target halted (? pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2fd0d66f4d..d678191705 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2239,13 +2239,30 @@ static void

[Qemu-devel] [PATCH v7 17/21] gdbstub: Implement v commands with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9b0556f8be..d56d0fd235 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1815,6 +1815,106 @@ static void

[Qemu-devel] [PATCH v7 16/21] gdbstub: Implement step (s pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9fe130f30d..9b0556f8be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext

[Qemu-devel] [PATCH v7 14/21] gdbstub: Implement read all registers (g pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index adfe39b3a3..3478ac778d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1757,6 +1757,21 @@ static void

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Jon Doron
Hi Alex, Thank you for your comments I will add a cover-letter and update it with the review changes, as for what I'm was hoping to add later on is mostly custom query commands for KVM perhaps might apply to other architectures as well here are things i had mind: 1. Get VM nested state, this way

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Jon Doron
Thank you Alex I will publish v8 with fixes from your review :) please see my comments below On Thu, Apr 25, 2019 at 5:42 PM Alex Bennée wrote: > > > ari...@gmail.com writes: > > > From: Jon Doron > > > > Signed-off-by: Jon Doron > > --- > > gdbstub.c | 215

[Qemu-devel] [Bug 1826422] Re: Regression: QEMU 4.0 hangs the host (*bisect included*)

2019-04-25 Thread Alex Williamson
Not just NVIDIA, forcing a NIC to use INTx also fails and it's apparent from the host that the device is stuck with DisINTx+. Looks like the resampling mechanism that allows KVM to unmask the interrupt is broken with split irqchip. -- You received this bug notification because you are a member

[Qemu-devel] [PATCH] migration/colo.h: Remove obsolete codes

2019-04-25 Thread Zhang Chen
From: Zhang Chen Signed-off-by: Zhang Chen --- include/migration/colo.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h index ddebe0ad27..f6fbe23ec9 100644 --- a/include/migration/colo.h +++ b/include/migration/colo.h @@ -22,8 +22,6 @@

[Qemu-devel] [PATCH] migration/colo.c: Remove redundant input parameter

2019-04-25 Thread Zhang Chen
From: Zhang Chen The colo_do_failover no need the input parameter. Signed-off-by: Zhang Chen --- include/migration/colo.h | 2 +- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/migration/colo.h

[Qemu-devel] [Bug 1826422] Re: Regression: QEMU 4.0 hangs the host (*bisect included*)

2019-04-25 Thread Alex Williamson
This seems related to INTx (legacy) interrupt mode, which NVIDIA GeForce will use by default. Using regedit in a Windows VM or adjusting nvidia.ko module parameters of a Linux VM can enable the driver to use MSI, which seems unaffected. We also have the vfio-pci device option x -no-kvm-intx=on,

[Qemu-devel] [PATCH] memory: correct the comment to DIRTY_MEMORY_MIGRATION

2019-04-25 Thread Wei Yang
The dirty bit is DIRTY_MEMORY_MIGRATION. Correct the comment. Signed-off-by: Wei Yang --- memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index e49369d85d..9d015bfe4c 100644 --- a/memory.c +++ b/memory.c @@ -2576,7 +2576,7 @@ void

Re: [Qemu-devel] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-25 Thread Yan Zhao
On Wed, Apr 24, 2019 at 05:10:43PM +0800, Christophe de Dinechin wrote: > > > > On 23 Apr 2019, at 12:39, Daniel P. Berrangé wrote: > > > > On Fri, Apr 19, 2019 at 04:35:04AM -0400, Yan Zhao wrote: > >> device version attribute in mdev sysfs is used by user space software > >> (e.g. libvirt)

Re: [Qemu-devel] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-25 Thread Yan Zhao
On Wed, Apr 24, 2019 at 10:14:50PM +0800, Alex Williamson wrote: > On Tue, 23 Apr 2019 23:39:34 -0400 > Yan Zhao wrote: > > > On Tue, Apr 23, 2019 at 11:02:56PM +0800, Alex Williamson wrote: > > > On Tue, 23 Apr 2019 01:41:57 -0400 > > > Yan Zhao wrote: > > > > > > > On Tue, Apr 23, 2019 at

Re: [Qemu-devel] Booting from a Bootcamp partition

2019-04-25 Thread Programmingkid
> On Apr 15, 2019, at 2:35 PM, John Snow wrote: > > > > On 4/15/19 6:23 AM, Programmingkid wrote: >> >>> On Apr 15, 2019, at 5:54 AM, Stefan Hajnoczi wrote: >>> >>> On Sun, Apr 14, 2019 at 07:33:17PM -0400, Programmingkid wrote: Hi I was wondering if anyone has been able to boot from

Re: [Qemu-devel] [PATCH] target/riscv: Expose time CSRs when allowed by [m|s]counteren

2019-04-25 Thread Jonathan Behrens
No, I've still been meaning to send it. After thinking about this some more I realized that it didn't actually make sense for the CLINT to decide the timer frequency and that it should instead be a property of the board itself. I got a bit sidetracked in the process of making those changes, but I

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 05:55:15PM -0300, Daniel Henrique Barboza wrote: > > >On 4/23/19 9:46 PM, Wei Yang wrote: >> migration_is_blocked() is used in migrate_prepare() and >> save_snapshot(), this is more proper to use this instead of >> qemu_savevm_state_blocked() in qemu_loadvm_state(). > >

Re: [Qemu-devel] [PATCH 1/4] migration/savevm: remove duplicate check of migration_is_blocked

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 04:20:57PM -0300, Daniel Henrique Barboza wrote: > > >On 4/23/19 9:46 PM, Wei Yang wrote: >> Current call flow of save_snapshot is: >> >>save_snapshot >> migration_is_blocked >>qemu_savevm_state >> migration_is_blocked >> >> Since

[Qemu-devel] [PATCH v15 0/2] support MAP_SYNC for memory-backend-file

2019-04-25 Thread Wei Yang
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at

[Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-25 Thread Wei Yang
From: Zhang Yi When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Current, We have below different

[Qemu-devel] [PATCH v15 2/2] docs: Added MAP_SYNC documentation

2019-04-25 Thread Wei Yang
From: Zhang Yi Signed-off-by: Zhang Yi Signed-off-by: Wei Yang Reviewed-by: Stefan Hajnoczi Reviewed-by: Pankaj Gupta Reviewed-by: Michael S. Tsirkin --- docs/nvdimm.txt | 22 +++--- qemu-options.hx | 5 + 2 files changed, 24 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 00/29] Kconfig dependencies for ARM machines

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > This series reworks the default-configs/arm-softmmu.mak and > default-configs/aarch64-softmmu.mak files to use the new Kconfig-style > dependencies instead. > > Some of the patches are slightly based on the work by Ákos Kovács: > >

Re: [Qemu-devel] [PATCH] ati-vga: Fix check for blt outside vram

2019-04-25 Thread BALATON Zoltan
On Sun, 14 Apr 2019, BALATON Zoltan wrote: On Tue, 9 Apr 2019, Philippe Mathieu-Daudé wrote: This patch looks 4.0 worthwhile. Now that it seems we'll have another rc, will this get in? Gerd, I think you have to send a pull request with it for that. Ping? This has missed two rc-s. This

Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] Fix ohci_die() and move PCI code to separate file

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Thomas, On 4/19/19 9:56 AM, Thomas Huth wrote: > First patch fixes a problem with ohci_die(), second patch moves PCI code into > a separate file, so that the sysbus OHCI device can also be used without > the dependency on the PCI code. > > v2: Split the patch into two patches, one for the

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 09/29] hw/arm: Express dependencies of the OMAP machines with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/18/19 8:00 PM, Thomas Huth wrote: > Add Kconfig dependencies for the OMAP machines (cheetah, n800, n810, > sx1 and sx1-v1). > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase

2019-04-25 Thread x00249684
Hi Igor, +static void test_acpi_virt_tcg(void) +{ +test_data data = { +.machine = "virt", +.uefi_fl1 = "pc-bios/edk2-aarch64-code.fd", +.uefi_fl2 = "pc-bios/edk2-arm-vars.fd", +.cd = "tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2", +

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 11/29] hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 24 - > hw/arm/Kconfig

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 19/29] hw/arm: Express dependencies of the MPS2 boards with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/18/19 8:00 PM, Thomas Huth wrote: > Add Kconfig dependencies for the mps2-an* machines. > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 20 +--- > hw/arm/Kconfig | 18 ++ > 2 files changed, 19 insertions(+), 19

Re: [Qemu-devel] [PATCH 4/4] migration/savevm: wrap into qemu_loadvm_state_header()

2019-04-25 Thread Daniel Henrique Barboza
On 4/23/19 9:47 PM, Wei Yang wrote: On source side, we have qemu_savevm_state_header() to send related data, while on the receiving side those steps are scattered in qemu_loadvm_state(). This patch wrap those related steps into qemu_loadvm_state_header() to make it friendly to read.

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-04-25 Thread Stefan Ring
There seems to be more confusion of the sort. This fixes it for me: --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -10226,7 +10226,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1, return -TARGET_EFAULT; }

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 28/29] hw/arm: Express dependencies of the musca machines with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/18/19 8:00 PM, Thomas Huth wrote: > Dependencies have been determined with trial-and-error and by > looking at the musca.c source file. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > hw/arm/Kconfig | 9 ++--- > 1 file changed, 6 insertions(+), 3

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 8:07 PM, Philippe Mathieu-Daudé wrote: > Hi Peter, Stefan, > > On 1/4/19 4:16 PM, Peter Maydell wrote: >> On Thu, 3 Jan 2019 at 14:41, Stefan Hajnoczi wrote: >>> >>> This reverts commit 01fd41ab3fb69971c24a69ed49cde96086d81278. >>> >>> The generic loader device (-device

Re: [Qemu-devel] [PATCH] target/riscv: Expose time CSRs when allowed by [m|s]counteren

2019-04-25 Thread Palmer Dabbelt
On Fri, 19 Apr 2019 16:05:35 PDT (-0700), alistai...@gmail.com wrote: On Mon, Apr 15, 2019 at 5:46 PM Jonathan Behrens wrote: For any chip that has a CLINT, we want the frequency of the time register and the frequency of the CLINT to match. That frequency, SIFIVE_CLINT_TIMEBASE_FREQ

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 10/29] hw/arm: Express dependencies of stellaris with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > This patch is slightly based on earlier work by Ákos Kovács (i.e. > his "hw/arm/Kconfig: Add ARM Kconfig" patch). > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 7 +-- > hw/arm/Kconfig | 10

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 25/29] hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/18/19 8:00 PM, Thomas Huth wrote: > Add Kconfig dependencies for the NRF51 / microbit machine. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > default-configs/arm-softmmu.mak | 3 +-- > hw/arm/Kconfig | 6 ++ > hw/arm/Makefile.objs

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 17/29] hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/18/19 8:00 PM, Thomas Huth wrote: > Netduino only depends on the stm32f205 SoC which in turn depends on > its components. > > Reviewed-by: Alistair Francis > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > default-configs/arm-softmmu.mak | 9 + >

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-04-25 Thread Daniel Henrique Barboza
On 4/23/19 9:46 PM, Wei Yang wrote: migration_is_blocked() is used in migrate_prepare() and save_snapshot(), this is more proper to use this instead of qemu_savevm_state_blocked() in qemu_loadvm_state(). migration_is_blocked() does an additional verification: "if (migration_blockers)"

Re: [Qemu-devel] [PATCH 1/2] fixup! target/riscv: Name the argument sets for all of insn32 formats

2019-04-25 Thread Alistair Francis
On Thu, Apr 25, 2019 at 10:28 AM Richard Henderson wrote: > > --- > target/riscv/translate.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) Not sure how this will work with a fixup, but still: Reviewed-by: Alistair Francis Alistair > > diff --git

[Qemu-devel] [Bug 1826422] Re: Regression: QEMU 4.0 hangs the host (*bisect included*)

2019-04-25 Thread Saverio Miroddi
> Does adding "kernel_irqchip=on" to the comma separated list of options for -machine resolve it? Yes, that solved it, thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1826422 Title:

Re: [Qemu-devel] [PATCH 0/4] Remove some qdev_get_machine() calls from CONFIG_USER_ONLY

2019-04-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190425200051.19906-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190425200051.19906-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] Remove some

[Qemu-devel] [PATCH 0/4] Remove some qdev_get_machine() calls from CONFIG_USER_ONLY

2019-04-25 Thread Eduardo Habkost
This series moves some qdev code outside qdev.o, so it can be compiled only in CONFIG_SOFTMMU. The code being moved includes two qdev_get_machine() calls, so this will make it easier to move qdev_get_machine() to CONFIG_SOFTMMU later. After this series, there's one remaining qdev_get_machine()

[Qemu-devel] [PATCH 2/4] move qdev hotplug code to qdev-hotplug.c

2019-04-25 Thread Eduardo Habkost
The qdev hotplug code is used only in softmmu mode, so move it to a separate file so we can eventually avoid compiling it in user-only mode. Signed-off-by: Eduardo Habkost --- hw/core/bus.c | 11 --- hw/core/qdev-hotplug.c | 69 ++

[Qemu-devel] [PATCH 4/4] qdev-hotplug: Don't check type of qdev_get_machine()

2019-04-25 Thread Eduardo Habkost
Now that qdev_get_machine_hotplug_handler() is only compiled in softmmu mode, we don't need to check if qdev_gt_machine() is really of type TYPE_MACHINE. Signed-off-by: Eduardo Habkost --- hw/core/qdev-hotplug.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] qdev: Don't compile hotplug code in user-mode emulation

2019-04-25 Thread Eduardo Habkost
Move qdev-hotplug.o and hotplug.o to CONFIG_SOFTMMU because the code is not necessary for *-user. Provide a few stubs in qdev-hotplug-stubs.c to replace initialization functions that are called from qdev.c. Signed-off-by: Eduardo Habkost --- hw/core/qdev-hotplug-stubs.c | 44

[Qemu-devel] [PATCH 1/4] machine: Move gpio code to hw/core/gpio.c

2019-04-25 Thread Eduardo Habkost
Only softmmu code uses gpio, so move gpio code from qdev.c to gpio.c and compile it only on softmmu mode. Signed-off-by: Eduardo Habkost --- hw/core/gpio.c| 206 ++ hw/core/qdev.c| 184 -

Re: [Qemu-devel] [PATCH 1/4] migration/savevm: remove duplicate check of migration_is_blocked

2019-04-25 Thread Daniel Henrique Barboza
On 4/23/19 9:46 PM, Wei Yang wrote: Current call flow of save_snapshot is: save_snapshot migration_is_blocked qemu_savevm_state migration_is_blocked Since qemu_savevm_state is only called in save_snapshot, this means migration_is_blocked has been already checked. I

Re: [Qemu-devel] [PATCH] target/riscv: Remove unused include of riscv_htif.h for virt board

2019-04-25 Thread Palmer Dabbelt
On Wed, 10 Apr 2019 09:29:11 PDT (-0700), finte...@gmail.com wrote: Unless I'm missing something, the virt board doesn't support HTIF and should not be including this header. Jonathan Signed-off-by: Jonathan Behrens --- hw/riscv/virt.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Qemu-devel] [PULL 3/4] Categorize devices: iommu

2019-04-25 Thread Eduardo Habkost
From: Ernest Esene Set category and description for iommu devices. Signed-off-by: Ernest Esene Message-Id: <20190327170518.GA16887@erokenlabserver> Reviewed-by: Eduardo Habkost [ehabkost: edited commit message] Signed-off-by: Eduardo Habkost --- hw/i386/amd_iommu.c | 2 ++

[Qemu-devel] [PULL 1/4] i386: Add new Hygon 'Dhyana' CPU model

2019-04-25 Thread Eduardo Habkost
From: Pu Wen Add a new base CPU model called 'Dhyana' to model processors from Hygon Dhyana(family 18h), which derived from AMD EPYC(family 17h). The following features bits have been removed compare to AMD EPYC: aes, pclmulqdq, sha_ni The Hygon Dhyana support to KVM in Linux is already

[Qemu-devel] [PULL 2/4] Categorize devices: IGD passthrough ISA bridge

2019-04-25 Thread Eduardo Habkost
From: Ernest Esene Set category for the device. Signed-off-by: Ernest Esene Message-Id: <20190327133714.GA9329@erokenlabserver> Reviewed-by: Eduardo Habkost [ehabkost: edited commit message] Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PULL 4/4] Pass through cache information for TOPOEXT CPUs

2019-04-25 Thread Eduardo Habkost
From: Stanislav Lanci Signed-off-by: Stanislav Lanci Message-Id: <20190416123833.60649-1-p...@polepetko.eu> [ehabkost: removed redundant comment line] Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/i386/cpu.c

[Qemu-devel] [PULL 0/4] x86 queue, 2019-04-25

2019-04-25 Thread Eduardo Habkost
The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' into staging (2019-04-24 13:19:41 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH 0/5] tests/vm: Python 3, improve image caching, and misc

2019-04-25 Thread Wainer dos Santos Moschetta
Hi Laszlo, On 04/24/2019 06:07 AM, Laszlo Ersek wrote: Hello Wainer, (answering because I dislike ignoring emails without giving any feedback:) I appreciated that! thanks! On 04/23/19 21:28, Wainer dos Santos Moschetta wrote: Ping. More reviews needed. I've already got Philippe's

[Qemu-devel] [PULL 08/11] util/mmap-alloc: Add a 'is_pmem' parameter to qemu_ram_mmap

2019-04-25 Thread Eduardo Habkost
From: Zhang Yi besides the existing 'shared' flags, we are going to add 'is_pmem' to qemu_ram_mmap(), which indicated the memory backend file is a persist memory. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi Reviewed-by: Pankaj Gupta Message-Id:

Re: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Peter, Stefan, On 1/4/19 4:16 PM, Peter Maydell wrote: > On Thu, 3 Jan 2019 at 14:41, Stefan Hajnoczi wrote: >> >> This reverts commit 01fd41ab3fb69971c24a69ed49cde96086d81278. >> >> The generic loader device (-device loader,file=kernel.bin) can be used >> to load a kernel instead of the

[Qemu-devel] [PULL 06/11] cpu: Rename parse_cpu_model() to parse_cpu_option()

2019-04-25 Thread Eduardo Habkost
The "model[,option...]" string parsed by the function is not just a CPU model. Rename the function and its argument to indicate it expects the full "-cpu" option to be provided. Signed-off-by: Eduardo Habkost Message-Id: <20190417025944.16154-2-ehabk...@redhat.com> Reviewed-by: David Gibson

[Qemu-devel] [PULL 10/11] linux-headers: add linux/mman.h.

2019-04-25 Thread Eduardo Habkost
From: Zhang Yi Update it to 4.20-rc1 Signed-off-by: Zhang Yi Message-Id: Signed-off-by: Eduardo Habkost --- linux-headers/asm-arm/mman.h | 4 + linux-headers/asm-arm64/mman.h | 1 + linux-headers/asm-generic/hugetlb_encode.h | 36 +++

[Qemu-devel] [PULL 11/11] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-25 Thread Eduardo Habkost
From: Zhang Yi When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Current, We have below different

[Qemu-devel] [PULL 05/11] vl: Simplify machine_parse()

2019-04-25 Thread Eduardo Habkost
From: Markus Armbruster Exploit that argument @name is nerver null. Check is_help_option() first, because that's what we do elsewhere. If we (foolishly!) defined a machine named "help", -machine help would now print help instead of selecting the machine named "help". Signed-off-by: Markus

[Qemu-devel] [PULL 04/11] vl: Clean up after previous commit

2019-04-25 Thread Eduardo Habkost
From: Markus Armbruster Since the previous commit, find_machine() and find_default_machine() don't have to deallocate on return. This permits further simplifications. Signed-off-by: Markus Armbruster Reviewed-by: Wei Yang Message-Id: <20190405064121.23662-4-richardw.y...@linux.intel.com>

[Qemu-devel] [PULL 03/11] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-25 Thread Eduardo Habkost
From: Wei Yang Now all the functions used to select machine is local and the call flow looks like below: select_machine() find_default_machine() machine_parse() find_machine() All these related function will need a GSList for TYPE_MACHINE. Currently we allocate

[Qemu-devel] [PULL 07/11] cpu: Fix crash with empty -cpu option

2019-04-25 Thread Eduardo Habkost
Fix the following crash: $ qemu-system-x86_64 -cpu '' qemu-system-x86_64: qom/cpu.c:291: cpu_class_by_name: \ Assertion `cpu_model && cc->class_by_name' failed. Regression test script included. Fixes: 99193d8f2ef5 ("cpu: drop unnecessary NULL check and cpu_common_class_by_name()")

[Qemu-devel] [PULL 09/11] scripts/update-linux-headers: add linux/mman.h

2019-04-25 Thread Eduardo Habkost
From: Zhang Yi Add linux/mman.h,asm/mman.h,asm/mman-common.h to linux-headers, So we can use more mmap2 flags. Signed-off-by: Zhang Yi Message-Id: Signed-off-by: Eduardo Habkost --- scripts/update-linux-headers.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 01/11] hw: add compat machines for 4.1

2019-04-25 Thread Eduardo Habkost
From: Cornelia Huck Add 4.1 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck Message-Id: <20190411102025.22559-1-coh...@redhat.com> Acked-by: Greg Kurz Acked-by: David Gibson Signed-off-by: Eduardo Habkost --- include/hw/boards.h| 3 +++

[Qemu-devel] [PULL 02/11] vl.c: make find_default_machine() local

2019-04-25 Thread Eduardo Habkost
From: Wei Yang Function find_default_machine() is introduced by commit 2c8cffa599b7 "vl: make find_default_machine externally visible", and it was used outside of vl.c until commit a904410af5f1 "pc_sysfw: remove the rom_only property". Commit a904410af5f1 "pc_sysfw: remove the rom_only

[Qemu-devel] [PULL 00/11] Machine queue, 2019-04-25

2019-04-25 Thread Eduardo Habkost
The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' into staging (2019-04-24 13:19:41 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH v2 0/3] vhost-scsi: Support migration

2019-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2019 at 09:38:19AM +0100, Stefan Hajnoczi wrote: > On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: > > > > > > > On 18 Apr 2019, at 12:41, Stefan Hajnoczi wrote: > > > > > > On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: > > >> Hi, > > >> > > >> This

Re: [Qemu-devel] [PATCH v3 2/2] core/qdev: refactor qdev_get_machine() with type assertion

2019-04-25 Thread Eduardo Habkost
On Thu, Apr 25, 2019 at 11:12:29AM +0800, Like Xu wrote: > On 2019/4/25 1:21, Eduardo Habkost wrote: [...] > > > > I think we all agree that qdev_get_machine() should eventually be > > available in softmmu only. > > I think we need to make it happen to avoid calling qdev_get_machine() > in

Re: [Qemu-devel] [PATCH 3/3] qmp: Add deprecation information to query-machines

2019-04-25 Thread Eduardo Habkost
On Thu, Apr 25, 2019 at 11:54:34AM -0300, Wainer dos Santos Moschetta wrote: > Hi Eduardo, > > On 04/23/2019 06:22 PM, Eduardo Habkost wrote: [...] > > +class QueryMachines(Test): > > +def test(self): > > I suggest to use a meaning test case name as it will be displayed with > Avocado

Re: [Qemu-devel] [PATCH 1/3] qapi: SupportStatusInfo struct

2019-04-25 Thread Eduardo Habkost
On Thu, Apr 25, 2019 at 11:20:58AM -0300, Wainer dos Santos Moschetta wrote: > Hi Eduardo, > > > On 04/23/2019 06:22 PM, Eduardo Habkost wrote: > > This struct will be used to represent support and deprecation > > status of QEMU features. > > > > Signed-off-by: Eduardo Habkost > > --- > >

Re: [Qemu-devel] [PATCH 2/2] target/riscv: Add checks for several RVC reserved operands

2019-04-25 Thread Richard Henderson
On 4/25/19 10:26 AM, Richard Henderson wrote: > { > + illegal 011 0 - 0 01 # c.addi16sp, RES nzimm=0 >addi011 . 00010 . 01 @c_addi16sp >lui 011 . . . 01 @c_lui > } Bah. I just realized the comment should be more like #

[Qemu-devel] [PATCH 1/2] fixup! target/riscv: Name the argument sets for all of insn32 formats

2019-04-25 Thread Richard Henderson
--- target/riscv/translate.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index d1f599a92d..009c146e8f 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -713,12 +713,19 @@ static bool

[Qemu-devel] [PATCH 2/2] target/riscv: Add checks for several RVC reserved operands

2019-04-25 Thread Richard Henderson
C.ADDI16SP, C.LWSP, C.JR, C.ADDIW, C.LDSP all have reserved operands that were not diagnosed. Signed-off-by: Richard Henderson --- target/riscv/insn16-64.decode | 10 -- target/riscv/insn16.decode| 7 ++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git

  1   2   3   >