Re: [Qemu-devel] [PATCH v7 1/8] vhost-user: add vhost_user_gpu_set_socket()

2019-05-13 Thread Gerd Hoffmann
Hi, > +VhostUserGpuCursorUpdate > + > + > ++-+---+---++ > +| pos | hot_x | hot_y | cursor | > ++-+---+---++ > + > +:pos: a ``VhostUserGpuCursorPos``, the cursor location > + > +:hot_x/hot_y: ``u32``, the cursor hot location > + >

[Qemu-devel] [PULL 06/31] tcg/arm: Use tcg_out_mov_reg in tcg_out_mov

2019-05-13 Thread Richard Henderson
We have a function that takes an additional condition parameter over the standard backend interface. It already takes care of eliding no-op moves. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-13 Thread Aravinda Prasad
On Tuesday 14 May 2019 10:17 AM, David Gibson wrote: > On Mon, May 13, 2019 at 04:00:43PM +0530, Aravinda Prasad wrote: >> >> >> On Friday 10 May 2019 03:23 PM, David Gibson wrote: >>> On Fri, May 10, 2019 at 12:45:29PM +0530, Aravinda Prasad wrote: On Friday 10 May 2019 12:16

Re: [Qemu-devel] [PATCH 08/13] target/arm/monitor: Add query-sve-vector-lengths

2019-05-13 Thread Markus Armbruster
Andrew Jones writes: > On Mon, May 13, 2019 at 06:12:38PM +0200, Markus Armbruster wrote: >> Andrew Jones writes: >> >> > Provide a QMP interface to query the supported SVE vector lengths. >> > A migratable guest will need to explicitly specify a valid set of >> > lengths on the command line

Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag

2019-05-13 Thread Pankaj Gupta
> > > > > > Hi Dan, > > > > While testing device mapper with DAX, I faced a bug with the commit: > > > > commit ad428cdb525a97d15c0349fdc80f3d58befb50df > > Author: Dan Williams > > Date: Wed Feb 20 21:12:50 2019 -0800 > > > > When I reverted the condition to old code[1] it worked for me. I >

[Qemu-devel] [PULL 20/31] tcg: Add support for integer absolute value

2019-05-13 Thread Richard Henderson
Remove a function of the same name from target/arm/. Use a branchless implementation of abs gleaned from gcc. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 5 +

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread Aravinda Prasad
On Tuesday 14 May 2019 10:10 AM, David Gibson wrote: > On Tue, May 14, 2019 at 09:56:41AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 14 May 2019 05:38 AM, David Gibson wrote: >>> On Mon, May 13, 2019 at 01:30:53PM +0200, Greg Kurz wrote: On Mon, 22 Apr 2019 12:33:26 +0530

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-13 Thread Markus Armbruster
Andrew Jones writes: > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: >> >> Hi all, >> >> >> >> First some background: >> >> >> >> For the userspace side of AArch64 guest

[Qemu-devel] [PULL 17/31] tcg/aarch64: Support vector variable shift opcodes

2019-05-13 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.opc.h | 2 ++ tcg/aarch64/tcg-target.inc.c | 42 3 files changed, 45 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread David Gibson
On Tue, May 14, 2019 at 09:56:41AM +0530, Aravinda Prasad wrote: > > > On Tuesday 14 May 2019 05:38 AM, David Gibson wrote: > > On Mon, May 13, 2019 at 01:30:53PM +0200, Greg Kurz wrote: > >> On Mon, 22 Apr 2019 12:33:26 +0530 > >> Aravinda Prasad wrote: > >> > >>> Upon a machine check

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 04:00:43PM +0530, Aravinda Prasad wrote: > > > On Friday 10 May 2019 03:23 PM, David Gibson wrote: > > On Fri, May 10, 2019 at 12:45:29PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Friday 10 May 2019 12:16 PM, David Gibson wrote: > >>> On Mon, Apr 22, 2019 at

Re: [Qemu-devel] [RFC v2 PATCH 3/3] spapr: Add Hcalls to support PAPR NVDIMM device

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 04:28:36AM -0500, Shivaprasad G Bhat wrote: > This patch implements few of the necessary hcalls for the nvdimm support. > > PAPR semantics is such that each NVDIMM device is comprising of multiple > SCM(Storage Class Memory) blocks. The guest requests the hypervisor to

[Qemu-devel] [PULL 18/31] tcg: Add gvec expanders for vector shift by scalar

2019-05-13 Thread Richard Henderson
Allow expansion either via shift by scalar or by replicating the scalar for shift by vector. Signed-off-by: Richard Henderson --- v3: Use a private structure for do_gvec_shifts. --- tcg/tcg-op-gvec.h | 7 ++ tcg/tcg-op.h | 4 + tcg/tcg-op-gvec.c | 214

[Qemu-devel] [PATCH 0/2] target/arm: Minor bit field improvements

2019-05-13 Thread Richard Henderson
The tcg extract2 patch on which this depended is now in master. r~ Richard Henderson (2): target/arm: Use extract2 for EXTR target/arm: Simplify BFXIL expansion target/arm/translate-a64.c | 44 -- 1 file changed, 23 insertions(+), 21 deletions(-) --

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread Aravinda Prasad
On Tuesday 14 May 2019 05:38 AM, David Gibson wrote: > On Mon, May 13, 2019 at 01:30:53PM +0200, Greg Kurz wrote: >> On Mon, 22 Apr 2019 12:33:26 +0530 >> Aravinda Prasad wrote: >> >>> Upon a machine check exception (MCE) in a guest address space, >>> KVM causes a guest exit to enable QEMU to

[Qemu-devel] [PATCH] kbd-state: fix autorepeat handling

2019-05-13 Thread Gerd Hoffmann
When allowing multiple down-events in a row (key autorepeat) we can't use change_bit() any more to update the state, because autorepeat events don't change the key state. We have to explicitly use set_bit() and clear_bit() instead. Cc: qemu-sta...@nongnu.org Fixes: 35921860156e kbd-state: don't

[Qemu-devel] [PULL 26/31] target/ppc: Use tcg_gen_abs_i32

2019-05-13 Thread Richard Henderson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190423102145.14812-2-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/ppc/translate/spe-impl.inc.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git

[Qemu-devel] [PULL 11/31] tcg: Add tcg_out_dupm_vec to the backend interface

2019-05-13 Thread Richard Henderson
Currently stubbed out in all backends that support vectors. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 6 ++ tcg/i386/tcg-target.inc.c| 7 +++ tcg/tcg.c| 19 ++- 3 files changed, 31 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 2/2] target/arm: Simplify BFXIL expansion

2019-05-13 Thread Richard Henderson
The mask implied by the extract is redundant with the one implied by the deposit. Also, fix spelling of BFXIL. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 38/39] tcg/arm: Use LDRD to load tlb mask+table

2019-05-13 Thread Alistair Francis
On Sat, May 11, 2019 at 12:13 PM Richard Henderson wrote: > > On 5/10/19 2:08 PM, Alistair Francis wrote: > >> +if (use_armv6_instructions && TARGET_LONG_BITS == 64) { > >> +tcg_out_ldrd_8(s, COND_AL, TCG_REG_R2, TCG_REG_R1, cmp_off); > ... > > > > This is complex and I'm

[Qemu-devel] [PATCH 1/2] target/arm: Use extract2 for EXTR

2019-05-13 Thread Richard Henderson
This is, after all, how we implement extract2 in tcg/aarch64. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/target/arm/translate-a64.c

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 04:28:02AM -0500, Shivaprasad G Bhat wrote: > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm > device interface in QEMU to support virtual NVDIMM devices for Power (May have > to re-look at this later). Create the required DT entries for the >

Re: [Qemu-devel] [PATCH v11 00/12] Add RX archtecture support

2019-05-13 Thread Yoshinori Sato
t; Fixed build errors and cleaned up the code. > > > > My git repository is bellow. > > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190513 > > This tag isn't exactly the same as the series you posted, some patches > are ordered differently, leading to th

Re: [Qemu-devel] [PATCH v4 12/14] spapr/irq: initialize the IRQ device only once

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 10:42:43AM +0200, Cédric Le Goater wrote: > Add a check to make sure that the routine initializing the emulated > IRQ device is called once. We don't have much to test on the XICS > side, so we introduce a 'init' boolean under ICSState. > > Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH v4 13/14] ppc/xics: fix irq priority in ics_set_irq_type()

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 10:42:44AM +0200, Cédric Le Goater wrote: > Recent commits changed the behavior of ics_set_irq_type() to > initialize correctly LSIs at the KVM level. ics_set_irq_type() is also > called by the realize routine of the different devices of the machine > when initial

Re: [Qemu-devel] [PATCH v4 04/14] spapr/xive: add state synchronization with KVM

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 10:42:35AM +0200, Cédric Le Goater wrote: > This extends the KVM XIVE device backend with 'synchronize_state' > methods used to retrieve the state from KVM. The HW state of the > sources, the KVM device and the thread interrupt contexts are > collected for the monitor usage

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 01:30:53PM +0200, Greg Kurz wrote: > On Mon, 22 Apr 2019 12:33:26 +0530 > Aravinda Prasad wrote: > > > Upon a machine check exception (MCE) in a guest address space, > > KVM causes a guest exit to enable QEMU to build and pass the > > error to the guest in the PAPR

[Qemu-devel] [PULL 14/31] tcg: Add INDEX_op_dupm_vec

2019-05-13 Thread Richard Henderson
Allow the backend to expand dup from memory directly, instead of forcing the value into a temp first. This is especially important if integer/vector register moves do not exist. Note that officially tcg_out_dupm_vec is allowed to fail. If it did, we could fix this up relatively easily: VECE

[Qemu-devel] [PULL 30/31] target/xtensa: Use tcg_gen_abs_i32

2019-05-13 Thread Richard Henderson
Acked-by: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 301c8e3161..b063fa85f2 100644 --- a/target/xtensa/translate.c +++

[Qemu-devel] [PULL 01/31] tcg: Implement tcg_gen_gvec_3i()

2019-05-13 Thread Richard Henderson
From: David Hildenbrand Let's add tcg_gen_gvec_3i(), similar to tcg_gen_gvec_2i(), however without introducing "gen_helper_gvec_3i *fnoi", as it isn't needed for now. Reviewed-by: Alex Bennée Signed-off-by: David Hildenbrand Message-Id: <20190416185301.25344-2-da...@redhat.com> Signed-off-by:

Re: [Qemu-devel] [PATCH v1 1/1] target/arm: Fix vector operation segfault

2019-05-13 Thread Richard Henderson
On 5/13/19 5:08 PM, Alistair Francis wrote: > We hit the second switch case as > NEON_3R_VQADD and NEON_3R_VQSUB don't return from the function in the > first switch case. That's the bug, not here in this second switch. r~

[Qemu-devel] [PULL 23/31] tcg/aarch64: Support vector absolute value

2019-05-13 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index 21d06d928c..e43554c3c7 100644 ---

[Qemu-devel] [PULL 25/31] target/cris: Use tcg_gen_abs_tl

2019-05-13 Thread Richard Henderson
Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/cris/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index b005a5c20e..31b40a57f9 100644 --- a/target/cris/translate.c +++

[Qemu-devel] [PULL 00/31] tcg: gvec improvments

2019-05-13 Thread Richard Henderson
) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20190513 for you to fetch changes up to a7b6d286cfb5205b9f5330aefc5727269b3d810f: tcg/aarch64: Do not advertise minmax for MO_64 (2019-05-13 22:52:08 +

[Qemu-devel] [PATCH v1 1/1] target/arm: Fix vector operation segfault

2019-05-13 Thread Alistair Francis
Commit 89e68b575 "target/arm: Use vector operations for saturation" causes this abort() when booting QEMU ARM with a Cortex-A15: 0 0x74c2382f in raise () at /usr/lib/libc.so.6 1 0x74c0e672 in abort () at /usr/lib/libc.so.6 2 0x559c1839 in disas_neon_data_insn (insn=,

[Qemu-devel] [PULL 21/31] tcg: Add support for vector absolute value

2019-05-13 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 5 +++ tcg/aarch64/tcg-target.h | 1 + tcg/i386/tcg-target.h| 1 + tcg/tcg-op-gvec.h| 2 ++ tcg/tcg-opc.h| 1 + tcg/tcg.h| 1 +

[Qemu-devel] [PULL 22/31] tcg/i386: Support vector absolute value

2019-05-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 15 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 7445f05885..66f16fbe3c 100644 --- a/tcg/i386/tcg-target.h +++

[Qemu-devel] [PULL 15/31] tcg: Add gvec expanders for variable shift

2019-05-13 Thread Richard Henderson
The gvec expanders perform a modulo on the shift count. If the target requires alternate behaviour, then it cannot use the generic gvec expanders anyway, and will have to have its own custom code. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 15

[Qemu-devel] [PULL 29/31] target/tricore: Use tcg_gen_abs_tl

2019-05-13 Thread Richard Henderson
From: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190423102145.14812-3-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/tricore/translate.c | 27 +-- 1 file changed, 5 insertions(+), 22

[Qemu-devel] [PULL 05/31] tcg: Assert fixed_reg is read-only

2019-05-13 Thread Richard Henderson
The only fixed_reg is cpu_env, and it should not be modified during any TB. Therefore code that tries to special-case moves into a fixed_reg is dead. Remove it. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg.c | 87

[Qemu-devel] [PULL 24/31] target/arm: Use tcg_gen_abs_i64 and tcg_gen_gvec_abs

2019-05-13 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.h| 2 -- target/arm/neon_helper.c | 5 - target/arm/translate-a64.c | 41 +- target/arm/translate.c | 11 +++--- 4 files changed, 8 insertions(+), 51

[Qemu-devel] [PULL 28/31] target/s390x: Use tcg_gen_abs_i64

2019-05-13 Thread Richard Henderson
Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index d4951836ad..e8e8a79b7d 100644 --- a/target/s390x/translate.c +++

[Qemu-devel] [PULL 27/31] target/ppc: Use tcg_gen_abs_tl

2019-05-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/ppc/translate.c | 68 +++--- 1 file changed, 24 insertions(+), 44 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 8d08625c33..b5217f632f 100644 --- a/target/ppc/translate.c +++

[Qemu-devel] [PULL 10/31] tcg: Manually expand INDEX_op_dup_vec

2019-05-13 Thread Richard Henderson
This case is similar to INDEX_op_mov_* in that we need to do different things depending on the current location of the source. Signed-off-by: Richard Henderson --- v3: Added some commentary to the tcg_reg_alloc_* functions. --- tcg/aarch64/tcg-target.inc.c | 9 ++- tcg/i386/tcg-target.inc.c

[Qemu-devel] [PULL 31/31] tcg/aarch64: Do not advertise minmax for MO_64

2019-05-13 Thread Richard Henderson
The min/max instructions are not available for 64-bit elements. Fixes: 93f332a50371 Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index

[Qemu-devel] [PULL 09/31] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface

2019-05-13 Thread Richard Henderson
The i386 backend already has these functions, and the aarch64 backend could easily split out one. Nothing is done with these functions yet, but this will aid register allocation of INDEX_op_dup_vec in a later patch. Adjust the aarch64 tcg_out_dupi_vec signature to match the new interface.

[Qemu-devel] [PULL 19/31] tcg/i386: Support vector scalar shift opcodes

2019-05-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index b240633455..618aa520d2 100644 ---

[Qemu-devel] [PULL 12/31] tcg/i386: Implement tcg_out_dupm_vec

2019-05-13 Thread Richard Henderson
At the same time, improve tcg_out_dupi_vec wrt broadcast from the constant pool. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 57 +-- 1 file changed, 43 insertions(+), 14 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c

[Qemu-devel] [PULL 02/31] tcg: Do not recreate INDEX_op_neg_vec unless supported

2019-05-13 Thread Richard Henderson
Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec, so that we check the type and vece for the actual operation. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c

[Qemu-devel] [PULL 13/31] tcg/aarch64: Implement tcg_out_dupm_vec

2019-05-13 Thread Richard Henderson
The LD1R instruction does all the work. Note that the only useful addressing mode is a base register with no offset. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 37 ++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 07/31] tcg: Return bool success from tcg_out_mov

2019-05-13 Thread Richard Henderson
This patch merely changes the interface, aborting on all failures, of which there are currently none. Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 5

Re: [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice

2019-05-13 Thread Alistair Francis
On Mon, May 13, 2019 at 12:57 PM Jonathan Behrens wrote: > > Signed-off-by: Jonathan Behrens Good find. Thanks for the patch! Reviewed-by: Alistair Francis Can this go via your tree Jason? Alistair > --- > hw/net/cadence_gem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-13 Thread Richard Henderson
On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > On May 10, 2019 10:36 PM, "Richard Henderson" > wrote: >> >> For linux-user, there is no need to add slirp to the set of >> git modules checked out, nor build it. >> >> This also avoids a makefile bug wrt

[Qemu-devel] [Bug 1828867] Re: QEmu translation is incorrect when using REX in combination with LAHF/SAHF

2019-05-13 Thread Alex Bennée
** Tags added: tcg testcase x86 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1828867 Title: QEmu translation is incorrect when using REX in combination with LAHF/SAHF Status in QEMU: New

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: introducing 'bdrv_co_delete_file' interface

2019-05-13 Thread John Snow
It looks like this one has gone un-noticed for a little while. On 3/26/19 5:17 PM, Daniel Henrique Barboza wrote: > Adding to Block Drivers the capability of being able to clean up > its created files can be useful in certain situations. For the > LUKS driver, for instance, a failure in one of

[Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice

2019-05-13 Thread Jonathan Behrens
Signed-off-by: Jonathan Behrens --- hw/net/cadence_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 7f63411430..37cb8a4e5c 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -146,7 +146,6 @@ #define GEM_DESCONF7

Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

2019-05-13 Thread Nir Soffer
On Mon, May 13, 2019, 18:52 Max Reitz wrote: > It is possible for an empty file to take up blocks on a filesystem. > Make iotest 175 take this into account. > > Reported-by: Thomas Huth > Signed-off-by: Max Reitz > --- > v2: [Nir] > - Use a function for filtering > -

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-13 Thread Andrew Jones
On Mon, May 13, 2019 at 11:46:29AM -0700, Richard Henderson wrote: > On 5/12/19 1:36 AM, Andrew Jones wrote: > >CPU type | accel | sve-max-vq | sve-vls-map > >--- > > 1) max | tcg | $MAX_VQ | $VLS_MAP > > 2) max | kvm | $MAX_VQ |

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-13 Thread John Snow
On 4/9/19 9:19 AM, Stefan Hajnoczi wrote: > On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: >> Signed-off-by: Kenneth Heitke >> --- >> hw/block/nvme.c | 120 +- >> hw/block/nvme.h | 3 ++ >> hw/block/trace-events | 2 + >>

[Qemu-devel] [Bug 1823458] Update Released

2019-05-13 Thread Corey Bryant
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-13 Thread Corey Bryant
This bug was fixed in the package qemu - 1:2.8+dfsg-3ubuntu2.9~cloud5.1 --- qemu (1:2.8+dfsg-3ubuntu2.9~cloud5.1) xenial-ocata; urgency=medium . * d/p/lp1823458/add-VirtIONet-vhost_stopped-flag-to-prevent-multiple.patch,

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-13 Thread Corey Bryant
This bug was fixed in the package qemu - 1:2.5+dfsg-5ubuntu10.37~cloud0 --- qemu (1:2.5+dfsg-5ubuntu10.37~cloud0) trusty-mitaka; urgency=medium . * New update for the Ubuntu Cloud Archive. . qemu (1:2.5+dfsg-5ubuntu10.37) xenial; urgency=medium . *

[Qemu-devel] [Bug 1823458] Update Released

2019-05-13 Thread Corey Bryant
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we

[Qemu-devel] [PATCH v7 8/8] hw/display: add vhost-user-vga & gpu-pci

2019-05-13 Thread Marc-André Lureau
Add new virtio-gpu devices with a "vhost-user" property. The associated vhost-user backend is used to handle the virtio rings and provide rendering results thanks to the vhost-user-gpu protocol. Example usage: -object vhost-user-backend,id=vug,cmd="./vhost-user-gpu" -device

[Qemu-devel] [PATCH v7 5/8] contrib: add vhost-user-gpu

2019-05-13 Thread Marc-André Lureau
Add a vhost-user gpu backend, based on virtio-gpu/3d device. It is to be associated with a vhost-user-gpu device. Various TODO and nice to have items: - multi-head support - crash & resume handling - accelerated rendering/display that avoids the waiting round trips - edid support Signed-off-by:

Re: [Qemu-devel] [PATCH 00/13] target/arm/kvm: enable SVE in guests

2019-05-13 Thread Richard Henderson
On 5/12/19 1:36 AM, Andrew Jones wrote: >CPU type | accel | sve-max-vq | sve-vls-map >--- > 1) max | tcg | $MAX_VQ | $VLS_MAP > 2) max | kvm | $MAX_VQ | $VLS_MAP > 3)host | kvm | N/A | $VLS_MAP This doesn't seem

[Qemu-devel] [PATCH v7 7/8] virtio-gpu: split virtio-gpu-pci & virtio-vga

2019-05-13 Thread Marc-André Lureau
Add base classes that are common to vhost-user-gpu-pci and vhost-user-vga. Signed-off-by: Marc-André Lureau --- hw/display/virtio-vga.h | 32 + hw/display/virtio-gpu-pci.c | 52 +- hw/display/virtio-vga.c | 135 ++-- MAINTAINERS

[Qemu-devel] [PATCH v7 3/8] virtio-gpu: add a pixman helper header

2019-05-13 Thread Marc-André Lureau
This will allow to share the format conversion function with vhost-user-gpu. Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu-pixman.h | 45 +++ hw/display/virtio-gpu.c | 29 ++--- 2 files changed, 48 insertions(+), 26

[Qemu-devel] [PATCH v7 6/8] virtio-gpu: split virtio-gpu, introduce virtio-gpu-base

2019-05-13 Thread Marc-André Lureau
Add a base class that is common to virtio-gpu and vhost-user-gpu devices. The VirtIOGPUBase base class provides common functionalities necessary for both virtio-gpu and vhost-user-gpu: - common configuration (max-outputs, initial resolution, flags) - virtio device initialization, including queue

[Qemu-devel] [PATCH v7 4/8] util: compile drm.o on Linux

2019-05-13 Thread Marc-André Lureau
OpenGL isn't required to use DRM rendernodes. The following patches uses it for 2d resources for ex. Signed-off-by: Marc-André Lureau --- util/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/Makefile.objs b/util/Makefile.objs index 9206878dec..657d59df3f

[Qemu-devel] [PATCH v7 1/8] vhost-user: add vhost_user_gpu_set_socket()

2019-05-13 Thread Marc-André Lureau
Add a new vhost-user message to give a unix socket to a vhost-user backend for GPU display updates. Back when I started that work, I added a new GPU channel because the vhost-user protocol wasn't bidirectional. Since then, there is a vhost-user-slave channel for the slave to send requests to the

[Qemu-devel] [PATCH v7 2/8] virtio-gpu: add bswap helpers header

2019-05-13 Thread Marc-André Lureau
The helper functions are useful to build the vhost-user-gpu backend. Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu-bswap.h | 61 hw/display/virtio-gpu.c | 43 +--- 2 files changed, 62 insertions(+), 42 deletions(-)

[Qemu-devel] [PATCH v7 0/8] Add vhost-user-gpu

2019-05-13 Thread Marc-André Lureau
Hi, vhost-user allows to drive a virtio device in a seperate process. After vhost-user-net, we have seen vhost-user-{scsi,blk,crypto,input} added more recently. This series, initially proposed ~3 years ago, time flies (https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg01905.html)

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-13 Thread Andrew Jones
On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > >> Hi all, > >> > >> First some background: > >> > >> For the userspace side of AArch64 guest SVE support we need to > >> expose

[Qemu-devel] [PATCH v3 1/3] libvhost-user: fix cast warnings on 32 bits

2019-05-13 Thread Marc-André Lureau
Fixes warnings: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c

[Qemu-devel] [PATCH v3 3/3] contrib: add vhost-user-input

2019-05-13 Thread Marc-André Lureau
Add a vhost-user input backend example, based on virtio-input-host device. It takes an evdev path as argument, and can be associated with a vhost-user-input device via a UNIX socket: $ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock $ qemu ... -chardev socket,id=vuic,path=/tmp/vui.sock

[Qemu-devel] [PATCH v3 0/3] Add vhost-user-input

2019-05-13 Thread Marc-André Lureau
Hi, v3: - rebased, fixing some warnings found during merge v2: - build fixes v1: (changes since original v6 series) - add "libvhost-user: fix -Waddress-of-packed-member" & "util: simplify unix_listen()" - use unix_listen() - build vhost-user-input by default (when applicable) Marc-André

[Qemu-devel] [PATCH v3 2/3] libvhost-user: fix -Werror=format= on ppc64

2019-05-13 Thread Marc-André Lureau
That should fix the following warning: /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function ‘vu_set_mem_table_exec_postcopy’: /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has

Re: [Qemu-devel] [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map

2019-05-13 Thread Andrew Jones
On Mon, May 13, 2019 at 05:37:09PM +0200, Markus Armbruster wrote: > Andrew Jones writes: > > > Allow the host cpu type to enable SVE in guests with the sve-vls-map > > cpu property. > > > > Signed-off-by: Andrew Jones > > --- > > target/arm/cpu.c | 1 + > > target/arm/cpu.h | 2 ++ > >

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

2019-05-13 Thread Richard Henderson
On 5/13/19 11:14 AM, Andrew Jones wrote: >> Indeed, to me this seems to be the wrong kind of swabbing here. Exactly what >> format is KVM expecting? Surely it should be the one used by the >> unpredicated >> LDR/STR instructions. Anything else would seem to be working against the >>

Re: [Qemu-devel] [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map

2019-05-13 Thread Andrew Jones
On Mon, May 13, 2019 at 05:25:23PM +0200, Markus Armbruster wrote: > Andrew Jones writes: > > > Introduce another cpu property to control SVE vector lengths, > > sve-vls-map, which allows the user to explicitly select the > > set of vector lengths the guest can use. The map must conform > > to

Re: [Qemu-devel] [PATCH 08/13] target/arm/monitor: Add query-sve-vector-lengths

2019-05-13 Thread Andrew Jones
On Mon, May 13, 2019 at 06:12:38PM +0200, Markus Armbruster wrote: > Andrew Jones writes: > > > Provide a QMP interface to query the supported SVE vector lengths. > > A migratable guest will need to explicitly specify a valid set of > > lengths on the command line and that set can be obtained

[Qemu-devel] [Bug 1828867] Re: QEmu translation is incorrect when using REX in combination with LAHF/SAHF

2019-05-13 Thread sonicadvan...@gmail.com
Here's also a basic test that can be run on hardware and have rflags and rsp inspected after each instruction just to see how hardware doesn't effect it. ** Attachment added: "a.cpp" https://bugs.launchpad.net/qemu/+bug/1828867/+attachment/5263495/+files/a.cpp -- You received this bug

[Qemu-devel] [Bug 1828867] [NEW] QEmu translation is incorrect when using REX in combination with LAHF/SAHF

2019-05-13 Thread sonicadvan...@gmail.com
Public bug reported: When translating code that is using LAHF and SAHF in combination with the REX prefix then qemu translates incorrectly. These two instructions only ever use the AH register. Contrary to other instructions where if you use REX + high bit offsets then it'll pull in rsp and a

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

2019-05-13 Thread Andrew Jones
On Mon, May 13, 2019 at 09:40:29AM -0700, Richard Henderson wrote: > On 5/13/19 5:31 AM, Dave Martin wrote: > > On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: > >> These are the SVE equivalents to kvm_arch_get/put_fpsimd. > >> > >> Signed-off-by: Andrew Jones > >> --- > >>

Re: [Qemu-devel] [PATCH 07/13] target/arm/kvm: max cpu: Allow sve max vector length setting

2019-05-13 Thread Andrew Jones
On Mon, May 13, 2019 at 10:19:25AM -0700, Richard Henderson wrote: > On 5/12/19 1:36 AM, Andrew Jones wrote: > > @@ -292,7 +292,7 @@ static void aarch64_max_initfn(Object *obj) > > > > if (kvm_enabled()) { > > kvm_arm_set_cpu_features_from_host(cpu); > > -cpu->sve_max_vq =

Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag

2019-05-13 Thread Dan Williams
On Mon, May 13, 2019 at 10:32 AM Pankaj Gupta wrote: > > > Hi Dan, > > While testing device mapper with DAX, I faced a bug with the commit: > > commit ad428cdb525a97d15c0349fdc80f3d58befb50df > Author: Dan Williams > Date: Wed Feb 20 21:12:50 2019 -0800 > > When I reverted the condition to old

Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag

2019-05-13 Thread Pankaj Gupta
Hi Dan, While testing device mapper with DAX, I faced a bug with the commit: commit ad428cdb525a97d15c0349fdc80f3d58befb50df Author: Dan Williams Date: Wed Feb 20 21:12:50 2019 -0800 When I reverted the condition to old code[1] it worked for me. I am thinking when we map two different

Re: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-13 Thread Amit Shah
On (Fri) 10 May 2019 [17:19:12], Markus Armbruster wrote: > Laurent Vivier writes: > > > On 10/05/2019 14:27, Markus Armbruster wrote: > >> Laurent Vivier writes: > >> > >>> Add a new RNG backend using QEMU builtin getrandom function. > >>> > >>> It can be created and used with something like:

Re: [Qemu-devel] [PATCH v11 00/12] Add RX archtecture support

2019-05-13 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 5/13/19 7:25 AM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. > > Fixed build errors and cleaned up the code. > > My git repository is bellow. > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-201

Re: [Qemu-devel] [PATCH 07/13] target/arm/kvm: max cpu: Allow sve max vector length setting

2019-05-13 Thread Richard Henderson
On 5/12/19 1:36 AM, Andrew Jones wrote: > @@ -292,7 +292,7 @@ static void aarch64_max_initfn(Object *obj) > > if (kvm_enabled()) { > kvm_arm_set_cpu_features_from_host(cpu); > -cpu->sve_max_vq = ARM_MAX_VQ; > +cpu->sve_max_vq = -1; /* set in kvm_arch_init_vcpu() */

Re: [Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-05-13 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 13 May 2019 17:25 > To: Shameerali Kolothum Thodi > Subject: Re: [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support > > On Mon, 13 May 2019 11:53:38 + > Shameerali Kolothum Thodi wrote: > > >

Re: [Qemu-devel] [PULL 4/9] linux-user/nios2 linux-user/riscv: Clean up header guards

2019-05-13 Thread Peter Maydell
On Mon, 13 May 2019 at 17:56, Palmer Dabbelt wrote: > > On Mon, 13 May 2019 01:18:39 PDT (-0700), arm...@redhat.com wrote: > > Reuse of the same guard symbol in multiple headers is okay as long as > > they cannot be included together. scripts/clean-header-guards.pl > > can't tell, so it warns. >

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

2019-05-13 Thread Richard Henderson
On 5/13/19 7:39 AM, Dave Martin wrote: > On that point, could TCG easily be made to expose a larger vector length > to the kernel? I'd be interested to see what happened. It would be easy enough to extend the maximum vector length within TCG. Increase ARM_MAX_VQ. Alter the couple of places

Re: [Qemu-devel] [PULL 4/9] linux-user/nios2 linux-user/riscv: Clean up header guards

2019-05-13 Thread Palmer Dabbelt
On Mon, 13 May 2019 01:18:39 PDT (-0700), arm...@redhat.com wrote: Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. scripts/clean-header-guards.pl can't tell, so it warns. Since we can avoid guard symbol reuse easily, do so: use guard

Re: [Qemu-devel] [PULL v3 00/29] Kconfig for Arm

2019-05-13 Thread Peter Maydell
On Mon, 13 May 2019 at 09:29, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-05-10 14:49:36 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve

2019-05-13 Thread Richard Henderson
On 5/13/19 5:31 AM, Dave Martin wrote: > On Sun, May 12, 2019 at 09:36:16AM +0100, Andrew Jones wrote: >> These are the SVE equivalents to kvm_arch_get/put_fpsimd. >> >> Signed-off-by: Andrew Jones >> --- >> target/arm/kvm64.c | 127 +++-- >> 1 file

Re: [Qemu-devel] [PATCH v2] iotests: Filter 175's allocation information

2019-05-13 Thread Eric Blake
On 5/13/19 10:52 AM, Max Reitz wrote: > It is possible for an empty file to take up blocks on a filesystem. > Make iotest 175 take this into account. > > Reported-by: Thomas Huth > Signed-off-by: Max Reitz > --- > v2: [Nir] > - Use a function for filtering > - s/empty_blocks/extra_blocks/ > ---

Re: [Qemu-devel] [PATCH] tests/libqtest: Fix description of qtest_vinitf() and qtest_initf()

2019-05-13 Thread Eric Blake
On 5/13/19 10:47 AM, Thomas Huth wrote: > These functions are convenience wrappers of qtest_init() and not of > qtest_start(). > > Signed-off-by: Thomas Huth > --- > tests/libqtest.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal

Re: [Qemu-devel] [PATCH 08/13] target/arm/monitor: Add query-sve-vector-lengths

2019-05-13 Thread Markus Armbruster
Andrew Jones writes: > Provide a QMP interface to query the supported SVE vector lengths. > A migratable guest will need to explicitly specify a valid set of > lengths on the command line and that set can be obtained from the > list returned with this QMP command. > > This patch only introduces

  1   2   3   4   >