Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images

2019-06-19 Thread Alexey Kardashevskiy
On 17/06/2019 14:56, Philippe Mathieu-Daudé wrote: > On 6/17/19 3:25 AM, Alexey Kardashevskiy wrote: >> On 14/06/2019 19:33, Stefan Hajnoczi wrote: >>> On Fri, Jun 14, 2019 at 10:13:04AM +1000, Alexey Kardashevskiy wrote: On 13/06/2019 23:08, Philippe Mathieu-Daudé wrote: >

[Qemu-devel] [PATCH v4 1/3] target/i386: Add CPUID.1F generation support for multi-dies PCMachine

2019-06-19 Thread Like Xu
The CPUID.1F as Intel V2 Extended Topology Enumeration Leaf would be exposed if guests want to emulate multiple software-visible die within each package. Per Intel's SDM, the 0x1f is a superset of 0xb, thus they can be generated by almost same code as 0xb except die_offset setting. If the number

[Qemu-devel] [PATCH v4 3/3] vl.c: Add -smp, dies=* command line support and update doc

2019-06-19 Thread Like Xu
For PC target, users could configure the number of dies per one package via command line with this patch, such as "-smp dies=2,cores=4". The parsing rules of new cpu-topology model obey the same restrictions/logic as the legacy socket/core/thread model especially on missing values computing.

Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-19 Thread Gerd Hoffmann
> === OUTPUT BEGIN === > 1/8 Checking commit cf2168a66dbd (block: Refactor macros - fix tabbing) > ERROR: Macros with complex values should be enclosed in parenthesis > #55: FILE: include/hw/block/block.h:65: > +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ > +

[Qemu-devel] [PATCH v4 0/3] Introduce cpu die topology and enable CPUID.1F for i386

2019-06-19 Thread Like Xu
This patch series introduces a new cpu topolgy 'die' for PCMachine, which extends virtual cpu topology to the socket/die/core/thread model, allowing the setting of dies number per one socket via -smp qemu command. For i386, it upgrades APIC-IDs generation and reversion functions with a new

Re: [Qemu-devel] [QEMU] [PATCH v4 7/8] bootdevice: FW_CFG interface for LCHS values

2019-06-19 Thread Gerd Hoffmann
On Wed, Jun 19, 2019 at 12:29:04PM +0300, Sam Eiderman wrote: > Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries (consistent

[Qemu-devel] [PATCH v4 2/3] machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse()

2019-06-19 Thread Like Xu
To make smp_parse() more flexible and expansive, a smp_parse function pointer is added to MachineClass that machine types could override. The generic smp_parse() code in vl.c is moved to hw/core/machine.c, and become the default implementation of MachineClass::smp_parse. A PC-specific function

Re: [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] geometry: Apply LCHS values for boot devices

2019-06-19 Thread Gerd Hoffmann
> +static int > +overriden_lchs_supplied(struct drive_s *drive) > +{ > +return drive->lchs.cylinder || drive->lchs.head || drive->lchs.sector; > +} > +case TRANSLATION_MACHINE: Hmm, why this name? Doesn't look intuitive to me. > +desc = "overriden"; I'd name that

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-19 Thread Yan Zhao
On Thu, Jun 20, 2019 at 12:02:30PM +0800, Peter Xu wrote: > On Wed, Jun 19, 2019 at 03:17:41PM +0200, Auger Eric wrote: > > Hi Yan, > > > > [+ Peter] > > > > On 6/19/19 10:49 AM, Yan Zhao wrote: > > > even if an entry overlaps with notifier's range, should not map/unmap > > > out of bound part

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-19 Thread Peter Xu
On Wed, Jun 19, 2019 at 03:17:41PM +0200, Auger Eric wrote: > Hi Yan, > > [+ Peter] > > On 6/19/19 10:49 AM, Yan Zhao wrote: > > even if an entry overlaps with notifier's range, should not map/unmap > > out of bound part in the entry. > > I don't think the patch was based on the master as the

Re: [Qemu-devel] [PATCH v3 7/9] target/i386: Support multi-dies when host doesn't support CPUID.1F

2019-06-19 Thread Eduardo Habkost
On Thu, Jun 20, 2019 at 10:03:07AM +0800, Like Xu wrote: > On 2019/6/20 7:36, Eduardo Habkost wrote: > > On Wed, Jun 19, 2019 at 04:15:46PM -0300, Eduardo Habkost wrote: > > > On Wed, Jun 12, 2019 at 04:41:02PM +0800, Like Xu wrote: > > > > In guest CPUID generation process, the cpuid_min_level

Re: [Qemu-devel] [PATCH] x86/cpu: use FeatureWordArray to define filtered_features

2019-06-19 Thread Eduardo Habkost
On Thu, Jun 20, 2019 at 10:37:46AM +0800, Wei Yang wrote: > Use the same definition as features/user_features in CPUX86State. > > Signed-off-by: Wei Yang Queued, thanks. -- Eduardo

Re: [Qemu-devel] [PATCH] migration: Improve accuracy of vCPU throttling with per-vCPU timers

2019-06-19 Thread Peter Xu
On Wed, Jun 19, 2019 at 03:23:28PM +, Cosmin Marin wrote: > > > On 19/06/2019, 02:35, "Peter Xu" wrote: > > On Tue, Jun 18, 2019 at 04:52:09PM +, Cosmin Marin wrote: > > > > > > On 18/06/2019, 15:51, "Peter Xu" wrote: > > > > On Tue, Jun 18, 2019 at

[Qemu-devel] [PATCH] x86/cpu: use FeatureWordArray to define filtered_features

2019-06-19 Thread Wei Yang
Use the same definition as features/user_features in CPUX86State. Signed-off-by: Wei Yang --- target/i386/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 0732e059ec..fd5ff13817 100644 --- a/target/i386/cpu.h +++

Re: [Qemu-devel] [PATCH v2 11/21] aspeed/timer: Ensure positive muldiv delta

2019-06-19 Thread Andrew Jeffery
On Wed, 19 Jun 2019, at 02:24, Cédric Le Goater wrote: > From: Christian Svensson > > If the host decrements the counter register that results in a negative > delta. This is then passed to muldiv64 which only handles unsigned > numbers resulting in bogus results. > > This fix ensures the

Re: [Qemu-devel] [PATCH v3 7/9] target/i386: Support multi-dies when host doesn't support CPUID.1F

2019-06-19 Thread Like Xu
On 2019/6/20 7:36, Eduardo Habkost wrote: On Wed, Jun 19, 2019 at 04:15:46PM -0300, Eduardo Habkost wrote: On Wed, Jun 12, 2019 at 04:41:02PM +0800, Like Xu wrote: In guest CPUID generation process, the cpuid_min_level would be adjusted to the maximum passed value for basic CPUID configuration

Re: [Qemu-devel] [PATCH] memory: do not do out of bound notification

2019-06-19 Thread Yan Zhao
hi Eric, Thanks for your reply. On Wed, Jun 19, 2019 at 09:17:41PM +0800, Auger Eric wrote: > Hi Yan, > > [+ Peter] > > On 6/19/19 10:49 AM, Yan Zhao wrote: > > even if an entry overlaps with notifier's range, should not map/unmap > > out of bound part in the entry. > > I don't think the patch

[Qemu-devel] [PATCH 01/12] qapi: add BitmapSyncMode enum

2019-06-19 Thread John Snow
Depending on what a user is trying to accomplish, there might be a few bitmap cleanup actions that occur when an operation is finished that could be useful. I am proposing three: - NEVER: The bitmap is never synchronized against what was copied. - ALWAYS: The bitmap is always synchronized, even

[Qemu-devel] [PATCH 02/12] block/backup: Add mirror sync mode 'bitmap'

2019-06-19 Thread John Snow
We don't need or want a new sync mode for simple differences in semantics. Create a new mode simply named "BITMAP" that is designed to make use of the new Bitmap Sync Mode field. Because the only bitmap mode is 'conditional', this adds no new functionality to the backup job (yet). The old

[Qemu-devel] [PATCH 11/12] iotests: add test 257 for bitmap-mode backups

2019-06-19 Thread John Snow
Signed-off-by: John Snow --- tests/qemu-iotests/257 | 412 +++ tests/qemu-iotests/257.out | 2199 tests/qemu-iotests/group |1 + 3 files changed, 2612 insertions(+) create mode 100755 tests/qemu-iotests/257 create mode 100644

[Qemu-devel] [PATCH 00/12] bitmaps: introduce 'bitmap' sync mode

2019-06-19 Thread John Snow
This series adds a new "BITMAP" sync mode that is meant to replace the existing "INCREMENTAL" sync mode. This mode can be changed by issuing any of three bitmap sync modes; passed as arguments to the job. The three bitmap sync modes are: - CONDITIONAL: This is an alias for the old incremental

[Qemu-devel] [PATCH 05/12] hbitmap: enable merging across granularities

2019-06-19 Thread John Snow
Signed-off-by: John Snow --- util/hbitmap.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/util/hbitmap.c b/util/hbitmap.c index 45d1725daf..0d6724b7bc 100644 --- a/util/hbitmap.c +++ b/util/hbitmap.c @@ -777,7 +777,17 @@ void hbitmap_truncate(HBitmap

[Qemu-devel] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim

2019-06-19 Thread John Snow
This function can claim an hbitmap to replace its own current hbitmap. In the case that the granularities do not match, it will use hbitmap_merge to copy the bit data instead. Signed-off-by: John Snow --- include/block/block_int.h | 1 + include/qemu/hbitmap.h| 8

[Qemu-devel] [PATCH 08/12] iotests: add testing shim for script-style python tests

2019-06-19 Thread John Snow
Because the new-style python tests don't use the iotests.main() test launcher, we don't turn on the debugger logging for these scripts when invoked via ./check -d. Refactor the launcher shim into new and old style shims so that they share environmental configuration. Two cleanup notes: debug was

[Qemu-devel] [PATCH 09/12] iotests: teach run_job to cancel pending jobs

2019-06-19 Thread John Snow
run_job can cancel pending jobs to simulate failure. This lets us use the pending callback to issue test commands while the job is open, but then still have the job fail in the end. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 22 -- 1 file changed, 20

[Qemu-devel] [PATCH 07/12] block/backup: add 'always' bitmap sync policy

2019-06-19 Thread John Snow
This adds an "always" policy for bitmap synchronization. Regardless of if the job succeeds or fails, the bitmap is *always* synchronized. This means that for backups that fail part-way through, the bitmap retains a record of which sectors need to be copied out to accomplish a new backup using the

[Qemu-devel] [PATCH 03/12] block/backup: add 'never' policy to bitmap sync mode

2019-06-19 Thread John Snow
This adds a "never" policy for bitmap synchronization. Regardless of if the job succeeds or fails, we never update the bitmap. This can be used to perform differential backups, or simply to avoid the job modifying a bitmap. Signed-off-by: John Snow --- qapi/block-core.json | 6 +-

[Qemu-devel] [PATCH 04/12] hbitmap: Fix merge when b is empty, and result is not an alias of a

2019-06-19 Thread John Snow
Nobody calls the function like this currently, but we neither prohibit or cope with this behavior. I decided to make the function cope with it. Signed-off-by: John Snow --- util/hbitmap.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/hbitmap.c

[Qemu-devel] [PATCH 10/12] iotests: teach FilePath to produce multiple paths

2019-06-19 Thread John Snow
Use "FilePaths" instead of "FilePath" to request multiple files be cleaned up after we leave that object's scope. This is not crucial; but it saves a little typing. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 21 +++-- 1 file changed, 15 insertions(+), 6

[Qemu-devel] [PATCH 12/12] block/backup: loosen restriction on readonly bitmaps

2019-06-19 Thread John Snow
With the "never" sync policy, we actually can utilize readonly bitmaps now. Loosen the check at the QMP level, and tighten it based on provided arguments down at the job creation level instead. Signed-off-by: John Snow --- block/backup.c | 6 ++ blockdev.c | 4 ++-- 2 files changed, 8

Re: [Qemu-devel] [QEMU PATCH v4 10/10] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-19 Thread Maran Wilson
On 6/19/2019 9:21 AM, Liran Alon wrote: Previous commits have added support for migration of nested virtualization workloads. This was done by utilising two new KVM capabilities: KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PAYLOAD. Both which are required in order to correctly migrate such

Re: [Qemu-devel] [PATCH 15/17] dump: Move the code to dump/

2019-06-19 Thread Marc-André Lureau
On Wed, Jun 19, 2019 at 10:10 PM Markus Armbruster wrote: > > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > MAINTAINERS | 2 +- > Makefile.target | 3 +-- > dump/Makefile.objs| 2 ++ > dump.c =>

Re: [Qemu-devel] [PATCH v3 7/9] target/i386: Support multi-dies when host doesn't support CPUID.1F

2019-06-19 Thread Eduardo Habkost
On Wed, Jun 19, 2019 at 04:15:46PM -0300, Eduardo Habkost wrote: > On Wed, Jun 12, 2019 at 04:41:02PM +0800, Like Xu wrote: > > In guest CPUID generation process, the cpuid_min_level would be adjusted to > > the maximum passed value for basic CPUID configuration and it should not be > > restricted

Re: [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump"

2019-06-19 Thread Marc-André Lureau
On Wed, Jun 19, 2019 at 10:10 PM Markus Armbruster wrote: > > Commit 2da91b54fe9 "dump: add Windows dump format to > dump-guest-memory" neglected to update MAINTAINERS. Do it now. > > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster argh, I guess I will CC relevant people ;)

Re: [Qemu-devel] [PATCH 14/17] qapi: Split dump.json off misc.json

2019-06-19 Thread Marc-André Lureau
On Wed, Jun 19, 2019 at 10:10 PM Markus Armbruster wrote: > > Move commands dump-guest-memory, query-dump, > query-dump-guest-memory-capability with their types from misc.json to > new dump.json. Add dump.json to MAINTAINERS section "Dump". > > Cc: Marc-André Lureau > Signed-off-by: Markus

Re: [Qemu-devel] [PULL 0/6] update edk2 submodule & binaries to edk2-stable201905

2019-06-19 Thread Laszlo Ersek
On 06/17/19 12:54, Peter Maydell wrote: > On Fri, 14 Jun 2019 at 21:25, Laszlo Ersek wrote: >> >> The following changes since commit f3d0bec9f80e4ed7796fffa834ba0a53f2094f7f: >> >> Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-14' >> into staging (2019-06-14 14:46:13

Re: [Qemu-devel] [PATCH v3 6/9] i386/cpu: Add CPUID.1F generation support for multi-dies PCMachine

2019-06-19 Thread Eduardo Habkost
I've just noticed one thing I don't understand: On Wed, Jun 12, 2019 at 04:41:01PM +0800, Like Xu wrote: > The CPUID.1F as Intel V2 Extended Topology Enumeration Leaf would be > exposed if guests want to emulate multiple software-visible die within > each package. Per Intel's SDM, the 0x1f is a

Re: [Qemu-devel] [PATCH v8 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190619221933.1981-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v8 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine Type: series Message-id:

[Qemu-devel] [PATCH v8 04/10] hw/m68k: add via support

2019-06-19 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/misc/Kconfig | 4 + hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 667 ++

[Qemu-devel] [PATCH v8 09/10] hw/m68k: add a dummy SWIM floppy controller

2019-06-19 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/block/Kconfig| 3 + hw/block/Makefile.objs | 1 + hw/block/swim.c | 415 include/hw/block/swim.h |

[Qemu-devel] [PATCH v8 06/10] hw/m68k: add macfb video card

2019-06-19 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- arch_init.c| 4 + hw/display/Kconfig | 3 + hw/display/Makefile.objs | 1 + hw/display/macfb.c |

[Qemu-devel] [PATCH v8 03/10] dp8393x: manage big endian bus

2019-06-19 Thread Laurent Vivier
This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 +++- 1 file

[Qemu-devel] [PATCH v8 02/10] esp: add pseudo-DMA as used by Macintosh

2019-06-19 Thread Laurent Vivier
There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.c:MAC_ESP_PDMA_LOOP(). The start of the

[Qemu-devel] [PATCH v8 05/10] hw/m68k: implement ADB bus support for via

2019-06-19 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- hw/misc/mac_via.c | 190 ++ include/hw/misc/mac_via.h | 7 ++ 2 files changed, 197

[Qemu-devel] [PATCH v8 08/10] hw/m68k: add Nubus support for macfb video card

2019-06-19 Thread Laurent Vivier
From: Mark Cave-Ayland Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/display/Kconfig | 1 + hw/display/macfb.c | 56 ++ include/hw/display/macfb.h | 21

[Qemu-devel] [PATCH v8 07/10] hw/m68k: add Nubus support

2019-06-19 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- hw/Kconfig | 1 + hw/Makefile.objs| 1 + hw/nubus/Kconfig| 2 + hw/nubus/Makefile.objs

[Qemu-devel] [PATCH v8 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-06-19 Thread Laurent Vivier
I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer, with: ... -M q800 \ -serial

[Qemu-devel] [PATCH v8 10/10] hw/m68k: define Macintosh Quadra 800

2019-06-19 Thread Laurent Vivier
If you want to test the machine, it doesn't yet boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer with: ./qemu-system-m68k \ -M q800 \ -serial none -serial mon:stdio \ -m 1000M -drive

[Qemu-devel] [PATCH v8 01/10] escc: introduce a selector for the register bit

2019-06-19 Thread Laurent Vivier
On Sparc and PowerMac, the bit 0 of the address selects the register type (control or data) and bit 1 selects the channel (B or A). On m68k Macintosh, the bit 0 selects the channel and bit 1 the register type. This patch introduces a new parameter (bit_swap) to the device interface to indicate

Re: [Qemu-devel] [RFC v1 3/5] hw/riscv: Extend the kernel loading support

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 2:01 PM Alistair Francis wrote: > > On Wed, Jun 19, 2019 at 8:16 AM Bin Meng wrote: > > > > On Wed, Jun 19, 2019 at 8:56 AM Alistair Francis > > wrote: > > > > > > Extend the RISC-V kernel loader to support uImage and Image files. > > > A Linux kernel can now be booted

Re: [Qemu-devel] [QEMU PATCH v4 06/10] linux-headers: i386: Modify struct kvm_nested_state to have explicit fields for data

2019-06-19 Thread Maran Wilson
On 6/19/2019 9:21 AM, Liran Alon wrote: Improve the KVM_{GET,SET}_NESTED_STATE structs by detailing the format of VMX nested state data in a struct. In order to avoid changing the ioctl values of KVM_{GET,SET}_NESTED_STATE, there is a need to preserve sizeof(struct kvm_nested_state). This is

Re: [Qemu-devel] [RFC v1 3/5] hw/riscv: Extend the kernel loading support

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 8:16 AM Bin Meng wrote: > > On Wed, Jun 19, 2019 at 8:56 AM Alistair Francis > wrote: > > > > Extend the RISC-V kernel loader to support uImage and Image files. > > A Linux kernel can now be booted with: > > > > qemu-system-riscv64 -machine virt -bios fw_jump.elf

Re: [Qemu-devel] [Qemu-riscv] [RFC v1 2/5] hw/riscv: Add support for loading a firmware

2019-06-19 Thread Alistair Francis
On Wed, Jun 19, 2019 at 8:30 AM Bin Meng wrote: > > Hi, > > On Wed, Jun 19, 2019 at 11:26 PM Jonathan Behrens wrote: > > > > I was actually just writing up the same thing. Shifting all the addresses > > in the ELF file by 2 or 4MB is somewhat surprising behavior, especially > > because this

Re: [Qemu-devel] [QEMU PATCH v4 01/10] target/i386: kvm: Delete VMX migration blocker on vCPU init failure

2019-06-19 Thread Maran Wilson
On 6/19/2019 1:33 PM, Liran Alon wrote: On 19 Jun 2019, at 23:30, Maran Wilson wrote: On 6/19/2019 9:21 AM, Liran Alon wrote: Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") added migration blocker for vCPU exposed with Intel VMX because QEMU doesn't yet contain code to

Re: [Qemu-devel] [QEMU PATCH v4 01/10] target/i386: kvm: Delete VMX migration blocker on vCPU init failure

2019-06-19 Thread Liran Alon
> On 19 Jun 2019, at 23:30, Maran Wilson wrote: > > On 6/19/2019 9:21 AM, Liran Alon wrote: >> Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") >> added migration blocker for vCPU exposed with Intel VMX because QEMU >> doesn't yet contain code to support migration of nested

Re: [Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM

2019-06-19 Thread Andreas Färber
Am 19.06.19 um 22:10 schrieb Markus Armbruster: > From: Paolo Bonzini > > QOM is not a particularly active subsystem now: 51 commits in two years. > But, we need active maintainers to review and merge patches, and Git > shows the following top committers taking on QOM: > > Markus Armbruster

Re: [Qemu-devel] [PATCH v1 2/4] disas/riscv: Disassemble reserved compressed encodings as illegal

2019-06-19 Thread Alistair Francis
On Fri, Jun 14, 2019 at 2:18 AM Palmer Dabbelt wrote: > > On Fri, 17 May 2019 15:11:01 PDT (-0700), Alistair Francis wrote: > > From: Michael Clark > > > > Due to the design of the disassembler, the immediate is not > > known during decoding of the opcode; so to handle compressed > > encodings

Re: [Qemu-devel] [QEMU PATCH v4 01/10] target/i386: kvm: Delete VMX migration blocker on vCPU init failure

2019-06-19 Thread Maran Wilson
On 6/19/2019 9:21 AM, Liran Alon wrote: Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker") added migration blocker for vCPU exposed with Intel VMX because QEMU doesn't yet contain code to support migration of nested virtualization workloads. However, that commit missed adding

Re: [Qemu-devel] [PATCH 17/17] dump: Move HMP command handlers to dump/

2019-06-19 Thread Eric Blake
On 6/19/19 3:10 PM, Markus Armbruster wrote: > Move the HMP handlers related to qapi/dump.json to > dimp/dump-hmp-cmds.c, where they are covered by MAINTAINERS section s/dimp/dump/ > "Dump", just like qapi/dump.json. > > Cc: Marc-André Lureau > Cc: "Dr. David Alan Gilbert" > Signed-off-by:

Re: [Qemu-devel] [PATCH 12/17] qapi: Split machine-target.json off target.json and misc.json

2019-06-19 Thread Eric Blake
On 6/19/19 3:10 PM, Markus Armbruster wrote: > Move commands query-cpu-definitions, query-cpu-model-baseline, > query-cpu-model-comparison, and query-cpu-model-expansion with their > types from target.json to machine-target.json. Also move typee s/typee/types/ > CpuModelInfo,

[Qemu-devel] [PATCH 10/17] hw/core: Collect QMP command handlers in hw/core/

2019-06-19 Thread Markus Armbruster
The handlers for qapi/machine.json's QMP commands are spread over cpus.c, hw/core/numa.c, monitor/misc.c, monitor/qmp-cmds.c, and vl.c. Move them all to new hw/core/machine-qmp-cmds.c, where they are covered by MAINTAINERS section "Machine core", just like qapi/machine.json. Cc: Eduardo Habkost

[Qemu-devel] [PATCH 06/17] qom: Move HMP command handlers to qom/

2019-06-19 Thread Markus Armbruster
There are just two HMP commands related to QOM: qom-list and qom-set. Move their handlers from monitor/hmp-cmds.c to new qom/qom-hmp-cmds.c, where they are covered by MAINTAINERS section QOM. Cc: Paolo Bonzini Cc: "Daniel P. Berrange" Cc: Eduardo Habkost Cc: "Dr. David Alan Gilbert"

[Qemu-devel] [PATCH 12/17] qapi: Split machine-target.json off target.json and misc.json

2019-06-19 Thread Markus Armbruster
Move commands query-cpu-definitions, query-cpu-model-baseline, query-cpu-model-comparison, and query-cpu-model-expansion with their types from target.json to machine-target.json. Also move typee CpuModelInfo, CpuModelExpansionType, and CpuModelCompareResult from misc.json there. Add

[Qemu-devel] [PATCH 14/17] qapi: Split dump.json off misc.json

2019-06-19 Thread Markus Armbruster
Move commands dump-guest-memory, query-dump, query-dump-guest-memory-capability with their types from misc.json to new dump.json. Add dump.json to MAINTAINERS section "Dump". Cc: Marc-André Lureau Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + dump.c| 4

[Qemu-devel] [PATCH 08/17] qapi: Split machine.json off misc.json

2019-06-19 Thread Markus Armbruster
Move commands cpu-add, query-cpus, query-cpus-fast, query-current-machine, query-hotpluggable-cpus, query-machines, query-memdev, and set-numa-node with their types from misc.json to new machine.json. Also move types X86CPURegister32 and X86CPUFeatureWordInfo. Add machine.json to MAINTAINERS

[Qemu-devel] [PATCH 17/17] dump: Move HMP command handlers to dump/

2019-06-19 Thread Markus Armbruster
Move the HMP handlers related to qapi/dump.json to dimp/dump-hmp-cmds.c, where they are covered by MAINTAINERS section "Dump", just like qapi/dump.json. Cc: Marc-André Lureau Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbruster --- Makefile.objs| 1 + dump/Makefile.objs |

[Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

2019-06-19 Thread Markus Armbruster
Move commands object-add, object-del, qom-get, qom-list, qom-list-properties, qom-list-types, and qom-set with their types from misc.json to new qom.json. Add qom.json to MAINTAINERS section QOM. Move commands device-list-properties, device_add, device-del, and event DEVICE_DELETED from

[Qemu-devel] [PATCH 13/17] qapi: Rename target.json to misc-target.json

2019-06-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/ppc/spapr_rtc.c | 2 +- hw/s390x/s390-skeys.c | 2 +- hw/timer/mc146818rtc.c | 4 ++-- qapi/Makefile.objs | 2 +- qapi/{target.json => misc-target.json} | 4

[Qemu-devel] [PATCH 03/17] hmp: Move hmp.h to include/monitor/

2019-06-19 Thread Markus Armbruster
Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbruster --- hmp.h => include/monitor/hmp.h | 0 monitor/hmp-cmds.c | 2 +- monitor/misc.c | 2 +- target/i386/monitor.c | 2 +- target/nios2/monitor.c | 2 +- target/ppc/monitor.c | 2 +-

[Qemu-devel] [PATCH 05/17] qom: Move QMP command handlers to qom/

2019-06-19 Thread Markus Armbruster
The handlers for qapi/qom.json's QMP commands are in monitor/qmp-cmds.c. Move them to new qom/qom-qmp-cmds.c, where they are covered by MAINTAINERS section QOM, just like qapi/qom.json. Move along qmp_device_list_properties() even though it's specified in qapi/qdev.json, because it's so similar

[Qemu-devel] [PATCH 11/17] hw/core: Collect HMP command handlers in hw/core/

2019-06-19 Thread Markus Armbruster
Move the HMP handlers related to qapi/machine.json to hw/core/machine-hmp-cmds.c, where they are covered by MAINTAINERS section "Machine core", just like qapi/machine.json. Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbruster ---

[Qemu-devel] [PATCH 07/17] MAINTAINERS: Merge sections CPU, NUMA into Machine core

2019-06-19 Thread Markus Armbruster
Suggested-by: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster --- MAINTAINERS | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1aef0afaf7..f18fdd 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH 00/17] Move QOM, qdev, machine core and dump code

2019-06-19 Thread Markus Armbruster
Split qom.json, qdev.json, machine.json, machine-target.json and dump.json off misc.json, so MAINTAINERS can cover them properly. Move their QMP and HMP code similarly. Move some code out of the the tree's root directory to better places. Markus Armbruster (16): Makefile: Don't add monitor/

[Qemu-devel] [PATCH 09/17] hw/core: Move numa.c to hw/core/

2019-06-19 Thread Markus Armbruster
Cc: Eduardo Habkost Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster --- MAINTAINERS | 2 +- Makefile.target | 2 +- hw/core/Makefile.objs| 2 ++ numa.c => hw/core/numa.c | 0 4 files changed, 4 insertions(+), 2 deletions(-) rename numa.c => hw/core/numa.c

[Qemu-devel] [PATCH 15/17] dump: Move the code to dump/

2019-06-19 Thread Markus Armbruster
Cc: Marc-André Lureau Signed-off-by: Markus Armbruster --- MAINTAINERS | 2 +- Makefile.target | 3 +-- dump/Makefile.objs| 2 ++ dump.c => dump/dump.c | 0 win_dump.c => dump/win_dump.c | 0 win_dump.h => dump/win_dump.h | 0 6 files changed,

[Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump"

2019-06-19 Thread Markus Armbruster
Commit 2da91b54fe9 "dump: add Windows dump format to dump-guest-memory" neglected to update MAINTAINERS. Do it now. Cc: Marc-André Lureau Signed-off-by: Markus Armbruster --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM

2019-06-19 Thread Markus Armbruster
From: Paolo Bonzini QOM is not a particularly active subsystem now: 51 commits in two years. But, we need active maintainers to review and merge patches, and Git shows the following top committers taking on QOM: Markus Armbruster Eduardo Habkost Paolo Bonzini Marc-André

[Qemu-devel] [PATCH 02/17] Makefile: Don't add monitor/ twice to common-obj-y

2019-06-19 Thread Markus Armbruster
Both commit f1b3ccfaa68 "monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c" and commit 7e3c0deab1b "monitor: Split out monitor/qmp.c" added monitor/ to common-obj-y ifeq ($(CONFIG_SOFTMMU),y). Revert the second addition. Signed-off-by: Markus Armbruster --- Makefile.objs | 1 - 1 file

[Qemu-devel] [PATCH v1 16/17] .travis.yml: default the --disable-system build to --static

2019-06-19 Thread Alex Bennée
It's fairly common to build qemu-user binaries with --static linking so the binary can be copied around without libraries. Enable --static in the default qemu-user build to cover this. There are other qemu-user builds that use dynamic linking so they should catch any problems there.

[Qemu-devel] [PATCH v1 12/17] tests/vm: freebsd autoinstall, using serial console

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Note that freebsd package downloads are

[Qemu-devel] [PATCH v1 15/17] tests/vm: ubuntu.i386: apt proxy setup

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Configure apt proxy so package downloads can be cached and can pass firewalls. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190617043858.8290-12-kra...@redhat.com> --- tests/vm/ubuntu.i386 | 4 1 file changed, 4 insertions(+) diff

[Qemu-devel] [PATCH v1 17/17] .travis.yml: force a brew update for MacOS builds

2019-06-19 Thread Alex Bennée
It looks like the Travis image package databases are out of date causing the build to error with: Error: Your Homebrew is outdated. Please run `brew update`. Error: Kernel.exit Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml

[Qemu-devel] [PATCH v1 11/17] tests/vm: openbsd autoinstall, using serial console

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH v1 08/17] tests/vm: proper guest shutdown

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann When not running in snapshot mode ask the guest to poweroff and wait for this to finish instead of simply quitting qemu, so the guest can flush pending updates to disk. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by:

[Qemu-devel] [PATCH v1 07/17] tests/vm: run test builds on snapshot

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann The build script doesn't shutdown the guest VMs properly, which results in filesystem corruption and guest boot failures sooner or later. Use the --snapshot to run builds on a snapshot, That way killing the VM doesn't corrupt the base image. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH v1 13/17] tests/vm: netbsd autoinstall, using serial console

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH v1 09/17] tests/vm: add vm-boot-{ssh, serial}- targets

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann For testing/troubleshooting convenience. make vm-boot-serial- Boot guest, with the serial console on stdio. make vm-boot-ssh- Boot guest, login via ssh. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v1 14/17] tests/vm: fedora autoinstall, using serial console

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Yes, we have docker images for fedora. But for trouble-shooting it might be helpful to have a

[Qemu-devel] [PATCH v1 03/17] tests/vm: pin ubuntu.i386 image

2019-06-19 Thread Alex Bennée
From: Cleber Rosa It's a good practice to always have the same components used in tests. According to: https://cloud-images.ubuntu.com/releases/16.04/ New images are released from time to time, and the "release/" directory points to the latest release. Let's pin to the latest available

[Qemu-devel] [PATCH v1 02/17] tests/vm: avoid image presence check and removal

2019-06-19 Thread Alex Bennée
From: Cleber Rosa Python's os.rename() will silently replace an existing file, so there's no need for the extra check and removal. Reference: https://docs.python.org/3/library/os.html#os.rename Signed-off-by: Cleber Rosa Message-Id: <20190613130718.3763-3-cr...@redhat.com> Signed-off-by: Alex

[Qemu-devel] [PATCH v1 05/17] tests/vm: send proxy environment variables over ssh

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Packages are fetched via proxy that way, if configured on the host. That might be required to pass firewalls, and it allows to route package downloads through a caching proxy server. Needs AcceptEnv setup in sshd_config on the guest side to work. Signed-off-by: Gerd

[Qemu-devel] [PATCH v1 04/17] tests/vm: add source repos on ubuntu.i386

2019-06-19 Thread Alex Bennée
From: Cleber Rosa Possibly because of different behavior on the newly update cloud-image, trying to run 'apt-get build-dep' results in: E: You must put some 'source' URIs in your sources.list This enables all source repos (even though some are not needed) for simplicity sake.

[Qemu-devel] [PATCH v1 06/17] tests/vm: use ssh with pty unconditionally

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Allways ask ssh to run with a pseudo terminal. Not having a terminal causes problems now and then. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PATCH v1 00/17] testing/next (Travis fixes, more tests/vm)

2019-06-19 Thread Alex Bennée
Hi, This is the current state of testing/next which has fixes for the MacOS Travis failures. We also have the return of the bsd-over-serial autosetup patches which I've tested on the previously failing platform. The one thing I've not included is adding check-block to the default set of check

[Qemu-devel] [PATCH v1 01/17] tests/vm: avoid extra compressed image copy

2019-06-19 Thread Alex Bennée
From: Cleber Rosa The image copy is only really needed because xz doesn't know to properly decompress a file not named properly. Instead of decompressing to stdout, and having to rely on a shell, let's just create a link instead of copying the file. Signed-off-by: Cleber Rosa Message-Id:

[Qemu-devel] [PATCH v1 10/17] tests/vm: serial console support helpers

2019-06-19 Thread Alex Bennée
From: Gerd Hoffmann Add a bunch of helpers to talk to the guest using the serial console. Also drop the hard-coded -serial parameter for the vm so QEMUMachine.set_console() actually works. Signed-off-by: Gerd Hoffmann Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [Qemu-devel] [PATCH 1/2] vl: Drain before (block) job cancel when quitting

2019-06-19 Thread Max Reitz
On 14.06.19 11:22, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 19:03, Max Reitz wrote: >> [re-adding the original CCs, why not] >> >> On 13.06.19 16:30, Vladimir Sementsov-Ogievskiy wrote: >>> 13.06.2019 17:21, Max Reitz wrote: On 13.06.19 16:19, Vladimir Sementsov-Ogievskiy wrote: >

Re: [Qemu-devel] [PATCH v2] iotest 134: test cluster-misaligned encrypted write

2019-06-19 Thread Max Reitz
On 16.05.19 16:30, Anton Nefedov wrote: > COW (even empty/zero) areas require encryption too > > Signed-off-by: Anton Nefedov > Reviewed-by: Eric Blake > Reviewed-by: Max Reitz > Reviewed-by: Alberto Garcia > --- > > ..apparently v1 ended up in a weird base64 that would not easily git-am. >

Re: [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base

2019-06-19 Thread Max Reitz
On 29.05.19 19:56, Andrey Shinkevich wrote: > This series introduces a bottom intermediate node that eliminates the > dependency on the base that may change while stream job is running. > It happens when stream/commit parallel jobs are running on the same > backing chain. The base node of the

Re: [Qemu-devel] [PATCH v7 1/3] block: include base when checking image chain for block allocation

2019-06-19 Thread Max Reitz
On 29.05.19 19:56, Andrey Shinkevich wrote: > This patch is used in the 'block/stream: introduce a bottom node' > that is following. Instead of the base node, the caller may pass > the node that has the base as its backing image to the function > bdrv_is_allocated_above() with a new parameter

  1   2   3   >