Re: [Qemu-devel] [PATCH v29 8/8] target/avr: Add tests

2019-08-25 Thread Thomas Huth
On 24/08/2019 20.46, Michael Rolnik wrote: > 1. Avocado test > The test is based on > https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo > demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. > it also demostrates that timer and IRQ are

[Qemu-devel] [PATCH qemu] spapr: Render full FDT on ibm, client-architecture-support

2019-08-25 Thread Alexey Kardashevskiy
The ibm,client-architecture-support call is a way for the guest to negotiate capabilities with a hypervisor. It is implemented as: - the guest calls SLOF via client interface; - SLOF calls QEMU (H_CAS hypercall) with an options vector from the guest; - QEMU returns a device tree diff (which uses

Re: [Qemu-devel] [RFC PATCH qemu] qapi: Add query-memory-checksum

2019-08-25 Thread Alexey Kardashevskiy
On 23/08/2019 21:41, Markus Armbruster wrote: Daniel P. Berrangé writes: On Fri, Aug 23, 2019 at 07:49:31AM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: On Thu, Aug 22, 2019 at 04:16:53PM +0200, Markus Armbruster wrote: Alexey Kardashevskiy writes: This returns MD5

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 6:10 PM, Richard Henderson wrote: > On 8/25/19 1:43 PM, Peter Maydell wrote: >> I'm still confused, I think. The hint space is >> + NOP 0011 1010 1000 >> (plus the more specific hint insns before that pattern with >> fixed values in the [7:0] bits).

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 1:43 PM, Peter Maydell wrote: > I'm still confused, I think. The hint space is > + NOP 0011 1010 1000 > (plus the more specific hint insns before that pattern with > fixed values in the [7:0] bits). > CPS falls into that space; but you've placed it

[Qemu-devel] [PATCH 3/3] audio: paaudio: ability to specify stream name

2019-08-25 Thread Kővágó, Zoltán
This can be used to identify stream in tools like pavucontrol when one creates multiple -audiodevs or runs multiple qemu instances. Signed-off-by: Kővágó, Zoltán --- qapi/audio.json | 6 ++ audio/paaudio.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 2/3] audio: paaudio: fix client name

2019-08-25 Thread Kővágó, Zoltán
pa_context_new expects a client name, not a server socket path. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index bfef9acaad..777b8e4718 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c

[Qemu-devel] [PATCH 0/3] Audio: misc fixes for "Audio 20190821 patches"

2019-08-25 Thread Kővágó, Zoltán
Hi, This series fixes two problems reported by Maxim Levitsky in relation of my multiple audio backend patch series, and a small feature request. Unfortunately I don't really use PulseAudio nowadays, so I haven't tested it other than making sure it compiles and connects to pa. Regards, Zoltan

[Qemu-devel] [PATCH 1/3] audio: omitting audiodev= parameter is only deprecated

2019-08-25 Thread Kővágó, Zoltán
Unfortunately, changes introduced in af2041ed2d "audio: audiodev= parameters no longer optional when -audiodev present" breaks backward compatibility. This patch changes the error into a deprecation warning. Signed-off-by: Kővágó, Zoltán --- qemu-deprecated.texi | 7 +++ audio/audio.c

Re: [Qemu-devel] [PULL 07/15] audio: audiodev= parameters no longer optional when -audiodev present

2019-08-25 Thread Zoltán Kővágó
On 2019-08-26 00:15, Maxim Levitsky wrote: > On Sun, 2019-08-25 at 20:05 +0200, Zoltán Kővágó wrote: >> On 2019-08-25 11:44, Maxim Levitsky wrote: >>> On Wed, 2019-08-21 at 10:41 +0200, Gerd Hoffmann wrote: From: Kővágó, Zoltán This means you should probably stop using -soundhw (as

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-25 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: > > Did you make your test with commit 126c04acbabd ("Fix heap overflow in > > ip_reass on big packet input") applied? > > Yes, unfortunately it doesn't fix the issue. Ok. Could you try the attached patch? There was

Re: [Qemu-devel] [PATCH v2 2/2] iotests: Test allocate_first_block() with O_DIRECT

2019-08-25 Thread Nir Soffer
On Mon, Aug 26, 2019 at 1:03 AM Nir Soffer wrote: > Using block_resize we can test allocate_first_block() with file > descriptor opened with O_DIRECT, ensuring that it works for any size > larger than 4096 bytes. > > Testing smaller sizes is tricky as the result depends on the filesystem > used

Re: [Qemu-devel] [PATCH v2 0/2] Optimize alignment probing

2019-08-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190825220329.7942-1-nsof...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/2] Optimize alignment probing Message-id:

[Qemu-devel] [PATCH] target/xtensa: linux-user: add call0 ABI support

2019-08-25 Thread Max Filippov
Xtensa binaries built for call0 ABI don't rotate register window on function calls and returns. Invocation of signal handlers from the kernel is therefore different in windowed and call0 ABIs. There's currently no way to determine xtensa ELF binary ABI from the binary itself. Provide an

Re: [Qemu-devel] [Qemu-block] [PATCH] block: posix: Always allocate the first block

2019-08-25 Thread Maxim Levitsky
On Sun, 2019-08-25 at 22:51 +0300, Nir Soffer wrote: > On Sun, Aug 25, 2019 at 10:44 AM Maxim Levitsky wrote: > > On Sat, 2019-08-17 at 00:21 +0300, Nir Soffer wrote: > > > When creating an image with preallocation "off" or "falloc", the first > > > block of the image is typically not allocated.

Re: [Qemu-devel] [PULL 07/15] audio: audiodev= parameters no longer optional when -audiodev present

2019-08-25 Thread Maxim Levitsky
On Sun, 2019-08-25 at 20:05 +0200, Zoltán Kővágó wrote: > On 2019-08-25 11:44, Maxim Levitsky wrote: > > On Wed, 2019-08-21 at 10:41 +0200, Gerd Hoffmann wrote: > > > From: Kővágó, Zoltán > > > > > > This means you should probably stop using -soundhw (as it doesn't allow > > > you to specify any

[Qemu-devel] [PATCH v2 2/2] iotests: Test allocate_first_block() with O_DIRECT

2019-08-25 Thread Nir Soffer
Using block_resize we can test allocate_first_block() with file descriptor opened with O_DIRECT, ensuring that it works for any size larger than 4096 bytes. Testing smaller sizes is tricky as the result depends on the filesystem used for testing. For example on NFS any size will work since

[Qemu-devel] [PATCH v2 0/2] Optimize alignment probing

2019-08-25 Thread Nir Soffer
When probing unallocated area on XFS filesystem we cannot detect request alignment and we fallback to safe value which may not be optimal. Avoid this fallback by always allocating the first block when creating a new image or resizing empty image. I tested v1 only with -raw format, and missed some

[Qemu-devel] [PATCH v2 1/2] block: posix: Always allocate the first block

2019-08-25 Thread Nir Soffer
When creating an image with preallocation "off" or "falloc", the first block of the image is typically not allocated. When using Gluster storage backed by XFS filesystem, reading this block using direct I/O succeeds regardless of request length, fooling alignment detection. In this case we

Re: [Qemu-devel] [PATCH v2 53/68] target/arm: Convert T16 add, compare, move (two high registers)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 49 ++ > target/arm/t16.decode | 10 + > 2 files changed, 12 insertions(+), 47 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 52/68] target/arm: Convert T16 branch and exchange

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 51/68] target/arm: Convert T16 one low register and immediate

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 50/68] target/arm: Convert T16 add/sub (3 low, 2 low and imm)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 26 ++ > target/arm/t16.decode | 16 > 2 files changed, 18 insertions(+), 24 deletions(-) Reviewed-by: Peter Maydell thanks

Re: [Qemu-devel] [PATCH v2 49/68] target/arm: Convert T16 load/store multiple

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 48 -- > target/arm/t16.decode | 8 +++ > 2 files changed, 17 insertions(+), 39 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 48/68] target/arm: Convert T16 add pc/sp (immediate)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 12 +--- > target/arm/t16.decode | 7 +++ > 2 files changed, 8 insertions(+), 11 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 47/68] target/arm: Convert T16 load/store (immediate offset)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 94 +++--- > target/arm/t16.decode | 33 +++ > 2 files changed, 38 insertions(+), 89 deletions(-) Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v2 46/68] target/arm: Convert T16 load/store (register offset)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 51 ++ > target/arm/t16.decode | 15 + > 2 files changed, 17 insertions(+), 49 deletions(-) Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v2 45/68] target/arm: Convert T16 data-processing (two low regs)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 152 ++--- > target/arm/t16.decode | 36 ++ > 2 files changed, 43 insertions(+), 145 deletions(-) Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Peter Maydell
On Sun, 25 Aug 2019 at 18:28, Richard Henderson wrote: > > On 8/25/19 9:20 AM, Peter Maydell wrote: > > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > > wrote: > >> > >> Signed-off-by: Richard Henderson > >> --- > >> target/arm/translate.c | 87 +++- >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: posix: Always allocate the first block

2019-08-25 Thread Nir Soffer
On Sun, Aug 25, 2019 at 10:44 AM Maxim Levitsky wrote: > On Sat, 2019-08-17 at 00:21 +0300, Nir Soffer wrote: > > When creating an image with preallocation "off" or "falloc", the first > > block of the image is typically not allocated. When using Gluster > > storage backed by XFS filesystem,

[Qemu-devel] [PULL 0/1] target/alpha queue

2019-08-25 Thread Richard Henderson
The following changes since commit 586f3dced9f2b354480c140c070a3d02a0c66a1e: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190822' into staging (2019-08-23 15:15:44 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-axp-20190825

[Qemu-devel] [PULL 1/1] target/alpha: fix tlb_fill trap_arg2 value for instruction fetch

2019-08-25 Thread Richard Henderson
From: Aurelien Jarno Commit e41c94529740cc26 ("target/alpha: Convert to CPUClass::tlb_fill") slightly changed the way the trap_arg2 value is computed in case of TLB fill. The type of the variable used in the ternary operator has been changed from an int to an enum. This causes the -1 value to

[Qemu-devel] [GSOC] Support for AVX within TCG: Work Product Submission

2019-08-25 Thread Jan Bobek
Hi folks, those of you who have been keeping up with Google Summer of Code this year might know that it's nearly over -- meaning that it's time for me to summarize all the work that I have done as a participant. Without further ado, you can find the summary attached below. Huge thanks to

[Qemu-devel] [PATCH 22/25] paaudio: channel-map option

2019-08-25 Thread Kővágó, Zoltán
Add an option to change the channel map used by pulseaudio. If not specified, falls back to an OSS compatible channel map. Signed-off-by: Kővágó, Zoltán --- qapi/audio.json | 7 +-- audio/paaudio.c | 18 ++ qemu-options.hx | 9 + 3 files changed, 28 insertions(+),

[Qemu-devel] [PATCH 19/25] audio: support more than two channels in volume setting

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.h | 10 ++ audio/audio_int.h | 4 ++-- audio/audio.c | 30 ++ audio/paaudio.c| 20 audio/spiceaudio.c | 14 -- 5 files changed, 54 insertions(+), 24 deletions(-)

[Qemu-devel] [PATCH 15/25] audio: split ctl_* functions into enable_* and volume_*

2019-08-25 Thread Kővágó, Zoltán
This way we no longer need vararg functions, improving compile time error detection. Also now it's possible to check actually what commands are supported, without needing to manually update ctl_caps. Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 15 ++--- audio/audio_template.h |

[Qemu-devel] [PATCH 25/25] usbaudio: change playback counters to 64 bit

2019-08-25 Thread Kővágó, Zoltán
With stereo playback, they need about 375 minutes of continuous audio playback to overflow, which is usually not a problem (as stopping and later resuming playback resets the counters). But with 7.1 audio, they only need about 95 minutes to overflow. After the overflow, the buf->prod %

[Qemu-devel] [PATCH 21/25] audio: basic support for multichannel audio

2019-08-25 Thread Kővágó, Zoltán
Which currently only means removing some checks. Old code won't require more than two channels, but new code will need it. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 7 --- audio/audio.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/audio/alsaaudio.c

[Qemu-devel] [PATCH 16/25] audio: add mixeng option (documentation)

2019-08-25 Thread Kővágó, Zoltán
This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just convert it to a third format. We no longer convert, only the underlying

[Qemu-devel] [PATCH 23/25] usb-audio: do not count on avail bytes actually available

2019-08-25 Thread Kővágó, Zoltán
This assumption is no longer true when mixeng is turned off. Signed-off-by: Kővágó, Zoltán --- hw/usb/dev-audio.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index ae42e5a2f1..74c99b1f12 100644 ---

[Qemu-devel] [PATCH 13/25] audio: remove hw->samples, buffer_size_in/out pcm_ops

2019-08-25 Thread Kővágó, Zoltán
This patch removes the samples member from HWVoiceIn and HWVoiceOut. Backends can specify buffer size via the newly added buffer_size_in and buffer_size_out functions in audio_pcm_ops. They are optional, if not defined qemu will fall back to some built-in constant. Signed-off-by: Kővágó, Zoltán

[Qemu-devel] [PATCH 14/25] audio: common rate control code for timer based outputs

2019-08-25 Thread Kővágó, Zoltán
This commit removes the ad-hoc rate-limiting code from noaudio and wavaudio, and replaces them with a (slightly modified) code from spiceaudio. This way multiple write calls (for example when the circular buffer wraps around) do not cause problems. Signed-off-by: Kővágó, Zoltán ---

[Qemu-devel] [PATCH 17/25] audio: make mixeng optional

2019-08-25 Thread Kővágó, Zoltán
Implementation of the previously added mixeng option. Signed-off-by: Kővágó, Zoltán --- audio/audio_template.h | 46 --- audio/audio.c | 70 ++ 2 files changed, 92 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] [PATCH 07/25] paaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- configure| 5 - audio/audio_pt_int.h | 22 --- audio/audio_pt_int.c | 173 audio/paaudio.c | 372 ++- audio/Makefile.objs | 1 - 5 files changed, 45 insertions(+), 528

[Qemu-devel] [PATCH 12/25] audio: unify input and output mixeng buffer management

2019-08-25 Thread Kővágó, Zoltán
Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the initial size of the STSampleBuffer. The next commit tries to fix this inconsistency. Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 12

[Qemu-devel] [PATCH 11/25] audio: remove remains of the old backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 7 --- audio/audio.c | 42 ++ 2 files changed, 6 insertions(+), 43 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index 8fb1ca8a8d..c76d7c39e8 100644 --- a/audio/audio_int.h

[Qemu-devel] [PATCH 06/25] ossaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/ossaudio.c | 288 +-- 1 file changed, 104 insertions(+), 184 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 1696933688..2782512706 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@

[Qemu-devel] [PATCH 04/25] dsoundaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/dsound_template.h | 47 +++--- audio/dsoundaudio.c | 329 ++-- 2 files changed, 103 insertions(+), 273 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index 8ece870c9e..9f10b688df 100644

[Qemu-devel] [PATCH 10/25] wavaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/wavaudio.c | 54 1 file changed, 9 insertions(+), 45 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index b6eeeb4e26..7816097db8 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c @@ -36,52

[Qemu-devel] [PATCH 20/25] audio: replace shift in audio_pcm_info with bytes_per_frame

2019-08-25 Thread Kővágó, Zoltán
The bit shifting trick worked because the number of bytes per frame was always a power-of-two (since QEMU only supports mono, stereo and 8, 16 and 32 bit samples). But if we want to add support for surround sound, this no longer holds true. Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h

[Qemu-devel] [PATCH 03/25] coreaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/coreaudio.c | 130 -- 1 file changed, 69 insertions(+), 61 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index d1be58b40a..5cde42f982 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@

[Qemu-devel] [PATCH 02/25] alsaaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 308 +- 1 file changed, 83 insertions(+), 225 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 591344dccd..19124d09d8 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@

[Qemu-devel] [PATCH 08/25] sdlaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/sdlaudio.c | 87 +++- 1 file changed, 42 insertions(+), 45 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 14b11f0335..f7ac8cd101 100644 --- a/audio/sdlaudio.c +++ b/audio/sdlaudio.c @@ -41,8

[Qemu-devel] [PATCH 01/25] audio: api for mixeng code free backends

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 41 ++-- audio/audio_template.h | 1 + audio/audio.c | 211 - 3 files changed, 245 insertions(+), 8 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index

[Qemu-devel] [PATCH 00/25] Audio: Mixeng-free 5.1/7.1 audio support

2019-08-25 Thread Kővágó, Zoltán
Hi, This is the final part of my audio patch series that finally makes mixeng optional and lifts the restriction of only supporting two channels of audio. It probably gained a bit of dust in the last few years, I've fixed most issues reported by checkpatch, but there might be other problems.

[Qemu-devel] [PATCH 05/25] noaudio: port to the new audio backend api

2019-08-25 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/noaudio.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 0fb2629cf2..b054fd225b 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -41,10 +41,9 @@

Re: [Qemu-devel] [PULL 07/15] audio: audiodev= parameters no longer optional when -audiodev present

2019-08-25 Thread Zoltán Kővágó
On 2019-08-25 11:44, Maxim Levitsky wrote: > On Wed, 2019-08-21 at 10:41 +0200, Gerd Hoffmann wrote: >> From: Kővágó, Zoltán >> >> This means you should probably stop using -soundhw (as it doesn't allow >> you to specify any options) and add the device manually with -device. >> The exception is

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 10:28 AM, Richard Henderson wrote: >> CPS shouldn't exist at all for M-profile, but the legacy decoder >> got this wrong too, so we should put that on the todo list for >> fixing later (along, maybe, with UNDEFing on some of the >> unpredictable combinations of M/imod/etc for A

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Richard Henderson
On 8/25/19 9:20 AM, Peter Maydell wrote: > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > wrote: >> >> Signed-off-by: Richard Henderson >> --- >> target/arm/translate.c | 87 +++- >> target/arm/a32-uncond.decode | 3 ++ >> target/arm/t32.decode|

Re: [Qemu-devel] [PATCH 05/13] qcrypto-luks: clear the masterkey and password before freeing them always

2019-08-25 Thread Maxim Levitsky
On Sun, 2019-08-25 at 18:31 +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 13:56 +0300, Maxim Levitsky wrote: > > On Thu, 2019-08-22 at 11:49 +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 20, 2019 at 08:12:51PM +0200, Max Reitz wrote: > > > > On 14.08.19 22:22, Maxim Levitsky wrote: > >

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:35 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:06PM +0300, Maxim Levitsky wrote: > > Hi! > > > > This patch series implements key management for luks based encryption > > It supports both raw luks images and qcow2 encrypted images. > > > > Bugzilla:

Re: [Qemu-devel] [PATCH 12/13] qemu-img: implement key management

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 16:42 +0200, Max Reitz wrote: > On 22.08.19 13:32, Daniel P. Berrangé wrote: > > On Tue, Aug 20, 2019 at 08:29:55PM +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > Signed-off-by: Maxim Levitsky > > > > --- > > > > block/crypto.c | 16 ++

Re: [Qemu-devel] [PATCH 09/13] qcrypto-luks: implement the encryption key management

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:27 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:15PM +0300, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > crypto/block-luks.c | 374 +++- > > 1 file changed, 373 insertions(+), 1

Re: [Qemu-devel] [PATCH 07/13] block: add manage-encryption command (qmp and blockdev)

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 16:07 +0200, Markus Armbruster wrote: > Maxim Levitsky writes: > > > On Wed, 2019-08-21 at 13:47 +0200, Markus Armbruster wrote: > > > Maxim Levitsky writes: > > > > > > > This adds: > > > > > > > > * x-blockdev-update-encryption and x-blockdev-erase-encryption qmp > >

Re: [Qemu-devel] [PATCH v2 43/68] target/arm: Simplify disas_arm_insn

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Fold away all of the cases that now just goto illegal_op, > because all of their internal bits are now in decodetree. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 69 ++ >

Re: [Qemu-devel] [PATCH v2 42/68] target/arm: Simplify disas_thumb2_insn

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Fold away all of the cases that now just goto illegal_op, > because all of their internal bits are now in decodetree. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 41/68] target/arm: Convert TT

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 87 +- > target/arm/t32.decode | 5 ++- > 2 files changed, 31 insertions(+), 61 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 40/68] target/arm: Convert SG

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 51 -- > target/arm/t32.decode | 5 - > 2 files changed, 33 insertions(+), 23 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 39/68] target/arm: Convert Table Branch

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 57 +- > target/arm/t32.decode | 8 +- > 2 files changed, 41 insertions(+), 24 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 87 +++- > target/arm/a32-uncond.decode | 3 ++ > target/arm/t32.decode| 3 ++ > 3 files changed, 42 insertions(+), 51

Re: [Qemu-devel] [PATCH 06/13] qcrypto-luks: implement more rigorous header checking

2019-08-25 Thread Maxim Levitsky
On Sun, 2019-08-25 at 18:40 +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 12:04 +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 11:22:12PM +0300, Maxim Levitsky wrote: > > > Check that keyslots don't overlap with the data, > > > and check that keyslots don't overlap with each

Re: [Qemu-devel] [PATCH v2 34/68] target/arm: Convert Clear-Exclusive, Barriers

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 122 +++ > target/arm/a32-uncond.decode | 10 +++ > target/arm/t32.decode| 10 +++ > 3 files changed, 73 insertions(+), 69

Re: [Qemu-devel] [PATCH 06/13] qcrypto-luks: implement more rigorous header checking

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:04 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:12PM +0300, Maxim Levitsky wrote: > > Check that keyslots don't overlap with the data, > > and check that keyslots don't overlap with each other. > > (this is done using naive O(n^2) nested loops, > > but

Re: [Qemu-devel] [PATCH 05/13] qcrypto-luks: clear the masterkey and password before freeing them always

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 13:56 +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 11:49 +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 20, 2019 at 08:12:51PM +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > While there are other places where these are still stored in

Re: [Qemu-devel] [PATCH v2 33/68] target/arm: Convert RFE and SRS

2019-08-25 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 150 ++- > target/arm/a32-uncond.decode | 8 ++ > target/arm/t32.decode| 12 +++ > 3 files changed, 81 insertions(+), 89

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 01:49, John Snow wrote: > > > On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >> With the '-valgrind' option, let all the QEMU processes be run under >> the Valgrind tool. The Valgrind own parameters may be set with its >> environment variable VALGRIND_OPTS, e.g. >>

Re: [Qemu-devel] [Qemu-block] [PATCH v5 4/6] iotests: Valgrind fails with nonexistent directory

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 03:55, John Snow wrote: > > > On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >> The Valgrind uses the exported variable TMPDIR and fails if the >> directory does not exist. Let us exclude such a test case from >> being run under the Valgrind and notify the user of it. >> >>

Re: [Qemu-devel] [PATCH] configure: more resilient Python version capture

2019-08-25 Thread Peter Maydell
On Sat, 24 Aug 2019 at 08:32, wrote: > > -echo "PYTHON_VERSION=$python_version" >> $config_host_mak > > +echo "PYTHON2=$python2" >> $config_host_mak > ... > > -ifneq ($(findstring v2,"v$(PYTHON_VERSION)"),v2) > > +ifneq ($(PYTHON2),y) > > Succinctly, if Python 3. > > We can further ween the world

Re: [Qemu-devel] [PATCH] i386/vmmouse: Properly reset state

2019-08-25 Thread Jan Kiszka
On 21.07.19 10:58, Jan Kiszka wrote: From: Jan Kiszka nb_queue was not zeroed so that we no longer delivered events if a previous guest left the device in an overflow state. The state of absolute does not matter as the next vmmouse_update_handler call will align it again. Signed-off-by: Jan

Re: [Qemu-devel] [PATCH 04/13] qcrypto-luks: refactoring: simplify the math used for keyslot locations

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:47 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:10PM +0300, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > crypto/block-luks.c | 64 +++-- > > 1 file changed, 38 insertions(+), 26

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:34 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 22, 2019 at 01:43:05AM +0300, Maxim Levitsky wrote: > > On Tue, 2019-08-20 at 20:01 +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > With upcoming key management, the header will > > > > need

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:38 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:09PM +0300, Maxim Levitsky wrote: > > With upcoming key management, the header will > > need to be stored after the image is created. > > > > Extracting load header isn't strictly needed, but > > do this

Re: [Qemu-devel] [QEMU] [PATCH v5 5/8] bootdevice: Gather LCHS from all relevant devices

2019-08-25 Thread Sam Eiderman via Qemu-devel
> Only scsi-hd has the lchs properties, though, so what’s the purpose of > defining the unrealize function for all other classes? > > Max - shmuel.eider...@oracle.com + sam...@google.com The only purpose is to already have them mapped to the correct existing function, in case it will be used

Re: [Qemu-devel] [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd

2019-08-25 Thread Sam Eiderman via Qemu-devel
> @@ -213,11 +221,18 @@ static void scsi_qdev_realize(DeviceState *qdev, Error > **errp) > static void scsi_qdev_unrealize(DeviceState *qdev, Error **errp) > { > SCSIDevice *dev = SCSI_DEVICE(qdev); > +Error *local_err = NULL; > > if (dev->vmsentry) { >

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/6] iotests: Add casenotrun report to bash tests

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 23:33, Cleber Rosa wrote: > On Thu, Aug 15, 2019 at 08:44:11PM -0400, John Snow wrote: >> >> >> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>> The new function _casenotrun() is to be invoked if a test case cannot >>> be run for some reason. The user will be notified by a message

Re: [Qemu-devel] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-25 Thread Maxim Levitsky
On Thu, 2019-08-22 at 16:32 +0200, Max Reitz wrote: > On 22.08.19 01:59, Maxim Levitsky wrote: > > On Tue, 2019-08-20 at 19:36 +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > This is also a preparation for key read/write/erase functions > > > > > > > > * use master

Re: [Qemu-devel] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 23:05, Cleber Rosa wrote: > On Fri, Jul 19, 2019 at 07:30:10PM +0300, Andrey Shinkevich wrote: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind, which is a useful tool for >> finding memory usage issues. Let's allow

Re: [Qemu-devel] [Qemu-block] [PATCH v5 6/6] iotests: extend sleeping time under Valgrind

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 04:01, John Snow wrote: > > > On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >> To synchronize the time when QEMU is running longer under the Valgrind, >> increase the sleeping time in the test 247. >> >> Signed-off-by: Andrey Shinkevich >> Reviewed-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PULL 07/15] audio: audiodev= parameters no longer optional when -audiodev present

2019-08-25 Thread Maxim Levitsky
On Wed, 2019-08-21 at 10:41 +0200, Gerd Hoffmann wrote: > From: Kővágó, Zoltán > > This means you should probably stop using -soundhw (as it doesn't allow > you to specify any options) and add the device manually with -device. > The exception is pcspk, it's currently not possible to manually add

Re: [Qemu-devel] [Qemu-block] [PATCH] block: posix: Always allocate the first block

2019-08-25 Thread Maxim Levitsky
On Sat, 2019-08-17 at 00:21 +0300, Nir Soffer wrote: > When creating an image with preallocation "off" or "falloc", the first > block of the image is typically not allocated. When using Gluster > storage backed by XFS filesystem, reading this block using direct I/O > succeeds regardless of request

[Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-08-25 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/nvme.c | 83 ++ block/trace-events | 2 ++ 2 files changed, 85 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index f8bd11e19a..dd041f39c9 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -112,6

[Qemu-devel] [PATCH 0/2] block/nvme: add support for write zeros and discard

2019-08-25 Thread Maxim Levitsky
This is the second part of the patches I prepared for this driver back when I worked on mdev-nvme. Best regards, Maxim Levitsky Maxim Levitsky (2): block/nvme: add support for write zeros block/nvme: add support for discard block/nvme.c | 155

[Qemu-devel] [PATCH 1/2] block/nvme: add support for write zeros

2019-08-25 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/nvme.c | 72 +++- block/trace-events | 1 + include/block/nvme.h | 19 +++- 3 files changed, 90 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 5be3a39b63..f8bd11e19a