Re: [PATCH] target/riscv: PMP violation due to wrong size parameter

2019-10-07 Thread Richard Henderson
On 10/7/19 11:41 AM, Dayeol Lee wrote: > if pmp_hart_has_privs() gets addr=0x2000 and size=0, > pmp_hart_has_privs() will ALWAYS return false because the code assumes size > > 0. > It checks if (addr) and (addr + size - 1) are within the PMP range for each > PMP > entry. You certainly could do

RE: [PATCH v4] intel_iommu: TM field should not be in reserved bits

2019-10-07 Thread Zhang, Qi1
Thank you! I formatted the patch with cover-letter and submitted them again. > -Original Message- > From: Michael S. Tsirkin > Sent: Sunday, October 6, 2019 5:50 AM > To: Zhang, Qi1 > Cc: qemu-devel@nongnu.org; marcel.apfelb...@gmail.com; > pbonz...@redhat.com; r...@twiddle.net;

[PATCH 1/2] intel_iommu: split the resevred fields arrays into two ones

2019-10-07 Thread qi1 . zhang
From: "Zhang, Qi" Signed-off-by: Zhang, Qi --- hw/i386/intel_iommu.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index f1de8fdb75..a118efaeaf 100644 --- a/hw/i386/intel_iommu.c +++

[PATCH 2/2] intel_iommu: TM field should not be in reserved bits

2019-10-07 Thread qi1 . zhang
From: "Zhang, Qi" When dt is supported, TM field should not be Reserved(0). Refer to VT-d Spec 9.8 Signed-off-by: Zhang, Qi Signed-off-by: Qi, Yadong --- hw/i386/intel_iommu.c | 12 hw/i386/intel_iommu_internal.h | 17 + 2 files changed, 21

[PATCH 0/2] TM field check failed

2019-10-07 Thread qi1 . zhang
From: "Zhang, Qi" *** BLURB HERE *** Zhang, Qi (2): intel_iommu: split the resevred fields arrays into two ones intel_iommu: TM field should not be in reserved bits hw/i386/intel_iommu.c | 35 -- hw/i386/intel_iommu_internal.h | 17

Re: [PATCH v2] target/riscv: Expose "priv" register for GDB

2019-10-07 Thread Jonathan Behrens
On Mon, Oct 7, 2019 at 2:36 PM Alistair Francis wrote: > On Fri, Oct 4, 2019 at 8:18 AM Jonathan Behrens wrote: > > @@ -296,6 +302,14 @@ int riscv_cpu_gdb_write_register(CPUState *cs, uint8_t > > *mem_buf, int n) > > } else if (n == 32) { > > env->pc = ldtul_p(mem_buf); > >

Re: [PATCH v2] target/riscv: Expose "priv" register for GDB

2019-10-07 Thread Jonathan Behrens
On Mon, Oct 7, 2019 at 5:17 PM Jim Wilson wrote: > On 10/4/19 8:16 AM, Jonathan Behrens wrote: > > diff --git a/gdb-xml/riscv-32bit-cpu.xml b/gdb-xml/riscv-32bit-cpu.xml > > index 0d07aaec85..d6d76aafd8 100644 > > --- a/gdb-xml/riscv-32bit-cpu.xml > > +++ b/gdb-xml/riscv-32bit-cpu.xml > > @@

[PATCH v3 3/3] target/riscv: Make the priv register writable by GDB

2019-10-07 Thread Jonathan Behrens
Currently only PRV_U, PRV_S and PRV_M are supported, so this patch ensures that the privilege mode is set to one of them. Once support for the H-extension is added, this code will also need to properly update the virtualization status when switching between VU/VS-modes and M-mode. Signed-off-by:

[PATCH v3 2/3] target/riscv: Expose priv register for GDB for reads

2019-10-07 Thread Jonathan Behrens
This patch enables a debugger to read the current privilege level via a virtual "priv" register. When compiled with CONFIG_USER_ONLY the register is still visible but always reports the value zero. Signed-off-by: Jonathan Behrens --- configure | 4 ++--

Re: [PATCH v3 0/3] target/riscv: Expose "priv" register for GDB

2019-10-07 Thread Jonathan Behrens
The first paragraph seems to have gone missing. Repeated below: > This series adds a new "priv" virtual register that reports the current > privilege mode. This is helpful for debugging purposes because that > information > is not actually available in any of the real CSRs. On Mon, Oct 7, 2019

Re: [PATCH 0/2] xics, xive: Add some missing comments

2019-10-07 Thread David Gibson
On Mon, Oct 07, 2019 at 03:42:58PM +0200, Greg Kurz wrote: > As noted by Markus, the reason why a device type isn't user creatable > should be documented. > > These patches can be squashed into the ones that made the devices > non user-creatable, or applied as follow-ups, at the discretion of >

[PATCH v3 1/3] target/riscv: Tell gdbstub the correct number of CSRs

2019-10-07 Thread Jonathan Behrens
If the number of registers reported to the gdbstub code does not match the number in the associated XML file, then the register numbers used by the stub may get out of sync with a remote GDB instance. Signed-off-by: Jonathan Behrens --- target/riscv/gdbstub.c | 4 ++-- 1 file changed, 2

[PATCH v3 0/3] target/riscv: Expose "priv" register for GDB

2019-10-07 Thread Jonathan Behrens
The third patch in this series makes the priv virtual register writitable. I'm not entirely sure this is a good idea, so I split it out into its own patch. In particular, this change will conflict with the hypervisor extension work which assumes that the privilege mode does not change in

Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset

2019-10-07 Thread Eduardo Habkost
On Mon, Oct 07, 2019 at 12:01:54PM +0200, Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 10/5/19 11:46 PM, Michael S. Tsirkin wrote: > > On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote: > > > Hi. > > > > > > Following the thread discussion between Peter/Markus/Damien

Re: [PATCH v2] target/riscv: Expose "priv" register for GDB

2019-10-07 Thread Jim Wilson
On 10/4/19 8:16 AM, Jonathan Behrens wrote: diff --git a/gdb-xml/riscv-32bit-cpu.xml b/gdb-xml/riscv-32bit-cpu.xml index 0d07aaec85..d6d76aafd8 100644 --- a/gdb-xml/riscv-32bit-cpu.xml +++ b/gdb-xml/riscv-32bit-cpu.xml @@ -44,4 +44,5 @@ + Adding this to the cpu register set

Re: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block

2019-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191007170646.14961-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block Message-id:

Re: [PATCH v7 1/2] docs: improve qcow2 spec about extending image header

2019-10-07 Thread Eric Blake
On 10/7/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: Make it more obvious how to add new fields to the version 3 header and how to interpret them. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/qcow2.txt | 26 +++--- 1 file changed, 23 insertions(+), 3

Re: [PATCH 1/2] tests: Make iotest 223 easier to edit

2019-10-07 Thread Eric Blake
On 10/7/19 7:05 AM, Max Reitz wrote: On 24.09.19 16:35, Eric Blake wrote: Log the QMP input to qemu, not just the QMP output. Why not just add this functionality to _send_qemu_cmd directly? (Like silent already does for replies, although it’s inverted.) Interesting idea. I'll give it a

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-10-07 Thread Eric Blake
On 10/7/19 5:48 AM, Vladimir Sementsov-Ogievskiy wrote: We want to wait until listening socket is prepared.. In shell: qemu-nbd --pid-file=/path/to/file ... while [ ! -e /path/to/file ]; do   sleep ... # fractional second, or exponential, or whatever... done # Now the listening socket is

[PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-07 Thread Eric Blake
One benefit of --pid-file is that it is easier to probe the file system to see if a pid file has been created than it is to probe if a socket is available for connection. Document that this is an intentional feature. Signed-off-by: Eric Blake --- qemu-nbd.texi | 3 ++- 1 file changed, 2

Re: [PATCH 1/1] IDE: deprecate ide-drive

2019-10-07 Thread John Snow
On 10/7/19 5:49 AM, Markus Armbruster wrote: > John Snow writes: > >> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >> I'd like to refactor these some day, and getting rid of the super-object >> will make that easier. > > Device "scsi-disk" is similar. However,

Re: [PATCH] iotests: Do not run the iotests during "make check" anymore

2019-10-07 Thread John Snow
On 10/7/19 9:03 AM, Max Reitz wrote: > On 03.10.19 01:51, John Snow wrote: >> >> >> On 10/2/19 11:50 AM, Max Reitz wrote: >>> On 02.10.19 17:10, Thomas Huth wrote: On 02/10/2019 17.03, Daniel P. Berrangé wrote: > On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote: >>

Re: [PATCH RFC] docker: automatic dependencies for dockerfiles

2019-10-07 Thread John Snow
On 10/7/19 12:12 PM, Alex Bennée wrote: > > John Snow writes: > >> This is a demo for using makefile dependencies for image requisites. >> Honestly, I don't like it -- Makefile sorcery is a bit beyond my >> comprehension. >> >> This is as near as I could stab, and it has the unfortunate

Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build

2019-10-07 Thread Philippe Mathieu-Daudé
On 10/7/19 9:05 PM, Alex Bennée wrote: Peter Maydell writes: On Mon, 7 Oct 2019 at 17:22, Alex Bennée wrote: Adding debug makes things run a bit slower so lets not hammer all the targets. Signed-off-by: Alex Bennée --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build

2019-10-07 Thread Alex Bennée
Peter Maydell writes: > On Mon, 7 Oct 2019 at 17:22, Alex Bennée wrote: >> >> Adding debug makes things run a bit slower so lets not hammer all the >> targets. >> >> Signed-off-by: Alex Bennée >> --- >> .travis.yml | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff

Re: [PATCH v9 00/13] TCG code quality tracking and perf integration

2019-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191007152839.30804-1-alex.ben...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] target/riscv: PMP violation due to wrong size parameter

2019-10-07 Thread Dayeol Lee
On Mon, Oct 7, 2019 at 11:25 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 10/7/19 10:19 AM, Dayeol Lee wrote: > > Thank you very much for the clarification! > > > > I found tlb_set_page with size != TARGET_PAGE_SIZE makes the translation > way > > too slow; the Linux doesn't

Re: [PATCH v2] target/riscv: Expose "priv" register for GDB

2019-10-07 Thread Alistair Francis
On Fri, Oct 4, 2019 at 8:18 AM Jonathan Behrens wrote: > > This patch enables a debugger to read and write the current privilege level > via > a special "priv" register. When compiled with CONFIG_USER_ONLY the register is > still visible but is hardwired to zero. > > Signed-off-by: Jonathan

Re: [PATCH v2 7/7] tests/fw_cfg: Run the tests on big-endian targets

2019-10-07 Thread Laszlo Ersek
On 10/07/19 17:19, Philippe Mathieu-Daudé wrote: > We have been restricting our fw_cfg tests to the PC machine, > which is a little-endian architecture. > The fw_cfg device is also used on the SPARC and PowerPC > architectures, which can run in big-endian configuration. > > Since we want to be

Re: [PATCH] target/riscv: PMP violation due to wrong size parameter

2019-10-07 Thread Richard Henderson
On 10/7/19 10:19 AM, Dayeol Lee wrote: > Thank you very much for the clarification! > > I found tlb_set_page with size != TARGET_PAGE_SIZE makes the translation way > too slow; the Linux doesn't seem to boot. To clarify, PMP specifies a range. That range has only two end points. Therefore, a

Is network backend vde worth keeping? (was: Is network backend netmap worth keeping?)

2019-10-07 Thread Markus Armbruster
Markus Armbruster writes: > Please excuse the attention-grabbing subject. Again. [...] > So, to make use of QEMU's netmap backend (CONFIG_NETMAP), you have to > build and install netmap software from sources. Which pretty much CONFIG_VDE seems to be similarly cumbersome to build-test. >

Re: [Qemu-devel] Bug#919921: qemu-user Linux ELF loader fails to handle pure BSS segments

2019-10-07 Thread Ben Hutchings
On Tue, 2019-01-22 at 21:31 -0800, Richard Henderson wrote: > On 1/22/19 1:39 AM, Philippe Mathieu-Daudé wrote: > > Hi Ben, > > > > On 1/22/19 6:43 AM, Michael Tokarev wrote: > > > Forwarding to qemu-devel@ > > > http://bugs.debian.org/919921 > > > > > > Thanks! > > > > > > 20.01.2019 20:55,

Re: [PATCH v9 00/13] TCG code quality tracking and perf integration

2019-10-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191007152839.30804-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v9 00/13] TCG code quality tracking and perf integration Message-id:

Re: [PATCH v1 22/28] target/riscv: Allow specifying MMU stage

2019-10-07 Thread Alistair Francis
On Thu, Oct 3, 2019 at 8:53 AM Palmer Dabbelt wrote: > > On Fri, 23 Aug 2019 16:38:47 PDT (-0700), Alistair Francis wrote: > > Signed-off-by: Alistair Francis > > --- > > target/riscv/cpu_helper.c | 39 ++- > > 1 file changed, 30 insertions(+), 9 deletions(-)

Re: [PULL v2 0/8] Ide patches

2019-10-07 Thread Philippe Mathieu-Daudé
On 10/7/19 7:35 PM, John Snow wrote: On 10/7/19 8:33 AM, Peter Maydell wrote: On Thu, 3 Oct 2019 at 20:33, John Snow wrote: The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Markus Armbruster
Thomas Huth writes: > On 07/10/2019 14.35, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: Peter Maydell writes: > Basically new submodules are a pain so we seek to minimize > the use of them. I suggested

Re: [PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-07 Thread Mario Smarduch
On 10/07/2019 03:27 AM, Philippe Mathieu-Daudé wrote: > Hi Mario, > > On 10/5/19 1:53 AM, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >> - if VM crashes on AR mce inform the

Re: [PATCH 0/5] hw/arm/exynos4210: Add acceptance tests to the SMDKC210 board

2019-10-07 Thread Krzysztof Kozlowski
On Mon, Oct 07, 2019 at 11:10:24AM +0200, Krzysztof Kozlowski wrote: > On Sat, Oct 05, 2019 at 05:47:43PM +0200, Philippe Mathieu-Daudé wrote: > > Hi all, > > > > Yesterday Peter Maydell asked on IRC if I had any working Exynos4 > > image. I looked at some old backuped notes and could boot

Re: [PULL v2 0/8] Ide patches

2019-10-07 Thread John Snow
On 10/7/19 8:33 AM, Peter Maydell wrote: > On Thu, 3 Oct 2019 at 20:33, John Snow wrote: >> >> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc: >> >> Merge remote-tracking branch >> 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 >>

Re: [Qemu-devel] Bug#919921: qemu-user Linux ELF loader fails to handle pure BSS segments

2019-10-07 Thread Philippe Mathieu-Daudé
Hi Ben, On 10/7/19 7:29 PM, Ben Hutchings wrote: On Tue, 2019-01-22 at 21:31 -0800, Richard Henderson wrote: On 1/22/19 1:39 AM, Philippe Mathieu-Daudé wrote: Hi Ben, On 1/22/19 6:43 AM, Michael Tokarev wrote: Forwarding to qemu-devel@ http://bugs.debian.org/919921 Thanks! 20.01.2019

Re: [PATCH 12/19] hw/arm/bcm2835_peripherals: Add Clock/Power/Reset Manager blocks

2019-10-07 Thread Philippe Mathieu-Daudé
On Tue, Oct 1, 2019 at 11:51 AM Philippe Mathieu-Daudé wrote: > On 9/26/19 7:34 PM, Philippe Mathieu-Daudé wrote: > > Add basic support for BCM283x CPRMAN. Provide support for reading and > > writing CPRMAN registers and initialize registers with sensible default > > values. During runtime retain

Re: [PATCH] target/riscv: PMP violation due to wrong size parameter

2019-10-07 Thread Dayeol Lee
Thank you very much for the clarification! I found tlb_set_page with size != TARGET_PAGE_SIZE makes the translation way too slow; the Linux doesn't seem to boot. If that's the only way to reduce PMP granularity to less than TARGET_PAGE_SIZE, Can we just set the PMP default granularity to

[PATCH 3/3] hw: Move BCM2835 AUX device from hw/char/ to hw/misc/

2019-10-07 Thread Philippe Mathieu-Daudé
The BCM2835 AUX device is a MUX between one UART block and two SPI blocks. Move it to the hw/misc/ folder. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/Makefile.objs | 1 - hw/char/trace-events| 4 hw/misc/Makefile.objs | 1 +

[PATCH 1/3] hw/char: Add the BCM2835 miniuart

2019-10-07 Thread Philippe Mathieu-Daudé
The miniuart code is already present in the multi-device hw/char/bcm2835_aux.c. Simply extracting it does not generate patch easy to review. Instead, add it again, rename the function names accordingly, use the "hw/registerfields.h" API. This is roughtly a copy of commit 97398d900caacc.

[RFC PATCH 5/5] target/arm/cpu: Add the kvm-adjvtime CPU property

2019-10-07 Thread Andrew Jones
kvm-adjvtime is a KVM specific CPU property and a first of its kind. To accommodate it we also add kvm_arm_add_vcpu_properties() and a KVM specific CPU properties description to the CPU features document. Signed-off-by: Andrew Jones --- docs/arm-cpu-features.rst | 27 ++-

Re: [PATCH v4 06/31] python: add commit-per-subsystem.py

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2019 19:21, Daniel P. Berrangé wrote: > On Mon, Oct 07, 2019 at 06:16:51PM +0200, Cornelia Huck wrote: >> On Mon, 7 Oct 2019 16:10:02 + >> Vladimir Sementsov-Ogievskiy wrote: >> >>> 07.10.2019 18:55, Cornelia Huck wrote: On Tue, 1 Oct 2019 18:52:54 +0300 Vladimir

[RFC PATCH 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime

2019-10-07 Thread Andrew Jones
When kvm-adjvtime is enabled the guest's cntvct[_el0] won't count the time when the VM is stopped. That time is skipped by updating cntvoff[_el2] on each transition to vm_running using the current QEMU_CLOCK_VIRTUAL time. QEMU_CLOCK_VIRTUAL only ticks when the VM is running. This patch only

[RFC PATCH 4/5] tests/arm-cpu-features: Check feature default values

2019-10-07 Thread Andrew Jones
If we know what the default value should be then we can test for that as well as the feature existence. Signed-off-by: Andrew Jones --- tests/arm-cpu-features.c | 44 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/tests/arm-cpu-features.c

Re: [PATCH 5/6] block/block-copy: add memory limit

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2019 18:27, Max Reitz wrote: > On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: >> Currently total allocation for parallel requests to block-copy instance >> is unlimited. Let's limit it to 128 MiB. >> >> For now block-copy is used only in backup, so actually we limit total >>

[PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block

2019-10-07 Thread Philippe Mathieu-Daudé
The BCM2838 has many more peripherals than his little brother, the BCM2837. With the raspi4, the Linux kernel takes more steps to configure the various MUXed devices. At some point it started to bug me, so I plan to add a dummy simple BCM2835_SPI block. It is cleaner to add it as a separate device

[RFC PATCH 2/5] timer: arm: Introduce functions to get the host cntfrq

2019-10-07 Thread Andrew Jones
When acceleration like KVM is in use it's necessary to use the host's counter frequency when converting ticks to or from time units. Signed-off-by: Andrew Jones --- include/qemu/timer.h | 16 1 file changed, 16 insertions(+) diff --git a/include/qemu/timer.h

[RFC PATCH 1/5] target/arm/kvm64: kvm64 cpus have timer registers

2019-10-07 Thread Andrew Jones
Add the missing GENERIC_TIMER feature to kvm64 cpus. We don't currently use these registers when KVM is enabled, but it's probably best we add the feature flag for consistency and potential future use. There's also precedent, as we add the PMU feature flag to KVM enabled guests, even though we

[PATCH 2/3] hw/char/bcm2835_aux: Use the BCM2835 miniuart block

2019-10-07 Thread Philippe Mathieu-Daudé
In the previous commit we extracted the miniuart block. Time to use it. It is mapped at offset 0x40 in the AUX block, and uses the first IRQ. Due to incomplete Clock Tree support, Linux kernel fails at initializing the UART clock and disable this block. For now Disable this feature with the

[RFC PATCH 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-10-07 Thread Andrew Jones
This series is inspired by a series[1] posted by Bijan Mottahedeh about a year ago. The problem described in the cover letter of [1] is easily reproducible and some users would like to have the option to avoid it. However the solution, which is to adjust the virtual counter offset each time the

Re: [PATCH v1 0/5] s390x/mmu: Implement more facilities

2019-10-07 Thread Cornelia Huck
On Fri, 4 Oct 2019 15:23:32 +0200 David Hildenbrand wrote: > On 26.09.19 12:16, David Hildenbrand wrote: > > This is the follow up of: > > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > Without the general MMU rework. It's based on: > > [PATCH v2 0/7] s390x/mmu: DAT

Re: [PATCH v1 5/5] s390x/cpumodel: Add new TCG features to QEMU cpu model

2019-10-07 Thread Cornelia Huck
On Thu, 26 Sep 2019 12:16:27 +0200 David Hildenbrand wrote: > We now implement a bunch of new facilities we can properly indicate. > > ESOP-1/ESOP-2 handling is discussed in the PoP Chafter 3-15 > ("Suppression on Protection"). The "Basic suppression-on-protection (SOP) > facility" is a core

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-07 Thread Max Reitz
On 07.10.19 18:28, Thomas Huth wrote: > On 07/10/2019 15.11, Thomas Huth wrote: >> On 07/10/2019 14.52, Max Reitz wrote: >>> On 07.10.19 14:16, Thomas Huth wrote: On 04/10/2019 14.44, Max Reitz wrote: > On 04.10.19 12:19, Kevin Wolf wrote: >> Am 02.10.2019 um 19:47 hat Max Reitz

Re: [PATCH 4/6] util: introduce co-shared-amount

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2019 18:22, Max Reitz wrote: > On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: >> Introduce an API for some shared splitable resource, like memory. > > *splittable, I suppose > >> It's going to be used by backup. Backup uses both read/write io and >> copy_range. copy_range may

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-07 Thread Thomas Huth
On 07/10/2019 15.11, Thomas Huth wrote: > On 07/10/2019 14.52, Max Reitz wrote: >> On 07.10.19 14:16, Thomas Huth wrote: >>> On 04/10/2019 14.44, Max Reitz wrote: On 04.10.19 12:19, Kevin Wolf wrote: > Am 02.10.2019 um 19:47 hat Max Reitz geschrieben: >> On 02.10.19 18:44, Kevin Wolf

Re: [PATCH 3/6] block/block-copy: refactor copying

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2019 17:17, Max Reitz wrote: > On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: >> Merge copying code into one function block_copy_do_copy, which only >> calls bdrv_ io functions and don't do any synchronization (like dirty >> bitmap set/reset). >> >> Refactor block_copy() function so

Re: [PATCH 6/6] block/block-copy: increase buffered copy request

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2019 18:48, Max Reitz wrote: > On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: >> No reason to limit buffered copy to one cluster. Let's allow up to 1 >> MiB. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> include/block/block-copy.h | 2 +- >> block/block-copy.c

Re: [PULL 00/19] virtio, vhost, acpi: features, fixes, tests

2019-10-07 Thread Peter Maydell
On Sat, 5 Oct 2019 at 22:58, Michael S. Tsirkin wrote: > > A couple of tweaks to the bios table test weren't > reviewed yet but as they are really helpful to > the arm tests I'm pushing, and affecting only the > test so fairly benign (dropped assert + a comment), > I cut a corner and pushed them

Re: [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210

2019-10-07 Thread Peter Maydell
On Sat, 5 Oct 2019 at 16:47, Philippe Mathieu-Daudé wrote: > > This test boots a Linux kernel on a smdkc210 board and verify > the serial output is working. > > The cpio image used comes from the linux-build-test project: > https://github.com/groeck/linux-build-test Thanks for putting this test

Re: [PATCH v4 06/31] python: add commit-per-subsystem.py

2019-10-07 Thread Daniel P . Berrangé
On Mon, Oct 07, 2019 at 06:16:51PM +0200, Cornelia Huck wrote: > On Mon, 7 Oct 2019 16:10:02 + > Vladimir Sementsov-Ogievskiy wrote: > > > 07.10.2019 18:55, Cornelia Huck wrote: > > > On Tue, 1 Oct 2019 18:52:54 +0300 > > > Vladimir Sementsov-Ogievskiy wrote: > > > >> +def

Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build

2019-10-07 Thread Peter Maydell
On Mon, 7 Oct 2019 at 17:22, Alex Bennée wrote: > > Adding debug makes things run a bit slower so lets not hammer all the > targets. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index

Re: [PATCH v4 06/31] python: add commit-per-subsystem.py

2019-10-07 Thread Cornelia Huck
On Mon, 7 Oct 2019 16:10:02 + Vladimir Sementsov-Ogievskiy wrote: > 07.10.2019 18:55, Cornelia Huck wrote: > > On Tue, 1 Oct 2019 18:52:54 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > >> +def git_add(pattern): > >> +subprocess.run(['git', 'add', pattern]) > >> + > >> + > >> +def

Re: [PATCH v1 24/28] target/riscv: Implement second stage MMU

2019-10-07 Thread Palmer Dabbelt
On Fri, 23 Aug 2019 16:38:52 PDT (-0700), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 96 +++ 1 file changed, 86 insertions(+), 10 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c

[PATCH] .travis.yml: reduce scope of the --enable-debug build

2019-10-07 Thread Alex Bennée
Adding debug makes things run a bit slower so lets not hammer all the targets. Signed-off-by: Alex Bennée --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index d0b9e099b9..fc0888aff5 100644 --- a/.travis.yml +++ b/.travis.yml @@

Re: [PATCH 00/97] Patch Round-up for stable 4.0.1, freeze on 2019-10-10

2019-10-07 Thread Alexandr Iarygin
Michael Roth writes: > Hi everyone, > > > The following new patches are queued for QEMU stable v4.0.1: > > https://github.com/mdroth/qemu/commits/stable-4.0-staging > > The release is planned for

Re: [PATCH RFC] docker: automatic dependencies for dockerfiles

2019-10-07 Thread Alex Bennée
John Snow writes: > This is a demo for using makefile dependencies for image requisites. > Honestly, I don't like it -- Makefile sorcery is a bit beyond my > comprehension. > > This is as near as I could stab, and it has the unfortunate requisite > that it will generate all of the *.d files at

Re: [PATCH v4 06/31] python: add commit-per-subsystem.py

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
07.10.2019 18:55, Cornelia Huck wrote: > On Tue, 1 Oct 2019 18:52:54 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> Add script to automatically commit tree-wide changes per-subsystem. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> CC: kw...@redhat.com >> CC: mre...@redhat.com

[PATCH v7 0/2] qcow2: add zstd cluster compression

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is my proposal, about how to correctly update qcow2 specification to introduce new field, keeping in mind currently existing images and downstream Qemu instances. Let's consider discussing from this. I called it v7, as it's a continuation of "[PATCH v6 0/3] qcow2: add zstd cluster

[PATCH v2] .travis.yml: Test the release tarball

2019-10-07 Thread Philippe Mathieu-Daudé
Add a job to generate the release tarball and build/install few QEMU targets from it. Ideally we should build the 'efi' target from the 'roms' directory, but it is too time consuming. This job is only triggered when a tag starting with 'v' is pushed, which is the case with release candidate

[PATCH v7 2/2] docs: qcow2: introduce compression type feature

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
The patch add new additional field to qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (ZSTD) is to be added in further commit. Suggested-by: Denis

[PATCH v7 1/2] docs: improve qcow2 spec about extending image header

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
Make it more obvious how to add new fields to the version 3 header and how to interpret them. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/qcow2.txt | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/docs/interop/qcow2.txt

Re: [PATCH v4 07/31] s390: Fix error_append_hint/error_prepend usage

2019-10-07 Thread Cornelia Huck
On Tue, 1 Oct 2019 18:52:55 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err > (the program will exit prior to the

Re: [PATCH] target/mips: add gdb xml files

2019-10-07 Thread Alex Bennée
Mikhail Abakumov writes: > From: Mikhail Abakumov Hmm the email got truncated here. > > This patch add xml files with gdb registers for mips. > > Signed-off-by: Mikhail Abakumov > --- > configure | 3 ++ > gdb-xml/mips-core.xml | 84

Re: [PATCH v4 06/31] python: add commit-per-subsystem.py

2019-10-07 Thread Cornelia Huck
On Tue, 1 Oct 2019 18:52:54 +0300 Vladimir Sementsov-Ogievskiy wrote: > Add script to automatically commit tree-wide changes per-subsystem. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > CC: kw...@redhat.com > CC: mre...@redhat.com > CC: js...@redhat.com > CC: f...@euphon.net >

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: >> Peter Maydell writes: >> > Basically new submodules are a pain so we seek to minimize >> > the use of them. >> >> I suggested making it a submodule upthread[*]. Let me try to distill >> the conversation into a

Re: [PATCH 6/6] block/block-copy: increase buffered copy request

2019-10-07 Thread Max Reitz
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: > No reason to limit buffered copy to one cluster. Let's allow up to 1 > MiB. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block-copy.h | 2 +- > block/block-copy.c | 44

Re: [PULL v3 0/4] Block layer patches

2019-10-07 Thread Peter Maydell
On Fri, 4 Oct 2019 at 11:00, Kevin Wolf wrote: > > The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 > 16:21:42 +0100) > > are available in the Git repository

Re: [PATCH] netmap: support git-submodule build otption

2019-10-07 Thread Thomas Huth
On 07/10/2019 14.35, Markus Armbruster wrote: > Peter Maydell writes: > >> On Mon, 7 Oct 2019 at 11:50, Markus Armbruster wrote: >>> Peter Maydell writes: Basically new submodules are a pain so we seek to minimize the use of them. >>> >>> I suggested making it a submodule

Re: [PATCH 6/6] block/block-copy: increase buffered copy request

2019-10-07 Thread Max Reitz
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: > No reason to limit buffered copy to one cluster. Let's allow up to 1 > MiB. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block-copy.h | 2 +- > block/block-copy.c | 44

[PATCH v9 08/13] tb-stats: reset the tracked TBs on a tb_flush

2019-10-07 Thread Alex Bennée
We keep track of translations but can only do so up until the translation cache is flushed. At that point we really have no idea if we can re-create a translation because all the active tracking information has been reset. Signed-off-by: Alex Bennée --- accel/tcg/tb-stats.c | 19

Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-07 Thread Alex Bennée
Richard Henderson writes: > On 10/6/19 9:05 AM, Paolo Bonzini wrote: >> On 01/10/19 19:40, Alex Bennée wrote: >>> >>> Paolo Bonzini writes: >>> On 01/10/19 18:04, Alex Bennée wrote: > qemu_cpu_kick is used for a number of reasons including to indicate > there is work to be done.

[PATCH v9 13/13] configure: remove the final bits of --profiler support

2019-10-07 Thread Alex Bennée
Signed-off-by: Alex Bennée --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index eedeb9016e..dfd0f67170 100755 --- a/configure +++ b/configure @@ -419,7 +419,6 @@ oss_lib="" bsd="no" linux="no" solaris="no" -profiler="no" cocoa="no" softmmu="yes"

[PATCH v9 06/13] debug: add -d tb_stats to control TBStatistics collection:

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" -d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=]] "dump_limit" is used to limit the number of dumped TBStats in linux-user mode. [all+jit+exec+time] control the profilling level used by the TBStats. Can be used as follow: -d tb_stats -d

[PATCH v9 11/13] accel/tcg: adding integration with linux perf

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" This commit adds support to Linux Perf in order to be able to analyze qemu jitted code and also to able to see the TBs PC in it. When using "-perf" qemu creates a jitdump file in the current working directory. You then integrate the file using perf inject.

[PATCH v9 09/13] Adding info [tb-list|tb] commands to HMP (WIP)

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host instructions... and examine their guest, host and IR code. The goal of this command is to allow the dynamic exploration of TCG behavior and code

[PATCH v9 05/13] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" Replace all others CONFIG_PROFILER statistics and migrate it to TBStatistics system. However, TCGProfiler still exists and can be use to store global statistics and times. All TB related statistics goes to TBStatistics. Signed-off-by: Vanderson M. do Rosario

[PATCH v9 01/13] accel/tcg: introduce TBStatistics structure

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" To store statistics for each TB, we created a TBStatistics structure which is linked with the TBs. TBStatistics can stay alive after tb_flush and be relinked to a regenerated TB. So the statistics can be accumulated even through flushes. The goal is to have all

[PATCH v9 07/13] monitor: adding tb_stats hmp command

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" Adding tb_stats [start|pause|stop|filter] command to hmp. This allows controlling the collection of statistics. It is also possible to set the level of collection: all, jit, or exec. tb_stats filter allow to only collect statistics for the TB in the last_search

[PATCH v9 12/13] tb-stats: adding TBStatistics info into perf dump

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" Adding TBStatistics information to linux perf TB's symbol names. Signed-off-by: Vanderson M. do Rosario Message-Id: <20190830121903.17585-3-vanderson...@gmail.com> [AJB: fix authorship, auto-strings] Signed-off-by: Alex Bennée --- AJB: - use g_string and

[PATCH v9 04/13] accel: replacing part of CONFIG_PROFILER with TBStats

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" We add some of the statistics collected in the TCGProfiler into the TBStats, having the statistics not only for the whole emulation but for each TB. Then, we removed these stats from TCGProfiler and reconstruct the information for the "info jit" using the sum of

[PATCH v9 03/13] accel: collecting JIT statistics

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" If a TB has a TBS (TBStatistics) with the TB_JIT_STATS enabled then we collect statistics of its translation processes and code translation. To help with collection we include the TCGProfile structure unconditionally. It will have further alterations in future

[PATCH v9 02/13] accel: collecting TB execution count

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" If a TB has a TBS (TBStatistics) with the TB_EXEC_STATS enabled, then we instrument the start code of this TB to atomically count the number of times it is executed. We count both the number of "normal" executions and atomic executions of a TB. The execution

[PATCH v9 10/13] tb-stats: dump hot TBs at the end of the execution

2019-10-07 Thread Alex Bennée
From: "Vanderson M. do Rosario" Dump the hottest TBs if -d tb_stats,dump_limit=N is used. Example of output for the 3 hottest TBs: TB id:1 | phys:0x34d54 virt:0x00034d54 flags:0xf0 | exec:4828932/0 guest inst cov:16.38% | trans:1 ints: g:3 op:82 op_opt:34 spills:3

Re: [PATCH 4/6] util: introduce co-shared-amount

2019-10-07 Thread Max Reitz
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: > Introduce an API for some shared splitable resource, like memory. *splittable, I suppose > It's going to be used by backup. Backup uses both read/write io and > copy_range. copy_range may consume memory implictly, so new API is *the new

[PATCH v9 00/13] TCG code quality tracking and perf integration

2019-10-07 Thread Alex Bennée
Hi, These are the bits of Vanderson's GSoC project which I think are ready for merge(^) and would like get up-streamed before the code freeze kicks in. It effectively removes the CONFIG_PROFILER support in favour of a more dynamic and configurable TB Statistics subsystem. While not in use it has

Re: [PATCH 5/6] block/block-copy: add memory limit

2019-10-07 Thread Max Reitz
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote: > Currently total allocation for parallel requests to block-copy instance > is unlimited. Let's limit it to 128 MiB. > > For now block-copy is used only in backup, so actually we limit total > allocation for backup job. > > Signed-off-by:

  1   2   3   >