Re: [PATCH v2 09/10] target/ppc: Correct RMLS table

2020-01-08 Thread Alexey Kardashevskiy
On 08/01/2020 12:06, David Gibson wrote: > On Tue, Jan 07, 2020 at 03:21:42PM +0100, Cédric Le Goater wrote: >> On 1/7/20 5:48 AM, David Gibson wrote: >>> The table of RMA limits based on the LPCR[RMLS] field is slightly wrong. >>> We're missing the RMLS == 0 => 256 GiB RMA option, which is

Re: [PATCH v2 05/10] spapr, ppc: Remove VPM0/RMLS hacks for POWER9

2020-01-08 Thread Alexey Kardashevskiy
On 07/01/2020 15:48, David Gibson wrote: > For the "pseries" machine, we use "virtual hypervisor" mode where we only > model the CPU in non-hypervisor privileged mode. This means that we need > guest physical addresses within the modelled within the cpu to be treated > as absolute physical

Re: [PATCH 5/7] target/ppc: Add privileged message send facilities

2020-01-08 Thread Cédric Le Goater
void helper_book3s_msgclr(CPUPPCState *env, target_ulong rb) { -int irq = book3s_dbell2irq(rb); +int irq = book3s_dbell2irq(rb, 1); >>> >>> true/false are preferred to 0/1 for bool types. >> >> yes or a define ? > > Sorry, I don't understand the question. The second

Re: [PATCH v2 0/3] hw/hppa/machine: Restrict the total memory size to 3GB

2020-01-08 Thread Helge Deller
On 09.01.20 03:20, Richard Henderson wrote: > On 1/9/20 11:05 AM, Philippe Mathieu-Daudé wrote: >> Philippe Mathieu-Daudé (3): >> hw/hppa/machine: Correctly check the firmware is in PDC range >> hw/hppa/machine: Restrict the total memory size to 3GB >> hw/hppa/machine: Map the PDC memory

[Bug 1851972] Re: pc-q35-4.1 and AMD Navi 5700/XT incompatible

2020-01-08 Thread Marshall Porter
Hi Philippe, thanks for replying. The 'kernel_irqchip' parameter is a bit confusing to me. It looks like the documentation was updated from it defaulted to 'off' as a -machine parameter, to now it will default to 'on' as an -accel parameter. This bug described how the value for

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-08 Thread Alexey Kardashevskiy
On 09/01/2020 15:07, David Gibson wrote: > On Wed, Jan 08, 2020 at 03:07:41PM +1100, Alexey Kardashevskiy wrote: >> >> >> On 07/01/2020 16:26, David Gibson wrote: >> +static uint32_t client_setprop(SpaprMachineState *sm, + uint32_t nodeph,

Re: [PATCH] testing: don't nest build for fp-test

2020-01-08 Thread Emilio G. Cota
On Tue, Jan 07, 2020 at 18:00:03 +, Alex Bennée wrote: > Re-calling the main make is counter-productive and really messes up > with parallel builds. Just ensure we have built the pre-requisites > before we build the fp-test bits. If the user builds manually just > complain if the parent build

RE: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-08 Thread Pavel Dovgalyuk
Ping. Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@gmail.com] > Sent: Monday, December 23, 2019 12:46 PM > To: qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; crosthwaite.pe...@gmail.com; > boost.li...@gmail.com;

Re: [BUG qemu 4.0] segfault when unplugging virtio-blk-pci device

2020-01-08 Thread Eryu Guan
On Tue, Jan 07, 2020 at 03:01:01PM +0100, Julia Suvorova wrote: > On Tue, Jan 7, 2020 at 2:06 PM Eryu Guan wrote: > > > > On Thu, Jan 02, 2020 at 10:08:50AM +0800, Eryu Guan wrote: > > > On Tue, Dec 31, 2019 at 11:51:35AM +0100, Igor Mammedov wrote: > > > > On Tue, 31 Dec 2019 18:34:34 +0800 > >

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-08 Thread David Gibson
On Wed, Jan 08, 2020 at 03:07:41PM +1100, Alexey Kardashevskiy wrote: > > > On 07/01/2020 16:26, David Gibson wrote: > > >> +static uint32_t client_setprop(SpaprMachineState *sm, > >> + uint32_t nodeph, uint32_t pname, > >> +

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-08 Thread David Gibson
On Wed, Jan 08, 2020 at 04:53:06PM +1100, Alexey Kardashevskiy wrote: > > > On 08/01/2020 15:20, Alexey Kardashevskiy wrote: > > > > > > On 07/01/2020 16:54, David Gibson wrote: > >> On Tue, Jan 07, 2020 at 03:44:35PM +1100, Alexey Kardashevskiy wrote: > >>> > >>> > >>> On 06/01/2020 15:19,

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-08 Thread David Gibson
On Wed, Jan 08, 2020 at 03:20:22PM +1100, Alexey Kardashevskiy wrote: > > > On 07/01/2020 16:54, David Gibson wrote: > > On Tue, Jan 07, 2020 at 03:44:35PM +1100, Alexey Kardashevskiy wrote: > >> > >> > >> On 06/01/2020 15:19, David Gibson wrote: > + > +static uint32_t

[PATCH] target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle

2020-01-08 Thread Masahiro Yamada
According to the specification "Semihosting for AArch32 and Aarch64", the SYS_OPEN operation should return: - A nonzero handle if the call is successful - -1 if the call is not successful So, it should never return 0. Prior to commit 35e9a0a8ce4b ("target/arm/arm-semi: Make semihosting code

Re: [PATCH v22 0/9] Add ARMv8 RAS virtualization support in QEMU

2020-01-08 Thread gengdongjiu
1. How to enable this feature: (a) In KVM mode: ./qemu-system-aarch64 --enable-kvm -cpu host --bios QEMU_EFI.fd_new -machine virt,gic-version=3,ras,kernel-irqchip=on -smp 4 -nographic -kernel Image -append "rdinit=/init console=ttyAMA0 mem=512M root=/dev/ram0" -initrd guestfs_new.cpio.gz

Re: [PATCH 0/2] exclude hyperv synic sections from vhost

2020-01-08 Thread Jason Wang
On 2020/1/8 下午9:53, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Hyperv's synic (that we emulate) is a feature that allows the guest to place some magic (4k) pages of RAM anywhere it likes in GPA. This confuses vhost's RAM section merging when these pages land over the

[PATCH 8/9] cputlb: Initialize tlbs as flushed

2020-01-08 Thread Richard Henderson
There's little point in leaving these data structures half initialized, and relying on a flush to be done during reset. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index

[PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locked

2020-01-08 Thread Richard Henderson
No functional change, but the smaller expressions make the code easier to read. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index c7dc1dc85a..eff427f137

[PATCH 9/9] cputlb: Hoist timestamp outside of loops over tlbs

2020-01-08 Thread Richard Henderson
Do not call get_clock_realtime() in tlb_mmu_resize_locked, but hoist outside of any loop over a set of tlbs. This is only two (indirect) callers, tlb_flush_by_mmuidx_async_work and tlb_flush_page_locked, so not onerous. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 14

[PATCH 7/9] cputlb: Partially merge tlb_dyn_init into tlb_init

2020-01-08 Thread Richard Henderson
Merge into the only caller, but at the same time split out tlb_mmu_init to initialize a single tlb entry. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/accel/tcg/cputlb.c

[PATCH 4/9] cputlb: Hoist tlb portions in tlb_mmu_resize_locked

2020-01-08 Thread Richard Henderson
No functional change, but the smaller expressions make the code easier to read. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index

[PATCH 6/9] cputlb: Split out tlb_mmu_flush_locked

2020-01-08 Thread Richard Henderson
We will want to be able to flush a tlb without resizing. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index eff427f137..e60e501334 100644 ---

[PATCH 3/9] cputlb: Pass CPUTLBDescFast to tlb_n_entries and sizeof_tlb

2020-01-08 Thread Richard Henderson
We do not need the entire CPUArchState to compute these values. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index e4a8ed9534..49c605b6d8 100644 ---

[PATCH 0/9] cputlb: Various cleanups

2020-01-08 Thread Richard Henderson
I had a conversation with Alistair Francis at KVM forum about being able to represent ASIDs "properly". This lead to the idea that target-specific code might be able to cache TLBs outside of the "main" NB_MMU_MODES -- possibly thousands of them. This goes nowhere near that far. But it does

[PATCH 2/9] cputlb: Make tlb_n_entries private to cputlb.c

2020-01-08 Thread Richard Henderson
There are no users of this function outside cputlb.c, and its interface will change in the next patch. Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 5 - accel/tcg/cputlb.c | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 1/9] cputlb: Merge tlb_table_flush_by_mmuidx into tlb_flush_one_mmuidx_locked

2020-01-08 Thread Richard Henderson
There is only one caller for tlb_table_flush_by_mmuidx. Place the result at the earlier line number, due to an expected user in the near future. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git

RE: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-08 Thread Zengtao (B)
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Thursday, January 09, 2020 12:39 AM > To: Zengtao (B) > Cc: Michael S. Tsirkin; qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > Shannon Zhao; Peter Maydell; qemu-...@nongnu.org > Subject: Re: [PATCH]

Re: [PATCH v1 35/36] target/riscv: Add the MSTATUS_MPV_ISSET helper macro

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:12:12 PST (-0800), Alistair Francis wrote: Add a helper macro MSTATUS_MPV_ISSET() which will determine if the MSTATUS_MPV bit is set for both 32-bit and 64-bit RISC-V. Signed-off-by: Alistair Francis --- target/riscv/cpu_bits.h | 11 +++

Re: [PATCH v1 20/36] target/riscv: Add support for virtual interrupt setting

2020-01-08 Thread Richard Henderson
On 1/9/20 11:49 AM, Palmer Dabbelt wrote: >> +    irqs = (pending & ~env->mideleg & -mie) | (pending &  env->mideleg & >> -sie); > > Isn't "-unsigned" implementation defined?  I can't get GCC to throw a warning > and it was already there, so maybe I'm just wrong? (1) You're confusing

Re: [PATCH v1 34/36] target/riscv: Add support for the 32-bit MSTATUSH CSR

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:12:09 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu.c| 6 ++ target/riscv/cpu.h| 7 +++ target/riscv/cpu_bits.h | 3 +++ target/riscv/cpu_helper.c | 7 +++ target/riscv/csr.c| 25

Re: [PATCH 0/2] ppc/pnv: PNOR cleanups

2020-01-08 Thread David Gibson
On Wed, Jan 08, 2020 at 10:03:46AM +0100, Cédric Le Goater wrote: > Hello, > > Here are small cleanups of the PnvPNOR model. Applied to ppc-for-5.0, thanks. > > Thanks, > > C. > > Cédric Le Goater (2): > ppc/pnv: use QEMU unit definition MiB > ppc/pnv: improve error logging when a PNOR

Re: [PATCH v1 32/36] target/riscv: Raise the new execptions when 2nd stage translation fails

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:12:04 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index

Re: [PATCH v1 33/36] target/riscv: Set htval and mtval2 on execptions

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:12:06 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 43c6629014..aa033b8590 100644 ---

Re: [PATCH v2 0/3] hw/hppa/machine: Restrict the total memory size to 3GB

2020-01-08 Thread Richard Henderson
On 1/9/20 11:05 AM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (3): > hw/hppa/machine: Correctly check the firmware is in PDC range > hw/hppa/machine: Restrict the total memory size to 3GB > hw/hppa/machine: Map the PDC memory region with higher priority Reviewed-by: Richard

[PATCH 3/4] vl: Remove useless test in configure_accelerators

2020-01-08 Thread Richard Henderson
The result of g_strsplit is never NULL. Signed-off-by: Richard Henderson --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index c9329fe699..887dbfbb5d 100644 --- a/vl.c +++ b/vl.c @@ -2776,7 +2776,7 @@ static void configure_accelerators(const char

[PATCH 1/4] vl: Remove unused variable in configure_accelerators

2020-01-08 Thread Richard Henderson
The accel_initialised variable no longer has any setters. Fixes: 6f6e1698a68c Signed-off-by: Richard Henderson --- vl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 86474a55c9..be79b03c1a 100644 --- a/vl.c +++ b/vl.c @@ -2749,7 +2749,6 @@ static void

[PATCH 0/4] vl: Fixes for cleanups to -accel

2020-01-08 Thread Richard Henderson
Running qemu-system-foo with no options should not generate a warning for "invalid accelerator bar". Also, fix some mistakes made while moving the code from accel/accel.c. r~ Richard Henderson (4): vl: Remove unused variable in configure_accelerators vl: Free accel_list in

[PATCH 4/4] vl: Only choose enabled accelerators in configure_accelerators

2020-01-08 Thread Richard Henderson
By choosing "tcg:kvm" when kvm is not enabled, we generate an incorrect warning: "invalid accelerator kvm". Presumably the inverse is also true with --disable-tcg. Fixes: 28a0961757fc Signed-off-by: Richard Henderson --- vl.c | 18 -- 1 file changed, 12 insertions(+), 6

[PATCH 2/4] vl: Free accel_list in configure_accelerators

2020-01-08 Thread Richard Henderson
We allocate the list with g_strsplit, so free it too. This freeing was lost during one of the rearrangements. Fixes: 6f6e1698a68c Signed-off-by: Richard Henderson --- vl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index be79b03c1a..c9329fe699 100644 ---

Re: [PATCH v1 31/36] target/riscv: Implement second stage MMU

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:12:01 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu.h| 1 + target/riscv/cpu_helper.c | 193 ++ 2 files changed, 175 insertions(+), 19 deletions(-) diff --git a/target/riscv/cpu.h

Re: [PATCH v18 5/7] ppc: spapr: Handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls

2020-01-08 Thread David Gibson
On Thu, Jan 09, 2020 at 12:19:12AM +0530, Ganesh wrote: > > > On 1/8/20 6:34 AM, David Gibson wrote: > > On Tue, Jan 07, 2020 at 11:57:08AM +0530, Ganesh wrote: > > > On 1/3/20 7:49 AM, David Gibson wrote: > > > > On Thu, Jan 02, 2020 at 01:21:09PM +0530, Ganesh Goudar wrote: > > > > > From:

Re: [PATCH 5/7] target/ppc: Add privileged message send facilities

2020-01-08 Thread David Gibson
On Wed, Jan 08, 2020 at 04:32:19PM +0100, Cédric Le Goater wrote: > On 12/17/19 5:00 AM, David Gibson wrote: > > On Thu, Nov 28, 2019 at 02:46:58PM +0100, Cédric Le Goater wrote: > >> From: Suraj Jitindar Singh > >> > >> Privileged message send facilities exist on POWER8 processors and > >> later

Re: [PATCH 2/2] pnv/psi: Consolidate some duplicated code in pnv_psi_realize()

2020-01-08 Thread David Gibson
On Wed, Jan 08, 2020 at 11:58:45AM +0100, Greg Kurz wrote: > On Wed, 8 Jan 2020 11:54:53 +1100 > David Gibson wrote: > > > On Tue, Jan 07, 2020 at 07:32:03PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Greg, > > > > > > On 1/7/20 5:32 PM, Greg Kurz wrote: > > > > The proper way to do that

Re: [PATCH v1 30/36] target/riscv: Allow specifying MMU stage

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:11:59 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c

Re: [PATCH v1 29/36] target/riscv: Respect MPRV and SPRV for floating point ops

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:11:56 PST (-0800), Alistair Francis wrote: mark_fs_dirty() is the only place in translate.c that uses the virt_enabled bool. Let's respect the contents of MSTATUS.MPRV and HSTATUS.SPRV when setting the bool as this is used for performing floating point operations when V=0.

Re: [PATCH v1 19/36] target/riscv: Extend the SIP CSR to support virtulisation

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:11:30 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/csr.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 54edfb280e..d028dfb60b 100644 ---

Re: [PATCH v1 20/36] target/riscv: Add support for virtual interrupt setting

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:11:32 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index

Re: [PATCH v1 26/36] target/riscv: Remove the hret instruction

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:11:48 PST (-0800), Alistair Francis wrote: The hret instruction does not exist in the new spec versions, so remove it from QEMU. Signed-off-by: Alistair Francis --- target/riscv/insn32.decode | 1 - target/riscv/insn_trans/trans_privileged.inc.c | 5

Re: [PATCH 5/5] python/qemu: qmp: Remove unnused attributes

2020-01-08 Thread John Snow
On 12/27/19 8:41 AM, Wainer dos Santos Moschetta wrote: > The `error` and `timeout` attributes in QEMUMonitorProtocol are > not used, so this delete them. > > Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: John Snow > --- > python/qemu/qmp.py | 4 > 1 file changed, 4

Re: [PATCH 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager

2020-01-08 Thread John Snow
On 12/27/19 8:41 AM, Wainer dos Santos Moschetta wrote: > This implement the __enter__ and __exit__ functions on > QEMUMonitorProtocol class so that it can be used on 'with' > statement and the resources will be free up on block end: > > with QEMUMonitorProtocol(socket_path) as qmp: >

Re: [PATCH 3/5] python/qemu: qmp: Make accept()'s timeout configurable

2020-01-08 Thread John Snow
On 12/27/19 8:40 AM, Wainer dos Santos Moschetta wrote: > Currently the timeout of QEMUMonitorProtocol.accept() is > hard-coded to 15 seconds. This added the parameter `timeout` > so the value can be configured by the user. > > Signed-off-by: Wainer dos Santos Moschetta > --- >

Re: [PATCH 2/5] python/qemu: Delint the qmp module

2020-01-08 Thread John Snow
On 12/27/19 8:40 AM, Wainer dos Santos Moschetta wrote: > This clean up the pylint-3 report on qmp: > > * Module qemu.qmp > python/qemu/qmp.py:1:0: C0111: Missing module docstring (missing-docstring) > python/qemu/qmp.py:17:0: C0111: Missing class docstring (missing-docstring) >

Re: [PATCH 1/5] python/qemu: qmp: Replace socket.error with OSError

2020-01-08 Thread John Snow
On 12/27/19 8:40 AM, Wainer dos Santos Moschetta wrote: > The socket.error is deprecated from Python 3.3, instead it is > made a link to OSError. This change replaces the occurences > of socket.error with OSError. > > Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: John Snow (Are

[PATCH v2 2/3] hw/hppa/machine: Restrict the total memory size to 3GB

2020-01-08 Thread Philippe Mathieu-Daudé
The hardware expects DIMM slots of 1 or 2 GB, allowing up to 4 GB of memory. We want to accept the same amount of memory the hardware can deal with. DIMMs of 768MB are not available. However we have to deal with a firmware limitation: currently SeaBIOS only supports 32-bit, and expects the RAM

[PATCH v2 0/3] hw/hppa/machine: Restrict the total memory size to 3GB

2020-01-08 Thread Philippe Mathieu-Daudé
Following the discussion of Igor's patch "hppa: allow max ram size upto 4Gb" [1] I tried to simplify the current code so Igor's series doesn't change the CLI with this machine. v2: Simplify by limiting to 3GB (Helge review) [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg667903.html

Re: [PATCH v2 2/9] 9pfs: validate count sent by client with T_readdir

2020-01-08 Thread Greg Kurz
On Mon, 06 Jan 2020 16:10:28 +0100 Christian Schoenebeck wrote: > On Montag, 6. Januar 2020 13:30:24 CET Greg Kurz wrote: > > On Wed, 18 Dec 2019 14:17:59 +0100 > > > > Christian Schoenebeck wrote: > > > A good 9p client sends T_readdir with "count" parameter that's > > > sufficiently smaller

[PATCH v2 3/3] hw/hppa/machine: Map the PDC memory region with higher priority

2020-01-08 Thread Philippe Mathieu-Daudé
The region in range [0xf000 - 0xf100] is the PDC area (Processor Dependent Code), where the firmware is loaded. This region has higher priority than the main memory. When the machine has more than 3840MB of RAM, there is an overlap. Since the PDC is closer to the CPU in the bus hierarchy,

[PATCH v2 1/3] hw/hppa/machine: Correctly check the firmware is in PDC range

2020-01-08 Thread Philippe Mathieu-Daudé
The firmware has to reside in the PDC range. If the Elf file expects to load it below FIRMWARE_START, it is incorrect, regardless the RAM size. Acked-by: Helge Deller Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 4/9] tests/virtio-9p: added readdir test

2020-01-08 Thread Greg Kurz
On Wed, 18 Dec 2019 14:30:43 +0100 Christian Schoenebeck wrote: > This first readdir test simply checks the amount of directory > entries returned by 9pfs server, according to the created amount > of virtual files on 9pfs synth driver side. > > Signed-off-by: Christian Schoenebeck > --- More

Re: [PATCH 2/3] hw/hppa/machine: Do not limit the RAM to 3840MB

2020-01-08 Thread Philippe Mathieu-Daudé
On Wed, Jan 8, 2020 at 10:39 PM Helge Deller wrote: > On 08.01.20 19:14, Philippe Mathieu-Daudé wrote: > > The hardware expects DIMM slots of 1 or 2 GB, allowing up to > > 4 GB of memory. Accept the same amount of memory the hardware > > can deal with. > > > > The CPU doesn't have access to the

[PATCH] hw/smbios/smbios: Use MachineState::ram_size instead of global one

2020-01-08 Thread Philippe Mathieu-Daudé
The smbios_get_tables() function has access the a machine state. Use the field instead of accessing the global ram_size variable. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/smbios/smbios.c

Re: [PATCH v3 01/17] hw/arm: add Allwinner H3 System-on-Chip

2020-01-08 Thread Philippe Mathieu-Daudé
On 1/8/20 9:00 PM, Niek Linnenbank wrote: The Allwinner H3 is a System on Chip containing four ARM Cortex A7 processor cores. Features and specifications include DDR2/DDR3 memory, SD/MMC storage cards, 10/100/1000Mbit ethernet, USB 2.0, HDMI and "Ethernet" various I/O modules. This commit

Re: [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver

2020-01-08 Thread Linus Walleij
On Mon, Jan 6, 2020 at 9:23 AM Geert Uytterhoeven wrote: > > The rest I think we cleared out else I will see it when I review again. > > The remaining discussion point is "GPIO Repeater in Device Tree", i.e. > the GPIO inverter usecase, which might be solved better by adding a > GPIO_INVERTED

Re: [PATCH v11 Kernel 6/6] vfio: Selective dirty page tracking if IOMMU backed device pins pages

2020-01-08 Thread Alex Williamson
On Thu, 9 Jan 2020 02:22:26 +0530 Kirti Wankhede wrote: > On 1/8/2020 5:39 AM, Alex Williamson wrote: > > On Wed, 8 Jan 2020 02:15:01 +0530 > > Kirti Wankhede wrote: > > > >> On 12/18/2019 5:42 AM, Alex Williamson wrote: > >>> On Tue, 17 Dec 2019 22:40:51 +0530 > >>> Kirti Wankhede wrote:

[RFC PATCH] travis.yml: split into build stages

2020-01-08 Thread Alex Bennée
The idea of this is split the build across stages so any failure in one stage will save time running later stages. So far I have have arbitrarily chosen: canary: up-front quick to build and run platforms: common build configurations rest: everything else The ideal should be canary and

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-08 Thread Alex Williamson
On Thu, 9 Jan 2020 02:11:11 +0530 Kirti Wankhede wrote: > On 1/9/2020 12:01 AM, Alex Williamson wrote: > > On Wed, 8 Jan 2020 15:59:55 +0100 > > Cornelia Huck wrote: > > > >> On Tue, 7 Jan 2020 11:56:02 -0700 > >> Alex Williamson wrote: > >> > >>> On Tue, 7 Jan 2020 23:23:17 +0530 > >>>

Re: [PATCH v3 02/17] hw/arm: add Xunlong Orange Pi PC machine

2020-01-08 Thread Philippe Mathieu-Daudé
On 1/8/20 9:00 PM, Niek Linnenbank wrote: The Xunlong Orange Pi PC is an Allwinner H3 System on Chip based embedded computer with mainline support in both U-Boot and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, 512MB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and various other

Re: [PATCH qemu v4] spapr: Kill SLOF

2020-01-08 Thread Alexey Kardashevskiy
On 08/01/2020 17:18, Alexey Kardashevskiy wrote: > The Petitboot bootloader is way more advanced than SLOF is ever going to > be as Petitboot comes with the full-featured Linux kernel with all > the drivers, and initramdisk with quite user friendly interface. > The problem with ditching SLOF is

Re: [PATCH v11 Kernel 3/6] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-01-08 Thread Alex Williamson
On Thu, 9 Jan 2020 01:31:16 +0530 Kirti Wankhede wrote: > On 1/8/2020 3:32 AM, Alex Williamson wrote: > > On Wed, 8 Jan 2020 01:37:03 +0530 > > Kirti Wankhede wrote: > > > > > > + > +unlocked = vfio_iova_put_vfio_pfn(dma, vpfn, dirty_tracking); > >

Re: [PATCH 2/3] hw/hppa/machine: Do not limit the RAM to 3840MB

2020-01-08 Thread Helge Deller
On 08.01.20 19:14, Philippe Mathieu-Daudé wrote: > The hardware expects DIMM slots of 1 or 2 GB, allowing up to > 4 GB of memory. Accept the same amount of memory the hardware > can deal with. > > The CPU doesn't have access to the RAM mapped in the > [0xf000 - 0xf100] range because this

Re: [PATCH 1/3] hw/hppa/machine: Correctly check the firmware is in PDC range

2020-01-08 Thread Helge Deller
On 08.01.20 19:14, Philippe Mathieu-Daudé wrote: > The firmware has to reside in the PDC range. If the Elf file > expects to load it below FIRMWARE_START, it is incorrect, > regardless the RAM size. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Helge Deller > --- > Note we define

Re: [PATCH v3 6/6] tests/tcg: add user version of dumb-as-bricks semiconsole test

2020-01-08 Thread Richard Henderson
On 1/9/20 6:55 AM, Alex Bennée wrote: > > Alex Bennée writes: > >> There are linux-user users of semihosting so we'd better check things >> work for them as well. >> >> Signed-off-by: Alex Bennée >> >> --- >> v3 >> - include aarch64 version >> v4 >> - use common semicall.h, test thumb &

Re: [PATCH v11 Kernel 6/6] vfio: Selective dirty page tracking if IOMMU backed device pins pages

2020-01-08 Thread Kirti Wankhede
On 1/8/2020 5:39 AM, Alex Williamson wrote: On Wed, 8 Jan 2020 02:15:01 +0530 Kirti Wankhede wrote: On 12/18/2019 5:42 AM, Alex Williamson wrote: On Tue, 17 Dec 2019 22:40:51 +0530 Kirti Wankhede wrote: This will fail when there are devices within the IOMMU group that are not

Re: [PATCH v3 5/6] tests/tcg: extract __semi_call into a header and expand

2020-01-08 Thread Richard Henderson
On 1/9/20 2:02 AM, Alex Bennée wrote: > There are two types of ARM semicall - lets test them both. Putting the > logic in a header will make re-using the functions easier later. > > Signed-off-by: Alex Bennée > --- > tests/tcg/arm/semicall.h | 35 +++ >

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-08 Thread Kirti Wankhede
On 1/9/2020 12:01 AM, Alex Williamson wrote: On Wed, 8 Jan 2020 15:59:55 +0100 Cornelia Huck wrote: On Tue, 7 Jan 2020 11:56:02 -0700 Alex Williamson wrote: On Tue, 7 Jan 2020 23:23:17 +0530 Kirti Wankhede wrote: There are 3 invalid states: * 101b => Invalid state * 110b =>

Re: [PATCH v1 18/36] target/riscv: Extend the MIE CSR to support virtulisation

2020-01-08 Thread Palmer Dabbelt
On Mon, 09 Dec 2019 10:11:27 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/csr.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index fc38c45a7e..54edfb280e 100644 ---

Re: [PATCH] include/sysemu/sysemu.h: Remove usused variable no_quit

2020-01-08 Thread Laurent Vivier
in subject: s/usused/unused/ Le 08/01/2020 à 20:24, Thomas Huth a écrit : > The no_quit variable has been removed in commit 78782712a62d56 ("vl: drop > no_quit variable"), so let's remove the extern declaration in the header > now, too. Fixes: 78782712a62d ("vl: drop no_quit variable") >

Re: [PATCH v8] qga: add command guest-get-devices for reporting VirtIO devices

2020-01-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/642f73c78a99258dc134e3879a0287db8ef176c0.1578497245.git.tgole...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it

[PATCH v3 09/17] hw/arm/allwinner-h3: add EMAC ethernet device

2020-01-08 Thread Niek Linnenbank
The Allwinner Sun8i System on Chip family includes an Ethernet MAC (EMAC) which provides 10M/100M/1000M Ethernet connectivity. This commit adds support for the Allwinner EMAC from the Sun8i family (H2+, H3, A33, etc), including emulation for the following functionality: * DMA transfers * MII

[PATCH v3 17/17] docs: add Orange Pi PC document

2020-01-08 Thread Niek Linnenbank
The Xunlong Orange Pi PC machine is a functional ARM machine based on the Allwinner H3 System-on-Chip. It supports mainline Linux, U-Boot, NetBSD and is covered by acceptance tests. This commit adds a documentation text file with a description of the machine and instructions for the user.

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread puchuu
Sure, I will try to reproduce permissions issue and create a new issue later. I will try to provide small patches too. I've created a question on kernel bugzilla. https://bugzilla.kernel.org/show_bug.cgi?id=206135 They should know that applications wants much more than "tbl" provides. ** Bug

Re: [PATCH] include/sysemu/sysemu.h: Remove usused variable no_quit

2020-01-08 Thread Alex Bennée
Thomas Huth writes: > The no_quit variable has been removed in commit 78782712a62d56 ("vl: drop > no_quit variable"), so let's remove the extern declaration in the header > now, too. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée > --- > include/sysemu/sysemu.h | 1 - > 1 file

[PATCH v3 15/17] tests/boot_linux_console: Add a SD card test for the OrangePi PC board

2020-01-08 Thread Niek Linnenbank
From: Philippe Mathieu-Daudé The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://www.armbian.com/orange-pi-pc/ The SD image is from the kernelci.org project: https://kernelci.org/faq/#the-code If ARM is a target being built, "make check-acceptance"

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread Aleksandar Markovic
I have certain concerns over a refactoring that changes the behavior. Refactorings in general should not do it, and if they still do, one should at least have a clear explanation. That is why I want more details on "emerge" problem. -- You received this bug notification because you are a member

[PATCH v3 14/17] tests/boot_linux_console: Add initrd test for the Orange Pi PC board

2020-01-08 Thread Niek Linnenbank
From: Philippe Mathieu-Daudé This test boots a Linux kernel on a OrangePi PC board and verify the serial output is working. The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://www.armbian.com/orange-pi-pc/ The cpio image used comes from the

[PATCH v3 08/17] hw/arm/allwinner: add SD/MMC host controller

2020-01-08 Thread Niek Linnenbank
The Allwinner System on Chip families sun4i and above contain an integrated storage controller for Secure Digital (SD) and Multi Media Card (MMC) interfaces. This commit adds support for the Allwinner SD/MMC storage controller with the following emulated features: * DMA transfers * Direct FIFO

[PATCH v3 07/17] hw/arm/allwinner: add Security Identifier device

2020-01-08 Thread Niek Linnenbank
The Security Identifier device found in various Allwinner System on Chip designs gives applications a per-board unique identifier. This commit adds support for the Allwinner Security Identifier using a 128-bit UUID value as input. Signed-off-by: Niek Linnenbank --- include/hw/arm/allwinner-h3.h

[PATCH v3 11/17] hw/arm/allwinner-h3: add SDRAM controller device

2020-01-08 Thread Niek Linnenbank
In the Allwinner H3 SoC the SDRAM controller is responsible for interfacing with the external Synchronous Dynamic Random Access Memory (SDRAM). Types of memory that the SDRAM controller supports are DDR2/DDR3 and capacities of up to 2GiB. This commit adds emulation support of the Allwinner H3

Re: [PATCH v11 Kernel 3/6] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-01-08 Thread Kirti Wankhede
On 1/8/2020 3:32 AM, Alex Williamson wrote: On Wed, 8 Jan 2020 01:37:03 +0530 Kirti Wankhede wrote: + + unlocked = vfio_iova_put_vfio_pfn(dma, vpfn, dirty_tracking); if (do_accounting) vfio_lock_acct(dma, -unlocked, true); @@ -571,8 +606,12 @@ static int

[PATCH v3 04/17] hw/arm/allwinner-h3: add USB host controller

2020-01-08 Thread Niek Linnenbank
The Allwinner H3 System on Chip contains multiple USB 2.0 bus connections which provide software access using the Enhanced Host Controller Interface (EHCI) and Open Host Controller Interface (OHCI) interfaces. This commit adds support for both interfaces in the Allwinner H3 System on Chip.

[PATCH v3 12/17] hw/arm/allwinner: add RTC device support

2020-01-08 Thread Niek Linnenbank
Allwinner System-on-Chips usually contain a Real Time Clock (RTC) for non-volatile system date and time keeping. This commit adds a generic Allwinner RTC device that supports the RTC devices found in Allwinner SoC family sun4i (A10), sun7i (A20) and sun6i and newer (A31, H2+, H3, etc). The

[PATCH v3 05/17] hw/arm/allwinner-h3: add System Control module

2020-01-08 Thread Niek Linnenbank
The Allwinner H3 System on Chip has an System Control module that provides system wide generic controls and device information. This commit adds support for the Allwinner H3 System Control module. Signed-off-by: Niek Linnenbank --- include/hw/arm/allwinner-h3.h | 3 +

[PATCH v3 16/17] tests/boot_linux_console: Add a SLOW test booting Ubuntu on OrangePi PC

2020-01-08 Thread Niek Linnenbank
From: Philippe Mathieu-Daudé This test boots Ubuntu Bionic on a OrangePi PC board. As it requires 1GB of storage, and is slow, this test is disabled on automatic CI testing. It is useful for workstation testing. Currently Avocado timeouts too quickly, so we can't run userland commands. The

[PATCH v3 01/17] hw/arm: add Allwinner H3 System-on-Chip

2020-01-08 Thread Niek Linnenbank
The Allwinner H3 is a System on Chip containing four ARM Cortex A7 processor cores. Features and specifications include DDR2/DDR3 memory, SD/MMC storage cards, 10/100/1000Mbit ethernet, USB 2.0, HDMI and various I/O modules. This commit adds support for the Allwinner H3 System on Chip.

[PATCH v3 06/17] hw/arm/allwinner: add CPU Configuration module

2020-01-08 Thread Niek Linnenbank
Various Allwinner System on Chip designs contain multiple processors that can be configured and reset using the generic CPU Configuration module interface. This commit adds support for the Allwinner CPU configuration interface which emulates the following features: * CPU reset * CPU status *

[PATCH v3 03/17] hw/arm/allwinner-h3: add Clock Control Unit

2020-01-08 Thread Niek Linnenbank
The Clock Control Unit is responsible for clock signal generation, configuration and distribution in the Allwinner H3 System on Chip. This commit adds support for the Clock Control Unit which emulates a simple read/write register interface. Signed-off-by: Niek Linnenbank ---

[PATCH v3 13/17] tests/boot_linux_console: Add a quick test for the OrangePi PC board

2020-01-08 Thread Niek Linnenbank
From: Philippe Mathieu-Daudé This test boots a Linux kernel on a OrangePi PC board and verify the serial output is working. The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://www.armbian.com/orange-pi-pc/ If ARM is a target being built, "make

[PATCH v3 00/17] Add Allwinner H3 SoC and Orange Pi PC Machine

2020-01-08 Thread Niek Linnenbank
Dear QEMU developers, Hereby I would like to contribute the following set of patches to QEMU which add support for the Allwinner H3 System on Chip and the Orange Pi PC machine. The following features and devices are supported: * SMP (Quad Core Cortex A7) * Generic Interrupt Controller

[PATCH v3 10/17] hw/arm/allwinner-h3: add Boot ROM support

2020-01-08 Thread Niek Linnenbank
A real Allwinner H3 SoC contains a Boot ROM which is the first code that runs right after the SoC is powered on. The Boot ROM is responsible for loading user code (e.g. a bootloader) from any of the supported external devices and writing the downloaded code to internal SRAM. After loading the SoC

[PATCH v3 02/17] hw/arm: add Xunlong Orange Pi PC machine

2020-01-08 Thread Niek Linnenbank
The Xunlong Orange Pi PC is an Allwinner H3 System on Chip based embedded computer with mainline support in both U-Boot and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, 512MB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and various other I/O. This commit add support for the Xunlong

Re: [PATCH v3 6/6] tests/tcg: add user version of dumb-as-bricks semiconsole test

2020-01-08 Thread Alex Bennée
Alex Bennée writes: > There are linux-user users of semihosting so we'd better check things > work for them as well. > > Signed-off-by: Alex Bennée > > --- > v3 > - include aarch64 version > v4 > - use common semicall.h, test thumb & arm > --- > tests/tcg/arm/semiconsole.c | 27

  1   2   3   4   >