On Wed, Jun 3, 2020 at 10:06 PM LIU Zhiwei wrote:
>
>
>
> On 2020/6/4 12:35, Alistair Francis wrote:
> > On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote:
> >>
> >>
> >> On 2020/6/3 23:56, Alistair Francis wrote:
> >>> On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote:
> On 2020/6/3 1:54,
On 2020/6/4 12:35, Alistair Francis wrote:
On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote:
On 2020/6/3 23:56, Alistair Francis wrote:
On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote:
On 2020/6/3 1:54, Alistair Francis wrote:
On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote:
Hi
+-- On Thu, 4 Jun 2020, BALATON Zoltan wrote --+
| On Thu, 4 Jun 2020, P J P wrote:
| > +assert(address + len <= pci_config_size(d));
|
| Does this allow guest now to crash QEMU?
Yes, possible. Such crash (assert failure) can be a regular bug, as reading
PCI configuration is likely a
Hi,
> > +assert(address + len <= pci_config_size(d));
>
> Does this allow guest now to crash QEMU?
Looks like it does (didn't actually try though).
> I think it was suggested that assert should only be used for cases
> that can only arise from a programming error and not from values set
On 04/06/2020 05.45, Richard Henderson wrote:
> Clang 10 enables this by default with -Wtype-limit.
>
> All of the instances flagged by this Werror so far have been
> cases in which we really do want the compiler to optimize away
> the test completely. Disabling the warning will avoid having
>
On 2020/6/4 12:35, Alistair Francis wrote:
On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote:
On 2020/6/3 23:56, Alistair Francis wrote:
On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote:
On 2020/6/3 1:54, Alistair Francis wrote:
On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote:
Hi
On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote:
>
>
>
> On 2020/6/3 23:56, Alistair Francis wrote:
> > On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote:
> >> On 2020/6/3 1:54, Alistair Francis wrote:
> >>> On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote:
> Hi Alistair,
>
> There
ping
On Thu, May 21, 2020 at 1:00 AM Raphael Norwitz
wrote:
>
> In QEMU today, a VM with a vhost-user device can hot add memory a
> maximum of 8 times. See these threads, among others:
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01046.html
>
Clang 10 enables this by default with -Wtype-limit.
All of the instances flagged by this Werror so far have been
cases in which we really do want the compiler to optimize away
the test completely. Disabling the warning will avoid having
to add ifdefs to work around this.
Signed-off-by: Richard
On 6/3/20 6:50 PM, agrecascino...@gmail.com wrote:
> static inline void tcg_out_shri64(TCGContext *s, TCGReg dst, TCGReg src, int
> c)
> {
> +tcg_debug_assert((c < 64) && (c >= 0));
> tcg_out_rld(s, RLDICL, dst, src, 64 - c, c);
> }
>
> @@ -2610,21 +2614,33 @@ static void
On 6/3/20 7:58 PM, Wei Wang wrote:
> It is possible that encoded_size==0, but unencoded_size !=0. For example,
> a page is written with the same data that it already has.
That really contains 0 bytes?
Not even the ones that say "same data"?
You certainly have a magical compression algorithm
On 06/04/2020 03:28 AM, Richard Henderson wrote:
On Wed, 29 Apr 2020 at 18:54, Wei Wang wrote:
+if (xbzrle_counters.pages == rs->xbzrle_pages_prev) {
+xbzrle_counters.encoding_rate = 0;
+} else if (!encoded_size) {
+xbzrle_counters.encoding_rate =
On 2020/6/3 23:56, Alistair Francis wrote:
On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote:
On 2020/6/3 1:54, Alistair Francis wrote:
On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote:
Hi Alistair,
There are still some questions I don't understand.
1. Is the baud rate or fifo a
Reviewed-by: Cameron Esfahani
Cameron Esfahani
di...@apple.com
"The cake is a lie."
Common wisdom
> On May 28, 2020, at 12:37 PM, Roman Bolshakov wrote:
>
> Hi,
>
> This is a cleanup series for HVF accel.
>
> HVF is using two emulator states CPUX86State and HVFX86EmulatorState
>
From: "Catherine A. Frederick"
Signed-off-by: Catherine A. Frederick
---
This should finally do it, sorry for the style issues on v3.
tcg/ppc/tcg-target.inc.c | 41 ++--
1 file changed, 35 insertions(+), 6 deletions(-)
diff --git a/tcg/ppc/tcg-target.inc.c
From: Chen Gang
Another DRM_IOCTL_* commands will be done later.
Signed-off-by: Chen Gang
---
configure | 10
linux-user/ioctls.h| 5 ++
linux-user/syscall.c | 95 ++
linux-user/syscall_defs.h | 15 ++
Reviewed-by: Cameron Esfahani
Cameron Esfahani
di...@apple.com
"It is the spirit and not the form of law that keeps justice alive."
Earl Warren
> On Jun 1, 2020, at 5:42 AM, Roman Bolshakov wrote:
>
> ld64 is making PIE executables for 10.7 and above by default, as
> documented in ld(1).
OK, thanks. I'll send patch v6. :)
On 2020/6/3 下午8:03, Laurent Vivier wrote:
> Le 03/06/2020 à 13:05, Chen Gang a écrit :
>> On 2020/6/3 下午5:49, Laurent Vivier wrote:
>>> Le 03/06/2020 à 03:08, cheng...@emindsoft.com.cn a écrit :
+#ifdef HAVE_DRM_H
+
+static void
Hi, Alexandar,
On Wed, Jun 3, 2020 at 10:34 PM Aleksandar Markovic
wrote:
>
>
>
> уто, 2. јун 2020. у 04:38 Huacai Chen је написао/ла:
>>
>> MIPS has two types of KVM: TE & VZ, and TE is the default type. Now we
>> can't create a VZ guest in QEMU because it lacks the kvm_type() hook in
>>
Started looking at this. Let me know if you have any ideas. Will respond
with more details later this week.
> -Original Message-
> From: Eduardo Habkost
> Sent: Tuesday, June 2, 2020 12:52 PM
> To: Moger, Babu
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
>
Reviewed-by: Cameron Esfahani
Cameron Esfahani
di...@apple.com
"Americans are very skilled at creating a custom meaning from something that's
mass-produced."
Ann Powers
> On May 7, 2020, at 6:16 AM, Gerd Hoffmann wrote:
>
> Use a single io range for _CRS instead of two,
> following what
Commit message typo tcg_allowed -> hvf_allowed.
If fixed:
Reviewed-by: Cameron Esfahani
Cameron Esfahani
di...@apple.com
"You only live once, and the way I live, once is enough"
Frank Sinatra
> On May 9, 2020, at 6:09 AM, Philippe Mathieu-Daudé wrote:
>
> When HVF is not available, the
Oh dear, I did it to myself again.
On Wed, Jun 3, 2020 at 7:13 PM wrote:
>
> From: "Catherine A. Frederick"
>
> Signed-off-by: Catherine A. Frederick
> ---
> tcg/ppc/tcg-target.inc.c | 28 ++--
> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> diff --git
From: "Catherine A. Frederick"
Signed-off-by: Catherine A. Frederick
---
tcg/ppc/tcg-target.inc.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c
index 7da67086c6..3cab56fe91 100644
---
在 2020/6/4 上午12:14, Li Qiang 写道:
After build qemu with '-fsanitize=address' extra-cflags,
'make check' show following leak:
=
==44580==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 2500 byte(s) in 1 object(s)
If we use QLNULL for null lockables, we can always
use referencing unknown_lock_type as a link time
error indicator.
Signed-off-by: Joe Slater
---
include/qemu/lockable.h | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/include/qemu/lockable.h
We currently will fail to build for optimizations like -Og because they do not
eliminate dead code. We do not need such clean up if we use QLNULL. There is
no
need to produce a QemuLockable that will be thrown away.
Only testing:
$ ../configure
$ make -j16 CFLAGS="$CFLAGS" # which I set
Allows us to build with -Og and optimizations that
do not clean up dead-code.
Signed-off-by: Joe Slater
to be squished
Signed-off-by: Joe Slater
---
block/block-backend.c | 4 ++--
block/block-copy.c | 2 +-
block/mirror.c | 5 +++--
On Thu, 4 Jun 2020, P J P wrote:
From: Prasad J Pandit
While reading PCI configuration bytes, a guest may send an
address towards the end of the configuration space. It may lead
to an OOB access issue. Assert that 'address + len' is within
PCI configuration space.
Suggested-by: Philippe
> -Original Message-
> From: Eduardo Habkost
> Sent: Wednesday, June 3, 2020 10:46 AM
> To: Moger, Babu
> Cc: marcel.apfelb...@gmail.com; pbonz...@redhat.com; r...@twiddle.net;
> m...@redhat.com; imamm...@redhat.com; qemu-devel@nongnu.org
> Subject: Re: [PATCH v7 07/13] hw/386: Add
On Thu, 4 Jun 2020, P J P wrote:
From: Prasad J Pandit
While reading PCI configuration bytes, a guest may send an
address towards the end of the configuration space. It may lead
to an OOB access issue. Add check to ensure 'address + size' is
within PCI configuration space.
Reported-by: Ren
On Thu, 4 Jun 2020, P J P wrote:
From: Prasad J Pandit
While accessing VGA registers via ati_mm_read/write routines,
a guest may set 's->regs.mm_index' such that it leads to infinite
recursion. Check mm_index value to avoid it.
Reported-by: Ren Ding
Reported-by: Hanqing Zhao
Reported-by: Yi
From: Prasad J Pandit
While reading PCI configuration bytes, a guest may send an
address towards the end of the configuration space. It may lead
to an OOB access issue. Add check to ensure 'address + size' is
within PCI configuration space.
Reported-by: Ren Ding
Reported-by: Hanqing Zhao
From: Prasad J Pandit
While reading PCI configuration bytes, a guest may send an
address towards the end of the configuration space. It may lead
to an OOB access issue. Assert that 'address + len' is within
PCI configuration space.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Prasad J
From: Prasad J Pandit
Hello,
This patch series fixes
1. While reading PCI configuration bytes, a guest may send an address towards
the end of the configuration space. It may lead to an OOB access issue.
Add check to ensure 'addr + size' is within bounds.
2. Assert that PCI configuration
On Wed, 29 Apr 2020 at 18:54, Wei Wang wrote:
> +if (xbzrle_counters.pages == rs->xbzrle_pages_prev) {
> +xbzrle_counters.encoding_rate = 0;
> +} else if (!encoded_size) {
> +xbzrle_counters.encoding_rate = UINT64_MAX;
> +} else {
> +
On 6/3/20 11:32 AM, Richard Henderson wrote:
I'd prefer we generate a compile-time error than a runtime trap (or nothing,
depending on compiler flags controlling __builtin_unreachable).
What we have DOES produce a compile-time error. If either expression to
MIN_CONST() is not actually const,
On 6/3/20 8:55 PM, P J P wrote:
> From: Prasad J Pandit
>
> While accessing VGA registers via ati_mm_read/write routines,
> a guest may set 's->regs.mm_index' such that it leads to infinite
> recursion. Check mm_index value to avoid it.
>
> Reported-by: Ren Ding
> Reported-by: Hanqing Zhao
>
+-- On Wed, 3 Jun 2020, BALATON Zoltan wrote --+
| or even > MM_DATA + 3 may be best as that only refers to defines used in
| that case. So maybe
|
| + } else if (s->regs.mm_index > MM_DATA + 3) {
| > ati_mm_write(s, s->regs.mm_index + addr - MM_DATA, data, size);
| > }
| >
| > and do the
From: Prasad J Pandit
While accessing VGA registers via ati_mm_read/write routines,
a guest may set 's->regs.mm_index' such that it leads to infinite
recursion. Check mm_index value to avoid it.
Reported-by: Ren Ding
Reported-by: Hanqing Zhao
Reported-by: Yi Ren
Signed-off-by: Prasad J
> Account the memory to the configured nid.
>
> Cc: Eduardo Habkost
> Cc: Marcel Apfelbaum
> Cc: "Michael S. Tsirkin"
> Signed-off-by: David Hildenbrand
> ---
> hw/core/numa.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/core/numa.c b/hw/core/numa.c
> index
Only SCSD cards support Class 6 (Block Oriented Write Protection)
commands.
"SD Specifications Part 1 Physical Layer Simplified Spec. v3.01"
4.3.14 Command Functional Difference in Card Capacity Types
* Write Protected Group
SDHC and SDXC do not support write-protected groups. Issuing
On 03/06/2020 20.01, Richard Henderson wrote:
> On 6/3/20 9:06 AM, Eric Blake wrote:
>> Instead of using #if, the following suffices to shut up clang:
>>
>> diff --git c/linux-user/mmap.c w/linux-user/mmap.c
>> index e37803379747..8d9ba201625d 100644
>> --- c/linux-user/mmap.c
>> +++
On 6/3/20 9:06 AM, Eric Blake wrote:
> Instead of using #if, the following suffices to shut up clang:
>
> diff --git c/linux-user/mmap.c w/linux-user/mmap.c
> index e37803379747..8d9ba201625d 100644
> --- c/linux-user/mmap.c
> +++ w/linux-user/mmap.c
> @@ -715,7 +715,7 @@ abi_long
Patchew URL:
https://patchew.org/QEMU/20200603160442.3151170-1-anthony.per...@citrix.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
Robert Foley writes:
> On Wed, 3 Jun 2020 at 07:43, Alex Bennée wrote:
>>
>>
>> Robert Foley writes:
>>
>
>> >
>> > When testing out the options, I noticed that
>> > if we supply arguments of "read", and "write", then we will only get
>> > the last one set, "write", since rw gets
On 6/3/20 6:14 PM, Li Qiang wrote:
> After build qemu with '-fsanitize=address' extra-cflags,
> 'make check' show following leak:
>
> =
> ==44580==ERROR: LeakSanitizer: detected memory leaks
>
> Direct leak of 2500 byte(s) in 1
Peter Maydell writes:
> On Tue, 2 Jun 2020 at 16:54, Alex Bennée wrote:
>>
>> This is a plugin intended to help with profiling access to various
>> bits of system hardware. It only really makes sense for system
>> emulation.
>>
>> It takes advantage of the recently exposed helper API that
The 06/03/2020 09:21, Richard Henderson wrote:
> On 6/3/20 6:50 AM, Szabolcs Nagy wrote:
> > thanks my tests now get further but later i run into
> > the previous assert failure:
> >
> > target/arm/mte_helper.c:97:allocation_tag_mem: assertion failed: (tag_size
> > <= in_page)
> >
> > i might
On Sonntag, 19. April 2020 17:06:17 CEST Christian Schoenebeck wrote:
> Make top half really top half and bottom half really bottom half:
>
> Each T_readdir request handling is hopping between threads (main
> I/O thread and background I/O driver threads) several times for
> every individual
On 03/06/20 18:04, Anthony PERARD wrote:
> From: Roger Pau Monne
>
> Xen PCI passthrough support may not be available and thus the global
> variable "has_igd_gfx_passthru" might be compiled out. Common code
> should not access it in that case.
>
> Unfortunately, we can't use
On Wed, Jun 03, 2020 at 05:04:42PM +0100, Anthony PERARD wrote:
> From: Roger Pau Monne
>
> Xen PCI passthrough support may not be available and thus the global
> variable "has_igd_gfx_passthru" might be compiled out. Common code
> should not access it in that case.
>
> Unfortunately, we can't
On Tue, 2 Jun 2020 at 15:22, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> > From: Lingfeng Yang
> >
> > +# Thread sanitizer is, for now, much noisier than the other sanitizers;
> > +# keep it separate until that is not the case.
>
> I think we also need to stop both being enabled at once.
On 5/24/20 9:48 AM, Philippe Mathieu-Daudé wrote:
> Convert APM_DPRINTF() to trace events and remove ifdef'ry.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/isa/apm.c| 15 +--
> hw/isa/trace-events | 4
> 2 files changed, 9 insertions(+), 10 deletions(-)
On 6/2/20 7:29 PM, Eric Blake wrote:
> Because:
>
> #if MIN(...)
>
> now fails to compile (you can't have { in a preprocessor expression), and:
>
> #if MIN_CONST(...)
>
> fails to compile (__builtin_constant_p() is not a preprocessor macro, so it
> warns that it is being treated as 0). The
After build qemu with '-fsanitize=address' extra-cflags,
'make check' show following leak:
=
==44580==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 2500 byte(s) in 1 object(s) allocated from:
#0 0x7f1b5a8b8d28 in
Signed-off-by: Alistair Francis
Reviewed-by: Bin Meng
---
docs/system/deprecated.rst | 33 ++---
target/riscv/cpu.h | 7 ---
target/riscv/cpu.c | 28
tests/qtest/machine-none-test.c | 4 ++--
4 files
Update the -bios deprecation documentation to describe the new
behaviour.
Signed-off-by: Alistair Francis
Reviewed-by: Bin Meng
---
docs/system/deprecated.rst | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/docs/system/deprecated.rst
From: Bin Meng
Remove the riscv_ prefix of the machine* functions.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Message-id: 1590072147-13035-2-git-send-email-bmeng...@gmail.com
Message-Id: <1590072147-13035-2-git-send-email-bmeng...@gmail.com>
From: Bin Meng
We only ship plain binary bios images in the QEMU source. With Spike
machine that uses ELF images as the default bios, running QEMU test
will complain hence let's suppress the error report for QEMU testing.
Signed-off-by: Bin Meng
Reviewed-by: Anup Patel
Message-Id:
On Wed, 3 Jun 2020 01:24:43 -0400
Yan Zhao wrote:
> On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote:
> > On Tue, 2 Jun 2020 23:19:48 -0400
> > Yan Zhao wrote:
> >
> > > On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote:
> > > > On Wed, 29 Apr 2020 20:39:50
From: Bin Meng
To keep consistency with the machine* functions, remove the riscv_
prefix of the soc* functions.
Signed-off-by: Bin Meng
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Message-id: 1590072147-13035-1-git-send-email-bmeng...@gmail.com
Message-Id:
Signed-off-by: Alistair Francis
Reviewed-by: Palmer Dabbelt
---
include/hw/riscv/sifive_e.h | 4
hw/riscv/sifive_e.c | 41 +++--
2 files changed, 34 insertions(+), 11 deletions(-)
diff --git a/include/hw/riscv/sifive_e.h
On 6/3/20 6:50 AM, Szabolcs Nagy wrote:
> thanks my tests now get further but later i run into
> the previous assert failure:
>
> target/arm/mte_helper.c:97:allocation_tag_mem: assertion failed: (tag_size <=
> in_page)
>
> i might be able to reduce it to a small reproducer
> this time. i assume
From: Bin Meng
Per QEMU deprecated doc, QEMU 4.1 introduced support for the -bios
option in QEMU for RISC-V for the virt machine and sifive_u machine.
The default behavior has been that QEMU does not automatically load
any firmware if no -bios option is included.
Now 2 releases passed, it's
Le 02/06/2020 à 13:53, Filip Bozuta a écrit :
> From: Filip Bozuta
>
> This patch implements strace argument printing functionality for following
> syscalls:
>
> *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value
>
> ssize_t getxattr(const char *path, const
The ISA specific Spike machines have been deprecated in QEMU since 4.1,
let's finally remove them.
Signed-off-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Bin Meng
Reviewed-by: Thomas Huth
---
docs/system/deprecated.rst | 17 +--
include/hw/riscv/spike.h | 6 +-
The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since
4.1. It's not commonly used so let's remove support for it.
Signed-off-by: Alistair Francis
Reviewed-by: Bin Meng
---
docs/system/deprecated.rst| 20 +--
target/riscv/cpu.h|
-20200603
for you to fetch changes up to fe0fe4735e798578097758781166cc221319b93d:
riscv: Initial commit of OpenTitan machine (2020-06-03 09:11:51 -0700)
This is a collection of RISC-V patches for 5.1.
This incldues removing deprecated
> -Original Message-
> From: Anthony PERARD
> Sent: 03 June 2020 17:05
> To: qemu-devel@nongnu.org
> Cc: Anthony PERARD ; Roger Pau Monne
> ; Michael S.
> Tsirkin ; Marcel Apfelbaum ;
> Paolo Bonzini
> ; Richard Henderson ; Eduardo Habkost
> ;
> Stefano Stabellini ; Paul Durrant ; xen-
On 6/3/20 5:37 AM, Philippe Mathieu-Daudé wrote:
> Use the common API for semihosting logging.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> default-configs/unicore32-softmmu.mak | 1 +
> target/unicore32/helper.c | 57 +++
> 2 files changed, 6
On 6/3/20 5:37 AM, Philippe Mathieu-Daudé wrote:
> Replace disabled DPRINTF() by qemu_log_mask(GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/unicore32/helper.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 6/3/20 5:37 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/unicore32/helper.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On 6/3/20 4:24 AM, Alex Bennée wrote:
> There is no particular reason why you can't have a watchpoint in TCG
> that covers a large chunk of the address space. We could be clever
> about it but these cases are pretty rare and we can assume the user
> will expect a little performance degradation.
>
On 6/2/20 11:43 PM, Philippe Mathieu-Daudé wrote:
>
> Hi Catherine,
>
> On 6/3/20 7:23 AM, agrecascino...@gmail.com wrote:
>> From: "Catherine A. Frederick"
>>
>> Signed-off-by: "Catherine A. Frederick"
>> ---
>> tcg/ppc/tcg-target.inc.c | 4
>> 1 file changed, 4 insertions(+)
>>
>> diff
On Wed, 3 Jun 2020 16:36:27 +0200
Philippe Mathieu-Daudé wrote:
> On 6/3/20 4:09 PM, Justin Hibbits wrote:
> > On Wed, 3 Jun 2020 08:08:42 +0200
> > Philippe Mathieu-Daudé wrote:
> >
> >> Cc'ing more developers.
> >>
> >> On 5/26/20 10:40 PM, David CARLIER wrote:
> >>> From
On 5/3/20 6:32 AM, Philippe Mathieu-Daudé wrote:
When building with Clang 10 on Fedora 32, we get:
CC linux-user/mmap.o
linux-user/mmap.c:720:49: error: result of comparison 'unsigned long' >
18446744073709551615 is always false [-Werror,-Wtautological-type-limit-compare]
On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote:
>
> On 2020/6/3 1:54, Alistair Francis wrote:
> > On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote:
> >> Hi Alistair,
> >>
> >> There are still some questions I don't understand.
> >>
> >> 1. Is the baud rate or fifo a necessary feature to
From: Roger Pau Monne
Xen PCI passthrough support may not be available and thus the global
variable "has_igd_gfx_passthru" might be compiled out. Common code
should not access it in that case.
Unfortunately, we can't use CONFIG_XEN_PCI_PASSTHROUGH directly in
xen-common.c so this patch instead
On 6/3/20 10:45 AM, Eduardo Habkost wrote:
> On Wed, Jun 03, 2020 at 10:38:46AM -0500, Babu Moger wrote:
>>
>>
>> On 6/3/20 10:31 AM, Eduardo Habkost wrote:
>>> On Wed, Jun 03, 2020 at 10:22:10AM -0500, Babu Moger wrote:
> -Original Message-
> From: Eduardo Habkost
On Tue, 2 Jun 2020 at 16:54, Alex Bennée wrote:
>
> This is a plugin intended to help with profiling access to various
> bits of system hardware. It only really makes sense for system
> emulation.
>
> It takes advantage of the recently exposed helper API that allows us
> to see the device name
On Tue, 2 Jun 2020 at 16:21, Alex Bennée wrote:
>
>
> Robert Foley writes:
> >
> > configure_qemu()
> > {
> > +if test -z "$TSAN"; then
> > +requires clang tsan
> > +echo "Including TSan Support"
> > +tsan_log_dir="/tmp/qemu-test/build/tsan"
> > +mkdir -p
On Wed, Jun 03, 2020 at 10:38:46AM -0500, Babu Moger wrote:
>
>
> On 6/3/20 10:31 AM, Eduardo Habkost wrote:
> > On Wed, Jun 03, 2020 at 10:22:10AM -0500, Babu Moger wrote:
> >>
> >>
> >>> -Original Message-
> >>> From: Eduardo Habkost
> >>> Sent: Tuesday, June 2, 2020 6:01 PM
> >>> To:
On Wed, 3 Jun 2020, BALATON Zoltan wrote:
On Wed, 3 Jun 2020, P J P wrote:
+-- On Wed, 3 Jun 2020, Gerd Hoffmann wrote --+
| Hmm, why modify mm_index? Shouldn't we just check it is non-zero
| before calling ati_mm_read/ati_mm_write?
if (s->regs.mm_index & BIT(31)) {
...
} else {
On Wed, 3 Jun 2020 at 07:43, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> >
> > When testing out the options, I noticed that
> > if we supply arguments of "read", and "write", then we will only get
> > the last one set, "write", since rw gets overwritten.
> > One option would be to error
On 6/3/20 10:31 AM, Eduardo Habkost wrote:
> On Wed, Jun 03, 2020 at 10:22:10AM -0500, Babu Moger wrote:
>>
>>
>>> -Original Message-
>>> From: Eduardo Habkost
>>> Sent: Tuesday, June 2, 2020 6:01 PM
>>> To: Moger, Babu
>>> Cc: marcel.apfelb...@gmail.com; pbonz...@redhat.com;
On Wed, 3 Jun 2020, P J P wrote:
+-- On Wed, 3 Jun 2020, Gerd Hoffmann wrote --+
| Hmm, why modify mm_index? Shouldn't we just check it is non-zero
| before calling ati_mm_read/ati_mm_write?
if (s->regs.mm_index & BIT(31)) {
...
} else {
ati_mm_write(s, s->regs.mm_index + addr -
On 6/2/20 9:29 PM, Eric Blake wrote:
+++ b/accel/tcg/translate-all.c
@@ -2565,9 +2565,9 @@ int page_check_range(target_ulong start,
target_ulong len, int flags)
/* This function should never be called with addresses outside the
guest address space. If this assert fires, it
On Wed, Jun 03, 2020 at 08:05:50PM +0530, P J P wrote:
> +-- On Wed, 3 Jun 2020, Gerd Hoffmann wrote --+
> | Hmm, why modify mm_index? Shouldn't we just check it is non-zero
> | before calling ati_mm_read/ati_mm_write?
>
> if (s->regs.mm_index & BIT(31)) {
> ...
> } else {
} else if
On Wed, Jun 03, 2020 at 10:22:10AM -0500, Babu Moger wrote:
>
>
> > -Original Message-
> > From: Eduardo Habkost
> > Sent: Tuesday, June 2, 2020 6:01 PM
> > To: Moger, Babu
> > Cc: marcel.apfelb...@gmail.com; pbonz...@redhat.com; r...@twiddle.net;
> > m...@redhat.com;
On 200603 1646, Thomas Huth wrote:
> On 02/06/2020 15.40, Alexander Bulekov wrote:
> > Thank you Darren.
> >
> > On 200602 1428, Darren Kenny wrote:
> >>
> >> Hi Alex,
> >>
> >> In general the series looks good, so:
> >>
> >> Reviewed-by: Darren Kenny
> >>
> >> But not sure how to handle the
> -Original Message-
> From: Eduardo Habkost
> Sent: Tuesday, June 2, 2020 6:01 PM
> To: Moger, Babu
> Cc: marcel.apfelb...@gmail.com; pbonz...@redhat.com; r...@twiddle.net;
> m...@redhat.com; imamm...@redhat.com; qemu-devel@nongnu.org
> Subject: Re: [PATCH v7 07/13] hw/386: Add EPYC
Pan Nengyuan 于2020年6月3日周三 下午2:17写道：
> 'obj' forgot to free at the end of hmp_qom_get(). Fix that.
>
> The leak stack:
> Direct leak of 40 byte(s) in 1 object(s) allocated from:
> #0 0x7f4e3a779ae8 in __interceptor_malloc (/lib64/libasan.so.5+0xefae8)
> #1 0x7f4e398f91d5 in g_malloc
On 6/3/20 9:48 AM, David Hildenbrand wrote:
This is the very basic, initial version of virtio-mem. More info on
virtio-mem in general can be found in the Linux kernel driver v2 posting
[1] and in patch #10. The latest Linux driver v4 can be found at [2].
This series is based on [3]:
Hi Igor,
My sincere Apologies, I just realized that I missed to reply this mail.
I was distracted to something else in the month of the February and
had only resumed working on hotplug in march. But will still reply to
this mail. Also, I have incorporated most of the below points as in the
vcpu
Sorry that I am not familiar with this part so I asked others to help
review (the FreeBSD related code). It's good and please append:
Reviewed-by: Edward Tomasz Napierala
Thanks!
On Wed, Jun 3, 2020 at 2:14 PM David CARLIER wrote:
>
> Sorry it landed in the spam.
>
> It does make things more
On 6/2/20 9:42 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma
> ---
> include/block/accounting.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/block/accounting.h b/include/block/accounting.h
> index 878b4c3581..645014fb0b 100644
> --- a/include/block/accounting.h
> +++
Set vendor property to IMX to enable IMX specific functionality
in sdhci code.
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Guenter Roeck
---
v2: Added missing error checks
Added Philippe's Tested-by: tag
hw/arm/fsl-imx25.c | 6 ++
hw/arm/fsl-imx6.c | 6 ++
On 6/2/20 9:42 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma
> ---
> hw/scsi/scsi-disk.c | 92
> include/scsi/constants.h | 1 +
> 2 files changed, 93 insertions(+)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index
We want to make sure that certain properties don't change during
migration, especially to catch user errors in a nice way. Let's migrate
a temporary structure and validate that the properties didn't change.
Cc: "Michael S. Tsirkin"
Cc: "Dr. David Alan Gilbert"
Signed-off-by: David Hildenbrand
1 - 100 of 247 matches
Mail list logo
