Re: [PATCH v7 17/47] block: Re-evaluate backing file handling in reopen

2020-07-16 Thread Max Reitz
On 10.07.20 21:42, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Reopening a node's backing child needs a bit of special handling because >> the "backing" child has different defaults than all other children >> (among other things).  Adding filter support here is a bit more

[PATCH] qapi: fix memory leak in visit_type_UserDefOneList

2020-07-16 Thread Li Qiang
While executing 'tests/test-qobject-input-visitor'. I got following error: /visitor/input/fail/alternate: OK /visitor/input/fail/union-list: OK = ==4353==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1

Re: [PATCH v7 14/47] stream: Deal with filters

2020-07-16 Thread Max Reitz
On 10.07.20 19:41, Andrey Shinkevich wrote: > On 10.07.2020 18:24, Max Reitz wrote: >> On 09.07.20 16:52, Andrey Shinkevich wrote: >>> On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 16:25:18 CEST Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 03:11:01PM +0200, Thomas Huth wrote: > > When using --enable-werror for the macOS builders in the Cirrus-CI, > > the atomic64 test is currently failing, and config.log shows a bunch > > > > of error

Re: [PATCH v7 02/47] block: Add chain helper functions

2020-07-16 Thread Max Reitz
On 13.07.20 12:18, Vladimir Sementsov-Ogievskiy wrote: > 25.06.2020 18:21, Max Reitz wrote: >> Add some helper functions for skipping filters in a chain of block >> nodes. >> >> Signed-off-by: Max Reitz >> --- >>   include/block/block_int.h |  3 +++ >>   block.c   | 55

[PATCH] docs/s390x: fix vfio-ccw type

2020-07-16 Thread Cornelia Huck
Fix the type name in the mdevctl example. Signed-off-by: Cornelia Huck --- I always seem to get this one wrong, and mdevctl does not complain until it wants to start the device... --- docs/system/s390x/vfio-ccw.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 17:44, Andrey Shinkevich wrote: On 16.07.2020 17:38, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:36, Andrey Shinkevich wrote: On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments

Re: [PATCH v7 01/47] block: Add child access functions

2020-07-16 Thread Max Reitz
On 13.07.20 11:06, Vladimir Sementsov-Ogievskiy wrote: > 25.06.2020 18:21, Max Reitz wrote: >> There are BDS children that the general block layer code can access, >> namely bs->file and bs->backing.  Since the introduction of filters and >> external data files, their meaning is not quite clear. 

Re: [PATCH for-5.1] iotests/030: Reduce job speed to make race less likely

2020-07-16 Thread Max Reitz
On 16.07.20 15:28, Kevin Wolf wrote: > It can happen that the throttling of the stream job doesn't make it slow > enough that we can be sure that it still exists when it is referenced > again. Just use a much smaller speed to make this very unlikely to > happen again. > > Reported-by: Peter

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Andrey Shinkevich
On 16.07.2020 17:38, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:36, Andrey Shinkevich wrote: On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format.

[PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-16 Thread Laszlo Ersek
Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an object that has static storage duration shall be constant expressions or string literals". The compound literal produced by the make_floatx80() macro is not such a constant expression, per 6.6p7-9. (An implementation may

Re: [PATCH-for-5.2] hw/s390x: Move S390_ADAPTER_SUPPRESSIBLE from 'css.h' to 's390_flic.h'

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 1:11 PM, Cornelia Huck wrote: > On Wed, 15 Jul 2020 15:18:45 +0200 > Philippe Mathieu-Daudé wrote: > >> Not all s390x devices require to have access to the CPU internals. >> >> To reduce the include dependencies on "s390x/css.h", move the >> S390_ADAPTER_SUPPRESSIBLE definition to

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 16:01:18 +0200 Markus Armbruster wrote: > David Gibson writes: > > > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > >> Some recent error handling cleanups unveiled issues with our support of > >> PCI bridges: > >> > >> 1) QEMU aborts when using non-standard

Re: [PATCH] util: qemu_get_thread_id for OpenBSD

2020-07-16 Thread Peter Maydell
On Wed, 15 Jul 2020 at 08:41, Brad Smith wrote: > > On 7/15/2020 12:54 AM, Thomas Huth wrote: > > On 14/07/2020 23.26, David CARLIER wrote: > >> From 9c7f54c67d40fae0174ba795fbaad829cd59c264 Mon Sep 17 00:00:00 2001 > >> From: David Carlier > >> Date: Tue, 14 Jul 2020 23:23:55 +0100 > >>

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 17:36, Andrey Shinkevich wrote: On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Andrey Shinkevich
On 16.07.2020 13:20, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Thomas Huth
On 16/07/2020 16.15, Christian Schoenebeck wrote: > On Donnerstag, 16. Juli 2020 15:11:01 CEST Thomas Huth wrote: >> When using --enable-werror for the macOS builders in the Cirrus-CI, >> the atomic64 test is currently failing, and config.log shows a bunch >> of error messages like this: >> >>

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Thomas Huth
On 16/07/2020 16.25, Daniel P. Berrangé wrote: > On Thu, Jul 16, 2020 at 03:11:01PM +0200, Thomas Huth wrote: >> When using --enable-werror for the macOS builders in the Cirrus-CI, >> the atomic64 test is currently failing, and config.log shows a bunch >> of error messages like this: >> >>

[PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size

2020-07-16 Thread Kevin Wolf
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1834646 Patch 1 fixes the assertion failure by failing gracefully when opening an image whose size isn't aligned to the required request alignment. Patch 2 relaxes the restrictions for NFS, which actually supports byte alignment, but incorrectly

[PATCH for-5.1 v2 2/2] file-posix: Allow byte-aligned O_DIRECT with NFS

2020-07-16 Thread Kevin Wolf
Since commit a6b257a08e3 ('file-posix: Handle undetectable alignment'), we assume that if we open a file with O_DIRECT and alignment probing returns 1, we just couldn't find out the real alignment requirement because some filesystems make the requirement only for allocated blocks. In this case, a

[PATCH for-5.1 v2 1/2] block: Require aligned image size to avoid assertion failure

2020-07-16 Thread Kevin Wolf
Unaligned requests will automatically be aligned to bl.request_alignment and we can't extend write requests to access space beyond the end of the image without resizing the image, so if we have the WRITE permission, but not the RESIZE one, it's required that the image size is aligned. Failing to

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 03:11:01PM +0200, Thomas Huth wrote: > When using --enable-werror for the macOS builders in the Cirrus-CI, > the atomic64 test is currently failing, and config.log shows a bunch > of error messages like this: > > config-temp/qemu-conf.c:6:7: error: implicit declaration of

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Markus Armbruster
David Gibson writes: > On Thu, Jul 16, 2020 at 12:32:44PM +0200, Greg Kurz wrote: >> On Thu, 16 Jul 2020 14:45:40 +1000 >> David Gibson wrote: >> >> > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: >> > > Some recent error handling cleanups unveiled issues with our support of >> >

Re: [PATCH for-5.1 0/3] target/arm: MTE improvements

2020-07-16 Thread Peter Maydell
On Mon, 13 Jul 2020 at 22:33, Richard Henderson wrote: > > Since MTE is new, and guest support for MTE is still under > development, let's disable it by default. > > Peter mentioned memory hotplug on IRC as something that > would break MTE's assumptions. By putting the enable flag > on the

Re: [RFC PATCH] os-posix: fix regression for install-less datadir location

2020-07-16 Thread Marc-André Lureau
Hi On Thu, Jul 16, 2020 at 6:11 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > os_find_datadir() used to check the ../share/qemu location (regardless > of CONFIG_QEMU_DATADIR). It turns out that people rely on that location > for running qemu in an arbitrary "install-less/portable"

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 15:11:01 CEST Thomas Huth wrote: > When using --enable-werror for the macOS builders in the Cirrus-CI, > the atomic64 test is currently failing, and config.log shows a bunch > of error messages like this: > > config-temp/qemu-conf.c:6:7: error: implicit declaration

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-07-16 Thread Marc-André Lureau
Hi On Tue, Jun 16, 2020 at 2:59 AM Joe Slater wrote: > Always look for ../share/qemu then ../pc-bios when looking for datadir. > > Signed-off-by: Joe Slater > Looks good to me, with: Fixes: 6dd2dacedd83d12328 ("os-posix: simplify os_find_datadir") Reviewed-by: Marc-André Lureau

[RFC PATCH] os-posix: fix regression for install-less datadir location

2020-07-16 Thread Marc-André Lureau
os_find_datadir() used to check the ../share/qemu location (regardless of CONFIG_QEMU_DATADIR). It turns out that people rely on that location for running qemu in an arbitrary "install-less/portable" fashion. Change the logic to return that directory as a last resort. (this is an alternative to

Re: [PATCH QEMU v2 4/5] ARM: PL061: Add gpiodev support

2020-07-16 Thread Geert Uytterhoeven
Hi Philippe, On Thu, Apr 23, 2020 at 12:08 PM Philippe Mathieu-Daudé wrote: > On 4/23/20 11:33 AM, Philippe Mathieu-Daudé wrote: > > On 4/23/20 11:01 AM, Geert Uytterhoeven wrote: > >> Make the PL061 GPIO controller user-creatable, and allow the user to tie > >> a newly created instance to a

Re: [PATCH v2] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-16 Thread Peter Maydell
On Thu, 16 Jul 2020 at 07:07, Cédric Le Goater wrote: > > On 7/15/20 7:34 PM, erik-smit wrote: > > Signed-off-by: erik-smit > > Reviewed-by: Cédric Le Goater Thanks; I've put this in my list of patches to put in via target-arm.next once 5.1 is released. If I seem to have forgotten about it

Re: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200716131101.18462-1-th...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Markus Armbruster
David Gibson writes: > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: >> Some recent error handling cleanups unveiled issues with our support of >> PCI bridges: >> >> 1) QEMU aborts when using non-standard PCI bridge types, >>unveiled by commit 7ef1553dac "spapr_pci: Drop some

[PATCH v2 3/3] iotests: Test node/bitmap aliases during migration

2020-07-16 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/300 | 511 + tests/qemu-iotests/300.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 517 insertions(+) create mode 100755 tests/qemu-iotests/300 create mode 100644

[PATCH v2 1/3] migration: Add block-bitmap-mapping parameter

2020-07-16 Thread Max Reitz
This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu

[PATCH v2 2/3] iotests.py: Add wait_for_runstate()

2020-07-16 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 3590ed78a0..fb240a334c 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -803,6

[PATCH v2 0/3] migration: Add block-bitmap-mapping parameter

2020-07-16 Thread Max Reitz
RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg09792.html Branch: https://github.com/XanClic/qemu.git

Re: [PULL 0/7] Net patches

2020-07-16 Thread Peter Maydell
On Wed, 15 Jul 2020 at 14:53, Jason Wang wrote: > > The following changes since commit 673205379fb499d2b72f2985b47ec7114282f5fe: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/python-next-20200714' into staging (2020-07-15 > 13:04:27 +0100) > > are available in the git

Re: [PATCH 0/2] virtio: non-legacy device handling

2020-07-16 Thread Cornelia Huck
On Tue, 7 Jul 2020 12:54:44 +0200 Cornelia Huck wrote: > As discussed in "virtio-fs: force virtio 1.x usage", it seems like > a good idea to make sure that any new virtio device (which does not > support legacy virtio) is indeed a non-transitional device, just to > catch accidental

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 3:13 PM, Alex Bennée wrote: > > Robert Foley writes: > >> On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: >>> >>> >>> Robert Foley writes: >>> The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Signed-off-by: Robert Foley

Re: [PATCH 2/2] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-16 Thread Alex Bennée
Robert Foley writes: > The primary purpose of this change is to clean up > machine.py's console_socket property to return a single type, > a ConsoleSocket. > > ConsoleSocket now derives from a socket, which means that > in the default case (of not draining), machine.py > will see the same

Re: [PATCH v8 08/18] hw/arm/allwinner: add SD/MMC host controller

2020-07-16 Thread Philippe Mathieu-Daudé
On 3/11/20 11:18 PM, Niek Linnenbank wrote: > The Allwinner System on Chip families sun4i and above contain > an integrated storage controller for Secure Digital (SD) and > Multi Media Card (MMC) interfaces. This commit adds support > for the Allwinner SD/MMC storage controller with the following

Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200716101442.48057-1-...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2] crypto: use a stronger private key for tests

2020-07-16 Thread Kevin Wolf
Am 15.07.2020 um 17:47 hat Daniel P. Berrangé geschrieben: > The unit tests using the x509 crypto functionality have started > failing in Fedora 33 rawhide with a message like > > The certificate uses an insecure algorithm > > This is result of Fedora changes to support strong crypto [1].

Re: [PULL 00/12] Block patches

2020-07-16 Thread Kevin Wolf
Am 16.07.2020 um 14:40 hat Peter Maydell geschrieben: > On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > > > We can "fix" it for probably all realistic cases by lowering the speed > > of the block job significantly. It's still not fully fixed for all > > theoretical cases, but the pattern of

[PATCH for-5.1] iotests/030: Reduce job speed to make race less likely

2020-07-16 Thread Kevin Wolf
It can happen that the throttling of the stream job doesn't make it slow enough that we can be sure that it still exists when it is referenced again. Just use a much smaller speed to make this very unlikely to happen again. Reported-by: Peter Maydell Signed-off-by: Kevin Wolf ---

Re: TB Cache size grows out of control with qemu 5.0

2020-07-16 Thread Christian Ehrhardt
On Wed, Jul 15, 2020 at 5:58 PM BALATON Zoltan wrote: > See commit 47a2def4533a2807e48954abd50b32ecb1aaf29a and the next two > following it. > Thank you Zoltan for pointing out this commit, I agree that this seems to be the trigger for the issues I'm seeing. Unfortunately the common CI host

Re: [PATCH v8 08/18] hw/arm/allwinner: add SD/MMC host controller

2020-07-16 Thread Philippe Mathieu-Daudé
Hi Niek, On 3/11/20 11:18 PM, Niek Linnenbank wrote: > The Allwinner System on Chip families sun4i and above contain > an integrated storage controller for Secure Digital (SD) and > Multi Media Card (MMC) interfaces. This commit adds support > for the Allwinner SD/MMC storage controller with the

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Alex Bennée
Robert Foley writes: > On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: >> >> >> Robert Foley writes: >> >> > The changes to console_socket.py and machine.py are to >> > cleanup for pylint and flake8. >> > >> > Signed-off-by: Robert Foley >> > --- >> > python/qemu/console_socket.py | 58

RE: [PATCH v3 0/3] Make hcd-xhci independent of pci hooks

2020-07-16 Thread Sai Pavan Boddu
Hi Gred, > -Original Message- > From: Gerd Hoffmann > Sent: Wednesday, July 15, 2020 4:21 PM > To: Sai Pavan Boddu > Cc: Peter Maydell ; Markus Armbruster > ; Thomas Huth ; Eduardo > Habkost ; qemu-devel@nongnu.org; Alistair Francis > ; 'Marc-André Lureau' > ; Ying Fang ; > Paolo

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread David Gibson
On Thu, Jul 16, 2020 at 12:32:44PM +0200, Greg Kurz wrote: > On Thu, 16 Jul 2020 14:45:40 +1000 > David Gibson wrote: > > > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > > > Some recent error handling cleanups unveiled issues with our support of > > > PCI bridges: > > > > > > 1)

[RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-16 Thread Thomas Huth
When using --enable-werror for the macOS builders in the Cirrus-CI, the atomic64 test is currently failing, and config.log shows a bunch of error messages like this: config-temp/qemu-conf.c:6:7: error: implicit declaration of function '__atomic_load_8' is invalid in C99

Re: [PATCH v5 19/20] tests/acpi: add microvm test

2020-07-16 Thread Igor Mammedov
On Thu, 16 Jul 2020 11:10:35 +0200 Gerd Hoffmann wrote: > Hi, > > > > +data.required_struct_types = base_required_struct_types; > > > +data.required_struct_types_len = > > > ARRAY_SIZE(base_required_struct_types); > > I vaguely recall this belongs to smbios tables, does actually

Re: [RFC PATCH-for-5.2 v2 2/2] block/block-backend: Let blk_attach_dev() provide helpful error

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 02:37:04PM +0200, Philippe Mathieu-Daudé wrote: > Let blk_attach_dev() take an Error* object to return helpful > information. Adapt the callers. > > $ qemu-system-arm -M n800 > qemu-system-arm: sd_init failed: cannot attach blk 'sd0' to device 'sd-card' > blk 'sd0'

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-16 Thread Claudio Fontana
Small update on this, On 7/15/20 1:10 PM, Claudio Fontana wrote: > Hi Thomas, > > On 7/14/20 4:35 PM, Thomas Huth wrote: >> On 14/07/2020 16.29, Claudio Fontana wrote: >>> Hello, >>> >>> I have some tiny progress in narrowing down this issue, possibly a qcow2 >>> issue, still unclear, >>> but

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 02:22:14PM +0200, Christian Schoenebeck wrote: > On Donnerstag, 16. Juli 2020 12:01:57 CEST Daniel P. Berrangé wrote: > > > My concern here is that just distinguishing between either 'low' or 'high' > > > is a far too rough classification. > > > > > > In our preceding

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Robert Foley
On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: > > > Robert Foley writes: > > > The changes to console_socket.py and machine.py are to > > cleanup for pylint and flake8. > > > > Signed-off-by: Robert Foley > > --- > > python/qemu/console_socket.py | 58 +-- > >

Re: [PATCH] qapi: record the last element in order to avoid memory leak

2020-07-16 Thread Markus Armbruster
Li Qiang writes: > While executing 'tests/test-qobject-input-visitor'. I got > following error: > > /visitor/input/fail/alternate: OK > /visitor/input/fail/union-list: OK > > = > ==4353==ERROR: LeakSanitizer: detected memory leaks >

Re: [PATCH-for-5.2 v2 1/2] block/block-backend: Trace blk_attach_dev()

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 2:37 PM, Philippe Mathieu-Daudé wrote: > Add a trace event to follow devices attaching block drives: > > $ qemu-system-arm -M n800 -trace blk_\* > 9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device > 'omap2-mmc' > 9513@1594040428.738189:blk_attach_dev attaching

Re: [PULL 00/12] Block patches

2020-07-16 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > We can "fix" it for probably all realistic cases by lowering the speed > of the block job significantly. It's still not fully fixed for all > theoretical cases, but the pattern of starting a block job that is > throttled to a low speed so it will

[PATCH-for-5.2 v2 0/2] block/block-backend: Let blk_attach_dev() provide helpful error

2020-07-16 Thread Philippe Mathieu-Daudé
A pair of patches which helps me debug an issue with block drive already attached. Suggestions to correctly/better use the Error API welcome, in particular in qdev-properties-system::set_drive_helper(). Since v1: - Rebased after 668f62ec62 ("error: Eliminate error_propagate()") Philippe

[RFC PATCH-for-5.2 v2 2/2] block/block-backend: Let blk_attach_dev() provide helpful error

2020-07-16 Thread Philippe Mathieu-Daudé
Let blk_attach_dev() take an Error* object to return helpful information. Adapt the callers. $ qemu-system-arm -M n800 qemu-system-arm: sd_init failed: cannot attach blk 'sd0' to device 'sd-card' blk 'sd0' is already attached by device 'omap2-mmc' Drive 'sd0' is already in use because it

[PATCH-for-5.2 v2 1/2] block/block-backend: Trace blk_attach_dev()

2020-07-16 Thread Philippe Mathieu-Daudé
Add a trace event to follow devices attaching block drives: $ qemu-system-arm -M n800 -trace blk_\* 9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device 'omap2-mmc' 9513@1594040428.738189:blk_attach_dev attaching blk 'sd0' to device 'sd-card' qemu-system-arm: sd_init

Re: [RFC 3/3] x68: acpi: trigger SMI before scanning for hotplugged CPUs

2020-07-16 Thread Laszlo Ersek
On 07/15/20 15:43, Igor Mammedov wrote: > On Wed, 15 Jul 2020 14:38:00 +0200 > Laszlo Ersek wrote: > >> On 07/14/20 17:19, Igor Mammedov wrote: >>> On Tue, 14 Jul 2020 14:41:28 +0200 >>> Laszlo Ersek wrote: >>> On 07/14/20 14:28, Laszlo Ersek wrote: > (CC'ing Peter Krempa due to

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 12:01:57 CEST Daniel P. Berrangé wrote: > > My concern here is that just distinguishing between either 'low' or 'high' > > is a far too rough classification. > > > > In our preceding communication regarding 9pfs, I made clear that a) we do > > care about security

Re: qemu test-qga failure on mergebuild after VERSION file change: dependency issues??

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 12:53 PM, Peter Maydell wrote: > The first merge I tried to process after bumping VERSION for rc0 > failed on test-qga like this: > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > tests/test-qga -m=quick -k --tap < /dev/null | ./scripts/tap-driv > er.pl

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-07-16 Thread Cornelia Huck
On Wed, 15 Jul 2020 12:26:20 -0400 Collin Walling wrote: > On 7/15/20 12:04 PM, Cornelia Huck wrote: > > On Wed, 15 Jul 2020 11:36:35 -0400 > > Collin Walling wrote: > > > >> Polite ping. Patches have been sitting on the list for a few weeks now, > >> and it doesn't look like any further

[PATCH] qcow2: cleanup created file when qcow2_co_create

2020-07-16 Thread Maxim Levitsky
This is basically the same thing as commit 'crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails' does but for qcow2 files to ensure that we don't leave qcow2 files when creation fails. Signed-off-by: Maxim Levitsky --- block/qcow2.c | 11 +++ 1 file changed, 11

Re: [PATCH-for-5.2] hw/s390x: Move S390_ADAPTER_SUPPRESSIBLE from 'css.h' to 's390_flic.h'

2020-07-16 Thread Cornelia Huck
On Wed, 15 Jul 2020 15:18:45 +0200 Philippe Mathieu-Daudé wrote: > Not all s390x devices require to have access to the CPU internals. > > To reduce the include dependencies on "s390x/css.h", move the > S390_ADAPTER_SUPPRESSIBLE definition to "s390x/s390_flic.h". But css.h is not 'CPU

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Alex Bennée
Robert Foley writes: > The changes to console_socket.py and machine.py are to > cleanup for pylint and flake8. > > Signed-off-by: Robert Foley > --- > python/qemu/console_socket.py | 58 +-- > python/qemu/machine.py| 7 +++-- > python/qemu/pylintrc

Re: [PATCH 4/4] net/colo: Match is-enabled probe to tracepoint

2020-07-16 Thread Roman Bolshakov
On Thu, Jul 16, 2020 at 09:51:27AM +0100, Daniel P. Berrangé wrote: > Adding Stefan to CC as the trace maintainer. > > On Thu, Jul 16, 2020 at 11:17:54AM +0300, Roman Bolshakov wrote: > > Build of QEMU with dtrace fails on macOS: > > > > LINKx86_64-softmmu/qemu-system-x86_64 > > error:

qemu test-qga failure on mergebuild after VERSION file change: dependency issues??

2020-07-16 Thread Peter Maydell
The first merge I tried to process after bumping VERSION for rc0 failed on test-qga like this: MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-qga -m=quick -k --tap < /dev/null | ./scripts/tap-driv er.pl --test-name="test-qga" PASS 1 test-qga /qga/sync-delimited PASS 2

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Thomas Huth
On 16/07/2020 12.33, Li Qiang wrote: > Markus Armbruster 于2020年7月16日周四 下午5:52写道: >> >> Li Qiang writes: >> >>> Markus Armbruster 于2020年7月16日周四 下午1:59写道: Li Qiang writes: > Properly free each test response to avoid memory leak and separate > qtest_qmp() calls with spare

Re: [virtio-dev] [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-16 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 03:01:18PM +0800, teawater wrote: > > > > 2020年7月16日 14:38,Michael S. Tsirkin 写道: > > > > On Thu, Jul 16, 2020 at 10:41:50AM +0800, Hui Zhu wrote: > >> The first, second and third version are in [1], [2] and [3]. > >> Code of current version for Linux and qemu is

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Markus Armbruster
Daniel P. Berrangé writes: [...] > NB, the build time classification won't be perfect, but that's largely > because we don't have sufficient granularity in what we build. For > example, although we only care about QMP, IIUC, we can't turn off HMP > at build time. It could be made compile-time

Re: [PATCH 4/5] linux-user: Support CLONE_VM and extended clone options

2020-07-16 Thread Alex Bennée
Josh Kunz writes: > Sorry for the late reply, response inline. Also I noticed a couple > mails ago I seemed to have removed the devel list and maintainers. > I've re-added them to the CC line. > > On Wed, Jun 24, 2020 at 3:17 AM Alex Bennée wrote: >> >> >> Josh Kunz writes: >> >> > On Tue,

[PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-16 Thread Ahmed Karaman
Python script that prints executed helpers of a QEMU invocation. Syntax: list_helpers.py [-h] -- \ [] \ [] [-h] - Print the script arguments help message. Example of usage: list_helpers.py -- qemu-mips coulomb_double-mips -n10 Example output: Total number of

[PATCH v2 0/2] Add list_fn_callees.py and list_helpers.py scripts

2020-07-16 Thread Ahmed Karaman
Hi, This series adds the two new scripts introduced in report 4 of the "TCG Continuous Benchmarking" GSoC project. "list_fn_callees.py" is used for printing the callees of a given list of QEMU functions. "list_helpers.py" is used for printing the executed helpers of a QEMU invocation. To learn

[PATCH v2 1/2] scripts/performance: Add list_fn_callees.py script

2020-07-16 Thread Ahmed Karaman
Python script that prints the callees of a given list of QEMU functions. Syntax: list_fn_callees.py [-h] -f FUNCTION [FUNCTION ...] -- \ [] \ [] [-h] - Print the script arguments help message. -f FUNCTION [FUNCTION ...] - List of function names Example of usage:

Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 12:14 PM, Sergio Lopez wrote: > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed > the implementation of the "norace" option, so remove it from the > cmdline help too. > > Signed-off-by: Sergio Lopez > --- > tools/virtiofsd/helper.c | 2 -- > 1 file changed, 2

Re: [PATCH v10 10/10] qcow2_format.py: support dumping metadata in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Implementation of dumping QCOW2 image metadata. The sample output: { "Header_extensions": [ { "name": "Feature table", "magic": 1745090647, "length": 192, "data_str": "" },

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 02:53:07 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > > Some recent error handling cleanups unveiled issues with our support of > > PCI bridges: > > > > 1) QEMU aborts when using non-standard PCI bridge types, > >

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Li Qiang
Markus Armbruster 于2020年7月16日周四 下午5:52写道: > > Li Qiang writes: > > > Markus Armbruster 于2020年7月16日周四 下午1:59写道: > >> > >> Li Qiang writes: > >> > >> > Properly free each test response to avoid memory leak and separate > >> > qtest_qmp() calls with spare lines, in a consistent manner. > >> > >

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 14:45:40 +1000 David Gibson wrote: > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > > Some recent error handling cleanups unveiled issues with our support of > > PCI bridges: > > > > 1) QEMU aborts when using non-standard PCI bridge types, > >unveiled by

Re: [PATCH] gitlab-ci.yml: Add fuzzer tests

2020-07-16 Thread Thomas Huth
On 16/07/2020 12.09, Thomas Huth wrote: > So far we neither compile-tested nor run any of the new fuzzers in our CI, > which led to some build failures of the fuzzer code in the past weeks. > To avoid this problem, add a job to compile the fuzzer code and run some > loops (which likely don't find

[PATCH] gitlab-ci.yml: Add fuzzer tests

2020-07-16 Thread Thomas Huth
So far we neither compile-tested nor run any of the new fuzzers in our CI, which led to some build failures of the fuzzer code in the past weeks. To avoid this problem, add a job to compile the fuzzer code and run some loops (which likely don't find any new bugs via fuzzing, but at least we know

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:45:50AM +0200, Christian Schoenebeck wrote: > On Donnerstag, 16. Juli 2020 11:21:55 CEST P J P wrote: > > +-- On Thu, 16 Jul 2020, Daniel P. Berrangé wrote --+ > > > > | > Failing to start (with a message that explains why) if one of the > > | > command > > | > line

Re: [PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, make a light copy of the initial __dict__ and extend the copy by adding lists we have to print in the JSON output. Signed-off-by: Andrey Shinkevich ---

Re: unable to boot windows with 256 cpus

2020-07-16 Thread Igor Mammedov
On Wed, 15 Jul 2020 14:28:19 -0400 Peter Xu wrote: > On Wed, Jul 15, 2020 at 07:45:13PM +0200, Igor Mammedov wrote: > > While testing ACPI cpu hotplug changes I stumbled on BSOD in case > > QEMU is configured with 256 CPUs, Windows Server 2012R2x64 fails to boot > > with bugcheck 5C > > > > >

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich ---

[PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-16 Thread Sergio Lopez
Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed the implementation of the "norace" option, so remove it from the cmdline help too. Signed-off-by: Sergio Lopez --- tools/virtiofsd/helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/virtiofsd/helper.c

Re: [PATCH v1 1/2] semihosting: defer connect_chardevs a little more to use serialx

2020-07-16 Thread Alex Bennée
Fred Konrad writes: > Le 6/26/20 à 12:06 PM, Fred Konrad a écrit : >> >> >> Le 6/16/20 à 4:52 PM, Alex Bennée a écrit : >>> >>> kon...@adacore.com writes: >>> From: KONRAD Frederic With that we can just use chardev=serial0. >>> >>> I don't quite follow what this means. >>>

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 03:14:51PM +0530, P J P wrote: > +-- On Thu, 16 Jul 2020, Dr. David Alan Gilbert wrote --+ > | > + C: CVE/Security/Trust Quotient > | > +H:High - Feature (or code) is meant to be safe and used by untrusted > | > + guests. So any potential security issue must

[RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-16 Thread Luc Michel
When single-stepping with a debugger attached to QEMU, and when an exception is raised, the debugger misses the first instruction after the exception: $ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S $ aarch64-linux-gnu-gdb GNU gdb (GDB) 9.2 [...] (gdb) tar rem :1234 Remote

Re: [PATCH 01/18] migration/vmstate: Document vmstate_dummy

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 11:52 AM, Daniel P. Berrangé wrote: > On Fri, Jul 03, 2020 at 10:18:54PM +0200, Philippe Mathieu-Daudé wrote: >> vmstate_dummy is special and restricted to linux-user. See commit >> c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY"). >> >> Signed-off-by: Philippe

Re: [PULL 2/2] usb: fix storage regression

2020-07-16 Thread BALATON Zoltan
On Thu, 16 Jul 2020, Gerd Hoffmann wrote: Fix the contition to figure whenever we need to wait for more data or Typo: contition -> condition Regards, BALATON Zoltan not. Simply check the mode, if we are not in DATAIN state any more we are done already and don't need to go ASYNC. Fixes:

Re: [PATCH 01/18] migration/vmstate: Document vmstate_dummy

2020-07-16 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 10:18:54PM +0200, Philippe Mathieu-Daudé wrote: > vmstate_dummy is special and restricted to linux-user. See commit > c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY"). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/migration/vmstate.h | 2 +- > 1

Re: [PATCH] hw/riscv: sifive_e: Correct debug block size

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1594891856-15474-1-git-send-email-bmeng...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Markus Armbruster
Li Qiang writes: > Markus Armbruster 于2020年7月16日周四 下午1:59写道: >> >> Li Qiang writes: >> >> > Properly free each test response to avoid memory leak and separate >> > qtest_qmp() calls with spare lines, in a consistent manner. >> > >> > Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add >> >

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 11:21:55 CEST P J P wrote: > +-- On Thu, 16 Jul 2020, Daniel P. Berrangé wrote --+ > > | > Failing to start (with a message that explains why) if one of the > | > command > | > line options is not covered by a specified security policy is not > | > unreasonable

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread P J P
+-- On Thu, 16 Jul 2020, Dr. David Alan Gilbert wrote --+ | > + C: CVE/Security/Trust Quotient | > + H:High - Feature (or code) is meant to be safe and used by untrusted | > + guests. So any potential security issue must be processed with | > + due care and be

<    1   2   3   >