Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 10:39 AM Frank Chang wrote: > > On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis > wrote: >> >> On Tue, Aug 25, 2020 at 1:29 AM Frank Chang wrote: >> > >> > On Mon, Aug 17, 2020 at 4:50 PM wrote: >> >> >> >> From: Frank Chang >> >> >> >> This patchset implements the

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread Rohit Shinde
Hey John, I came across QEMU in 2015 when I was looking to participate in GSOC. I did GSoC through another org. I kept following qemu because I was interested in virtualization, systems level coding and device emulation. Currently, most of my professional dev work is done in Java and Python

Re: [PATCH] hw/arm/sbsa-ref: add "reg" property to DT cpu nodes

2020-08-26 Thread Graeme Gregory
On Tue, Aug 25, 2020 at 05:52:17PM +0100, Leif Lindholm wrote: > The sbsa-ref platform uses a minimal device tree to pass amount of memory > as well as number of cpus to the firmware. However, when dumping that > minimal dtb (with -M sbsa-virt,dumpdtb=), the resulting blob > generates a warning

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Frank Chang
On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis wrote: > On Tue, Aug 25, 2020 at 1:29 AM Frank Chang > wrote: > > > > On Mon, Aug 17, 2020 at 4:50 PM wrote: > >> > >> From: Frank Chang > >> > >> This patchset implements the vector extension v1.0 for RISC-V on QEMU. > >> > >> This patchset

RE: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Wednesday, August 26, 2020 8:31 AM > To: Daniel P. Berrangé > Cc: Moger, Babu ; pbonz...@redhat.com; > r...@twiddle.net; ehabk...@redhat.com; qemu-devel@nongnu.org; > m...@redhat.com; Michal Privoznik > Subject: Re: [PATCH v5 0/8]

Re: [PATCH v5 1/8] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-26 Thread Babu Moger
On 8/26/20 4:57 AM, Igor Mammedov wrote: > On Fri, 21 Aug 2020 17:12:25 -0500 > Babu Moger wrote: > >> Remove node_id, nr_nodes and nodes_per_pkg from topology. Use >> die_id, nr_dies and dies_per_pkg which is already available. >> Removes the confusion over two variables. >> >> With node_id

Re: [PATCH v5 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Add trace_calls to make it easier to debug > > Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert > --- > migration/dirtyrate.c | 7 +++ > migration/trace-events | 8 > 2 files changed, 15 insertions(+) > > diff --git

Re: [PATCH 4/4] tls-cipher-suites: Correct instance_size

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 01:10:05PM -0400, Eduardo Habkost wrote: > We do have a QCryptoTLSCipherSuites struct. It must be used when > setting instance_size of the QOM type. Luckily this never caused > problems because the QCryptoTLSCipherSuites struct has only a > parent_obj field and nothing

[PATCH 2/4] hda-audio: Set instance_size at base class

2020-08-26 Thread Eduardo Habkost
Setting instance_size correctly at the base class will help us avoid mistakes when declaring new subclasses. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- hw/audio/hda-codec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 0/4] QOM instance_size cleanups and fixes

2020-08-26 Thread Eduardo Habkost
Additional batch of fixes to code setting instance_size on QOM types. Eduardo Habkost (4): tosa-ssp: No need to override instance_size hda-audio: Set instance_size at base class slavio_misc: Correct instance_size tls-cipher-suites: Correct instance_size crypto/tls-cipher-suites.c | 2 +-

[PATCH 4/4] tls-cipher-suites: Correct instance_size

2020-08-26 Thread Eduardo Habkost
We do have a QCryptoTLSCipherSuites struct. It must be used when setting instance_size of the QOM type. Luckily this never caused problems because the QCryptoTLSCipherSuites struct has only a parent_obj field and nothing else. Signed-off-by: Eduardo Habkost --- Cc: "Daniel P. Berrangé" Cc:

[PATCH 3/4] slavio_misc: Correct instance_size

2020-08-26 Thread Eduardo Habkost
TYPE_APC was using the wrong struct for instance_size. Luckily this never caused any problems because MiscState is larger than APCState. Signed-off-by: Eduardo Habkost --- Cc: Mark Cave-Ayland Cc: qemu-devel@nongnu.org --- hw/misc/slavio_misc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/4] tosa-ssp: No need to override instance_size

2020-08-26 Thread Eduardo Habkost
TYPE_SSI_SLAVE already sets instance_size=sizeof(SSISlave), there's no need to override it. Signed-off-by: Eduardo Habkost --- Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/tosa.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-26 Thread Roman Bolshakov
On Wed, Aug 26, 2020 at 07:18:15AM -0400, Eduardo Habkost wrote: > On Wed, Aug 26, 2020 at 01:22:38PM +0300, Roman Bolshakov wrote: > > On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > > > git tree for this series: > > >

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Alistair Francis
On Tue, Aug 25, 2020 at 1:29 AM Frank Chang wrote: > > On Mon, Aug 17, 2020 at 4:50 PM wrote: >> >> From: Frank Chang >> >> This patchset implements the vector extension v1.0 for RISC-V on QEMU. >> >> This patchset is sent as RFC because RVV v1.0 is still in draft state. >> v2 patchset was sent

Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE > which is set as 128M. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 10 ++ > 2 files

Re: [RFC v6 12/13] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 10:42 PM Eugenio Pérez wrote: > This improves performance in case of netperf with vhost-net: > * TCP_STREAM: From 9049.59Mbit/s to 9049.59Mbit/s (13%) > What's improvement ? they are the same > * TCP_RR: From 8464.73 trans/s to 8932.70 trans/s (5.5%) > * UDP_RR:

Re: [PATCH v3 0/8] meson: mingw installation fixes & nsis conversion

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 5:47 PM Paolo Bonzini wrote: > We should document the difference in the 5.2 changelog then (it's okay to > introduce it since the configure option is named differently). > > Not directly related, but I can't help thinking that we would be better off maintaining the

Re: [PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Compare page hash results for recorded sampled page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang So I think this is OK, with the minor clean up suggestions of David E. > --- > migration/dirtyrate.c | 64 >

Re: [PATCH v2 1/2] hw/isa/superio: Set abstract TYPE_ISA_SUPERIO instance size

2020-08-26 Thread Eduardo Habkost
On Sat, Aug 22, 2020 at 04:28:15PM +0200, Philippe Mathieu-Daudé wrote: > Instead of setting the instance size on each implementations, > set it on the abstract parent, so we are sure no implementation > will forget to set it. > > Reported-by: Eduardo Habkost > Signed-off-by: Philippe

Re: [PATCH 3/3] spapr: Correct type for SPAPR_DRC_PCI

2020-08-26 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 09:16:27PM +1000, David Gibson wrote: > TYPE_SPAPR_DRC_PCI inherits from TYPE_SPAPR_DRC_PHYSICAL, so its checker > macro should use the corresponding instance type. We got away with it > because we never actually used that checker macro. > > Signed-off-by: David Gibson >

Re: [PATCH 02/77] tests/tcg: Do not require FE_TOWARDZERO

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:35PM -0700, Richard Henderson wrote: > This is optional in ISO C, and not all cpus provide it. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias > --- > tests/tcg/multiarch/float_convs.c | 2 ++ >

Re: [PATCH 03/77] tests/tcg: Do not require FE_* exception bits

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:36PM -0700, Richard Henderson wrote: > Define anything that is missing as 0, so that flags & FE_FOO > is false for any missing FOO. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias > --- >

Re: [PATCH 01/77] tests/tcg: Add microblaze to arches filter

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:34PM -0700, Richard Henderson wrote: > Not attempting to use a single cross-compiler for both > big-endian and little-endian at this time. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias > --- > tests/tcg/configure.sh | 2

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 11:56 PM Paolo Bonzini wrote: > Yes that would be great. We are tracking all CI "holes" that we didn't > catch before committing the Meson transition, and MSYS is certainly > one of them. > > You can send a patch and it will be reviewed and included. > > Thanks, > After

Re: [PULL 00/18] Usb 20200826 patches

2020-08-26 Thread Peter Maydell
available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20200826-pull-request > > for you to fetch changes up to 0cb60cbaf4831d859134eea39ae99ae23db79d9d: > > usb: fix setup_len init (CVE-2020-14364) (2020-08-26 14:42:00 +0200) > > -

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
Yes that would be great. We are tracking all CI "holes" that we didn't catch before committing the Meson transition, and MSYS is certainly one of them. You can send a patch and it will be reviewed and included. Thanks, Paolo On Wed, Aug 26, 2020 at 5:48 PM 罗勇刚(Yonggang Luo) wrote: > > How

Re: [PATCH v3 72/74] [automated] Remove redundant instance_size/class_size fields

2020-08-26 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 03:21:08PM -0400, Eduardo Habkost wrote: > This will remove instance_size/class_size fields from TypeInfo > variables when the value is exactly the same as the one in the > parent class. > > Generated by: > > $ ./scripts/codeconverter/converter.py -i \ >

Re: [RFC v6 00/13] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-26 Thread Peter Xu
On Wed, Aug 26, 2020 at 05:00:30PM +0200, Eugenio Perez Martin wrote: > Hi! > > Sending v6 to see if that is on the same page as what you meant. > Making each setting of "type" explicitly IOMMU_IOTLB_NONE if not used > in notifications. This is done in different commits in case this helps >

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

2020-08-26 Thread Markus Armbruster
Sorry for taking so long to reply. Daniel P. Berrangé writes: > A followup to: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html > > When QMP was first introduced some 10+ years ago now, the snapshot > related commands (savevm/loadvm/delvm) were not converted. This

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread John Snow
On 8/26/20 11:00 AM, Rohit Shinde wrote: Hey Thomas, I didn't really have any specific questions. I wanted to know if there was any part of qemu that I could contribute to. Qemu is overwhelmingly vast and without some pointers, I felt very lost. Yeah, it can be hard to get started. What

Re: [RFC v6 03/13] hw/alpha/typhoon: Mark all IOMMUTLBEntry as IOMMU_IOTLB_NONE type

2020-08-26 Thread Peter Xu
On Wed, Aug 26, 2020 at 04:36:41PM +0200, Eugenio Pérez wrote: > Signed-off-by: Eugenio Pérez > --- > hw/alpha/typhoon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c > index 29d44dfb06..b1e6c4e929 100644 > --- a/hw/alpha/typhoon.c > +++

QEMU | Pipeline #182269677 has failed for master | 25f6dc28

2020-08-26 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 25f6dc28 ( https://gitlab.com/qemu-project/qemu/-/commit/25f6dc28a3a8dd231c2c092a0e65bd796353c769 ) Commit Message: Merge

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Yonggang Luo
How about enabling github actions to enable MSYS2 builds in CI. So we won't break msys2 silently.

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 11:41 PM Paolo Bonzini wrote: > On Wed, Aug 26, 2020 at 5:39 PM 罗勇刚(Yonggang Luo) > wrote: > >> Ok, that's useful. But can you just send the whole file (it's huge but > >> you can gzip it or something similar)? > >> > >> Paolo > > > > I am OK with that, but where should

Re: [RFC v6 02/13] memory: Add IOMMUTLBNotificationType to IOMMUTLBEntry

2020-08-26 Thread Peter Xu
On Wed, Aug 26, 2020 at 04:36:40PM +0200, Eugenio Pérez wrote: > This way we can tell between MAPs and UNMAP, and potentially avoid to > send them to a notifier that does not require them. > > Signed-off-by: Eugenio Pérez > --- > include/exec/memory.h | 17 - > 1 file changed,

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
On Wed, Aug 26, 2020 at 5:39 PM 罗勇刚(Yonggang Luo) wrote: >> Ok, that's useful. But can you just send the whole file (it's huge but >> you can gzip it or something similar)? >> >> Paolo > > I am OK with that, but where should I post Just pbonz...@redhat.com. Regarding the version.rc_version.o

[PATCH v6] meson: Convert undefsym.sh to undefsym.py

2020-08-26 Thread luoyonggang
From: Yonggang Luo undefsym.sh are not msys2 compatible, convert it to python script Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/undefsym.py | 57 + scripts/undefsym.sh | 20 3 files changed, 58

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread John Snow
On 8/24/20 10:26 PM, Rohit Shinde wrote: Hey John, Hi Rohit! I sent this email a couple of weeks ago to the qemu mailing list since I didn't really know who to approach. Sorry, I didn't see a mail. The volume is quite high and I missed it. For Python issues, the usual suspects are:

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 11:37 PM Paolo Bonzini wrote: > On Wed, Aug 26, 2020 at 5:31 PM 罗勇刚(Yonggang Luo) > wrote: > > > > I can tell you build.ninja can contains $: symbol, that's the escape for > Ninja, > > when ninjatool parse it, it will convert $: -> :, so that's not a > problem. > > This

Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 11:36 PM Paolo Bonzini wrote: > On Wed, Aug 26, 2020 at 5:33 PM 罗勇刚(Yonggang Luo) > wrote: > > > > > > On Wed, Aug 26, 2020 at 11:24 PM Paolo Bonzini > wrote: > >> I'm a bit wary of this patch, the effects are quite wide-ranging. If > >> we move all the detection of

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
On Wed, Aug 26, 2020 at 5:31 PM 罗勇刚(Yonggang Luo) wrote: > > I can tell you build.ninja can contains $: symbol, that's the escape for > Ninja, > when ninjatool parse it, it will convert $: -> :, so that's not a problem. > This is part of the build.ninja on my computer Ok, that's useful. But can

Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread Paolo Bonzini
On Wed, Aug 26, 2020 at 5:33 PM 罗勇刚(Yonggang Luo) wrote: > > > On Wed, Aug 26, 2020 at 11:24 PM Paolo Bonzini wrote: >> I'm a bit wary of this patch, the effects are quite wide-ranging. If >> we move all the detection of dependencies to meson, it will take a >> while but we should get a similar

Re: meson: problems building under msys2/mingw-w64 native

2020-08-26 Thread Paolo Bonzini
On Wed, Aug 26, 2020 at 12:15 AM Mark Cave-Ayland wrote: > ... > -rw-r--r-- 1 Mark None39424 Aug 25 20:43 vgabios-stdvga.bin > -rw-r--r-- 1 Mark None39424 Aug 25 20:43 vgabios-virtio.bin > -rw-r--r-- 1 Mark None39424 Aug 25 20:43 vgabios-vmware.bin > > > I would expect the majority of

Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 11:24 PM Paolo Bonzini wrote: > I'm a bit wary of this patch, the effects are quite wide-ranging. If > we move all the detection of dependencies to meson, it will take a > while but we should get a similar effect. > Only on MINGW the $PWD sematic are changed, so I don't

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Yonggang Luo
I can tell you build.ninja can contains $: symbol, that's the escape for Ninja, when ninjatool parse it, it will convert $: -> :, so that's not a problem. This is part of the build.ninja on my computer ``` build version.rc_version.o: CUSTOM_COMMAND_DEP ../qemu.org/version.rc |

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
On Wed, Aug 26, 2020 at 5:12 PM wrote: > > From: Yonggang Luo > > SIMPLE_PATH_RE should match the full path token. > Or the $ and : contained in path would not matched if the path are start with > C:/ and E:/ I don't understand this, SIMPLE_PATH_RE is used with re.match which only matches at

Re: [PATCH 00/77] target/microblaze improvements

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > Wow, thanks for working on this Richard! I'll run some tests on it and go through the patches. Thanks, Edgar > I started off thinking conversion to decodetree would be quick, > after

Re: [PATCH v5 6/6] meson: Convert undefsym.sh to undefsym.py

2020-08-26 Thread Yonggang Luo
Gotcha, I am confusing about submitting a patch, This is my script to submit patch, but didn't got the things work. https://wiki.qemu.org/Contribute/SubmitAPatch#Base_patches_against_current_git_master Are very long, but I still didn't got the way how to submit patches properly Windows bat

Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread Paolo Bonzini
I'm a bit wary of this patch, the effects are quite wide-ranging. If we move all the detection of dependencies to meson, it will take a while but we should get a similar effect. However, I'm testing and queuing patches 1 to 3. Paolo On Wed, Aug 26, 2020 at 5:13 PM wrote: > > From: Yonggang Luo

Re: [RFC PATCH v3 24/34] Hexagon (target/hexagon) opcode data structures

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +extern const char *opcode_names[]; > + > +extern const char *opcode_reginfo[]; > +extern const char *opcode_rregs[]; > +extern const char *opcode_wregs[]; const char * const > +extern opcode_encoding_t opcode_encodings[XX_LAST_OPCODE]; const. >

Re: [PATCH v5 6/6] meson: Convert undefsym.sh to undefsym.py

2020-08-26 Thread Paolo Bonzini
Careful, the original script: -comm -12 \ - <( $NM -P -g $staticlib | awk '$2!="U"{print "-Wl,-u," $1}' | sort -u) \ - <( $NM -P -g "$@" | awk '$2=="U"{print "-Wl,-u," $1}' | sort -u) looks for lines that *are* U in the modules. So using filter_lines_set is correct for static libraries but

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2020 at 04:03:40PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 26, 2020 at 04:02:58PM +0200, Igor Mammedov wrote: > > On Wed, 26 Aug 2020 14:36:38 +0100 > > Daniel P. Berrangé wrote: > > > > > On Wed, Aug 26, 2020 at 03:30:34PM +0200, Igor Mammedov wrote: > > > > On Wed, 26

Re: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > The macro definitions specify instruction attributes that are applied > to each instruction that references the macro. The generator will > recursively apply attributes to each instruction that used the macro. > > Signed-off-by: Taylor Simpson > --- >

Re: [Fwd] Issue 25164 in oss-fuzz: qemu: Fuzzing build failure

2020-08-26 Thread Paolo Bonzini
On Wed, Aug 26, 2020 at 3:56 PM Alexander Bulekov wrote: > > On 200825 0958, Paolo Bonzini wrote: > > Il lun 24 ago 2020, 00:58 Alexander Bulekov ha scritto: > > > > > Hi Paolo, > > > Our oss-fuzz builds started failing, after the meson merge. I think I > > > tracked down the issues: > > > 1.)

[PATCH v5 5/6] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2

2020-08-26 Thread luoyonggang
From: Yonggang Luo use ninja instead ${build_path}/ninjatool Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b9e79923d..2ad0c58492 100755 --- a/configure +++ b/configure @@ -8222,7 +8222,7 @@ fi mv

[PATCH v5 6/6] meson: Convert undefsym.sh to undefsym.py

2020-08-26 Thread luoyonggang
From: Yonggang Luo undefsym.sh are not msys2 compatible, convert it to python script Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/undefsym.py | 56 + scripts/undefsym.sh | 20 3 files changed, 57

[PATCH v5 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread luoyonggang
From: Yonggang Luo On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be

[PATCH v5 3/6] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread luoyonggang
From: Yonggang Luo Fixes this for msys2/mingw64 by remove the include_type for sdl2 discovery in meson Signed-off-by: Yonggang Luo --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index f0fe5f8799..1644bbd83c 100644 ---

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Laszlo Ersek
On 08/26/20 13:55, Igor Mammedov wrote: > On Wed, 26 Aug 2020 11:24:14 +0200 > Laszlo Ersek wrote: >> (2a) Change the firmware so that it sends a directed SMI as well to >>each CPU, just before sending an INIT-SIPI-SIPI. This should be >>idempotent -- if the broadcast SMI *has*

[PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread luoyonggang
From: Yonggang Luo SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ Signed-off-by: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 2/6] meson: fixes relpath may fail on win32.

2020-08-26 Thread luoyonggang
From: Yonggang Luo On win32, os.path.relpath would raise exception when do the following relpath: C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. So we try catch it for stopping it from raise exception on msys2 Signed-off-by: Yonggang Luo --- scripts/mtest2make.py | 11

Re: [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +extern size16s_t cast8s_to_16s(size8s_t a); > +extern size8s_t cast16s_to_8s(size16s_t a); > +extern size16s_t add128(size16s_t a, size16s_t b); > +extern size16s_t sub128(size16s_t a, size16s_t b); > +extern size16s_t shiftr128(size16s_t a, size4u_t

[PULL 15/18] hw/usb: Add U2F device check to passthru mode

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patchs adds a check to verify that the device passed through the hidraw property is a U2F device. The check is done by ensuring that the first values of the report descriptor (USAGE PAGE and USAGE) correspond to those of a U2F device. Signed-off-by: César Belley

Re: [RFC PATCH v3 15/34] Hexagon (target/hexagon) instruction printing

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +extern void snprint_a_pkt(char *buf, int n, packet_t *pkt); Is there a good reason you're using a fixed size buffer and not returning a GString? r~

Re: [RFC PATCH v3 14/34] Hexagon (target/hexagon) instruction/packet decode

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +#define DECODE_NEW_TABLE(TAG, SIZE, WHATNOT) \ > +static struct _dectree_table_struct dectree_table_##TAG; All of these little structures should be const. > +typedef struct { > +struct _dectree_table_struct *table_link; > +struct

[PULL 07/18] hw/usb: Add U2F key base class

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patch adds the specification for the U2F key base class. Used to group the common characteristics, this device class will be inherited by its two variants, corresponding to the two modes: passthrough and emulated This prepares the U2F devices hierarchy which is as

[PULL 10/18] hw/usb: Add U2F key emulated mode

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key emulated mode. The emulated mode consists of completely emulating the behavior of a U2F device through software part. Libu2f-emu is used for that. The emulated mode is associated with a device inheriting from u2f-key base. To work, an emulated

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 04:02:58PM +0200, Igor Mammedov wrote: > On Wed, 26 Aug 2020 14:36:38 +0100 > Daniel P. Berrangé wrote: > > > On Wed, Aug 26, 2020 at 03:30:34PM +0200, Igor Mammedov wrote: > > > On Wed, 26 Aug 2020 13:50:59 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Wed,

[PULL 17/18] usb-host: workaround libusb bug

2020-08-26 Thread Gerd Hoffmann
libusb_get_device_speed() does not work for libusb_wrap_sys_device() devices in v1.0.23. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1871090 Signed-off-by: Gerd Hoffmann Message-id: 20200824110057.32089-1-kra...@redhat.com --- hw/usb/host-libusb.c | 37

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread Rohit Shinde
Hey Thomas, I didn't really have any specific questions. I wanted to know if there was any part of qemu that I could contribute to. Qemu is overwhelmingly vast and without some pointers, I felt very lost. On Tue, Aug 25, 2020 at 1:51 AM Thomas Huth wrote: > On 25/08/2020 04.26, Rohit Shinde

[PULL 13/18] docs/qdev-device-use.txt: Add USB U2F key to the QDEV devices examples

2020-08-26 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200826114209.28821-10-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/qdev-device-use.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index

Re: [RFC v6 00/13] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-26 Thread Eugenio Perez Martin
Hi! Sending v6 to see if that is on the same page as what you meant. Making each setting of "type" explicitly IOMMU_IOTLB_NONE if not used in notifications. This is done in different commits in case this helps review of different architectures. I think that this way we have too much freedom

[PULL 11/18] meson: Add U2F key to meson

2020-08-26 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200826114209.28821-8-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- configure | 8 +++- meson_options.txt | 1 + hw/usb/Kconfig | 5 + hw/usb/meson.build | 7 +++ meson.build| 7 +++

[PULL 01/18] hw: xhci: check return value of 'usb_packet_map'

2020-08-26 Thread Gerd Hoffmann
From: Li Qiang Currently we don't check the return value of 'usb_packet_map', this will cause an UAF issue. This is LP#1891341. Following is the reproducer provided in: -->https://bugs.launchpad.net/qemu/+bug/1891341 cat << EOF | ./i386-softmmu/qemu-system-i386 -device nec-usb-xhci \ -trace

[PULL 06/18] docs: Add USB U2F key device documentation

2020-08-26 Thread Gerd Hoffmann
From: César Belley Add USB U2F key device documentation: - USB U2F key device - Building - Using u2f-emulated - Using u2f-passthru - Libu2f-emu Signed-off-by: César Belley Message-id: 20200826114209.28821-3-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/u2f.txt | 101

[PULL 12/18] docs/system: Add U2F key to the USB devices examples

2020-08-26 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200826114209.28821-9-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/system/usb.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/system/usb.rst b/docs/system/usb.rst index ddfa828d74ae..9a2f1927c451

Re: [PATCH v2] virtio-gpu: fix unmap the already mapped items

2020-08-26 Thread Li Qiang
Li Zhijian 于2020年8月21日周五 下午7:34写道: > > we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider > to unmap the 'i'th item as well when the 'i'th item is not nil > > Signed-off-by: Li Zhijian > > --- > v2: address Gerd's comments > --- > hw/display/virtio-gpu.c | 3 +++ > 1

[PULL 16/18] hw/usb: Add U2F device autoscan to passthru mode

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patch adds an autoscan to let u2f-passthru choose the first U2F device it finds. The autoscan is performed using libudev with an enumeration of all the hidraw devices present on the host. The first device which happens to be a U2F device is taken to do the passtru.

[PULL 00/18] Usb 20200826 patches

2020-08-26 Thread Gerd Hoffmann
The following changes since commit d1a2b51f868d09ca8489ee9aee9c55632ed8fb92: Merge remote-tracking branch 'remotes/berrange/tags/socket-next-pull-reques= t' into staging (2020-08-25 15:01:43 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20200826-pull

[PULL 08/18] hw/usb: Add U2F key base class implementation

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key base class implementation. The U2F key base mainly takes care of the HID interfacing with guest. On the one hand, it retrieves the guest U2FHID packets and transmits them to the variant associated according to the mode: pass-through or emulated. On

[PULL 14/18] scripts: Add u2f-setup-gen script

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patch adds the script used to generate setup directories, needed for the device u2f-emulated configuration in directory mode: python u2f-setup-gen.py $DIR qemu -usb -device u2f-emulated,dir=$DIR Signed-off-by: César Belley Message-id:

[PULL 04/18] ehci: drop pointless warn_report for guest bugs.

2020-08-26 Thread Gerd Hoffmann
We have a tracepoint at the same place which can be enabled if needed. Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236 Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200722072613.10390-1-kra...@redhat.com> --- hw/usb/hcd-ehci.c | 1 - 1 file

[PULL 18/18] usb: fix setup_len init (CVE-2020-14364)

2020-08-26 Thread Gerd Hoffmann
Store calculated setup_len in a local variable, verify it, and only write it to the struct (USBDevice->setup_len) in case it passed the sanity checks. This prevents other code (do_token_{in,out} functions specifically) from working with invalid USBDevice->setup_len values and overrunning the

[PULL 05/18] hw/usb: Regroup USB HID protocol values

2020-08-26 Thread Gerd Hoffmann
From: César Belley Group some HID values that are used pretty much everywhere when dealing with HID devices. Signed-off-by: César Belley Message-id: 20200812094135.20550-2-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- include/hw/usb/hid.h | 17 + hw/usb/dev-hid.c

[PULL 02/18] hw: ehci: destroy sglist in error path

2020-08-26 Thread Gerd Hoffmann
From: Li Qiang This may cause resource leak. Signed-off-by: Li Qiang Message-Id: <20200812161712.29361-1-liq...@163.com> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index

[PULL 09/18] hw/usb: Add U2F key passthru mode

2020-08-26 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key pass-through mode. The pass-through mode consists of passing all requests made from the guest to the physical security key connected to the host machine and vice versa. In addition, the dedicated pass-through allows to have a U2F security key

[PULL 03/18] hw: ehci: check return value of 'usb_packet_map'

2020-08-26 Thread Gerd Hoffmann
From: Li Qiang If 'usb_packet_map' fails, we should stop to process the usb request. Signed-off-by: Li Qiang Message-Id: <20200812161727.29412-1-liq...@163.com> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2020 at 11:40:28AM +0200, Philippe Mathieu-Daudé wrote: > Le mar. 25 août 2020 19:42, Alistair Francis a > écrit : > > > Reported-by: Eduardo Habkost > > Signed-off-by: Alistair Francis > > --- > > hw/core/register.c | 31 +-- > > 1 file changed,

[RFC v6 13/13] memory: Skip bad range assertion if notifier is DEVIOTLB type

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- softmmu/memory.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index 4ed63f4d0d..d2797e996a 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1915,6 +1915,7 @@ void

[RFC v6 11/13] memory: Add IOMMU_DEVIOTLB_UNMAP IOMMUTLBNotificationType

2020-08-26 Thread Eugenio Pérez
Adapt intel and vhost to use this new notification type Signed-off-by: Eugenio Pérez --- hw/i386/intel_iommu.c | 2 +- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 9 ++--- softmmu/memory.c | 5 - 4 files changed, 12 insertions(+), 6 deletions(-) diff --git

[RFC v6 12/13] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

2020-08-26 Thread Eugenio Pérez
This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 9049.59Mbit/s to 9049.59Mbit/s (13%) * TCP_RR: From 8464.73 trans/s to 8932.70 trans/s (5.5%) * UDP_RR: From 8562.08 trans/s to 9005.62/s (5.1%) * UDP_STREAM: No change observed (insignificant 0.1% improvement)

[RFC v6 08/13] virtio-iommu: Mark virtio_iommu_translate IOTLB as IOMMU_IOTLB_NONE type

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/virtio-iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 5d56865e56..16267e8096 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -619,6 +619,7 @@ static

[RFC v6 07/13] intel_iommu: Mark IOMMUTLBEntry of page notification as IOMMU_IOTLB_UNMAP type

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/i386/intel_iommu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 2ad6b9d796..ed83e496b8 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1999,6 +1999,7 @@ static void

[RFC v6 10/13] memory: Notify IOMMU IOTLB based on entry type, not permissions

2020-08-26 Thread Eugenio Pérez
This way the intention is much clearer. Signed-off-by: Eugenio Pérez --- softmmu/memory.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index 961c25b42f..3e68442ca6 100644 --- a/softmmu/memory.c +++

[RFC v6 06/13] dma/rc4030: Mark all IOMMUTLBEntry as IOMMU_IOTLB_NONE type

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/dma/rc4030.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c index 7eddc9a776..8eee12b1cb 100644 --- a/hw/dma/rc4030.c +++ b/hw/dma/rc4030.c @@ -506,6 +506,7 @@ static IOMMUTLBEntry rc4030_dma_translate(IOMMUMemoryRegion

[RFC v6 03/13] hw/alpha/typhoon: Mark all IOMMUTLBEntry as IOMMU_IOTLB_NONE type

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/alpha/typhoon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 29d44dfb06..b1e6c4e929 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -615,6 +615,7 @@ static bool make_iommu_tlbe(hwaddr taddr,

[RFC v6 09/13] intel_iommu: Set IOMMUTLBEntry type in vtd_page_walk_level

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index ed83e496b8..0b3399874f 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1251,6 +1251,7 @@ static int

[RFC v6 02/13] memory: Add IOMMUTLBNotificationType to IOMMUTLBEntry

2020-08-26 Thread Eugenio Pérez
This way we can tell between MAPs and UNMAP, and potentially avoid to send them to a notifier that does not require them. Signed-off-by: Eugenio Pérez --- include/exec/memory.h | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/include/exec/memory.h

[RFC v6 04/13] amd_iommu: Mark all IOMMUTLBEntry as IOMMU_IOTLB_NONE type

2020-08-26 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/i386/amd_iommu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 087f601666..c2607e9e91 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -946,6 +946,7 @@ static void

<    1   2   3   4   5   >