Hi Peter!
The following changes since commit c79f01c9450bcf90c08a77f13fbf67bdba59a316:
Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210218' into
staging (2021-02-18 16:33:36 +)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git tags/pull
From: Daniel P. Berrangé
Currently we attempt to skip building container images if the commits do
not involve changes to the dockerfiles or gitlab CI definitions.
Conceptually this makes sense, but there is a challenge in the real
world implementation of this in gitlab.
In the case of a CI
From: Philippe Mathieu-Daudé
When using KVM, using a specific cpu type will only work if the
host CPU really is that exact CPU type.
During testing we can simply use the 'max' CPU which will select
all the features available from the host.
This allow running this test on a Cavium CN8890
On 19.02.21 07:57, Andrey Gruzdev wrote:
On 17.02.2021 02:35, Peter Xu wrote:
Hi, Andrey,
On Sat, Feb 13, 2021 at 12:34:07PM +0300, Andrey Gruzdev wrote:
On 12.02.2021 19:11, Peter Xu wrote:
On Fri, Feb 12, 2021 at 09:52:52AM +0100, David Hildenbrand wrote:
On 12.02.21 04:06, Peter Xu
On 17.02.2021 02:35, Peter Xu wrote:
Hi, Andrey,
On Sat, Feb 13, 2021 at 12:34:07PM +0300, Andrey Gruzdev wrote:
On 12.02.2021 19:11, Peter Xu wrote:
On Fri, Feb 12, 2021 at 09:52:52AM +0100, David Hildenbrand wrote:
On 12.02.21 04:06, Peter Xu wrote:
On Thu, Feb 11, 2021 at 10:09:58PM
I'm now using qemu-system-hppa version 5.2.50, and I can put "-serial
mon: stdio" before or after "-serial telnet :: 4441, server" without a
problem.
#qemu-system-hppa --version
QEMU emulator version 5.2.50 (v5.2.0-1300-g0e32462630)
Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project
On 18/02/2021 18.40, Pierre Morel wrote:
The Measurement Block Origin inside the SCHIB is used when
Mesurement Block format 1 is in used and must be aligned
on 128bits.
128 bits = 16 bytes ...
Signed-off-by: Pierre Morel
---
target/s390x/ioinst.c | 6 ++
1 file changed, 6
Hello Alex, Stefan, all
+-- On Thu, 18 Feb 2021, Alexander Bulekov wrote --+
| Maybe the infinite loop mentioned in the commit message is actually a DMA
| recursion issue? I'm providing a reproducer for a DMA re-entracy issue
| below. With this patch applied, the reproducer triggers the
Public bug reported:
I have a jetson nano (arm64 SBC) and I want to check the native
emulation performance of Raspbian Buster. I used the info available
here:
https://github.com/dhruvvyas90/qemu-rpi-kernel/tree/master/native-
emuation
I have Xubuntut 20.04 with KVM enabled kernel running on the
On Tue, Feb 9, 2021 at 8:06 AM Bin Meng wrote:
>
> Cc'ing libSLiRP
I am not sure whether my reply arrived to libSLiRP as I did not
subscribe to that list ...
>
> Hi Peter,
>
> On Tue, Feb 9, 2021 at 12:09 AM Peter Maydell
> wrote:
> >
> > On Mon, 8 Feb 2021 at 14:53, Bin Meng wrote:
> > >
>
Alexander Bulekov 于2021年2月19日周五 上午10:15写道：
>
> On 210219 1006, Li Qiang wrote:
> > Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
> > >
> > > On 210218 1441, Peter Maydell wrote:
> > > > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > > > >
> > > > > From: Prasad J Pandit
> > > > >
> > > > > While
The following changes since commit ef450767d7d162dec67ec4674f85f9044a3d80cc:
spapr_drc.c: do not call spapr_drc_detach() in drc_isolate_logical()
(2021-02-17 11:50:21 +1100)
are available in the Git repository at:
g...@github.com:aik/qemu.git tags/qemu-slof-20210217
for you to fetch
On 210210 2022, P J P wrote:
> From: Prasad J Pandit
>
> While processing transmit (tx) descriptors in process_tx_desc()
> various descriptor fields are not checked properly. This may lead
> to infinite loop like issue. Add checks to avoid them.
>
+CC Peter Maydell
Is this a DMA
On 2021/2/18 3:47 下午, P J P wrote:
Hello Jason,
+-- On Thu, 18 Feb 2021, Jason Wang wrote --+
| On 2021/2/10 下午10:52, P J P wrote:
| > From: Prasad J Pandit
| >
| > While processing transmit (tx) descriptors in process_tx_desc()
| > various descriptor fields are not checked properly. This
On Thu, 18 Feb 2021 14:38:20 +0100
Gerd Hoffmann wrote:
> > > The explanation is simple. Unlike most devices, the ccw devices aren't
> > > portable. In particular both css.c and css.h includes "cpu.h", and
> > > virtio-ccw-gpu.c includes "qemu/osdep.h". Furthermore osdep.h contains:
> > > #ifdef
On 210219 1006, Li Qiang wrote:
> Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
> >
> > On 210218 1441, Peter Maydell wrote:
> > > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > > >
> > > > From: Prasad J Pandit
> > > >
> > > > While processing controller commands, eepro100 emulator gets
> > > >
Alexander Bulekov 于2021年2月19日周五 上午9:56写道：
>
> On 210218 1441, Peter Maydell wrote:
> > On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> > >
> > > From: Prasad J Pandit
> > >
> > > While processing controller commands, eepro100 emulator gets
> > > command unit(CU) base address OR receive unit (RU)
On 210218 1441, Peter Maydell wrote:
> On Thu, 18 Feb 2021 at 14:13, P J P wrote:
> >
> > From: Prasad J Pandit
> >
> > While processing controller commands, eepro100 emulator gets
> > command unit(CU) base address OR receive unit (RU) base address
> > OR command block (CB) address from guest.
On Thu, Feb 18, 2021 at 11:58 PM Bin Meng wrote:
>
> At present when building qemu-ppce500 the following warnings are seen:
>
> = WARNING ==
> This board does not use CONFIG_DM. CONFIG_DM will be
> compulsory starting with the v2020.01 release.
> Failure to
> On Feb 18, 2021, at 2:15 PM, Jonathan Cameron
> wrote:
>
> On Fri, 12 Feb 2021 17:26:50 -0500
> Chris Browy wrote:
>
>>> On Feb 12, 2021, at 12:23 PM, Jonathan Cameron
>>> wrote:
>>>
>>> On Tue, 9 Feb 2021 15:36:03 -0500
>>> Chris Browy wrote:
>>>
>>> Split this into two patches for
> On Feb 18, 2021, at 2:11 PM, Jonathan Cameron
> wrote:
>
> On Fri, 12 Feb 2021 16:58:21 -0500
> Chris Browy wrote:
>
>>> On Feb 12, 2021, at 11:24 AM, Jonathan Cameron
>>> wrote:
>>>
>>> On Tue, 9 Feb 2021 15:35:49 -0500
>>> Chris Browy wrote:
>>>
>>> Run ./scripts/checkpatch.pl
> -Original Message-
> From: Alex Bennée
> Sent: Tuesday, February 16, 2021 5:18 AM
> To: Philippe Mathieu-Daudé
> Cc: Brian Cain ; qemu-devel@nongnu.org; Michael
> Lambert ; Sid Manning ;
> Laurent Vivier
> Subject: [EXT] Re: hexagon sysemu - library loading path feature
>
>
> Philippe
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use explicit casts for ext32u opcodes, and allow truncation
> to happen for other users.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 122 --
> 1 file changed, 54 insertions(+), 68
On 2/17/21 9:19 PM, Richard Henderson wrote:
> In all cases restricted to 64-bit hosts, tcg_read_r is
> identical. We retain the 64-bit symbol for the single
> case of INDEX_op_qemu_st_i64.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 93
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use explicit casts for ext16u opcodes, and allow truncation
> to happen with the store for st16 opcodes, and with the call
> for bswap16 opcodes.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 28 +++-
> 1 file
On 2/19/21 12:33 AM, Richard Henderson wrote:
> On 2/18/21 3:11 PM, Philippe Mathieu-Daudé wrote:
>>> @@ -533,7 +520,7 @@ uintptr_t QEMU_DISABLE_CFI
>>> tcg_qemu_tb_exec(CPUArchState *env,
>>> tci_write_reg(regs, t0, *(uint32_t *)(t1 + t2));
>>> break;
>>>
On 2/19/21 12:23 AM, Taylor Simpson wrote:
> How do I get a wiki account for wiki.qemu.org? Going forward, I’d like
> to be able to add information about the Hexagon target.
As any user with access to the wiki can create user accounts,
I created yours and will send you your information off-list.
> The following changes since commit c79f01c9450bcf90c08a77f13fbf67bdba59a316:
>
> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210218'
> into staging (2021-02-18 16:33:36 +)
>
> are available in the Git repository at:
>
> https://gitlab.com/e
Hi Philippe,
On Fri, Feb 19, 2021 at 12:25 AM Philippe Mathieu-Daudé wrote:
>
> On 2/16/21 4:46 AM, Bin Meng wrote:
> > At the end of sdhci_send_command(), it starts a data transfer if the
> > command register indicates data is associated. But the data transfer
> > should only be initiated when
On Thu, Feb 18, 2021 at 10:58:39PM +0800, Bin Meng wrote:
> From: Bin Meng
>
> Per devicetree spec v0.3 [1] chapter 2.3.5:
>
> The #address-cells and #size-cells properties are not inherited
> from ancestors in the devicetree. They shall be explicitly defined.
> If missing, a client program
From: Richard Henderson
Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
cases that are identical between 32-bit and 64-bit hosts.
Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210217202036.1724901-5-richard.hender...@linaro.org>
[PMD: Split patch as
On 2/18/21 3:11 PM, Philippe Mathieu-Daudé wrote:
>> @@ -533,7 +520,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
>> *env,
>> tci_write_reg(regs, t0, *(uint32_t *)(t1 + t2));
>> break;
>> CASE_32_64(st8)
>> -t0 = tci_read_r8(regs,
From: Richard Henderson
Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
cases that are identical between 32-bit and 64-bit hosts.
Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210217202036.1724901-5-richard.hender...@linaro.org>
[PMD: Split patch as
Hi Richard,
This is your patch (#4/71 of v4 [*]) split in 5 parts for
easier review. Please consider using this series instead of
your original patch.
Regards,
Phil.
[*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg783450.html
Richard Henderson (5):
tcg/tci: Merge identical cases
From: Richard Henderson
Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
cases that are identical between 32-bit and 64-bit hosts.
Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210217202036.1724901-5-richard.hender...@linaro.org>
[PMD: Split patch as
From: Richard Henderson
Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
cases that are identical between 32-bit and 64-bit hosts.
Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210217202036.1724901-5-richard.hender...@linaro.org>
[PMD: Split patch as
From: Richard Henderson
Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
cases that are identical between 32-bit and 64-bit hosts.
Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210217202036.1724901-5-richard.hender...@linaro.org>
[PMD: Split patch as
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use CASE_32_64 and CASE_64 to reduce ifdefs and merge
> cases that are identical between 32-bit and 64-bit hosts.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci/tcg-target.c.inc | 204 ++-
> 1 file changed,
Replace "whitelist" in the device-crash-test script with
"rule list".
I'm using "rule list" instead of "allow list" or "pass list"
because the list is not used only for expected/allowed errors.
It also contain rules specifying which errors shouldn't be
ignored and/or should be fatal.
From: Michal Privoznik
When management applications (like Libvirt) want to check whether
memory-backend-file.pmem is supported they can list object
properties using 'qom-list-properties'. However, 'pmem' is
declared always (and thus reported always) and only at runtime
QEMU errors out if it was
From: Babu Moger
Adds the support for AMD 3rd generation processors. The model
display for the new processor will be EPYC-Milan.
Adds the following new feature bits on top of the feature bits from
the first and second generation EPYC models.
pcid: Process context identifiers support
ibrs
-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210218' into
staging (2021-02-18 16:33:36 +)
are available in the Git repository at:
https://gitlab.com/ehabkost/qemu.git tags/machine-next-pull-request
for you to fetch changes up to bf475162d70a16a6cef478272aa32be1025aa72a:
hostmem
On 2/17/21 9:19 PM, Richard Henderson wrote:
> This includes ext8s, ext8u, ext16s, ext16u.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 44
> 1 file changed, 8 insertions(+), 36 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
How do I get a wiki account for wiki.qemu.org? Going forward, I'd like to be
able to add information about the Hexagon target.
Thanks,
Taylor
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 29 +
> 1 file changed, 5 insertions(+), 24 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/17/21 9:19 PM, Richard Henderson wrote:
> This includes bswap16 and bswap32.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 22 --
> 1 file changed, 4 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use explicit casts for ext32s opcodes.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 20 ++--
> 1 file changed, 2 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/17/21 9:19 PM, Richard Henderson wrote:
> This includes add, sub, mul, and, or, xor.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 83 +--
> 1 file changed, 25 insertions(+), 58 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use explicit casts for ext16s opcodes.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 26 --
> 1 file changed, 4 insertions(+), 22 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use explicit casts for ext8s opcodes.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 25 -
> 1 file changed, 4 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Use explicit casts for ext8u opcodes, and allow truncation
> to happen with the store for st8 opcodes.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tci.c | 23 +--
> 1 file changed, 5 insertions(+), 18 deletions(-)
>
> diff
On 2/17/21 9:19 PM, Richard Henderson wrote:
> Allow other places in tcg to restart with a smaller tb.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On Wed, Feb 17, 2021 at 3:01 AM Peter Maydell
wrote:
> On Tue, 16 Feb 2021 at 14:28, Peter Maydell
> wrote:
> >
> > On Sat, 13 Feb 2021 at 00:25, Doug Evans wrote:
> > >
> > > This is a 10/100 ethernet device that has several features.
> > > Only the ones needed by the Linux driver have been
We have several scripts that help build reproducers, but no
documentation for how they should be used. Add some documentation
Signed-off-by: Alexander Bulekov
---
docs/devel/fuzzing.rst | 45 ++
1 file changed, 45 insertions(+)
diff --git
Hello,
This series adds a script that can be handy for reporting fuzzer bugs
and creating regression-tests, based on crash reproducers
Patch 1 adds a script that can help create bash and C reproducers for
crashes.
Patch 2 documents the process of building reproducers.
Patches 3-5 are examples of
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.
Doug Evans (3):
hw/net: Add npcm7xx emc model
hw/arm: Add npcm7xx emc model
tests/qtests: Add npcm7xx emc model
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.
Reviewed-by: Hao Wu
Reviewed-by: Avi Fishman
Reviewed-by: Peter Maydell
Signed-off-by: Doug Evans
---
Reviewed-by: Hao Wu
Reviewed-by: Avi Fishman
Reviewed-by: Peter Maydell
Signed-off-by: Doug Evans
---
Differences from v4:
- handle --disable-slirp
Differences from v3:
- handle big endian hosts, tested on sparc64
Differences from v2:
- remove use of C99 mixed decls/statements
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.
Reviewed-by: Hao Wu
Reviewed-by: Avi Fishman
Signed-off-by: Doug Evans
---
Differences from v4:
- no change
This patch serves as an example of a file generated with the
./scripts/oss-fuzz/output_reproducer.py script:
The source file in this patch was generated like this:
$ wget https://paste.debian.net/plain/1185141 -O /tmp/trace
$ export QEMU_ARGS="-nographic -machine accel=qtest -m 512M \
-nodefaults
This patch serves as an example of a file generated with the
./scripts/oss-fuzz/output_reproducer.py script:
The source file in this patch was generated like this:
$ wget https://paste.debian.net/plain/118513 -O /tmp/trace
$ export QEMU_ARGS="-nographic -machine accel=qtest -m 512M \
-nodefaults
Currently, bash and C crash reproducers are be built manually. This is a
problem, as we want to integrate reproducers into the tree, for
regression testing. This patch adds a script that converts a sequence of
QTest commands into a pasteable Bash reproducer, or a libqtest-based C
program. This
Some CLP response data was accidentally dropped when fixing endianness
issues with the Query PCI Function CLP response. All of these values are
sent as 0s to the guest for emulated devices, so the impact is only
observed on passthrough devices.
Fixes: a4e2fff1b104 ("s390x/pci: fix endianness
On 2/18/21 2:33 PM, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20210218201528.127099-1-ebl...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> 5/5 Checking commit 7be641fea748 (do not
Patchew URL: https://patchew.org/QEMU/20210218201538.701509-1-...@google.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210218201538.701509-1-...@google.com
Subject: [PATCH v4 0/4] Add support for ipv6 host
On 2/18/21 7:23 PM, Philippe Mathieu-Daudé wrote:
> On 2/16/21 4:46 AM, Bin Meng wrote:
>> Per "SD Host Controller Standard Specification Version 7.00"
>> chapter 2.2.1 SDMA System Address Register:
>>
>> This register can be accessed only if no transaction is executing
>> (i.e., after a
Patchew URL: https://patchew.org/QEMU/20210218201528.127099-1-ebl...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210218201528.127099-1-ebl...@redhat.com
Subject: [PATCH 0/5] Obey NBD spec regarding
On Thu, Feb 11, 2021 at 1:12 AM Daniel P. Berrangé
wrote:
> [...]
>
> I think the key useful part to keep common impl for is the handling
> of the [] brackets for IPv6 raw addrs. I'd suggest we try to pull the
> "address:port" part out into a new inet_addr_parse() helper that can be
> called
Net option "-hostfwd" now supports IPv6 addresses.
Commands hostfwd_add, hostfwd_remove now support IPv6 addresses.
Signed-off-by: Doug Evans
---
Differences from v3:
- this patch renamed from 3/3 to 4/4
- ipv6 support added to existing hostfwd option, commands
- instead of creating new ipv6
On 2/18/21 9:10 PM, Stefan Sandström wrote:
>> On 18 Feb 2021, at 20:59, Philippe Mathieu-Daudé wrote:
>>
>> Hi Stefan,
>>
>>> On 2/18/21 7:43 PM, Stefan Sandström wrote:
>>> From: Stefan Sandstrom
>>>
>>> Add and fix deallocation of temporary TCG registers in CRIS code
>>> generation.
>>
>>
This reverts commit 737d3f524481bb2ef68d3eba1caa636ff143e16a.
This is intended only for testing purposes: if you apply this without
the rest of the series, iotest 241 no longer benefits from the client
side working around server non-compliance.
---
block/nbd.c | 30
This patchset takes the original patch from Maxim,
https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html
and updates it.
Option hostfwd is extended to support ipv6 addresses.
Commands hostfwd_add, hostfwd_remove are extended as well.
The libslirp part of the patch has been committed
Signed-off-by: Doug Evans
---
Changes from v3:
- pick up latest libslirp patch to reject ipv6 addr-any for guest address
- libslirp currently only provides a stateless DHCPv6 server, which means
it can't know in advance what the guest's IP address is, and thus
cannot do the "addr-any
... in preparation for adding ipv6 host forwarding support.
New test: avocado run tests/acceptance/hostfwd.py
Signed-off-by: Doug Evans
---
Changes from v3:
- this patch renamed from 2/3 to 3/4
- call inet_parse_host_and_port from util/qemu-sockets.c
- added tests/acceptance/hostfwd.py
The NBD server code used bdrv_block_status_above() to determine where
to fragment structured read and block status replies, and similarly
used bdrv_is_allocated_above() for the qemu:allocation-depth context.
However, the protocol can only advertise the active layer's minimum
block size; if the
The NBD spec requires that responses to NBD_CMD_BLOCK_STATUS be
aligned to the server's advertised min_block alignment, if the client
agreed to abide by alignments. In general, since dirty bitmap
granularity cannot go below 512, and it is hard to provoke qcow2 to go
above an alignment of 512, this
The parsing is moved into new function inet_parse_host_and_port.
This is done in preparation for using the function in net/slirp.c.
Signed-off-by: Doug Evans
---
Changes from v3:
- this patch is new in v4
- provides new utility: inet_parse_host_and_port, updates inet_parse
to use it
We've had some known long-standing compliance bugs in our NBD server
not always honoring a minimum block size in its response to client
requests, when dealing with an image with a large block size backed by
another image with a smaller block size (for example, an encrypted
qcow2 image has a
Previous commits (such as 6e280648, 75d34eb9) have mentioned that our
NBD server still sends unaligned fragments when an active layer with
large advertised minimum block size is backed by another layer with a
smaller block size. Expand the test to actually cover these scenario,
by using two
Previous patches mentioned how the blkdebug filter driver demonstrates
a bug present in our NBD server (for example, commit b0245d64); the
bug is also present with the raw format driver when probing
occurs. Basically, if we specify a particular alignment > 1, but defer
the actual block status to
s/pull-plugin-updates-180221-1' into staging (2021-02-18
> 13:27:03 +)
>
> are available in the Git repository at:
>
> https://gitlab.com/rth7680/qemu.git tags/pull-hex-20210218
>
> for you to fetch changes up to 3e7a84eeccc3b3a9b43c6dfb52bd98ea5acebf0a:
>
>
Hi Stefan,
On 2/18/21 7:43 PM, Stefan Sandström wrote:
> From: Stefan Sandstrom
>
> Add and fix deallocation of temporary TCG registers in CRIS code
> generation.
What did you run to figure this out?
> Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
> Signed-off-by: Stefan Sandstrom
>
> On 18 Feb 2021, at 20:59, Philippe Mathieu-Daudé wrote:
>
> Hi Stefan,
>
>> On 2/18/21 7:43 PM, Stefan Sandström wrote:
>> From: Stefan Sandstrom
>>
>> Add and fix deallocation of temporary TCG registers in CRIS code
>> generation.
>
> What did you run to figure this out?
Hi Philippe,
Add python3.6 to the fedora container image: we need it to run the
linters against that explicit version to make sure we don't break our
minimum version promise.
Add pipenv so that we can fetch precise versions of pip packages we need
to guarantee test reproducability.
Signed-off-by: John Snow
Add "make venv" to create the pipenv-managed virtual environment that
contains our explicitly pinned dependencies.
Add "make check" to run the python linters [in the host execution
environment].
Add "make venv-check" which combines the above two: create/update the
venv, then run the linters in
Try using pytest to manage our various tests; even though right now
they're only invoking binaries and not really running any python-native
code.
Create tests/, and add test_lint.py which calls out to mypy, flake8,
pylint and isort to enforce the standards in this directory.
Add pytest to the
On Thu, Feb 18, 2021 at 11:35 AM Daniel P. Berrangé
wrote:
> On Wed, Feb 10, 2021 at 02:19:59PM +0800, Jason Wang wrote:
> >
> > On 2021/2/9 下午11:04, Michael S. Tsirkin wrote:
> > > On Tue, Feb 09, 2021 at 02:51:05PM +, Daniel P. Berrangé wrote:
> > > > On Tue, Feb 09, 2021 at 09:34:20AM
setuptools doesn't have a formal understanding of development requires,
but it has an optional feataures section. Fine; add a "devel" feature
and add the requirements to it.
To avoid duplication, we can modify pipenv to install qemu[devel]
instead. This enables us to run invocations like "pip
Add a shortcut that canonizes the runes needed to get both the
linting pre-requisites (the "[devel]" part), and the editable
live-install (the "-e" part) of these python libraries.
Signed-off-by: John Snow
---
python/Makefile | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff
0.730 appears to be about the oldest version that works with the
features we want, including nice human readable output (to make sure
iotest 297 passes), and type-parameterized Popen generics.
0.770, however, supports adding 'strict' to the config file, so require
at least 0.770.
Now that we are
This adds the python qemu packages themselves to the pipenv manifest.
'pipenv sync' will create a virtual environment sufficient to use the SDK.
'pipenv sync --dev' will create a virtual environment sufficient to use
and test the SDK (with pylint, mypy, isort, flake8, etc.)
The qemu packages are
Instruct flake8 to avoid certain well-known directories created by
python tooling that it ought not check.
Note that at-present, nothing actually creates a ".venv" directory; but
it is in such widespread usage as a de-facto location for a developer's
virtual environment that it should be excluded
mypy supports reading its configuration values from a central project
configuration file; do so.
Signed-off-by: John Snow
---
python/mypy.ini | 4
python/setup.cfg | 5 +
2 files changed, 5 insertions(+), 4 deletions(-)
delete mode 100644 python/mypy.ini
diff --git a/python/mypy.ini
Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
---
python/.isort.cfg | 7 ---
python/setup.cfg | 8
2 files changed, 8 insertions(+), 7 deletions(-)
delete mode 100644 python/.isort.cfg
diff --git a/python/.isort.cfg b/python/.isort.cfg
deleted file mode 100644
index
We are specifying >= pylint 2.6.x for two reasons:
1. For setup.cfg support, added in pylint 2.5.x
2. To clarify that we are using a version that has incompatibly dropped
bad-whitespace checks.
Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
---
python/Pipfile |
Delete the empty settings now that it's sharing a home with settings for
other tools.
pylint can now be run from this folder as "pylint qemu".
Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
---
python/qemu/machine/pylintrc | 58
Update the comment concerning the flake8 exception to match commit
42c0dd12, whose commit message stated:
A note on the flake8 exception: flake8 will warn on *any* bare except,
but pylint's is context-aware and will suppress the warning if you
re-raise the exception.
Signed-off-by: John Snow
Python infrastructure as it exists today is not capable reliably of
single-sourcing a package version from a parent directory. The authors
of pip are working to correct this, but as of today this is not possible.
The problem is that when using pip to build and install a python
package, it copies
pipenv is a tool used for managing virtual environments with pinned,
explicit dependencies. It is used for precisely recreating python
virtual environments.
pipenv uses two files to do this:
(1) Pipfile, which is similar in purpose and scope to what setup.py
lists. It specifies the requisite
Add setup.cfg and setup.py, necessary for installing a package via
pip. Add a ReST document (PACKAGE.rst) explaining the basics of what
this package is for and who to contact for more information. This
document will be used as the landing page for the package on PyPI.
I am not yet using a
1 - 100 of 274 matches
Mail list logo
