Re: [PATCH v2] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-04-08 Thread Thomas Lamprecht
On 08.04.21 14:49, Markus Armbruster wrote: > Kevin Wolf writes: >> Am 08.04.2021 um 11:21 hat Markus Armbruster geschrieben: >>> Should this go into 6.0? >> >> This is something that the responsible maintainer needs to decide. > > Yes, and that's me. I'm soliciting opinions. > >> If it helps y

Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-08 Thread Cornelia Huck
On Thu, 8 Apr 2021 14:39:59 +0200 Halil Pasic wrote: > On Thu, 8 Apr 2021 11:02:32 +0200 > Cornelia Huck wrote: > > > On Wed, 7 Apr 2021 19:47:11 +0200 > > Halil Pasic wrote: > > > > > So this begs the question, do we need this fixed for old releases as well? > > > > > > My answer is yes w

Re: [PATCH RFC] target/i386: Add Intel CPU model versions supporting 'xsaves'

2021-04-08 Thread Wen Pu
On 2021/4/7 23:43, Vitaly Kuznetsov wrote: > Hyper-V 2016 refuses to boot on Skylake+ CPU models because they lack > 'xsaves'/'vmx-xsaves' features and this diverges from real hardware. The > same issue emerges with AMD "EPYC" CPU model prior to version 3 which got > 'xsaves' added. EPYC-Rome/EPYC-

Re: [PATCH RFC] target/i386: Add Intel CPU model versions supporting 'xsaves'

2021-04-08 Thread Vitaly Kuznetsov
Wen Pu writes: > On 2021/4/7 23:43, Vitaly Kuznetsov wrote: >> Hyper-V 2016 refuses to boot on Skylake+ CPU models because they lack >> 'xsaves'/'vmx-xsaves' features and this diverges from real hardware. The >> same issue emerges with AMD "EPYC" CPU model prior to version 3 which got >> 'xsaves'

Re: [RFC v12 40/65] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM

2021-04-08 Thread Claudio Fontana
On 3/29/21 4:03 PM, Richard Henderson wrote: > On 3/29/21 1:02 AM, Claudio Fontana wrote: >> On 3/28/21 7:21 PM, Richard Henderson wrote: >>> On 3/26/21 1:36 PM, Claudio Fontana wrote: test is TCG-only. Signed-off-by: Claudio Fontana Cc: Philippe Mathieu-Daudé ---

Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

2021-04-08 Thread BALATON Zoltan
On Thu, 8 Apr 2021, Philippe Mathieu-Daudé wrote: This patch apparently got lost. No, it's queued for 6.1 as part of my pegasos2 series in David's tree: https://github.com/dgibson/qemu/commits/ppc-for-6.1 Regards, BALATON Zoltan On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote: TYPE_VIA_P

Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-08 Thread Cornelia Huck
On Thu, 8 Apr 2021 14:32:11 +0200 Pierre Morel wrote: > On 4/8/21 11:02 AM, Cornelia Huck wrote: > > On Wed, 7 Apr 2021 19:47:11 +0200 > > Halil Pasic wrote: > > > >> So this begs the question, do we need this fixed for old releases as well? > >> > >> My answer is yes we do. Conny what do you

Re: [PATCH 0/3] hw: Constify VMStateDescription

2021-04-08 Thread Philippe Mathieu-Daudé
On 3/15/21 10:05 AM, Keqian Zhu wrote: > Hi Philippe, > > It seems that vmstate_ecc_state and vmstate_x86_cpu can also be constified. > Found by . Correct (I only searched for the static ones). Do you mind sending a patch? > > Thanks, > Keqian > > On 2021/3/14 1:11, Philippe Mathieu-Daudé wro

Re: Commit "x86/kvm: Move context tracking where it belongs" broke guest time accounting

2021-04-08 Thread Thomas Gleixner
On Tue, Apr 06 2021 at 21:47, Sean Christopherson wrote: > On Tue, Apr 06, 2021, Michael Tokarev wrote: >> broke kvm guest cpu time accounting - after this commit, when running >> qemu-system-x86_64 -enable-kvm, the guest time (in /proc/stat and >> elsewhere) is always 0. >> >> I dunno why it happ

Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM

2021-04-08 Thread Philippe Mathieu-Daudé
This patch apparently got lost. On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote: > TYPE_VIA_PM calls apm_init() in via_pm_realize(), so > requires APM to be selected. > > Reported-by: BALATON Zoltan > Signed-off-by: Philippe Mathieu-Daudé > --- > Rebased on usb-20210315-pull-request > Based-o

Re: [PULL 00/11] rc2 fixes (check-tcg, gitlab, gdbstub)

2021-04-08 Thread Peter Maydell
On Wed, 7 Apr 2021 at 19:42, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Wed, 7 Apr 2021 at 18:26, Alex Bennée wrote: > >> > >> > >> Peter Maydell writes: > >> > >> > On Tue, 6 Apr 2021 at 16:00, Alex Bennée wrote: > >> >> > >> >> The following changes since commit > >> >> 109918d

Re: [PATCH v1 4/8] target/riscv: Add ePMP CSR access functions

2021-04-08 Thread Bin Meng
On Fri, Apr 2, 2021 at 8:50 PM Alistair Francis wrote: > > From: Hou Weiying > > Signed-off-by: Hongzheng-Li > Signed-off-by: Hou Weiying > Signed-off-by: Myriad-Dreamin > Message-Id: > > [ Changes by AF: > - Rebase on master > - Fix build errors > - Fix some style issues > ] > Signed-off

Re: [PATCH v4 00/12] target/arm mte fixes

2021-04-08 Thread Peter Maydell
On Tue, 6 Apr 2021 at 18:41, Richard Henderson wrote: > > Changes for v4: > * Fix tag count computation error in mte_checkN, which when used > by mte_check1 in patch 5, caused all sorts of KASAN failures. > * Fix PAGE_ANON / PAGE_TARGET_1 overlap. > > > r~ > > > Richard Henderson (12): >

Re: [PATCH v2] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-04-08 Thread Markus Armbruster
Kevin Wolf writes: > Am 08.04.2021 um 11:21 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 22.03.2021 um 16:40 hat Stefan Reiter geschrieben: >> >> The QMP dispatcher coroutine holds the qmp_queue_lock over a yield >> >> point, where it expects to be rescheduled from the ma

Re: QMP introspecting device props common to a bus type

2021-04-08 Thread Daniel P . Berrangé
On Thu, Apr 08, 2021 at 01:56:28PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > When introspecting properties for devices, libvirt issues a sequence of > > QMP 'device-list-properties' commands, one for each device type we > > need info for. The result of this command tell

Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-08 Thread Halil Pasic
On Thu, 8 Apr 2021 11:02:32 +0200 Cornelia Huck wrote: > On Wed, 7 Apr 2021 19:47:11 +0200 > Halil Pasic wrote: > > > So this begs the question, do we need this fixed for old releases as well? > > > > My answer is yes we do. Conny what do you think? > > What do you mean with "old releases"?

Re: [PATCH 0/2] i386: Fix interrupt based Async PF enablement

2021-04-08 Thread Paolo Bonzini
On 06/04/21 13:42, Vitaly Kuznetsov wrote: older machine types are still available (I disable it for <= 5.1 but we can consider disabling it for 5.2 too). The feature is upstream since Linux 5.8, I know that QEMU supports much older kernels but this doesn't probably mean that we can't enable new

[Bug 1915063] Re: Windows 10 wil not install using qemu-system-x86_64

2021-04-08 Thread Christian Ehrhardt 
Thanks Babu/Igor for chiming in! @Babu That exposed STIBP but not IBRS - isn't that what you tried to solve (for userspace) in qemu via a v2 for the Rome chips? => https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg01020.html I was recently pinging that, as it wasn't merged into the qemu 6

Re: [PATCH 09/24] aspeed: Add Scater-Gather support for HACE Hash

2021-04-08 Thread Joel Stanley
Hi Klaus, On Wed, 7 Apr 2021 at 17:16, Cédric Le Goater wrote: > > From: Klaus Heinrich Kiwi > > Complement the Aspeed HACE support with Scatter-Gather hash support for > sha256 and sha512. Scatter-Gather is only supported on AST2600-series. Sorry it's taken some time for me to get to this patc

Re: [RFC PATCH v2 00/11] qemu_iotests: improve debugging options

2021-04-08 Thread Markus Armbruster
Emanuele Giuseppe Esposito writes: > On 08/04/2021 10:26, Markus Armbruster wrote: >> Emanuele Giuseppe Esposito writes: >> >>> This series adds the option to attach gdbserver and valgrind >>> to the QEMU binary running in qemu_iotests. >>> It also allows to redirect QEMU binaries output of the

Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-08 Thread Pierre Morel
On 4/8/21 11:02 AM, Cornelia Huck wrote: On Wed, 7 Apr 2021 19:47:11 +0200 Halil Pasic wrote: So this begs the question, do we need this fixed for old releases as well? My answer is yes we do. Conny what do you think? What do you mean with "old releases"? The dstream rework was in 2.11,

[PATCH v2] docs: add nvme emulation documentation

2021-04-08 Thread Klaus Jensen
From: Klaus Jensen Remove the docs/specs/nvme.txt and replace it with proper documentation in docs/system/nvme.rst. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daudé --- v2: - add descriptions of the simple copy `mssrl`, `mcl` and `msrc` parameters. (philmd) docs/specs/nvme

Re: [PULL 0/6] migration + virtiofsd queue

2021-04-08 Thread Andrey Gruzdev
On 08.04.2021 13:50, Dr. David Alan Gilbert wrote: * Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: On 07.04.2021 19:50, Dr. David Alan Gilbert wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Ala

Re: QMP introspecting device props common to a bus type

2021-04-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > When introspecting properties for devices, libvirt issues a sequence of > QMP 'device-list-properties' commands, one for each device type we > need info for. The result of this command tells us about all properties > possible on that specific device, which is genera

Re: [PATCH] docs: add nvme emulation documentation

2021-04-08 Thread Klaus Jensen
On Apr 8 12:17, Philippe Mathieu-Daudé wrote: On 4/8/21 11:50 AM, Klaus Jensen wrote: From: Klaus Jensen Remove the docs/specs/nvme.txt and replace it with proper documentation in docs/system/nvme.rst. Signed-off-by: Klaus Jensen --- docs/specs/nvme.txt | 23 - docs/system/index.rst

Re: [PATCH v4 11/12] target/arm: Remove log2_esize parameter to gen_mte_checkN

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > The log2_esize parameter is not used except trivially. > Drop the parameter and the deferral to gen_mte_check1. > > This fixes a bug in that the parameters as documented > in the header file were the reverse from those in the > implementation. Which meant that trans

Re: [Qemu-devel][bug] qemu crash when migrate vm and vm's disks

2021-04-08 Thread Dr. David Alan Gilbert
* Yuchen (yu.c...@h3c.com) wrote: > When migrate vm and vm’s disks target host qemu crash due to an invalid free. > > #0 object_unref (obj=0x1000) at > /qemu-2.12/rpmbuild/BUILD/qemu-2.12/qom/object.c:920 > #1 0x560434d79e79 in memory_region_unref (mr=) > at /qemu-2.12/rpmbuild/BUILD/qe

Re: [PATCH v4 10/12] target/arm: Simplify sve mte checking

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > Now that mte_check1 and mte_checkN have been merged, we can > merge sve_cont_ldst_mte_check1 and sve_cont_ldst_mte_checkN. > > Which means that we can eliminate the function pointer into > sve_ldN_r and sve_stN_r, calling sve_cont_ldst_mte_check directly. > > Signed-

Re: [RFC PATCH v2 00/11] qemu_iotests: improve debugging options

2021-04-08 Thread Emanuele Giuseppe Esposito
On 08/04/2021 10:26, Markus Armbruster wrote: Emanuele Giuseppe Esposito writes: This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file.

Re: [PATCH v4 09/12] target/arm: Rename mte_probe1 to mte_probe

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > For consistency with the mte_check1 + mte_checkN merge > to mte_check, rename the probe function as well. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 08/12] target/arm: Merge mte_check1, mte_checkN

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > The mte_check1 and mte_checkN functions are now identical. > Drop mte_check1 and rename mte_checkN to mte_check. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 07/12] target/arm: Replace MTEDESC ESIZE+TSIZE with SIZEM1

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > After recent changes, mte_checkN does not use ESIZE, > and mte_check1 never used TSIZE. We can combine the > two into a single field: SIZEM1. > > Choose to pass size - 1 because size == 0 is never used, > our immediate need in mte_probe_int is for the address > of t

Re: Mac OS real USB device support issue

2021-04-08 Thread Gerd Hoffmann
Hi, > > Those might be a good place to start. IOKit provides the drivers and > > also the io registry which is probably where you can get if a driver > > is bound to a device and which one is it. How to dissociate the > > driver from the device though I don't know. > https://developer.apple.com

Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c

2021-04-08 Thread Claudio Fontana
On 3/28/21 6:40 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> +#ifdef CONFIG_TCG >> +arm_rebuild_hflags(env); >> +#endif /* CONFIG_TCG */ > > No functional changes during code movement. > Really. > I cannot emphasize this enough. we are asserting "not reached" fo

Re: [PATCH-for-6.0?] hw/block/fdc: Fix 'fallback' property on sysbus floppy disk controllers

2021-04-08 Thread Kevin Wolf
Am 07.04.2021 um 15:37 hat Philippe Mathieu-Daudé geschrieben: > Setting the 'fallback' property corrupts the QOM instance state > (FDCtrlSysBus) because it accesses an incorrect offset (it uses > the offset of the FDCtrlISABus state). > > Fixes: a73275dd6fc ("fdc: Add fallback option") > Signed-o

Re: [PULL 0/6] migration + virtiofsd queue

2021-04-08 Thread Dr. David Alan Gilbert
* Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > On 07.04.2021 19:50, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > > > Th

Re: [PATCH] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-08 Thread Peter Maydell
On Wed, 7 Apr 2021 at 11:46, Stefan Hajnoczi wrote: > > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > qtest_get_arch(), which attempts to parse the target architecture from > the QTEST_QEMU_BINARY environment variable. > > Print an error instead of returning the architecture

Re: [PATCH 06/14] block/nbd: further segregation of connect-thread

2021-04-08 Thread Roman Kagan
On Wed, Apr 07, 2021 at 01:46:29PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add personal state NBDConnectThread for connect-thread and > nbd_connect_thread_start() function. Next step would be moving > connect-thread to a separate file. > > Note that we stop publishing thr->sioc during > qio_c

Re: [PULL for-6.0 v3 00/10] emulated nvme fixes for -rc3

2021-04-08 Thread Peter Maydell
On Wed, 7 Apr 2021 at 17:53, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > Gitlab CI finally got back in business :) > > Note: only cover letter sent for this v3. > > > The following changes since commit d0d3dd401b70168a353450e031727affee828527: > > Update version for v6.0.0-rc2

Re: [PATCH] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-08 Thread Laurent Vivier
On 07/04/2021 12:45, Stefan Hajnoczi wrote: > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > qtest_get_arch(), which attempts to parse the target architecture from > the QTEST_QEMU_BINARY environment variable. > > Print an error instead of returning the architecture "kvm". Th

Re: [RFC v12 17/65] target/arm: tcg: add stubs for some helpers for non-tcg builds

2021-04-08 Thread Claudio Fontana
On 3/28/21 6:22 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> +int fp_exception_el(CPUARMState *env, int cur_el) >> +{ >> +return 0; >> +} > > Oh, I'm pretty sure this should be identical with sve_exception_el, where the > fpu may or may not be enabled for a giv

Re: [RFC v12 27/65] target/arm: split a15 cpu model and 32bit class functions to cpu32.c

2021-04-08 Thread Peter Maydell
On Thu, 8 Apr 2021 at 11:23, Claudio Fontana wrote: > Mainly for this code here a question from my side: is the current code > actually already "wrong"? > > I mean, we unconditionally set the aarch64-capable cpu classes to all use > aarch64_gdb_arch_name and gdbstub64, > but what about an aarch6

Re: [PATCH v2] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-04-08 Thread Kevin Wolf
Am 08.04.2021 um 11:21 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 22.03.2021 um 16:40 hat Stefan Reiter geschrieben: > >> The QMP dispatcher coroutine holds the qmp_queue_lock over a yield > >> point, where it expects to be rescheduled from the main context. If a > >> CHR_EV

Re: [RFC v12 27/65] target/arm: split a15 cpu model and 32bit class functions to cpu32.c

2021-04-08 Thread Claudio Fontana
On 3/28/21 6:18 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> provide helper functions there to initialize 32bit models, >> and export the a15 cpu model. >> >> We still need to keep around a15 until we sort out the board configurations. >> >> cpu.c will continue to co

Re: [PATCH 1/3] vhost-vdpa: Remove redundant declaration of address_space_memory

2021-04-08 Thread Philippe Mathieu-Daudé
On 4/8/21 12:12 PM, Xie Yongji wrote: > The symbol address_space_memory are already declared in > include/exec/address-spaces.h. So let's add this header file > and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h. > > Signed-off-by: Xie Yongji > --- > hw/virtio/vhost-vdpa.c

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-08 Thread Alex Bennée
Peter Maydell writes: > On Wed, 7 Apr 2021 at 19:54, Alex Bennée wrote: >> >> >> Richard Henderson writes: >> >> > We were incorrectly assuming that only the first byte of an MTE access >> > is checked against the tags. But per the ARM, unaligned accesses are >> > pre-decomposed into single-

Re: [PATCH] docs: add nvme emulation documentation

2021-04-08 Thread Philippe Mathieu-Daudé
On 4/8/21 11:50 AM, Klaus Jensen wrote: > From: Klaus Jensen > > Remove the docs/specs/nvme.txt and replace it with proper documentation > in docs/system/nvme.rst. > > Signed-off-by: Klaus Jensen > --- > docs/specs/nvme.txt | 23 - > docs/system/index.rst | 1 + > docs/system/nvme.rst

[PATCH 3/3] vhost-vdpa-blk: Introduce vhost-vdpa-blk host device

2021-04-08 Thread Xie Yongji
This commit introduces a new vhost-vdpa block device, which will set up a vDPA device specified by a "vdpa-dev" parameter, something like: qemu-system-x86_64 \ -device vhost-vdpa-blk-pci,vdpa-dev=/dev/vhost-vdpa-0 Signed-off-by: Xie Yongji --- hw/block/Kconfig | 5 + hw/

[PATCH 2/3] vhost-blk: Add vhost-blk-common abstraction

2021-04-08 Thread Xie Yongji
This commit abstracts part of vhost-user-blk into a common parent class which is useful for the introducation of vhost-vdpa-blk. Signed-off-by: Xie Yongji --- hw/block/meson.build | 2 +- hw/block/vhost-blk-common.c | 291 + hw/block/vhost-user-

[PATCH 0/3] Introduce vhost-vdpa block device

2021-04-08 Thread Xie Yongji
Since we already have some ways to emulate vDPA block device in kernel[1] or userspace[2]. This series tries to introduce a new vhost-vdpa block device for that. To use it, we can add something like: qemu-system-x86_64 \ -device vhost-vdpa-blk-pci,vdpa-dev=/dev/vhost-vdpa-0 You can also get t

[PATCH 1/3] vhost-vdpa: Remove redundant declaration of address_space_memory

2021-04-08 Thread Xie Yongji
The symbol address_space_memory are already declared in include/exec/address-spaces.h. So let's add this header file and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h. Signed-off-by: Xie Yongji --- hw/virtio/vhost-vdpa.c | 1 + include/hw/virtio/vhost-vdpa.h | 1 - 2

DROP THIS Re: [PATCH 00/14] nbd: move reconnect-thread to separate file

2021-04-08 Thread Vladimir Sementsov-Ogievskiy
07.04.2021 13:46, Vladimir Sementsov-Ogievskiy wrote: Hi all! There are problems with nbd driver: - nbd reconnect is cancelled on drain, which is bad as Roman describes in his "[PATCH 0/7] block/nbd: decouple reconnect from drain" - nbd driver is too complicated around drained sections

Re: [PATCH-for-6.0?] hw/block/fdc: Fix 'fallback' property on sysbus floppy disk controllers

2021-04-08 Thread Philippe Mathieu-Daudé
On 4/8/21 11:38 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Setting the 'fallback' property corrupts the QOM instance state >> (FDCtrlSysBus) because it accesses an incorrect offset (it uses >> the offset of the FDCtrlISABus state). >> >> Fixes: a73275dd6fc ("fdc: Add fallb

Re: [PATCH] docs: add nvme emulation documentation

2021-04-08 Thread Peter Maydell
On Thu, 8 Apr 2021 at 10:54, Klaus Jensen wrote: > > Hi Peter, > > Are documentation updates acceptable for -rc3? Yes; they're safe changes, generally. thanks -- PMM

Re: [RFC v12 24/65] target/arm: move arm_sctlr away from tcg helpers

2021-04-08 Thread Claudio Fontana
On 3/28/21 6:12 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> this function is used for kvm too, add it to the >> cpu-common module. >> >> Signed-off-by: Claudio Fontana >> --- >> target/arm/cpu-common.c | 15 +++ >> target/arm/tcg/helper.c | 11 --

Re: [PATCH] docs: add nvme emulation documentation

2021-04-08 Thread Klaus Jensen
Hi Peter, Are documentation updates acceptable for -rc3? On Apr 8 11:50, Klaus Jensen wrote: From: Klaus Jensen Remove the docs/specs/nvme.txt and replace it with proper documentation in docs/system/nvme.rst. Signed-off-by: Klaus Jensen --- docs/specs/nvme.txt | 23 - docs/system/ind

[PATCH] docs: add nvme emulation documentation

2021-04-08 Thread Klaus Jensen
From: Klaus Jensen Remove the docs/specs/nvme.txt and replace it with proper documentation in docs/system/nvme.rst. Signed-off-by: Klaus Jensen --- docs/specs/nvme.txt | 23 - docs/system/index.rst | 1 + docs/system/nvme.rst | 212 ++ MAINTAIN

[PULL 0/6] Net patches

2021-04-08 Thread Jason Wang
The following changes since commit d0d3dd401b70168a353450e031727affee828527: Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to 21df394d9e2ffce9fa

[PATCH v5 5/6] virtio-mmio: add support for configure interrupt

2021-04-08 Thread Cindy Lu
add configure interrupt support for virtio-mmio bus. This interrupt will working while backend is vhost-vdpa Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index

[PULL 5/6] Revert "qapi: net: Add query-netdev command"

2021-04-08 Thread Jason Wang
Several issues has been reported for query-netdev series. Consider it's late in the rc, this reverts commit d32ad10a14d46dfe9304e3ed5858a11dcd5c71a0. Signed-off-by: Jason Wang --- include/net/net.h | 3 -- net/l2tpv3.c | 7 net/net.c | 30 +- net/netmap.c

[PULL 3/6] Revert "net: Move NetClientState.info_str to dynamic allocations"

2021-04-08 Thread Jason Wang
Several issues has been reported for query-netdev info series. Consider it's late in the rc, this reverts commit commit 59b5437eb732d6b103a9bc279c3482c834d1eff9. Signed-off-by: Jason Wang --- hw/net/xen_nic.c | 5 +++-- include/net/net.h | 2 +- net/l2tpv3.c | 3 ++- net/net.c |

[PATCH v5 1/6] virtio: introduce new type in interrupt process

2021-04-08 Thread Cindy Lu
To support config interrupt we need to add a new type of interrupt process. So we introduce the vector type enum virtio_vector_type { 聽 聽 聽 聽 VIRTIO_VQ_VECTOR, 聽 聽 聽 聽 VIRTIO_CONFIG_VECTOR, 聽 聽 聽 聽 VIRTIO_VECTOR_UNKNOWN, 聽 聽 }; 聽 聽 Now the bus which support configure interrupt is virtio-mmio and vr

[PULL 4/6] Revert "tests: Add tests for query-netdev command"

2021-04-08 Thread Jason Wang
Several issues has been reported for query-netdev series. Consider it's late in the rc, this reverts commit 3c3b656885473ef0d699290ba966177f17839aa5. Signed-off-by: Jason Wang --- tests/qtest/meson.build | 3 - tests/qtest/test-query-netdev.c | 120 -

[PULL 6/6] tap-win32: correctly recycle buffers

2021-04-08 Thread Jason Wang
Commit 969e50b61a28 ("net: Pad short frames to minimum size before sending from SLiRP/TAP") tries to pad frames but try to recyle the local array that is used for padding to tap thread. This patch fixes this by recyling the original buffer. Fixes: 969e50b61a28 ("net: Pad short frames to minimum si

[PATCH v5 6/6] virtio-pci: add support for configure interrupt

2021-04-08 Thread Cindy Lu
Add support for configure interrupt, use kvm_irqfd_assign and set the gsi to kernel. When the configure notifier was eventfd_signal by host kernel, this will finally inject an msix interrupt to guest Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 91

[PATCH v5 2/6] vhost: add new call back function for config interrupt

2021-04-08 Thread Cindy Lu
to support configure interrupt, we need to Add new call back function for config interrupt. now聽this call back function only used in vhost-vdpa driver Signed-off-by: Cindy Lu --- hw/virtio/trace-events| 2 ++ hw/virtio/vhost-vdpa.c| 7 +++ include/hw/virtio/vhost-back

[PULL 1/6] Revert "net: Do not fill legacy info_str for backends"

2021-04-08 Thread Jason Wang
Several issues has been reported for query-netdev info series. Consider it's late in the rc, this reverts commit f2e8319d456724c3d8514d943dc4607e2f08e88a. Signed-off-by: Jason Wang --- net/l2tpv3.c | 2 ++ net/slirp.c | 3 +++ net/socket.c | 28 net/ta

[PULL 2/6] Revert "hmp: Use QAPI NetdevInfo in hmp_info_network"

2021-04-08 Thread Jason Wang
Several issues has been reported for query-netdev info series. Consider it's late in the rc, this reverts commit a0724776c5a98a08fc946bb5a4ad16410ca64c0e. Signed-off-by: Jason Wang --- include/qapi/hmp-output-visitor.h | 30 -- net/net.c | 31 +- qapi/hmp-output

[PATCH v5 4/6] vhost-vdpa: add support for configure interrupt

2021-04-08 Thread Cindy Lu
Add support for configure interrupt. Set the notifier's fd to the kernel driver when vdpa start. also set -1 while vdpa stop. then the kernel will release the related resource Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 26 +- 1 file changed, 25 insertions(+), 1

[PATCH v5 0/6] vhost-vdpa: add support for configure interrupt

2021-04-08 Thread Cindy Lu
These code are all tested in vp-vdpa (support configure interrupt) vdpa_sim (not support configure interrupt) test in virtio-pci bus and virtio-mmio bus Change in v2: Add support fot virtio-mmio bus active the notifier wihle the backend support configure intterrput misc fixes form v1 Change in v

[PATCH v5 3/6] virtio:add support in configure interrupt

2021-04-08 Thread Cindy Lu
Add configure notifier support in virtio and related driver When peer is vhost vdpa, setup the configure interrupt function vhost_net_start and release the resource when vhost_net_stop Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 9 + hw/net/virtio-net.c| 6 ++

Re: [PATCH-for-6.0?] hw/block/fdc: Fix 'fallback' property on sysbus floppy disk controllers

2021-04-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Setting the 'fallback' property corrupts the QOM instance state > (FDCtrlSysBus) because it accesses an incorrect offset (it uses > the offset of the FDCtrlISABus state). > > Fixes: a73275dd6fc ("fdc: Add fallback option") > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts

2021-04-08 Thread Peter Maydell
On Fri, 2 Apr 2021 at 09:48, Zenghui Yu wrote: > > The GSIV values in SMMUv3 IORT node are not correct as they don't match > the SMMUIrq enumeration, which describes the IRQ<->PIN mapping used by > our emulated vSMMU. > > Fixes: a703b4f6c1ee ("hw/arm/virt-acpi-build: Add smmuv3 node in IORT table"

Re: [PATCH] hw/arm/smmuv3: Emulate CFGI_STE_RANGE for an aligned range of StreamIDs

2021-04-08 Thread Peter Maydell
On Fri, 2 Apr 2021 at 11:05, Zenghui Yu wrote: > > In emulation of the CFGI_STE_RANGE command, we now take StreamID as the > start of the invalidation range, regardless of whatever the Range is, > whilst the spec clearly states that > > - "Invalidation is performed for an *aligned* range of 2^(Ra

Re: [PULL 0/6] migration + virtiofsd queue

2021-04-08 Thread Andrey Gruzdev
On 07.04.2021 19:50, Dr. David Alan Gilbert wrote: * Peter Maydell (peter.mayd...@linaro.org) wrote: On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The following changes since commit d0d3dd401b70168a353450e031727affee828527: Update version

Re: [PATCH v1 1/8] target/riscv: Fix the PMP is locked check when using TOR

2021-04-08 Thread Bin Meng
On Fri, Apr 2, 2021 at 8:49 PM Alistair Francis wrote: > > The RISC-V spec says: > if PMP entry i is locked and pmpicfg.A is set to TOR, writes to > pmpaddri-1 are ignored. > > The current QEMU code ignores accesses to pmpaddri-1 and pmpcfgi-1 which > is incorrect. > > Update the pmp_is_lo

Re: [PATCH v2] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB

2021-04-08 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.03.2021 um 16:40 hat Stefan Reiter geschrieben: >> The QMP dispatcher coroutine holds the qmp_queue_lock over a yield >> point, where it expects to be rescheduled from the main context. If a >> CHR_EVENT_CLOSED event is received just then, it can race and block the >> m

Re: [PATCH 21/24] hw/block: m25p80: Add support for mt25qu02g

2021-04-08 Thread Francisco Iglesias
Hi Cedric, On [2021 Apr 08] Thu 10:40:18, Cédric Le Goater wrote: > On 4/8/21 10:00 AM, Francisco Iglesias wrote: > > Hello Cedric! > > > > On Wed, Apr 07, 2021 at 07:16:34PM +0200, Cédric Le Goater wrote: > >> The Micron mt25qu02g is a 3V 2Gb serial NOR flash memory supporting > >> dual I/O and

Re: [PATCH v4 06/12] test/tcg/aarch64: Add mte-5

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > Buglink: https://bugs.launchpad.net/bugs/1921948 > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 05/12] target/arm: Fix unaligned checks for mte_check1, mte_probe1

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > We were incorrectly assuming that only the first byte of an MTE access > is checked against the tags. But per the ARM, unaligned accesses are > pre-decomposed into single-byte accesses. So by the time we reach the > actual MTE check in the ARM pseudocode, all acces

Re: [PATCH 17/24] aspeed: Remove swift-bmc machine

2021-04-08 Thread Peter Maydell
On Thu, 8 Apr 2021 at 08:40, Cédric Le Goater wrote: > > On 4/7/21 8:29 PM, Peter Maydell wrote: > > On Wed, 7 Apr 2021 at 18:17, Cédric Le Goater wrote: > >> > >> The SWIFT machine never came out of the lab and we already have enough > >> AST2500 based OpenPower machines. Remove it. > >> > >> Cc

[Qemu-devel][bug] qemu crash when migrate vm and vm's disks

2021-04-08 Thread Yuchen
When migrate vm and vm’s disks target host qemu crash due to an invalid free. #0 object_unref (obj=0x1000) at /qemu-2.12/rpmbuild/BUILD/qemu-2.12/qom/object.c:920 #1 0x560434d79e79 in memory_region_unref (mr=) at /qemu-2.12/rpmbuild/BUILD/qemu-2.12/memory.c:1730 #2 flatview_destroy (vi

Re: [PATCH v4 04/12] target/arm: Split out mte_probe_int

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > Split out a helper function from mte_checkN to perform > all of the checking and address manpulation. So far, > just use this in mte_checkN itself. > > Signed-off-by: Richard Henderson > --- > target/arm/mte_helper.c | 52 +++--

Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-08 Thread Cornelia Huck
On Wed, 7 Apr 2021 19:47:11 +0200 Halil Pasic wrote: > So this begs the question, do we need this fixed for old releases as well? > > My answer is yes we do. Conny what do you think? What do you mean with "old releases"? The dstream rework was in 2.11, and I doubt that anyone is using anything

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > On 4/7/21 11:39 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> We were incorrectly assuming that only the first byte of an MTE access >>> is checked against the tags. But per the ARM, unaligned accesses are >>> pre-decomposed into single-byte accesses.

Re: [PATCH 03/24] aspeed/i2c: Fix DMA address mask

2021-04-08 Thread Cédric Le Goater
On 4/7/21 11:22 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 4/7/21 7:16 PM, Cédric Le Goater wrote: >> The RAM memory region is now used for DMAs accesses instead of the >> memory address space region. Mask off the top bits of the DMA address >> to reflect this change. >> >> Cc: Philippe

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-08 Thread Daniel P . Berrangé
On Fri, Mar 26, 2021 at 04:44:25PM +, Peter Maydell wrote: > On Fri, 26 Mar 2021 at 16:33, John Snow wrote: > > Being less terse about it: Mostly, I don't like how it enforces this > > column width even for indented structures. Generally, we claim that 72 > > columns is "comfortable to read" a

Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-08 Thread Cornelia Huck
On Wed, 7 Apr 2021 18:54:26 +0200 Halil Pasic wrote: > On Wed, 7 Apr 2021 13:41:57 +0200 > Pierre Morel wrote: > > > > Here, however, I'm not sure. Returning a negative error here is fine, > > > but handle_payload_3270_write (not changed in this patch) seems to > > > match everything to -EIO. S

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-08 Thread Peter Maydell
On Wed, 7 Apr 2021 at 19:54, Alex Bennée wrote: > > > Richard Henderson writes: > > > We were incorrectly assuming that only the first byte of an MTE access > > is checked against the tags. But per the ARM, unaligned accesses are > > pre-decomposed into single-byte accesses. So by the time we r

RE: [PATCH v5 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info()

2021-04-08 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Thursday, April 1, 2021 3:47 PM > To: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com; > pbonz...@redhat.com; lukasstra...@web.de > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject: [PATC

RE: [PATCH v5 06/10] Add the function of colo_compare_cleanup

2021-04-08 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Thursday, April 1, 2021 3:47 PM > To: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com; > pbonz...@redhat.com; lukasstra...@web.de > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject: [PATC

Re: [PATCH 21/24] hw/block: m25p80: Add support for mt25qu02g

2021-04-08 Thread Cédric Le Goater
On 4/8/21 10:00 AM, Francisco Iglesias wrote: > Hello Cedric! > > On Wed, Apr 07, 2021 at 07:16:34PM +0200, Cédric Le Goater wrote: >> The Micron mt25qu02g is a 3V 2Gb serial NOR flash memory supporting >> dual I/O and quad I/O, 4KB, 32KB, 64KB sector erase. It also supports >> 4B opcodes. >> >> C

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-08 Thread Markus Armbruster
John Snow writes: > On 3/26/21 2:26 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 3/25/21 11:21 AM, Markus Armbruster wrote: John Snow writes: > PEP8's BDFL writes: "For flowing long blocks of text with fewer > structural restrictions (docstrings or comments), t

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-08 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 26 Mar 2021 at 16:33, John Snow wrote: >> Being less terse about it: Mostly, I don't like how it enforces this >> column width even for indented structures. Generally, we claim that 72 >> columns is "comfortable to read" and I agree. >> >>

Re: [RFC PATCH v2 00/11] qemu_iotests: improve debugging options

2021-04-08 Thread Markus Armbruster
Emanuele Giuseppe Esposito writes: > This series adds the option to attach gdbserver and valgrind > to the QEMU binary running in qemu_iotests. > It also allows to redirect QEMU binaries output of the python tests > to the stdout, instead of a log file. > > Patches 1-6 introduce the -gdb option t

Re: [PATCH 21/24] hw/block: m25p80: Add support for mt25qu02g

2021-04-08 Thread Francisco Iglesias
Hello Cedric! On Wed, Apr 07, 2021 at 07:16:34PM +0200, Cédric Le Goater wrote: > The Micron mt25qu02g is a 3V 2Gb serial NOR flash memory supporting > dual I/O and quad I/O, 4KB, 32KB, 64KB sector erase. It also supports > 4B opcodes. > > Cc: Alistair Francis > Cc: Francisco Iglesias > Signed-

Re: [PATCH 0/2] block/rbd: fix memory leaks

2021-04-08 Thread Stefano Garzarella
On Wed, Apr 07, 2021 at 11:38:17AM +0200, Markus Armbruster wrote: Max Reitz writes: On 29.03.21 17:01, Stefano Garzarella wrote: This series fixes two memory leaks, found through valgrind, in the rbd driver. Stefano Garzarella (2): block/rbd: fix memory leak in qemu_rbd_connect() block

Re: [PATCH 1/2] block/rbd: fix memory leak in qemu_rbd_connect()

2021-04-08 Thread Stefano Garzarella
On Tue, Apr 06, 2021 at 10:22:30AM +0200, Markus Armbruster wrote: Stefano Garzarella writes: In qemu_rbd_connect(), 'mon_host' is allocated by qemu_rbd_mon_host() using g_strjoinv(), but it's only freed in the error path, leaking memory in the success path as reported by valgrind: 80 bytes

Re: [PATCH 17/24] aspeed: Remove swift-bmc machine

2021-04-08 Thread Cédric Le Goater
On 4/7/21 8:29 PM, Peter Maydell wrote: > On Wed, 7 Apr 2021 at 18:17, Cédric Le Goater wrote: >> >> The SWIFT machine never came out of the lab and we already have enough >> AST2500 based OpenPower machines. Remove it. >> >> Cc: Adriana Kobylak >> Signed-off-by: Cédric Le Goater > > We've had

Re: A question about the translation granule size supported by the vSMMU

2021-04-08 Thread Auger Eric
Hi Kunkun, On 4/7/21 11:26 AM, Kunkun Jiang wrote: > Hi Eric, > > On 2021/4/7 3:50, Auger Eric wrote: >> Hi Kunkun, >> >> On 3/27/21 3:24 AM, Kunkun Jiang wrote: >>> Hi all, >>> >>> Recently, I did some tests on SMMU nested mode. Here is >>> a question about the translation granule size supported

<    1   2   3   4   >