We don't seem to check for EINTR and retry. There are other places
in code where we check for EINTR. So lets add a check.
Signed-off-by: Vivek Goyal
---
tools/virtiofsd/fuse_virtio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/virtiofsd/fuse_virtio.c
There are places where we need to skip few bytes from front of the iovec
array. We have our own custom code for that. Looks like iov_discard_front()
can do same thing. So use that helper instead.
Signed-off-by: Vivek Goyal
---
tools/virtiofsd/fuse_virtio.c | 14 +++---
1 file changed, 3
On 3/24/21 3:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to support 64 bit write-zeroes requests. Now update the
> limit variable. It's absolutely safe. The variable is set in some
> drivers, and used in bdrv_co_do_pwrite_zeroes().
>
> Update also max_write_zeroes variable in
On 3/24/21 3:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are generally moving to int64_t for both offset and bytes parameters
> on all io paths.
>
> Main motivation is realization of 64-bit write_zeroes operation for
> fast zeroing large disk chunks, up to the whole disk.
>
> We chose signed
On Fri, Apr 16, 2021 at 11:08:56AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Now, when thread can do negotiation and retry, it may run relatively
> long. We need a mechanism to stop it, when user is not interested in
> result anymore. So, on nbd_client_connection_release() let's shutdown
> the
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> Several distros have been dropped since the last time we bumped the
> minimum required CLang version.
>
> Per repology, currently shipping versions are:
>
> RHEL-8: 10.0.1
> Debian Stretch: 7.0.1
> Debian
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> Several distros have been dropped since the last time we bumped the
> minimum required GCC version.
>
> Per repology, currently shipping versions are:
>
> RHEL-8: 8.3.1
> Debian Stretch: 6.3.0
> Debian Buster:
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> The condition being tested has never been set since the day the code was
> first introduced.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> crypto/tlscredsx509.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Willian
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> The glib version was not previously constrained by RHEL-7 since it
> rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the
> constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of
> these are old enough that they
On 3/24/21 3:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are generally moving to int64_t for both offset and bytes parameters
> on all io paths.
>
> Main motivation is realization of 64-bit write_zeroes operation for
> fast zeroing large disk chunks, up to the whole disk.
>
> We chose signed
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> It has been over two years since RHEL-8 was released, and thus per the
> platform build policy, we no longer need to support RHEL-7 as a build
> target. This lets us increment the minimum required gnutls version
>
> Per repology,
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> It has been over two years since RHEL-8 was released, and thus per the
> platform build policy, we no longer need to support RHEL-7 as a build
> target. This lets us increment the minimum required gcrypt version and
> assume that HMAC
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> It has been over two years since RHEL-8 was released, and thus per the
> platform build policy, we no longer need to support RHEL-7 as a build
> target. This lets us increment the minimum required nettle version and
> drop a lot of
On Fri, Apr 16, 2021 at 11:08:55AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Add an option for thread to retry connection until success. We'll use
> nbd/client-connection both for reconnect and for initial connection in
> nbd_open(), so we need a possibility to use same NBDClientConnection
>
On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé wrote:
>
> It has been over two years since RHEL-8 was released, and thus per the
> platform build policy, we no longer need to support RHEL-7 as a build
> target.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .gitlab-ci.d/containers.yml
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> To allow forks to easily decide which jobs they want to run,
> but without disrupting the current default, move the current
> set of jobs to a new file corresponding to the jobs run by
> the mainstream project CI:
>
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> It is not possible to use the previously extracted templates
> without this set of core containers. Extract them into a new
> file (container-core.yml) to be able to build them without
> having to build all the other containers by
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> Extract the build/test jobs run by default on the mainstream
> CI into a new file (buildtest.yml).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/buildtest.yml | 726 +
>
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> To be able to reuse the mainstream build/test jobs templates,
> extract them into a new file (buildtest-template.yml).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/buildtest-template.yml | 69
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> Extract the build stages used by our job templates to a new file
> (stages.yml) to be able to include it with the other templates,
> without having to run all the jobs included in the default
> .gitlab-ci.yml, which are mainly
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> Extract the DCO / checkpatch jobs to a new file (static_checks.yml)
> to be able to run them without having to run all the jobs included
> in the default .gitlab-ci.yml, which are mainly useful for the
> mainstream CI.
>
>
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> Extract the crossbuild job templates to a new file
> (crossbuild-template.yml) to be able to reuse them
> without having to run all the jobs included, which
> are mainly useful for mainstream CI.
>
> Signed-off-by: Philippe
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> Extract the container job template to a new file
> (container-template.yml) to be able to reuse it
> without having to run all the jobs included, which
> are mainly useful for mainstream CI.
>
> Signed-off-by: Philippe
On Tue, May 11, 2021 at 4:30 AM Philippe Mathieu-Daudé wrote:
>
> From: Philippe Mathieu-Daudé
>
> 'extends' is an alternative to using YAML anchors
> and is a little more flexible and readable. See:
> https://docs.gitlab.com/ee/ci/yaml/#extends
>
> Reviewed-by: Wainer dos Santos Moschetta
>
On Sat, 8 May 2021 at 08:18, Jason Wang wrote:
>
> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd48672:
>
> Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504'
> into staging (2021-05-05 20:29:14 +0100)
>
> are available in the git repository at:
On 5/11/21 5:22 AM, David Hildenbrand wrote:
On 08.05.21 03:47, Richard Henderson wrote:
At the same time, rename to parts64_default_nan and define
a macro for parts_default_nan using QEMU_GENERIC.
All I can spot is "#define parts_default_nan parts64_default_nan" -- what am I
missing?
Dear colleagues,
I am looking for ways to accelerate the MTTCG for ARM guest on x86-64 host.
The maximum number of CPUs for MTTCG that uses GICv2 is limited by 8:
include/hw/intc/arm_gic_common.h:#define GIC_NCPU 8
The version 3 of the Generic Interrupt Controller (GICv3) is not
supported in
On 5/10/21 7:57 AM, Alex Bennée wrote:
Richard Henderson writes:
These builtins came in clang 3.8, but are not present in gcc through
version 11. Even in clang the optimization is not ideal except for
x86_64, but no worse than the hand-coding that we currently do.
Given this statement
On 5/6/21 8:12 AM, Christian Schoenebeck wrote:
> To lower the entry level for new developers, add a link to the
> 9p developer docs (i.e. qemu wiki) at the beginning of 9p source
> files, that is to: https://wiki.qemu.org/Documentation/9p
>
> Signed-off-by: Christian Schoenebeck
> ---
>
On 5/11/21 12:51 PM, Andrey Shinkevich wrote:
The version 3 of the Generic Interrupt Controller (GICv3) is not
supported in QEMU for some reason unknown to me.
It is supported. You have to enable it like so:
-M virt,gic-version=3
r~
Long story short, we need a space here for the reference to work
correctly.
Longer story:
Without the space, kerneldoc generates a line like this:
one of :c:type:`MemoryListener.region_add\(\)
`,:c:type:`MemoryListener.region_del\(\)
Sphinx does not process the role information correctly, so
From: Stefan Hajnoczi
socket_get_fd() fails with the error "socket_get_fd: too many
connections" if the given listen backlog value is not 1.
Not all callers set the backlog to 1. For example, commit
582d4210eb2f2ab5baac328fe4b479cd86da1647 ("qemu-nbd: Use SOMAXCONN for
socket listen() backlog")
The following changes since commit f9a576a818044133f8564e0d243ebd97df0b3280:
Merge remote-tracking branch
'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210506' into staging (2021-05-11
13:03:44 +0100)
are available in the Git repository at:
https://repo.or.cz/qemu/ericb.git
On 3/24/21 3:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to convert .bdrv_co_preadv_part and .bdrv_co_pwritev_part
> to int64_t type for offset and bytes parameters (as it's already done
> for generic block/io.c layer).
>
> In qcow2 .bdrv_co_preadv_part is used in some places, so
On 5/11/21 4:25 AM, Daniel P. Berrangé wrote:
> The QAPI reference docs for the guest agent, storage daemon and QMP are
> all rather long and hard to navigate unless you already know the name of
> the command and can do full text search for it.
>
> A table of contents in each doc will help people
From: Gustavo Noronha Silva
v4 moves the code to add the tap to the set function, which
not only sidesteps the issue pointed out by Akihiko Odaki
but simply makes sense - full-grab is not a runtime toggle
and there is no reason to have the tap set up if it's not
turned on.
It also fixes the
From: Gustavo Noronha Silva
On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change
swaps them around so that Alt is the key closer to the space bar and Meta/Super
is between Control and Alt, like on non-Mac keyboards.
It is a cocoa display option, disabled by default.
From: Gustavo Noronha Silva
Applications such as Gnome may use Alt-Tab and Super-Tab for different
purposes, some use Ctrl-arrows so we want to allow qemu to handle
everything when it captures the mouse/keyboard.
However, Mac OS handles some combos like Command-Tab and Ctrl-arrows
at an earlier
On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> QEMU fails to report a good error message if the bridge helper exits
> with success code, but forgets to pass back an FD.
>
> There is also a minor portability problem impacting FreeBSD/NetBSD
> dealing with cmsg initialization.
>
> Daniel P.
On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> [..]
> The recv_fd() method returns -1 on error, 0 on end of file, or an FD
> $ qemu-system-x86_64 -netdev bridge,br=br99,helper=/bin/true,id=ns0
> qemu-system-x86_64: -netdev bridge,br=br99,helper=/bin/true,id=ns0:
> bridge helper did not
OSS-Fuzz never picked up on this one, so I'm guessing it was fixed sometime
between 5.1 and 5.2.
Not a fun section to bisect, but looks like it was fixed by 21bc31524e ("hw:
xhci: check return value of 'usb_packet_map'")
--
You received this bug notification because you are a member of qemu-
Hi all,
I need some help with grok'ing qdev busses. Stefan, Michael - David
suggested on IRC that I CC'ed you guys since you might have solved a
similar issue with virtio devices. I've tried to study how that works,
but I'm not exactly sure how to apply it to the issue I'm having.
On Tue, May 11, 2021 at 09:23:10AM +0100, Stefan Hajnoczi wrote:
> On Tue, Mar 16, 2021 at 08:35:14AM -0500, Eric Blake wrote:
> > On 3/16/21 4:10 AM, Stefan Hajnoczi wrote:
> > > On Wed, Mar 10, 2021 at 05:30:04PM +, Stefan Hajnoczi wrote:
> > >> socket_get_fd() fails with the error
On 5/11/21 12:15 AM, Warner Losh wrote:
> The forked bsd-user tree doesn't really support these platforms. They aren't
> functional at the moment anyway. Remove them from the build so that the major
> reorg patch series can focus on one platform (x86) before adding addition
> platforms once
I don't think it is fixed yet.. This is https://bugs.chromium.org/p/oss-
fuzz/issues/detail?id=28571#c4
Bash Reproducer:
./qemu-system-i386 -display none -machine accel=qtest, -m 512M \
-machine q35 -nodefaults -drive \
file=null-co://,if=none,format=raw,id=disk0 -device qemu-xhci,id=xhci \
** Attachment added: "attachment"
https://bugs.launchpad.net/qemu/+bug/1883729/+attachment/5496430/+files/attachment
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1883729
Title:
On 3/24/21 3:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We modify the request by adding an offset to vmstate. Let's check the
> modified request. It will help us to safely move .bdrv_co_preadv_part
> and .bdrv_co_pwritev_part to int64_t type of offset and bytes.
>
> Signed-off-by: Vladimir
On 3/24/21 3:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> There are only two drivers supporting vmstate: qcow2 and sheepdog.
> Sheepdog is deprecated. In qcow2 these requests go through
> .bdrv_co_p{read,write}v_part handlers.
>
> So, let's do our basic check for the request on vmstate generic
>
Hey,
On Tue, May 11, 2021, at 12:08 AM, Akihiko Odaki wrote:
> > +CFRunLoopAddSource(runLoop, tapEventsSrc, kCFRunLoopDefaultMode);
> > +CFRelease(tapEventsSrc);
> > +
> > return self;
> > }
> >
>
> These statements should be in "if (self)" block which they follow, or it
>
For the purposes of my QAPI generator cleanup (adding docstrings and
mypy static types to ./scripts/qapi), I have a series of patches I've
been carrying off-list that changes the behavior of how Sphinx
cross-references work.
Presently, `foo` in our Sphinx docs is interpreted as the "content"
On 5/11/21 3:10 AM, Peter Maydell wrote:
On Fri, 30 Apr 2021 at 21:30, Richard Henderson
wrote:
Signed-off-by: Richard Henderson
---
v2: Fix sqabs, sqneg (laurent desnogues)
---
target/arm/helper-sve.h| 13 +++
target/arm/sve.decode | 7 ++
target/arm/sve_helper.c
Can you still reproduce this assertion with the latest version 6.0 of
QEMU? ... I cannot trigger it here, so I assume this issue has been
fixed?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On 5/11/21 2:55 AM, Peter Maydell wrote:
This code is earlier in the function than the place where we
update ahcf->isar to set the "SVE supported bits":
/* Add feature bits that can't appear until after VCPU init. */
if (sve_supported) {
t = ahcf->isar.id_aa64pfr0;
t
Can you still reproduce this assert with QEMU v6.0 ? For me, it does not
seem to run into the assert() anymore, so I assume this has been fixed
within the last months?
** Changed in: qemu
Status: New => Incomplete
** Tags added: fuzzer usb
--
You received this bug notification because
On 05.05.2021 09:59, Vladimir Sementsov-Ogievskiy wrote:
> Split checking for reserved bits out of aligned offset check.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
Tested-by: Kirill Tkhai
> ---
> block/qcow2.h | 1 +
> block/qcow2-refcount.c | 10
On Tue, May 11, 2021 at 04:13:47AM -0400, Paolo Bonzini wrote:
> The HMP loadvm code is calling load_snapshot rather than
> qmp_snapshot_load, in order to bypass the job infrastructure. The code
> around it is almost the same, with one difference: hmp_loadvm is
> restarting the VM if
On 5/10/21 5:15 PM, Warner Losh wrote:
Warner Losh (3):
bsd-user: remove target_signal.h, it's unused
bsd-user: Stop building the sparc platforms
bsd-user: rename linux_binprm to bsd_binprm
Reviewed-by: Richard Henderson
r~
On Tue, May 11, 2021 at 06:58:01PM +0200, Kevin Wolf wrote:
> Am 11.05.2021 um 18:49 hat Daniel P. Berrangé geschrieben:
> > On Tue, May 11, 2021 at 06:31:51PM +0200, Kevin Wolf wrote:
> > > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation
> > > when converting from 0/-errno
On Tue, May 11, 2021 at 06:31:51PM +0200, Kevin Wolf wrote:
> Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation
> when converting from 0/-errno return values to a bool value. The result
> is that loadvm resumes the VM now if it failed and keeps it stopped if
> it failed. Fix it
Am 11.05.2021 um 18:49 hat Daniel P. Berrangé geschrieben:
> On Tue, May 11, 2021 at 06:31:51PM +0200, Kevin Wolf wrote:
> > Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation
> > when converting from 0/-errno return values to a bool value. The result
> > is that loadvm resumes
On 05.05.2021 09:59, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
> ---
> block/qcow2.h | 1 +
> block/qcow2-refcount.c | 6 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/block/qcow2.h b/block/qcow2.h
> index
On 5/11/21 5:41 AM, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/virtio: Pass virtio_feature_get_config_size() a const argument
virtio-blk: Constify VirtIOFeature feature_sizes[]
virtio-net: Constify VirtIOFeature feature_sizes[]
Reviewed-by: Richard Henderson
r~
On 05.05.2021 09:59, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
> ---
> block/qcow2.h | 1 +
> block/qcow2-refcount.c | 12 +++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/block/qcow2.h
On 5/11/21 5:35 AM, Philippe Mathieu-Daudé wrote:
Keep bitmask_transtbl in .rodata by marking the arrays const.
Signed-off-by: Philippe Mathieu-Daudé
---
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On Thu, Apr 29, 2021 at 05:40:23PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Hi,
>
> This series makes the 'if' conditions less liberal, by formalizing a simple
> expression tree based on bare boolean logic of configure option identifiers.
>
> (this allows to
On 05.05.2021 09:59, Vladimir Sementsov-Ogievskiy wrote:
> Check subcluster bitmap of the l2 entry for different types of
> clusters:
>
> - for compressed it must be zero
> - for allocated check consistency of two parts of the bitmap
> - for unallocated all subclusters should be unallocated
>
On Thu, Apr 29, 2021 at 05:40:25PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Move the generating function to the QAPISchemaIfCond class.
I'm not familiar enough with the QAPI code generator to know whether
schema.py is supposed to generate C code directly.
Commit f61fe11aa6f broke hmp_loadvm() by adding an incorrect negation
when converting from 0/-errno return values to a bool value. The result
is that loadvm resumes the VM now if it failed and keeps it stopped if
it failed. Fix it to restore the old behaviour and do it the other way
around.
On Fri, 30 Apr 2021 at 21:41, Richard Henderson
wrote:
>
> From: Stephen Long
>
> Signed-off-by: Stephen Long
> Reviewed-by: Richard Henderson
> Signed-off-by: Richard Henderson
> ---
> v2: Load all inputs before writing any output (laurent desnogues)
> ---
> target/arm/helper-sve.h| 35
From: Philippe Mathieu-Daudé
When no mapping is requested, it is pointless to create
alias regions.
Only create them when multiple mappings are requested to
simplify the memory layout. The flatview is not changed.
For example using 'qemu-system-sh4 -M r2d -S -monitor stdio',
* before:
-20210511
for you to fetch changes up to 27545c9df24f509c6d1c1f17478281a357125554:
hw/block/pflash_cfi02: Do not create aliases when not necessary (2021-05-11
18:11:02 +0200)
Parallel NOR Flash patches queue
- Simplify memory
On 5/11/21 6:03 PM, Klaus Jensen wrote:
On May 11 16:54, Hannes Reinecke wrote:
On 5/11/21 3:37 PM, Klaus Jensen wrote:
On May 11 15:12, Hannes Reinecke wrote:
On 5/11/21 2:22 PM, Klaus Jensen wrote:
[ .. ]
The hotplug fix looks good - I'll post a series that tries to
integrate
both.
Ta.
From: Philippe Mathieu-Daudé
The ROMD mode isn't related to mapping setup.
Ideally we'd set this mode when the state machine resets,
but for now simply move it to pflash_cfi02_realize() to
not introduce logical change.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
On Fri, 30 Apr 2021 at 21:50, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/sve.decode | 6 ++
> target/arm/translate-sve.c | 21 +
> 2 files changed, 27 insertions(+)
Reviewed-by: Peter Maydell
thanks
-- PMM
On May 11 16:54, Hannes Reinecke wrote:
On 5/11/21 3:37 PM, Klaus Jensen wrote:
On May 11 15:12, Hannes Reinecke wrote:
On 5/11/21 2:22 PM, Klaus Jensen wrote:
[ .. ]
The hotplug fix looks good - I'll post a series that tries to integrate
both.
Ta.
The more I think about it, the more I
On Fri, 30 Apr 2021 at 21:37, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/sve.decode | 5 +
> target/arm/translate-sve.c | 10 ++
> 2 files changed, 15 insertions(+)
Reviewed-by: Peter Maydell
thanks
-- PMM
On Fri, 30 Apr 2021 at 21:44, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/helper-sve.h| 24
> target/arm/sve.decode | 12 ++
> target/arm/sve_helper.c| 56 +
> target/arm/translate-sve.c | 238
On Fri, 30 Apr 2021 at 21:53, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/sve.decode | 8
> target/arm/translate-sve.c | 34 ++
> 2 files changed, 42 insertions(+)
Applied, thanks.
Please update the changelog
If the user explicitly asked for the system libfdt library, but
the library is not usable (usually too old), we should not silently
default to the internal one.
Respect the user decision, and only default to 'internal' if in
auto mode.
Fixes: fbb4121d592 ("dtc: Convert Makefile bits to meson
On 5/11/21 5:53 PM, Philippe Mathieu-Daudé wrote:
> Attempt to fix the issue reported by John when building
> with an outdated libfdt.
Unencoded version of this cover:
For now it changes:
hw/ppc/spapr_hcall.c: In function ‘h_update_dt’:
hw/ppc/spapr_hcall.c:1966:9: warning: implicit
On Tue, 11 May 2021 at 16:40, Richard Henderson
wrote:
>
> On 5/11/21 3:43 AM, Peter Maydell wrote:
> >> +#define do_sqshl_d(n, m) \
> >> + ({ uint32_t discard; do_sqrshl_d(n, m, false, ); })
> > Why pass in rather than just NULL ? (Similarly below.)
>
> sat != NULL means enable saturation.
>
Since commit fea35ca4b8e ("ppc/spapr: Receive and store device
tree blob from SLOF") the pSeries machine depends on the libfdt
fdt_check_full() call, which is available in libfdt v1.4.7.
Add the corresponding Kconfig dependency.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/Kconfig | 1
The CONFIG_FDT symbol depends on the availability of the
fdt library on the host. To be able to have other symbols
depends on it, declare it symbol in Kconfig.host.
Signed-off-by: Philippe Mathieu-Daudé
---
Kconfig.host | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Kconfig.host
hw/ppc/fdt.c defines the ppc_create_page_sizes_prop() function,
which is unrelated to the libfdt. Remove the incorrect library
dependency on the file.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Per the kconfig.rst:
A device should be listed [...] ``imply`` if (depending on
the QEMU command line) the board may or may not be started
without it.
This is the case with the NVDIMM device, so use the 'imply'
weak reverse dependency to select the symbol.
Signed-off-by: Philippe
Attempt to fix the issue reported by John when building
with an outdated libfdt.
For now it changes:
hw/ppc/spapr_hcall.c: In function =E2=80=98h_update_dt=E2=80=99:
hw/ppc/spapr_hcall.c:1966:9: warning: implicit declaration of function =E2=
=80=98fdt_check_full=E2=80=99; did you mean
On Fri, 30 Apr 2021 at 21:37, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> v2: Fix sel indexing and argument order (laurent desnogues).
> ---
> target/arm/helper-sve.h| 3 +++
> target/arm/sve.decode | 6 ++
> target/arm/sve_helper.c| 34
On 5/11/21 3:43 AM, Peter Maydell wrote:
+#define do_sqshl_d(n, m) \
+ ({ uint32_t discard; do_sqrshl_d(n, m, false, ); })
Why pass in rather than just NULL ? (Similarly below.)
sat != NULL means enable saturation.
Discard the results because unlike NEON, there is no architectural SVE
On Tue, May 11, 2021 at 10:43:57AM +, John Levon wrote:
> On Tue, May 11, 2021 at 11:09:53AM +0100, Stefan Hajnoczi wrote:
> > Fleshing out irqs sounds like a 1.0 milestone to me. It will definitely
> > be necessary but for now this can be dropped.
>
> I could be wrong, and probably am, but I
Most block device commands do not require a fully constructed machine.
Allow running them before machine initialization has concluded.
Signed-off-by: Paolo Bonzini
---
hmp-commands.hx| 14 +
qapi/block-core.json | 117 +++--
Creating and destroying network backend does not require a fully
constructed machine. Allow the related monitor commands to run before
machine initialization has concluded.
Signed-off-by: Paolo Bonzini
---
hmp-commands.hx | 2 ++
qapi/net.json | 6 --
2 files changed, 6 insertions(+), 2
Creating and destroying QOM objects does not require a fully constructed
machine. Allow running object-add and object-del before machine
initialization has concluded.
Signed-off-by: Paolo Bonzini
---
hmp-commands.hx | 2 ++
qapi/qom.json | 6 --
2 files changed, 6 insertions(+), 2
On Tue, May 11, 2021 at 03:00:05PM +, Boeuf, Sebastien wrote:
> But what about the vhost-user backend initialization? Does
> QEMU go again through initializing memory table, vrings, etc...
> since it can't assume anything from the backend?
Yes, the initial protocol messages are the same after
On Fri, 30 Apr 2021 at 21:44, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> v2: Fix select offsetting and argument order (laurent desnogues).
> ---
> target/arm/helper-sve.h| 14 ++
> target/arm/sve.decode | 12 +
> target/arm/sve_helper.c|
From: Peter Maydell
Coverity notices that several places in the migration-test code fail
to free memory in error-exit paths. This is pretty unimportant in
test case code, but we can avoid having to manually free the memory
entirely by using g_autofree.
The places where Coverity spotted a leak
From: David Hildenbrand
We want to make use of ram_block_discard_range() in the RAM block resize
callback when growing a RAM block, *before* used_length is changed.
Let's relax the check. As RAM blocks always mmap the whole max_length area,
we cannot corrupt unrelated data.
Reviewed-by: Peter
hsch and csch basically have two parts: execute the command,
and perform the halt/clear function. For fully emulated
subchannels, it is pretty clear how it will work: check the
subchannel state, and actually 'perform the halt/clear function'
and set cc 0 if everything looks good.
For passthrough
From: Hyman
Guestperf tool does not cover the multifd-enabled migration
currently, it is worth supporting so that developers can
analysis the migration performance with all kinds of
migration.
To request that multifd is enabled, with 4 channels:
$ ./tests/migration/guestperf.py \
--multifd
From: "Dr. David Alan Gilbert"
Accidental use of "true" as a boolean; spotted by coverity
and Peter.
Fixes: b99784ef6c3
Fixes: d795f47466e
Reported-by: Peter Maydell
Reported-by: Coverity (CID 1432373, 1432292, 1432288)
Signed-off-by: Dr. David Alan Gilbert
Message-Id:
From: David Hildenbrand
We never read or write beyond the used_length of memory blocks when
migrating. Make this clearer by using offset_in_ramblock() consistently.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
Message-Id: <20210429112708.12291-11-da...@redhat.com>
101 - 200 of 524 matches
Mail list logo
