[PULL 58/59] linux-user/elfload: fix filling psinfo->pr_psargs

2021-05-17 Thread Laurent Vivier
From: Ilya Leoshkevich The current code dumps the memory between arg_start and arg_end, which contains the argv pointers. This results in the Core was generated by `` message when opening the core file in GDB. This is because the code is supposed to dump the actual arg strings. Fix by

[PULL 25/59] linux-user/sparc: Save and restore fpu in signal frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-19-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 84 --- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git

[PULL 41/59] linux-user/s390x: Clean up single-use gotos in signal.c

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-10-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 29 - 1 file changed, 8 insertions(+), 21

[PULL 22/59] linux-user/sparc: Use target_pt_regs

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Replace __siginfo_t with target_pt_regs, and move si_mask into target_signal_frame directly. Extract save/restore functions for target_pt_regs. Adjust for sparc64 tstate. Use proper get/put functions for psr. Turns out we were already writing to si_mask twice, so no

[PULL 24/59] linux-user/sparc: Clean up get_sigframe

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Remove inline; fix spacing and comment format. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-18-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PULL 59/59] linux-user/elfload: add s390x core dumping support

2021-05-17 Thread Laurent Vivier
From: Ilya Leoshkevich Provide the following definitions required by the common code: * ELF_NREG: with the value of sizeof(s390_regs) / sizeof(long). * target_elf_gregset_t: define it like all the other arches do. * elf_core_copy_regs(): similar to kernel's s390_regs_get(). * USE_ELF_CORE_DUMP.

[PULL 18/59] linux-user/sparc: Merge sparc64/ into sparc/

2021-05-17 Thread Laurent Vivier
From: Richard Henderson All of the source and header files already defer to sparc via #include. The syscall.tbl and syscallhdr.sh files could not do the same, but are identical. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-12-richard.hender...@linaro.org>

[PULL 20/59] linux-user/sparc: Remove target_rt_signal_frame as unused

2021-05-17 Thread Laurent Vivier
From: Richard Henderson It's wrong anyway. Remove it for now. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-14-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PULL 40/59] linux-user/s390x: Tidy save_sigregs

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The "save" routines copied from the kernel, which are currently commented out, are unnecessary in qemu. We can copy from env where the kernel needs special instructions. Fix comment style. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id:

[PULL 47/59] linux-user/s390x: Handle vector regs in signal stack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-16-richard.hender...@linaro.org> [lv: fix indentation] Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 62 +-- 1 file

[PULL 01/59] linux-user: Remove dead code

2021-05-17 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We can not use watchpoints in user-mode emulation because we need the softmmu slow path to detect accesses to watchpointed memory. This code is expanded as empty stub in "hw/core/cpu.h" anyway, so we can drop it. Reviewed-by: Laurent Vivier Signed-off-by: Philippe

[PULL 21/59] linux-user/sparc: Fix the stackframe structure

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Move target_reg_window up and use it. Fold structptr and xxargs into xargs -- the use of a host pointer was incorrect anyway. Rename the structure to target_stackf for consistency. Signed-off-by: Richard Henderson Message-Id:

[PULL 50/59] linux-user: use GDateTime for formatting timestamp for core file

2021-05-17 Thread Laurent Vivier
From: Daniel P. Berrangé The GDateTime APIs provided by GLib avoid portability pitfalls, such as some platforms where 'struct timeval.tv_sec' field is still 'long' instead of 'time_t'. When combined with automatic cleanup, GDateTime often results in simpler code too. Signed-off-by: Daniel P.

[PULL 49/59] linux-user: Fix erroneous conversion in copy_file_range

2021-05-17 Thread Laurent Vivier
From: Giuseppe Musacchio The implicit cast from abi_long to size_t may introduce an intermediate unwanted sign-extension of the value for 32bit targets running on 64bit hosts. Signed-off-by: Giuseppe Musacchio Reviewed-by: Laurent Vivier Message-Id:

[PULL 15/59] linux-user/sparc: Merge sparc64 target_elf.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-9-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc64/target_elf.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git

[PULL 46/59] linux-user/s390x: Clean up signal.c

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Reorder the function bodies to correspond to the kernel source. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-15-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 63

[PULL 12/59] linux-user/sparc: Include TARGET_STACK_BIAS in get_sp_from_cpustate

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Move TARGET_STACK_BIAS from signal.c. Generic code cares about the logical stack pointer, not the physical one that has a bias applied for sparc64. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-6-richard.hender...@linaro.org> Signed-off-by:

[PULL 35/59] linux-user/s390x: Remove PSW_ADDR_AMODE

2021-05-17 Thread Laurent Vivier
From: Richard Henderson This is an unnecessary complication since we only support 64-bit mode. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 17

[PULL 08/59] linux-user: Split out target_restore_altstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Create a function to match target_save_altstack. Fix some style and unlock issues in do_sigaltstack. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/signal-common.h | 1

[PULL 30/59] linux-user/sparc: Implement sparc32 rt signals

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-24-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 126 -- 1 file changed, 122 insertions(+), 4 deletions(-) diff --git

[PULL 27/59] linux-user/sparc: Clean up setup_frame

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Clean up a goto label with a single use. Remove #if 0. Remove useless parentheses. Fold constants into __put_user. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-21-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 13/59] linux-user/sparc: Clean up init_thread

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Share code between sparc32 and sparc64, removing a bit of pointless difference wrt psr/tstate. Use sizeof(abi_ulong) for allocating initial register window. Use TARGET_STACK_BIAS. Signed-off-by: Richard Henderson Message-Id:

[PULL 10/59] linux-user: Pass CPUArchState to do_sigaltstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Now that we have exactly one call, it's easy to pass in env instead of passing in the sp value. Use target_save_altstack, which required env. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-4-richard.hender...@linaro.org> Signed-off-by: Laurent

[PULL 28/59] linux-user/sparc: Minor corrections to do_sigreturn

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Check that the input sp is 16 byte aligned, not 4. Do that before the lock_user_struct check. Validate the saved sp is 8 byte aligned. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-22-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier

[PULL 11/59] linux-user: Pass CPUArchState to target_restore_altstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson In most cases we were already passing get_sp_from_cpustate directly to the function. In other cases, we were passing a local variable which already contained the same value. In the rest of the cases, we were passing the stack pointer out of env directly. Reviewed by:

[PULL 19/59] linux-user/sparc: Remove target_sigcontext as unused

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-13-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 28 1 file changed, 28 deletions(-) diff --git a/linux-user/sparc/signal.c

[PULL 06/59] linux-user/arm: Simplify accumulating and raising fpa11 exceptions

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Use bit masking instead of an if tree. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 50

[PULL 02/59] linux-user: strace now handles unshare syscall args correctly

2021-05-17 Thread Laurent Vivier
From: Matus Kysel Syscall unshare did not have custom print function for strace, but it's argument is same as flags in clone syscall, so it can be easily implemented. Also updated missing flags from clone_flags. Signed-off-by: Matus Kysel Reviewed-by: Laurent Vivier Message-Id:

[PULL 17/59] linux-user/sparc: Merge sparc64 termbits.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-11-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc64/termbits.h | 292 +- 1 file changed, 1 insertion(+), 291 deletions(-) diff --git

[PULL 29/59] linux-user/sparc: Add 64-bit support to fpu save/restore

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The shape of the kernel's __siginfo_fpu_t is dependent on the cpu type, not the abi. Which is weird, but there ya go. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-23-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 03/59] linux-user/arm: Split out emulate_arm_fpa11

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Pull out the fpa11 emulation to a helper function. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 153

[PULL 16/59] linux-user/sparc: Merge sparc64 target_structs.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-10-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/target_structs.h | 34 +++-- linux-user/sparc64/target_structs.h | 59 + 2

[PULL 09/59] linux-user: Use target_restore_altstack in all sigreturn

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Note that target_restore_altstack uses the host memory pointer that we have already verified, so TARGET_EFAULT is not a possible return value. Note that using -EFAULT was a bug. Signed-off-by: Richard Henderson Message-Id:

[PULL 14/59] linux-user/sparc: Merge sparc64 target_syscall.h

2021-05-17 Thread Laurent Vivier
From: Richard Henderson There are only a few differences in sparc32 vs sparc64. This fixes target_shmlba for sparc32plus, which is v9. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 07/59] linux-user: Add strace support for printing arguments of llseek

2021-05-17 Thread Laurent Vivier
From: Kito Cheng Some target are using llseek instead of _llseek like riscv, nios2, hexagon, and openrisc. Signed-off-by: Kito Cheng Reviewed-by: Laurent Vivier Message-Id: <20210512101358.122781-1-kito.ch...@sifive.com> Signed-off-by: Laurent Vivier --- linux-user/strace.c| 3 ++-

[PULL 05/59] linux-user/arm: Do not fill in si_code for fpa11 exceptions

2021-05-17 Thread Laurent Vivier
From: Richard Henderson There is no such decoding in linux/arch/arm/nwfpe/fpmodule.c. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 26

[PULL 04/59] linux-user/arm: Do not emulate fpa11 in thumb mode

2021-05-17 Thread Laurent Vivier
From: Richard Henderson These antiquated instructions are arm-mode only. Buglink: https://bugs.launchpad.net/bugs/1925512 Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210423165413.338259-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 00/59] Linux user for 6.1 patches

2021-05-17 Thread Laurent Vivier
-request for you to fetch changes up to 4a1e8931eca05077afd0b7ed092ab0f10c5b457e: linux-user/elfload: add s390x core dumping support (2021-05-18 07:10:46 +0200) linux-user pull request 20210517 - alpha sigaction fixes/cleanups

Re: Best approach for supporting snapshots for QEMU's gdbstub?

2021-05-17 Thread Pavel Dovgalyuk
On 17.05.2021 20:27, Alex Bennée wrote: Luis Machado writes: Hi, On 5/14/21 1:06 PM, Alex Bennée wrote: Hi, I've been playing around with QEMU's reverse debugging support which I have working with Pavel's latest patches for supporting virtio with record/replay. Once you get the right

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-17 Thread Alexey Kardashevskiy
On 18/05/2021 04:44, BALATON Zoltan wrote: On Mon, 17 May 2021, BALATON Zoltan wrote: On Mon, 17 May 2021, Alexey Kardashevskiy wrote: On 5/17/21 09:34, BALATON Zoltan wrote: On Sat, 15 May 2021, BALATON Zoltan wrote: On Sat, 15 May 2021, BALATON Zoltan wrote: On Thu, 22 Apr 2021, Alexey

Re: [PULL 00/59] Linux user for 6.1 patches

2021-05-17 Thread Laurent Vivier
Hi, I'm going to send an updated PR with fixes for problem reported by checkpatch. Thanks, Laurent Le 17/05/2021 à 21:15, no-re...@patchew.org a écrit : > Patchew URL: https://patchew.org/QEMU/20210517181424.8093-1-laur...@vivier.eu/ > > > > Hi, > > This series seems to have some coding

Re: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-17 Thread wangyanan (Y)
Hi Salil, On 2021/5/18 1:07, Salil Mehta wrote: From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of Yanan Wang Sent: Sunday, May 16, 2021 11:29 AM To: Peter Maydell ; Andrew Jones ; Michael S . Tsirkin ; Igor Mammedov ; Shannon Zhao ; Alistair Francis ; David

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

2021-05-17 Thread Alexey Kardashevskiy
On 17/05/2021 22:17, BALATON Zoltan wrote: On Mon, 17 May 2021, Alexey Kardashevskiy wrote: On 5/16/21 01:04, BALATON Zoltan wrote: On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote: [snip] +/* Defined as Big Endian */ +struct prom_args { +    uint32_t service; +    uint32_t nargs; +   

[Bug 1912780] Re: QEMU: Null Pointer Failure in fdctrl_read() in hw/block/fdc.c

2021-05-17 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/338 ** Changed in: qemu Status: In Progress => Expired **

Re: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members

2021-05-17 Thread wangyanan (Y)
Hi Salil, On 2021/5/18 4:48, Salil Mehta wrote: From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of Yanan Wang Sent: Sunday, May 16, 2021 11:29 AM To: Peter Maydell ; Andrew Jones ; Michael S . Tsirkin ; Igor Mammedov ; Shannon Zhao ; Alistair Francis ; David

[Bug 1925496] Re: nvme disk cannot be hotplugged after removal

2021-05-17 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know how to transfer the bug to the new system if (if still necessary). Thus we're setting the status to "Incomplete" now. In the unlikely case that the bug has already been fixed in the latest upstream

[Bug 1914638] Re: [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page

2021-05-17 Thread Thomas Huth
What happened to your patch, Philippe? Did it get stalled? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914638 Title: [OSS-Fuzz] Issue 30219: Global-buffer-overflow in mode_sense_page Status in

[Bug 1914870] Re: libvixl compilation failure on Debian unstable

2021-05-17 Thread Thomas Huth
Suggested patch: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg04637.html ** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914870

[Bug 1922102] Re: Broken tap networking on macOS host

2021-05-17 Thread Thomas Huth
Ticket has been moved here (thanks, Vladislav!): https://gitlab.com/qemu-project/qemu/-/issues/335 ... thus I'm closing this on Launchpad now. ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #335 https://gitlab.com/qemu-project/qemu/-/issues/335 ** Changed in: qemu Status:

[Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2021-05-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796520 Title: autogen

Re: [PATCH v2 4/6] python/console_socket: Add a pylint ignore

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:06PM -0400, John Snow wrote: > We manage cleaning up this resource ourselves. Pylint should shush. > > Signed-off-by: John Snow > --- > python/qemu/console_socket.py | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Cleber Rosa signature.asc Description:

Re: [PATCH v2 6/6] python/machine: disable warning for Popen in _launch()

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:08PM -0400, John Snow wrote: > We handle this resource rather meticulously in > shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in > _do_shutdown(). > > Quiet this pylint warning here. > > Signed-off-by: John Snow > --- > python/qemu/machine.py

Re: [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull)

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:04PM -0400, John Snow wrote: > One less file resource to manage, and it helps quiet some pylint >= > 2.8.0 warnings about not using a with-context manager for the open call. > > Signed-off-by: John Snow > Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:05PM -0400, John Snow wrote: > use run() instead of Popen() -- to assert to pylint that we are not > forgetting to close a long-running program. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 15 +-- > 1 file changed, 9 insertions(+), 6

Re: [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch

2021-05-17 Thread Cleber Rosa
On Mon, May 17, 2021 at 02:48:07PM -0400, John Snow wrote: > Shift the open() call later so that the pylint pragma applies *only* to > that one open() call. Add a note that suggests why this is safe: the > resource is unconditionally cleaned up in _post_shutdown(). > > _post_shutdown is called

Re: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-05-17 Thread wangyanan (Y)
Hi Salil, On 2021/5/17 23:17, Salil Mehta wrote: From: Qemu-devel [mailto:qemu-devel-bounces+salil.mehta=huawei@nongnu.org] On Behalf Of Yanan Wang Sent: Sunday, May 16, 2021 11:32 AM To: Peter Maydell ; Paolo Bonzini ; Andrew Jones ; Michael S . Tsirkin ; Igor Mammedov ; Shannon Zhao ;

Re: [PATCH v4 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP

2021-05-17 Thread Ziqiao Kong
On Tue, May 18, 2021 at 4:29 AM Eduardo Habkost wrote: > > Hi, > > Thanks for the patch, and apologies for not reviewing earlier > versions. > Nevermind, the earlier version is also hard to review without a proper split. > On Fri, May 07, 2021 at 04:00:58PM +0800, Ziqiao Kong wrote: > > Changes

Re: [PATCH v4 1/2] target/i386: Trivial code motion

2021-05-17 Thread Ziqiao Kong
On Tue, May 18, 2021 at 4:16 AM Eduardo Habkost wrote: > > On Fri, May 07, 2021 at 04:00:56PM +0800, Ziqiao Kong wrote: > > Move the float translation case to a new block by a new pair of braces. > > If you are just adding braces around the code, do you really need > to reindent all the code? I

Re: [RFC PATCH v3 9/9] hw/arm/virt: Add separate -smp parsing function for ARM machines

2021-05-17 Thread wangyanan (Y)
Hi Drew, On 2021/5/17 16:24, Andrew Jones wrote: On Sun, May 16, 2021 at 06:29:00PM +0800, Yanan Wang wrote: The cpu hierarchy topology information parsed out from QEMU -smp command line will be exposed to guest kernel through ACPI and DT since machine type 6.1, so we will expect more detailed

Re: [PATCH v5 20/23] target/ppc: Implement cfuged instruction

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:22PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > v5: > - Comments to explain helper_cfuged implementation. > --- > target/ppc/helper.h| 1 + >

RE: [PATCH v6 05/10] Add a function named packet_new_nocopy for COLO.

2021-05-17 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Friday, April 9, 2021 11:21 AM > To: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com; > pbonz...@redhat.com; lukasstra...@web.de > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject:

Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:25PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn32.decode | 14 ++ > target/ppc/translate.c | 52

Re: [PATCH v5 21/23] target/ppc: Implement vcfuged instruction

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:23PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > v5: > - New REQUIRE_ALTIVEC macro; > - REQUIRE_INSNS_FLAGS2. > --- > target/ppc/insn32.decode | 7

Re: [PATCH v5 14/23] TCG: add tcg_constant_tl

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:16PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Used in D/DS/X-form load/store implementation. > > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > include/tcg/tcg-op.h | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH v5 22/23] target/ppc: Move addpcis to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:24PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Reviewed-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn32.decode | 6 ++ > target/ppc/translate.c

Re: [PATCH v5 18/23] target/ppc: Implement prefixed integer store instructions

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:20PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn64.decode | 12 >

Re: [PATCH v5 15/23] target/ppc: Move D/DS/X-form integer loads to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:17PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > These are all connected by macros in the legacy decoding. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- >

Re: [PATCH v5 17/23] target/ppc: Move D/DS/X-form integer stores to decodetree

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:19PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > These are all connected by macros in the legacy decoding. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- >

Re: [PATCH v5 12/23] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:14PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn32.decode | 8 >

Re: [PATCH v5 19/23] target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:21PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Implements the following PowerISA v3.1 instructions: > setbc: Set Boolean Condition > setbcr: Set Boolean Condition Reverse > setnbc: Set Negative Boolean Condition > setnbcr: Set Negative

Re: [PATCH v5 16/23] target/ppc: Implement prefixed integer load instructions

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:18PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/insn64.decode | 15 +++ >

Re: [PATCH] Fix `lxvdsx` (issue #212)

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 04:40:32PM -0500, Paul A. Clarke wrote: > `lxvdsx` is byte-swapping the data it loads, which it should not > do. Fix it. > > Fixes #212. > > Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c > Signed-off-by: Paul A. Clarke ' ...^ I'm having a hard time convincing myself

Re: [PATCH v5 11/23] target/ppc: Add infrastructure for prefixed insns

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:13PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Luis Pires > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/cpu.h | 1 +

Re: [PATCH v5 10/23] target/ppc: Move page crossing check to ppc_tr_translate_insn

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:12PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > With prefixed instructions, the number of instructions > remaining until the page crossing is no longer constant. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst

Re: [PATCH v5 13/23] target/ppc: Implement PNOP

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:15PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > The illegal suffix behavior matches what was observed in a > POWER10 DD2.0 machine. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks.

Re: [PATCH v5 09/23] target/ppc: Introduce macros to check isa extensions

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:11PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > These will be used by the decodetree trans_* functions > to early-exit when the instruction set is not enabled. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst

Re: [PATCH v5 08/23] target/ppc: Use translator_loop_temp_check

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:10PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > The special logging is unnecessary. It will have been done > immediately before in the log file. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst > Reviewed-by:

Re: [PATCH v5 07/23] target/ppc: Mark helper_raise_exception* as noreturn

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:09PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- > target/ppc/helper.h | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v5 06/23] target/ppc: Tidy exception vs exit_tb

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:08PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > We do not need to emit an exit_tb after an exception, > as the latter will exit via longjmp. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to

Re: [PATCH v5 01/23] target/ppc: Introduce gen_icount_io_start

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:03PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Create a function to handle the details for interacting with icount. > > Force the exit from the tb via DISAS_TOO_MANY, which allows chaining > to the next tb, where the code emitted for

Re: [PATCH v5 05/23] target/ppc: Move single-step check to ppc_tr_tb_stop

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:07PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > When single-stepping, force max_insns to 1 in init_disas > so that we exit the translation loop immediately. > > Combine the single-step checks in tb_stop, and give the > gdb exception

Re: [PATCH v5 04/23] target/ppc: Remove DisasContext.exception

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:06PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Now that we have removed all of the fake exceptions, and all real > exceptions exit via DISAS_NORETURN, we can remove this field. > > Signed-off-by: Richard Henderson > Signed-off-by:

Re: [PATCH v5 03/23] target/ppc: Replace POWERPC_EXCP_BRANCH with DISAS_NORETURN

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:05PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > The translation of branch instructions always results in exit from > the TB. Remove the synthetic "exception" after no more uses. > > Signed-off-by: Richard Henderson > Signed-off-by:

Re: [PATCH v5 02/23] target/ppc: Replace POWERPC_EXCP_STOP with DISAS_EXIT_UPDATE

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:04PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Richard Henderson > > Remove the synthetic "exception" after no more uses. > > Signed-off-by: Richard Henderson > Signed-off-by: Matheus Ferst Applied to ppc-for-6.1, thanks. > --- >

RE: [PATCH v6 00/10] Fixed some bugs and optimized some codes for COLO

2021-05-17 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Tuesday, May 18, 2021 3:47 AM > To: Rao, Lei > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; quint...@redhat.com; dgilb...@redhat.com; > pbonz...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [PATCH v6 00/10]

[Bug 1824616] Re: Build succeeds despite flex/bison missing

2021-05-17 Thread MarcH
The warning was supposedly removed by https://github.com/qemu/qemu/commit/67953a379ea5 / https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg03980.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-17 Thread maobibo
Sorry I do not state the background clearly. Page size is 16K on my MIPS machine, and it supports running guest OS in kvm mode and qxl vga card can used for VM. Qxl pci rom size is 8K, smaller than 16K page size on host system, it fails to be added into memslot in kvm mode since size of the pci

Re: [PATCH v2 0/4] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-05-17 Thread Michael S. Tsirkin
On Mon, May 17, 2021 at 10:32:59AM +0200, Greg Kurz wrote: > On Wed, 12 May 2021 17:05:53 +0100 > Stefan Hajnoczi wrote: > > > On Fri, May 07, 2021 at 06:59:01PM +0200, Greg Kurz wrote: > > > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > > > a serious slow down may be

Re: [PATCH v2] floppy: remove dead code related to formatting

2021-05-17 Thread John Snow
On 4/27/21 10:28 PM, Alexander Bulekov wrote: fdctrl_format_sector was added in baca51faff ("updated floppy driver: formatting code, disk geometry auto detect (Jocelyn Mayer)") The single callsite is guarded by a check: fdctrl->data_state & FD_STATE_FORMAT However, the only place where the

[Bug 1912780] Re: QEMU: Null Pointer Failure in fdctrl_read() in hw/block/fdc.c

2021-05-17 Thread John Snow
Took a look at the patch today, I think it might need a change or two but it should be quick to do. I've asked Thomas to move this issue to gitlab so I can keep a closer eye on it. --js -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-17 Thread John Snow
On 1/23/21 5:03 AM, P J P wrote: From: Prasad J Pandit While processing ioport command in 'fdctrl_write_dor', device controller may select a drive which is not initialised with a block device. This may result in a NULL pointer dereference. Add checks to avoid it. Fixes: CVE-2021-20196

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment

2021-05-17 Thread Alistair Francis
On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé wrote: > > The RISCV CPU is migratable since commit f7697f0e629 > ("target/riscv: Add basic vmstate description of CPU"), > so remove an obsolete comment which is now incorrect. > > Reported-by: Richard Henderson > Signed-off-by: Philippe

[PATCH] Fix `lxvdsx` (issue #212)

2021-05-17 Thread Paul A. Clarke
`lxvdsx` is byte-swapping the data it loads, which it should not do. Fix it. Fixes #212. Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c Signed-off-by: Paul A. Clarke mem_idx, MO_TEQ); +tcg_gen_qemu_ld_i64(data, EA, ctx->mem_idx, MO_LEQ); tcg_gen_gvec_dup_i64(MO_Q,

Re: [PATCH v2] fdc: fix floppy boot for Red Hat Linux 5.2

2021-05-17 Thread John Snow
On 4/27/21 2:10 PM, John Snow wrote: The image size indicates it's an 81 track floppy disk image, which we don't have a listing for in the geometry table. When you force the drive type to 1.44MB, it guesses the reasonably close 18/80. When the drive type is allowed to auto-detect or set to 2.88,

[PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree

2021-05-17 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode | 14 ++ target/ppc/translate.c | 52 -- target/ppc/translate/fixedpoint-impl.c.inc | 31 + 3 files changed, 45 insertions(+), 52 deletions(-)

[PATCH v5 21/23] target/ppc: Implement vcfuged instruction

2021-05-17 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v5: - New REQUIRE_ALTIVEC macro; - REQUIRE_INSNS_FLAGS2. --- target/ppc/insn32.decode | 7 target/ppc/translate.c | 1 + target/ppc/translate/vector-impl.c.inc | 56 ++ 3 files

Re: [PATCH v4 0/9] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-17 Thread John Snow
On 5/17/21 4:50 PM, Philippe Mathieu-Daudé wrote: On 5/17/21 9:19 PM, John Snow wrote: On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote: Missing review: #1 Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only

[PATCH v5 22/23] target/ppc: Move addpcis to decodetree

2021-05-17 Thread matheus . ferst
From: Matheus Ferst Reviewed-by: Richard Henderson Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode | 6 ++ target/ppc/translate.c | 9 - target/ppc/translate/fixedpoint-impl.c.inc | 7 +++ 3 files changed, 13 insertions(+), 9

[PATCH v5 20/23] target/ppc: Implement cfuged instruction

2021-05-17 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v5: - Comments to explain helper_cfuged implementation. --- target/ppc/helper.h| 1 + target/ppc/insn32.decode | 4 ++ target/ppc/int_helper.c| 62 ++

[PATCH v5 18/23] target/ppc: Implement prefixed integer store instructions

2021-05-17 Thread matheus . ferst
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Matheus Ferst --- target/ppc/insn64.decode | 12 target/ppc/translate/fixedpoint-impl.c.inc | 4 2 files changed, 16 insertions(+) diff --git a/target/ppc/insn64.decode

  1   2   3   4   5   6   7   >