From: Matheus Ferst
Implements the following PowerISA v3.1 instructions:
setbc: Set Boolean Condition
setbcr: Set Boolean Condition Reverse
setnbc: Set Negative Boolean Condition
setnbcr: Set Negative Boolean Condition Reverse
Signed-off-by: Matheus Ferst
---
v5:
- Style fix;
- Use
From: Richard Henderson
These are all connected by macros in the legacy decoding.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/insn32.decode | 22 ++
target/ppc/translate.c | 85 +-
From: Richard Henderson
These are all connected by macros in the legacy decoding.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/insn32.decode | 37 ++
target/ppc/translate.c | 147 -
From: Richard Henderson
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/insn64.decode | 15 +++
target/ppc/translate/fixedpoint-impl.c.inc | 16
2 files changed, 31 insertions(+)
diff --git a/target/ppc/insn64.decode
From: Richard Henderson
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/insn32.decode | 8
target/ppc/insn64.decode | 12 ++
target/ppc/translate.c | 29 --
From: Richard Henderson
The illegal suffix behavior matches what was observed in a
POWER10 DD2.0 machine.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
v5:
- Remove argument set from PNOP;
- Use no_overlap_group for invalid suffixes.
---
target/ppc/insn64.decode
From: Matheus Ferst
Used in D/DS/X-form load/store implementation.
Signed-off-by: Matheus Ferst
---
include/tcg/tcg-op.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
index 2cd1faf9c4..ef8a008ea7 100644
--- a/include/tcg/tcg-op.h
+++
From: Richard Henderson
Signed-off-by: Luis Pires
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/cpu.h | 1 +
target/ppc/insn32.decode | 18
target/ppc/insn64.decode | 18
From: Richard Henderson
These will be used by the decodetree trans_* functions
to early-exit when the instruction set is not enabled.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/translate.c | 26 ++
1 file changed, 26 insertions(+)
Xtensa cores may or may not have hardware support for unaligned memory
access. On cores with such support pass MO_UNALN in memory access flags
for all operations that would not raise an exception. Drop condition
from xtensa_cpu_do_unaligned_access and replace it with assertions.
Add a test.
From: Richard Henderson
With prefixed instructions, the number of instructions
remaining until the page crossing is no longer constant.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/translate.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff
From: Richard Henderson
The special logging is unnecessary. It will have been done
immediately before in the log file.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
Reviewed-by: Bruno Larsen (billionai)
---
target/ppc/translate.c | 6 +-
1 file changed, 1 insertion(+),
From: Richard Henderson
When single-stepping, force max_insns to 1 in init_disas
so that we exit the translation loop immediately.
Combine the single-step checks in tb_stop, and give the
gdb exception priority over the cpu exception, just as
we already do in gen_lookup_and_goto_ptr.
From: Richard Henderson
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/helper.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/ppc/helper.h b/target/ppc/helper.h
index 513066d54d..ea9f2a236c 100644
--- a/target/ppc/helper.h
+++
From: Richard Henderson
We do not need to emit an exit_tb after an exception,
as the latter will exit via longjmp.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/translate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Richard Henderson
Remove the synthetic "exception" after no more uses.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
linux-user/ppc/cpu_loop.c | 3 ---
target/ppc/cpu.h | 1 -
target/ppc/translate.c| 24 +++-
3 files changed, 7
From: Richard Henderson
The translation of branch instructions always results in exit from
the TB. Remove the synthetic "exception" after no more uses.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
linux-user/ppc/cpu_loop.c | 3 ---
target/ppc/cpu.h | 2 --
From: Richard Henderson
Now that we have removed all of the fake exceptions, and all real
exceptions exit via DISAS_NORETURN, we can remove this field.
Signed-off-by: Richard Henderson
Signed-off-by: Matheus Ferst
---
target/ppc/translate.c | 30 --
1 file
On 5/17/21 9:19 PM, John Snow wrote:
> On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote:
>> Missing review: #1
>>
>> Hi,
>>
>> The floppy disc controllers pulls in irrelevant devices (sysbus in
>> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
>>
>> This series clean that by
From: Richard Henderson
Create a function to handle the details for interacting with icount.
Force the exit from the tb via DISAS_TOO_MANY, which allows chaining
to the next tb, where the code emitted for gen_tb_start() will
determine if we must exit. We can thus remove any matching
From: Matheus Ferst
This series provides the basic infrastructure for adding the new 32/64-bit
instructions in Power ISA 3.1 to target/ppc.
v5:
- Rebase on ppc-for-6.1;
- Change copyright line from new files;
- Remove argument set from PNOP;
- Add comments to explain helper_cfuged
> From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org]
> On Behalf Of Yanan Wang
> Sent: Sunday, May 16, 2021 11:29 AM
> To: Peter Maydell ; Andrew Jones
> ; Michael S . Tsirkin ; Igor Mammedov
> ; Shannon Zhao ; Alistair
> Francis ; David Gibson
> ; qemu-devel@nongnu.org;
On Tue, 20 Apr 2021 23:15:37 +0800
Zhang Chen wrote:
> Use connection protocol,src port,dst port,src ip,dst ip as the key
> to bypass certain network traffic in COLO compare.
>
> Signed-off-by: Zhang Chen
> ---
> net/net.c | 160 +-
> 1 file
On Tue, 20 Apr 2021 23:15:32 +0800
Zhang Chen wrote:
> Since the real user scenario does not need COLO to monitor all traffic.
> Add colo-passthrough-add and colo-passthrough-del to maintain
> a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands.
> Except protocol field is
Hi,
Thanks for the patch, and apologies for not reviewing earlier
versions.
On Fri, May 07, 2021 at 04:00:58PM +0800, Ziqiao Kong wrote:
> Changes since v3:
> - Split the long patches to series to make review easier.
> - Fix the coding style problems in v3.
>
> Changes since v2:
> - Change
On Fri, May 07, 2021 at 04:00:56PM +0800, Ziqiao Kong wrote:
> Move the float translation case to a new block by a new pair of braces.
If you are just adding braces around the code, do you really need
to reindent all the code? I don't see any mention of `switch`
statements on style.rst, but I
On Tue, 20 Apr 2021 23:15:36 +0800
Zhang Chen wrote:
> Add passthrough list for each CompareState.
>
> Signed-off-by: Zhang Chen
> ---
> net/colo-compare.c | 28
> net/colo-compare.h | 12
> 2 files changed, 40 insertions(+)
>
> diff --git
On Mon, May 17, 2021 at 03:18:56PM -0400, Eduardo Habkost wrote:
> CCing Build system architecture maintainer (Daniel).
Oops, I was misled by the subsection title. Daniel is
responsible only for the build system documentation.
Do we have any volunteers willing to be listed as reviewers for
On Tue, 20 Apr 2021 23:15:35 +0800
Zhang Chen wrote:
> Rename structure with COLO index and move it to .h file,
> It make other modules can reuse COLO code.
Hi,
There are some definitions that don't need to be moved into the header,
more comments below.
In general I think the new passthrough
Xtensa cores may or may not have hardware support for unaligned memory
access. On cores with such support pass MO_UNALN in memory access flags
for all operations that would not raise an exception. Drop condition
from xtensa_cpu_do_unaligned_access and replace it with assertions.
Add a test.
17.05.2021 19:57, Max Reitz wrote:
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote:
No reason to tolerate bdrv_get_info() errors except for ENOTSUP. Let's
just error-out, it's simpler and safer.
Hm, doesn’t look that much simpler to me. Not sure how much safer it is,
because the point
+Stefan
I have a question about ratelimit_set_speed() below:
On Fri, Apr 30, 2021 at 06:33:05PM +0800, Chenyi Qiang wrote:
> A bus lock is acquired through either split locked access to writeback
> (WB) memory or any locked access to non-WB memory. It is typically >1000
> cycles slower than an
In current code there are no calls to pa_stream_get_latency()
or pa_stream_get_time() to receive latency or time information.
Remove the flags PA_STREAM_INTERPOLATE_TIMING and
PA_STREAM_AUTO_TIMING_UPDATE which instruct PulseAudio to
calculate this information in regular intervals.
Merge the #ifdef DEBUG code with the if statement a few lines
above to avoid bit rot.
Suggested-by: Gerd Hoffmann
Signed-off-by: Volker Rümelin
---
audio/alsaaudio.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index
A small collection of patches for the audio subsystem.
It took me one evening to get a working audio system with JACK.
I never associated the in-(NULL) and out-(NULL) devices in the
patch bay with qemu.
With best regards,
Volker
Volker Rümelin (4):
alsaaudio: remove #ifdef DEBUG to avoid bit
17.05.2021 19:05, Max Reitz wrote:
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote:
We are going to convert backup_top to full featured public filter,
which can be used in separate of backup job. Start from renaming from
"how it used" to "what it does".
Is this safe? The name was
On Thu, 8 Apr 2021 23:20:46 -0400
leirao wrote:
> From: Rao, Lei
>
> Changes since v5:
> --Replaced g_slice_new calls with g_slice_new0.
>
> Changes since v4:
> --Replaced qemu_mutex_lock calls with QEMU_LOCK_GUARD in
> colo_bitmap_clear_dirty.
> --Modify some minor
Currently with jackaudio client name and qemu guest name unset,
the JACK client names are out-(NULL) and in-(NULL). These names
are user visible in the patch bay. Replace the function call to
qemu_get_vm_name() with a call to audio_application_name() which
replaces NULL with "qemu" to have more
Xtensa cores may or may not have hardware support for unaligned memory
access. On cores with such support pass MO_UNALN in memory access flags
for all operations that would not raise an exception. Drop condition
from xtensa_cpu_do_unaligned_access and replace it with assertions.
Add a test.
Move the code to generate the pa_context_new() application name
argument to a function in audio/audio.c. The new function
audio_application_name() will also be used in the jackaudio
backend.
Signed-off-by: Volker Rümelin
---
audio/audio.c | 9 +
audio/audio_int.h | 2 ++
This still triggers with current QEMU development version ... marking as
"Confirmed" ... Alexander, could you please move this ticket to the new
issue tracker at gitlab?
** Changed in: qemu
Status: New => Confirmed
** Tags added: fuzzer net
--
You received this bug notification because
This does not crash for me anymore, so I guess it has been fixed
already. Could you still reproduce the crash with the latest version of
QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On 1/23/21 12:52 PM, Alexander Bulekov wrote:
On 210123 1247, Alexander Bulekov wrote:
Hello,
Here is a reproducer for this bug found by the OSS-Fuzz fuzzer:
cat << EOF | qemu-system-i386 -display none -machine accel=qtest \
-m 512M -machine pc -device floppy,unit=1,id=floppy0,drive=disk0 \
CCing Build system architecture maintainer (Daniel).
On Sat, May 15, 2021 at 07:37:04PM +0200, Philippe Mathieu-Daudé wrote:
> Various Kconfig fixes when building stand-alone machine binaries.
Who should merge this once it's ready?
>
> Since v1:
> - Fixed Pegasos2 machine
> - Removed
Patchew URL: https://patchew.org/QEMU/20210517181424.8093-1-laur...@vivier.eu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210517181424.8093-1-laur...@vivier.eu
Subject: [PULL 00/59] Linux user for 6.1 patches
On 5/17/21 2:39 PM, Philippe Mathieu-Daudé wrote:
Missing review: #1
Hi,
The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
This series clean that by extracting each device in its own file,
adding the
** Bug watch removed: Sourceware.org Bugzilla #27543
https://sourceware.org/bugzilla/show_bug.cgi?id=27543
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1796520
Title:
autogen crashes on
On Mon, 17 May 2021 12:40:43 +0100
Stefan Hajnoczi wrote:
> On Fri, May 14, 2021 at 11:15:18AM -0400, Steven Sistare wrote:
> > On 5/14/2021 7:53 AM, Stefan Hajnoczi wrote:
> > > On Thu, May 13, 2021 at 04:21:15PM -0400, Steven Sistare wrote:
> > >> On 5/12/2021 12:42 PM, Stefan Hajnoczi
On Mon, 17 May 2021 at 18:37, Alex Bennée wrote:
> Luis Machado writes:
> > Right. We don't support reverse step/next/continue for remote targets.
> > I think this would be the most appropriate way to implement this
> > feature in GDB. But it is not trivial.
>
> You do because
We manage cleaning up this resource ourselves. Pylint should shush.
Signed-off-by: John Snow
---
python/qemu/console_socket.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py
index 87237bebef7..8c4ff598ad7 100644
---
The QEMU project is currently moving its bug tracking to another system.
For this we need to know how to transfer the bug to the new system if
(if still necessary). Thus we're setting the status to "Incomplete" now.
In the unlikely case that the bug has already been fixed in the final
6.0 release
I'm closing this since it's very unlikely that we get a Solaris VM
image, since they are not available for free, as far as I know. Maybe
somebody could contribute an illumos-based image one day, but that's
nothing that we have to track in the bug tracker, I think.
** Changed in: qemu
On 5/12/21 7:12 PM, John Snow wrote:
Based-on: <20210512214642.2803189-1-js...@redhat.com>
CI: https://gitlab.com/jsnow/qemu/-/pipelines/302010131
GitLab: https://gitlab.com/jsnow/qemu/-/tree/python-package-mk3
MR: https://gitlab.com/jsnow/qemu/-/merge_requests/4
Patchset updated and rebased
One less file resource to manage, and it helps quiet some pylint >=
2.8.0 warnings about not using a with-context manager for the open call.
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
---
python/qemu/machine.py | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
I think there is quite a bit of information missing here? Which host OS
/ distribution are we talking about here? Which parameters were used for
"configure"? Which QEMU version has been used? Is it still reproducible
with the latest version? ... thus I wonder whether this should get
closed, or
Thanks for moving the ticket to gitlab! ... so I'm closing this on
Launchpad now.
** Changed in: qemu
Status: Incomplete => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1883268
Fixes pylint warnings.
Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
Reviewed-by: Philippe Mathieu-Daudé
---
python/qemu/console_socket.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py
index
gitlab CI: https://gitlab.com/jsnow/qemu/-/pipelines/304224309
branch: https://gitlab.com/jsnow/qemu/-/commits/python-package-pre-cleanup
This series serves as a pre-requisite for packaging the python series
and getting the linters running via CI. The first patch fixes a linter
error we've had
Moved here:
https://gitlab.com/qemu-project/qemu/-/issues/334
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #334
https://gitlab.com/qemu-project/qemu/-/issues/334
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
We handle this resource rather meticulously in
shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in
_do_shutdown().
Quiet this pylint warning here.
Signed-off-by: John Snow
---
python/qemu/machine.py | 3 +++
1 file changed, 3 insertions(+)
diff --git
The QEMU project is currently moving its bug tracking to another system.
Is there still anything left to do here? If so, please provide the test case
and switch the state back to "New" or "Confirmed", or open a new ticket in the
new bug tracker here: https://gitlab.com/qemu-project/qemu/-/issues
On Mon, 17 May 2021, BALATON Zoltan wrote:
On Mon, 17 May 2021, Alexey Kardashevskiy wrote:
On 5/17/21 09:34, BALATON Zoltan wrote:
On Sat, 15 May 2021, BALATON Zoltan wrote:
On Sat, 15 May 2021, BALATON Zoltan wrote:
On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote:
[snip]
vof_claim
This ticket has been moved here (thanks, Gautam):
https://gitlab.com/qemu-project/qemu/-/issues/331
... thus I'm closing this on Launchpad now.
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #331
https://gitlab.com/qemu-project/qemu/-/issues/331
** Changed in: qemu
Status:
use run() instead of Popen() -- to assert to pylint that we are not
forgetting to close a long-running program.
Signed-off-by: John Snow
---
python/qemu/machine.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
isa_superio_realize() calls isa_fdc_init_drives(), which is defined
in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol.
Reported-by: John Snow
Fixes: c0ff3795143 ("Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c")
Signed-off-by: Philippe Mathieu-Daudé
---
hw/isa/Kconfig |
On 5/17/21 8:19 PM, John Snow wrote:
> On 5/17/21 2:04 PM, John Snow wrote:
>> On 5/17/21 1:49 PM, Philippe Mathieu-Daudé wrote:
>>> Some machines use floppy controllers via the SysBus interface,
>>> and don't need to pull in all the ISA code.
>>> Extract the ISA specific code to a new unit:
There is only one call site for fdctrl_init_sysbus(), and this
function is specific to the jazz machines, not part of the
SYSBUS_FDC API. Move it locally with the machine code, and
remove its declaration in "hw/block/fdc.h".
Suggested-by: Mark Cave-Ayland
Reviewed-by: Mark Cave-Ayland
QDev properties to be set before the device is realized should
be exposed as a Property with a DEFINE_PROP_XXX() macro, then
accessed with the equivalent qdev_prop_set_xxx() API.
Do this with the FDCtrlSysBus 'dma-channel' property: convert
it to int32_t, default-initialize with
On Sat, 15 May 2021 at 11:07, Laurent Vivier wrote:
>
> The following changes since commit 3e9f48bcdabe57f8f90cf19f01bbbf3c86937267:
>
> Merge remote-tracking branch
> 'remotes/alistair/tags/pull-riscv-to-apply-20210511' into staging (2021-05-12
> 17:31:52 +0100)
>
> are available in the Git
There is only one call site for sun4m_fdctrl_init(), and this
function is specific to the sun4m machines, not part of the
SYSBUS_FDC API. Move it locally with the machine code, and
remove its declaration in "hw/block/fdc.h".
Suggested-by: Mark Cave-Ayland
Reviewed-by: Mark Cave-Ayland
FDCtrlSysBus's FDCtrl state is a private field. However it is
accessed by the public fdctrl_init_sysbus() and sun4m_fdctrl_init()
methods. To be able to move them out of fdc-sysbus.c, first add
the sysbus_fdc_init_drives() method and use it in these 2 functions.
Reviewed-by: Mark Cave-Ayland
Shift the open() call later so that the pylint pragma applies *only* to
that one open() call. Add a note that suggests why this is safe: the
resource is unconditionally cleaned up in _post_shutdown().
_post_shutdown is called after failed launches (see launch()), and
unconditionally after every
Some machines use floppy controllers via the SysBus interface,
and don't need to pull in all the SysBus code.
Extract the SysBus specific code to a new unit: fdc-sysbus.c,
and add a new Kconfig symbol: "FDC_SYSBUS".
Reviewed-by: John Snow
Acked-by: Mark Cave-Ayland
Reviewed-by: Mark Cave-Ayland
Some machines use floppy controllers via the SysBus interface,
and don't need to pull in all the ISA code.
Extract the ISA specific code to a new unit: fdc-isa.c, and
add a new Kconfig symbol: "FDC_ISA".
Reviewed-by: John Snow
Acked-by: Mark Cave-Ayland
Reviewed-by: Mark Cave-Ayland
From: Ilya Leoshkevich
Provide the following definitions required by the common code:
* ELF_NREG: with the value of sizeof(s390_regs) / sizeof(long).
* target_elf_gregset_t: define it like all the other arches do.
* elf_core_copy_regs(): similar to kernel's s390_regs_get().
* USE_ELF_CORE_DUMP.
From: Richard Henderson
Do not access a field that may not be present. This will
become an issue when sharing more code in the next patch.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-Id:
Reviewed-by: John Snow
Acked-by: Mark Cave-Ayland
Reviewed-by: Mark Cave-Ayland
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/fdc.c| 7 +--
hw/block/trace-events | 1 +
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index
This ticket has been moved here (thanks, Dan!):
https://gitlab.com/qemu-project/qemu/-/issues/330
... so I'm closing this on Launchpad now.
** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #330
https://gitlab.com/qemu-project/qemu/-/issues/330
** Changed in: qemu
Status:
From: Richard Henderson
The value of ka_restorer needs to be saved in sigact_table.
At the moment, the attempt to save it in do_syscall is
improperly clobbering user memory.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Message-Id:
We want to extract ISA/SysBus code from the generic fdc.c file.
First, declare the prototypes we will access from the new units
into a new local header: "fdc-internal.h".
Acked-by: Mark Cave-Ayland
Reviewed-by: Mark Cave-Ayland
Signed-off-by: Philippe Mathieu-Daudé
---
hw/block/fdc-internal.h
Missing review: #1
Hi,
The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
This series clean that by extracting each device in its own file,
adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.
From: Richard Henderson
Use ka_restorer, in line with TARGET_ARCH_HAS_KA_RESTORER
vs TARGET_ARCH_HAS_SA_RESTORER, since Alpha passes this
field as a syscall argument.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Message-Id: <20210422230227.314751-3-richard.hender...@linaro.org>
From: Ilya Leoshkevich
The current code dumps the memory between arg_start and arg_end,
which contains the argv pointers. This results in the
Core was generated by ``
message when opening the core file in GDB. This is because the code is
supposed to dump the actual arg strings. Fix by
From: Daniel P. Berrangé
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Signed-off-by: Daniel P.
On 5/17/21 2:04 PM, John Snow wrote:
On 5/17/21 1:49 PM, Philippe Mathieu-Daudé wrote:
Some machines use floppy controllers via the SysBus interface,
and don't need to pull in all the ISA code.
Extract the ISA specific code to a new unit: fdc-isa.c, and
add a new Kconfig symbol: "FDC_ISA".
From: Richard Henderson
We incorrectly used the offset of the non-rt sigframe.
Reviewed-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Message-Id: <20210422230227.314751-2-richard.hender...@linaro.org>
Signed-off-by: Laurent
From: Giuseppe Musacchio
Signed-off-by: Giuseppe Musacchio
Reviewed-by: Laurent Vivier
Message-Id: <20210503174159.54302-2-thatle...@gmail.com>
Signed-off-by: Laurent Vivier
---
linux-user/strace.list | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-user/strace.list
From: Richard Henderson
This means that we can share the TARGET_NR_rt_sigaction code,
and the target_rt_sigaction structure is unused. Untangling
the ifdefs so that target_sigaction can be shared will wait
until the next patch.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
From: Richard Henderson
At point of usage, it's not immediately obvious that
we don't need a loop to copy these arrays.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-14-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
From: Richard Henderson
Initialize variables instead of elses.
Use an else instead of a goto.
Add braces.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210422230227.314751-8-richard.hender...@linaro.org>
Signed-off-by: Laurent
From: Richard Henderson
Using the host address of >sregs is incorrect.
We need the guest address.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-7-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
linux-user/s390x/signal.c |
From: Giuseppe Musacchio
The implicit cast from abi_long to size_t may introduce an intermediate
unwanted sign-extension of the value for 32bit targets running on 64bit
hosts.
Signed-off-by: Giuseppe Musacchio
Reviewed-by: Laurent Vivier
Message-Id:
From: Richard Henderson
Reorder the function bodies to correspond to the kernel source.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-15-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
linux-user/s390x/signal.c | 63
From: Richard Henderson
There's no longer a difference between the alpha code and
the generic code.
There is a type difference in target_old_sigaction.sa_flags,
which can be resolved with a very much smaller ifdef, which
allows us to finish sharing the target_sigaction definition.
From: Richard Henderson
Directly reading sc->regs.psw.addr misses the bswap
that may be performed by __get_user.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-6-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
From: Richard Henderson
The function cannot fail.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-5-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
linux-user/s390x/signal.c | 14 +++---
1 file changed, 3
From: Richard Henderson
The "save" routines copied from the kernel, which are currently
commented out, are unnecessary in qemu. We can copy from env
where the kernel needs special instructions. Fix comment style.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id:
From: Richard Henderson
Note that PSW_ADDR_{64,32} are called PSW_MASK_{EA,BA}
in the kernel source.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-11-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
From: Richard Henderson
The original value of frame_addr is still required for
its use in the call to unlock_user_struct below.
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-13-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
From: Richard Henderson
Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
Message-Id: <20210428193408.233706-10-richard.hender...@linaro.org>
Signed-off-by: Laurent Vivier
---
linux-user/s390x/signal.c | 29 -
1 file changed, 8 insertions(+), 21
101 - 200 of 629 matches
Mail list logo
