On 21/07/2021 00.13, Jose R. Ziviani wrote:
Hello!
This patch gives the ability to build TCG builtin even if
--enable-modules is selected. This is useful to have a base
QEMU with TCG native product but still using the benefits of
modules.
Could you please elaborate why this is required? Did
From: Christina Wang
In the legacy RX descriptor mode, VLAN tag was saved to d->special
by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but
it was then zeroed out again at the end of the call, which is wrong.
Fixes: c89d416a2b0f ("e1000e: Don't zero out buffer address in rx
From: Christina Wang
The initial value of VLAN Ether Type (VET) register is 0x8100, as per
the manual and real hardware.
While Linux e1000e driver always writes VET register to 0x8100, it is
not always the case for everyone. Drivers relying on the reset value
of VET won't be able to transmit
From: Christina Wang
The initial value of VLAN Ether Type (VET) register is 0x8100, as per
the manual and real hardware.
While Linux e1000 driver always writes VET register to 0x8100, it is
not always the case for everyone. Drivers relying on the reset value
of VET won't be able to transmit and
I've tried and this patch is able to detach all the virtual console after we
launch the qemu. However, I think we need to filter out other terminal that are
not related to view such as compatmonitor(), serial and parallel.
Also, I think we can have the detach specific to virtio-pci view
Signed-off-by: Richard Zak
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 232c54dcc1..163af793e9 100755
--- a/configure
+++ b/configure
@@ -768,7 +768,8 @@ SunOS)
;;
Haiku)
haiku="yes"
-
migration uses QIOChannel typed qemufiles. In follow up patches, we'll need
the capability to identify this fact, so that we can get the backing QIOChannel
from a QEMUFile.
We can also define types for QEMUFile but so far since we only need to be able
to identify QIOChannel, introduce a boolean
There're plenty of places in migration/* that checks against either socket or
tls typed ioc for yank operations. Provide two helpers to hide all these
information.
Signed-off-by: Peter Xu
---
migration/channel.c | 15 ++-
migration/multifd.c | 8 ++--
We have a logic in await_return_path_close_on_source() that we will explicitly
shutdown the socket when migration encounters errors. However it could be racy
because from_dst_file could have been reset right after checking it but before
passing it to qemu_file_shutdown() by the rp_thread.
Fix it
Patch 1 fixes a possible race that migration thread can accidentally skip
join() of rp_thread even if the return thread is enabled. Patch 1 is suspected
to also be the root cause of the recent hard-to-reproduce migration-test
failure here reported by PMM:
It's efficient, but hackish to call yank unregister calls in channel_close(),
especially it'll be hard to debug when qemu crashed with some yank function
leaked.
Remove that hack, but instead explicitly unregister yank functions at the
places where needed, they are:
(on src)
-
It's possible that the migration thread skip the join() of the rp_thread in
below race and crash on src right at finishing migration:
migration_thread rp_thread
-
migration_completion()
This is a very rudimentary conversion from .txt to .rst changing as
little as possible, but getting it to render somewhat nicely; without
using any Sphinx directives. (It is 'native' ReST.)
Further patches will add cross-references and Sphinx-specific extensions
to make it sparkle.
Up until this point we only handled local compilers or assumed we had
everything in the container. This falls down when we are building QEMU
inside the container.
This special handling only affects tricore for now but I put it in a
case just in case we add any other "special" targets. Setting
While we are at it add a brief preamble that explains some of the
common concepts in QEMU's device emulation which will hopefully lead
to less confusing about our dizzying command line options.
Signed-off-by: Alex Bennée
Message-Id: <20210714182056.25888-3-alex.ben...@linaro.org>
Cc: Markus
Mostly, add ``literal`` markers to a lot of things like C types, add
code blocks, and fix the way a few things render.
Signed-off-by: John Snow
---
docs/devel/qapi-code-gen.rst | 172 ++-
1 file changed, 90 insertions(+), 82 deletions(-)
diff --git
Add clickables to many places.
Signed-off-by: John Snow
---
docs/devel/qapi-code-gen.rst | 107 +++
1 file changed, 58 insertions(+), 49 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index 4a28118d951..8c77af2d076 100644
From: Thomas Huth
While there might have been bigger differnces between the -base and
the -xcode images in the beginning, they almost vanished in the
current builds, e.g. when comparing the output of the "configure"
step after cleaning up the differences due to temporary path names,
I only get:
For some reason Alexander's contributions were not getting grouped
from the plain "edu" mapping.
Signed-off-by: Alex Bennée
Reviewed-by: Alexander Bulekov
Message-Id: <20210714182056.25888-20-alex.ben...@linaro.org>
---
contrib/gitdm/group-map-academics | 3 +++
1 file changed, 3 insertions(+)
Warner confirmed he works for Netflix on IRC.
Signed-off-by: Alex Bennée
Reviewed-by: Warner Losh
Message-Id: <20210714182056.25888-19-alex.ben...@linaro.org>
---
contrib/gitdm/group-map-netflix | 5 +
gitdm.config| 1 +
2 files changed, 6 insertions(+)
create mode
Patch 1 does (roughly) the bare minimum, patch 2 adds some formatting,
and patch 3 adds cross-references.
John Snow (3):
docs: convert qapi-code-gen.txt to ReST
docs/qapi-code-gen: Beautify formatting
docs/qapi-code-gen: add cross-references
docs/devel/index.rst |
From: Philippe Mathieu-Daudé
All jobs depending on 'docker-opensbi' job must use at most all
the rules that triggers it. The simplest way to ensure that
is to always use the same rules. Extract all the rules to a
reusable section, and include this section (with the 'extends'
keyword) in both
In user-mode emulation there is a small race between preexit_cleanup
and exit_group() which means we may end up calling instrumented
instructions before the kernel reaps child threads. To solve this we
implement a new helper which ensures the callbacks are flushed along
with any translations
Lets try and keep them that way.
Signed-off-by: Alex Bennée
Message-Id: <20210714182056.25888-10-alex.ben...@linaro.org>
---
gitdm.config | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gitdm.config b/gitdm.config
index 7378238c20..a3542d2fc7 100644
--- a/gitdm.config
Both tests use the same kernel command line arguments, so there's no
need to have a common and then an additional set of arguments.
Signed-off-by: Cleber Rosa
Message-Id: <20210714174051.28164-5-cr...@redhat.com>
Reviewed-by: Willian Rampazzo
Signed-off-by: Cleber Rosa
---
Like previously done with the arch tags, all tests use the same CPU
value so it's possible to combine them at the class level.
Signed-off-by: Cleber Rosa
Message-Id: <20210714174051.28164-4-cr...@redhat.com>
Reviewed-by: Willian Rampazzo
Signed-off-by: Cleber Rosa
---
Since efe30d501 there's a shorthand for requiring specific
accelerators, and canceling the test if it's not available.
Signed-off-by: Cleber Rosa
Message-Id: <20210714174051.28164-2-cr...@redhat.com>
Reviewed-by: Willian Rampazzo
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtio-gpu.py |
The test class in question is x86_64 specific, so it's possible to set
the tags at the class level.
Signed-off-by: Cleber Rosa
Message-Id: <20210714174051.28164-3-cr...@redhat.com>
Reviewed-by: Willian Rampazzo
Signed-off-by: Cleber Rosa
---
tests/acceptance/virtio-gpu.py | 3 +--
1 file
Since 49afbca3b, the use of an optional virgl renderer is not
available anymore, and since b36eb8860f, the way to choose a GL based
rendered is to use the "virtio-vga-gl" device.
Signed-off-by: Cleber Rosa
Message-Id: <20210714174051.28164-6-cr...@redhat.com>
Reviewed-by: Willian Rampazzo
Also ensure Li's canonical gmail address is used.
Signed-off-by: Alex Bennée
Acked-by: Li Qiang
Acked-by: Chetan Pant
Acked-by: Akihiko Odaki
Message-Id: <20210714182056.25888-22-alex.ben...@linaro.org>
---
contrib/gitdm/aliases | 3 +++
contrib/gitdm/group-map-individuals | 3
From: Mahmoud Mandour
This manifests itself when associativity degree is greater than the
number of sets and FIFO is used, otherwise it's also a memory leak
whenever FIFO was used.
Signed-off-by: Mahmoud Mandour
Reviewed-by: Alex Bennée
Message-Id:
From: Aaron Lindsay
The address calculation for IO regions introduced by
commit 787148bf928a54b5cc86f5b434f9399e9737679c
Author: Aaron Lindsay
plugins: Expose physical addresses instead of device offsets
is not always accurate. Use the more correct
We inadvertently added a symbol clash causing the build not to include
the testboard needed for check-tcg.
Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig")
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Richard Henderson
Signed-off-by: Alex Bennée
Reviewed-by: Christian Schoenebeck
Message-Id: <20210714182056.25888-15-alex.ben...@linaro.org>
---
contrib/gitdm/domain-map | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map
index 5ac8288716..e42861cd11 100644
---
Rather than base of the shared Debian 10 container which would require
us to bring in even more dependencies just bring in what is needed for
building tricore-softmmu in GitLab. We don't even remove the container
from the DOCKER_PARTIAL_IMAGES lest we cause more confusion.
Signed-off-by: Alex
From: Mahmoud Mandour
It's not necessary to lock the address translation portion of the
vcpu_mem_access callback.
Signed-off-by: Mahmoud Mandour
Reviewed-by: Alex Bennée
Message-Id: <20210714172151.8494-3-ma.mando...@gmail.com>
Signed-off-by: Alex Bennée
---
contrib/plugins/cache.c | 3 +--
While we do mention some of this stuff in the various daemons and
manuals the subtleties of the socket and memory sharing are sometimes
missed. This document attempts to give some background on vhost-user
daemons in general terms.
Signed-off-by: Alex Bennée
Reviewed-by: Stefan Hajnoczi
From: Yang Zhong
Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
qemu_ram_alloc_from_fd()")
Signed-off-by: Yang Zhong
Reviewed-by: David Hildenbrand
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Pankaj Gupta
Reviewed-by: Peter Xu
Message-Id:
By providing kernel and initrd hashes, the test guarantees the
integrity of the images used and avoids the warnings set by
fetch_asset() when hashes are lacking.
Signed-off-by: Cleber Rosa
Message-Id: <20210714174051.28164-7-cr...@redhat.com>
Reviewed-by: Willian Rampazzo
Signed-off-by: Cleber
From: Mahmoud Mandour
Signed-off-by: Mahmoud Mandour
Reviewed-by: Alex Bennée
Message-Id: <20210714172151.8494-7-ma.mando...@gmail.com>
Signed-off-by: Alex Bennée
---
contrib/plugins/cache.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/plugins/cache.c
I think this mainly comes from kernel-doc stuff imported into the QEMU
tree.
Signed-off-by: Alex Bennée
Cc: Jonathan Corbet
Message-Id: <20210714182056.25888-14-alex.ben...@linaro.org>
---
contrib/gitdm/domain-map | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/gitdm/domain-map
The following changes since commit c04b4d9e6b596ead3cf6046a9243fbfee068ef33:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2021-07-20 16:59:33 +0100)
are available in the Git repository at:
https://gitlab.com/cleber.gnu/qemu.git/ tags/python-next-pull-request
It was pointed out in review of the previous patch that the if leg
isn't needed as the for loop will not enter on an empty $device_archs.
Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the
build")
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-Id:
Signed-off-by: Alex Bennée
Reviewed-by: Kirti Wankhede
Cc: Yishai Hadas
Message-Id: <20210714182056.25888-18-alex.ben...@linaro.org>
---
contrib/gitdm/domain-map | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map
index e42861cd11..2800d9f986
It makes sense to put our various interns in a group so we can see the
overall impact of GSoC and Outreachy on the project.
Signed-off-by: Alex Bennée
Reviewed-by: Mahmoud Mandour
Cc: Ahmed Karaman
Cc: César Belley
Message-Id: <20210714182056.25888-21-alex.ben...@linaro.org>
---
Luis acked on IRC:
#qemu@znc-oftc_2021-07-13.txt:[15:00:02] stsquad: "eldorado.org.br
Eldorado" is fine
Signed-off-by: Alex Bennée
Acked-by: Luis Pires
Cc: Bruno Larsen (billionai)
Message-Id: <20210714182056.25888-12-alex.ben...@linaro.org>
---
contrib/gitdm/domain-map | 1 +
1 file
This mostly affects Reported-by: tags
Signed-off-by: Alex Bennée
Message-Id: <20210714182056.25888-9-alex.ben...@linaro.org>
---
contrib/gitdm/group-map-robots | 7 +++
gitdm.config | 3 +++
2 files changed, 10 insertions(+)
create mode 100644
On Sun, Jul 18, 2021 at 11:35:35PM -0700, Kasireddy, Vivek wrote:
> Hi DW,
>
> > eb_fb_blit needs more parameters which describe x and y offsets and width
> > and height of the actual scanout to specify the size and cordination of
> > partial image to blit in the guest fb in case the guest fb
As per discussion at:
http://patchwork.ozlabs.org/project/qemu-devel/patch/20201004180443.2035359-19-f4...@amsat.org/
I've added Bin's personal email as an individual contributor.
Signed-off-by: Alex Bennée
Acked-by: Bin Meng
Cc: Ruimei Yan
Cc: Xuzhou Cheng
Message-Id:
Signed-off-by: Alex Bennée
Acked-by: Corey Minyard
Message-Id: <20210714182056.25888-8-alex.ben...@linaro.org>
---
contrib/gitdm/domain-map | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map
index 0074da618f..efbbb15643 100644
---
From: Viresh Kumar
Update .gitignore to ignore .swp and .patch files.
Signed-off-by: Viresh Kumar
Signed-off-by: Alex Bennée
Reviewed-by: Alex Bennée
Message-Id:
<79262dbe1f7888eb02e1911501eebafa6f2f6400.1616583806.git.viresh.ku...@linaro.org>
Message-Id:
Fixes: 49a6f3bffb ("target/arm: Correct the encoding of MDCCSR_EL0 and
DBGDSCRint")
Fixes: 5a07192a04 ("target/i386: Fix handling of k_gs_base register in 32-bit
mode in gdbstub")
Signed-off-by: Alex Bennée
Cc: Nick Hudson
Cc: Marek Dolata
Message-Id:
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Cc: Yuval Shaia
Message-Id: <20210714182056.25888-6-alex.ben...@linaro.org>
---
contrib/gitdm/aliases | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/gitdm/aliases b/contrib/gitdm/aliases
index c1e744312f..c6ed215e68
Minwoo's work from their personal address are treated as personal
contributions.
Signed-off-by: Alex Bennée
Acked-by: Klaus Jensen
Cc: Gollu Appalanaidu
Cc: Minwoo Im
Message-Id: <20210714182056.25888-11-alex.ben...@linaro.org>
---
vPrePr
- removed extraneous groupmap
---
Hi,
This is a roll-up of all the various patches I've been posting
targeting the 6.1 bug fixes. So far they include:
- gitdm metadata updates (dropped un-acked mappings)
- documentation on driver/device configuration
- some miscellaneous plugin bug fixes
- fix and CI test for Tricore
On Sun, Jul 18, 2021 at 11:17:00PM -0700, Kasireddy, Vivek wrote:
> Hi DW,
>
> > When guest is running Linux/X11 with extended multiple displays mode
> > enabled,
> > the guest shares one scanout resource each time containing whole surface
> > rather than sharing individual display output
The function module_load_one() fills a hash table with modules that
were successfuly loaded. However, that table is a static variable of
module_load_one(). This patch changes it and creates a function that
informs whether a given module was loaded or not.
It also creates a function that returns
module_object_class_by_name() calls module_load_qom_one if the object
is provided by a dynamically linked library. Such library might not be
available at this moment - for instance, it can be a package not yet
installed. Thus, instead of assert error messages, this patch outputs
more friendly
The main objective here is to fix an user issue when trying to load TCG
that was built as module, but it's not installed or found in the library
path.
For example:
$ ./qemu-system-x86_64 -machine q35 -accel tcg -kernel /boot/vmlinuz
...
On 7/20/21 11:53 PM, Philippe Mathieu-Daudé wrote:
> On 7/20/21 11:08 PM, Richard Henderson wrote:
>> On 7/20/21 10:56 AM, Peter Maydell wrote:
>>> On Tue, 20 Jul 2021 at 20:54, Richard Henderson
>>> wrote:
This will allow a breakpoint hack to move out of AVR's translator.
On Tue, Jul 20, 2021 at 03:42:16PM +0200, Thomas Huth wrote:
> On 19/07/2021 23.41, Dongwon Kim wrote:
> > With "detach-all=on" for display, all VCs are detached from the beginning.
> > This is useful when there are multiple displays assigned to a guest OS.
>
> Can you elaborate? (i.e. why is it
Philippe Mathieu-Daudé writes:
> All jobs depending on 'docker-opensbi' job must use at most all
> the rules that triggers it. The simplest way to ensure that
> is to always use the same rules. Extract all the rules to a
> reusable section, and include this section (with the 'extends'
>
Aaron Lindsay writes:
> The address calculation for IO regions introduced by
>
> commit 787148bf928a54b5cc86f5b434f9399e9737679c
> Author: Aaron Lindsay
> plugins: Expose physical addresses instead of device offsets
Queued to for-6.1/fixes-for-rc1, thanks.
>
> is not always accurate.
Thomas Huth writes:
> While there might have been bigger differnces between the -base and
> the -xcode images in the beginning, they almost vanished in the
> current builds, e.g. when comparing the output of the "configure"
> step after cleaning up the differences due to temporary path names,
Adds an option (--enable-tcg-builtin) to build TCG natively when
--enable-modules argument is passed to the build system. It gives
the opportunity to have this important accelerator built-in and
still take advantage of the new modular system.
Signed-off-by: Jose R. Ziviani
---
configure
Hello!
This patch gives the ability to build TCG builtin even if
--enable-modules is selected. This is useful to have a base
QEMU with TCG native product but still using the benefits of
modules.
Thank you!
Jose R. Ziviani (1):
modules: Option to build native TCG with --enable-modules
On 7/20/21 9:54 PM, Richard Henderson wrote:
> The hook is now unused, with breakpoints checked outside translation.
>
> Signed-off-by: Richard Henderson
> ---
> include/exec/translator.h | 11 ---
> target/arm/helper.h | 2 --
> target/alpha/translate.c | 16
On 7/20/21 9:54 PM, Richard Henderson wrote:
> Ensure at registration that all breakpoints are in
> code space, not data space.
>
> Signed-off-by: Richard Henderson
> ---
> target/avr/cpu.h | 1 +
> target/avr/cpu.c | 1 +
> target/avr/gdbstub.c | 13 +
>
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
>
> Cc: Sergio Lopez
> Signed-off-by: Markus Armbruster
> ---
> hw/i386/microvm.c | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index aba0c83219..f257ec5a0b
> We continue after -smp help:
>
> $ qemu-system-x86_64 -smp help -display none -monitor stdio
> smp-opts options:
> cores=
> cpus=
> dies=
> maxcpus=
> sockets=
> threads=
> QEMU 6.0.50 monitor - type 'help' for more information
> (qemu)
>
>
> Commit b673eab4e2 "multifd: Make multifd_load_setup() get an Error
> parameter" changed migration_incoming_setup() to take an Error **
> argument, and adjusted the callers accordingly. It neglected to
> change adjust multifd_load_setup(): it still exit()s on error. Clean
> that up.
>
> The
On Tue, Jul 20, 2021 at 02:42:12PM -0500, Michael Roth wrote:
> On Tue, Jul 13, 2021 at 03:46:19PM +0200, Markus Armbruster wrote:
> > Brijesh Singh writes:
> >
> > > To launch the SEV-SNP guest, a user can specify up to 8 parameters.
> > > Passing all parameters through command line can be
On 7/20/21 11:08 PM, Richard Henderson wrote:
> On 7/20/21 10:56 AM, Peter Maydell wrote:
>> On Tue, 20 Jul 2021 at 20:54, Richard Henderson
>> wrote:
>>>
>>> This will allow a breakpoint hack to move out of AVR's translator.
>>>
>>> Signed-off-by: Richard Henderson
>>
>>> diff --git a/cpu.c
On 20/07/2021 20:54, Richard Henderson wrote:
This is fixing #404 ("windows xp boot takes much longer...")
and several other similar reports.
Changes for v6:
* Reinstate accidental loss of singlestep overriding breakpoint check.
Shows up in the record-replay avocado tests failing to
All instances of EXTRA_ARGS are now identical.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 36
accel/tcg/cputlb.c | 1 -
Use trace_mem_get_info instead of trace_mem_build_info,
using the TCGMemOpIdx that we already have. Do this in
the atomic_trace_*_pre function as common subroutines.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 48
Since the last thing that mem.h does is include mem-internal.h,
the symbols are not actually private.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
trace/mem-internal.h | 50
Unify the parameters of atomic_mmu_lookup between cputlb.c and
user-exec.c. Call the function directly, and remove the macros.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 41 +
Reduce the amount of code duplication by always passing
the TCGMemOpIdx argument to helper_atomic_*. This is not
currently used for user-only, but it's easy to ignore.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
accel/tcg/tcg-runtime.h | 46
All definitions are now empty.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/atomic_template.h | 12
accel/tcg/cputlb.c | 1 -
accel/tcg/user-exec.c | 1 -
3 files changed,
Always provide the atomic interface using TCGMemOpIdx oi
and uintptr_t retaddr. Rename from helper_* to cpu_* so
as to (mostly) match the exec/cpu_ldst.h functions, and
to emphasize that they are not callable from TCG directly.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Signed-off-by:
Use it to avoid some clang-12 -Watomic-alignment errors,
forcing some structures to be aligned and as a pointer when
we have ensured that the address is aligned.
Tested-by: Cole Robinson
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
We now require c11, so the fallbacks are now dead code
Tested-by: Cole Robinson
Reviewed-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
configure | 7 --
include/qemu/atomic.h | 204 +++---
2 files changed, 10
Clang warnings about questionable atomic usage get localized
to the inline function in atomic.h. By using a macro, we get
the full traceback to the original use that caused the warning.
Tested-by: Cole Robinson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
This is intended to fix building with clang-12 on i386.
In the process, I found bugs wrt handling of guest memory in target/
with respect to atomics, fixed by unifying the api between softmmu
and user-only and removing some ifdefs under target/.
Unification of the api allowed some further
On 7/20/21 10:56 AM, Peter Maydell wrote:
On Tue, 20 Jul 2021 at 20:54, Richard Henderson
wrote:
This will allow a breakpoint hack to move out of AVR's translator.
Signed-off-by: Richard Henderson
diff --git a/cpu.c b/cpu.c
index 83059537d7..91d9e38acb 100644
--- a/cpu.c
+++ b/cpu.c
@@
On Tue, 20 Jul 2021 at 20:54, Richard Henderson
wrote:
>
> This will allow a breakpoint hack to move out of AVR's translator.
>
> Signed-off-by: Richard Henderson
> diff --git a/cpu.c b/cpu.c
> index 83059537d7..91d9e38acb 100644
> --- a/cpu.c
> +++ b/cpu.c
> @@ -267,8 +267,13 @@ static void
On 7/19/21 2:39 AM, Peter Maydell wrote:
This cast is OK, but it took me a while to verify that:
* we check that 'addr' is 8-aligned further up in this function
* we check that guest_base is at least page-aligned in
probe_guest_base(), and there's no way to avoid that function
On Tue, Jul 20, 2021 at 05:22:29PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> First, this permission never protected node from being changed, as
a node
> generic child-replacing functions don't check it.
>
> Second, it's a strange thing: it presents a permission of parent node
> to change its
On Tue, 20 Jul 2021 at 20:55, Richard Henderson
wrote:
>
> Set CF_SINGLE_STEP when single-stepping is enabled.
> This avoids the need to flush all tb's when turning
> single-stepping on or off.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
On Tue, 20 Jul 2021 at 20:55, Richard Henderson
wrote:
>
> The hook is now unused, with breakpoints checked outside translation.
>
> Signed-off-by: Richard Henderson
> ---
> include/exec/translator.h | 11 ---
> target/arm/helper.h | 2 --
> target/alpha/translate.c
On 7/19/21 2:01 AM, Peter Maydell wrote:
-static inline void qatomic_set_u64(uint64_t *ptr, uint64_t val)
-{
-qatomic_set__nocheck(ptr, val);
-}
...
+#define qatomic_set_u64 qatomic_set__nocheck
Previously if you tried to do qatomic_set_i64() etc on something
that wasn't an int64_t*,
On Fri, Jul 16, 2021 at 08:32:53PM -0400, John Snow wrote:
> This tests most of protocol.py -- From a hacked up Coverage.py run, it's
> at about 86%. There's a few error cases that aren't very well tested
> yet, they're hard to induce artificially so far. I'm working on it.
>
> Signed-off-by:
This is the upstream QEMU bug tracker, not an Ubuntu specific tracker;
if you'd like Ubuntu to consider a backport of something, please file a
bug with them.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml,
On Tue, 20 Jul 2021 at 21:18, Jag Raman wrote:
>
>
>
> > On Jul 20, 2021, at 2:39 PM, Cleber Rosa wrote:
> >
> >
> > Jag Raman writes:
> >>
> >> We presently don’t have permissions to send a PR to
> >> upstream (Peter Maydell).
> >>
> >> Presently, we are requesting someone else who has
> >>
> On Jul 20, 2021, at 8:53 AM, Markus Armbruster wrote:
>
> The Error ** argument must be NULL, _abort, _fatal, or a
> pointer to a variable containing NULL. Passing an argument of the
> latter kind twice without clearing it in between is wrong: if the
> first call sets an error, it no
> On Jul 20, 2021, at 2:39 PM, Cleber Rosa wrote:
>
>
> Jag Raman writes:
>
>>
>> Hi Cleber,
>>
>> We presently don’t have permissions to send a PR to
>> upstream (Peter Maydell).
>>
>> Presently, we are requesting someone else who has
>> permissions to do PRs on our behalf. We will work
Public bug reported:
This is a reopen of #1869073 for `qemu-user-static/focal-updates,focal-
security,now 1:4.2-3ubuntu6.17 amd64`.
`git clone` reproducably segfaults in `qemu-arm-static` chroot.
#1869073 mentions this should have been fixed for newer versions of
QEMU, but for `focal` there's
Set CF_SINGLE_STEP when single-stepping is enabled.
This avoids the need to flush all tb's when turning
single-stepping on or off.
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 1 +
accel/tcg/cpu-exec.c | 7 ++-
accel/tcg/translate-all.c | 4
The hook is now unused, with breakpoints checked outside translation.
Signed-off-by: Richard Henderson
---
include/exec/translator.h | 11 ---
target/arm/helper.h | 2 --
target/alpha/translate.c | 16
target/arm/debug_helper.c | 7 ---
1 - 100 of 385 matches
Mail list logo
