Re: [RFC v3 16/19] vfio-user: dma map/unmap operations

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:44 -0800 > John Johnson wrote: > >> Signed-off-by: Jagannathan Raman >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> --- >> hw/vfio/pci.h | 1 + >>

Re: [RFC v3 08/19] vfio-user: define socket receive functions

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:36 -0800 > John Johnson wrote: > >> Add infrastructure needed to receive incoming messages >> >> Signed-off-by: John G Johnson >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: Jagannathan Raman >>

Re: [RFC v3 12/19] vfio-user: region read/write

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:40 -0800 > John Johnson wrote: > >> >> VFIOProxy *vfio_user_connect_dev(SocketAddress *addr, Error **errp); >> void vfio_user_disconnect(VFIOProxy *proxy); >> diff --git a/include/hw/vfio/vfio-common.h

Re: [RFC v3 07/19] vfio-user: connect vfio proxy to remote server

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:35 -0800 > John Johnson wrote: > >> >> >> static void vfio_user_instance_finalize(Object *obj) >> { >> +VFIOPCIDevice *vdev = VFIO_PCI_BASE(obj); >> +VFIODevice *vbasedev = >vbasedev; >> + >> +

Re: [RFC v3 13/19] vfio-user: pci_user_realize PCI setup

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:41 -0800 > John Johnson wrote: > >> PCI BARs read from remote device >> PCI config reads/writes sent to remote server >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >>

Re: [RFC v3 04/19] Add device IO ops vector

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:32 -0800 > John Johnson wrote: > >> >> +int (*region_write)(VFIODevice *vdev, uint8_t nr, off_t off, uint32_t >> size, >> +void *data, bool post); > > The @post arg is not

Re: [RFC v3 06/19] vfio-user: Define type vfio_user_pci_dev_info

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:34 -0800 > John Johnson wrote: > >> New class for vfio-user with its class and instance >> constructors and destructors, and its pci ops. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G

Re: [RFC v3 05/19] Add validation ops vector

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > > Add a prefix on Subject: please. Same for previous in series. > ok > On Mon, 8 Nov 2021 16:46:33 -0800 > John Johnson wrote: > >> Validates cases where the return values aren't fully trusted >> (prep work for

Re: [RFC v3 02/19] vfio-user: add VFIO base abstract class

2021-12-06 Thread John Johnson
> On Nov 19, 2021, at 2:42 PM, Alex Williamson > wrote: > > On Mon, 8 Nov 2021 16:46:30 -0800 > John Johnson wrote: > >> + >> +static Property vfio_pci_dev_properties[] = { >> +DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host), >> +DEFINE_PROP_STRING("sysfsdev",

Re: [PATCH v6 3/6] failover: fix unplug pending detection

2021-12-06 Thread Laurent Vivier
On 07/12/2021 05:13, Ani Sinha wrote: On Mon, 6 Dec 2021, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device().

Re: [PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-12-06 Thread Peter Xu
On Thu, Dec 02, 2021 at 06:38:27PM +0100, Juan Quintela wrote: > This needs to be improved to be compatible with old versions. Any plan to let new binary work with old binary? Maybe boost the version field for multifd packet (along with a multifd_version=2 parameter and only set on new machine

Re: [PATCH v3 18/23] multifd: Use normal pages array on the recv side

2021-12-06 Thread Peter Xu
On Wed, Nov 24, 2021 at 11:06:12AM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/multifd.h | 8 +-- > migration/multifd-zlib.c | 8 +++ > migration/multifd-zstd.c | 6 +++--- > migration/multifd.c | 45 ++-- >

[PATCH v1 1/2] hostmem: use a static size for maxnode, validate policy everywhere

2021-12-06 Thread Daniil Tatianin
Previously we would calculate the last set bit in the mask, and add 2 to that value to get the maxnode value. This is unnecessary since the mbind syscall allows the bitmap to be any (reasonable) size as long as all the unused bits are clear. This also adds policy validation in multiple places so

[PATCH v1 2/2] osdep: support mempolicy for preallocation in os_mem_prealloc

2021-12-06 Thread Daniil Tatianin
This is needed for cases where we want to make sure that a shared memory region gets allocated from a specific NUMA node. This is impossible to do with mbind(2) because it ignores the policy for memory mapped with MAP_SHARED. We work around this by calling set_mempolicy from prealloc threads

Re: [RFC PATCH v3 05/27] target/loongarch: Add stabletimer support

2021-12-06 Thread maobibo
On 12/06/2021 12:38 PM, chen huacai wrote: > Hi, Xiaojuan, > > Maybe it is better to use "constant timer" instead of "stable timer", > which is more "native" in English. Yeap, maybe we need more investigation. On arm platform its name is ArchTimer rather than "constant timer" in x86. And we

Re: [PATCH v10 4/8] qmp: add QMP command x-query-virtio-status

2021-12-06 Thread Markus Armbruster
Jonah Palmer writes: > From: Laurent Vivier > > This new command shows the status of a VirtIODevice, including > its corresponding vhost device's status (if active). > > Next patch will improve output by decoding feature bits, including > vhost device's feature bits (backend, protocol, acked,

Re: [PATCH 11/15] ppc/ppc405: Fix boot from kernel

2021-12-06 Thread Cédric Le Goater
On 12/6/21 16:16, BALATON Zoltan wrote: On Mon, 6 Dec 2021, Cédric Le Goater wrote: The machine can already boot with kernel and initrd U-boot images if a firmware is loaded first. Adapt and improve the load sequence to let the machine boot directly from a Linux kernel ELF image and a usual

Re: [PATCH 07/15] ppc/ppc405: Add some address space definitions

2021-12-06 Thread Cédric Le Goater
On 12/6/21 16:05, BALATON Zoltan wrote: On Mon, 6 Dec 2021, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h    |  7 +++ hw/ppc/ppc405_boards.c | 16 +++- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/ppc/ppc405.h

Re: [PATCH v10 3/8] qmp: add QMP command x-query-virtio

2021-12-06 Thread Markus Armbruster
Jonah Palmer writes: > From: Laurent Vivier > > This new command lists all the instances of VirtIODevices with > their canonical QOM path and name. > > Signed-off-by: Jonah Palmer > --- > hw/virtio/meson.build | 2 ++ > hw/virtio/virtio-stub.c| 14 ++ > hw/virtio/virtio.c

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Ani Sinha
On Mon, Dec 6, 2021 at 9:51 PM Eric DeVolder wrote: > > Hi Ani, inline responses below. > eric > > On 12/6/21 02:14, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Ani Sinha
On Mon, Dec 6, 2021 at 9:51 PM Eric DeVolder wrote: > > Hi Ani, inline responses below. > eric > > On 12/6/21 02:14, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/7 10:57, Peter Xu 写道: On Mon, Dec 06, 2021 at 11:19:21PM +0800, Hyman wrote: +if (has_cpu_index) { +info = dirtylimit_query_vcpu(cpu_index); +QAPI_LIST_APPEND(tail, info); +} else { +CPUState *cpu; +CPU_FOREACH(cpu) { +if

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/7 10:24, Peter Xu 写道: On Mon, Dec 06, 2021 at 10:56:00PM +0800, Hyman wrote: I found that it'll be challenging for any human being to identify "whether he/she has turned throttle off for all vcpus".. I think that could be useful when we finally decided to cancel current migration.

Re: [PATCH v6 3/6] failover: fix unplug pending detection

2021-12-06 Thread Ani Sinha
On Mon, 6 Dec 2021, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > > But since > 17858a169508

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Peter Xu
On Mon, Dec 06, 2021 at 11:19:21PM +0800, Hyman wrote: > > > +if (has_cpu_index) { > > > +info = dirtylimit_query_vcpu(cpu_index); > > > +QAPI_LIST_APPEND(tail, info); > > > +} else { > > > +CPUState *cpu; > > > +CPU_FOREACH(cpu) { > > > +if

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Peter Xu
On Mon, Dec 06, 2021 at 10:56:00PM +0800, Hyman wrote: > > I found that it'll be challenging for any human being to identify "whether > > he/she has turned throttle off for all vcpus".. I think that could be > > useful > > when we finally decided to cancel current migration. > That's question,

Re: [PATCH v2] ppc/pnv.c: fix "system-id" FDT when -uuid is set

2021-12-06 Thread David Gibson
On Mon, Dec 06, 2021 at 10:02:53AM -0300, Daniel Henrique Barboza wrote: > Setting -uuid in the pnv machine does not work: > > ./qemu-system-ppc64 -machine powernv8,accel=tcg -uuid > 7ff61ca1-a4a0-4bc1-944c-abd114a35e80 > qemu-system-ppc64: error creating device tree: (fdt_property_string(fdt,

Issue using few e1000 nic in xen

2021-12-06 Thread Mega MoiX
Hello everyone, I hope everything is going fine! Thanks for your hard work;-) I am trying to migrate my personal environment bare metal from Ubuntu 16.04.x with xen like 4.4 or 4.6 ? to Ubuntu 20.04.x with xen 4.11 for nearly one year now without success. I use those two USB drive to boot so

Re: [PATCH] spec: Add NBD_OPT_EXTENDED_HEADERS

2021-12-06 Thread Eric Blake
On Mon, Dec 06, 2021 at 02:40:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Simple reply message > > > > The simple reply message MUST be sent by the server in response to all > > requests if structured replies have not been negotiated using > > -`NBD_OPT_STRUCTURED_REPLY`. If

[PATCH v2 2/4] hw/display/vga-mmio: Inline vga_mm_init()

2021-12-06 Thread Philippe Mathieu-Daudé
Inline vga_mm_init() in vga_mmio_init() to simplify the next patch review. Kind of. Reviewed-by: BALATON Zoltan Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/display/vga-mmio.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git

[PATCH v2 1/4] hw/display: Rename VGA_ISA_MM -> VGA_MMIO

2021-12-06 Thread Philippe Mathieu-Daudé
There is no ISA bus part in the MMIO VGA device, so rename: * hw/display/vga-isa-mm.c -> hw/display/vga-mmio.c * CONFIG_VGA_ISA_MM -> CONFIG_VGA_MMIO * ISAVGAMMState -> VGAMmioState * isa_vga_mm_init() -> vga_mmio_init() Reviewed-by: BALATON Zoltan Reviewed-by: Thomas Huth

[PATCH v2 3/4] hw/display/vga-mmio: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

2021-12-06 Thread Philippe Mathieu-Daudé
Introduce TYPE_VGA_MMIO, a sysbus device. While there is no change in the vga_mmio_init() interface, this is a migration compatibility break of the MIPS Acer Pica 61 Jazz machine (pica61). Suggested-by: Thomas Huth Reviewed-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 4/4] hw/mips/jazz: Inline vga_mmio_init() and remove it

2021-12-06 Thread Philippe Mathieu-Daudé
vga_mmio_init() is used only one time and not very helpful, inline and remove it. Reviewed-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé --- include/hw/display/vga.h | 5 - hw/display/vga-mmio.c| 19 --- hw/mips/jazz.c | 9 - 3 files

[PATCH v2 0/4] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

2021-12-06 Thread Philippe Mathieu-Daudé
Convert the open-coded vga_mmio_init() to a sysbus device. Since v1: - Addressed Zolton and Thomas comments, added their R-b tags Philippe Mathieu-Daudé (4): hw/display: Rename VGA_ISA_MM -> VGA_MMIO hw/display/vga-mmio: Inline vga_mm_init() hw/display/vga-mmio: QOM'ify vga_mmio_init() as

[PATCH v6 6/6] tests/libqtest: add a migration test with two couples of failover devices

2021-12-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 279 ++ 1 file changed, 279 insertions(+) diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c index 57abb99e7f6e..ace9001894af 100644 ---

[PATCH v6 3/6] failover: fix unplug pending detection

2021-12-06 Thread Laurent Vivier
Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device(). But since 17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35") we

[PATCH v6 2/6] tests/qtest: add some tests for virtio-net failover

2021-12-06 Thread Laurent Vivier
Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature. Signed-off-by: Laurent Vivier ---

[PATCH v6 5/6] test/libqtest: add some virtio-net failover migration cancelling tests

2021-12-06 Thread Laurent Vivier
Add some tests to check the state of the machine if the migration is cancelled while we are using virtio-net failover. Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 291 ++ 1 file changed, 291 insertions(+) diff --git

[PATCH v6 4/6] tests/libqtest: update virtio-net failover test

2021-12-06 Thread Laurent Vivier
Update the migration test to check we correctly wait the end of the card unplug before doing the migration. Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/tests/qtest/virtio-net-failover.c

[PATCH v6 1/6] qtest/libqos: add a function to initialize secondary PCI buses

2021-12-06 Thread Laurent Vivier
Scan the PCI devices to find bridge and set PCI_SECONDARY_BUS and PCI_SUBORDINATE_BUS (algorithm from seabios) Signed-off-by: Laurent Vivier --- include/hw/pci/pci_bridge.h | 8 +++ tests/qtest/libqos/pci.c| 118 tests/qtest/libqos/pci.h| 1 + 3

[PATCH v6 0/6] tests/qtest: add some tests for virtio-net failover

2021-12-06 Thread Laurent Vivier
This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine

Re: [PATCH v10 0/8] hmp,qmp: Add commands to introspect virtio devices

2021-12-06 Thread Michael S. Tsirkin
On Mon, Dec 06, 2021 at 07:13:49PM +0100, Christian Schoenebeck wrote: > On Montag, 6. Dezember 2021 17:09:45 CET Jonah Palmer wrote: > > On 12/6/21 08:50, Christian Schoenebeck wrote: > > > On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote: > > >> This series introduces new QMP/HMP

Re: [PULL 0/1] Block patches

2021-12-06 Thread Richard Henderson
On 12/6/21 7:27 AM, Stefan Hajnoczi wrote: The following changes since commit 99fc08366b06282614daeda989d2fde6ab8a707f: Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging (2021-12-03 05:26:40 -0800) are available in the Git repository at:

Re: Suggestions for TCG performance improvements

2021-12-06 Thread Alex Bennée
Vasilev Oleg writes: > On 12/3/2021 8:32 PM, Alex Bennée wrote: >> Vasilev Oleg writes: >> >>> On 12/2/2021 7:02 PM, Alex Bennée wrote: >>> Vasilev Oleg writes: > ...skipped... I did ponder a debug mode which would keep the last N tables dropped by tlb_mmu_resize_locked and

Re: [PATCH 3/3] iotests: check: multiprocessing support

2021-12-06 Thread John Snow
On Mon, Dec 6, 2021 at 3:20 PM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 06.12.2021 21:35, John Snow wrote: > > > > > > On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy < > vsement...@virtuozzo.com > wrote: > > > > Add -j

Re: [PATCH] fuzz: pass failures from child process into libfuzzer engine

2021-12-06 Thread Konstantin Khlebnikov
  06.12.2021, 19:35, "Alexander Bulekov" :On 211205 1917, Konstantin Khlebnikov wrote: Fuzzer is supposed to stop when first bug is found and report failure. Present fuzzers fork new child at each iteration to isolate side-effects. But child's exit code is ignored, i.e. libfuzzer

Re: [PATCH 0/3] iotests: multiprocessing!!

2021-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2021 21:37, John Snow wrote: On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy mailto:vsement...@virtuozzo.com>> wrote: Hi all! Finally, I can not stand it any longer. So, I'm happy to present multiprocessing support for iotests test runner. testing on tmpfs:

Re: [PATCH 3/3] iotests: check: multiprocessing support

2021-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2021 21:35, John Snow wrote: On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy mailto:vsement...@virtuozzo.com>> wrote: Add -j parameter, to run tests in several jobs simultaneously. For realization - simply utilize multiprocessing.Pool class. Notes: 1. Of

Re: [PATCH for-6.2 1/1] tcg/arm: Reduce vector alignment requirement for NEON

2021-12-06 Thread Philippe Mathieu-Daudé
On 12/6/21 20:13, Richard Henderson wrote: > With arm32, the ABI gives us 8-byte alignment for the stack. > While it's possible to realign the stack to provide 16-byte alignment, > it's far easier to simply not encode 16-byte alignment in the > VLD1 and VST1 instructions that we emit. > > Remove

Re: [PATCH for-7.0 4/4] tests/qtest: Add a function to check whether a machine is available

2021-12-06 Thread John Snow
On Wed, Dec 1, 2021 at 5:44 AM Thomas Huth wrote: > It is nowadays possible to build QEMU with a reduced set of machines > in each binary. However, the qtests still hard-code the expected > machines and fail if the binary does not feature the required machine. > Let's get a little bit more

Re: [PATCH v2 0/1] migration: multifd live migration improvement

2021-12-06 Thread Dr. David Alan Gilbert
* Li Zhang (lizh...@suse.de) wrote: > When testing live migration with multifd channels (8, 16, or a bigger number) > and using qemu -incoming (without "defer"), if a network error occurs > (for example, triggering the kernel SYN flooding detection), > the migration fails and the guest hangs

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-06 Thread Dr. David Alan Gilbert
* Li Zhang (lizh...@suse.de) wrote: > > Thanks for Daniel's review. > > Hi David and Juan, > > Any comments for this patch? > Yeh I think that's OK, so Reviewed-by: Dr. David Alan Gilbert I'd have a slight preference for it being before the post I think. Dave > > Thanks > > Li > > On

Re: Suggestions for TCG performance improvements

2021-12-06 Thread Vasilev Oleg via
On 12/3/2021 8:32 PM, Alex Bennée wrote: > Vasilev Oleg writes: > >> On 12/2/2021 7:02 PM, Alex Bennée wrote: >> >>> Vasilev Oleg writes: ...skipped... >>> I did ponder a debug mode which would keep the last N tables dropped by >>> tlb_mmu_resize_locked and then measure the differences in the

Re: [PULL 0/3] MIPS patches for 2021-12-06

2021-12-06 Thread Richard Henderson
-03 05:26:40 -0800) are available in the Git repository at: https://github.com/philmd/qemu.git tags/mips-20211206 for you to fetch changes up to ac5837e330ec33e2df2d83338713a5c4272c8cc8: Revert "vga: don't abort when adding a duplicate isa-vga device" (2021-12-06 11:5

[PATCH for-6.2 0/1] tcg/arm: Reduce vector alignment requirement for NEON

2021-12-06 Thread Richard Henderson
Re-post of https://patchew.org/QEMU/20210912174925.200132-1-richard.hender...@linaro.org/ fixing https://bugzilla.redhat.com/show_bug.cgi?id=1999878 which seems to have gotten lost. In the qemu-devel thread, I did successfully reproduce and fix the assertion failure, but I never got

[PATCH for-6.2 1/1] tcg/arm: Reduce vector alignment requirement for NEON

2021-12-06 Thread Richard Henderson
With arm32, the ABI gives us 8-byte alignment for the stack. While it's possible to realign the stack to provide 16-byte alignment, it's far easier to simply not encode 16-byte alignment in the VLD1 and VST1 instructions that we emit. Remove the assertion in temp_allocate_frame, limit natural

Re: [PATCH 0/3] iotests: multiprocessing!!

2021-12-06 Thread John Snow
On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > Hi all! > > Finally, I can not stand it any longer. So, I'm happy to present > multiprocessing support for iotests test runner. > > testing on tmpfs: > > Before: > > time check -qcow2 > ... > real

Re: [PATCH 3/3] iotests: check: multiprocessing support

2021-12-06 Thread John Snow
On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > Add -j parameter, to run tests in several jobs simultaneously. > For realization - simply utilize multiprocessing.Pool class. > > Notes: > > 1. Of course, tests can't run simultaneously in same

Re: [PATCH] net/slirp: Fix incorrect permissions on samba >= 2.0.5

2021-12-06 Thread Niklas Hambüchen
Hey all, just checking on an update. It would be great if this could be included in the coming/next QEMU release. Cheers! Niklas

Re: [PATCH v10 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-12-06 Thread Christian Schoenebeck via
On Montag, 6. Dezember 2021 17:09:45 CET Jonah Palmer wrote: > On 12/6/21 08:50, Christian Schoenebeck wrote: > > On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote: > >> This series introduces new QMP/HMP commands to dump the status of a > >> virtio device at different levels. > >> > >>

Re: [PATCH 2/3] iotests/testrunner.py: move updating last_elapsed to run_tests

2021-12-06 Thread John Snow
On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > We are going to use do_run_test() in multiprocessing environment, where > we'll not be able to change original runner object. > > Happily, the only thing we change is that last_elapsed and it's simple

Re: [PATCH 1/3] iotests/testrunner.py: add doc string for run_test()

2021-12-06 Thread John Snow
On Fri, Dec 3, 2021 at 7:22 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > We are going to modify these methods and will add more documentation in > further commit. As a preparation add basic documentation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[PATCH v6 2/6] net/vmnet: add vmnet backends to qapi/net

2021-12-06 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m |

[PATCH v6 4/6] net/vmnet: implement host mode (vmnet-host)

2021-12-06 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 93 1 file changed, 87 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index 4a5ef99dc7..9c2e760ed1 100644 --- a/net/vmnet-host.c +++ b/net/vmnet-host.c @@

[PATCH v6 5/6] net/vmnet: implement bridged mode (vmnet-bridged)

2021-12-06 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 98 ++--- 1 file changed, 92 insertions(+), 6 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 4e42a90391..3c9da9dc8b 100644 --- a/net/vmnet-bridged.m +++

[PATCH v6 3/6] net/vmnet: implement shared mode (vmnet-shared)

2021-12-06 Thread Vladislav Yaroshchuk
Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. vmnet.framework supports iov, but writing more than one iov into vmnet interface fails with 'VMNET_INVALID_ARGUMENT'. Collecting

[PATCH v6 6/6] net/vmnet: update qemu-options.hx

2021-12-06 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index ae2c6dbbfc..1ffa5eedd5 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2677,6 +2677,25 @@ DEF("netdev", HAS_ARG,

[PATCH v6 1/6] net/vmnet: add vmnet dependency and customizable option

2021-12-06 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- meson.build | 4 meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 3 files changed, 9 insertions(+) diff --git a/meson.build b/meson.build index 96de1a6ef9..ce8acf6ada 100644 --- a/meson.build +++

[PATCH v6 0/6] Add vmnet.framework based network backend

2021-12-06 Thread Vladislav Yaroshchuk
macOS provides networking API for VMs called 'vmnet.framework': https://developer.apple.com/documentation/vmnet We can provide its support as the new QEMU network backends which represent three different vmnet.framework interface usage modes: * `vmnet-shared`: allows the guest to

Re: [PATCH] fuzz: pass failures from child process into libfuzzer engine

2021-12-06 Thread Alexander Bulekov
On 211205 1917, Konstantin Khlebnikov wrote: > Fuzzer is supposed to stop when first bug is found and report failure. > Present fuzzers fork new child at each iteration to isolate side-effects. > But child's exit code is ignored, i.e. libfuzzer does not see any crashes. > > Right now virtio-net

Re: [PATCH v9 06/10] ACPI ERST: build the ACPI ERST table

2021-12-06 Thread Eric DeVolder
Hi Ani, response below. eric On 12/6/21 04:30, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:40 AM Eric DeVolder wrote: This builds the ACPI ERST table to inform OSPM how to communicate with the acpi-erst device. Signed-off-by: Eric DeVolder --- hw/acpi/erst.c | 241

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Eric DeVolder
Hi Ani, inline responses below. eric On 12/6/21 02:14, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. OK sent some more

Re: [PATCH v10 0/8] hmp,qmp: Add commands to introspect virtio devices

2021-12-06 Thread Jonah Palmer
On 12/6/21 08:50, Christian Schoenebeck wrote: On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Nov. 10 (v9). Original patches are by

Re: [PATCH v9 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-12-06 Thread Hyman
在 2021/12/6 18:18, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:45AM +0800, huang...@chinatelecom.cn wrote: +static void dirtylimit_calc_func(void) +{ +CPUState *cpu; +DirtyPageRecord *dirty_pages; +int64_t start_time, end_time, calc_time; +DirtyRateVcpu rate; +int i = 0; +

Re: [PATCH v2 00/13] Eliminate drive_get_next()

2021-12-06 Thread Markus Armbruster
Markus Armbruster writes: > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit numbers implicitly by execution

[PULL 1/1] virtio-blk: Fix clean up of host notifiers for single MR transaction.

2021-12-06 Thread Stefan Hajnoczi
From: Mark Mielke The code that introduced "virtio-blk: Configure all host notifiers in a single MR transaction" introduced a second loop variable to perform cleanup in second loop, but mistakenly still refers to the first loop variable within the second loop body. Fixes: d0267da61489

[PULL 0/1] Block patches

2021-12-06 Thread Stefan Hajnoczi
The following changes since commit 99fc08366b06282614daeda989d2fde6ab8a707f: Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging (2021-12-03 05:26:40 -0800) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/6 16:39, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:47AM +0800, huang...@chinatelecom.cn wrote: +void dirtylimit_setup(int max_cpus) +{ +if (!kvm_enabled() || !kvm_dirty_ring_enabled()) { +return; +} + +dirtylimit_calc_state_init(max_cpus); +

Re: [PATCH 15/15] ppc/ppc405: Update U-Boot board information for hotfoot

2021-12-06 Thread Cédric Le Goater
On 12/6/21 14:40, Thomas Huth wrote: On 06/12/2021 14.37, Cédric Le Goater wrote: On 12/6/21 14:27, Philippe Mathieu-Daudé wrote: On 12/6/21 11:37, Cédric Le Goater wrote: When support for the ESTeem 195E (PPC405EP) SBC (hotfoot) board was added to Linux, a different layout of U-Boot board

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/6 16:36, Peter Xu 写道: On Fri, Dec 03, 2021 at 09:39:47AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it reachs the quota dirty page rate given by user. Introduce qmp

Re: [PATCH 11/15] ppc/ppc405: Fix boot from kernel

2021-12-06 Thread BALATON Zoltan
On Mon, 6 Dec 2021, Cédric Le Goater wrote: The machine can already boot with kernel and initrd U-boot images if a firmware is loaded first. Adapt and improve the load sequence to let the machine boot directly from a Linux kernel ELF image and a usual initrd image if a firmware image is not

Re: [PATCH 07/15] ppc/ppc405: Add some address space definitions

2021-12-06 Thread BALATON Zoltan
On Mon, 6 Dec 2021, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 7 +++ hw/ppc/ppc405_boards.c | 16 +++- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index ad5f4026b5db..ea48c3626908

Re: [PATCH v6 00/18] Adding partial support for 128-bit riscv target

2021-12-06 Thread Frédéric Pétrot
Hi Richard, On 29/11/2021 13:13, Richard Henderson wrote: On 11/28/21 2:57 PM, Frédéric Pétrot wrote: This series of patches provides partial 128-bit support for the riscv target architecture, namely RVI and RVM, with minimal csr support. Thanks again for the reviews and suggestions. v6: -

Re: [PATCH v9 3/3] cpus-common: implement dirty page limit on vCPU

2021-12-06 Thread Hyman
在 2021/12/6 16:28, Peter Xu 写道: On Sat, Dec 04, 2021 at 08:00:19PM +0800, Hyman Huang wrote: 在 2021/12/3 20:34, Markus Armbruster 写道: huang...@chinatelecom.cn writes: From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle vCPU until it

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-06 Thread Peter Maydell
On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > v3: > - Added __attribute__((weak)) to get_ptr_*() [Florian] Do we really need it *only* on get_ptr_*() ? If we need to noinline the other two we probably also should use the same attribute weak to force no optimizations at all. -- PMM

Re: request for wiki account

2021-12-06 Thread Daniel P . Berrangé
On Mon, Dec 06, 2021 at 04:37:24AM -0500, nick black wrote: > hello there! i've been using qemu since about 2005, but somehow > never needed to make an account on the wiki. i now do. can i > get an account created for 'dankamongmen' or, if you prefer real > names, 'nickblack'? thanks! I'll take

Re: [PATCH v3 4/4] s390x/pci: add supported DT information to clp response

2021-12-06 Thread Eric Farman
On Fri, 2021-12-03 at 09:27 -0500, Matthew Rosato wrote: > The DTSM is a mask that specifies which I/O Address Translation > designation > types are supported. Today QEMU only supports DT=1. > > Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman > --- > hw/s390x/s390-pci-bus.c |

[PATCH for-7.0] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a'

2021-12-06 Thread Thomas Huth
The lsi53c895a SCSI adaptor might not be enabled in each and every x86 QEMU binary, e.g. it's disabled in the RHEL/CentOS build. Thus let's add a check to the 051 test so that it does not fail if this device is not available. Signed-off-by: Thomas Huth --- tests/qemu-iotests/051 | 4 1

[RFC v3 4/4] cpus: use coroutine TLS macros for iothread_locked

2021-12-06 Thread Stefan Hajnoczi
qemu_mutex_iothread_locked() may be used from coroutines. Standard __thread variables cannot be used by coroutines. Use the coroutine TLS macros instead. Signed-off-by: Stefan Hajnoczi --- softmmu/cpus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/softmmu/cpus.c

[RFC v3 3/4] rcu: use coroutine TLS macros

2021-12-06 Thread Stefan Hajnoczi
RCU may be used from coroutines. Standard __thread variables cannot be used by coroutines. Use the coroutine TLS macros instead. Signed-off-by: Stefan Hajnoczi --- include/qemu/rcu.h | 7 --- tests/unit/rcutorture.c| 10 +- tests/unit/test-rcu-list.c | 4 ++--

Re: [PATCH] linux-user/hexagon: Use generic target_stat64 structure

2021-12-06 Thread Philippe Mathieu-Daudé
On Mon, Dec 6, 2021 at 3:21 PM Philippe Mathieu-Daudé wrote: > > Hi Laurent, > > What is your plan for this patch? Technically this is a bugfix. I see the code was released for 6.0, so not a regression. Probably 7.0 material now. > On 11/16/21 22:09, Philippe Mathieu-Daudé wrote: > > Linux

[RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-06 Thread Stefan Hajnoczi
v3: - Added __attribute__((weak)) to get_ptr_*() [Florian] - Replace rdfsbase with mov %%fs:0,%0 [Florian] This patch series solves the coroutines TLS problem. Coroutines re-entered from another thread sometimes see stale TLS values. This happens because compilers may cache values across yield

[RFC v3 2/4] util/async: replace __thread with QEMU TLS macros

2021-12-06 Thread Stefan Hajnoczi
QEMU TLS macros must be used to make TLS variables safe with coroutines. Signed-off-by: Stefan Hajnoczi --- util/async.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/util/async.c b/util/async.c index 6f6717a34b..ddd9f24419 100644 --- a/util/async.c +++

request for wiki account

2021-12-06 Thread nick black
hello there! i've been using qemu since about 2005, but somehow never needed to make an account on the wiki. i now do. can i get an account created for 'dankamongmen' or, if you prefer real names, 'nickblack'? thanks! -- nick black -=- https://www.nick-black.com to make an apple pie from

[RFC v3 1/4] tls: add macros for coroutine-safe TLS variables

2021-12-06 Thread Stefan Hajnoczi
Compiler optimizations can cache TLS values across coroutine yield points, resulting in stale values from the previous thread when a coroutine is re-entered by a new thread. Serge Guelton developed an __attribute__((noinline)) wrapper and tested it with clang and gcc. I formatted his idea

Re: [PATCH] linux-user/hexagon: Use generic target_stat64 structure

2021-12-06 Thread Philippe Mathieu-Daudé
Hi Laurent, What is your plan for this patch? Technically this is a bugfix. On 11/16/21 22:09, Philippe Mathieu-Daudé wrote: > Linux Hexagon port doesn't define a specific 'struct stat' > but uses the generic one (see Linux commit 6103ec56c65c [*] > "asm-generic: add generic ABI headers" which

Re: [PATCH] virtio-blk: Fix clean up of host notifiers for single MR transaction.

2021-12-06 Thread Stefan Hajnoczi
On Thu, Dec 02, 2021 at 11:26:51AM -0500, Mark Mielke wrote: > The code that introduced "virtio-blk: Configure all host notifiers in > a single MR transaction" introduced a second loop variable to perform > cleanup in second loop, but mistakenly still refers to the first > loop variable within the

[RFC PATCH v2] blog post: how to get your new feature up-streamed

2021-12-06 Thread Alex Bennée
Experience has shown that getting new functionality up-streamed can be a somewhat painful process. Lets see if we can collect some of our community knowledge into a blog post describing some best practices for getting code accepted. Signed-off-by: Alex Bennée --- v2 - tweak the title -

Re: [PATCH v10 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-12-06 Thread Christian Schoenebeck via
On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote: > This series introduces new QMP/HMP commands to dump the status of a > virtio device at different levels. > > [Jonah: Rebasing previous patchset from Nov. 10 (v9). Original patches > are by Laurent Vivier from May 2020. > > Rebase

Re: [PATCH 15/15] ppc/ppc405: Update U-Boot board information for hotfoot

2021-12-06 Thread Cédric Le Goater
On 12/6/21 14:27, Philippe Mathieu-Daudé wrote: On 12/6/21 11:37, Cédric Le Goater wrote: When support for the ESTeem 195E (PPC405EP) SBC (hotfoot) board was added to Linux, a different layout of U-Boot board information was introduced because the FW of these boards was an ancient U-Boot

  1   2   >