Re: ebpf/rss.bpf.skeleton.h generated by what?

2022-05-08 Thread Markus Armbruster
Jason Wang writes: > On Sat, May 7, 2022 at 2:58 PM Paolo Bonzini wrote: >> >> On 5/7/22 08:53, Jason Wang wrote: >> > On Sat, May 7, 2022 at 2:46 PM Paolo Bonzini wrote: >> >> >> >> On 5/7/22 07:05, Jason Wang wrote: >> If it was generated by something in the tree, it should not be

Re: [PATCH 1/4] Clean up header guards that don't match their file name

2022-05-08 Thread Markus Armbruster
Markus Armbruster writes: > Header guard symbols should match their file name to make guard > collisions less likely. > > Cleaned up with scripts/clean-header-guards.pl, followed by some > renaming of new guard symbols picked by the script to better ones. > > Signed-off-by: Markus Armbruster

Re: [PATCH v9 0/6] hw/arm/virt: Fix CPU's default NUMA node ID

2022-05-08 Thread Gavin Shan
Hi Peter and maintainers, On 5/3/22 10:02 PM, Gavin Shan wrote: When the CPU-to-NUMA association isn't provided by user, the default NUMA node ID for the specific CPU is returned from virt_get_default_cpu_node_id(). Unfortunately, the default NUMA node ID breaks socket boundary and leads to the

PING: [PATCH v5 9/9] crypto: Introduce RSA algorithm

2022-05-08 Thread zhenwei pi
Hi, Lei I would appreciate it if you could review this patch! On 4/28/22 21:59, zhenwei pi wrote: There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two

Re: [PULL 00/53] qemu-sparc queue 20220508

2022-05-08 Thread Richard Henderson
/qemu.git tags/qemu-sparc-20220508 for you to fetch changes up to 1f110516190f146df40f49aef2f1ef5903b8f540: artist: only render dirty scanlines on the display surface (2022-05-08 18:52:37 +0100) qemu-sparc queue - HPPA general

[PULL 52/53] artist: remove unused ROP8OFF() macro

2022-05-08 Thread Mark Cave-Ayland
This macro is unused and so can simply be removed. Signed-off-by: Mark Cave-Ayland Message-Id: <20220504153708.10352-3-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Peter Maydell Reviewed-by: Helge Deller Reviewed-by: Sven Schnelle Signed-off-by: Mark Cave-Ayland --- hw/display/artist.c | 6

[PULL 50/53] hppa: simplify machine function names in machine.c

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-51-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/machine.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PULL 53/53] artist: only render dirty scanlines on the display surface

2022-05-08 Thread Mark Cave-Ayland
The framebuffer_update_display() function returns the dirty scanlines that were touched since the last display update, however artist_update_display() always calls dpy_gfx_update() with start and end scanlines of 0 and s->height causing the entire display surface to be rendered on every update.

[PULL 51/53] artist: checkpatch and newline style fixes

2022-05-08 Thread Mark Cave-Ayland
Ensure that subsequent patches do not cause checkpatch to fail and also tidy up extra/missing newlines. Signed-off-by: Mark Cave-Ayland Message-Id: <20220504153708.10352-2-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Peter Maydell Reviewed-by: Helge Deller Reviewed-by: Sven Schnelle

[PULL 49/53] hppa: fold machine_hppa_machine_init() into machine_hppa_machine_init_class_init()

2022-05-08 Thread Mark Cave-Ayland
There is no need for a separate function to set the machine class properties separately from the others. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-50-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland

[PULL 45/53] hppa: remove unused trace-events from from hw/hppa

2022-05-08 Thread Mark Cave-Ayland
Now that there are no longer any devices in hw/hppa the trace-events file is empty and can be removed. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-46-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland ---

[PULL 47/53] hppa: remove the empty hppa_sys.h file

2022-05-08 Thread Mark Cave-Ayland
This file is now just a simple wrapper that includes hppa_hardware.h so remove the file completely, and update its single user in machine.c to include hppa_hardware.h directly. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id:

[PULL 33/53] lasi: move LAN initialisation to machine.c

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-34-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c| 7 --- hw/hppa/machine.c | 5 + 2 files changed, 5 insertions(+), 7

[PULL 42/53] lasi: move from hw/hppa to hw/misc

2022-05-08 Thread Mark Cave-Ayland
Move the LASI device implementation from hw/hppa to hw/misc so that it is located with all the other miscellaneous devices. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-43-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Mark Cave-Ayland ---

[PULL 41/53] hppa: move device headers from hppa_sys.h into individual .c files

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-42-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/hppa_sys.h | 3 --- hw/hppa/lasi.h | 4 hw/hppa/machine.c | 2 ++ hw/hppa/pci.c

[PULL 37/53] lasi: remove address space parameter from lasi_initfn()

2022-05-08 Thread Mark Cave-Ayland
Now that all of the LASI devices are mapped by the board, this parameter is no longer required. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-38-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland ---

[PULL 48/53] hppa: use MACHINE QOM macros for defining the hppa machine

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-49-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PULL 40/53] lasi: use numerical constant for iar reset value

2022-05-08 Thread Mark Cave-Ayland
This is to allow us to decouple the LASI device from the board logic. If it is decided later that this value needs to be configurable then it can easily be converted to a qdev property. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id:

[PULL 34/53] lasi: move parallel port initialisation to machine.c

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-35-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c| 6 -- hw/hppa/machine.c | 6 ++ 2 files changed, 6 insertions(+), 6

[PULL 32/53] lasi: update lasi_initfn() to return LASIState

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-33-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/hppa_sys.h | 3 ++- hw/hppa/lasi.c | 4 ++-- hw/hppa/machine.c | 3 ++- 3 files changed, 6

[PULL 46/53] hppa: move enable_lan() define from hppa_sys.h to machine.c

2022-05-08 Thread Mark Cave-Ayland
Now that the board configuration is in one place, the define is only needed when wiring up the board in machine.c. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-47-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark

[PULL 35/53] lasi: move second serial port initialisation to machine.c

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-36-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c| 8 hw/hppa/machine.c | 7 +++ 2 files changed, 7 insertions(+), 8

[PULL 36/53] lasi: move PS2 initialisation to machine.c

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-37-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c| 5 - hw/hppa/machine.c | 5 + 2 files changed, 5 insertions(+), 5

[PULL 30/53] lasi: use qdev GPIOs to wire up IRQs in lasi_initfn()

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-31-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git

[PULL 22/53] dino: move from hw/hppa to hw/pci-host

2022-05-08 Thread Mark Cave-Ayland
Move the DINO device implementation from hw/hppa to hw/pci-host so that it is located with all the other PCI host bridges. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-23-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by:

[PULL 44/53] hppa: remove hw/hppa/pci.c

2022-05-08 Thread Mark Cave-Ayland
The functions and definitions in this file are not used anywhere within the generic hppa machine. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-45-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland ---

[PULL 39/53] lasi: use constants for device register offsets

2022-05-08 Thread Mark Cave-Ayland
Instead of generating the offset based upon the physical address of the register, add constants for each of the device registers to lasi.h and update lasi.c to use them. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-40-mark.cave-ayl...@ilande.co.uk>

[PULL 28/53] lasi: replace lasi_get_irq() with defined constants

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-29-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c | 31 --- hw/hppa/lasi.h | 9 + 2 files changed, 13 insertions(+), 27 deletions(-)

[PULL 43/53] hppa: move hppa_pci_ignore_ops from pci.c to machine.c

2022-05-08 Thread Mark Cave-Ayland
The memory region only has one user which is for ensuring accesses to the ISA bus memory do not fault. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-44-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland ---

[PULL 29/53] lasi: define IRQ inputs as qdev GPIOs

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-30-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c | 2 ++ hw/hppa/lasi.h | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PULL 21/53] dino: move DINO HPA constants from hppa_hardware.h to dino.h

2022-05-08 Thread Mark Cave-Ayland
This is to allow us to decouple the DINO device from the board logic. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-22-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.h | 5

[PULL 38/53] lasi: move lasi_initfn() to machine.c

2022-05-08 Thread Mark Cave-Ayland
Move the simplified lasi_initfn() back to machine.c whilst also renaming it back to its original lasi_init() name. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-39-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark

[PULL 26/53] lasi: move initialisation of iar and rtc to new lasi_reset() function

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-27-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PULL 16/53] dino: define IRQ inputs as qdev GPIOs

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-17-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 2 ++ hw/hppa/dino.h | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PULL 19/53] hppa: move dino_init() from dino.c to machine.c

2022-05-08 Thread Mark Cave-Ayland
Now that dino_init() is completely decoupled from dino.c it can be moved to machine.c with the rest of the board configuration. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-20-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson

[PULL 31/53] lasi: fix serial port initialisation

2022-05-08 Thread Mark Cave-Ayland
The existing code checks for serial_hd(1) but sets the LASI serial port chardev to serial_hd(0). Use serial_hd(1) for the LASI serial port and also set the serial port endian to DEVICE_BIG_ENDIAN (which also matches the endian of the existing serial port). Signed-off-by: Mark Cave-Ayland

[PULL 23/53] lasi: checkpatch fixes

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-24-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/hppa/lasi.c

[PULL 14/53] machine.c: map DINO device during board configuration

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-15-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c| 3 --- hw/hppa/machine.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)

[PULL 17/53] dino: wire up serial IRQ using a qdev GPIO in machine.c

2022-05-08 Thread Mark Cave-Ayland
This makes it unnecessary to allocate a separate IRQ for the serial port. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-18-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 8

[PULL 27/53] lasi: move LASIState and associated QOM structures to lasi.h

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-28-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c | 44 +- hw/hppa/lasi.h | 58

[PULL 15/53] dino.h: add defines for DINO IRQ numbers

2022-05-08 Thread Mark Cave-Ayland
This is to allow the DINO IRQs to be defined as qdev GPIOs. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-16-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.h | 12 1 file

[PULL 18/53] dino: remove unused dino_set_timer_irq() IRQ handler

2022-05-08 Thread Mark Cave-Ayland
According to the comments in dino.c the timer IRQ is unused, so remove the empty dino_set_timer_irq() handler function and simply pass NULL to mc146818_rtc_init() in machine.c instead. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id:

[PULL 13/53] dino: change dino_init() to return the DINO device instead of PCIBus

2022-05-08 Thread Mark Cave-Ayland
This is in preparation for using more qdev APIs during the configuration of the HPPA generic machine. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-14-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland ---

[PULL 25/53] lasi: move register memory mapping from lasi.c to machine.c

2022-05-08 Thread Mark Cave-Ayland
The device register should be mapped directly by the board code. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-26-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/lasi.c| 7 +++

[PULL 12/53] hppa: use new CONFIG_HPPA_B160L option instead of CONFIG_DINO to build hppa machine

2022-05-08 Thread Mark Cave-Ayland
DINO refers to the GSC-PCI bridge device which will soon be handled separately, however the QEMU HPPA machine is actually based upon the HPPA B160L as indicated by the Linux kernel dmesg output when booted in qemu-system-hppa and the QEMU MAINTAINERS file. Update the machine configuration to use

[PULL 06/53] dino: move pci_setup_iommu() to dino_pcihost_init()

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-7-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/hppa/dino.c

[PULL 10/53] dino: return PCIBus from dino_init() using qdev_get_child_bus()

2022-05-08 Thread Mark Cave-Ayland
This allows access to the PCI bus without having to reference parent_obj directly. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-11-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 7

[PULL 11/53] dino: split declarations from dino.c into dino.h

2022-05-08 Thread Mark Cave-Ayland
This is to allow access to DinoState from outside dino.c. With the changes to the headers it is now possible to remove the duplicate definition for TYPE_DINO_PCI_HOST_BRIDGE from hppa_sys.h. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id:

[PULL 03/53] dino: move PCI bus initialisation to dino_pcihost_init()

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-4-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

[PULL 08/53] dino: move initial register configuration to new dino_pcihost_reset() function

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-9-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[PULL 24/53] lasi: move memory region initialisation to new lasi_init() function

2022-05-08 Thread Mark Cave-Ayland
Create a new lasi_init() instance initialisation function and move the LASI memory region initialisation into it. Rename the existing lasi_init() function to lasi_initfn() for now. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id:

[PULL 20/53] dino: use numerical constant for iar0 and iar1 reset values

2022-05-08 Thread Mark Cave-Ayland
This is to allow us to decouple the DINO device from the board logic. The choice of using a hard-coded constant (along with a comment) is to match how this is already done for toc_addr. If it is decided later that these values need to be configurable then they can easily be converted to qdev

[PULL 09/53] dino: use QOM cast instead of directly referencing parent_obj

2022-05-08 Thread Mark Cave-Ayland
Use a QOM cast in both dino_chip_read_with_attrs() and dino_chip_write_with_attrs() instead of directly referencing parent_obj. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-10-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson

[PULL 02/53] dino: move registers from dino_init() to DINO_PCI_BRIDGE init function

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-3-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 44 +--- 1 file changed, 29 insertions(+), 15

[PULL 04/53] dino: move PCI windows initialisation to dino_pcihost_init()

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-5-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

[PULL 07/53] dino: move PCI bus master address space setup to dino_pcihost_realize()

2022-05-08 Thread Mark Cave-Ayland
Add a new dino_pcihost_unrealize() function to remove the address space when the device is unrealized. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-8-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland ---

[PULL 05/53] dino: add memory-as property containing a link to the memory address space

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller Message-Id: <20220504092600.10048-6-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/hppa/dino.c

[PULL 01/53] dino: checkpatch fixes

2022-05-08 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Acked-by: Helge Deller Message-Id: <20220504092600.10048-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/hppa/dino.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/hppa/dino.c

[PULL 00/53] qemu-sparc queue 20220508

2022-05-08 Thread Mark Cave-Ayland
The following changes since commit f1336649156cf57f5d874a98e619fb362e3fcb59: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-05-07 06:14:16 -0500) are available in the Git repository at: https://github.com/mcayland/qemu.git tags/qemu-sparc-20220508 for you

Re: Possible bug in Aarch64 single-stepping

2022-05-08 Thread Chris Howard
On 8. May 2022, at 14:08, Peter Maydell wrote: > > On Sat, 7 May 2022 at 14:44, Chris Howard wrote: >> >> Hi, I’m writing a simple debugger in assembly code for the Raspberry Pi 3B >> (in aarch64). >> >> I’m using QEMU 7.0.0. Everything is running in EL1. (I have MDE and KDE set >> in

Re: Possible bug in Aarch64 single-stepping [PATCH]

2022-05-08 Thread Chris Howard
On 8. May 2022, at 14:18, Peter Maydell wrote: > On Sat, 7 May 2022 at 15:18, Chris Howard wrote: >> PS. In plain gdb (ie. no nice user interface) a large number (but not all) >> of the system registers gets displayed after each step. It would be nice if >> these were sorted in some way. At

[PATCH] hw/usb/hcd-ehci: fix writeback order

2022-05-08 Thread Arnout Engelen
The 'active' bit passes control over a qTD between the guest and the controller: set to 1 by guest to enable execution by the controller, and the controller sets it to '0' to hand back control to the guest. ehci_state_writeback write two dwords to main memory using DMA: the third dword of the qTD

Re: iotests and python dependencies

2022-05-08 Thread Paolo Bonzini
If we want to provide an installable rpm in Fedora then yes; but we can leave distribution to pypi and use a bundled copy in the virtual environment that is used to run tests. Paolo Il 5 maggio 2022 17:57:24 CEST, "Daniel P. Berrangé" ha scritto: >On Thu, May 05, 2022 at 05:50:00PM +0200,

Re: [PATCH v2 00/50] hppa: general improvements and tidy-ups

2022-05-08 Thread Richard Henderson
On 5/8/22 04:21, Mark Cave-Ayland wrote: Richard, thanks for taking the time to look over this (rather large) patchset. I've replied to your comments, and from what I can see the v2 patchset should be fine to merge. Are you happy for me to go ahead and send a PR with that and the artist fixes?

Re: Possible bug in Aarch64 single-stepping

2022-05-08 Thread Peter Maydell
On Sun, 8 May 2022 at 13:18, Peter Maydell wrote: > > Introduction > > This document will explain how setup Mutt email client using OAuth2 > (modern authentication) to access your emails. Argh, sorry about this. I mis-clicked something and pasted a load of bogus text :-( -- PMM

Re: Possible bug in Aarch64 single-stepping

2022-05-08 Thread Peter Maydell
Introduction This document will explain how setup Mutt email client using OAuth2 (modern authentication) to access your emails. Authentication will be done using "bearer tokens" instead of a combination of a username and an application password. You can find more details about bearer tokens and

Re: Possible bug in Aarch64 single-stepping

2022-05-08 Thread Peter Maydell
On Sat, 7 May 2022 at 14:44, Chris Howard wrote: > > Hi, I’m writing a simple debugger in assembly code for the Raspberry Pi 3B > (in aarch64). > > I’m using QEMU 7.0.0. Everything is running in EL1. (I have MDE and KDE set > in MDSCR_EL1). > > I’m coming across Unexpected Behaviour when

[PATCH 2/3] hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug()

2022-05-08 Thread Bernhard Beschow
The comment is based on commit message ae4d2eb273b167dad748ea4249720319240b1ac2 'xen-platform: add missing disk unplug option'. Since it seems to describe design decisions and limitations that still apply it seems worth having. Signed-off-by: Bernhard Beschow --- hw/ide/piix.c | 11 +++

[PATCH 0/3] PIIX3-IDE XEN cleanup

2022-05-08 Thread Bernhard Beschow
This patch series first removes the redundant "piix3-ide-xen" device class and then moves a XEN-specific helper function from PIIX3 code to XEN code. The idea is to decouple PIIX3-IDE and XEN and to compile XEN-specific bits only if XEN support is enabled. Testing done: 'qemu-system-x86_64 -M pc

[PATCH 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()

2022-05-08 Thread Bernhard Beschow
This function was declared in a generic and public header, implemented in a device-specific source file but only used in xen_platform. Given its 'aux' parameter, this function is more xen-specific than piix-specific. Also, the hardcoded magic constants seem to be generic and related to PCIIDEState

[PATCH 1/3] hw/ide/piix: Remove redundant "piix3-ide-xen" device class

2022-05-08 Thread Bernhard Beschow
Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci generic class init function' already resolved redundant code which in turn rendered piix3-ide-xen redundant. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 3 +-- hw/ide/piix.c | 7 --- 2 files changed, 1

[Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2022-05-08 Thread Andrii
Found the same problem using Gnome boxes, as I understand it uses QEMU. Error I see in gnome boxes when I'm trying to install windows 10 vm: SYSTEM THREAD EXCEPTION NOT HANDLED Fresh install of Ubuntu 22.04 CPU: AMD Ryzen 7 1700 The solution posted by asd fghjkl (ryzen27) worked for me too:

[PATCH v2 3/5] net: slirp: switch to slirp_new

2022-05-08 Thread Paolo Bonzini
Replace slirp_init with slirp_new, so that a more recent cfg.version can be specified. Only support version 3 of the configuration for simplicity, corresponding to a minimum slirp version of 4.3.0. Signed-off-by: Paolo Bonzini --- meson.build | 2 +- net/slirp.c | 27

[PATCH v2 5/5] net: slirp: allow CFI with libslirp >= 4.7

2022-05-08 Thread Paolo Bonzini
slirp 4.7 introduces a new CFI-friendly timer callback that does not pass function pointers within libslirp as callbacks for timers. Check the version number and, if it is new enough, allow using CFI even with a system libslirp. Reviewed-by: Samuel Thibault Reviewed-by: Marc-André Lureau

[PATCH v2 4/5] net: slirp: add support for CFI-friendly timer API

2022-05-08 Thread Paolo Bonzini
libslirp 4.7 introduces a CFI-friendly version of the .timer_new callback. The new callback replaces the function pointer with an enum; invoking the callback is done with a new function slirp_handle_timer. Support the new API so that CFI can be made compatible with using a system libslirp.

[PATCH v2 1/5] slirp: bump submodule past 4.7 release

2022-05-08 Thread Paolo Bonzini
Version 4.7 of slirp provides a new timer API that works better with CFI, together with several other improvements: * Allow disabling the internal DHCP server !22 * Support Unix sockets in hostfwd !103 * IPv6 DNS proxying support !110 * bootp: add support for UEFI HTTP boot !111 and bugfixes.

[PATCH v2 0/5] net: support for CFI with libslirp >= 4.7

2022-05-08 Thread Paolo Bonzini
Content-Type: text/plain Up until now, a CFI-enabled build would require slirp to be compiled as a static library, using the version that is bundled together with QEMU. This is because slirp registers functions as callbacks for QEMU Timers and, when using a system-wide shared libslirp, the type

[PATCH v2 2/5] net: slirp: introduce a wrapper struct for QemuTimer

2022-05-08 Thread Paolo Bonzini
This struct will be extended in the next few patches to support the new slirp_handle_timer() call. For that we need to store an additional "int" for each SLIRP timer, in addition to the cb_opaque. Reviewed-by: Samuel Thibault Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini ---

Re: [PATCH] mos6522: fix linking error when CONFIG_MOS6522 is not set

2022-05-08 Thread Mark Cave-Ayland
On 07/05/2022 00:44, Murilo Opsfelder Araújo wrote: On 5/2/22 06:43, Mark Cave-Ayland wrote: On 30/04/2022 00:31, Murilo Opsfelder Araujo wrote: When CONFIG_MOS6522 is not set, building ppc64-softmmu target fails: /usr/bin/ld: libqemu-ppc64-softmmu.fa.p/monitor_misc.c.o:(.data+0x1158):

Re: [PATCH 0/3] artist: minor fixes and performance improvement

2022-05-08 Thread Mark Cave-Ayland
On 05/05/2022 13:26, Helge Deller wrote: On 5/4/22 17:37, Mark Cave-Ayland wrote: Patch 1 updates artist.c to fix some style issues and ensure that artist.c passes checkpatch for the remainder of the patchset, whilst patch 2 removes the ROP8OFF() macro which is currently unused. Finally

Re: [PATCH v2 00/50] hppa: general improvements and tidy-ups

2022-05-08 Thread Mark Cave-Ayland
On 04/05/2022 10:25, Mark Cave-Ayland wrote: This patchset started off when I noticed that dino.c was accessing parent_obj directly rather than using a QOM cast. After fixing that I noticed quite a few other improvements that could be done to bring hppa up to our recommended coding standards.

Re: [PATCH v2 42/50] lasi: move from hw/hppa to hw/misc

2022-05-08 Thread Mark Cave-Ayland
On 08/05/2022 04:07, Richard Henderson wrote: On 5/4/22 04:25, Mark Cave-Ayland wrote: Move the LASI device implementation from hw/hppa to hw/misc so that it is located with all the other miscellaneous devices. Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller ---   MAINTAINERS 

Re: [PATCH v2 39/50] lasi: use constants for device register offsets

2022-05-08 Thread Mark Cave-Ayland
On 08/05/2022 04:04, Richard Henderson wrote: On 5/4/22 04:25, Mark Cave-Ayland wrote: Instead of generating the offset based upon the physical address of the register, add constants for each of the device registers to lasi.h and update lasi.c to use them. Signed-off-by: Mark Cave-Ayland

Re: [PATCH v2 35/50] lasi: move second serial port initialisation to machine.c

2022-05-08 Thread Mark Cave-Ayland
On 08/05/2022 03:50, Richard Henderson wrote: On 5/4/22 04:25, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Acked-by: Helge Deller ---   hw/hppa/lasi.c    | 8   hw/hppa/machine.c | 7 +++   2 files changed, 7 insertions(+), 8 deletions(-) In that it is code