On Mon, Jan 30, 2023 at 1:32 PM Michael S. Tsirkin wrote:
>
> On Mon, Jan 30, 2023 at 10:15:12AM +0800, Xuan Zhuo wrote:
> > On Sun, 29 Jan 2023 07:15:47 -0500, "Michael S. Tsirkin"
> > wrote:
> > > On Sun, Jan 29, 2023 at 08:03:42PM +0800, Xuan Zhuo wrote:
> > > > On Sun, 29 Jan 2023 06:57:29
On Monday, January 30, 2023 1:26 PM, Ackerley Tng wrote:
>
> > +static int restrictedmem_getattr(struct user_namespace *mnt_userns,
> > +const struct path *path, struct kstat *stat,
> > +u32 request_mask, unsigned int query_flags)
> {
> > +
On Mon, Jan 30, 2023 at 11:53:18AM +0800, Jason Wang wrote:
> On Mon, Jan 30, 2023 at 11:42 AM Xuan Zhuo wrote:
> >
> > On Mon, 30 Jan 2023 11:01:40 +0800, Jason Wang wrote:
> > > On Sun, Jan 29, 2023 at 3:44 PM Xuan Zhuo
> > > wrote:
> > > >
> > > > On Sun, 29 Jan 2023 14:23:21 +0800, Jason
Peter Xu wrote:
> When a ramblock is backed by hugetlbfs and the user specified using
> double-map feature, we trap the faults on these regions using minor mode.
> Teach QEMU about that.
>
> Add some sanity check on the fault flags when receiving a uffd message.
> For minor fault trapped ranges,
On 1/29/23 16:03, LIU Zhiwei wrote:
Thanks. It's a bug. We should load all memory addresses to local TCG temps
first.
Do you think we should probe all the memory addresses for the store pair instructions? If
so, can we avoid the use of a helper function?
Depends on what the hardware does.
On Mon, Jan 30, 2023 at 10:15:12AM +0800, Xuan Zhuo wrote:
> On Sun, 29 Jan 2023 07:15:47 -0500, "Michael S. Tsirkin"
> wrote:
> > On Sun, Jan 29, 2023 at 08:03:42PM +0800, Xuan Zhuo wrote:
> > > On Sun, 29 Jan 2023 06:57:29 -0500, "Michael S. Tsirkin"
> > > wrote:
> > > > On Sun, Jan 29, 2023
+static int restrictedmem_getattr(struct user_namespace *mnt_userns,
+const struct path *path, struct kstat *stat,
+u32 request_mask, unsigned int query_flags)
+{
+ struct inode *inode = d_inode(path->dentry);
+ struct
Peter Xu wrote:
> Add a RAMBlock.host_mirror for all the hugetlbfs backed guest memories.
> It'll be used to remap the same region twice and it'll be used to service
> page faults using UFFDIO_CONTINUE.
>
> To make sure all accesses to these ranges will generate minor page faults
> not missing
Peter Xu wrote:
> Let it replace the old qemu_ram_pagesize_largest() just to fetch the page
> sizes using migration_ram_pagesize(), because it'll start to consider
> double mapping effect in migrations.
>
> Also don't account the ignored ramblocks as they won't be migrated.
>
> Signed-off-by:
Peter Xu wrote:
> Migration may not want to recognize memory chunks in page size of the host
> only, but sometimes we may want to recognize the memory in smaller chunks
> if e.g. they're doubly mapped as both huge and small.
>
> In those cases we'll prefer to assume the memory page size is always
Peter Xu wrote:
> Add a new cap to allow mapping hugetlbfs backed RAMs in small page sizes.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
> +bool migrate_hugetlb_doublemap(void)
> +{
> +MigrationState *s = migrate_get_current();
> +
> +return
Peter Xu wrote:
> Add a helper to do mmap() for a ramblock based on the cached informations.
>
> A trivial thing to mention is we need to move ramblock->fd setup to be
> earlier, before the ramblock_file_map() call, because it'll need to
> reference the fd being mapped. However that should not
Peter Xu wrote:
> This allows us to have RAM_READONLY to be set in ram_flags to show that
> this ramblock can only be read not write.
>
> We used to pass in readonly boolean along the way for allocating the
> ramblock, now let it be together with the rest ramblock flags.
>
> The main purpose of
Peter Xu wrote:
> We do proper page size alignment for file backed mmap()s for ramblocks.
> Even if it's as simple as that, cache the value because it'll be used in
> multiple places.
>
> Since at it, drop size for file_ram_alloc() and just use max_length because
> that's always true for
Peter Xu wrote:
> This value was only used for mmap() when we want to map at a specific
> offset of the file for memory. To be prepared that we might do another map
> upon the same range for whatever reason, cache the offset so we know how to
> map again on the same range.
>
> Signed-off-by:
Peter Xu wrote:
> MADV_COLLAPSE is a new madvise() on Linux. Define it.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Peter Xu wrote:
> MADV_SPLIT is a new madvise() on Linux. Define QEMU_MADV_SPLIT.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
You can maintain the reviewed-by even if you collapsed with next one as
David suggests.
Peter Xu wrote:
> This will allow qemu/madvise.h to always include linux/mman.h under the
> linux-headers/.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Peter Xu wrote:
> Returns true for a hugetlbfs mapping, false otherwise.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Peter Xu wrote:
> Without it, we never have CONFIG_LINUX defined even if on linux, so
> linux/mman.h is never really included.
>
> Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Markus is working on this right now, Markus?
Markus Armbruster wrote:
> Commit bd688fc931 "accel: introduce accelerator blocker API" aded
> include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS
> covers the latter in section "Guest CPU Cores (other accelerators) /
> Overall", but not the former. Fix that.
>
>
Markus Armbruster wrote:
> Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface
> helpers" added util/userfaultfd.c without covering it in MAINTAINERS.
> Add it to section "Migration".
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> For example, avoid when TCG is disabled:
>
> $ make check-qtest-aarch64
> ...
> 20/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/migration-test
> qemu-system-aarch64: -accel tcg: invalid accelerator tcg
>
> Reviewed-by: Dr. David Alan Gilbert
>
Philippe Mathieu-Daudé wrote:
> Part 4/4: Convert rest of options.
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Part 3/4: Convert accelerator options.
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Part 2/4: Convert shmem option.
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Again, much nicer that what was there.
Philippe Mathieu-Daudé wrote:
> Part 1/4: Convert memory & machine options.
>
> Signed-off-by: Philippe Mathieu-Daudé
Much nicer.
Reviewed-by: Juan Quintela
Philippe Mathieu-Daudé wrote:
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
I am assuming that you will pull this patches through tests tree, not
migration tree.
Otherwise, let me know.
Philippe Mathieu-Daudé wrote:
> This slighly simplify the logic, and eases the following conversion.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Richard Henderson
Reviewed-by: Juan Quintela
Peter Xu wrote:
> Commit d9e474ea56 overlooked the case where the target psize is even larger
> than the host psize. One example is Alpha has 8K page size and migration
> will start to crash the source QEMU when running Alpha migration on x86.
>
> Fix it by detecting that case and set host
On Thu, Jan 26, 2023 at 12:25 AM Alexandre Ghiti wrote:
>
> The 'mmu-type' should reflect what the hardware is capable of so use the
> new satp_mode field in RISCVCPUConfig to do that.
>
> Signed-off-by: Alexandre Ghiti
> Reviewed-by: Andrew Jones
> Reviewed-by: Alistair Francis
> ---
>
On Thu, Jan 26, 2023 at 12:24 AM Alexandre Ghiti wrote:
>
> Currently, the max satp mode is set with the only constraint that it must be
> implemented in qemu, i.e. set in valid_vm_1_10_[32|64].
nits: s/qemu/QEMU/g
>
> But we actually need to add another level of constraint: what the hw is
>
Jiang Jiacheng wrote:
> To support query migration thread infomation, save and delete
> thread information at thread creation and end.
>
> Signed-off-by: Jiang Jiacheng
Don't disagree with this, but if we create this on the sending side, why
this is not needed for the multifd_recv_threads?
Jiang Jiacheng wrote:
> Introduce interface query-migrationthreads. The interface is use
> with the migration thread name reported by qemu and returns with
> migration thread name and its pid.
> Introduce threadinfo.c to manage threads with migration.
>
> Signed-off-by: Jiang Jiacheng
I like
On Thu, Jan 26, 2023 at 12:23 AM Alexandre Ghiti wrote:
>
> RISC-V specifies multiple sizes for addressable memory and Linux probes for
> the machine's support at startup via the satp CSR register (done in
> csr.c:validate_vm).
>
> As per the specification, sv64 must support sv57, which in turn
Jiang Jiacheng wrote:
> Report migration thread name to libvirt in order to
> support query migration thread infomation by its name.
>
> Signed-off-by: Jiang Jiacheng
> ---
> migration/migration.c | 3 +++
> migration/multifd.c | 5 -
> qapi/migration.json | 12
> 3 files
Markus Armbruster wrote:
> Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface
> helpers" added util/userfaultfd.c without covering it in MAINTAINERS.
> Add it to section "Migration".
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> Tracked down with the help of scripts/clean-includes.
>
> Signed-off-by: Markus Armbruster
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index b9a37ef255..8b7d1af75d 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@
Markus Armbruster wrote:
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Juan Quintela
Markus Armbruster wrote:
> "Dr. David Alan Gilbert" writes:
>
>> * Markus Armbruster (arm...@redhat.com) wrote:
>>> "Dr. David Alan Gilbert" writes:
>>>
>>> > * Markus Armbruster (arm...@redhat.com) wrote:
>>> >> Clean up includes so that osdep.h is included first and headers
>>> >> which it
On Mon, Jan 30, 2023 at 11:42 AM Xuan Zhuo wrote:
>
> On Mon, 30 Jan 2023 11:01:40 +0800, Jason Wang wrote:
> > On Sun, Jan 29, 2023 at 3:44 PM Xuan Zhuo
> > wrote:
> > >
> > > On Sun, 29 Jan 2023 14:23:21 +0800, Jason Wang
> > > wrote:
> > > > On Sun, Jan 29, 2023 at 10:52 AM Xuan Zhuo
>
On Mon, 30 Jan 2023 11:01:40 +0800, Jason Wang wrote:
> On Sun, Jan 29, 2023 at 3:44 PM Xuan Zhuo wrote:
> >
> > On Sun, 29 Jan 2023 14:23:21 +0800, Jason Wang wrote:
> > > On Sun, Jan 29, 2023 at 10:52 AM Xuan Zhuo
> > > wrote:
> > > >
> > > > Check whether it is per-queue reset state in
On Sun, Jan 29, 2023 at 3:44 PM Xuan Zhuo wrote:
>
> On Sun, 29 Jan 2023 14:23:21 +0800, Jason Wang wrote:
> > On Sun, Jan 29, 2023 at 10:52 AM Xuan Zhuo
> > wrote:
> > >
> > > Check whether it is per-queue reset state in virtio_net_flush_tx().
> > >
> > > Before per-queue reset, we need to
Hi Frediano, Gerd,
>
> Il giorno mar 24 gen 2023 alle ore 06:41 Kasireddy, Vivek
> ha scritto:
> >
> > + Frediano
> >
> > Hi Gerd,
> >
> > >
> > > Hi,
> > >
> > > > Here is the flow of things from the Qemu side:
> > > > - Call gl_scanout (to update the fd) and gl_draw_async just like
> > > >
On Sun, 29 Jan 2023 07:15:47 -0500, "Michael S. Tsirkin"
wrote:
> On Sun, Jan 29, 2023 at 08:03:42PM +0800, Xuan Zhuo wrote:
> > On Sun, 29 Jan 2023 06:57:29 -0500, "Michael S. Tsirkin"
> > wrote:
> > > On Sun, Jan 29, 2023 at 04:23:08PM +0800, Xuan Zhuo wrote:
> > > > On Sun, 29 Jan 2023
On 2023/1/25 4:44, Richard Henderson wrote:
On 1/24/23 09:59, Christoph Muellner wrote:
+static bool gen_loadpair_tl(DisasContext *ctx, arg_th_pair *a, MemOp
memop,
+ int shamt)
+{
+ TCGv rd1 = dest_gpr(ctx, a->rd1);
+ TCGv rd2 = dest_gpr(ctx, a->rd2);
+
On Wed, Jan 25, 2023 at 7:23 AM Daniel Henrique Barboza
wrote:
>
> Hi,
>
> These are the last 3 patches from the series
>
> "[PATCH v3 0/7] riscv: fdt related cleanups"
>
> That can be sent in separate from the fdt work. Patches are all acked.
>
> Changes from v3:
> - patches 1,2,3:
> - former
On 1/25/23 6:19 PM, Chuck Zmudzinski wrote:
> On 1/25/2023 6:37 AM, Anthony PERARD wrote:
>> On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote:
>> > I call attention to the commit message of the first patch which points
>> > out that using the "pc" machine and adding the xen
On Thu, Jan 26, 2023 at 10:03 PM Bin Meng wrote:
>
> On Tue, Jan 24, 2023 at 9:42 AM Alistair Francis wrote:
> >
> > On Tue, Jan 24, 2023 at 11:24 AM Bin Meng wrote:
> > >
> > > On Mon, Jan 23, 2023 at 11:58 AM Alistair Francis
> > > wrote:
> > > >
> > > > From: Alistair Francis
> > > >
> > >
On Thu, Jan 26, 2023 at 10:07 PM Bin Meng wrote:
>
> Hi Alistair,
>
> On Mon, Jan 16, 2023 at 12:28 PM Alistair Francis
> wrote:
> >
> > On Sat, Jan 14, 2023 at 11:41 PM Bin Meng wrote:
> > >
> > > On Sat, Jan 14, 2023 at 1:18 AM Daniel Henrique Barboza
> > > wrote:
> > > >
> > > > Recent
On Sat, Jan 28, 2023 at 6:37 AM Deepak Gupta wrote:
>
> Please dis-regard this.
> I've sent the patch to qemu-ri...@nongnu.org
That's not entirely correct either.
You can run the `./scripts/get_maintainer.pl` script on your patch to
get the email addresses to send this patch to. qemu-devel is
On Wed, Jan 11, 2023 at 12:08:26 +, Daniel P. Berrangé wrote:
> First, I find the test to be a little unreliable the first few
> times it is ran. I ran it in a loop 20 times and it got more
> stable results. Looking at just the QTree lines I get something
> typically like:
Agreed, this is a
On Wed, Jan 25, 2023 at 15:58:25 +, Daniel P. Berrangé wrote:
> On Wed, Jan 11, 2023 at 12:34:29PM +, Daniel P. Berrangé wrote:
> > On Tue, Jan 10, 2023 at 10:55:36PM -0500, Emilio Cota wrote:
> > > qemu-user can hang in a multi-threaded fork. One common
> > > reason is that when creating
On Wed, Jan 11, 2023 at 12:10:53 +, Daniel P. Berrangé wrote:
> On Tue, Jan 10, 2023 at 10:55:36PM -0500, Emilio Cota wrote:
> > Performance impact on linux-user:
> > - ~2% slowdown in spec06
> > - 1.05% slowdown in Nbench-int
> > - 4.51% slowdown in Nbench-fp
>
> What do you get *before*
On Thu, Dec 01, 2022 at 10:49:27 +, Alex Bennée wrote:
> Emilio Cota writes:
> > On Tue, Oct 04, 2022 at 13:00:47 +0100, Daniel P. Berrangé wrote:
> > (snip)
> >> Can't say I especially like this but I'm out of other ideas for how
> >> to guarantee a solution. Users can't set env vars prior
On Wed, Jan 25, 2023 at 5:51 AM Christoph Müllner
wrote:
>
>
>
> On Tue, Jan 24, 2023 at 6:31 PM Christoph Müllner
> wrote:
>>
>>
>>
>> On Mon, Jan 23, 2023 at 11:50 PM Alistair Francis
>> wrote:
>>>
>>> On Sat, Dec 24, 2022 at 4:09 AM Christoph Muellner
>>> wrote:
>>> >
>>> > From:
Hi Shreyansh, Gerd, and Laurent,
The last virtio-sound RFC was sent in February last year. It was a
spare time project. Understandably it's hard to complete the whole
thing on weekends, evenings, etc. So I wanted to suggest relaunching
the virtio-sound effort as a Google Summer of Code project.
This series is part of my work to bring the VIA south bridges to the PC machine
[1]. First it resolves a fixme in the device model by using the dedicated ACPI
interrupt register for SCI routing. It then enables the device model to switch
to ACPI. Finally, ACPI shutdown is implemented which guests
Signed-off-by: Bernhard Beschow
---
hw/isa/vt82c686.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index b0765d4ed8..2db54d1649 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -33,8 +33,10 @@
#include "qapi/error.h"
Adds missing functionality the real hardware supports.
Signed-off-by: Bernhard Beschow
---
hw/isa/vt82c686.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 2189be6f20..b0765d4ed8 100644
--- a/hw/isa/vt82c686.c
According to the PCI specification, the hardware is not supposed to use
PCI_INTERRUPT_PIN for interrupt routing. Use the dedicated ACPI
Interrupt Select register for SCI routing instead.
Signed-off-by: Bernhard Beschow
---
hw/isa/vt82c686.c | 42 ++
1
From: Marc-André Lureau
Now that qtest_qmp_add_client() works on win32, we can enable the VNC
test.
Signed-off-by: Marc-André Lureau
Acked-by: Thomas Huth
---
tests/qtest/vnc-display-test.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/tests/qtest/vnc-display-test.c
From: Marc-André Lureau
Whether it is SPICE, VNC, D-Bus, or the socket chardev, they all
actually expect a socket kind or will fail in different ways at runtime.
Throw an error early if the given 'add_client' fd is not a socket, and
close it to avoid leaks.
This allows to replace the close()
From: Marc-André Lureau
Manually implement a socketpair() function, using UNIX sockets and
simple peer credential checking.
QEMU doesn't make much use of socketpair, beside vhost-user which is not
available for win32 at this point. However, I intend to use it for
writing some new portable
From: Marc-André Lureau
The generated code doesn't quite handle the conditional arguments.
For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
conditions. See generated code in qmp_marshal_test_if_cmd().
Note that if there are multiple optional arguments at the last position,
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
tests/unit/test-io-channel-command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/unit/test-io-channel-command.c
From: Marc-André Lureau
A process with enough capabilities can duplicate a socket to QEMU.
Modify 'getfd' to import it and add it to the monitor fd list, so it can
be later used by other commands.
Note that we actually store the SOCKET in the FD list, appropriate care
must now be taken to use
From: Marc-André Lureau
Duplicate a socket to QEMU, and add it via 'getfd' on win32.
Signed-off-by: Marc-André Lureau
Acked-by: Thomas Huth
---
tests/qtest/libqtest.h | 2 --
tests/qtest/libqtest.c | 16 ++--
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git
From: Marc-André Lureau
docker.py is run during configure, and produces an error: No module
named 'pwd'.
Use a more portable and recommended alternative to lookup the user
"login name".
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
tests/docker/docker.py | 6
From: Marc-André Lureau
socat "PIPE:"" on Windows are named pipes, not fifo path names.
Fixes: commit 68406d10859 ("tests/unit: cleanups for test-io-channel-command")
Signed-off-by: Marc-André Lureau
---
tests/unit/test-io-channel-command.c | 6 ++
1 file changed, 6 insertions(+)
diff
From: Marc-André Lureau
Hi,
The following series first fixes a few tests on win32. The second part focuses
on 'add_client' support, by limiting its scope to sockets and adding win32
support. Finally, it enables vnc-display test on win32, to exercise the new code
paths and demonstrate the usage.
Am 24. Januar 2023 16:05:40 UTC schrieb Igor Mammedov :
>s/resolve/remove|drop/
>
>On Mon, 23 Jan 2023 15:49:29 +
>Bernhard Beschow wrote:
>
>> Am 23. Januar 2023 07:57:08 UTC schrieb "Philippe Mathieu-Daudé"
>> :
>> >Hi Bernhard,
>> >
>> >On 22/1/23 18:07, Bernhard Beschow wrote:
>> >>
On Sun, 29 Jan 2023 at 12:10, wrote:
>
> The patch fix bug abort settting CPUX86State::gdt::base on linux-user, the
> bug can write dirty data to emulated segment registers of x86
> Patch address:
> https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00142.html
> Bug description:
Am 25. Januar 2023 15:55:01 UTC schrieb Igor Mammedov :
>On Sun, 22 Jan 2023 18:07:22 +0100
>Bernhard Beschow wrote:
>
>> The PIIX4 datasheet defines the GPSTS register to be at offset 0x0c of the
>> power management I/O register block. This register block is represented
>> in the device model
Am 24. Januar 2023 16:55:37 UTC schrieb Igor Mammedov :
>On Sun, 22 Jan 2023 18:07:19 +0100
>Bernhard Beschow wrote:
>
>> The first thing ich9_pm_iospace_update() does is to set pm->pm_io_base to
>> the pm_io_base parameter.
>try to explain why 'pm->pm_io_base = 0' was there , what's changed
On Sun, 29 Jan 2023, Bernhard Beschow wrote:
Am 27. Januar 2023 19:22:49 UTC schrieb BALATON Zoltan :
On Fri, 27 Jan 2023, Bernhard Beschow wrote:
The variable is redundant to "phb" and is never used by its real type.
Also replace qdev_get_machine() with reference already passed to init
v6: nit fixes
v5: nit fixes
v4: split to multiple commits
add support for more than just luks-any in layered encryption
nit fixes
v3: further nit fixes suggested by @idryomov
v2: nit fixes suggested by @idryomov
Or Ozeri (3):
block/rbd: Remove redundant stack variable passphrase_len
Am 27. Januar 2023 19:22:49 UTC schrieb BALATON Zoltan :
>On Fri, 27 Jan 2023, Bernhard Beschow wrote:
>> The variable is redundant to "phb" and is never used by its real type.
>
>Also replace qdev_get_machine() with reference already passed to init
>function. (Maybe worth mentioning in commit
The patch fix bug abort settting CPUX86State::gdt::base on linux-user, the bug
can write dirty data to emulated segment registers of x86
Patch address:
https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00142.html
Bug description: https://gitlab.com/qemu-project/qemu/-/issues/1405
On Sun, 29 Jan 2023 06:57:29 -0500, "Michael S. Tsirkin"
wrote:
> On Sun, Jan 29, 2023 at 04:23:08PM +0800, Xuan Zhuo wrote:
> > On Sun, 29 Jan 2023 03:12:12 -0500, "Michael S. Tsirkin"
> > wrote:
> > > On Sun, Jan 29, 2023 at 03:28:28PM +0800, Xuan Zhuo wrote:
> > > > On Sun, 29 Jan 2023
On Sun, Jan 29, 2023 at 08:03:42PM +0800, Xuan Zhuo wrote:
> On Sun, 29 Jan 2023 06:57:29 -0500, "Michael S. Tsirkin"
> wrote:
> > On Sun, Jan 29, 2023 at 04:23:08PM +0800, Xuan Zhuo wrote:
> > > On Sun, 29 Jan 2023 03:12:12 -0500, "Michael S. Tsirkin"
> > > wrote:
> > > > On Sun, Jan 29, 2023
On Sun, 29 Jan 2023 07:15:47 -0500, "Michael S. Tsirkin"
wrote:
> On Sun, Jan 29, 2023 at 08:03:42PM +0800, Xuan Zhuo wrote:
> > On Sun, 29 Jan 2023 06:57:29 -0500, "Michael S. Tsirkin"
> > wrote:
> > > On Sun, Jan 29, 2023 at 04:23:08PM +0800, Xuan Zhuo wrote:
> > > > On Sun, 29 Jan 2023
On Sun, Jan 29, 2023 at 04:23:08PM +0800, Xuan Zhuo wrote:
> On Sun, 29 Jan 2023 03:12:12 -0500, "Michael S. Tsirkin"
> wrote:
> > On Sun, Jan 29, 2023 at 03:28:28PM +0800, Xuan Zhuo wrote:
> > > On Sun, 29 Jan 2023 02:25:43 -0500, "Michael S. Tsirkin"
> > > wrote:
> > > > On Sun, Jan 29, 2023
Am 27. Januar 2023 19:30:21 UTC schrieb BALATON Zoltan :
>On Fri, 27 Jan 2023, Bernhard Beschow wrote:
>> Signed-off-by: Bernhard Beschow
>
>Why? I'd rather replace locals with direct call to function as it's not
>expensive (just returns a global) and adding a local name to it is not much
Sometimes, `ep` is not enforced to 0 when `pid` is `USB_TOKEN_SETUP`. I
trigger this through dwc2
(https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg07179.html).
A similar bug was found
[here](https://gitlab.com/qemu-project/qemu/-/issues/119) and
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
hw/block/trace-events | 7 +++
hw/block/virtio-blk.c | 12
2 files changed, 19 insertions(+)
diff --git a/hw/block/trace-events b/hw/block/trace-events
index 2c45a62bd5..34be8b9135 100644
--- a/hw/block/trace-events
+++
Use scripts/update-linux-headers.sh to update virtio-blk headers
from Dmitry's "virtio-blk:add support for zoned block devices"
Linux patches.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Dmitry Fomichev
---
include/standard-headers/linux/virtio_blk.h | 158
Note: the virtio-blk headers isn't upstream in the kernel yet therefore
marked as an RFC. The VIRTIO spec changes have been merged. The Linux
virtio_blk guest driver patches are in Michael Tsirkin's vhost tree:
This patch extends virtio-blk emulation to handle zoned device commands
by calling the new block layer APIs to perform zoned device I/O on
behalf of the guest. It supports Report Zone, four zone oparations (open,
close, finish, reset), and Append Zone.
The VIRTIO_BLK_F_ZONED feature bit will only
Taking account of the new zone append write operation for zoned devices,
BLOCK_ACCT_APPEND enum is introduced as other I/O request type (read,
write, flush).
Signed-off-by: Sam Li
---
block/qapi-sysemu.c| 11
block/qapi.c | 15 ++
hw/block/virtio-blk.c
Add the documentation about the zoned device support to virtio-blk
emulation.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Dmitry Fomichev
---
docs/devel/zoned-storage.rst | 43 ++
Putting zoned/non-zoned BlockDrivers on top of each other is not
allowed.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
---
block.c | 19 +++
block/file-posix.c | 12
Add zoned device option to host_device BlockDriver. It will be presented only
for zoned host block devices. By adding zone management operations to the
host_block_device BlockDriver, users can use the new block layer APIs
including Report Zone and four zone management operations
(open, close,
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
block/file-posix.c | 3 +++
block/trace-events | 2 ++
2 files changed, 5 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index f661f202a1..5cf92608db 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -3272,6
We have added new block layer APIs of zoned block devices. Test it as
follows: Run each zone operation on a newly created null_blk device
and see whether the logs show the correct zone information. By:
$ ./tests/qemu-iotests/tests/zoned.sh
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
---
Use get_sysfs_str_val() to get the string value of device
zoned model. Then get_sysfs_zoned_model() can convert it to
BlockZoneModel type of QEMU.
Use get_sysfs_long_val() to get the long value of zoned device
information.
Signed-off-by: Sam Li
Reviewed-by: Hannes Reinecke
Reviewed-by: Stefan
raw-format driver usually sits on top of file-posix driver. It needs to
pass through requests of zone commands.
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
Reviewed-by: Dmitry Fomichev
---
block/raw-format.c | 13 +
Zoned Block Devices (ZBDs) devide the LBA space to block regions called zones
that are larger than the LBA size. It can only allow sequential writes, which
reduces write amplification in SSD, leading to higher throughput and increased
capacity. More details about ZBDs can be found at:
Signed-off-by: Sam Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Damien Le Moal
Reviewed-by: Hannes Reinecke
---
include/block/block-common.h | 43
1 file changed, 43 insertions(+)
diff --git a/include/block/block-common.h b/include/block/block-common.h
On 2023/01/28 22:46, Sriram Yagnaraman wrote:
Also add checks for RXDCTL/TXDCTL queue enable bits
Signed-off-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 42 +++---
hw/net/igb_regs.h | 3 ++-
2 files changed, 33 insertions(+), 12 deletions(-)
diff
1 - 100 of 103 matches
Mail list logo
