Hi,
On 20:13 Wed 13 Dec , Philippe Mathieu-Daudé wrote:
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Arnaud,
>
> (Cc'ing Peter and Luc)
>
> On 12/12/23 14:05, Arnaud Minier wrote:
> > Hi
>From 366ba4e21d8a11728957ccdcf974317e84fac140 Mon Sep 17 00:00:00 2001
From: wangmeiling
Date: Thu, 14 Dec 2023 07:22:08 +
Subject: [PATCH] Fix bugs when VM shutdown with virtio-gpu unplugged
Virtio-gpu malloc memory for the queue when it realized, but the queues was not
released when it
Hi Cleber,
On 12/13/23 21:08, Cleber Rosa wrote:
> Alex Bennée writes:
>
>> Cleber Rosa writes:
>>
>>> Based on many runs, the average run time for these 4 tests is around
>>> 250 seconds, with 320 seconds being the ceiling. In any way, the
>>> default 120 seconds timeout is inappropriate in
-display lists display backends, but does not tell their options.
Use the help messages from qemu-options.def, which include the list of
options.
Signed-off-by: Akihiko Odaki
---
include/ui/console.h | 1 -
system/vl.c | 11 ++-
ui/console.c | 20
Apparently the help entries were not merged when the patches got in.
Fixes: f844cdb99714 ("ui/cocoa: capture all keys and combos when mouse is
grabbed")
Signed-off-by: Akihiko Odaki
---
qemu-options.hx | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qemu-options.hx
Some options for -display cocoa were not described or not listed at all.
Reported-by: BALATON Zoltan
Signed-off-by: Akihiko Odaki
---
qemu-options.hx | 17 +
1 file changed, 17 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 28aa26ceb508..13359d12944a 100644
For the context, see:
https://lore.kernel.org/all/e3839467-6d4c-e8e6-9247-a71fafe55...@eik.bme.hu/
Signed-off-by: Akihiko Odaki
---
Akihiko Odaki (2):
qemu-options: Unify the help entries for cocoa
qemu-options: Tell more for -display cocoa
qemu-options.hx | 21
> --
> On Wed, Dec 13, 2023 at 04:27:40PM +, Srujana Challa wrote:
> > Hi Michael,
> >
> > While verifying virtio frontend drivers of guest OS on qemu with
> > vhost-vdpa backend, we came across feature bits VIRTIO_F_IN_ORDER
Hi Peter,
>-Original Message-
>From: Peter Maydell
>Sent: Tuesday, December 12, 2023 10:12 PM
>To: Boddu, Sai Pavan
>Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; qemu-
>bl...@nongnu.org; Alistair Francis ; Edgar E. Iglesias
>; Kevin Wolf ; Francisco
>Iglesias ;
> On 11-Dec-2023, at 11:27 AM, Thomas Huth wrote:
>
> On 08/12/2023 13.26, Ani Sinha wrote:
>> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow
>> up to 4096 vCPUs")
>> Linux kernel can support upto a maximum number of 4096 vCPUS when MAXSMP is
>> enabled in the
The guest surface needs to be updated with a blob scanout after resumed
from saved vm state if blob is enabled.
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff
If the guest state is paused before it gets a response for the current
scanout frame submission (resource-flush), it won't flush new frames
after being restored as it still waits for the old response, which is
accepted as a scanout render done signal. So it's needed to unblock
the current scanout
It is needed to unblock the pipeline only if there is an active dmabuf
to be rendered and the fence for it is not yet signaled.
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git
> On Dec 14, 2023, at 08:31, Dongli Zhang wrote:
>
> It is required to use error_report() instead of error_reportf_err(), if the
> prior function does not take local_err as the argument. As a result, the
> local_err is always NULL and segment fault may happen.
>
> vhost_scsi_start()
> ->
On 12/1/2023 7:00 PM, Markus Armbruster wrote:
Xiaoyao Li writes:
From: Isaku Yamahata
Three sha384 hash values, mrconfigid, mrowner and mrownerconfig, of a TD
can be provided for TDX attestation.
So far they were hard coded as 0. Now allow user to specify those values
via property
It is required to use error_report() instead of error_reportf_err(), if the
prior function does not take local_err as the argument. As a result, the
local_err is always NULL and segment fault may happen.
vhost_scsi_start()
-> vhost_scsi_set_endpoint(s) --> does not allocate local_err
->
On Wed, Dec 13, 2023 at 10:15 PM Stefan Hajnoczi wrote:
> Alternatives welcome! (A cleaner version of this approach might be to forbid
> cross-thread aio_set_fd_handler() calls and to refactor all
> aio_set_fd_handler() callers so they come from the AioContext's home thread.
> I'm starting to
Based-on: 20231205182011.1976568-1-stefa...@redhat.com
(https://lore.kernel.org/qemu-devel/20231205182011.1976568-1-stefa...@redhat.com/)
On Wed, Dec 13, 2023 at 10:15 PM Stefan Hajnoczi wrote:
> -/* If a read is in progress, just mark the node as deleted */
> -if (ctx->walking_handlers > 0) {
> -QLIST_INSERT_HEAD_RCU(>deleted_aio_handlers, node,
> node_deleted);
> -return false;
> +/* If polling was
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
fifth release candidate for the QEMU 8.2 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu.org/qemu-8.2.0-rc4.tar.xz
On Mon, Dec 11, 2023 at 11:48:05AM +0100, Fiona Ebner wrote:
> Am 08.12.23 um 09:32 schrieb Kevin Wolf:
> >
> > I'm not involved in it myself, but the kind of theme reminds me of this
> > downstream bug that Hanna analysed recently:
> >
> > https://issues.redhat.com/browse/RHEL-3934
> >
> >
TODO
- What about Windows?
Most of the event loop code runs in the AioContext's home thread. The
exceptions are aio_notify(), aio_bh_scheduler(), aio_set_fd_handler(),
etc. Amongst them, aio_set_fd_handler() is the most complicated because
the aio_handlers list must be both thread-safe and handle
Hanna and Fiona encountered a bug in aio_set_fd_handler(): there is no matching
io_poll_end() call upon removing an AioHandler when io_poll_begin() was
previously called. The missing io_poll_end() call leaves virtqueue
notifications disabled and the virtqueue's ioeventfd will never become
readable
Hanna Czenczek found the root cause for --device
virtio-scsi-pci,iothread= hangs across hotplug/unplug. When AioContext
polling has started on the virtqueue host notifier in the IOThread and
the main loop thread calls aio_set_fd_handler(), then the io_poll_end()
callback is not invoked on the
TODO further simplifications may be possible, like using none _RCU() macros for
the aio_handlers QLIST
Now that aio_set_fd_handler() uses a BH to schedule itself in remote
AioContexts it is no longer necessary to worry about multi-threading.
Replace the ctx->list_lock locked counter with a plain
Alex Bennée writes:
> Cleber Rosa writes:
>
>> The tests under machine_aarch64_virt.py do not need read-write access
>> to the ISOs. The ones under machine_aarch64_sbsaref.py, on the other
>> hand, will need read-write access, so let's give each test an unique
>> file.
>
> I think we are
Marcin Juszkiewicz writes:
> W dniu 8.12.2023 o 20:09, Cleber Rosa pisze:
>> The tests under machine_aarch64_virt.py do not need read-write access
>> to the ISOs. The ones under machine_aarch64_sbsaref.py, on the other
>> hand, will need read-write access, so let's give each test an unique
>>
Alex Bennée writes:
> Cleber Rosa writes:
>
>> Based on many runs, the average run time for these 4 tests is around
>> 250 seconds, with 320 seconds being the ceiling. In any way, the
>> default 120 seconds timeout is inappropriate in my experience.
>
> I would rather see these tests updated
Akihiko Odaki writes:
> On 2023/12/09 4:09, Cleber Rosa wrote:
>> Avocado's fetchasset plugin runs before the actual Avocado job (and
>> any test). It analyses the test's code looking for occurrences of
>> "self.fetch_asset()" in the either the actual test or setUp() method.
>> It's not able to
On Wed, 13 Dec 2023, Philippe Mathieu-Daudé wrote:
ping?
On 24/11/23 19:26, Philippe Mathieu-Daudé wrote:
Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these
fields has been converted to qdev properties, so don't need to be
Typo: fields have been
migrated:
static Property
On 13/12/23 18:20, Peter Maydell wrote:
On Wed, 13 Dec 2023 at 17:17, Philippe Mathieu-Daudé wrote:
Hi Peter,
On 12/12/23 15:18, Peter Maydell wrote:
On Sun, 12 Nov 2023 at 09:22, Nikita Ostrenkov wrote:
Hi; thanks for this patch, and sorry I haven't got round
to reviewing it earlier.
Hi Arnaud,
(Cc'ing Peter and Luc)
On 12/12/23 14:05, Arnaud Minier wrote:
Hi all,
I tried to implement the RCC (Reset and Clock Control) for the STM32L4x5_SoC
but ran into some problems regarding clock emulation in Qemu.
In this SoC, it is possible to change the source of several clocks used
On 13/12/23 19:04, Guenter Roeck wrote:
On 12/13/23 09:19, Philippe Mathieu-Daudé wrote:
Hi Guenter,
On 13/12/23 18:12, Peter Maydell wrote:
On Wed, 13 Dec 2023 at 01:49, Guenter Roeck wrote:
All tests using pxa2xx_mmc to access mmc cards on pxa2xx platforms
such as borzoi fail starting
Allow cpr-reboot for vfio if the guest is in the suspended runstate. The
guest drivers' suspend methods flush outstanding requests and re-initialize
the devices, and thus there is no device state to save and restore. The
user is responsible for suspending the guest before initiating cpr, such as
The existing notifiers should only apply to normal mode.
No functional change.
Signed-off-by: Steve Sistare
---
hw/net/virtio-net.c | 4
hw/vfio/migration.c | 3 +++
include/migration/misc.h | 1 +
migration/migration.c| 5 +
net/vhost-vdpa.c | 4
After calling notifiers, check if an error has been reported via
migrate_set_error, and halt the migration.
None of the notifiers call migrate_set_error at this time, so no
functional change.
Signed-off-by: Steve Sistare
---
include/migration/misc.h | 2 +-
migration/migration.c| 26
Allow cpr-reboot for vfio if the guest is in the suspended runstate. The
guest drivers' suspend methods flush outstanding requests and re-initialize
the devices, and thus there is no device state to save and restore. The
user is responsible for suspending the guest before initiating cpr, such as
On 12/13/23 09:19, Philippe Mathieu-Daudé wrote:
Hi Guenter,
On 13/12/23 18:12, Peter Maydell wrote:
On Wed, 13 Dec 2023 at 01:49, Guenter Roeck wrote:
All tests using pxa2xx_mmc to access mmc cards on pxa2xx platforms
such as borzoi fail starting with commit a2e1753b80 ("memory: prevent
On 12/13/23 09:12, Peter Maydell wrote:
On Wed, 13 Dec 2023 at 01:49, Guenter Roeck wrote:
All tests using pxa2xx_mmc to access mmc cards on pxa2xx platforms
such as borzoi fail starting with commit a2e1753b80 ("memory: prevent
dma-reentracy issues"). Disable reentrancy guard to fix the
On 29/10/23 22:08, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 11 ++
include/tcg/tcg-temp-internal.h | 27 +++---
include/tcg/tcg.h | 51 --
tcg/tcg.c | 64
On 29/10/23 22:08, Richard Henderson wrote:
These functions are no longer used outside tcg-op.c.
There are several that are completely unused, so remove them.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 47 -
tcg/tcg-op.c| 131
Hi Paolo,
No objection if I queue this patch?
On 21/11/23 21:31, Philippe Mathieu-Daudé wrote:
Allow building a qemu-system-foo binary with target-agnostic
only HW models.
Signed-off-by: Philippe Mathieu-Daudé
---
Although this is for 9.0, I wanted to post it today to celebrate :)
Once
ping?
On 24/11/23 20:22, Philippe Mathieu-Daudé wrote:
PCIQXLDevice::vram_size seems to be some shadow of
VGACommonState::vram_size. Just use the latter.
Signed-off-by: Philippe Mathieu-Daudé
---
RFC: I don't understand this field otherwise.
---
hw/display/qxl.h | 1 -
hw/display/qxl.c |
ping?
On 24/11/23 19:26, Philippe Mathieu-Daudé wrote:
Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these
fields has been converted to qdev properties, so don't need to be
migrated:
static Property sb16_properties[] = {
DEFINE_AUDIO_PROPERTIES(SB16State, card),
Hao Xiang writes:
> During live migration, if the latency between sender and receiver
> is high but bandwidth is high (a long and fat pipe), using a bigger
> packet size can help reduce migration total time. In addition, Intel
> DSA offloading performs better with a large batch task. Providing
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Wed, 13 Dec 2023, Akihiko Odaki wrote:
On 2023/12/13 0:38, Rene Engel wrote:
--- Ursprüngliche Nachricht ---
Von: Akihiko Odaki
Datum: 11.12.2023 06:39:35
An: Peter Maydell , Philippe Mathieu-Daudé
, Gerd Hoffmann , Marc-André Lureau
Betreff: [PATCH v6] ui/cocoa: Use NSWindow's
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Wed, 13 Dec 2023 at 17:17, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> On 12/12/23 15:18, Peter Maydell wrote:
> > On Sun, 12 Nov 2023 at 09:22, Nikita Ostrenkov
> > wrote:
> >
> > Hi; thanks for this patch, and sorry I haven't got round
> > to reviewing it earlier.
> >
> >>
Hi Guenter,
On 13/12/23 18:12, Peter Maydell wrote:
On Wed, 13 Dec 2023 at 01:49, Guenter Roeck wrote:
All tests using pxa2xx_mmc to access mmc cards on pxa2xx platforms
such as borzoi fail starting with commit a2e1753b80 ("memory: prevent
dma-reentracy issues"). Disable reentrancy guard to
Hi Peter,
On 12/12/23 15:18, Peter Maydell wrote:
On Sun, 12 Nov 2023 at 09:22, Nikita Ostrenkov wrote:
Hi; thanks for this patch, and sorry I haven't got round
to reviewing it earlier.
Signed-off-by: Nikita Ostrenkov
---
hw/misc/imx7_snvs.c | 59
On Wed, 13 Dec 2023 at 01:49, Guenter Roeck wrote:
>
> All tests using pxa2xx_mmc to access mmc cards on pxa2xx platforms
> such as borzoi fail starting with commit a2e1753b80 ("memory: prevent
> dma-reentracy issues"). Disable reentrancy guard to fix the problem.
>
> Fixes: a2e1753b80 ("memory:
ping?
On 14/11/23 17:31, Philippe Mathieu-Daudé wrote:
Hi,
While looking at Xen target-specific code, I noticed some
generic code used by x86 which is not implemented for ARM.
Maybe ARM machines don't need it, I don't know. But I
wanted to see if I can get this common code target agnostic
and
Hi Michael,
While verifying virtio frontend drivers of guest OS on qemu with vhost-vdpa
backend,
we came across feature bits VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA,
which are introduced in virtio 1.1 spec, are not yet enabled in qemu. These
feature flags
are very much useful for
On Thu, Dec 7, 2023 at 7:51 PM Si-Wei Liu wrote:
>
> Should help live migration downtime on source host. Below are the
> coalesced dma_unmap time series on 2 queue pair config (no
> dedicated descriptor group ASID for SVQ).
>
> 109531@1693367276.853503:vhost_vdpa_reset_device dev: 0x55c933926890
On Wed, Dec 13, 2023 at 04:27:40PM +, Srujana Challa wrote:
> Hi Michael,
>
> While verifying virtio frontend drivers of guest OS on qemu with vhost-vdpa
> backend,
> we came across feature bits VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA,
> which are introduced in virtio 1.1 spec, are
On 12/13/23 8:00 AM, Michael Tokarev wrote:
> The following patches are queued for QEMU stable v7.2.8:
>
> https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2
>
> Patch freeze is 2023-12-23, and the release is planned for 2023-12-25:
>
> https://wiki.qemu.org/Planning/7.2
>
> Please
Hi Nikita,
On 13/12/23 16:24, Nikita Ostrenkov wrote:
Signed-off-by: Nikita Ostrenkov
---
hw/misc/imx7_snvs.c | 70 +
hw/misc/trace-events| 4 +--
include/hw/misc/imx7_snvs.h | 7 +++-
3 files changed, 71 insertions(+), 10 deletions(-)
On Thu, Dec 7, 2023 at 7:51 PM Si-Wei Liu wrote:
>
> So that DMA batching API can operate on other ASID than 0.
>
> Signed-off-by: Si-Wei Liu
> ---
> hw/virtio/trace-events | 4 ++--
> hw/virtio/vhost-vdpa.c | 14 --
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff
On Thu, Dec 7, 2023 at 7:51 PM Si-Wei Liu wrote:
>
> So that the batching API can be called from other file
> externally than the local.
>
> Signed-off-by: Si-Wei Liu
> ---
> hw/virtio/vhost-vdpa.c | 21 +++--
> include/hw/virtio/vhost-vdpa.h | 3 +++
> 2 files changed,
On Thu, Dec 7, 2023 at 7:51 PM Si-Wei Liu wrote:
>
> Then it's possible to specify ASID when calling the DMA
> batching API. If the ASID to work on doesn't align with
> the ASID for ongoing transaction, the API will fail the
> request and return negative, and the transaction will
> remain intact
Hi Peter, all have RB's, with all i's dotted and t's crossed - steve
On 12/13/2023 10:30 AM, Steve Sistare wrote:
> Migration of a guest in the suspended runstate is broken. The incoming
> migration code automatically tries to wake the guest, which is wrong;
> the guest should end migration in
Currently, a vm in the suspended state is not completely stopped. The VCPUs
have been paused, but the cpu clock still runs, and runstate notifiers for
the transition to stopped have not been called. This causes problems for
live migration. Stale cpu timers_state is saved to the migration
Add an option to suspend the src in a-b-bootblock.S, which puts the guest
in S3 state after one round of writing to memory. The option is enabled by
poking a 1 into the suspend_me word in the boot block prior to starting the
src vm. Generate symbol offsets in a-b-bootblock.h so that the
A guest that is migrated in the suspended state automaticaly wakes and
continues execution. This is wrong; the guest should end migration in
the same state it started. The root cause is that the outgoing migration
code automatically wakes the guest, then saves the RUNNING runstate in
Migration of a guest in the suspended runstate is broken. The incoming
migration code automatically tries to wake the guest, which is wrong;
the guest should end migration in the same runstate it started. Further,
after saving a snapshot in the suspended state and loading it, the vm_start
fails.
Add a test case to verify that the suspended state is handled correctly by
live migration postcopy. The test suspends the src, migrates, then wakes
the dest.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
tests/qtest/migration-test.c | 20 +++-
1 file changed, 19
FYI for Markus and Blake. No change since V6 and V7.
- Steve
On 12/13/2023 10:30 AM, Steve Sistare wrote:
> Currently, a vm in the suspended state is not completely stopped. The VCPUs
> have been paused, but the cpu clock still runs, and runstate notifiers for
> the transition to stopped have
Define the vm_resume helper, for use in subsequent patches.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
include/sysemu/runstate.h | 9 +
system/cpus.c | 9 +
2 files changed, 18 insertions(+)
diff --git a/include/sysemu/runstate.h
Restoring a snapshot can break a suspended guest. Snapshots suffer from
the same suspended-state issues that affect live migration, plus they must
handle an additional problematic scenario, which is that a running vm must
remain running if it loads a suspended snapshot.
To save, the existing
Define a state object to capture events seen by migration tests, to allow
more events to be captured in a subsequent patch, and simplify event
checking in wait_for_migration_pass. No functional change.
Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
Reviewed-by: Daniel P. Berrangé
---
Add a state variable to remember if a vm previously transitioned into a
suspended state.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
include/sysemu/runstate.h | 2 ++
system/cpus.c | 15 +++
2 files changed, 17 insertions(+)
diff --git
Add a test case to verify that the suspended state is handled correctly
during live migration precopy. The test suspends the src, migrates, then
wakes the dest.
Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
---
tests/qtest/migration-helpers.c | 3 ++
Do not wake a suspended guest during bg_migration, and restore the prior
state at finish rather than unconditionally running. Allow the additional
state transitions that occur.
Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
---
migration/migration.c | 7 +--
When a vm transitions from running to suspended, runstate notifiers are
not called, so the notifiers still think the vm is running. Hence, when
we call vm_start to restore the suspended state, we call vm_state_notify
with running=1. However, some notifiers check for RUN_STATE_RUNNING.
They must
If the outgoing machine was previously suspended, propagate that to the
incoming side via global_state, so a subsequent vm_start restores the
suspended state. To maintain backward and forward compatibility, reclaim
some space from the runstate member.
Signed-off-by: Steve Sistare
Reviewed-by:
Signed-off-by: Nikita Ostrenkov
---
hw/misc/imx7_snvs.c | 70 +
hw/misc/trace-events| 4 +--
include/hw/misc/imx7_snvs.h | 7 +++-
3 files changed, 71 insertions(+), 10 deletions(-)
diff --git a/hw/misc/imx7_snvs.c b/hw/misc/imx7_snvs.c
Hi! Thanks for your feedback.
I've considered your comments and I'm sending a new patch.
вт, 12 дек. 2023 г. в 17:18, Peter Maydell :
> On Sun, 12 Nov 2023 at 09:22, Nikita Ostrenkov
> wrote:
>
> Hi; thanks for this patch, and sorry I haven't got round
> to reviewing it earlier.
>
> >
> On 13-Dec-2023, at 8:47 PM, Michael S. Tsirkin wrote:
>
> On Wed, Dec 13, 2023 at 04:14:00PM +0100, Gerd Hoffmann wrote:
>> Hi,
>>
>>> I agree, Gerd, going forward please include the diff of the
>>> disassemled AML.
>>
>> That is in patch 5/6 which updates the test data.
>>
>> take
On Wed, Dec 13, 2023 at 04:14:00PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > I agree, Gerd, going forward please include the diff of the
> > disassemled AML.
>
> That is in patch 5/6 which updates the test data.
>
> take care,
> Gerd
Oh I double checked and you are right, I'm not sure where
On 13/12/23 12:20, Anton Johansson wrote:
On 12/12/23, Philippe Mathieu-Daudé wrote:
We usually check target endianess before swapping values,
so target_words_bigendian() declaration makes sense in
"exec/tswap.h" with the target swapping helpers.
Remove "hw/core/cpu.h" when it was only
Hi,
> I agree, Gerd, going forward please include the diff of the
> disassemled AML.
That is in patch 5/6 which updates the test data.
take care,
Gerd
On 29/10/23 22:08, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
include/tcg/tcg-temp-internal.h | 29 +
tcg/tcg.c | 25 +
2 files changed, 30 insertions(+), 24 deletions(-)
Reviewed-by: Philippe
On 29/10/23 22:08, Richard Henderson wrote:
These are used within tcg-op.c and tcg-op-ldst.c.
There are no uses outside tcg/.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 7 ---
tcg/tcg-internal.h | 7 +++
2 files changed, 7 insertions(+), 7
On 29/10/23 22:08, Richard Henderson wrote:
These are used within tcg-op-vec.c and tcg/host/tcg-target.c.inc.
There are no uses outside tcg/.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 4
tcg/tcg-internal.h | 4
2 files changed, 4 insertions(+), 4
On 29/10/23 22:08, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 140 ++--
tcg/tcg-op.c| 116 ++
2 files changed, 137 insertions(+), 119 deletions(-)
Reviewed-by:
On 29/10/23 22:08, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 19 +++
tcg/tcg-op.c| 16
2 files changed, 19 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 29/10/23 22:08, Richard Henderson wrote:
This one is more complicated, combining 32-bit and 64-bit
expansion with C if instead of preprocessor #if.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 144 +-
tcg/tcg-op.c| 231
On Wed, Dec 13, 2023 at 08:09:29PM +0530, Ani Sinha wrote:
>
>
> > On 13-Dec-2023, at 8:03 PM, Michael S. Tsirkin wrote:
> >
> > On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote:
> >>
> >>
> >>> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann wrote:
> >>>
> >>> Signed-off-by: Gerd
Gentle reminder. Please let me know if there are any concerns or please
pull these patches for next update.
Thanks Babu
On 11/10/23 11:08, Babu Moger wrote:
Observed the following failure while booting the SEV-SNP guest and the
guest fails to boot with the smp parameters:
"-smp
On 12/1/23 12:51, Markus Armbruster wrote:
Review, anyone?
Only Vladimir
Maksim Davydov writes:
This script runs QEMU to obtain compat_props of machines and default
values of different types of drivers to produce comparison table. This
table can be used to compare machine types to
Thanks for reviewing
Sorry for replying late
On 12/1/23 12:49, Markus Armbruster wrote:
I apologize for the lateness of my review.
Maksim Davydov writes:
To control that creating new machine type doesn't affect the previous
types (their compat_props) and to check complex compat_props
> On 13-Dec-2023, at 8:03 PM, Michael S. Tsirkin wrote:
>
> On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote:
>>
>>
>>> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann wrote:
>>>
>>> Signed-off-by: Gerd Hoffmann
>>
>> Please combine this patch with patch 5. No need to do this
Hi,
On Tue, Aug 02, 2022 at 07:32:41PM -0700, Iris Chen wrote:
> From: Iris Chen
>
> Signed-off-by: Iris Chen
> ---
Are there any plans to submit a new version of this patch ?
Thanks,
Guenter
> configs/devices/arm-softmmu/default.mak | 1 +
> hw/arm/Kconfig | 5
On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote:
>
>
> > On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann wrote:
> >
> > Signed-off-by: Gerd Hoffmann
>
> Please combine this patch with patch 5. No need to do this separately.
Yes but since it's done - it's fine either way I think. No?
>
Provide explicit guidance on dealing with option parameters as arbitrary
strings containing commas, such as in "file=my,file" and "string=a,b". The
updated documentation emphasizes the need to double commas when they
appear within such parameters.
Resolves:
On 29/10/23 22:08, Richard Henderson wrote:
In addition to moving out of line, with CONFIG_DEBUG_TCG
mark them all noinline.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 252 +++-
tcg/tcg-op.c| 208
On 29/10/23 22:08, Richard Henderson wrote:
Encourage the compiler to tail-call rather than inline
across the dozens of opcode expanders.
Signed-off-by: Richard Henderson
---
tcg/tcg-op.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
Reviewed-by: Philippe
1 - 100 of 160 matches
Mail list logo
